[GitHub] lucenenet pull request #216: Add support for netstandard2.0 for Queries and ...

2018-10-01 Thread gabrieldelaparra
GitHub user gabrieldelaparra opened a pull request: https://github.com/apache/lucenenet/pull/216 Add support for netstandard2.0 for Queries and SandBox I was trying to use Lucene.Net on a side project with Net Core 2 and Blazor for front end. I needed the Queries and

[GitHub] lucenenet pull request #215: remove redundant termAtt initialization in Uppe...

2018-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/215 ---

[GitHub] lucenenet pull request #215: remove redundant termAtt initialization in Uppe...

2018-02-07 Thread igor-brylin
GitHub user igor-brylin opened a pull request: https://github.com/apache/lucenenet/pull/215 remove redundant termAtt initialization in UpperCaseFilter constructor Constructor of UpperCaseFilter has duplicated initalization code for termAttr field. I have modified

[GitHub] lucenenet pull request #214: Update ConcurrentMergeScheduler.cs

2017-12-21 Thread phillipc
GitHub user phillipc opened a pull request: https://github.com/apache/lucenenet/pull/214 Update ConcurrentMergeScheduler.cs Add a comment: Non-treatable exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/phillipc/lucenenet

[GitHub] lucenenet pull request #:

2017-09-15 Thread NightOwl888
Github user NightOwl888 commented on the pull request: https://github.com/apache/lucenenet/commit/34ef2ce56c48beeb36e3a608c5339b84b36a5414#commitcomment-24319196 Just thinking a couple of steps ahead. `IDictionary` doesn't inherit `IReadOnlyDictionary`.

[GitHub] lucenenet pull request #:

2017-09-15 Thread jeme
Github user jeme commented on the pull request: https://github.com/apache/lucenenet/commit/34ef2ce56c48beeb36e3a608c5339b84b36a5414#commitcomment-24318879 Does this make any sense to change?... The only thing it does is making the dictionary readonly for the ReplicatorService. If we

[GitHub] lucenenet pull request #211: fix null reference exception in mono on linux

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/211 ---

[GitHub] lucenenet pull request #209: RFC: LUCENENET-565: Porting of Lucene.Net.Repli...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/209 ---

[GitHub] lucenenet pull request #213: Add Lucene.Net.Contrib

2017-08-21 Thread hgupta9
GitHub user hgupta9 opened a pull request: https://github.com/apache/lucenenet/pull/213 Add Lucene.Net.Contrib Its impossible to find the nuget package for the user contributed code. I have therefore added the nuget link into the readme. You can merge this pull request into a Git

[GitHub] lucenenet pull request #212: LUCENENET-469 - enumerables

2017-08-14 Thread AndyPook
GitHub user AndyPook opened a pull request: https://github.com/apache/lucenenet/pull/212 LUCENENET-469 - enumerables See https://issues.apache.org/jira/projects/LUCENENET/issues/LUCENENET-469 for background. This is an early stage proposal for implementing IEnumerable on

[GitHub] lucenenet pull request #210: Corrected bug in Lifetime reference count

2017-08-02 Thread vvdb
Github user vvdb closed the pull request at: https://github.com/apache/lucenenet/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #210: Corrected bug in Lifetime reference count

2017-08-01 Thread vvdb
GitHub user vvdb opened a pull request: https://github.com/apache/lucenenet/pull/210 Corrected bug in Lifetime reference count The addFactory in ConcurrentDictionary's GetOrAdd isn't guaranteed to be called only once, yielding incorrect reference counts. Switched to a lazily

[GitHub] lucenenet pull request #209: RFC: LUCENENET-565: Porting of Lucene.Net.Repli...

2017-07-22 Thread jeme
GitHub user jeme opened a pull request: https://github.com/apache/lucenenet/pull/209 RFC: LUCENENET-565: Porting of Lucene.Net.Replicator Commit is for Review with comments about original Java Source for assistance. - [ ] RevisionFile.Size - Please change to `Length` to

[GitHub] lucenenet pull request #206: API Doc site generator using DocFx script

2017-06-30 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/206#discussion_r125003467 --- Diff: apidocs/docs.ps1 --- @@ -49,10 +49,17 @@ If ($FileExists -eq $False) { if ($Clean -eq 1) { Remove-Item (Join-Path -Path

[GitHub] lucenenet pull request #206: API Doc site generator using DocFx script

2017-06-30 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/206#discussion_r12420 --- Diff: apidocs/api/index.md --- @@ -129,6 +128,9 @@ index for all the files contained in a directory. SearchFiles.java prompts for

[GitHub] lucenenet pull request #208: LUCENE-5644: switch to simpler LIFO thread to T...

2017-06-27 Thread vvdb
Github user vvdb closed the pull request at: https://github.com/apache/lucenenet/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: [GitHub] lucenenet pull request #208: LUCENE-5644: switch to simpler LIFO thread to T...

2017-06-13 Thread Van Den Berghe, Vincent
Yes. I don't know why this appeared together with my pull request. I don't understand this system. Vincent -Original Message- From: synhershko [mailto:g...@git.apache.org] Sent: Tuesday, June 13, 2017 9:06 AM To: dev@lucenenet.apache.org Subject: [GitHub] lucenenet pull request #208

[GitHub] lucenenet pull request #208: LUCENE-5644: switch to simpler LIFO thread to T...

2017-06-13 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/208#discussion_r121596530 --- Diff: src/Lucene.Net/Document/Document.cs --- @@ -278,9 +279,17 @@ public string Get(string name) return null; }

[GitHub] lucenenet pull request #208: LUCENE-5644: switch to simpler LIFO thread to T...

2017-06-12 Thread vvdb
GitHub user vvdb opened a pull request: https://github.com/apache/lucenenet/pull/208 LUCENE-5644: switch to simpler LIFO thread to ThreadState allocator d… …uring indexing”. Technically, this is something from releases/lucene-solr/4.8.1, but profiling indicates it makes a

[GitHub] lucenenet pull request #207: API: Added ReferenceManager.AcquireContext()

2017-05-16 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/207 API: Added ReferenceManager.AcquireContext() Opening this as a pull request so the team can discuss this approach vs the previous `ExecuteSearch` method (that was inadvertently removed from

[GitHub] lucenenet pull request #206: API Doc site generator using DocFx script

2017-05-16 Thread Shazwazza
GitHub user Shazwazza opened a pull request: https://github.com/apache/lucenenet/pull/206 API Doc site generator using DocFx script I remember seeing on the mail list that getting API docs generated was still on the TODO list so here it is. This is a PR to build API documentation

[GitHub] lucenenet pull request #205: Made FSDirectory stale files set synchronized.

2017-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #205: Made FSDirectory stale files set synchronized.

2017-05-08 Thread pvginkel
GitHub user pvginkel opened a pull request: https://github.com/apache/lucenenet/pull/205 Made FSDirectory stale files set synchronized. `FSDirectory` has a hash set to track stale files. In the original Lucene source at e.g.

[GitHub] lucenenet pull request #203: API Work - Stabilization

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #191: Migrating Lucene.Net to .NET Core

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #204: Adding missing build configurations for highlig...

2017-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #204: Adding missing build configurations for highlig...

2017-03-25 Thread vvdb
GitHub user vvdb reopened a pull request: https://github.com/apache/lucenenet/pull/204 Adding missing build configurations for highlighter and highlighter test You can merge this pull request into a Git repository by running: $ git pull https://github.com/vvdb/lucenenet

[GitHub] lucenenet pull request #204: Adding missing build configurations for highlig...

2017-03-25 Thread vvdb
Github user vvdb closed the pull request at: https://github.com/apache/lucenenet/pull/204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #204: Adding missing build configurations for highlig...

2017-03-25 Thread vvdb
GitHub user vvdb opened a pull request: https://github.com/apache/lucenenet/pull/204 Adding missing build configurations for highlighter and highlighter test You can merge this pull request into a Git repository by running: $ git pull https://github.com/vvdb/lucenenet

[GitHub] lucenenet pull request #203: API Work - Stabilization

2017-01-24 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/203 API Work - Stabilization This is a branch of #191 and supersedes that pull request. To build this branch, see the instructions on #191. The plan is to work on the API here to keep

[GitHub] lucenenet pull request #202: Fix TermText property accessibility

2017-01-02 Thread konopka
Github user konopka closed the pull request at: https://github.com/apache/lucenenet/pull/202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #201: updating assemblyinfo files for nuget package m...

2016-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #201: updating assemblyinfo files for nuget package m...

2016-12-18 Thread wwb
GitHub user wwb opened a pull request: https://github.com/apache/lucenenet/pull/201 updating assemblyinfo files for nuget package metadata. Updating the AssemblyInfo files to provide better myget metadata for now. This should not conflict w/ #191. You can merge this pull request

[GitHub] lucenenet pull request #200: Adding nunit 3 console package to enable TeamCi...

2016-12-18 Thread wwb
Github user wwb closed the pull request at: https://github.com/apache/lucenenet/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #200: Adding nunit 3 console package to enable TeamCi...

2016-12-18 Thread wwb
GitHub user wwb opened a pull request: https://github.com/apache/lucenenet/pull/200 Adding nunit 3 console package to enable TeamCity to run the tests. Adding Nunit 3 console package to enable TeamCity to run the nunit 3.5 tests. You can merge this pull request into a Git

[GitHub] lucenenet pull request #199: Merge pull request #1 from apache/master

2016-12-18 Thread wwb
Github user wwb closed the pull request at: https://github.com/apache/lucenenet/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #199: Merge pull request #1 from apache/master

2016-12-18 Thread wwb
Github user wwb closed the pull request at: https://github.com/apache/lucenenet/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #199: Merge pull request #1 from apache/master

2016-12-18 Thread wwb
GitHub user wwb reopened a pull request: https://github.com/apache/lucenenet/pull/199 Merge pull request #1 from apache/master resync with upstream You can merge this pull request into a Git repository by running: $ git pull https://github.com/wwb/lucenenet master

[GitHub] lucenenet pull request #199: Merge pull request #1 from apache/master

2016-12-18 Thread wwb
GitHub user wwb opened a pull request: https://github.com/apache/lucenenet/pull/199 Merge pull request #1 from apache/master resync with upstream You can merge this pull request into a Git repository by running: $ git pull https://github.com/wwb/lucenenet master Alternatively

[GitHub] lucenenet pull request #194: Updating from NUnit 2.6.3 to NUnit 3.5.0

2016-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #196: Renamed hyphenation to Hyphenation

2016-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #198: Removing C# 6 features

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #197: Fixing build errors

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #198: Updating minimum Visual Studio version to 2015

2016-12-06 Thread conniey
GitHub user conniey opened a pull request: https://github.com/apache/lucenenet/pull/198 Updating minimum Visual Studio version to 2015 There are C# 6 features in use (ie.

[GitHub] lucenenet pull request #196: Renamed hyphenation to Hyphenation

2016-11-28 Thread DevMk
GitHub user DevMk opened a pull request: https://github.com/apache/lucenenet/pull/196 Renamed hyphenation to Hyphenation Renamed hyphenation to Hyphenation to fix build and run on case sensitive file systems You can merge this pull request into a Git repository by running: $

[GitHub] lucenenet pull request #174: Ported over Lucene.Net.Spatial

2016-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #195: Moving ICU dependent classes into a separate pr...

2016-11-24 Thread laimis
Github user laimis closed the pull request at: https://github.com/apache/lucenenet/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #195: Moving ICU dependent classes into a separate pr...

2016-11-23 Thread laimis
GitHub user laimis opened a pull request: https://github.com/apache/lucenenet/pull/195 Moving ICU dependent classes into a separate project Would this help to deal with ICU issues that people are encountering in using early versions of 4.8 port? Seems like a quick way to get past

[GitHub] lucenenet pull request #193: Completed Grouping Implementation

2016-11-09 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/193#discussion_r87320660 --- Diff: src/Lucene.Net.Core/Support/HashMap.cs --- @@ -125,9 +140,87 @@ public TValue AddIfAbsent(TKey key, TValue value) return

[GitHub] lucenenet pull request #192: Fixed terms boosting in multifield query

2016-11-03 Thread ecortese
GitHub user ecortese opened a pull request: https://github.com/apache/lucenenet/pull/192 Fixed terms boosting in multifield query Provided fixes for prefix terms, wildcard terms, fuzzy and range terms boosting when parsing a multifield query. Specific test cases were added

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-05 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r82028685 --- Diff: src/Lucene.Net.Core/Support/DataInputStream.cs --- @@ -0,0 +1,323 @@ +using System; +using System.IO; + +namespace

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-05 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r82028284 --- Diff: Lucene.Net.sln --- @@ -59,14 +60,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Lucene.Net.Suggest", "src\L EndProject

[GitHub] lucenenet pull request #188: Fixed 64 Failing Facet Tests and Finished Facet...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #187: Fixed 76 QueryParser Failing Tests

2016-10-04 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/187#discussion_r81840724 --- Diff: src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs --- @@ -883,7 +883,7 @@ private void Jj_rescan_token()

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-04 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r81838986 --- Diff: Lucene.Net.sln --- @@ -59,14 +60,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Lucene.Net.Suggest", "src\L EndProject

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-04 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r81839278 --- Diff: src/Lucene.Net.Core/Support/DataInputStream.cs --- @@ -0,0 +1,323 @@ +using System; +using System.IO; + +namespace

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-03 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/190 Ported Analysis.Stempel All 16 tests are passing. I ended up porting over `DataInputStream` and `DataOutputStream` and their corresponding interfaces from Java to save time. There

[GitHub] lucenenet pull request #189: Fixed 24 Failing Analaysis Tests + Completed Ch...

2016-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #186: Ported Misc (mostly), Suggest, and Memory

2016-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #188: Fixed 64 Failing Facet Tests and Finished Facet...

2016-09-28 Thread eladmarg
Github user eladmarg commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/188#discussion_r81025984 --- Diff: src/Lucene.Net.Facet/Taxonomy/LRUHashMap.cs --- @@ -100,19 +120,25 @@ public bool Put(TKey key, TValue value)

[GitHub] lucenenet pull request #188: Fixed 64 Failing Facet Tests and Finished Facet...

2016-09-28 Thread eladmarg
Github user eladmarg commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/188#discussion_r81009940 --- Diff: src/Lucene.Net.Facet/Taxonomy/LRUHashMap.cs --- @@ -100,19 +120,25 @@ public bool Put(TKey key, TValue value)

[GitHub] lucenenet pull request #88: fix lru hash map

2016-09-27 Thread eladmarg
Github user eladmarg closed the pull request at: https://github.com/apache/lucenenet/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #188: Fixed 64 Failing Tests and Finished Facet Imple...

2016-09-26 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/188 Fixed 64 Failing Tests and Finished Facet Implementation Fixed the 64 failing Facet tests, refactored the public API to be more .NET friendly (changing methods to properties and vice versa,

[GitHub] lucenenet pull request #187: Fixed 76 QueryParser Failing Tests

2016-09-22 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/187 Fixed 76 QueryParser Failing Tests This fixes 76 of the 77 failing tests in QueryParser. The remaining one is a matter of completing the test implementation (or removing it entirely

[GitHub] lucenenet pull request #186: Ported Misc (mostly), Suggest, and Memory

2016-09-19 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/186 Ported Misc (mostly), Suggest, and Memory This pull request contains Lucene.Net.Misc, Lucene.Net.Suggest, and Lucene.Net.Memory. There is also some cleanup of the compiler warnings in

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78303386 --- Diff: src/Lucene.Net.TestFramework/Util/fst/FSTTester.cs --- @@ -395,6 +407,24 @@ internal virtual FST DoTest(int prune1, int prune2, bool

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78303194 --- Diff: src/Lucene.Net.TestFramework/Util/fst/FSTTester.cs --- @@ -395,6 +407,24 @@ internal virtual FST DoTest(int prune1, int prune2, bool

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78303088 --- Diff: src/Lucene.Net.Tests/core/Util/TestWeakIdentityMap.cs --- @@ -174,12 +188,15 @@ public virtual void TestSimpleHashMap()

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78302998 --- Diff: src/Lucene.Net.Core/AssemblyInfo.cs --- @@ -84,6 +90,6 @@ // (*) Delay Signing is an advanced option - see the Microsoft .NET

[GitHub] lucenenet pull request #176: Ported QueryParser

2016-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78302897 --- Diff: src/Lucene.Net.Tests/core/Util/TestWeakIdentityMap.cs --- @@ -174,12 +188,15 @@ public virtual void TestSimpleHashMap()

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78302841 --- Diff: src/Lucene.Net.Core/AssemblyInfo.cs --- @@ -84,6 +90,6 @@ // (*) Delay Signing is an advanced option - see the Microsoft .NET

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78302836 --- Diff: src/Lucene.Net.TestFramework/Util/fst/FSTTester.cs --- @@ -913,6 +945,73 @@ private void VerifyPruned(int inputMode, FST fst, int prune1, int

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78302397 --- Diff: src/Lucene.Net.Core/AssemblyInfo.cs --- @@ -84,6 +90,6 @@ // (*) Delay Signing is an advanced option - see the Microsoft .NET

[GitHub] lucenenet pull request #184: Fixed OfflineSorter Test Failures

2016-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-07 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/185 Ported Core.Util.Fst tests + Core.Util.Packed.TestPackedInts test This includes 3 missing test files from Core.Util, several bug fixes to make the Core.Util.Fst tests pass (all green), and

[GitHub] lucenenet pull request #184: Fixed OfflineSorter Test Failures

2016-09-02 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/184 Fixed OfflineSorter Test Failures This resolves the following failing tests: Core.Util.TestOfflineSorter.TestEmpty Core.Util.TestOfflineSorter.TestIntermediateMerges

[GitHub] lucenenet pull request #173: Analysis work

2016-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #182: Analysis Missing Tests and Bug Fixes

2016-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #183: Fix test failures and making SPIClassIterator m...

2016-08-28 Thread conniey
GitHub user conniey opened a pull request: https://github.com/apache/lucenenet/pull/183 Fix test failures and making SPIClassIterator more performant ### SPIClassIterator * Filtering out Microsoft/System assemblies to improve loading * Only adding public classes to the

[GitHub] lucenenet pull request #173: Analysis work

2016-08-23 Thread synhershko
GitHub user synhershko reopened a pull request: https://github.com/apache/lucenenet/pull/173 Analysis work You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/lucenenet analysis-work Alternatively you can review and apply

[GitHub] lucenenet pull request #179: Analysis work - Standard and Core namespaces (m...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #180: Misc bugs

2016-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #180: Misc bugs

2016-08-21 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/180 Misc bugs This removes 15 failing tests and in some other cases fixes the test failure message to show the real logic error instead of an exception. You can merge this pull request into a

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #178: Ported Core.Codecs.Perfield.TestPerFieldPosting...

2016-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #178: Ported Core.Codecs.Perfield.TestPerFieldPosting...

2016-08-07 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/178 Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat2 Ported the Core.Codecs.Perfield.TestPerFieldPostingsFormat2 tests and removed [Test] attribute from a couple of methods where it

[GitHub] lucenenet pull request #:

2016-08-07 Thread synhershko
Github user synhershko commented on the pull request: https://github.com/apache/lucenenet/commit/c6f1a19af68a405b428f935118665f65fefad491#commitcomment-18551289 Please mark as LUCENENET specific if that's the case --- If your project is set up for it, you can reply to this email and

[GitHub] lucenenet pull request #176: Ported QueryParser

2016-08-06 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/176#discussion_r73793556 --- Diff: src/Lucene.Net.Core/Util/ToStringUtils.cs --- @@ -36,12 +37,13 @@ public static string Boost(float boost) { if

[GitHub] lucenenet pull request #176: Ported QueryParser

2016-08-06 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/176#discussion_r73792790 --- Diff: src/Lucene.Net.Core/Util/ToStringUtils.cs --- @@ -36,12 +37,13 @@ public static string Boost(float boost) { if

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-06 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73790017 --- Diff: src/Lucene.Net.Tests/core/Search/TestPhraseQuery.cs --- @@ -255,7 +255,7 @@ public virtual void TestPhraseQueryWithStopAnalyzer()

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-06 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73789830 --- Diff: src/Lucene.Net.Tests/core/Codecs/Lucene3x/TestLucene3xStoredFieldsFormat.cs --- @@ -35,7 +35,8 @@ protected override Codec Codec

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-06 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73789759 --- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs --- @@ -85,22 +86,22 @@ public static IndexWriter MockIndexWriter(Directory dir,

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-04 Thread conniey
GitHub user conniey opened a pull request: https://github.com/apache/lucenenet/pull/177 Limiting uses of static variables and methods in Testcases This is an improvement from PR #172. The difference is that all the existing constructors are maintained with some additions.

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71187179 --- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs --- @@ -85,24 +85,24 @@ public static IndexWriter MockIndexWriter(Directory dir,

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71186208 --- Diff: src/Lucene.Net.Tests/core/Index/TestBinaryDocValuesUpdates.cs --- @@ -1109,25 +1109,55 @@ public virtual void

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71185454 --- Diff: src/Lucene.Net.Tests.Queries/TestCustomScoreQuery.cs --- @@ -334,11 +334,11 @@ private void VerifyResults(float boost, IndexSearcher s,

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71185299 --- Diff: src/Lucene.Net.Tests.Join/Lucene.Net.Tests.Join.csproj --- @@ -31,7 +31,7 @@ -

  1   2   3   4   5   6   >