[ANN] Apache Maven Wrapper 3.3.1 Released
The Apache Maven team is pleased to announce the release of the Apache Maven Wrapper, version 3.3.1 The Maven Wrapper is an easy way to ensure a user of your Maven build has everything necessary to run your Maven build. See https://maven.apache.org/wrapper/ for instructions on how to use Maven Wrapper. You can download the appropriate sources etc. from the download page: https://maven.apache.org/wrapper/download.html Release Notes - Maven Wrapper - Version 3.3.1 ** Improvement * [MWRAPPER-132] - Inlined mvnw Downloader.java uses `new URL(String)`, which is deprecated in Java 21 * [MWRAPPER-134] - Provide a reliable way to determine the Maven Wrapper version Enjoy, -The Apache Maven team
[RESULT][VOTE] Release Apache Maven Wrapper 3.3.1
Howdy, The vote has passed with the following result: +1b: Slawomir, Sylwester, Olivier, Tamas +1nb: Matthias PMC quorum: reached I will promote the artifacts to the central repo, the source release ZIP file and add this release to the board report. Thanks T
Re: [VOTE] Release Apache Maven Wrapper 3.3.1
+1 On Tue, Apr 23, 2024 at 1:18 PM Olivier Lamy wrote: > +1 > > On Tue, 23 Apr 2024 at 02:28, Tamás Cservenák wrote: > > > > Howdy, > > > > The importance of this release is to gain over 3.3.0: Two changes are in > > this release, both are equally important, but MWRAPPER-134 adds simple > > means for tooling to discover wrapper versions being used. With 3.3.0 we > > lost this ability to figure out wrapper versions easily. > > > > We solved 2 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12354586 > > > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/projects/MWRAPPER/issues > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-2097 > > > > Source release checksum SHA512: > > > 270d843df1b5db108f5420c3ef9310ff1238d49b077c35cff6a5eca9f584f6f41ee9d82cba169fce2c6e768281cda9d84383ec75171640163d0966cc0f206949 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Wrapper 3.3.1
+1 On Tue, 23 Apr 2024 at 02:28, Tamás Cservenák wrote: > > Howdy, > > The importance of this release is to gain over 3.3.0: Two changes are in > this release, both are equally important, but MWRAPPER-134 adds simple > means for tooling to discover wrapper versions being used. With 3.3.0 we > lost this ability to figure out wrapper versions easily. > > We solved 2 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12354586 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MWRAPPER/issues > > Staging repo: > https://repository.apache.org/content/repositories/maven-2097 > > Source release checksum SHA512: > 270d843df1b5db108f5420c3ef9310ff1238d49b077c35cff6a5eca9f584f6f41ee9d82cba169fce2c6e768281cda9d84383ec75171640163d0966cc0f206949 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper 3.3.1
+1 pon., 22 kwi 2024, 20:20 użytkownik Slawomir Jaranowski < s.jaranow...@gmail.com> napisał: > +1 > > pon., 22 kwi 2024 o 18:28 Tamás Cservenák > napisał(a): > > > Howdy, > > > > The importance of this release is to gain over 3.3.0: Two changes are in > > this release, both are equally important, but MWRAPPER-134 adds simple > > means for tooling to discover wrapper versions being used. With 3.3.0 we > > lost this ability to figure out wrapper versions easily. > > > > We solved 2 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12354586 > > > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/projects/MWRAPPER/issues > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-2097 > > > > Source release checksum SHA512: > > > > > 270d843df1b5db108f5420c3ef9310ff1238d49b077c35cff6a5eca9f584f6f41ee9d82cba169fce2c6e768281cda9d84383ec75171640163d0966cc0f206949 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > > -- > Sławomir Jaranowski >
Re: [VOTE] Release Apache Maven Wrapper 3.3.1
+1 pon., 22 kwi 2024 o 18:28 Tamás Cservenák napisał(a): > Howdy, > > The importance of this release is to gain over 3.3.0: Two changes are in > this release, both are equally important, but MWRAPPER-134 adds simple > means for tooling to discover wrapper versions being used. With 3.3.0 we > lost this ability to figure out wrapper versions easily. > > We solved 2 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12354586 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MWRAPPER/issues > > Staging repo: > https://repository.apache.org/content/repositories/maven-2097 > > Source release checksum SHA512: > > 270d843df1b5db108f5420c3ef9310ff1238d49b077c35cff6a5eca9f584f6f41ee9d82cba169fce2c6e768281cda9d84383ec75171640163d0966cc0f206949 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > -- Sławomir Jaranowski
Re: [VOTE] Release Apache Maven Wrapper 3.3.1
+1 Greetings Matthias Am 22.04.2024 um 18:28 schrieb Tamás Cservenák: Howdy, The importance of this release is to gain over 3.3.0: Two changes are in this release, both are equally important, but MWRAPPER-134 adds simple means for tooling to discover wrapper versions being used. With 3.3.0 we lost this ability to figure out wrapper versions easily. We solved 2 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12354586 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MWRAPPER/issues Staging repo: https://repository.apache.org/content/repositories/maven-2097 Source release checksum SHA512: 270d843df1b5db108f5420c3ef9310ff1238d49b077c35cff6a5eca9f584f6f41ee9d82cba169fce2c6e768281cda9d84383ec75171640163d0966cc0f206949 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven Wrapper 3.3.1
Howdy, The importance of this release is to gain over 3.3.0: Two changes are in this release, both are equally important, but MWRAPPER-134 adds simple means for tooling to discover wrapper versions being used. With 3.3.0 we lost this ability to figure out wrapper versions easily. We solved 2 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12354586 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MWRAPPER/issues Staging repo: https://repository.apache.org/content/repositories/maven-2097 Source release checksum SHA512: 270d843df1b5db108f5420c3ef9310ff1238d49b077c35cff6a5eca9f584f6f41ee9d82cba169fce2c6e768281cda9d84383ec75171640163d0966cc0f206949 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1
[ANN] Apache Maven Wrapper 3.3.0 Released
The Apache Maven team is pleased to announce the release of the Apache Maven Wrapper, version 3.3.0 The Maven Wrapper is an easy way to ensure a user of your Maven build has everything necessary to run your Maven build. See https://maven.apache.org/wrapper/ for instructions on how to use Maven Wrapper. You can download the appropriate sources etc. from the download page: https://maven.apache.org/wrapper/download.html Release Notes - Maven Wrapper - Version 3.3.0 ** Bug * [MWRAPPER-86] - Trim trailing slash in Repo URL * [MWRAPPER-103] - Failed to validate Maven Wrapper SHA-256 on Windows * [MWRAPPER-108] - mvnw script fails silently when download fails * [MWRAPPER-112] - Detection of JAVA_HOME fails due to bad quoting * [MWRAPPER-113] - Error and warning output goes to standard output and intermingles with Maven output * [MWRAPPER-120] - Maven wrapper plugin should not create wrapperUrl property for script-only mode * [MWRAPPER-123] - only-mvnw fails on ksh printf implementations * [MWRAPPER-131] - Downloader downloads directly into target file ** Improvement * [MWRAPPER-70] - Don't require a pom.xml * [MWRAPPER-104] - Add prettier config for shell scripts * [MWRAPPER-124] - MavenWrapperDownloader uses new URL(String), which is deprecated in Java 21 * [MWRAPPER-125] - Make "only-script" the default wrapper ** Task * [MWRAPPER-128] - Remove legacy * [MWRAPPER-129] - Set plugin prerequisite to Maven 3.6.3 ** Dependency upgrade * [MWRAPPER-100] - Declare needed dependencies * [MWRAPPER-115] - Bump org.codehaus.plexus:plexus-archiver from 4.6.2 to 4.9.1 * [MWRAPPER-118] - Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 * [MWRAPPER-119] - Upgrade Parent to 41 * [MWRAPPER-126] - Upgrade org.codehaus.plexus:plexus-archiver to 4.9.2 * [MWRAPPER-127] - Bump commons-io:commons-io from 2.16.0 to 2.16.1 * [MWRAPPER-130] - Use Maven parent 42 Enjoy, -The Apache Maven team
[RESULT][VOTE] Release Apache Maven Wrapper 3.3.0
Howdy, The vote has passed with the following result: +1b: Olivier, Karl-Heinz, Slawomir PMC quorum: reached I will promote the artifacts to the central repo, the source release ZIP file and add this release to the board report. Thanks T
Re: [VOTE] Release Apache Maven Wrapper 3.3.0
+1 śr., 17 kwi 2024 o 21:36 Tamás Cservenák napisał(a): > Howdy, > > We solved 21 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12352995 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MWRAPPER/issues > > Staging repo: > https://repository.apache.org/content/repositories/maven-2093 > > Source release checksum SHA512: > > 4c495321f25d7001ba76a0cb4fd207b59905c4fef9066df8ca6f37eb645a74e55234710222d46df297bfd6ca17138630778ffa27c026a23e4b1045e0e98d9a04 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > -- Sławomir Jaranowski
Re: [VOTE] Release Apache Maven Wrapper 3.3.0
Howdy, created https://issues.apache.org/jira/browse/MWRAPPER-132 and scheduled for 3.3.1 Thanks T On Thu, Apr 18, 2024 at 3:48 AM James Gao wrote: > pr of MWRAPPER-124 <https://issues.apache.org/jira/browse/MWRAPPER-124> is > not ported to only-script type. see pr > https://github.com/apache/maven-wrapper/pull/133 > > On Thu, Apr 18, 2024 at 3:36 AM Tamás Cservenák > wrote: > > > Howdy, > > > > We solved 21 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12352995 > > > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/projects/MWRAPPER/issues > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-2093 > > > > Source release checksum SHA512: > > > > > 4c495321f25d7001ba76a0cb4fd207b59905c4fef9066df8ca6f37eb645a74e55234710222d46df297bfd6ca17138630778ffa27c026a23e4b1045e0e98d9a04 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > >
Re: [VOTE] Release Apache Maven Wrapper 3.3.0
Hi, +1 from me. Kind regrads Karl Heinz Marbaise On 17.04.24 21:34, Tamás Cservenák wrote: Howdy, We solved 21 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12352995 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MWRAPPER/issues Staging repo: https://repository.apache.org/content/repositories/maven-2093 Source release checksum SHA512: 4c495321f25d7001ba76a0cb4fd207b59905c4fef9066df8ca6f37eb645a74e55234710222d46df297bfd6ca17138630778ffa27c026a23e4b1045e0e98d9a04 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper 3.3.0
pr of MWRAPPER-124 <https://issues.apache.org/jira/browse/MWRAPPER-124> is not ported to only-script type. see pr https://github.com/apache/maven-wrapper/pull/133 On Thu, Apr 18, 2024 at 3:36 AM Tamás Cservenák wrote: > Howdy, > > We solved 21 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12352995 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MWRAPPER/issues > > Staging repo: > https://repository.apache.org/content/repositories/maven-2093 > > Source release checksum SHA512: > > 4c495321f25d7001ba76a0cb4fd207b59905c4fef9066df8ca6f37eb645a74e55234710222d46df297bfd6ca17138630778ffa27c026a23e4b1045e0e98d9a04 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 >
Re: [VOTE] Release Apache Maven Wrapper 3.3.0
+1 On Thu, 18 Apr 2024 at 05:36, Tamás Cservenák wrote: > > Howdy, > > We solved 21 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12352995 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MWRAPPER/issues > > Staging repo: > https://repository.apache.org/content/repositories/maven-2093 > > Source release checksum SHA512: > 4c495321f25d7001ba76a0cb4fd207b59905c4fef9066df8ca6f37eb645a74e55234710222d46df297bfd6ca17138630778ffa27c026a23e4b1045e0e98d9a04 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven Wrapper 3.3.0
Howdy, We solved 21 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12352995 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MWRAPPER/issues Staging repo: https://repository.apache.org/content/repositories/maven-2093 Source release checksum SHA512: 4c495321f25d7001ba76a0cb4fd207b59905c4fef9066df8ca6f37eb645a74e55234710222d46df297bfd6ca17138630778ffa27c026a23e4b1045e0e98d9a04 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1
[ANN] Apache Maven Wrapper 3.2.0 Released
The Apache Maven team is pleased to announce the release of the Apache Maven Wrapper, version 3.2.0 The Maven Wrapper is an easy way to ensure a user of your Maven build has everything necessary to run your Maven build. See https://maven.apache.org/wrapper/ for instructions on how to use Maven Wrapper. You can download the appropriate sources etc. from the download page: https://maven.apache.org/wrapper/download.html Release Notes - Maven Wrapper - Version 3.2.0 ** Bug * [MWRAPPER-64] - IT test use early deployed artifacts * [MWRAPPER-65] - MavenWrapperDownloader.java ignores the MVNW_REPOURL env * [MWRAPPER-66] - maven-wrapper.properties - incorrect header reported by rat plugin * [MWRAPPER-67] - mvnw script does not download jar if used in git bash in windows * [MWRAPPER-68] - MVNW_REPOURL improperly formed distributionUrl * [MWRAPPER-73] - Empty maven property cause to invalid configuration * [MWRAPPER-74] - Fix default distribution type documentation on maven site. * [MWRAPPER-77] - wrapper:wrapper does not update scripts * [MWRAPPER-81] - mvnw does not remove return chars from jvm.config * [MWRAPPER-85] - Docs do not mention distributionType for MavenWrapperDownloader.jar * [MWRAPPER-88] - mvnw is not POSIX compatible * [MWRAPPER-95] - Fix bug in mvnw to handle \r in jvm.config correctly ** New Feature * [MWRAPPER-61] - let mvnw call mvn directly, without maven-wrapper.jar * [MWRAPPER-75] - Allow for sha256 checksum verification of downloaded artifacts. * [MWRAPPER-80] - Support maven-mvnd as a maven distribution ** Improvement * [MWRAPPER-16] - update mvnw scripts to launch target Maven mvn scripts, to enforce consistency * [MWRAPPER-33] - Use java 8 in maven-wrapper ** Task * [MWRAPPER-84] - Update documentation about shells ** Dependency upgrade * [MWRAPPER-89] - Update maven-parent to v39 * [MWRAPPER-96] - Require Maven 3.2.5 Enjoy, -The Apache Maven team
[RESULT] [VOTE] Release Apache Maven Wrapper Plugin 3.2.0
Hi, The vote has passed with the following result: +1: Herve Boutemy, Tamás Cservenák, Benjamin Marwell, Slawomir Jaranowski, Delany +0: Elliotte Rusty Harold PMC quorum: reached I will promote the source release zip file to Apache distribution area and the artifacts to the central repo. -- Sławomir Jaranowski
[VOTE] Release Apache Maven Wrapper Plugin 3.2.0
Hi, We solved 20 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12351128 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20resolution%20%3D%20Unresolved Staging repo: https://repository.apache.org/content/repositories/maven-1885/ https://repository.apache.org/content/repositories/maven-1885/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0-source-release.zip Source release checksum(s): maven-wrapper-3.2.0-source-release.zip - SHA-512 : 547cc262b57fe0dd9ee43613aa0179092305520d9f3c173155bcef4090e7ca57dca3927f953793a4518d082a5b28c9b3ea1a8c488741030196a6bb9723d13c3c Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 -- Sławomir Jaranowski
Re: [ANN] Apache Maven Wrapper 3.1.1 Released
Thanks everyone involved, and thank you to Brian Demers for starting this
project in the first place!
On Sat, 14 May 2022, 16:07 Hervé Boutemy, wrote:
> The Apache Maven team is pleased to announce the release of the Apache
> Maven
> Wrapper, version 3.1.1.
>
> The Maven Wrapper is an easy way to ensure a user of your Maven build has
> everything necessary to run your Maven build.
>
> This is the first release of this project in its Apache Maven new home: it
> was
> previously maintained by community at
> https://github.com/takari/maven-wrapper
> and was kindly donated to the Maven team. Thank you to all people who
> permitted this.
>
> See https://maven.apache.org/wrapper/ for instructions on how to use this
> updated Maven Wrapper.
>
> You can download the appropriate sources etc. from the download page:
>
> https://maven.apache.org/wrapper/download.cgi
>
>
> Release Notes - Maven Wrapper - Version 3.1.1
>
> ** Bug
> * [MWRAPPER-21] - Arbitrary file write during archive extraction ("Zip
> Slip") in wrapper
> * [MWRAPPER-38] - build from source-release has different result from
> Git
> * [MWRAPPER-40] - Wrapper Properties File License system dependant
> line
> separator
> * [MWRAPPER-41] - Goals documentation missing from site
> * [MWRAPPER-42] - maven-wrapper fails to self-update maven-wrapper.jar
> * [MWRAPPER-44] - maven-wrapper may use outdated
> MavenWrapperDownloader.class
> * [MWRAPPER-58] - curl cannot follow 302 code when downloading wrapper
> jar
>
> ** Improvement
> * [MWRAPPER-39] - release as maven-wrapper instead of
> maven-wrapper-parent
> * [MWRAPPER-43] - Download of jar must be quiet by default
> * [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper
> files/
> scripts
> * [MWRAPPER-49] - add Wrapper version in mvnw/mvnw.cmd scripts
> * [MWRAPPER-51] - Refactor using Java Path API (NIO.2)
> * [MWRAPPER-53] - cygwin path tidy for java and class
>
> ** Task
> * [MWRAPPER-56] - Remove M2_HOME from mvnw script
>
> ** Dependency upgrade
> * [MWRAPPER-62] - Upgrade Parent to 35
> * [MWRAPPER-63] - Upgrade Parent to 36
>
>
> Enjoy,
>
> -The Apache Maven team
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
Re: [ANN] Apache Maven Wrapper 3.1.1 Released
Awesome work everyone. I am glad this made it to the users from Apache now.
Manfred
Hervé Boutemy wrote on 2022-05-14 07:06 (GMT -07:00):
> The Apache Maven team is pleased to announce the release of the Apache Maven
> Wrapper, version 3.1.1.
>
> The Maven Wrapper is an easy way to ensure a user of your Maven build has
> everything necessary to run your Maven build.
>
> This is the first release of this project in its Apache Maven new home: it
> was
> previously maintained by community at https://github.com/takari/maven-wrapper
> and was kindly donated to the Maven team. Thank you to all people who
> permitted this.
>
> See https://maven.apache.org/wrapper/ for instructions on how to use this
> updated Maven Wrapper.
>
> You can download the appropriate sources etc. from the download page:
>
> https://maven.apache.org/wrapper/download.cgi
>
>
> Release Notes - Maven Wrapper - Version 3.1.1
>
> ** Bug
> * [MWRAPPER-21] - Arbitrary file write during archive extraction ("Zip
> Slip") in wrapper
> * [MWRAPPER-38] - build from source-release has different result from Git
> * [MWRAPPER-40] - Wrapper Properties File License system dependant line
> separator
> * [MWRAPPER-41] - Goals documentation missing from site
> * [MWRAPPER-42] - maven-wrapper fails to self-update maven-wrapper.jar
> * [MWRAPPER-44] - maven-wrapper may use outdated
> MavenWrapperDownloader.class
> * [MWRAPPER-58] - curl cannot follow 302 code when downloading wrapper jar
>
> ** Improvement
> * [MWRAPPER-39] - release as maven-wrapper instead of maven-wrapper-parent
> * [MWRAPPER-43] - Download of jar must be quiet by default
> * [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/
> scripts
> * [MWRAPPER-49] - add Wrapper version in mvnw/mvnw.cmd scripts
> * [MWRAPPER-51] - Refactor using Java Path API (NIO.2)
> * [MWRAPPER-53] - cygwin path tidy for java and class
>
> ** Task
> * [MWRAPPER-56] - Remove M2_HOME from mvnw script
>
> ** Dependency upgrade
> * [MWRAPPER-62] - Upgrade Parent to 35
> * [MWRAPPER-63] - Upgrade Parent to 36
>
>
> Enjoy,
>
> -The Apache Maven team
>
>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@maven.apache.org
> For additional commands, e-mail: users-h...@maven.apache.org
>
>
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[ANN] Apache Maven Wrapper 3.1.1 Released
The Apache Maven team is pleased to announce the release of the Apache Maven
Wrapper, version 3.1.1.
The Maven Wrapper is an easy way to ensure a user of your Maven build has
everything necessary to run your Maven build.
This is the first release of this project in its Apache Maven new home: it was
previously maintained by community at https://github.com/takari/maven-wrapper
and was kindly donated to the Maven team. Thank you to all people who
permitted this.
See https://maven.apache.org/wrapper/ for instructions on how to use this
updated Maven Wrapper.
You can download the appropriate sources etc. from the download page:
https://maven.apache.org/wrapper/download.cgi
Release Notes - Maven Wrapper - Version 3.1.1
** Bug
* [MWRAPPER-21] - Arbitrary file write during archive extraction ("Zip
Slip") in wrapper
* [MWRAPPER-38] - build from source-release has different result from Git
* [MWRAPPER-40] - Wrapper Properties File License system dependant line
separator
* [MWRAPPER-41] - Goals documentation missing from site
* [MWRAPPER-42] - maven-wrapper fails to self-update maven-wrapper.jar
* [MWRAPPER-44] - maven-wrapper may use outdated
MavenWrapperDownloader.class
* [MWRAPPER-58] - curl cannot follow 302 code when downloading wrapper jar
** Improvement
* [MWRAPPER-39] - release as maven-wrapper instead of maven-wrapper-parent
* [MWRAPPER-43] - Download of jar must be quiet by default
* [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/
scripts
* [MWRAPPER-49] - add Wrapper version in mvnw/mvnw.cmd scripts
* [MWRAPPER-51] - Refactor using Java Path API (NIO.2)
* [MWRAPPER-53] - cygwin path tidy for java and class
** Task
* [MWRAPPER-56] - Remove M2_HOME from mvnw script
** Dependency upgrade
* [MWRAPPER-62] - Upgrade Parent to 35
* [MWRAPPER-63] - Upgrade Parent to 36
Enjoy,
-The Apache Maven team
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[RESULT] [VOTE] Release Apache Maven Wrapper version 3.1.1
Hi, The vote has passed with the following result: +1 : Maarten Mulders, Herve Boutemy, Delany, Jorge Solórzano, Slawomir Jaranowski, Tamás Cservenák, Olivier Lamy, Jason van Zyl PMC quorum reached I will promote the source release zip file to Apache distribution area and the artifacts to the central repo. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
+1 > On May 14, 2022, at 6:26 AM, Tamás Cservenák wrote: > > +1 > > On Sun, May 8, 2022, 11:29 Hervé BOUTEMY wrote: > >> Hi, >> >> We solved 14 issues: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 >> >> Staging repo: >> https://repository.apache.org/content/repositories/maven-1750/ >> >> https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip >> >> Source release checksum(s): >> maven-wrapper-3.1.1-source-release.zip: >> b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 >> >> Staging site: >> https://maven.apache.org/wrapper-archives/wrapper-LATEST/ >> >> Guide to testing staged releases: >> https://maven.apache.org/guides/development/guide-testing-releases.html >> >> Vote open for at least 72 hours. >> >> [ ] +1 >> [ ] +0 >> [ ] -1 >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> A master in the art of living draws no sharp distinction between his work and his play; his labor and his leisure; his mind and his body; his education and his recreation. He hardly knows which is which. He simply pursues his vision of excellence through whatever he is doing, and leaves others to determine whether he is working or playing. To himself, he always appears to be doing both. -- François-René de Chateaubriand - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
+1 On Sun, 8 May 2022 at 19:28, Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: > https://repository.apache.org/content/repositories/maven-1750/ > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > Source release checksum(s): > maven-wrapper-3.1.1-source-release.zip: > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
+1 On Sun, May 8, 2022, 11:29 Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: > https://repository.apache.org/content/repositories/maven-1750/ > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > Source release checksum(s): > maven-wrapper-3.1.1-source-release.zip: > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
thanks for checking: I'll add these 2 issues to the release Le vendredi 13 mai 2022, 17:08:21 CEST Jorge Solórzano a écrit : > +1 > > Tested on Linux with JDK17. > > I think this also fixes MWRAPPER-44 and fixes the abandoned > MWRAPPER-21 Zip-slip issue, making a total of 16 issues fixes ;) > > On Fri, May 13, 2022 at 9:29 AM Delany wrote: > > +1 > > > > JDK11 on *nix > > > > Delany > > > > On Fri, 13 May 2022 at 08:11, Herve Boutemy wrote: > > > here is my +1 > > > > > > Reproducible Build confirmed: reference done with JDK 8 on *nix > > > > > > I need more votes, please > > > > > > On 2022/05/08 09:28:32 Hervé BOUTEMY wrote: > > > > Hi, > > > > > > > We solved 14 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929; > > > styleName=Text=12323721> > > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-1750/ > > > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache > > > /maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zi > > > p> > > > > > Source release checksum(s): > > > > > > > maven-wrapper-3.1.1-source-release.zip: > > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89 > > > f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0> > > > > > Staging site: > > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > > > Guide to testing staged releases: > > > > https://maven.apache.org/guides/development/guide-testing-releases.htm > > > > l > > > > > > > > Vote open for at least 72 hours. > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
+1 pt., 13 maj 2022 o 17:08 Jorge Solórzano napisał(a): > +1 > > Tested on Linux with JDK17. > > I think this also fixes MWRAPPER-44 and fixes the abandoned > MWRAPPER-21 Zip-slip issue, making a total of 16 issues fixes ;) > > > On Fri, May 13, 2022 at 9:29 AM Delany wrote: > > > > +1 > > > > JDK11 on *nix > > > > Delany > > > > > > On Fri, 13 May 2022 at 08:11, Herve Boutemy wrote: > > > > > here is my +1 > > > > > > Reproducible Build confirmed: reference done with JDK 8 on *nix > > > > > > I need more votes, please > > > > > > On 2022/05/08 09:28:32 Hervé BOUTEMY wrote: > > > > Hi, > > > > > > > > We solved 14 issues: > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > > > > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-1750/ > > > > > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > > > > > > > Source release checksum(s): > > > > maven-wrapper-3.1.1-source-release.zip: > > > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > > > > > > > Staging site: > > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > > > Guide to testing staged releases: > > > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > > Vote open for at least 72 hours. > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
+1 Tested on Linux with JDK17. I think this also fixes MWRAPPER-44 and fixes the abandoned MWRAPPER-21 Zip-slip issue, making a total of 16 issues fixes ;) On Fri, May 13, 2022 at 9:29 AM Delany wrote: > > +1 > > JDK11 on *nix > > Delany > > > On Fri, 13 May 2022 at 08:11, Herve Boutemy wrote: > > > here is my +1 > > > > Reproducible Build confirmed: reference done with JDK 8 on *nix > > > > I need more votes, please > > > > On 2022/05/08 09:28:32 Hervé BOUTEMY wrote: > > > Hi, > > > > > > We solved 14 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > > > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1750/ > > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > > > > > Source release checksum(s): > > > maven-wrapper-3.1.1-source-release.zip: > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > > > > > Staging site: > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > Guide to testing staged releases: > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for at least 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
+1 JDK11 on *nix Delany On Fri, 13 May 2022 at 08:11, Herve Boutemy wrote: > here is my +1 > > Reproducible Build confirmed: reference done with JDK 8 on *nix > > I need more votes, please > > On 2022/05/08 09:28:32 Hervé BOUTEMY wrote: > > Hi, > > > > We solved 14 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1750/ > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > > > Source release checksum(s): > > maven-wrapper-3.1.1-source-release.zip: > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
ok, I was able to reproduce: yes, IT seems to expect wrapper.jar to have been previously installed: Tamas will bite because this is a build cycle :) I suppose this can easily be tested with SNAPSHOTs, you just have to delete the artifacts in local repository nice future improvement for the codebase at least, this does not impact users of wrapper Regards, Hervé On 2022/05/09 19:19:15 Slawomir Jaranowski wrote: > Hi, > > Failed IT test during build from source-releas [1] > > We have almost done a new type distribution - only-script [2] which > downloads the Maven distribution and calls directly the mvn script from > distribution. > > I will be happy to provide this distribution to users for getting feedback. > So probably the next release will be soon. > > [1] https://issues.apache.org/jira/browse/MWRAPPER-64 > [2] https://github.com/apache/maven-wrapper/pull/33 > > > niedz., 8 maj 2022 o 11:29 Hervé BOUTEMY napisał(a): > > > Hi, > > > > We solved 14 issues: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1750/ > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > > > Source release checksum(s): > > maven-wrapper-3.1.1-source-release.zip: > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > Sławomir Jaranowski > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
here is my +1 Reproducible Build confirmed: reference done with JDK 8 on *nix I need more votes, please On 2022/05/08 09:28:32 Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: > https://repository.apache.org/content/repositories/maven-1750/ > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > Source release checksum(s): > maven-wrapper-3.1.1-source-release.zip: > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
Hi, Failed IT test during build from source-releas [1] We have almost done a new type distribution - only-script [2] which downloads the Maven distribution and calls directly the mvn script from distribution. I will be happy to provide this distribution to users for getting feedback. So probably the next release will be soon. [1] https://issues.apache.org/jira/browse/MWRAPPER-64 [2] https://github.com/apache/maven-wrapper/pull/33 niedz., 8 maj 2022 o 11:29 Hervé BOUTEMY napisał(a): > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: > https://repository.apache.org/content/repositories/maven-1750/ > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > Source release checksum(s): > maven-wrapper-3.1.1-source-release.zip: > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
mvnd is not only the CLI, it's also the daemon: if mvnd CLI does not manage different daemons for different versions, you'll not get the expected result I also see another question with mvnd CLI being a native GraalVM executable: we'll need to have the good native CLI expanded nothing is not feasible: it's just early given we're at the first mvnd release at Apache not yet released, and maven-wrapper 3.1.1 waiting for the jar-less future option we'll need to have people participating to both mvnd and maven-wrapper updates before we work on associating the 2 but for sure, it's a nice future target for now, let's finish wrapper 3.1.1 release Regards, Hervé Le lundi 9 mai 2022, 03:14:52 CEST James Gao a écrit : > If mvnd always bundles a fixed version of Maven, from the wapper, maven > daemon could be seen as a maven distribution, and if detected, the `mvnd` > entry script is invoked instead of `mvn`. > > On Mon, May 9, 2022 at 2:59 AM Hervé BOUTEMY wrote: > > currently mvnd does not support variable Maven versions > > then having wrapper for mvnd does not yet make sense > > > > Le dimanche 8 mai 2022, 14:12:31 CEST Slawomir Jaranowski a écrit : > > > HI > > > Delany what kind of integration do you think ...? Is there an issue > > > > created > > > > > for it? > > > > > > niedz., 8 maj 2022 o 11:49 Delany > > > > napisał(a): > > > > Hi. Is there integration between the wrapper and the upcoming mvnd? > > > > > > > > Thanks, > > > > Delany > > > > > > > > On Sun, 8 May 2022 at 11:29, Hervé BOUTEMY > > > > wrote: > > > > > Hi, > > > > > > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929 > > > > > > yleName=Text=12323721> > > > > > > > > > Staging repo: > > > > > https://repository.apache.org/content/repositories/maven-1750/ > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/m > > > > aven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip> > > > > > > > Source release checksum(s): > > > > > > > maven-wrapper-3.1.1-source-release.zip: > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f7 > > > > > > 0f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0> > > > > > > > > > Staging site: > > > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > Vote open for at least 72 hours. > > > > > > > > > > [ ] +1 > > > > > [ ] +0 > > > > > [ ] -1 > > > > > > > > > > > > > > > > > > > > > > > > > - > > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
If mvnd always bundles a fixed version of Maven, from the wapper, maven daemon could be seen as a maven distribution, and if detected, the `mvnd` entry script is invoked instead of `mvn`. On Mon, May 9, 2022 at 2:59 AM Hervé BOUTEMY wrote: > currently mvnd does not support variable Maven versions > then having wrapper for mvnd does not yet make sense > > Le dimanche 8 mai 2022, 14:12:31 CEST Slawomir Jaranowski a écrit : > > HI > > Delany what kind of integration do you think ...? Is there an issue > created > > for it? > > > > niedz., 8 maj 2022 o 11:49 Delany > napisał(a): > > > Hi. Is there integration between the wrapper and the upcoming mvnd? > > > > > > Thanks, > > > Delany > > > > > > On Sun, 8 May 2022 at 11:29, Hervé BOUTEMY > wrote: > > > > Hi, > > > > > > > We solved 14 issues: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929 > > > yleName=Text=12323721> > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-1750/ > > > > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/m > > > > aven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip> > > > > Source release checksum(s): > > > > > > > maven-wrapper-3.1.1-source-release.zip: > > > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f7 > > > 0f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0> > > > > Staging site: > > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > > > Guide to testing staged releases: > > > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > > Vote open for at least 72 hours. > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
currently mvnd does not support variable Maven versions then having wrapper for mvnd does not yet make sense Le dimanche 8 mai 2022, 14:12:31 CEST Slawomir Jaranowski a écrit : > HI > Delany what kind of integration do you think ...? Is there an issue created > for it? > > niedz., 8 maj 2022 o 11:49 Delany napisał(a): > > Hi. Is there integration between the wrapper and the upcoming mvnd? > > > > Thanks, > > Delany > > > > On Sun, 8 May 2022 at 11:29, Hervé BOUTEMY wrote: > > > Hi, > > > > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929 > > yleName=Text=12323721> > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1750/ > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/m > > aven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip> > > > Source release checksum(s): > > > > > maven-wrapper-3.1.1-source-release.zip: > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f7 > > 0f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0> > > > Staging site: > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > Guide to testing staged releases: > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for at least 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
Le dimanche 8 mai 2022, 13:21:46 CEST Maarten Mulders a écrit : > With Maven 4 on macOS, neither `mvn wrapper:wrapper` nor `mvn wrapper` > picks up the new version. I guess we need a task to update Mavens > `WrapperLifecycleProvider` to achieve that? yes, because it's a fixed version we removed support for LATEST in Lifecycle providers: usually, this was a good move, but for wrapper, LATEST would be the right choice IMHO or eventually simply remove the wrapper lifecycle just because it creates this issue: "mvn wrapper:wrapper" is acceptable, it's not so much an if people can't do "mvn wrapper"... Regards, Hervé > > > Maarten > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
HI Delany what kind of integration do you think ...? Is there an issue created for it? niedz., 8 maj 2022 o 11:49 Delany napisał(a): > Hi. Is there integration between the wrapper and the upcoming mvnd? > > Thanks, > Delany > > > > On Sun, 8 May 2022 at 11:29, Hervé BOUTEMY wrote: > > > Hi, > > > > We solved 14 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1750/ > > > > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > > > Source release checksum(s): > > maven-wrapper-3.1.1-source-release.zip: > > > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Sławomir Jaranowski
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
On 08/05/2022 11:28, Hervé BOUTEMY wrote: Hi, We solved 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 Staging repo: https://repository.apache.org/content/repositories/maven-1750/ https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip Source release checksum(s): maven-wrapper-3.1.1-source-release.zip: b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org +1. Tested with Maven 3.8.5 on macOS; no unexpected differences between wrappers generated by 3.1.0 or 3.1.1. With Maven 4 on macOS, neither `mvn wrapper:wrapper` nor `mvn wrapper` picks up the new version. I guess we need a task to update Mavens `WrapperLifecycleProvider` to achieve that? Maarten - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.1
Hi. Is there integration between the wrapper and the upcoming mvnd? Thanks, Delany On Sun, 8 May 2022 at 11:29, Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: > https://repository.apache.org/content/repositories/maven-1750/ > > https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip > > Source release checksum(s): > maven-wrapper-3.1.1-source-release.zip: > b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
[VOTE] Release Apache Maven Wrapper version 3.1.1
Hi, We solved 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 Staging repo: https://repository.apache.org/content/repositories/maven-1750/ https://repository.apache.org/content/repositories/maven-1750/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1-source-release.zip Source release checksum(s): maven-wrapper-3.1.1-source-release.zip: b110aef3a123c5f1ab77669c53baee3b1a71471ad672af4812d39ef302234f64789edd89f70f20c169eb5d4cc45fb4a94a24f64f98adbf863d0e5013a762aea0 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #26: Use Maven wrapper to set up Maven version for build
slawekjaranowski opened a new pull request #26: URL: https://github.com/apache/maven-gh-actions-shared/pull/26 Some project require specific Maven version so let's allow changing default version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
RE: [ANN] Apache Maven Wrapper 3.1.0 Released
So (with my incubator mentor hat on) ... If we update the maven-wrapper stuff currently in the repos with something we created with the new apache maven-wrapper-plugin ... do we still have to point out the related files in the LICENSE and NOTICE files? Chris -Original Message- From: Jason van Zyl Sent: Samstag, 18. Dezember 2021 14:34 To: Maven Developers List Subject: Re: [ANN] Apache Maven Wrapper 3.1.0 Released I have archived the donated project at Takari and updated the README to point everyone to Apache: https://github.com/takari/maven-wrapper jvz > On Dec 18, 2021, at 5:52 AM, Hervé Boutemy wrote: > > The Apache Maven team is pleased to announce the release of the Apache Maven > Wrapper, version 3.1.0. > > The Maven Wrapper is an easy way to ensure a user of your Maven build has > everything necessary to run your Maven build. > > This is the first release of this project in its Apache Maven new home: it > was previously maintained by community at > https://github.com/takari/maven-wrapper and was kindly donated to the Maven > team. Thank you to all people who permitted this. > > See https://maven.apache.org/wrapper/ for instructions on how to use this > updated Maven Wrapper. > > You can download the appropriate sources etc. from the download page: > > https://maven.apache.org/wrapper/download.cgi > > > Release Notes - Maven Wrapper - Version 3.1.0 > > ** Bug >* [MWRAPPER-18] - using MVNW_REPOURL, wrong Maven version is downloaded >* [MWRAPPER-19] - maven-wrapper DefaultDownloader does not parse > user/password correctly >* [MWRAPPER-20] - Maven Wrapper creates empty file when it fails behind > proxy 407 >* [MWRAPPER-22] - maven-wrapper on windows >* [MWRAPPER-25] - fix installer messages >* [MWRAPPER-37] - restore MVNW_REPOURL support for wrapper plugin > > ** New Feature >* [MWRAPPER-28] - add mvnwDebug* scripts > > ** Improvement >* [MWRAPPER-24] - mvnw calls which(1) which is an external command >* [MWRAPPER-27] - rework mvnw* scripts to better match mvn* from Maven 3.8 >* [MWRAPPER-29] - Project should build successfully with verify lifecycle >* [MWRAPPER-30] - Add help mojo >* [MWRAPPER-31] - Get rid of maven-artifact-transfer >* [MWRAPPER-32] - Use Maven core component in provided scope > > ** Wish >* [MWRAPPER-26] - install binary by default to match older user > experience > > ** Task >* [MWRAPPER-14] - Make maven wrapper functional >* [MWRAPPER-17] - IP-CLEARANCE for Maven Wrapper >* [MWRAPPER-34] - use Java 7 for maven-wrapper-plugin and maven-wrapper.jar >* [MWRAPPER-35] - don't copy mvnwDebug* scripts by default > > > Enjoy, > > -The Apache Maven team > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For > additional commands, e-mail: dev-h...@maven.apache.org > Thanks, Jason - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [ANN] Apache Maven Wrapper 3.1.0 Released
I have archived the donated project at Takari and updated the README to point everyone to Apache: https://github.com/takari/maven-wrapper jvz > On Dec 18, 2021, at 5:52 AM, Hervé Boutemy wrote: > > The Apache Maven team is pleased to announce the release of the Apache Maven > Wrapper, version 3.1.0. > > The Maven Wrapper is an easy way to ensure a user of your Maven build has > everything necessary to run your Maven build. > > This is the first release of this project in its Apache Maven new home: it > was previously maintained by community at > https://github.com/takari/maven-wrapper and was kindly donated to the Maven > team. Thank you to all people who permitted this. > > See https://maven.apache.org/wrapper/ for instructions on how to use this > updated Maven Wrapper. > > You can download the appropriate sources etc. from the download page: > > https://maven.apache.org/wrapper/download.cgi > > > Release Notes - Maven Wrapper - Version 3.1.0 > > ** Bug >* [MWRAPPER-18] - using MVNW_REPOURL, wrong Maven version is downloaded >* [MWRAPPER-19] - maven-wrapper DefaultDownloader does not parse > user/password correctly >* [MWRAPPER-20] - Maven Wrapper creates empty file when it fails behind > proxy 407 >* [MWRAPPER-22] - maven-wrapper on windows >* [MWRAPPER-25] - fix installer messages >* [MWRAPPER-37] - restore MVNW_REPOURL support for wrapper plugin > > ** New Feature >* [MWRAPPER-28] - add mvnwDebug* scripts > > ** Improvement >* [MWRAPPER-24] - mvnw calls which(1) which is an external command >* [MWRAPPER-27] - rework mvnw* scripts to better match mvn* from Maven 3.8 >* [MWRAPPER-29] - Project should build successfully with verify lifecycle >* [MWRAPPER-30] - Add help mojo >* [MWRAPPER-31] - Get rid of maven-artifact-transfer >* [MWRAPPER-32] - Use Maven core component in provided scope > > ** Wish >* [MWRAPPER-26] - install binary by default to match older user experience > > ** Task > * [MWRAPPER-14] - Make maven wrapper functional >* [MWRAPPER-17] - IP-CLEARANCE for Maven Wrapper >* [MWRAPPER-34] - use Java 7 for maven-wrapper-plugin and maven-wrapper.jar >* [MWRAPPER-35] - don't copy mvnwDebug* scripts by default > > > Enjoy, > > -The Apache Maven team > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > Thanks, Jason - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[ANN] Apache Maven Wrapper 3.1.0 Released
The Apache Maven team is pleased to announce the release of the Apache Maven Wrapper, version 3.1.0. The Maven Wrapper is an easy way to ensure a user of your Maven build has everything necessary to run your Maven build. This is the first release of this project in its Apache Maven new home: it was previously maintained by community at https://github.com/takari/maven-wrapper and was kindly donated to the Maven team. Thank you to all people who permitted this. See https://maven.apache.org/wrapper/ for instructions on how to use this updated Maven Wrapper. You can download the appropriate sources etc. from the download page: https://maven.apache.org/wrapper/download.cgi Release Notes - Maven Wrapper - Version 3.1.0 ** Bug * [MWRAPPER-18] - using MVNW_REPOURL, wrong Maven version is downloaded * [MWRAPPER-19] - maven-wrapper DefaultDownloader does not parse user/password correctly * [MWRAPPER-20] - Maven Wrapper creates empty file when it fails behind proxy 407 * [MWRAPPER-22] - maven-wrapper on windows * [MWRAPPER-25] - fix installer messages * [MWRAPPER-37] - restore MVNW_REPOURL support for wrapper plugin ** New Feature * [MWRAPPER-28] - add mvnwDebug* scripts ** Improvement * [MWRAPPER-24] - mvnw calls which(1) which is an external command * [MWRAPPER-27] - rework mvnw* scripts to better match mvn* from Maven 3.8 * [MWRAPPER-29] - Project should build successfully with verify lifecycle * [MWRAPPER-30] - Add help mojo * [MWRAPPER-31] - Get rid of maven-artifact-transfer * [MWRAPPER-32] - Use Maven core component in provided scope ** Wish * [MWRAPPER-26] - install binary by default to match older user experience ** Task * [MWRAPPER-14] - Make maven wrapper functional * [MWRAPPER-17] - IP-CLEARANCE for Maven Wrapper * [MWRAPPER-34] - use Java 7 for maven-wrapper-plugin and maven-wrapper.jar * [MWRAPPER-35] - don't copy mvnwDebug* scripts by default Enjoy, -The Apache Maven team - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[RESULT] [VOTE] Release Apache Maven Wrapper version 3.1.0
Hi, The vote has passed with the following result: +1 : Christopher Dutz, Tamás Cservenák, Jason van zyl, Arnaud Héritier, Hervé Boutemy PMC quorum: reached I will promote the artifacts to the central repo. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
here is my +1 build near fully reproduced: reference was done with JDK 8 on *nix Only strange issue is on group write access to on mvnw*.cmd that is different in source-release zip file from Git checkout... Regards, Hervé Le lundi 13 décembre 2021, 22:09:42 CET Hervé BOUTEMY a écrit : > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721 > rsion=12350068=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-1679/ > https://repository.apache.org/content/repositories/maven-1679/org/apache/mav > en/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-rele > ase.zip > > Source release checksum(s): > maven-wrapper-parent-3.1.0-source-release.zip sha512: > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac149 > 75692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
+1 Le mer. 15 déc. 2021 à 19:38, Jason van zyl a écrit : > +1 > > jvz > > > On Dec 13, 2021, at 4:09 PM, Hervé BOUTEMY > wrote: > > > > Hi, > > > > We solved 18 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1679/ > > > https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip > > > > Source release checksum(s): > > maven-wrapper-parent-3.1.0-source-release.zip sha512: > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Arnaud Héritier Twitter/GitHub/... : aheritier
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
+1 jvz > On Dec 13, 2021, at 4:09 PM, Hervé BOUTEMY wrote: > > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-1679/ > https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip > > Source release checksum(s): > maven-wrapper-parent-3.1.0-source-release.zip sha512: > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
+1 On Mon, Dec 13, 2021 at 10:09 PM Hervé BOUTEMY wrote: > Hi, > > We solved 18 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-1679/ > > https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip > > Source release checksum(s): > maven-wrapper-parent-3.1.0-source-release.zip sha512: > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
RE: [VOTE] Release Apache Maven Wrapper version 3.1.0
+1 (non-binding) Built on Windows 10 with Java 11.0.13 Chris [MINOR] Download all staged artifacts under the url specified in the release vote email. - Archive doesn't have "apache" in its name [OK] Verify the signature is correct. [OK] Check if the signature references an Apache email address. [MINOR] Verify the SHA512 hashes. - No SHA512 hashes, just MD5 and SHA1, but these were correct. [OK] Unzip the archive. [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. - No RELEASE_NOTES [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] Run RAT externally to ensure there are no surprises. [OK] Search for SNAPSHOT references: Only found some in the dummy website copy in the integration-tests - SNAPSHOT references only in input to integration-tests [OK] Search for Copyright references, and if they are in headers, make sure these files containing them are mentioned in the LICENSE file. [OK] Build the project according to the information in the README.md file. - No build instructions in README ... did a simple maven build. -Original Message- From: Hervé BOUTEMY Sent: Montag, 13. Dezember 2021 22:10 To: Maven Developers List Subject: [VOTE] Release Apache Maven Wrapper version 3.1.0 Hi, We solved 18 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text Staging repo: https://repository.apache.org/content/repositories/maven-1679/ https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip Source release checksum(s): maven-wrapper-parent-3.1.0-source-release.zip sha512: 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
user documentation is as usual not in README but on the site https://maven.apache.org/wrapper/ you are supposed to use "mvn wrapper:wrapper" initially to have a smooth out of the box user experience (using our staging repository to download the plugin) Regards, Hervé Le mardi 14 décembre 2021, 14:26:26 CET Enrico Olivelli a écrit : > I have checked the artifacts and they look good. > The build passes on Mac on JDK11 (Adoptium) > > I am trying to use the binary produced by the build > > I am facing this error: > > enrico.olivelli@xxx target % MVNW_VERBOSE=true ./mvnw > > > Found .mvn/wrapper/maven-wrapper.jar > > /Users/enrico.olivelli/dev/tmp/maven-wrapper-parent-3.1.0/maven-wrapper-dist > ribution/target > > Apache Maven Wrapper 3.1.0 > > Exception in thread "main" java.lang.RuntimeException: Wrapper properties > file > '/Users/enrico.olivelli/dev/tmp/maven-wrapper-parent-3.1.0/maven-wrapper-dis > tribution/target/.mvn/wrapper/maven-wrapper.properties' does not exist. > > at > org.apache.maven.wrapper.WrapperExecutor.forWrapperPropertiesFile(WrapperExe > cutor.java:66) > > at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:71) > > Is there something wrong ? > > There README file does not tell much about how to use it > (same contents as here https://github.com/apache/maven-wrapper) > > > Enrico > > > > Enrico > > Il giorno mar 14 dic 2021 alle ore 12:17 Hervé BOUTEMY < > > herve.bout...@free.fr> ha scritto: > > SNAPSHOTs are available from > > > > https://repository.apache.org/content/repositories/snapshots/ > > > > Le mardi 14 décembre 2021, 07:53:40 CET Dan Tran a écrit : > > > Hi > > > > > > Could you deploy a snapshot? my company repository manager does not > > > > proxy > > > > > staging repos. > > > > > > Can build from tag, generate the wrapper files, and run mvnw on some > > > > other > > > > > host, it will fail if I use the staging RC, but I can pull > > > maven-wrapper.jar from snapshot > > > > > > Thanks > > > > > > -D > > > > > > On Mon, Dec 13, 2021 at 1:12 PM Manfred Moser > > > > > > wrote: > > > > Awesome. Thank you Herve. > > > > > > > > + 100 > > > > > > > > Hervé BOUTEMY wrote on 2021-12-13 13:09 (GMT -08:00): > > > > > Hi, > > > > > > > We solved 18 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > > version=12350068=Text> > > > > > > > > > Staging repo: > > > > > https://repository.apache.org/content/repositories/maven-1679/ > > > > https://repository.apache.org/content/repositories/maven-1679/org/apache/m > > > > aven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source- > > > > > > release.zip> > > > > > > > > > Source release checksum(s): > > > > > > > maven-wrapper-parent-3.1.0-source-release.zip sha512: > > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14 > > > > > > 975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9> > > > > > > > > > Staging site: > > > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > Vote open for at least 72 hours. > > > > > > > > > > [ ] +1 > > > > > [ ] +0 > > > > > [ ] -1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > - > > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
I have checked the artifacts and they look good. The build passes on Mac on JDK11 (Adoptium) I am trying to use the binary produced by the build I am facing this error: enrico.olivelli@xxx target % MVNW_VERBOSE=true ./mvnw Found .mvn/wrapper/maven-wrapper.jar /Users/enrico.olivelli/dev/tmp/maven-wrapper-parent-3.1.0/maven-wrapper-distribution/target Apache Maven Wrapper 3.1.0 Exception in thread "main" java.lang.RuntimeException: Wrapper properties file '/Users/enrico.olivelli/dev/tmp/maven-wrapper-parent-3.1.0/maven-wrapper-distribution/target/.mvn/wrapper/maven-wrapper.properties' does not exist. at org.apache.maven.wrapper.WrapperExecutor.forWrapperPropertiesFile(WrapperExecutor.java:66) at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:71) Is there something wrong ? There README file does not tell much about how to use it (same contents as here https://github.com/apache/maven-wrapper) Enrico Enrico Il giorno mar 14 dic 2021 alle ore 12:17 Hervé BOUTEMY < herve.bout...@free.fr> ha scritto: > SNAPSHOTs are available from > https://repository.apache.org/content/repositories/snapshots/ > > Le mardi 14 décembre 2021, 07:53:40 CET Dan Tran a écrit : > > Hi > > > > Could you deploy a snapshot? my company repository manager does not > proxy > > staging repos. > > > > Can build from tag, generate the wrapper files, and run mvnw on some > other > > host, it will fail if I use the staging RC, but I can pull > > maven-wrapper.jar from snapshot > > > > Thanks > > > > -D > > > > On Mon, Dec 13, 2021 at 1:12 PM Manfred Moser > > > > wrote: > > > Awesome. Thank you Herve. > > > > > > + 100 > > > > > > Hervé BOUTEMY wrote on 2021-12-13 13:09 (GMT -08:00): > > > > Hi, > > > > > > > We solved 18 issues: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > version=12350068=Text> > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-1679/ > > > > > > > https://repository.apache.org/content/repositories/maven-1679/org/apache/m > > > > aven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source- > > > release.zip> > > > > Source release checksum(s): > > > > > > > maven-wrapper-parent-3.1.0-source-release.zip sha512: > > > > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14 > > > 975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9> > > > > Staging site: > > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > > > Guide to testing staged releases: > > > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > > Vote open for at least 72 hours. > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > > > > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
SNAPSHOTs are available from https://repository.apache.org/content/repositories/snapshots/ Le mardi 14 décembre 2021, 07:53:40 CET Dan Tran a écrit : > Hi > > Could you deploy a snapshot? my company repository manager does not proxy > staging repos. > > Can build from tag, generate the wrapper files, and run mvnw on some other > host, it will fail if I use the staging RC, but I can pull > maven-wrapper.jar from snapshot > > Thanks > > -D > > On Mon, Dec 13, 2021 at 1:12 PM Manfred Moser > > wrote: > > Awesome. Thank you Herve. > > > > + 100 > > > > Hervé BOUTEMY wrote on 2021-12-13 13:09 (GMT -08:00): > > > Hi, > > > > > We solved 18 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > version=12350068=Text> > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1679/ > > > > https://repository.apache.org/content/repositories/maven-1679/org/apache/m > > aven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source- > > release.zip> > > > Source release checksum(s): > > > > > maven-wrapper-parent-3.1.0-source-release.zip sha512: > > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14 > > 975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9> > > > Staging site: > > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > > > Guide to testing staged releases: > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for at least 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
You can build locally and test that way as well. I used to do that with local repository as well as a locally running repository manager (Sonatype Nexus). Manfred Dan Tran wrote on 2021-12-13 22:53 (GMT -08:00): > Hi > > Could you deploy a snapshot? my company repository manager does not proxy > staging repos. > > Can build from tag, generate the wrapper files, and run mvnw on some other > host, it will fail if I use the staging RC, but I can pull > maven-wrapper.jar from snapshot > > Thanks > > -D > > On Mon, Dec 13, 2021 at 1:12 PM Manfred Moser > wrote: > >> Awesome. Thank you Herve. >> >> + 100 >> >> Hervé BOUTEMY wrote on 2021-12-13 13:09 (GMT -08:00): >> >> > Hi, >> > >> > We solved 18 issues: >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text >> > >> > Staging repo: >> > https://repository.apache.org/content/repositories/maven-1679/ >> > >> https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip >> > >> > Source release checksum(s): >> > maven-wrapper-parent-3.1.0-source-release.zip sha512: >> > >> 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 >> > >> > Staging site: >> > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ >> > >> > Guide to testing staged releases: >> > https://maven.apache.org/guides/development/guide-testing-releases.html >> > >> > Vote open for at least 72 hours. >> > >> > [ ] +1 >> > [ ] +0 >> > [ ] -1 >> > >> > >> > >> > >> > - >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> > For additional commands, e-mail: dev-h...@maven.apache.org >> > >> > >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
Hi Could you deploy a snapshot? my company repository manager does not proxy staging repos. Can build from tag, generate the wrapper files, and run mvnw on some other host, it will fail if I use the staging RC, but I can pull maven-wrapper.jar from snapshot Thanks -D On Mon, Dec 13, 2021 at 1:12 PM Manfred Moser wrote: > Awesome. Thank you Herve. > > + 100 > > Hervé BOUTEMY wrote on 2021-12-13 13:09 (GMT -08:00): > > > Hi, > > > > We solved 18 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1679/ > > > https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip > > > > Source release checksum(s): > > maven-wrapper-parent-3.1.0-source-release.zip sha512: > > > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 > > > > Staging site: > > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Wrapper version 3.1.0
Awesome. Thank you Herve. + 100 Hervé BOUTEMY wrote on 2021-12-13 13:09 (GMT -08:00): > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-1679/ > https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip > > Source release checksum(s): > maven-wrapper-parent-3.1.0-source-release.zip sha512: > 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 > > Staging site: > https://maven.apache.org/wrapper-archives/wrapper-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven Wrapper version 3.1.0
Hi, We solved 18 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068=Text Staging repo: https://repository.apache.org/content/repositories/maven-1679/ https://repository.apache.org/content/repositories/maven-1679/org/apache/maven/wrapper/maven-wrapper-parent/3.1.0/maven-wrapper-parent-3.1.0-source-release.zip Source release checksum(s): maven-wrapper-parent-3.1.0-source-release.zip sha512: 9b7362c956cd24e21b46b290e154893ae35fd38431b6fe80f035cd17a97806e9221c71ac14975692f2a948ad25489f5b9d9bbb72441f9ab5eb541da0a86bdef9 Staging site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
ITs updated to run mvnw MWRAPPER-22 proven to require to reapply the fix: done (surprising that nobody found that bug in Wrapper 0.5.6 and previous for more than 2 years...) release ready to be done: I'll launch it tonight Regards, Hervé Le dimanche 12 décembre 2021, 19:05:33 CET Robert Scholte a écrit : > Jason, > > my point is that i DID write integration tests as part of the donation > to better understand the code, improve the codebase and its reliability. > While writing them I did find several issues, some caused because the > scripts didn't get in sync with the Maven core scripts. > So it is possible to automate these tests, they are there, somebody just > has to ported them to the new project. > Also with the change of strategy how the wrapper should work we need > integration-tests to confirm it all works. > We shouldn't gamble, as almost every release people will only test is > _after_ its vote, which is just too late. > > Robert > > [1] > https://github.com/apache/maven-integration-testing/tree/master/core-it-suit > e/src/test/resources/mng-5937%20wrapper > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 12-12-2021 13:54:16 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >Clearly no one here disagrees with the goal of having robust testing for > >software that is made available to users. > > > >As to the timing of that testing being complete for the wrapper, to the > >satisfaction of those objecting to a release, I will argue. > > > >Do we wait four years for adequate testing? I’m not being facetious because > >we’re rolling up on three years since the initial donation of the wrapper > >was made. No one can force anyone else to do work here, sometimes things > >take a while, and there still may be a great deal of time that passes > >before testing is present that is considered adequate. > > > >All else being equal, I think the value of a release to remove the state of > >limbo the wrapper has been in for years outweighs the current lack of > >testing. The wrapper has been in use for 8 years, and while more testing > >is preferred we have reasonable assurances it works as expected. I don’t > >think we’ll be back to zero if we find issues, they can be fixed and will > >be accompanied by tests as most things here are. Right now from a user’s > >perspective the wrapper appears dead at Takari and Apache which is a > >shame. > > > >Would everyone be amenable to an alpha release? And transition to a > >non-alpha release when everyone agrees the testing is sufficient? > > > >jvz > > > >> On Dec 12, 2021, at 5:14 AM, Maarten Mulders > >> wrote: > >> > >> Chiming in a little late, but here are my 2 cents nevertheless. I would > >> not feel confident releasing something that we cannot test in an > >> automated way. Not having an integration test suite means we don't know > >> for sure if it works. And if we know it works and we change something, > >> we're back to zero. > >> > >> To me, this has nothing to do with a (misplaced) drive for perfection. > >> It is all about making sure we ship something to users that we know to > >> work, and that we can easily prove to still work after we change it. > >> > >> Thanks, > >> > >> Maarten > >> > >> On 11/12/2021 13:43, Robert Scholte wrote: > >>> It was marked for Maven 4, and part of the improvements was test > >>> automation, which was now possible because it became part of Maven > >>> Core. Even thought the code still exists in Maven Core, is has now > >>> become useless. There hasn't been a real need for new releases of > >>> Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper > >>> would have been another feature to attract developers to Maven 4. And > >>> finally, I see that the donated code has been used as base, ignoring > >>> all the effort done to improve that codebase done afterwards. Hence my > >>> response that reliability is gone that was added after donation. > >>> Robert > >>> -- Origineel bericht -- > >>> Van: "Manfred Moser" > >>> Aan: dev@maven.apache.org > >>> Verzonden: 10-12-2021 20:58:33 > >>> Onderwerp: Re: reviewing Maven Wrapper before releasing > >>> > >>>> I totally agree with finally just shipping this. We got this all > >>>> donated about two years
Re: reviewing Maven Wrapper before releasing
Robert, I’m actually not sure what you are implying. Are you saying that you’re going to block the release until someone ports your tests over? Or you’re going to block the release of the separate wrapper? I don’t think anyone disagrees that the tests can be fully automated.I don’t think it’s absolutely necessary for the first release from Apache. We do the best we can, when we can. As for users only trying releases, does this surprise anyone? I don’t think so. It’s something to embrace. If we find a bunch of things wrong with the release we’ll fix them, add tests, and release again. The wrapper is now separate so this is not hard. Overall the Maven project does an excellent job with testing but in this case it’s become a theoretical exercise devoid of user feedback which is essential to improving any piece of software. Add your tests back when you can, others might get their first or add different tests. We’ll get there. Let’s just get it into the hands of users. jvz > On Dec 12, 2021, at 1:05 PM, Robert Scholte wrote: > > Jason, > > my point is that i DID write integration tests as part of the donation to > better understand the code, improve the codebase and its reliability. > While writing them I did find several issues, some caused because the scripts > didn't get in sync with the Maven core scripts. > So it is possible to automate these tests, they are there, somebody just has > to ported them to the new project. > Also with the change of strategy how the wrapper should work we need > integration-tests to confirm it all works. > We shouldn't gamble, as almost every release people will only test is _after_ > its vote, which is just too late. > > Robert > > [1] > https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5937%20wrapper > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 12-12-2021 13:54:16 > Onderwerp: Re: reviewing Maven Wrapper before releasing > >> Clearly no one here disagrees with the goal of having robust testing for >> software that is made available to users. >> >> As to the timing of that testing being complete for the wrapper, to the >> satisfaction of those objecting to a release, I will argue. >> >> Do we wait four years for adequate testing? I’m not being facetious because >> we’re rolling up on three years since the initial donation of the wrapper >> was made. No one can force anyone else to do work here, sometimes things >> take a while, and there still may be a great deal of time that passes before >> testing is present that is considered adequate. >> >> All else being equal, I think the value of a release to remove the state of >> limbo the wrapper has been in for years outweighs the current lack of >> testing. The wrapper has been in use for 8 years, and while more testing is >> preferred we have reasonable assurances it works as expected. I don’t think >> we’ll be back to zero if we find issues, they can be fixed and will be >> accompanied by tests as most things here are. Right now from a user’s >> perspective the wrapper appears dead at Takari and Apache which is a shame. >> >> Would everyone be amenable to an alpha release? And transition to a >> non-alpha release when everyone agrees the testing is sufficient? >> >> jvz >> >>> On Dec 12, 2021, at 5:14 AM, Maarten Mulders wrote: >>> >>> Chiming in a little late, but here are my 2 cents nevertheless. I would not >>> feel confident releasing something that we cannot test in an automated way. >>> Not having an integration test suite means we don't know for sure if it >>> works. And if we know it works and we change something, we're back to zero. >>> >>> To me, this has nothing to do with a (misplaced) drive for perfection. It >>> is all about making sure we ship something to users that we know to work, >>> and that we can easily prove to still work after we change it. >>> >>> Thanks, >>> >>> Maarten >>> >>> On 11/12/2021 13:43, Robert Scholte wrote: >>>> It was marked for Maven 4, and part of the improvements was test >>>> automation, which was now possible because it became part of Maven Core. >>>> Even thought the code still exists in Maven Core, is has now become >>>> useless. >>>> There hasn't been a real need for new releases of Maven Wrapper Plugin >>>> until a range of Maven 3.8 started. >>>> Maven Wrapper would have been another feature to attract developers to >>>> Maven 4
Re: reviewing Maven Wrapper before releasing
> > Yes, that is said, we have seen this with Maven 3.8.x recently, but we > can't change people. Let's get over with and just push a release. Let it > soak in and continue with bugfixes. > > +1
Re: reviewing Maven Wrapper before releasing
Am 2021-12-12 um 19:05 schrieb Robert Scholte: Jason, my point is that i DID write integration tests as part of the donation to better understand the code, improve the codebase and its reliability. While writing them I did find several issues, some caused because the scripts didn't get in sync with the Maven core scripts. So it is possible to automate these tests, they are there, somebody just has to ported them to the new project. Also with the change of strategy how the wrapper should work we need integration-tests to confirm it all works. We shouldn't gamble, as almost every release people will only test is _after_ its vote, which is just too late. Yes, that is said, we have seen this with Maven 3.8.x recently, but we can't change people. Let's get over with and just push a release. Let it soak in and continue with bugfixes. M - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Jason, my point is that i DID write integration tests as part of the donation to better understand the code, improve the codebase and its reliability. While writing them I did find several issues, some caused because the scripts didn't get in sync with the Maven core scripts. So it is possible to automate these tests, they are there, somebody just has to ported them to the new project. Also with the change of strategy how the wrapper should work we need integration-tests to confirm it all works. We shouldn't gamble, as almost every release people will only test is _after_ its vote, which is just too late. Robert [1] https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5937%20wrapper -- Origineel bericht -- Van: "Jason van Zyl" Aan: "Maven Developers List" Verzonden: 12-12-2021 13:54:16 Onderwerp: Re: reviewing Maven Wrapper before releasing Clearly no one here disagrees with the goal of having robust testing for software that is made available to users. As to the timing of that testing being complete for the wrapper, to the satisfaction of those objecting to a release, I will argue. Do we wait four years for adequate testing? I’m not being facetious because we’re rolling up on three years since the initial donation of the wrapper was made. No one can force anyone else to do work here, sometimes things take a while, and there still may be a great deal of time that passes before testing is present that is considered adequate. All else being equal, I think the value of a release to remove the state of limbo the wrapper has been in for years outweighs the current lack of testing. The wrapper has been in use for 8 years, and while more testing is preferred we have reasonable assurances it works as expected. I don’t think we’ll be back to zero if we find issues, they can be fixed and will be accompanied by tests as most things here are. Right now from a user’s perspective the wrapper appears dead at Takari and Apache which is a shame. Would everyone be amenable to an alpha release? And transition to a non-alpha release when everyone agrees the testing is sufficient? jvz On Dec 12, 2021, at 5:14 AM, Maarten Mulders wrote: Chiming in a little late, but here are my 2 cents nevertheless. I would not feel confident releasing something that we cannot test in an automated way. Not having an integration test suite means we don't know for sure if it works. And if we know it works and we change something, we're back to zero. To me, this has nothing to do with a (misplaced) drive for perfection. It is all about making sure we ship something to users that we know to work, and that we can easily prove to still work after we change it. Thanks, Maarten On 11/12/2021 13:43, Robert Scholte wrote: It was marked for Maven 4, and part of the improvements was test automation, which was now possible because it became part of Maven Core. Even thought the code still exists in Maven Core, is has now become useless. There hasn't been a real need for new releases of Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper would have been another feature to attract developers to Maven 4. And finally, I see that the donated code has been used as base, ignoring all the effort done to improve that codebase done afterwards. Hence my response that reliability is gone that was added after donation. Robert -- Origineel bericht -- Van: "Manfred Moser" Aan: dev@maven.apache.org Verzonden: 10-12-2021 20:58:33 Onderwerp: Re: reviewing Maven Wrapper before releasing I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robe
Re: reviewing Maven Wrapper before releasing
Clearly no one here disagrees with the goal of having robust testing for software that is made available to users. As to the timing of that testing being complete for the wrapper, to the satisfaction of those objecting to a release, I will argue. Do we wait four years for adequate testing? I’m not being facetious because we’re rolling up on three years since the initial donation of the wrapper was made. No one can force anyone else to do work here, sometimes things take a while, and there still may be a great deal of time that passes before testing is present that is considered adequate. All else being equal, I think the value of a release to remove the state of limbo the wrapper has been in for years outweighs the current lack of testing. The wrapper has been in use for 8 years, and while more testing is preferred we have reasonable assurances it works as expected. I don’t think we’ll be back to zero if we find issues, they can be fixed and will be accompanied by tests as most things here are. Right now from a user’s perspective the wrapper appears dead at Takari and Apache which is a shame. Would everyone be amenable to an alpha release? And transition to a non-alpha release when everyone agrees the testing is sufficient? jvz > On Dec 12, 2021, at 5:14 AM, Maarten Mulders wrote: > > Chiming in a little late, but here are my 2 cents nevertheless. I would not > feel confident releasing something that we cannot test in an automated way. > Not having an integration test suite means we don't know for sure if it > works. And if we know it works and we change something, we're back to zero. > > To me, this has nothing to do with a (misplaced) drive for perfection. It is > all about making sure we ship something to users that we know to work, and > that we can easily prove to still work after we change it. > > Thanks, > > Maarten > > On 11/12/2021 13:43, Robert Scholte wrote: >> It was marked for Maven 4, and part of the improvements was test automation, >> which was now possible because it became part of Maven Core. >> Even thought the code still exists in Maven Core, is has now become useless. >> There hasn't been a real need for new releases of Maven Wrapper Plugin until >> a range of Maven 3.8 started. >> Maven Wrapper would have been another feature to attract developers to Maven >> 4. >> And finally, I see that the donated code has been used as base, ignoring all >> the effort done to improve that codebase done afterwards. >> Hence my response that reliability is gone that was added after donation. >> Robert >> -- Origineel bericht ------ >> Van: "Manfred Moser" >> Aan: dev@maven.apache.org >> Verzonden: 10-12-2021 20:58:33 >> Onderwerp: Re: reviewing Maven Wrapper before releasing >>> I totally agree with finally just shipping this. We got this all donated >>> about two years ago now and there is still nothing shipping. >>> >>> I used to just manually do the testing and thousands of projects are happy. >>> I assume the new project is at least manually testing and works as before >>> or better. Let's not wait nay more and let perfection get into our way. It >>> surely is good enough for a release. >>> >>> The beauty is that if you find an issue.. you just ship again ... no reason >>> to wait. >>> >>> manfred >>> >>> Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): >>> >>>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did >>>> not >>>> test, I just did not change anything using the general approach "people >>>> were >>>> happy before, just continue step by step improvements" :) >>>> >>>> reading the mvnw script (*nix), compiling+running the .java is executed >>>> only if >>>> neither wget nor curl are available on your machine >>>> >>>> reading the mvnw.cmd, it seems .java is not supported >>>> >>>> looking at Git history confirms: >>>> https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 >>>> >>>> >>>> >>>> Don't hesitate to create a Jira issue and corresponding fix to add .java >>>> support for Windows: future 3.1.0 will have one more fix over previous >>>> 0.5.6 >>>> >>>> Regards, >>>> >>>> Hervé >>>> >>>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : >>>>> I need more time. >>>>> >>>>> e.g. it l
Re: reviewing Maven Wrapper before releasing
sure, having ITs is our best bet for maintenance, particularly with the OS- dependant scripts notice that with wrapper releases being back independent from Maven core releases, the impact of any issue is not definitive: newer releases of wrapper will fix bugs and permit new features for every past and future release of Maven core = what Manfred did for years and made Maven Wrapper successful. We can safely continue this success history. Regards, Hervé Le dimanche 12 décembre 2021, 11:14:37 CET Maarten Mulders a écrit : > Chiming in a little late, but here are my 2 cents nevertheless. I would > not feel confident releasing something that we cannot test in an > automated way. Not having an integration test suite means we don't know > for sure if it works. And if we know it works and we change something, > we're back to zero. > > To me, this has nothing to do with a (misplaced) drive for perfection. > It is all about making sure we ship something to users that we know to > work, and that we can easily prove to still work after we change it. > > Thanks, > > Maarten > > On 11/12/2021 13:43, Robert Scholte wrote: > > It was marked for Maven 4, and part of the improvements was test > > automation, which was now possible because it became part of Maven Core. > > Even thought the code still exists in Maven Core, is has now become > > useless. > > > > There hasn't been a real need for new releases of Maven Wrapper Plugin > > until a range of Maven 3.8 started. > > Maven Wrapper would have been another feature to attract developers to > > Maven 4. > > > > And finally, I see that the donated code has been used as base, ignoring > > all the effort done to improve that codebase done afterwards. > > Hence my response that reliability is gone that was added after donation. > > > > Robert > > > > -- Origineel bericht -- > > Van: "Manfred Moser" > > Aan: dev@maven.apache.org > > Verzonden: 10-12-2021 20:58:33 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > >> I totally agree with finally just shipping this. We got this all > >> donated about two years ago now and there is still nothing shipping. > >> > >> I used to just manually do the testing and thousands of projects are > >> happy. I assume the new project is at least manually testing and works > >> as before or better. Let's not wait nay more and let perfection get > >> into our way. It surely is good enough for a release. > >> > >> The beauty is that if you find an issue.. you just ship again ... no > >> reason to wait. > >> > >> manfred > >> > >> Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > >>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I > >>> did not > >>> test, I just did not change anything using the general approach > >>> "people were > >>> happy before, just continue step by step improvements" :) > >>> > >>> reading the mvnw script (*nix), compiling+running the .java is > >>> executed only if > >>> neither wget nor curl are available on your machine > >>> > >>> reading the mvnw.cmd, it seems .java is not supported > >>> > >>> looking at Git history confirms: > >>> https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7 > >>> 746d01b00e70337 > >>> > >>> > >>> > >>> Don't hesitate to create a Jira issue and corresponding fix to add > >>> .java > >>> support for Windows: future 3.1.0 will have one more fix over > >>> previous 0.5.6 > >>> > >>> Regards, > >>> > >>> Hervé > >>> > >>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > >>>> I need more time. > >>>> > >>>> e.g. it looks like type=source doesn't use the Java sourcefile to > >>>> download the wrapper. > >>>> now that the plugin and wrapper are combined in one project, the > >>>> ITs are > >>>> incomplete. > >>>> They should call both the wrapper-goal and something like 'mvnw > >>>> --version' to ensure it is working (this used to be done in > >>>> maven-integration-testing) > >>>> > >>>> thanks, > >>>> Robert > >>>> > >>>> -- Origineel bericht -- > >>>
Re: reviewing Maven Wrapper before releasing
Chiming in a little late, but here are my 2 cents nevertheless. I would not feel confident releasing something that we cannot test in an automated way. Not having an integration test suite means we don't know for sure if it works. And if we know it works and we change something, we're back to zero. To me, this has nothing to do with a (misplaced) drive for perfection. It is all about making sure we ship something to users that we know to work, and that we can easily prove to still work after we change it. Thanks, Maarten On 11/12/2021 13:43, Robert Scholte wrote: It was marked for Maven 4, and part of the improvements was test automation, which was now possible because it became part of Maven Core. Even thought the code still exists in Maven Core, is has now become useless. There hasn't been a real need for new releases of Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper would have been another feature to attract developers to Maven 4. And finally, I see that the donated code has been used as base, ignoring all the effort done to improve that codebase done afterwards. Hence my response that reliability is gone that was added after donation. Robert -- Origineel bericht -- Van: "Manfred Moser" Aan: dev@maven.apache.org Verzonden: 10-12-2021 20:58:33 Onderwerp: Re: reviewing Maven Wrapper before releasing I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For add
Re: reviewing Maven Wrapper before releasing
The improvements can still be applied. My understanding was that it was planned for the next Maven release. And that was 4 at the time .. however that changed and we have had no released maintained wrapper for two years now. Lets just move on with the release of the wrapper in Apache and then improve however desired. Manfred Robert Scholte wrote on 2021-12-11 04:43 (GMT -08:00): > It was marked for Maven 4, and part of the improvements was test > automation, which was now possible because it became part of Maven Core. > Even thought the code still exists in Maven Core, is has now become > useless. > > There hasn't been a real need for new releases of Maven Wrapper Plugin > until a range of Maven 3.8 started. > Maven Wrapper would have been another feature to attract developers to > Maven 4. > > And finally, I see that the donated code has been used as base, ignoring > all the effort done to improve that codebase done afterwards. > Hence my response that reliability is gone that was added after > donation. > > Robert > > -- Origineel bericht -- > Van: "Manfred Moser" > Aan: dev@maven.apache.org > Verzonden: 10-12-2021 20:58:33 > Onderwerp: Re: reviewing Maven Wrapper before releasing > >>I totally agree with finally just shipping this. We got this all donated about >>two years ago now and there is still nothing shipping. >> >>I used to just manually do the testing and thousands of projects are happy. I >>assume the new project is at least manually testing and works as before or >>better. Let's not wait nay more and let perfection get into our way. It surely >>is good enough for a release. >> >>The beauty is that if you find an issue.. you just ship again ... no reason to >>wait. >> >>manfred >> >>Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): >> >>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not >>> test, I just did not change anything using the general approach "people >>> were >>> happy before, just continue step by step improvements" :) >>> >>> reading the mvnw script (*nix), compiling+running the .java is executed >>> only >>> if >>> neither wget nor curl are available on your machine >>> >>> reading the mvnw.cmd, it seems .java is not supported >>> >>> looking at Git history confirms: >>>https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 >>> >>> >>> Don't hesitate to create a Jira issue and corresponding fix to add .java >>> support for Windows: future 3.1.0 will have one more fix over previous >>> 0.5.6 >>> >>> Regards, >>> >>> Hervé >>> >>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : >>>> I need more time. >>>> >>>> e.g. it looks like type=source doesn't use the Java sourcefile to >>>> download the wrapper. >>>> now that the plugin and wrapper are combined in one project, the ITs are >>>> incomplete. >>>> They should call both the wrapper-goal and something like 'mvnw >>>> --version' to ensure it is working (this used to be done in >>>> maven-integration-testing) >>>> >>>> thanks, >>>> Robert >>>> >>>> -- Origineel bericht -- >>>> Van: "Hervé BOUTEMY" >>>> Aan: "Maven Developers List" >>>> Verzonden: 10-12-2021 08:08:57 >>>> Onderwerp: Re: reviewing Maven Wrapper before releasing >>>> >>>> >thank you to everybody who reviewed, discussed, contributed >>>> > >>>> >we now have 16 issues fixed, everything seems stable >>>> > >>>> >if nobody objects, I'll start a release over the week-end >>>> > >>>> >Regards, >>>> > >>>> >Hervé >>>> > >>>> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >>>> >> Hi, >>>> >> >>>> >> Maven Wrapper has been donated to Apache Maven, imported to >>>> >> >>>> >>https://github.com/apache/maven-wrapper >>>> >> >>>> >> Documentation published to https://maven.apache.org/wrapper/ >>>> >> >>>> >> Here is the list of fixes from previous 0.5.6 release: >>>> >>>> >>https://issues.apache.org
Re: reviewing Maven Wrapper before releasing
It was marked for Maven 4, and part of the improvements was test automation, which was now possible because it became part of Maven Core. Even thought the code still exists in Maven Core, is has now become useless. There hasn't been a real need for new releases of Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper would have been another feature to attract developers to Maven 4. And finally, I see that the donated code has been used as base, ignoring all the effort done to improve that codebase done afterwards. Hence my response that reliability is gone that was added after donation. Robert -- Origineel bericht -- Van: "Manfred Moser" Aan: dev@maven.apache.org Verzonden: 10-12-2021 20:58:33 Onderwerp: Re: reviewing Maven Wrapper before releasing I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Maybe mrm-maven-plugin can be used for mock Central for downloading wrapper. sob., 11 gru 2021 o 09:03 Hervé BOUTEMY napisał(a): > I'm trying an "exec:exec" approach > https://github.com/apache/maven-wrapper/tree/it_run_mvnw > > the only tricky case is for source distribution type to download the > wrapper > that is not available on central > > perhaps I'll simply skip that one for now: we'll have time to improve later > > Le vendredi 10 décembre 2021, 12:56:23 CET Slawomir Jaranowski a écrit : > > In order to run proper IT test by maven-invoker-plugin we should provide > > invoker.properties like: > > > > invoker.goals.1 = wraper:wrapper > > > > invoker.goals.2 = validate > > invoker.mavenExecutable.2 = ./mvnw > > invoker.os.family.2 = unix, mac > > > > invoker.goals.3 = validate > > invoker.mavenExecutable.3 = ./mvnw.cmd > > invoker.os.family.3 = windows > > > > but > > - mavenExecutable - can be set on global configuration only > > - invoker.os.family - not support indexing ... > > > > So first improvement on maven-invoker-plugin will be needed ... > > or switch to another tools for IT testing > > or try to complicate maven-invoker configuration - I don't sure if will > be > > posible > > > > I can take care about changes in maven-invoker-plugin if you wish > > > > pt., 10 gru 2021 o 11:03 Robert Scholte > napisał(a): > > > I need more time. > > > > > > e.g. it looks like type=source doesn't use the Java sourcefile to > > > download the wrapper. > > > now that the plugin and wrapper are combined in one project, the ITs > are > > > incomplete. > > > They should call both the wrapper-goal and something like 'mvnw > > > --version' to ensure it is working (this used to be done in > > > maven-integration-testing) > > > > > > thanks, > > > Robert > > > > > > -- Origineel bericht -- > > > Van: "Hervé BOUTEMY" > > > Aan: "Maven Developers List" > > > Verzonden: 10-12-2021 08:08:57 > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > >thank you to everybody who reviewed, discussed, contributed > > > > > > > >we now have 16 issues fixed, everything seems stable > > > > > > > >if nobody objects, I'll start a release over the week-end > > > > > > > >Regards, > > > > > > > >Hervé > > > > > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > > > >> Hi, > > > >> > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > >> > > > >>https://github.com/apache/maven-wrapper > > > >> > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > ve> > > > >> rsion=12350068 > > > >> > > > >> > > > >> Please test and review so we can do a release soon > > > >> > > > >> Regards, > > > >> > > > >> Hervé > > > >> > > > >> > > > >> > > > >> > - > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > >- > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
I'm trying an "exec:exec" approach https://github.com/apache/maven-wrapper/tree/it_run_mvnw the only tricky case is for source distribution type to download the wrapper that is not available on central perhaps I'll simply skip that one for now: we'll have time to improve later Le vendredi 10 décembre 2021, 12:56:23 CET Slawomir Jaranowski a écrit : > In order to run proper IT test by maven-invoker-plugin we should provide > invoker.properties like: > > invoker.goals.1 = wraper:wrapper > > invoker.goals.2 = validate > invoker.mavenExecutable.2 = ./mvnw > invoker.os.family.2 = unix, mac > > invoker.goals.3 = validate > invoker.mavenExecutable.3 = ./mvnw.cmd > invoker.os.family.3 = windows > > but > - mavenExecutable - can be set on global configuration only > - invoker.os.family - not support indexing ... > > So first improvement on maven-invoker-plugin will be needed ... > or switch to another tools for IT testing > or try to complicate maven-invoker configuration - I don't sure if will be > posible > > I can take care about changes in maven-invoker-plugin if you wish > > pt., 10 gru 2021 o 11:03 Robert Scholte napisał(a): > > I need more time. > > > > e.g. it looks like type=source doesn't use the Java sourcefile to > > download the wrapper. > > now that the plugin and wrapper are combined in one project, the ITs are > > incomplete. > > They should call both the wrapper-goal and something like 'mvnw > > --version' to ensure it is working (this used to be done in > > maven-integration-testing) > > > > thanks, > > Robert > > > > -- Origineel bericht -- > > Van: "Hervé BOUTEMY" > > Aan: "Maven Developers List" > > Verzonden: 10-12-2021 08:08:57 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > >thank you to everybody who reviewed, discussed, contributed > > > > > >we now have 16 issues fixed, everything seems stable > > > > > >if nobody objects, I'll start a release over the week-end > > > > > >Regards, > > > > > >Hervé > > > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > > >> Hi, > > >> > > >> Maven Wrapper has been donated to Apache Maven, imported to > > >> > > >>https://github.com/apache/maven-wrapper > > >> > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > >> Here is the list of fixes from previous 0.5.6 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > ve> > > >> rsion=12350068 > > >> > > >> > > >> Please test and review so we can do a release soon > > >> > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >- > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
+1 On Fri, Dec 10, 2021, 20:58 Manfred Moser wrote: > I totally agree with finally just shipping this. We got this all donated > about two years ago now and there is still nothing shipping. > > I used to just manually do the testing and thousands of projects are > happy. I assume the new project is at least manually testing and works as > before or better. Let's not wait nay more and let perfection get into our > way. It surely is good enough for a release. > > The beauty is that if you find an issue.. you just ship again ... no > reason to wait. > > manfred > > Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > > > the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did > not > > test, I just did not change anything using the general approach "people > were > > happy before, just continue step by step improvements" :) > > > > reading the mvnw script (*nix), compiling+running the .java is executed > only if > > neither wget nor curl are available on your machine > > > > reading the mvnw.cmd, it seems .java is not supported > > > > looking at Git history confirms: > > > https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 > > > > > > Don't hesitate to create a Jira issue and corresponding fix to add .java > > support for Windows: future 3.1.0 will have one more fix over previous > 0.5.6 > > > > Regards, > > > > Hervé > > > > Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > >> I need more time. > >> > >> e.g. it looks like type=source doesn't use the Java sourcefile to > >> download the wrapper. > >> now that the plugin and wrapper are combined in one project, the ITs are > >> incomplete. > >> They should call both the wrapper-goal and something like 'mvnw > >> --version' to ensure it is working (this used to be done in > >> maven-integration-testing) > >> > >> thanks, > >> Robert > >> > >> -- Origineel bericht -- > >> Van: "Hervé BOUTEMY" > >> Aan: "Maven Developers List" > >> Verzonden: 10-12-2021 08:08:57 > >> Onderwerp: Re: reviewing Maven Wrapper before releasing > >> > >> >thank you to everybody who reviewed, discussed, contributed > >> > > >> >we now have 16 issues fixed, everything seems stable > >> > > >> >if nobody objects, I'll start a release over the week-end > >> > > >> >Regards, > >> > > >> >Hervé > >> > > >> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >> >> Hi, > >> >> > >> >> Maven Wrapper has been donated to Apache Maven, imported to > >> >> > >> >>https://github.com/apache/maven-wrapper > >> >> > >> >> Documentation published to https://maven.apache.org/wrapper/ > >> >> > >> >> Here is the list of fixes from previous 0.5.6 release: > >> >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > >> >>ve>> > >> >> rsion=12350068 > >> >> > >> >> > >> >> Please test and review so we can do a release soon > >> >> > >> >> Regards, > >> >> > >> >> Hervé > >> >> > >> >> > >> >> > >> >> > - > >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > >> >- > >> >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: reviewing Maven Wrapper before releasing
I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not > test, I just did not change anything using the general approach "people were > happy before, just continue step by step improvements" :) > > reading the mvnw script (*nix), compiling+running the .java is executed only > if > neither wget nor curl are available on your machine > > reading the mvnw.cmd, it seems .java is not supported > > looking at Git history confirms: > https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 > > > Don't hesitate to create a Jira issue and corresponding fix to add .java > support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 > > Regards, > > Hervé > > Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : >> I need more time. >> >> e.g. it looks like type=source doesn't use the Java sourcefile to >> download the wrapper. >> now that the plugin and wrapper are combined in one project, the ITs are >> incomplete. >> They should call both the wrapper-goal and something like 'mvnw >> --version' to ensure it is working (this used to be done in >> maven-integration-testing) >> >> thanks, >> Robert >> >> -- Origineel bericht -- >> Van: "Hervé BOUTEMY" >> Aan: "Maven Developers List" >> Verzonden: 10-12-2021 08:08:57 >> Onderwerp: Re: reviewing Maven Wrapper before releasing >> >> >thank you to everybody who reviewed, discussed, contributed >> > >> >we now have 16 issues fixed, everything seems stable >> > >> >if nobody objects, I'll start a release over the week-end >> > >> >Regards, >> > >> >Hervé >> > >> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> >> Hi, >> >> >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >> >> >>https://github.com/apache/maven-wrapper >> >> >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> >> >> Here is the list of fixes from previous 0.5.6 release: >> >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >> >>ve>> >> >> rsion=12350068 >> >> >> >> >> >> Please test and review so we can do a release soon >> >> >> >> Regards, >> >> >> >> Hervé >> >> >> >> >> >> >> >> - >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> >> For additional commands, e-mail: dev-h...@maven.apache.org >> > >> >- >> >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> >For additional commands, e-mail: dev-h...@maven.apache.org >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
To me there's a very important piece missing. For the maven-wrapper-plugin I wrote several ITs to proof that downloading and unpacking works with all kinds of combinations of parameters. With the maven-wrapper code moved to this project, there no coverage at all to the actual wrapper code. Unlike maven-integration-testing there's no proof that mvnw works, because maven-invoker-plugin will keep using mvn. It needs to be improved like done with maven-verifier[1] (which is used by maven-integration-testing) IMO we should not release this maven-wrapper under pressure until this is solved: we should automatically verify that the scripts work now, as with any feature change. At its current state we've dropped in reliability compared to the maven-wrapper module in Maven Core. thanks, Robert [1] https://issues.apache.org/jira/browse/MSHARED-855 -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 13:13:41 Onderwerp: Re: reviewing Maven Wrapper before releasing the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > I need more time. > > e.g. it looks like type=source doesn't use the Java sourcefile to > download the wrapper. > now that the plugin and wrapper are combined in one project, the ITs are > incomplete. > They should call both the wrapper-goal and something like 'mvnw > --version' to ensure it is working (this used to be done in > maven-integration-testing) > > thanks, > Robert > > -- Origineel bericht -- > Van: "Hervé BOUTEMY" > Aan: "Maven Developers List" > Verzonden: 10-12-2021 08:08:57 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >thank you to everybody who reviewed, discussed, contributed > > > >we now have 16 issues fixed, everything seems stable > > > >if nobody objects, I'll start a release over the week-end > > > >Regards, > > > >Hervé > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >> > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > >>ve>> > >> rsion=12350068 > >> > >> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
In order to run proper IT test by maven-invoker-plugin we should provide invoker.properties like: invoker.goals.1 = wraper:wrapper invoker.goals.2 = validate invoker.mavenExecutable.2 = ./mvnw invoker.os.family.2 = unix, mac invoker.goals.3 = validate invoker.mavenExecutable.3 = ./mvnw.cmd invoker.os.family.3 = windows but - mavenExecutable - can be set on global configuration only - invoker.os.family - not support indexing ... So first improvement on maven-invoker-plugin will be needed ... or switch to another tools for IT testing or try to complicate maven-invoker configuration - I don't sure if will be posible I can take care about changes in maven-invoker-plugin if you wish pt., 10 gru 2021 o 11:03 Robert Scholte napisał(a): > I need more time. > > e.g. it looks like type=source doesn't use the Java sourcefile to > download the wrapper. > now that the plugin and wrapper are combined in one project, the ITs are > incomplete. > They should call both the wrapper-goal and something like 'mvnw > --version' to ensure it is working (this used to be done in > maven-integration-testing) > > thanks, > Robert > > -- Origineel bericht -- > Van: "Hervé BOUTEMY" > Aan: "Maven Developers List" > Verzonden: 10-12-2021 08:08:57 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >thank you to everybody who reviewed, discussed, contributed > > > >we now have 16 issues fixed, everything seems stable > > > >if nobody objects, I'll start a release over the week-end > > > >Regards, > > > >Hervé > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721 > >> rsion=12350068 > >> > >> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing thank you to everybody who reviewed, discussed, contributed we now have 16 issues fixed, everything seems stable if nobody objects, I'll start a release over the week-end Regards, Hervé Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : Hi, Maven Wrapper has been donated to Apache Maven, imported to https://github.com/apache/maven-wrapper Documentation published to https://maven.apache.org/wrapper/ Here is the list of fixes from previous 0.5.6 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721 rsion=12350068 Please test and review so we can do a release soon Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
thank you to everybody who reviewed, discussed, contributed we now have 16 issues fixed, everything seems stable if nobody objects, I'll start a release over the week-end Regards, Hervé Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > Hi, > > Maven Wrapper has been donated to Apache Maven, imported to > https://github.com/apache/maven-wrapper > > Documentation published to https://maven.apache.org/wrapper/ > > Here is the list of fixes from previous 0.5.6 release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721 > rsion=12350068 > > > Please test and review so we can do a release soon > > Regards, > > Hervé > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
awesome. Thanks On Thu, Dec 9, 2021 at 12:43 AM Hervé BOUTEMY wrote: > this is the fix in https://issues.apache.org/jira/browse/MWRAPPER-18 > > with wrapper 0.5.6, there was a fixed Maven version hard coded in maven- > wrapper.jar and inconsistent local installation directory name (see Jira > issue > for detailed description) > > with MWRAPPER-18, from the distributionUrl in maven-wrapper.properties, it > replaces the repository prefix: see the commit > > Regards, > > Hervé > > Le jeudi 9 décembre 2021, 09:19:09 CET Dan Tran a écrit : > > That works, but how does it figure out the maven version to compute the > > full URL to download? > > > > Thanks > > > > -D > > > > On Wed, Dec 8, 2021 at 11:10 PM Hervé BOUTEMY > wrote: > > > there is MVNW_REPOURL system property > > > https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager > > > > > > with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 > > > (showing concrete usage output) > > > > > > Is it what you expected? > > > > > > Regards, > > > > > > Hervé > > > > > > Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > > > > sorry for hi-jack this thread. is it possible to configure mvnw to > use > > > > a > > > > new location of distributionUrl on the fly? (without touching > > > > maven-wrapper.properties) > > > > > > > > Thanks > > > > > > > > -D > > > > > > > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski < > > > > > > s.jaranow...@gmail.com> > > > > > > > wrote: > > > > > In current project configuration it is a bug rather ... We can use > a > > > > > wrapper with java 5 but we can't install it because the plugin > > > > > requires > > > > > java 8 ... > > > > > > > > > > śr., 8 gru 2021 o 20:18 Xeno Amess > napisał(a): > > > > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > > > > 8 is the minimum version normal people can accept，others be > zombies > > > > > > who > > > > > > > > do > > > > > > > > > > > not need to be maintained IMO. They can use original wrapper > plugin > > > > > > > > > > anyway. > > > > > > > > > > > If we do not force them when beginning，it is harder to add the > > > > > > liminition > > > > > > later. > > > > > > > > > > > > XenoAmess > > > > > > ____ > > > > > > From: Slawomir Jaranowski > > > > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > > > > To: Maven Developers List > > > > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > > > I created issues with the proposition of improvement: > > > > > > > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > > > > > > > please assign a version to fix ... if it is applicable. > > > > > > > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > > > > > > > napisał(a): > > > > > > > because it's as it was imported: > > > > > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > > > > I refactored but kept everything as equivalent as possible > > > > > > > > > > > > > > we can update the value if it has an interest, with associated > > > > > > > Jira > > > > > > > > > > issue > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > Hervé > > > > > > > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a > > > > > > écrit > > > > > > > > > > > Next question: > > > > > > > > - why use java 5 in maven-wrapper module .. it is not > possible > > > > > > > > build > >
Re: reviewing Maven Wrapper before releasing
this is the fix in https://issues.apache.org/jira/browse/MWRAPPER-18 with wrapper 0.5.6, there was a fixed Maven version hard coded in maven- wrapper.jar and inconsistent local installation directory name (see Jira issue for detailed description) with MWRAPPER-18, from the distributionUrl in maven-wrapper.properties, it replaces the repository prefix: see the commit Regards, Hervé Le jeudi 9 décembre 2021, 09:19:09 CET Dan Tran a écrit : > That works, but how does it figure out the maven version to compute the > full URL to download? > > Thanks > > -D > > On Wed, Dec 8, 2021 at 11:10 PM Hervé BOUTEMY wrote: > > there is MVNW_REPOURL system property > > https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager > > > > with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 > > (showing concrete usage output) > > > > Is it what you expected? > > > > Regards, > > > > Hervé > > > > Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > > > sorry for hi-jack this thread. is it possible to configure mvnw to use > > > a > > > new location of distributionUrl on the fly? (without touching > > > maven-wrapper.properties) > > > > > > Thanks > > > > > > -D > > > > > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski < > > > > s.jaranow...@gmail.com> > > > > > wrote: > > > > In current project configuration it is a bug rather ... We can use a > > > > wrapper with java 5 but we can't install it because the plugin > > > > requires > > > > java 8 ... > > > > > > > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > > > 8 is the minimum version normal people can accept，others be zombies > > > > who > > > > > > do > > > > > > > > > not need to be maintained IMO. They can use original wrapper plugin > > > > > > > > anyway. > > > > > > > > > If we do not force them when beginning，it is harder to add the > > > > > liminition > > > > > later. > > > > > > > > > > XenoAmess > > > > > > > > > > From: Slawomir Jaranowski > > > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > > > To: Maven Developers List > > > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > I created issues with the proposition of improvement: > > > > > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > > > > > please assign a version to fix ... if it is applicable. > > > > > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > > > > > napisał(a): > > > > > > because it's as it was imported: > > > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > > > I refactored but kept everything as equivalent as possible > > > > > > > > > > > > we can update the value if it has an interest, with associated > > > > > > Jira > > > > > > > > issue > > > > > > > > > > Regards, > > > > > > > > > > > > Hervé > > > > > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a > > > > écrit > > > > > > > > > Next question: > > > > > > > - why use java 5 in maven-wrapper module .. it is not possible > > > > > > > build > > > > > > > > > > > > with > > > > > > > > > > > > > java > 8 [1] > > > > > > > > > > > > > > [1] > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ > > > > > > ma> > > > > > > > > > > > ster/ > > > > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > > > > > > > > > > napisał(a): > > > > > > > > Le mercredi 8 décembre 202
Re: reviewing Maven Wrapper before releasing
That works, but how does it figure out the maven version to compute the full URL to download? Thanks -D On Wed, Dec 8, 2021 at 11:10 PM Hervé BOUTEMY wrote: > there is MVNW_REPOURL system property > https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager > > with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 > (showing concrete usage output) > > Is it what you expected? > > Regards, > > Hervé > > Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > > sorry for hi-jack this thread. is it possible to configure mvnw to use a > > new location of distributionUrl on the fly? (without touching > > maven-wrapper.properties) > > > > Thanks > > > > -D > > > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski < > s.jaranow...@gmail.com> > > wrote: > > > In current project configuration it is a bug rather ... We can use a > > > wrapper with java 5 but we can't install it because the plugin requires > > > java 8 ... > > > > > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > > 8 is the minimum version normal people can accept，others be zombies > who > > > > > > do > > > > > > > not need to be maintained IMO. They can use original wrapper plugin > > > > > > anyway. > > > > > > > If we do not force them when beginning，it is harder to add the > > > > liminition > > > > later. > > > > > > > > XenoAmess > > > > > > > > From: Slawomir Jaranowski > > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > > To: Maven Developers List > > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > > > I created issues with the proposition of improvement: > > > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > > > please assign a version to fix ... if it is applicable. > > > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > > > napisał(a): > > > > > because it's as it was imported: > > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > > I refactored but kept everything as equivalent as possible > > > > > > > > > > we can update the value if it has an interest, with associated Jira > > > > > > issue > > > > > > > > Regards, > > > > > > > > > > Hervé > > > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a > écrit > : > > > > > > Next question: > > > > > > - why use java 5 in maven-wrapper module .. it is not possible > > > > > > build > > > > > > > > > > with > > > > > > > > > > > java > 8 [1] > > > > > > > > > > > > [1] > > > > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ > > > ma> > > > > > > ster/ > > > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > > > > > > > > napisał(a): > > > > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a > écrit : > > > > > > > > With mvn verify -Prun-its all ITs fail on my system. This > should > > > > > > > > work > > > > > > > > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't > > > > > > > > pass > > > > > > > > > > System > > > > > > > > > > > > > properties to Maven, only arguments. And they should be > passed > > > > > > > > as > > > > > > > > is > > > > > > > > > to > > > > > > > > > > > > > mvn. > > > > > > > > > > > > > > I must admit I don't know: I suppose that if the code is here > from > > > > > > > > the &
Re: reviewing Maven Wrapper before releasing
there is MVNW_REPOURL system property https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 (showing concrete usage output) Is it what you expected? Regards, Hervé Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > sorry for hi-jack this thread. is it possible to configure mvnw to use a > new location of distributionUrl on the fly? (without touching > maven-wrapper.properties) > > Thanks > > -D > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski > wrote: > > In current project configuration it is a bug rather ... We can use a > > wrapper with java 5 but we can't install it because the plugin requires > > java 8 ... > > > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > 8 is the minimum version normal people can accept，others be zombies who > > > > do > > > > > not need to be maintained IMO. They can use original wrapper plugin > > > > anyway. > > > > > If we do not force them when beginning，it is harder to add the > > > liminition > > > later. > > > > > > XenoAmess > > > ________ > > > From: Slawomir Jaranowski > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > To: Maven Developers List > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > I created issues with the proposition of improvement: > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > please assign a version to fix ... if it is applicable. > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > napisał(a): > > > > because it's as it was imported: > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > I refactored but kept everything as equivalent as possible > > > > > > > > we can update the value if it has an interest, with associated Jira > > > > issue > > > > > > Regards, > > > > > > > > Hervé > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > > > > Next question: > > > > > - why use java 5 in maven-wrapper module .. it is not possible > > > > > build > > > > > > > > with > > > > > > > > > java > 8 [1] > > > > > > > > > > [1] > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ > > ma> > > > > > ster/ > > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > > > > > > napisał(a): > > > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > > > > With mvn verify -Prun-its all ITs fail on my system. This should > > > > > > work > > > > > > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't > > > > > > > pass > > > > > > > > System > > > > > > > > > > > properties to Maven, only arguments. And they should be passed > > > > > > > as > > > > > > is > > > > > > > to > > > > > > > > > > > mvn. > > > > > > > > > > > > I must admit I don't know: I suppose that if the code is here from > > > > > > the > > > > > > > > > beginning, it's for some use, it's just me who did not imagine the > > > > > > use > > > > > > > > > case > > > > > > > > > > > > if everybody is confident that it's never used, no problem to > > > > remove > > > > > it > > > > > > > > > > IT's should confirm that. > > > > > > > > > > > > > > Robert > > > > > > > > > > > > > > -- Origineel bericht -- > > > > > > > Van: "Jason van Zyl" > > > > > > > Aan: "Maven Deve
Re: reviewing Maven Wrapper before releasing
sorry for hi-jack this thread. is it possible to configure mvnw to use a new location of distributionUrl on the fly? (without touching maven-wrapper.properties) Thanks -D On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski wrote: > In current project configuration it is a bug rather ... We can use a > wrapper with java 5 but we can't install it because the plugin requires > java 8 ... > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > 8 is the minimum version normal people can accept，others be zombies who > do > > not need to be maintained IMO. They can use original wrapper plugin > anyway. > > If we do not force them when beginning，it is harder to add the liminition > > later. > > > > XenoAmess > > > > From: Slawomir Jaranowski > > Sent: Thursday, December 9, 2021 3:11:42 AM > > To: Maven Developers List > > Subject: Re: reviewing Maven Wrapper before releasing > > > > I created issues with the proposition of improvement: > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > please assign a version to fix ... if it is applicable. > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > napisał(a): > > > > > because it's as it was imported: > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > I refactored but kept everything as equivalent as possible > > > > > > we can update the value if it has an interest, with associated Jira > issue > > > > > > Regards, > > > > > > Hervé > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > > > Next question: > > > > > > > > - why use java 5 in maven-wrapper module .. it is not possible build > > > with > > > > java > 8 [1] > > > > > > > > [1] > > > > > > > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > > > ster/ > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > napisał(a): > > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > > > With mvn verify -Prun-its all ITs fail on my system. This should > > work > > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > > > System > > > > > > properties to Maven, only arguments. And they should be passed as > > is > > > to > > > > > > mvn. > > > > > > > > > > I must admit I don't know: I suppose that if the code is here from > > the > > > > > beginning, it's for some use, it's just me who did not imagine the > > use > > > > > case > > > > > > > > > > if everybody is confident that it's never used, no problem to > remove > > it > > > > > > > > > > > IT's should confirm that. > > > > > > > > > > > > Robert > > > > > > > > > > > > -- Origineel bericht -- > > > > > > Van: "Jason van Zyl" > > > > > > Aan: "Maven Developers List" > > > > > > Verzonden: 7-12-2021 14:55:32 > > > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > > > >Everything builds and it generates the wrapper for a project in > a > > > way > > > > > > > > > > will > > > > > > > > > > > >be familiar to existing users. The switch for current users > > should, > > > > > > >hopefully, be painless and transparent. > > > > > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page > for > > > the > > > > > > >Takari version about the impending release at Apache, and > provided > > > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > > > > > >jvz > > > > > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY < > > herve.bout...
Re: reviewing Maven Wrapper before releasing
In current project configuration it is a bug rather ... We can use a wrapper with java 5 but we can't install it because the plugin requires java 8 ... śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > +1 for forcing more people quit java 5,6,7， as even 17 is out. > 8 is the minimum version normal people can accept，others be zombies who do > not need to be maintained IMO. They can use original wrapper plugin anyway. > If we do not force them when beginning，it is harder to add the liminition > later. > > XenoAmess > > From: Slawomir Jaranowski > Sent: Thursday, December 9, 2021 3:11:42 AM > To: Maven Developers List > Subject: Re: reviewing Maven Wrapper before releasing > > I created issues with the proposition of improvement: > > https://issues.apache.org/jira/browse/MWRAPPER-31 > https://issues.apache.org/jira/browse/MWRAPPER-32 > https://issues.apache.org/jira/browse/MWRAPPER-33 > > please assign a version to fix ... if it is applicable. > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY napisał(a): > > > because it's as it was imported: > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > I refactored but kept everything as equivalent as possible > > > > we can update the value if it has an interest, with associated Jira issue > > > > Regards, > > > > Hervé > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > > Next question: > > > > > > - why use java 5 in maven-wrapper module .. it is not possible build > > with > > > java > 8 [1] > > > > > > [1] > > > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > > ster/ > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > napisał(a): > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > > With mvn verify -Prun-its all ITs fail on my system. This should > work > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > > System > > > > > properties to Maven, only arguments. And they should be passed as > is > > to > > > > > mvn. > > > > > > > > I must admit I don't know: I suppose that if the code is here from > the > > > > beginning, it's for some use, it's just me who did not imagine the > use > > > > case > > > > > > > > if everybody is confident that it's never used, no problem to remove > it > > > > > > > > > IT's should confirm that. > > > > > > > > > > Robert > > > > > > > > > > -- Origineel bericht -- > > > > > Van: "Jason van Zyl" > > > > > Aan: "Maven Developers List" > > > > > Verzonden: 7-12-2021 14:55:32 > > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > >Everything builds and it generates the wrapper for a project in a > > way > > > > > > > > will > > > > > > > > > >be familiar to existing users. The switch for current users > should, > > > > > >hopefully, be painless and transparent. > > > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for > > the > > > > > >Takari version about the impending release at Apache, and provided > > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > > > >jvz > > > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY < > herve.bout...@free.fr > > > > > > > > > > > wrote: > > > > > >> Hi, > > > > > >> > > > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > > > >> > > > > > >>https://github.com/apache/maven-wrapper > > > > > >> > > > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > > > &
Re: reviewing Maven Wrapper before releasing
+1 for forcing more people quit java 5,6,7， as even 17 is out. 8 is the minimum version normal people can accept，others be zombies who do not need to be maintained IMO. They can use original wrapper plugin anyway. If we do not force them when beginning，it is harder to add the liminition later. XenoAmess From: Slawomir Jaranowski Sent: Thursday, December 9, 2021 3:11:42 AM To: Maven Developers List Subject: Re: reviewing Maven Wrapper before releasing I created issues with the proposition of improvement: https://issues.apache.org/jira/browse/MWRAPPER-31 https://issues.apache.org/jira/browse/MWRAPPER-32 https://issues.apache.org/jira/browse/MWRAPPER-33 please assign a version to fix ... if it is applicable. śr., 8 gru 2021 o 19:47 Hervé BOUTEMY napisał(a): > because it's as it was imported: > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > I refactored but kept everything as equivalent as possible > > we can update the value if it has an interest, with associated Jira issue > > Regards, > > Hervé > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > Next question: > > > > - why use java 5 in maven-wrapper module .. it is not possible build > with > > java > 8 [1] > > > > [1] > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > ster/ > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > napisał(a): > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > With mvn verify -Prun-its all ITs fail on my system. This should work > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > System > > > > properties to Maven, only arguments. And they should be passed as is > to > > > > mvn. > > > > > > I must admit I don't know: I suppose that if the code is here from the > > > beginning, it's for some use, it's just me who did not imagine the use > > > case > > > > > > if everybody is confident that it's never used, no problem to remove it > > > > > > > IT's should confirm that. > > > > > > > > Robert > > > > > > > > -- Origineel bericht -- > > > > Van: "Jason van Zyl" > > > > Aan: "Maven Developers List" > > > > Verzonden: 7-12-2021 14:55:32 > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > >Everything builds and it generates the wrapper for a project in a > way > > > > > > will > > > > > > > >be familiar to existing users. The switch for current users should, > > > > >hopefully, be painless and transparent. > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for > the > > > > >Takari version about the impending release at Apache, and provided > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > >jvz > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > > > > wrote: > > > > >> Hi, > > > > >> > > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > > >> > > > > >>https://github.com/apache/maven-wrapper > > > > >> > > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > > > >>version=12350068>> > > > > >> > > > > >> Please test and review so we can do a release soon > > > > >> > > > > >> Regards, > > > > >> > > > > >> Hervé > > > > >> > > > > >> > > > > >> > > > > >> > > > > > >> - > > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > >- > > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
I created issues with the proposition of improvement: https://issues.apache.org/jira/browse/MWRAPPER-31 https://issues.apache.org/jira/browse/MWRAPPER-32 https://issues.apache.org/jira/browse/MWRAPPER-33 please assign a version to fix ... if it is applicable. śr., 8 gru 2021 o 19:47 Hervé BOUTEMY napisał(a): > because it's as it was imported: > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > I refactored but kept everything as equivalent as possible > > we can update the value if it has an interest, with associated Jira issue > > Regards, > > Hervé > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > Next question: > > > > - why use java 5 in maven-wrapper module .. it is not possible build > with > > java > 8 [1] > > > > [1] > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > ster/ > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > napisał(a): > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > With mvn verify -Prun-its all ITs fail on my system. This should work > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > System > > > > properties to Maven, only arguments. And they should be passed as is > to > > > > mvn. > > > > > > I must admit I don't know: I suppose that if the code is here from the > > > beginning, it's for some use, it's just me who did not imagine the use > > > case > > > > > > if everybody is confident that it's never used, no problem to remove it > > > > > > > IT's should confirm that. > > > > > > > > Robert > > > > > > > > -- Origineel bericht -- > > > > Van: "Jason van Zyl" > > > > Aan: "Maven Developers List" > > > > Verzonden: 7-12-2021 14:55:32 > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > >Everything builds and it generates the wrapper for a project in a > way > > > > > > will > > > > > > > >be familiar to existing users. The switch for current users should, > > > > >hopefully, be painless and transparent. > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for > the > > > > >Takari version about the impending release at Apache, and provided > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > >jvz > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > > > > wrote: > > > > >> Hi, > > > > >> > > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > > >> > > > > >>https://github.com/apache/maven-wrapper > > > > >> > > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > > > >>version=12350068>> > > > > >> > > > > >> Please test and review so we can do a release soon > > > > >> > > > > >> Regards, > > > > >> > > > > >> Hervé > > > > >> > > > > >> > > > > >> > > > > >> > > > > > >> - > > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > >- > > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
because it's as it was imported: https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 I refactored but kept everything as equivalent as possible we can update the value if it has an interest, with associated Jira issue Regards, Hervé Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > Next question: > > - why use java 5 in maven-wrapper module .. it is not possible build with > java > 8 [1] > > [1] > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > ster/ > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY napisał(a): > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > With mvn verify -Prun-its all ITs fail on my system. This should work > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > And I'm pretty sure we can remove the cli package: you can't pass System > > > properties to Maven, only arguments. And they should be passed as is to > > > mvn. > > > > I must admit I don't know: I suppose that if the code is here from the > > beginning, it's for some use, it's just me who did not imagine the use > > case > > > > if everybody is confident that it's never used, no problem to remove it > > > > > IT's should confirm that. > > > > > > Robert > > > > > > -- Origineel bericht -- > > > Van: "Jason van Zyl" > > > Aan: "Maven Developers List" > > > Verzonden: 7-12-2021 14:55:32 > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > >Everything builds and it generates the wrapper for a project in a way > > > > will > > > > > >be familiar to existing users. The switch for current users should, > > > >hopefully, be painless and transparent. > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > > > >Takari version about the impending release at Apache, and provided > > > >pointers to the new Git repository and JIRA project. > > > > > > > >jvz > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > wrote: > > > >> Hi, > > > >> > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > >> > > > >>https://github.com/apache/maven-wrapper > > > >> > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > >>version=12350068>> > > > >> > > > >> Please test and review so we can do a release soon > > > >> > > > >> Regards, > > > >> > > > >> Hervé > > > >> > > > >> > > > >> > > > >> > > > >> - > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > >- > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Next question: - why use java 5 in maven-wrapper module .. it is not possible build with java > 8 [1] [1] https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/master/ śr., 8 gru 2021 o 19:05 Hervé BOUTEMY napisał(a): > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > With mvn verify -Prun-its all ITs fail on my system. This should work > > out-of-the-box, so I'll need to investigate the issue. > > > > And I'm pretty sure we can remove the cli package: you can't pass System > > properties to Maven, only arguments. And they should be passed as is to > > mvn. > I must admit I don't know: I suppose that if the code is here from the > beginning, it's for some use, it's just me who did not imagine the use case > > if everybody is confident that it's never used, no problem to remove it > > > IT's should confirm that. > > > > Robert > > > > -- Origineel bericht -- > > Van: "Jason van Zyl" > > Aan: "Maven Developers List" > > Verzonden: 7-12-2021 14:55:32 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > >Everything builds and it generates the wrapper for a project in a way > will > > >be familiar to existing users. The switch for current users should, > > >hopefully, be painless and transparent. > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > > >Takari version about the impending release at Apache, and provided > > >pointers to the new Git repository and JIRA project. > > > > > >jvz > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > wrote: > > >> > > >> Hi, > > >> > > >> Maven Wrapper has been donated to Apache Maven, imported to > > >> > > >>https://github.com/apache/maven-wrapper > > >> > > >> Documentation published to https://maven.apache.org/wrapper/ > > >> > > >> Here is the list of fixes from previous 0.5.6 release: > > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > >>version=12350068>> > > >> Please test and review so we can do a release soon > > >> > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >- > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > With mvn verify -Prun-its all ITs fail on my system. This should work > out-of-the-box, so I'll need to investigate the issue. > > And I'm pretty sure we can remove the cli package: you can't pass System > properties to Maven, only arguments. And they should be passed as is to > mvn. I must admit I don't know: I suppose that if the code is here from the beginning, it's for some use, it's just me who did not imagine the use case if everybody is confident that it's never used, no problem to remove it > IT's should confirm that. > > Robert > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 7-12-2021 14:55:32 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >Everything builds and it generates the wrapper for a project in a way will > >be familiar to existing users. The switch for current users should, > >hopefully, be painless and transparent. > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > >Takari version about the impending release at Apache, and provided > >pointers to the new Git repository and JIRA project. > > > >jvz > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY wrote: > >> > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >> > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > >>version=12350068>> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
MWRAPPER-29 and MWRAPPER-30 merged: thank you Slawomir Le mercredi 8 décembre 2021, 16:07:48 CET Slawomir Jaranowski a écrit : > https://issues.apache.org/jira/browse/MWRAPPER-29 > > śr., 8 gru 2021 o 15:52 Robert Scholte napisał(a): > > With mvn verify -Prun-its all ITs fail on my system. This should work > > out-of-the-box, so I'll need to investigate the issue. > > > > And I'm pretty sure we can remove the cli package: you can't pass System > > properties to Maven, only arguments. And they should be passed as is to > > mvn. > > IT's should confirm that. > > > > Robert > > > > -- Origineel bericht -- > > Van: "Jason van Zyl" > > Aan: "Maven Developers List" > > Verzonden: 7-12-2021 14:55:32 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > >Everything builds and it generates the wrapper for a project in a way > > > > will be familiar to existing users. The switch for current users should, > > hopefully, be painless and transparent. > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > > > > Takari version about the impending release at Apache, and provided > > pointers > > to the new Git repository and JIRA project. > > > > >jvz > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > wrote: > > >> Hi, > > >> > > >> Maven Wrapper has been donated to Apache Maven, imported to > > >> > > >>https://github.com/apache/maven-wrapper > > >> > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > >> Here is the list of fixes from previous 0.5.6 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > version=12350068> > > >> Please test and review so we can do a release soon > > >> > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >- > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
https://issues.apache.org/jira/browse/MWRAPPER-29 śr., 8 gru 2021 o 15:52 Robert Scholte napisał(a): > With mvn verify -Prun-its all ITs fail on my system. This should work > out-of-the-box, so I'll need to investigate the issue. > > And I'm pretty sure we can remove the cli package: you can't pass System > properties to Maven, only arguments. And they should be passed as is to > mvn. > IT's should confirm that. > > Robert > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 7-12-2021 14:55:32 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >Everything builds and it generates the wrapper for a project in a way > will be familiar to existing users. The switch for current users should, > hopefully, be painless and transparent. > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > Takari version about the impending release at Apache, and provided pointers > to the new Git repository and JIRA project. > > > >jvz > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > wrote: > >> > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 > >> > >> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > > > > > > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
With mvn verify -Prun-its all ITs fail on my system. This should work out-of-the-box, so I'll need to investigate the issue. And I'm pretty sure we can remove the cli package: you can't pass System properties to Maven, only arguments. And they should be passed as is to mvn. IT's should confirm that. Robert -- Origineel bericht -- Van: "Jason van Zyl" Aan: "Maven Developers List" Verzonden: 7-12-2021 14:55:32 Onderwerp: Re: reviewing Maven Wrapper before releasing Everything builds and it generates the wrapper for a project in a way will be familiar to existing users. The switch for current users should, hopefully, be painless and transparent. Nice work Robert and Hervé. I put a notice on the GitHub page for the Takari version about the impending release at Apache, and provided pointers to the new Git repository and JIRA project. jvz On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY wrote: Hi, Maven Wrapper has been donated to Apache Maven, imported to https://github.com/apache/maven-wrapper Documentation published to https://maven.apache.org/wrapper/ Here is the list of fixes from previous 0.5.6 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 Please test and review so we can do a release soon Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Everything builds and it generates the wrapper for a project in a way will be familiar to existing users. The switch for current users should, hopefully, be painless and transparent. Nice work Robert and Hervé. I put a notice on the GitHub page for the Takari version about the impending release at Apache, and provided pointers to the new Git repository and JIRA project. jvz > On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY wrote: > > Hi, > > Maven Wrapper has been donated to Apache Maven, imported to > https://github.com/apache/maven-wrapper > > Documentation published to https://maven.apache.org/wrapper/ > > Here is the list of fixes from previous 0.5.6 release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 > > > Please test and review so we can do a release soon > > Regards, > > Hervé > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
reviewing Maven Wrapper before releasing
Hi, Maven Wrapper has been donated to Apache Maven, imported to https://github.com/apache/maven-wrapper Documentation published to https://maven.apache.org/wrapper/ Here is the list of fixes from previous 0.5.6 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 Please test and review so we can do a release soon Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983747573 In the end the-person-that-called-wrapper:wrapper should decide. It is a matter of a "sources-only repository" (either download via script or Java) versus "don't download", not the "cloner/forker". To me it is weird we make an exception for the wrapper.jar, whereas we all prefer sources only for everything else. IIUC everything is configurable to download, including repo-manager, proxy, etc. It should be possible to guide in case it doesn't work. Also, regarding the potential unintended commit: the plugin could help here generating scm-specific ignore files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983710755 > The choice for `script` was because in general we don't want binaries in the SCM. There's no real damage if the file is committed anyway. making script the default is not sufficient, because if .mvn/wrapper/maven-wrapper.jar or *.jar is not in .gitignore, the jar will inevitably come into future Git commit, not by the guy who did `mvn wrapper:wrapper`, by the user who will do `./mvnw` and commit everything without remarking that `wrapper.jar` was downloaded then forcing `mvn wrapper:wrapper` not to download `maven-wrapper.jar` just adds an additional friction (= `mvnw` needs to be able to download the jar, without the help of Maven settings) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983699652 ok, code pushed in MWRPPER-14 branch in maven-studies https://github.com/apache/maven-studies/tree/MWRAPPER-14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983664558 Can https://github.com/hboutemy/maven-wrapper be cloned to maven-studies? That makes it easier for everybody to do their changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983367640 There are still things in the code I want to comment on, but that's hard to describe here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983365226 The choice for `script` was because in general we don't want binaries in the SCM. There's no real damage if the file is committed anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980644191 thinking at default type more in depth, I think that I now understand the logic = making `script` the default is not sufficient, because if `.mvn/wrapper/maven-wrapper.jar` or `*.jar` is not in `.gitignore`, the jar will inevitably come into future Git commit then the logic is to have `bin` by default when installing maven-wrapper, and the `.gitignore` configuration will trigger if the jar is stored or not (and if not stored, the consequence in network access) thinking like this, I now feel that yes, `bin` should be default... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
