On Sept. 12, 2014, 7:03 p.m., Ben Mahler wrote:
Thanks for doing this! A few higher level comments:
(1) We have strings::join in stout. Have you considered implementing this
TLineHelper as a generic Joiner in stout/strings.hpp? Seems like it belongs
there instead of a newline
---
On Sept. 18, 2014, 7:58 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789
a1702cd
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5
Diff: https://reviews.apache.org/r/25789/diff/
Testing
---
Ran make check for stout. Added test cases for join as these were missing.
Thanks,
Joris Van Remoortere
-
3rdparty/libprocess/Makefile.am edbe54b
3rdparty/libprocess/include/process/help.hpp 4333b5b
3rdparty/libprocess/src/help.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/25798/diff/
Testing
---
make check on 3rdparty
support/mesos-style.py
Thanks,
Joris Van Remoortere
in the usage of
join. Dealing with this and writing test for this now.
- Joris Van Remoortere
On Sept. 18, 2014, 10:22 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
://reviews.apache.org/r/25789/diff/
Testing
---
Ran make check for stout. Added test cases for join as these were missing.
Thanks,
Joris Van Remoortere
---
On Sept. 18, 2014, 10:53 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798
---
make check on 3rdparty
support/mesos-style.py
Thanks,
Joris Van Remoortere
for stout. Added test cases for join as these were missing.
Thanks,
Joris Van Remoortere
/stout/include/stout/strings.hpp a1702cd
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5
Diff: https://reviews.apache.org/r/25789/diff/
Testing
---
Ran make check for stout. Added test cases for join as these were missing.
Thanks,
Joris Van Remoortere
---
On Sept. 19, 2014, 6:37 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 19
/
Testing
---
make check on 3rdparty
support/mesos-style.py
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/25847/diff/
Testing
---
make check in libprocess
support/mesos-stype.py
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25847/#review54018
---
On Sept. 19, 2014, 8:31 p.m., Joris Van Remoortere wrote
/node.hpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 3ac56c7
Diff: https://reviews.apache.org/r/25847/diff/
Testing
---
make check in libprocess
support/mesos-stype.py
Thanks,
Joris Van Remoortere
8adc809
Diff: https://reviews.apache.org/r/25868/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
.
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/#review54077
---
On Sept. 20, 2014, 12:58 a.m., Joris Van Remoortere wrote
/strings_tests.cpp 51008e5
Diff: https://reviews.apache.org/r/25789/diff/
Testing
---
Ran make check for stout. Added test cases for join as these were missing.
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/#review54086
---
On Sept. 20, 2014, 12:58 a.m., Joris Van Remoortere wrote
that alongside doing a scan
for the headers we only use inside libprocess.
Joris Van Remoortere wrote:
Hi Ben,
I am refactoring certain classes from process.cpp into the include
directory because my goal is to allow pluggable implementations (modules) of
the event-management abstraction
that alongside doing a scan
for the headers we only use inside libprocess.
Joris Van Remoortere wrote:
Hi Ben,
I am refactoring certain classes from process.cpp into the include
directory because my goal is to allow pluggable implementations (modules) of
the event-management abstraction
3rdparty/libprocess/src/process.cpp 8adc809
3rdparty/libprocess/src/process_reference.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/25868/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp 9d08329
src/tests/isolator_tests.cpp c38f876
Diff: https://reviews.apache.org/r/25922/diff/
Testing
---
make check
sudo bin/mesos-tests.sh --gtest_filter=*BlkIO*
support/mesos-style.py
Thanks,
Joris Van Remoortere
as these were missing.
Thanks,
Joris Van Remoortere
as these were missing.
Thanks,
Joris Van Remoortere
as these were missing.
Thanks,
Joris Van Remoortere
Van Remoortere
3rdparty/libprocess/src/http_proxy.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp e46e6b1
Diff: https://reviews.apache.org/r/26060/diff/
Testing
---
make check
support/mesos-style.py
Thanks,
Joris Van Remoortere
3rdparty/libprocess/src/net.hpp 1ba3dbb
3rdparty/libprocess/src/process_reference.hpp 4964107
3rdparty/libprocess/src/synchronized.hpp 577a5fc
Diff: https://reviews.apache.org/r/26056/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van
in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
)
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26476/#review55945
---
On Oct. 9, 2014, 1:35 a.m., Joris Van Remoortere wrote
---
On Oct. 9, 2014, 1:35 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26476/
---
(Updated Oct. 9
a reduction in definitely lost
blocks)
Thanks,
Joris Van Remoortere
:
https://reviews.apache.org/r/26533/#review56166
---
On Oct. 10, 2014, 1:02 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
make check
support/mesos-style
valgrind 3rdparty/libprocess/tests (to see a reduction in definitely lost
blocks)
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/26578/diff/
Testing
---
make check
support/mesos-style.py
Thanks,
Joris Van Remoortere
/mesos-style.py
Thanks,
Joris Van Remoortere
: mesos-git
Description
---
Wrap the libprocess garbage collector process with a unique ptr. Reset the ptr
during finalization.
Diffs
-
3rdparty/libprocess/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/26583/diff/
Testing
---
make check
Thanks,
Joris Van
processes);
Join on the worker threads that were dispatched.
Diffs (updated)
-
3rdparty/libprocess/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/26580/diff/
Testing
---
make check
support/mesos-style.py
Thanks,
Joris Van Remoortere
---
On Oct. 10, 2014, 11:12 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26583
registered with the garbage collector when the
garbage collector terminates.
Diffs (updated)
-
3rdparty/libprocess/include/process/gc.hpp e83c636
Diff: https://reviews.apache.org/r/26578/diff/
Testing
---
make check
support/mesos-style.py
Thanks,
Joris Van Remoortere
)
-
3rdparty/libprocess/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/26580/diff/
Testing
---
make check
support/mesos-style.py
Thanks,
Joris Van Remoortere
/benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26150/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
)
-
3rdparty/libprocess/Makefile.am 616618e
3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26150/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
---
On Oct. 14, 2014, 9:27 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/
---
(Updated Oct
-CREATION
Diff: https://reviews.apache.org/r/26150/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/26580/diff/
Testing
---
make check
support/mesos-style.py
Thanks,
Joris Van Remoortere
/tests/benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26150/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
/
Testing
---
make check
support/mesos-style.py
valgrind (reduced allocation count)
Thanks,
Joris Van Remoortere
(updated)
-
3rdparty/libprocess/include/process/gc.hpp e83c636
Diff: https://reviews.apache.org/r/26578/diff/
Testing
---
make check
support/mesos-style.py
Thanks,
Joris Van Remoortere
,
Joris Van Remoortere
---
Thanks,
Joris Van Remoortere
40906cb
Diff: https://reviews.apache.org/r/27024/diff/
Testing
---
Thanks,
Joris Van Remoortere
---
make check
Thanks,
Joris Van Remoortere
PRE-CREATION
Diff: https://reviews.apache.org/r/26150/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26783/#review57188
---
On Oct. 22, 2014, 6:55 p.m., Joris Van Remoortere wrote
::vectorstd::thread tvec;
for (size_t i = 0; i nthread; ++i) {
tvec.emplace_back(do_launch);
}
for (auto t : tvec) {
t.join();
}
```
Thanks,
Joris Van Remoortere
---
On Oct. 15, 2014, 9:29 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26476
/
Testing
---
make check
support/mesos-style.py
valgrind (reduced allocation count)
Thanks,
Joris Van Remoortere
-
3rdparty/libprocess/include/process/timeout.hpp 40906cb
Diff: https://reviews.apache.org/r/27024/diff/
Testing (updated)
---
make check with this patch and 27025 applied.
Thanks,
Joris Van Remoortere
-CREATION
Diff: https://reviews.apache.org/r/26150/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
: https://reviews.apache.org/r/26150/diff/
Testing
---
make check in 3rdparty/libprocess
support/mesos-style.py
Thanks,
Joris Van Remoortere
/mesos/containerizer.cpp 9d08329
src/tests/isolator_tests.cpp 52b38a3
Diff: https://reviews.apache.org/r/27111/diff/
Testing
---
make check
sudo ./mesos-tests --gtest_filter=BlkIOIsolatorTest*
Thanks,
Joris Van Remoortere
/
Testing
---
make check
Thanks,
Joris Van Remoortere
,
Joris Van Remoortere
check
Thanks,
Joris Van Remoortere
-
3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b
Diff: https://reviews.apache.org/r/27113/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
---
On Oct. 24, 2014, 3:09 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27113
.
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27113/#review58124
---
On Oct. 24, 2014, 3:09 a.m., Joris Van Remoortere wrote
/libprocess/src/tests/benchmarks.cpp 3177a8e
Diff: https://reviews.apache.org/r/27113/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
-tests --gtest_filter=BlkIOIsolatorTest*
Thanks,
Joris Van Remoortere
=BlkIOIsolatorTest*
Thanks,
Joris Van Remoortere
/27111/#review58418
---
On Oct. 25, 2014, 5:53 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27111
check
Thanks,
Joris Van Remoortere
/process/socket.hpp 6683881
Diff: https://reviews.apache.org/r/27023/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/27023/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
/libprocess/include/process/socket.hpp 6683881
3rdparty/libprocess/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/27054/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
---
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
-
3rdparty/libprocess/include/process/socket.hpp 6683881
3rdparty/libprocess/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/27054/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
/
Testing
---
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
)
-
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
Diff: https://reviews.apache.org/r/27351/diff/
Testing
---
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/27354/diff/
Testing
---
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
() and
send().
Diffs
-
3rdparty/libprocess/include/process/socket.hpp 6683881
3rdparty/libprocess/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/27054/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
/ax_cxx_compile_stdcxx_11.m4 72a1080
Diff: https://reviews.apache.org/r/27356/diff/
Testing
---
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
/25847/.
Niklas suggested we not rename the class as the naming was originally inspired
by Erlang http://www.erlang.org/doc/reference_manual/distributed.html.
Maybe this deserves a JIRA discussion rather than reviewboard.
- Joris Van Remoortere
On Oct. 31, 2014, 3:45 a.m., Evelina Dumitrescu
That seems like you might have a connectivity / firewall issue.
Can you try just doing a wget on that artifact?
On Fri, Oct 31, 2014 at 1:56 PM, Sweta Rani swetarani3...@gmail.com wrote:
I tried it again but failed with following errors :
make[1]: Entering directory
response... 200 OK
Length: 14811 (14K) [text/xml]
Saving to: ‘apache-11.pom’
*Joris Van Remoortere*
On Sat Nov 01 2014 at 2:36:27 AM Joris Van Remoortere jo...@mesosphere.io
wrote:
That seems like you might have a connectivity / firewall issue.
Can you try just doing a wget
---
make check
Thanks,
Joris Van Remoortere
/3rdparty/stout/tests/os_tests.cpp 3f39017
Diff: https://reviews.apache.org/r/27461/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
, as it ends up with ERROR(1). Upon
searching, I created settings.xml file inside .m2 with the required
configuration but failed again. Please help me out, as it is greatly
hindering me from my work.
On Sat Nov 01 2014 at 3:38:57 AM Joris Van Remoortere jo...@mesosphere.io
wrote:
I think
(updated)
-
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3f39017
Diff: https://reviews.apache.org/r/27461/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/27461/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
. 4, 2014, 12:36 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27461/
---
(Updated Nov. 4, 2014
/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
.
By disabling Java, you could at least check that the rest of Mesos builds
and runs fine, which would still work with C++, Python, or Go frameworks,
or even any Java frameworks using the pure Java bindings (jesos).
On Mon, Nov 3, 2014 at 2:01 PM, Joris Van Remoortere
jo...@mesosphere.io
-with-apache-98address-already-in-use
but it didnt work for me.
*Sweta Rani*
On Wed, Nov 5, 2014 at 3:50 AM, Joris Van Remoortere
jo...@mesosphere.io
wrote:
You need to make the directory and set the permissions to the user
you
are
running the master
/option.hpp 47fe92c
Diff: https://reviews.apache.org/r/26476/diff/
Testing
---
make check
support/mesos-style.py
valgrind (reduced allocation count)
Thanks,
Joris Van Remoortere
http://stackoverflow.com/questions/1491180/how-to-configure-a-http-proxy-for-svn
On Fri, Nov 7, 2014 at 8:10 AM, Sweta Rani swetarani3...@gmail.com wrote:
Upon running svn checkout http://svn.apache.org/repos/asf/mesos/site
mesos-last-attempt, it gives following error:
svn: E000111: Unable to
/
---
(Updated Nov. 11, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas
Nielsen, and Vinod Kone.
Repository: mesos-git
Description
---
See summary.
Diffs
-
3rdparty/libprocess
1 - 100 of 447 matches
Mail list logo
