[GitHub] JaroslavTulach opened a new pull request #3: Computed property enhancement

2017-11-30 Thread GitBox 
JaroslavTulach opened a new pull request #3: Computed property enhancement
URL: https://github.com/apache/incubator-netbeans-html4j/pull/3
 
 
   There has been a long time pending request to improve the 
`@ComputedProperty` to be able to depend on other computed properties. This 
changes offers that by allowing one to access the whole *model class* when 
computing the property.
   
   When at it I also improved the Javadoc for the `@ComputedProperty` 
annotation.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [Gentoo Packaging] 9 9 9 :)

2017-11-30 Thread John Muczynski 
Congratulations !

On Nov 30, 2017 9:42 PM, "William L. Thomson Jr."  wrote:

> Netbeans 9, built under java 9, running on java 9 :)
>
> http://www.enlightenment.org/ss/e-5a20b8eb0b3e91.03603173.jpg
> http://www.enlightenment.org/ss/e-5a20b833eb1999.79359468.jpg
> http://www.enlightenment.org/ss/e-5a20b8017cd974.90970763.jpg
> http://www.enlightenment.org/ss/e-5a20bf75cc4179.53467093.jpg
>
> Still much more to do, no working editor yet, mime and some other
> issues, more to package. That NbBundleProcessor issue was a major light
> switch moment. All menus are fully populated now :)
>
> Darcula works when copied from my 8.2 user install. Trying to get the
> nbm to install. No public plugins are showing. I assume that is due to
> 9 not being released yet and/or transition to Apache. Not a huge deal.
>
> Off to the races now for the most part!
>
> --
> William L. Thomson Jr.
>

[Gentoo Packaging] 9 9 9 :)

2017-11-30 Thread William L. Thomson Jr. 
Netbeans 9, built under java 9, running on java 9 :)

http://www.enlightenment.org/ss/e-5a20b8eb0b3e91.03603173.jpg
http://www.enlightenment.org/ss/e-5a20b833eb1999.79359468.jpg
http://www.enlightenment.org/ss/e-5a20b8017cd974.90970763.jpg
http://www.enlightenment.org/ss/e-5a20bf75cc4179.53467093.jpg

Still much more to do, no working editor yet, mime and some other
issues, more to package. That NbBundleProcessor issue was a major light
switch moment. All menus are fully populated now :)

Darcula works when copied from my 8.2 user install. Trying to get the
nbm to install. No public plugins are showing. I assume that is due to
9 not being released yet and/or transition to Apache. Not a huge deal.

Off to the races now for the most part!

-- 
William L. Thomson Jr.


pgpBISvZm9ArA.pgp
Description: OpenPGP digital signature

Re: [Gentoo packaging] SOLVED Can't find resource for bundle

2017-11-30 Thread William L. Thomson Jr. 
These two files are being generated now when they were not before.
Seems the Bundle.properties file existing causes several issues.

META-INF/namedservices/URLStreamHandler/nbresloc/java.net.URLStreamHandler
META-INF/namedservices/URLStreamHandler/nbres/java.net.URLStreamHandler

Though others I still had to create, not sure why.
META-INF/namedservices.index
META-INF/namedservices/java.net.URLStreamHandlerFactory

Some what moot for now, Past those issues. Just interesting the files
that were not being generated before are now. Killed 2 birds!

-- 
William L. Thomson Jr.


pgprps00RG7S9.pgp
Description: OpenPGP digital signature

Re: [Gentoo packaging] SOLVED Can't find resource for bundle

2017-11-30 Thread William L. Thomson Jr. 
What I ended up doing was copying the default Bundle.properties in
src to  a resources directory I created. Then I delete all
Bundle.properties files in the sources. That causes annotation
processors to re-create the Bundle.properties files.

Then I just cat the generated Bundle.Properties to the original one in
resources. Delete the generated one, and jar it all up :)
https://github.com/Obsidian-StudiosInc/os-xtoo/commit/5bb0077f4c03c2ce9e18a6da60351bac56696e0a

Why NbBundleProcessor does not append is beyond me. I think ant must be
doing something along the lines as to what I am doing. Otherwise I
cannot see what I am doing wrong to get annotation processors to not
combine generated stuff with static that existed in Bundle.properties
from the start.

Either way finally resolved my biggest issue and annoyance :)

That was super annoying! Caused tons of pop-ups. I could not read
important information like modules that could not load. Need to rebuild
jars once again to fix others. Hopefully for the last time. I have
rebuild the 130+ packages I have now several times. To pick up stuff
missed with annotation processors etc.

-- 
William L. Thomson Jr.


pgp5f3xg6t279.pgp
Description: OpenPGP digital signature

Re: [Gentoo packaging] HALF SOLVED Can't find resource for bundle

2017-11-30 Thread William L. Thomson Jr. 
It turns out if I delete Bundle.properties. It generates one with the
missing stuff. However it lacks stuff the one I deleted had. Thus now I
need to come up with some way to combine the two

At least some progress though. Not sure why it only writes that stuff
when properties does not exist vs appending. Maybe a bug?

I can come up with my own means to combine, etc. Is there something I
am missing there that would do that for me?

Thanks, and at least finally have a clue whats going on and how to hack
around :)

-- 
William L. Thomson Jr.


pgpZCsHRMiLqN.pgp
Description: OpenPGP digital signature

Re: [Gentoo packaging] Can't find resource for bundle

2017-11-30 Thread William L. Thomson Jr. 
On Mon, 27 Nov 2017 13:24:11 -0500
"William L. Thomson Jr."  wrote:
>
> I am getting lots of these errors
> 
> java.util.MissingResourceException: Can't find resource for bundle
> org.openide.util.NbBundle$PBundle, key MSG_start_load_boot_modules
> 
> Regarding that specific variable. I see it in this file.
> https://github.com/apache/incubator-netbeans/blob/master/core.startup/src/org/netbeans/core/startup/NbEvents.java#L73
> 
> Looks like unprocessed annotations. I am assuming I need to process
> it. Netbeans 8.2 has it in a Bundle.properties. Which seems I need as
> well. The NbBundleProcessor does not seem to be picking this stuff
> up. Likely some other processor I am missing and need to use.

Still working on this. Resolution is my present goal and task. I have
built core.startup via ant with verbose compiler output. Next may do
verbose ant as well but ant was making tremendous noise.

I see it generating the missing stuff in Bundle.properties. I cannot
yet explain what I am doing wrong or what it is doing differently.

I am seeing the exact same annotation processor output. Though it seems
ant has 3 rounds. 1st process annotations, 2nd not sure, 3rd compile,
no annotations. Without hacking into and interrupting that 3 round
compile process. I am trying to replicate doing annotation processing
first -proc:only. Then going back and doing compile no annotation
processing, -proc:none.

Without copying the Bundle.java that was generated. It failed to build
because it cannot find things that come from annotation messages.

src/org/netbeans/core/startup/NbEvents.java:50: error: cannot find
symbol import static org.netbeans.core.startup.Bundle.*;
   ^
  symbol:   class Bundle
  location: package org.netbeans.core.startup
src/org/netbeans/core/startup/NbEvents.java:116: error: cannot find
symbol MSG_start_load_boot_modules());

That was the same issues I face early on missing Bundle.class. Till I
used NbBundleProcessor. Which is definitely doing its thing. However
that exact error, MSG_start_load_boot_modules. its key/value is never
written to Bundle.properties.

Again current exception is

java.util.MissingResourceException: Can't find resource for bundle
org.openide.util.NbBundle$PBundle, key MSG_start_load_boot_modules

So you can see it literally is the same stuff. Why that key and value
is not written to Bundle.properties. I have yet to figure out.

-- 
William L. Thomson Jr.


pgp3wlk4QK8Lm.pgp
Description: OpenPGP digital signature

[GitHub] jlahoda commented on issue #306: Some more updates to fix issues reported by verify-libs-and-licenses.

2017-11-30 Thread GitBox 
jlahoda commented on issue #306: Some more updates to fix issues reported by 
verify-libs-and-licenses.
URL: 
https://github.com/apache/incubator-netbeans/pull/306#issuecomment-348333218
 
 
   @steffendietz - thanks for report, fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] steffendietz commented on a change in pull request #306: Some more updates to fix issues reported by verify-libs-and-licenses.

2017-11-30 Thread GitBox 
steffendietz commented on a change in pull request #306: Some more updates to 
fix issues reported by verify-libs-and-licenses.
URL: https://github.com/apache/incubator-netbeans/pull/306#discussion_r154206117
 
 

 ##
 File path: nbbuild/licenses/names.properties
 ##
 @@ -17,10 +17,12 @@
 
 GPL-2-CP=GPL v2 with Classpath exception 
(http://openjdk.java.net/legal/gplv2+ce.html)
 Apache-2.0=Apache Version 2.0  (http://www.apache.org/licenses/LICENSE-2.0.txt)
+Apache-2.0-lucene=Apache Version 2.0  
(http://www.apache.org/licenses/LICENSE-2.0.txt) with Apache Lucene addenums
 
 Review comment:
   adden**d**ums or addenda


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jlahoda opened a new pull request #306: Some more updates to fix issues reported by verify-libs-and-licenses.

2017-11-30 Thread GitBox 
jlahoda opened a new pull request #306: Some more updates to fix issues 
reported by verify-libs-and-licenses.
URL: https://github.com/apache/incubator-netbeans/pull/306
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Status of Apache NetBeans (incubating) 9.0 Beta

2017-11-30 Thread John McDonnell 
Cool, that makes sense, I was just curious about its progress.

John

On 30 November 2017 at 20:02, Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:

> Fair question.
>
> On the other hand, we're clearly not in a position yet to do anything with
> those files, even if they were to come in today -- we clearly have more
> than enough work to do just on the code from the 1st donation.
>
> That being said, we've restructured the subsequent donations such that we
> can focus specifically on the parts we care most about right now -- Java
> EE, JavaScript/HTML, PHP, and Groovy:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
>
> At the end of the above link, notice 5e, which is the focus of the 2nd
> donation -- we've moved C++-related clusters to the third code donation so
> that we can get especially the Java EE and JavaScript/HTML features over to
> Apache as quickly as possible. The reason for the delays is simply a
> question of resourcing and conflicting work assignments coming in the paths
> of those working on this. However, again, I must say I'm happy we don't
> have the 2nd code donation yet right now -- we'd be swamped, we'd have a
> significant number of additional files we'd need to wade through while
> right now we have plenty of files to wade through as it is.
>
> Gj
>
> On Thu, Nov 30, 2017 at 8:56 PM, John McDonnell 
> wrote:
>
> > Any update on the progress of the 2nd code donation?
> >
> > Is Oracle still going through those files - Any idea when that will be
> > ready?
> >
> > John
> >
> > On 30 November 2017 at 19:41, Geertjan Wielenga <
> > geertjan.wiele...@googlemail.com> wrote:
> >
> > > Hi all,
> > >
> > > Status for 9.0 Beta is looking really good -- the Rat report is almost
> > down
> > > to 0:
> > >
> > > https://builds.apache.org/job/incubator-netbeans-release/
> > > lastSuccessfulBuild/artifact/rat-java-temp/nbbuild/build/
> rat-report.txt
> > >
> > > And pretty much all the issues are resolved or closed in some way:
> > >
> > > https://cwiki.apache.org/confluence/display/NETBEANS/
> > > Apache+NetBeans+9.0+Beta
> > >
> > > Bearing in mind that incubator releases do not need to be perfect, so
> > long
> > > as their imperfections are known and documented, what is there left to
> be
> > > done?
> > >
> > > We're close to having an incubation release of a Java 9.0 NetBeans IDE
> --
> > > though Beta, because after that we'll have the NetCAT program (and
> during
> > > that process we could also fix a few other things as well that we may
> > want
> > > to skip over for the Beta).
> > >
> > > Thanks,
> > >
> > > Gj
> > >
> >
>

Re: Status of Apache NetBeans (incubating) 9.0 Beta

2017-11-30 Thread Geertjan Wielenga 
Fair question.

On the other hand, we're clearly not in a position yet to do anything with
those files, even if they were to come in today -- we clearly have more
than enough work to do just on the code from the 1st donation.

That being said, we've restructured the subsequent donations such that we
can focus specifically on the parts we care most about right now -- Java
EE, JavaScript/HTML, PHP, and Groovy:

https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition

At the end of the above link, notice 5e, which is the focus of the 2nd
donation -- we've moved C++-related clusters to the third code donation so
that we can get especially the Java EE and JavaScript/HTML features over to
Apache as quickly as possible. The reason for the delays is simply a
question of resourcing and conflicting work assignments coming in the paths
of those working on this. However, again, I must say I'm happy we don't
have the 2nd code donation yet right now -- we'd be swamped, we'd have a
significant number of additional files we'd need to wade through while
right now we have plenty of files to wade through as it is.

Gj

On Thu, Nov 30, 2017 at 8:56 PM, John McDonnell 
wrote:

> Any update on the progress of the 2nd code donation?
>
> Is Oracle still going through those files - Any idea when that will be
> ready?
>
> John
>
> On 30 November 2017 at 19:41, Geertjan Wielenga <
> geertjan.wiele...@googlemail.com> wrote:
>
> > Hi all,
> >
> > Status for 9.0 Beta is looking really good -- the Rat report is almost
> down
> > to 0:
> >
> > https://builds.apache.org/job/incubator-netbeans-release/
> > lastSuccessfulBuild/artifact/rat-java-temp/nbbuild/build/rat-report.txt
> >
> > And pretty much all the issues are resolved or closed in some way:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/
> > Apache+NetBeans+9.0+Beta
> >
> > Bearing in mind that incubator releases do not need to be perfect, so
> long
> > as their imperfections are known and documented, what is there left to be
> > done?
> >
> > We're close to having an incubation release of a Java 9.0 NetBeans IDE --
> > though Beta, because after that we'll have the NetCAT program (and during
> > that process we could also fix a few other things as well that we may
> want
> > to skip over for the Beta).
> >
> > Thanks,
> >
> > Gj
> >
>

Re: Status of Apache NetBeans (incubating) 9.0 Beta

2017-11-30 Thread John McDonnell 
Any update on the progress of the 2nd code donation?

Is Oracle still going through those files - Any idea when that will be
ready?

John

On 30 November 2017 at 19:41, Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:

> Hi all,
>
> Status for 9.0 Beta is looking really good -- the Rat report is almost down
> to 0:
>
> https://builds.apache.org/job/incubator-netbeans-release/
> lastSuccessfulBuild/artifact/rat-java-temp/nbbuild/build/rat-report.txt
>
> And pretty much all the issues are resolved or closed in some way:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/
> Apache+NetBeans+9.0+Beta
>
> Bearing in mind that incubator releases do not need to be perfect, so long
> as their imperfections are known and documented, what is there left to be
> done?
>
> We're close to having an incubation release of a Java 9.0 NetBeans IDE --
> though Beta, because after that we'll have the NetCAT program (and during
> that process we could also fix a few other things as well that we may want
> to skip over for the Beta).
>
> Thanks,
>
> Gj
>

[GitHub] matthiasblaesing closed pull request #262: Fix NullPointerException at com.sun.source.util.TreePath.

2017-11-30 Thread GitBox 
matthiasblaesing closed pull request #262: Fix NullPointerException at 
com.sun.source.util.TreePath.
URL: https://github.com/apache/incubator-netbeans/pull/262
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocMemberEnter.java 
b/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocMemberEnter.java
index 8f227596b..df8734d2d 100644
--- 
a/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocMemberEnter.java
+++ 
b/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocMemberEnter.java
@@ -68,7 +68,10 @@ public void visitMethodDef(JCMethodDecl tree) {
 cancelService.abortIfCanceled();
 super.visitMethodDef(tree);
 if (trees instanceof NBJavacTrees && 
!env.enclClass.defs.contains(tree)) {
-((NBJavacTrees)trees).addPathForElement(tree.sym, new 
TreePath(trees.getPath(env.toplevel, env.enclClass), tree));
+TreePath path = trees.getPath(env.toplevel, env.enclClass);
+if (path != null) {
+((NBJavacTrees)trees).addPathForElement(tree.sym, new 
TreePath(path, tree));
+}
 }
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matthiasblaesing commented on issue #262: Fix NullPointerException at com.sun.source.util.TreePath.

2017-11-30 Thread GitBox 
matthiasblaesing commented on issue #262: Fix NullPointerException at 
com.sun.source.util.TreePath.
URL: 
https://github.com/apache/incubator-netbeans/pull/262#issuecomment-348299861
 
 
   The change looks save and in the worst case it masks the underlying bug. I'm 
pulling this in.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Status of Apache NetBeans (incubating) 9.0 Beta

2017-11-30 Thread Geertjan Wielenga 
Hi all,

Status for 9.0 Beta is looking really good -- the Rat report is almost down
to 0:

https://builds.apache.org/job/incubator-netbeans-release/lastSuccessfulBuild/artifact/rat-java-temp/nbbuild/build/rat-report.txt

And pretty much all the issues are resolved or closed in some way:

https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+9.0+Beta

Bearing in mind that incubator releases do not need to be perfect, so long
as their imperfections are known and documented, what is there left to be
done?

We're close to having an incubation release of a Java 9.0 NetBeans IDE --
though Beta, because after that we'll have the NetCAT program (and during
that process we could also fix a few other things as well that we may want
to skip over for the Beta).

Thanks,

Gj

Unsuscribe

2017-11-30 Thread ahmed al kahky 
Hello All,     Would you please remove me from this group?
Regards, Ahmed

[GitHub] matthiasblaesing commented on issue #305: [NETBEANS-71] Change product name

2017-11-30 Thread GitBox 
matthiasblaesing commented on issue #305: [NETBEANS-71] Change product name
URL: 
https://github.com/apache/incubator-netbeans/pull/305#issuecomment-348296064
 
 
   Thanks for your input!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lbruun commented on issue #305: [NETBEANS-71] Change product name

2017-11-30 Thread GitBox 
lbruun commented on issue #305: [NETBEANS-71] Change product name
URL: 
https://github.com/apache/incubator-netbeans/pull/305#issuecomment-348293708
 
 
   Whether it is required or not:
   
   http://apache.org/foundation/marks/pmcs.html#naming:
   
   As you can see the ASF really want us to use "Apache NetBeans" rather than 
just "NetBeans". If it is strictly required in the locations I've changed in 
this PR is open for interpretation. But the intent from the ASF is certainly 
clear. In any case I think it is in our (the (new) NetBeans community) interest 
too, i.e. to set the product apart from pre-Apache era.
   
   I've looked at Tomcat and Cassandra and they are pretty consistent in using 
the full name, in particular Tomcat will never, ever, refer to itself as solely 
"Tomcat". This goes for docs, UI and log messages. 
   
   Btw:  With this change, because of the changed `currentVersion` variable, 
the name which is printed at the top of the messages log will also change:
   
   ```text
   System Info: 
 Product Version = Apache NetBeans IDE Dev (Build 
20171128-unknown-revn)
 ...
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] geertjanw closed pull request #305: [NETBEANS-71] Change product name

2017-11-30 Thread GitBox 
geertjanw closed pull request #305: [NETBEANS-71] Change product name
URL: https://github.com/apache/incubator-netbeans/pull/305
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core.startup/src/org/netbeans/core/startup/Bundle.properties 
b/core.startup/src/org/netbeans/core/startup/Bundle.properties
index 9b974afeb..597aa19c9 100644
--- a/core.startup/src/org/netbeans/core/startup/Bundle.properties
+++ b/core.startup/src/org/netbeans/core/startup/Bundle.properties
@@ -26,7 +26,7 @@ OpenIDE-Module-Long-Description=\
 
 # VERSIONING (TopLogging, MainWindow)
 # {0} - build number
-currentVersion=NetBeans Platform Dev (Build {0})
+currentVersion=Apache NetBeans Platform Dev (Build {0})
 
 ERR_no_user_directory=netbeans.user is not set.\nPlease check your NetBeans 
startup script.
 # {0} - userdir full path
@@ -35,7 +35,7 @@ ERR_user_dir_is_inside_home=Your user directory ({0}) cannot 
reside inside your
 
 #Splash
 # title of the splash window; shown perhaps in window tray of e.g. Gnome
-LBL_splash_window_title=Starting NetBeans Platform
+LBL_splash_window_title=Starting Apache NetBeans Platform
 # The Title of the About Box
 CTL_About_Title=About
 CTL_About_Detail=Detail
diff --git 
a/core.windows/src/org/netbeans/core/windows/view/ui/Bundle.properties 
b/core.windows/src/org/netbeans/core/windows/view/ui/Bundle.properties
index f8b6cfe62..47cec6e2a 100644
--- a/core.windows/src/org/netbeans/core/windows/view/ui/Bundle.properties
+++ b/core.windows/src/org/netbeans/core/windows/view/ui/Bundle.properties
@@ -23,8 +23,8 @@ LBL_EditorAreaFrameTitle=Editor
 ACSD_MainWindow=Main Window
 # {0} build number
 # {1} project name
-CTL_MainWindow_Title=NetBeans Platform {0}
-CTL_MainWindow_Title_No_Project=NetBeans Platform {0}
+CTL_MainWindow_Title=Apache NetBeans Platform {0}
+CTL_MainWindow_Title_No_Project=Apache NetBeans Platform {0}
 
 # DocumentsDlg
 LBL_Documents=:
diff --git 
a/ide.branding/core.startup/src/org/netbeans/core/startup/Bundle_nb.properties 
b/ide.branding/core.startup/src/org/netbeans/core/startup/Bundle_nb.properties
index 174ca5cb9..f5151e4d0 100644
--- 
a/ide.branding/core.startup/src/org/netbeans/core/startup/Bundle_nb.properties
+++ 
b/ide.branding/core.startup/src/org/netbeans/core/startup/Bundle_nb.properties
@@ -48,8 +48,8 @@ AboutTextBounds=78, 60, 362, 20
 #NOI18N
 AboutTextColor=0x00
 
-LBL_splash_window_title=Starting NetBeans IDE
-currentVersion=NetBeans IDE Dev (Build {0})
+LBL_splash_window_title=Starting Apache NetBeans IDE
+currentVersion=Apache NetBeans IDE Dev (Build {0})
 
 MSG_warning=NetBeans IDE - Warning
 MSG_info=NetBeans IDE - Information
diff --git 
a/ide.branding/core.windows/src/org/netbeans/core/windows/view/ui/Bundle_nb.properties
 
b/ide.branding/core.windows/src/org/netbeans/core/windows/view/ui/Bundle_nb.properties
index 10db4704e..02d379039 100644
--- 
a/ide.branding/core.windows/src/org/netbeans/core/windows/view/ui/Bundle_nb.properties
+++ 
b/ide.branding/core.windows/src/org/netbeans/core/windows/view/ui/Bundle_nb.properties
@@ -17,5 +17,5 @@
 
 # {0} build number
 # {1} project name
-CTL_MainWindow_Title={1} - NetBeans IDE Dev {0}
-CTL_MainWindow_Title_No_Project=NetBeans IDE Dev {0}
+CTL_MainWindow_Title={1} - Apache NetBeans IDE Dev {0}
+CTL_MainWindow_Title_No_Project=Apache NetBeans IDE Dev {0}


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] geertjanw commented on issue #305: [NETBEANS-71] Change product name

2017-11-30 Thread GitBox 
geertjanw commented on issue #305: [NETBEANS-71] Change product name
URL: 
https://github.com/apache/incubator-netbeans/pull/305#issuecomment-348293587
 
 
   Well, one or two mentions of Apache in NetBeans itself would be good. 
Merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Gentoo Packaging] compat8 packages needed on 9

2017-11-30 Thread William L. Thomson Jr. 
This may seem obvious but figured I would ask anyway. Are the various
compat8 projects needed for running under 9? I assume they were made to
facilitate running under 1.8. Though I haven't seen any major issues
where the compat ones would resolve. Though may explain why some
packaged stuff isn't showing up yet.

Just curious either way thanks!

-- 
William L. Thomson Jr.


pgpfiechUnql1.pgp
Description: OpenPGP digital signature

[GitHub] matthiasblaesing commented on issue #305: [NETBEANS-71] Change product name

2017-11-30 Thread GitBox 
matthiasblaesing commented on issue #305: [NETBEANS-71] Change product name
URL: 
https://github.com/apache/incubator-netbeans/pull/305#issuecomment-348275239
 
 
   Looks ok, feel free to merge. Just out of curiosity - is the name change 
needed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] steffendietz commented on issue #279: [NETBEANS-162] Restore autoupdate.services tests

2017-11-30 Thread GitBox 
steffendietz commented on issue #279: [NETBEANS-162] Restore 
autoupdate.services tests
URL: 
https://github.com/apache/incubator-netbeans/pull/279#issuecomment-346710961
 
 
   I revisited point 1 from [above](#issuecomment-346595065). I'm now using the 
correct method of providing an executable file list by using the 
`nbm.executable.files` property.
   
   I also opened a JIRA issue regarding this change, but couldn't link it on 
the Confluence page where the donation changes are tracked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] steffendietz commented on issue #279: [NETBEANS-162] Restore autoupdate.services tests

2017-11-30 Thread GitBox 
steffendietz commented on issue #279: [NETBEANS-162] Restore 
autoupdate.services tests
URL: 
https://github.com/apache/incubator-netbeans/pull/279#issuecomment-348273063
 
 
   Is there something further I can do to get this merged? - It is ready to go 
from my perspective.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] steffendietz commented on issue #279: [NETBEANS-162] Restore autoupdate.services tests

2017-11-30 Thread GitBox 
steffendietz commented on issue #279: [NETBEANS-162] Restore 
autoupdate.services tests
URL: 
https://github.com/apache/incubator-netbeans/pull/279#issuecomment-348273063
 
 
   Is there something I can do further to get this merged? - It is ready to go 
from my perspective.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

AW: (Avoid) Using JavaFX WebView was: JDK & JavaFX versions

2017-11-30 Thread Christian Lenz 
Hey Jaroslav,

thank you so much for your PR, I will really have a deeper look into it soon as 
you can see my comments and I didn’t Close it . So the thing is, that I 
couldn’t find the solutions for my problems that I wrote earlier that’s why I 
changed it back and tried it by my own. I really like the approach but it 
wasn’t so comfortable for me and it still isn’t. For example, I said I want to 
write my JS where I need to and this should be in my UI, if this is not often 
possible, as I can see it in your PR, then I Need to Combine JS and Java and 
this is a mess in HTML4J because it is still a string and it can have a lot of 
errors, where you can’t find the solution because it is still a string.

Long time ago, I had to write GWT and I had to add some JSNI 
(http://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html) methods to 
it. That works similar to it but first the Syntax Looks different:

public static native void alert(String msg) /*-{
  $wnd.alert(msg);
}-*/;

Unfortunately NetBeans can’t handle this out of the box, but I think it is more 
a GWT type, but I brought simple syntax highlighting to the GWT4NB plugin: 
https://github.com/ksfreitas/gwt4nb/pull/41 My implementation based on 
Geertjans tutorial: 
https://blogs.oracle.com/geertjan/embedding-javascript-editor-in-java-editor 
Unfortunately, it doesn’t work correctly, as you can see it in the comment of 
Geertjan, but it is good enough, to see JS Syntax highlighted in Java: 
https://github.com/ksfreitas/gwt4nb/issues/36#issuecomment-255379539 and if 
someone can fix the stuff, that I can write real JS with working code 
completion (it only works for custom Code templates) in this /*-{}-*/ syntax in 
Java files, that would be aawesome and I think that this will be a much 
better solution for it to use a similar way in HTML4J and this will definitely 
change my mind about it  Today we have a lot of mixed languages, HTML in 
strings like in Angular, React, Vue (template property) or SQL inside strings, 
or regex etc. So yeah maybe this could be a better solution, I guess it will.


Regards

Chris

Von: Jaroslav Tulach
Gesendet: Donnerstag, 30. November 2017 07:05
An: dev@netbeans.incubator.apache.org
Betreff: Re: (Avoid) Using JavaFX WebView was: JDK & JavaFX versions

Hello Christian,

2017-11-29 16:07 GMT+01:00 Christian Lenz :

> As an real world example, which is working well and I found a good
> solution for me, myself and I, please look here:
> https://github.com/Chris2011/NbScratchFile/tree/develop


nice example of mixed UI development! I've polished it to avoid the JavaFX
WebView direct dependency:
https://github.com/Chris2011/NbScratchFile/pull/12 - we can discuss
possible improvements there.


> As you can see, I separated the Java application (My NetBeans module)
> completely from the HTML UI. This gave me the benefit, that I have a HTML5
> application, where I can use my own build System like Webpack, npm, Tasks,
> scss and the ability of the NetBeans IDE to handle this project as it is. I
> can run it, I can build it, I can debug it and and and. After I finished
> everything in the UI, I started the Java logic. So as you can see, I
> created a ViewModel to communicate with it in my UI, to call methods on it
> and to send stuff from the UI to the backend. No Need to add annotations or
> JS Code as strings in Java Code or JSNI (If possible) which is still weird
> for me as a FronEnd WebDeveloper.
>

Little bit of that is in my PR. However it actually has some benefits: for
example it is more secure. Rather than allowing calls to any Java method
from the view (your approach), I require the developer to explicitly
specify which methods shall be exposed. The evolution of Android
Java/JavaScript bridge shows such security concerns are quite important.


> As you can see I only wanted to minimze the amount of Java Code that I had
> to write. Only some methods to get the colors from NetBeans fields to set
> the Color to the UI fields to be dynamically, when someone changes their
> laf from light to darcula or metal or whatever and the logic that I needed
> for my plugin. No Need to have specific css files, just methods to call. It
> is not that good but it is a good compromise and it works pretty well
> and some kind of fast.
>
> I started with DukeScript first, because I wanted to write HTML UIs but I
> had some problems. The biggest one was, that my WebApp, doesn’t work the
> same as expected in the Java NetBeans module context as in my browser and I
> couldn’t find out why.
>
> The other problem, what I can say is the generated shizzle code which
> happens in the back if you create a view model, because I decoupled the
> model, I tried it with the annotations and I created a new, separated class
> in a new file and the generation of the code breaks. I couldn’t find out
> why. Yeah sure needed more investigation, but I didn’t want it. My
> playground is HTML/JS(TS)/CSS(SCSS) and so on.

[GitHub] geertjanw commented on issue #305: [NETBEANS-71] Change product name

2017-11-30 Thread GitBox 
geertjanw commented on issue #305: [NETBEANS-71] Change product name
URL: 
https://github.com/apache/incubator-netbeans/pull/305#issuecomment-348140054
 
 
   +1 looks great and good thinking.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lbruun opened a new pull request #305: [NETBEANS-71] Change product name

2017-11-30 Thread GitBox 
lbruun opened a new pull request #305: [NETBEANS-71] Change product name
URL: https://github.com/apache/incubator-netbeans/pull/305
 
 
   The product name, i.e. 'NetBeans Platform' or 'NetBeans IDE', is changed to 
reflect the new Apache home, in a couple of locations. This is done to 
distinguish the product from the pre-Apache era.
   
   These changes are expected to be permanent. As for any actual release, such 
release will be expected to brand these variables, e.g. insert the word 
"(incubating)" for releases done while in Apache incubating phase, etc. This is 
similar to the existing release process prior to NB9.
   
   It doesn't make sense to change every occurrence of "NetBeans Platform" or 
"NetBeans IDE". It only makes sense in the most prominent locations, IMO. The 
ones I've chosen are outlined below.  There are a few other locations where I 
think it makes sense to change as well, but they are all related to the IDE's 
Installer, and since that part hasn't been donated yet, it cannot be changed 
just yet.
   
   ## Changes in this PR
   
   **1. The main window's title bar**
   
   
![titlebar](https://user-images.githubusercontent.com/32431476/33424207-60b15de8-d5bb-11e7-8ef3-8aa5ee3a8154.png)
   
   **2. the product name in the About dialog.**
   
![about](https://user-images.githubusercontent.com/32431476/33424215-675e6910-d5bb-11e7-8f3b-2a0f2250f26e.png)
   
   
   3. (less prominent because nobody notices) : The title of the splash window 
in the OS window tray / status line
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] geertjanw commented on issue #303: [NETEBEANS-171] Removed hibernate and hibernate4libs

2017-11-30 Thread GitBox 
geertjanw commented on issue #303: [NETEBEANS-171] Removed hibernate and 
hibernate4libs
URL: 
https://github.com/apache/incubator-netbeans/pull/303#issuecomment-348133151
 
 
   Can you also close this: https://issues.apache.org/jira/browse/NETBEANS-171


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [Gentoo packaging] Can't find resource for bundle

2017-11-30 Thread William L. Thomson Jr. 
On Thu, 30 Nov 2017 03:39:59 -0500
"William L. Thomson Jr."  wrote:

> On Thu, 30 Nov 2017 09:09:49 +0100
> Jaroslav Tulach  wrote:
> >
> > There is some beauty in your approach, but it is a lot of work.   
> 
> It is a lot of redundancy and tediousness but not really that much
> work per se. The packages themselves are quite tiny. It is more time
> in resolving what other packages are needed. What to package next,
> etc.


Tiny ebuilds per package, way smaller than any ant, maven, gradle etc :)
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/netbeans-editor/netbeans-editor-.ebuild

See there is not much to it. Even the eclass is not big. Nor the other
eclasses, java-pkg-simple, etc. All together its great :)
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/eclass/java-netbeans.eclass
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/eclass/java-pkg-simple.eclass

-- 
William L. Thomson Jr.


pgpF7_6l1RkET.pgp
Description: OpenPGP digital signature

Re: [Gentoo packaging] Can't find resource for bundle

2017-11-30 Thread William L. Thomson Jr. 
On Thu, 30 Nov 2017 09:29:31 +0100
Jan Lahoda  wrote:
> 
> This is a little bit surprising to me. AFAIK in JDK 8 it worked like
> this: for:
> $ javac -processorpath  

Interesting, maybe that is the solution. Presently just using classpath
and passing sources. I am setting the --source-path now. 
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/eclass/java-netbeans.eclass#L249

I had to have that for it to find resources for the static annotation
processor as I mentioned in another post. I did not think about it
finding processors. But I guess I need to set the entire classpath to
the source path or something.  I am pretty sure I tried removing the
-processor and it didn't find them.

I some what have current proof. As I just packaged the
org.netbeans.html stuff, or some. net-java-html packages. One of them
had a Model Annnotation  processor. It did not find it on the
classpath. It was already compiled, but I needed it for templatesui.
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/eclass/java-netbeans.eclass#L158
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/netbeans-templatesui/netbeans-templatesui-.ebuild

> roughly, javac looked into the jars, searched for
> META-INF/services/javax.annotation.processing.Processor files, and
> used processors registered by these files. I.e. processors in jars
> were used in sources.

Hmm, maybe some are missing that. But I tested that out when I added
those files and resolved another issue with the unknown protocol nbres.
Along with that file there was one for the annotation process. The
net-java-html-json Model processor jar has that but it was not detected.

# unzip -l /usr/share/net-java-html-json/lib/net-java-html-json.jar |
grep javax
META-INF/services/javax.annotation.processing.Processor

# unzip
-l /usr/share/netbeans-core-startup-9/lib/netbeans-core-startup.jar |
grep java
META-INF/namedservices/URLStreamHandler/nbresloc/java.net.URLStreamHandler
META-INF/namedservices/URLStreamHandler/nbres/jav .net.URLStreamHandler
META-INF/services/javax.annotation.processing.Processor
META-INF/services/java.net.URLStreamHandlerFactory

The URLStreamHandler stuff resolved my nbres issue. It did not see to
help with any annotation. I still had to pass them. Which I do not
mind. That seems to work well.

> Then this:
> $ javac -classpath  
> 
> Is mostly a shorthand for:
> $ javac -classpath  -processorpath  

Interesting, but seems redundant to be including things on the
classpath for compile, and then maybe the same again for annotations.
For ones that are just dependencies for annotation processors that
might make sense. Just seems like lots of bloat and duplication.

> In JDK 9, there is a new option, "--processor-module-path", which
> works over JDK/Jigsaw modules (and disables the autosearch from
> classpath/processorpath), but unless it is used, I don't offhand
> recall a change that would disable the old classpath/processorpath
> approach.

I may need to repeat my tests, but I did come across what your talking
about. That annotation processors should be found etc. Thus far it does
not seem to be the case. I can test again tomorrow with source path.
Though I was not adding classpath jars, so maybe that was my mistake.

That would simplify things a bit. But for the most part I have the
processors thing down now.

> So if there is a particular commandline that did the
> autosearch on 8 and does not on 9, then there may be a javac bug.

Not sure if its a bug or not. I was wondering about the
processor-module-path. The whole annotation processing in this manner
is new to me. I am used to asm doing it but not within Java. I missed
that feature of 1.8 or when ever it was added :P Obviously :)

-- 
William L. Thomson Jr.


pgpeNV9qvKQ9B.pgp
Description: OpenPGP digital signature

Re: [Gentoo packaging] Can't find resource for bundle

2017-11-30 Thread William L. Thomson Jr. 
On Thu, 30 Nov 2017 09:09:49 +0100
Jaroslav Tulach  wrote:
>
> There is some beauty in your approach, but it is a lot of work. 

It is a lot of redundancy and tediousness but not really that much work
per se. The packages themselves are quite tiny. It is more time in
resolving what other packages are needed. What to package next, etc.

> For example I doubt NetBeans can be currently built with JDK9. 

The majority can and has thus far just fine. Only ran into like 2 or 3
classes in total that needed to be address for Java 9. Presently stuck
on one with a LazyDocumentTable.Entry that is private now.

Along those same lines may be able to help with some patches to fix
issues under 9. Though can't really say I am there just yet.

> The  first thing I would do: set a regular Jenkins job to build on
> JDK9 and fix the regular Ant build to build with JDK9. 

I was doing that I was having to many problems and wasting to much
time. Example
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/netbeans-platform/netbeans-platform-8.2-r11.ebuild#L113

Gentoo has python code to re-write ant build xml source/target. But
that has never worked with Netbeans and its in to many locations. There
is no support for --release. Thus I had to remove that stuff via sed
and then use javacargs to pass in other stuff.

But I ran into strange issues with ant under Portage I did not with ant
directly. The whole ant + portage stuff I am no longer a fan of and
looking to circumvent. Patching build.xml, fiddling with them etc is no
fun.
https://dev.gentoo.org/~fordfrog/distfiles/${PN:0:8}-${SLOT}-build.xml.patch.bz2
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/netbeans-platform/netbeans-platform-8.2-r11.ebuild#L13

> However I can't tell you want to do: De gustibus non disputandum est.
> In any case, good luck! -jt

Thanks, its coming along very well. Making tremendous progress. I
packaged some 70+ pieces of eclipse just for lombok. This is much more
rewarding as I use it like other stuff I have packaged. Lombok was an
indirect dependency of spring. Which spring is like ever java library
ever written used in some form or another...

Just stuck on this one issue. Driving me crazy as I have overcome all
others. Once past this I can get a better clue as to other stuff. But
getting very few errors in message.log. Other than the annoying bundle
exceptions. Why it excludes some stuff no clue. But NbBundleProcessor
for sure creates files I need to build. Just not some stuff needed at
runtime, text messages.

-- 
William L. Thomson Jr.


pgpQahcjBCN1F.pgp
Description: OpenPGP digital signature

Re: [Gentoo packaging] Can't find resource for bundle

2017-11-30 Thread Jaroslav Tulach 
2017-11-30 8:18 GMT+01:00 William L. Thomson Jr. :

> On Thu, 30 Nov 2017 07:50:13 +0100
> Jaroslav Tulach  wrote
> > I would assume you get NetBeans-source.zip file, replace all binaries
> > with references to files from other packages and then invoke
> >
> > $ ant build
>
> Not at all, very far from what I am doing. Its in the archives. I am
> suing Gentoo Java system. Essentially shell scripts that get a list of
> java files and pass that to javac.
>
> No ant, no maven, no gradle. Straight javac.
>

There is some beauty in your approach, but it is a lot of work. For example
I doubt NetBeans can be currently built with JDK9. The first thing I would
do: set a regular Jenkins job to build on JDK9 and fix the regular Ant
build to build with JDK9. However I can't tell you want to do: De gustibus
non disputandum est. In any case, good luck!
-jt