[RESULT][VOTE] Release Apache NetBeans 9.0 Beta (incubating) rc3

2018-02-09 Thread Geertjan Wielenga
Hi all,

After being opened for over more than 72 hours, the vote for releasing
incubating-netbeans-java-9.0-beta [rc3] passed with 2 binding +1s
(from two of our Apache NetBeans mentors), 31 non-binding +1s (from
PPMC members, as well as others on the Apache NetBeans dev mailing
list) and no 0 or -1.

The link to the vote thread is

https://lists.apache.org/thread.html/f1c5a2a3077690f2c7785ed81c36f1ba1920efa01b26f3e7a5f32f2b@%3Cdev.netbeans.apache.org%3E

Binding votes +1s:

Bertrand Delacretaz
Ate Douma

Non-binding votes +1s:

Gilberto Caetano de Andrade
Emilian Bold
John Brock
Alexius Diakogiannis
Constantin Drabo
James Gosling
Gaurav Gupta
Jacek Gzel
David Heffelfinger
Ludovic Hochet
Glenn Holmer
Josh Juneau
Sarvesh Kesharwani
John Kostaras
Jiri Kovalsky
Illya Kysil
Christian Lenz
Josh McDonnell
Michael Mueller
Kai Uwe Pel
Sean Phillips
Vikas Prabhakar
Delfi Ramirez
Sven Reimers
Arunava Sinha
Neil C Smith
Reema Taneja
Antonio Vieiro
Florian Volger
Geertjan Wielenga
Junichi Yamamoto

Thanks to all who examined the release artifacts and voted.

I will now start a new thread for the IPMC vote.

Thanks all,

Geertjan
on behalf of the Apache NetBeans PPMC

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread Geertjan Wielenga
Here's our release management page with instructions I followed in
putting the rc3 together:

https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+Release+README

What could be added/changed/corrected in the above to avoid the
specific issues that have arisen with the tag -- and anything else to
make the above as complete as possible?

Thanks,

Gj

On Fri, Feb 9, 2018 at 11:59 AM, John Muczynski  wrote:
> Hi guys,
>
> re: LICENSE being slightly different in the source tarball
> Here at SimuQuest, we've had similar confusions between files which are
> templates in version control but fleshed out in the release.
> Our solution has been to
>* keep the templates in a separate folder
>* use a templating language like the one in maven or Velocity
>* try to keep comments in each file saying what it is and where it came
> from
>* not include the template folder in the binary release
>
> For us, this has been motivated less by tarball comparisons and more by
> wanting developers to modify and commit the "right" copy of the file.
>
> Hope the info helps.
>
> Kind Regards,
> Johnny
>
>
> --
> Johnny Muczynski
> 734-262-2045
>
> On Fri, Feb 9, 2018 at 5:39 AM, Neil C Smith  wrote:
>
>> On Fri, 9 Feb 2018 at 10:30 Bertrand Delacretaz 
>> wrote:
>>
>> > I think LICENSE being slightly different (better actually, right?) in
>> > the source tarball is perfectly fine if there's a rational reason for
>> > it - you just need to reassure people that it's not a mistake.
>> >
>>
>> Thanks.  Yes it's better - to clarify I meant aiming towards checking in
>> and tracking history in git of the version in the full source bundle.
>> Something for a later discussion anyway.
>>
>>
>> >
>> > For that you just need to be able to answer such questions with "have
>> > a look at http://netbeans.apache.org/release-management.html; instead
>> > of re-explaining every time.
>> >
>> >
>> Definitely one to add to the list of initial pages we were discussing the
>> other day then! ;-)
>>
>> Thanks and best wishes,
>>
>> Neil
>> --
>> Neil C Smith
>> Artist & Technologist
>> www.neilcsmith.net
>>
>> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
>>

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: info requested regarding build fail

2018-02-09 Thread Peter Hull
I have a work-around for building on Fedora, here it is:
--- incubator-netbeans-9.0-beta-rc3/websvc.saas.api/build.xml2018-02-09
11:06:36.124001000 +
+++ /tmp/incubator-netbeans-9.0-beta-rc3/websvc.saas.api/build.xml
2018-01-31 17:49:31.0 +
@@ -33,7 +33,7 @@
 

 
-
+
 
 
 

There's no documentation I can find but looking at the code, XJC2Task ends
up executing the same code as XJCTask but without manipulating the class
loaders quite as much.
 "Fix your NetBeans with this one weird trick"!!
Would be great if someone could test on SUSE too.
Pete


On Wed, 7 Feb 2018 at 10:53 Peter Hull  wrote:

> On Sat, 3 Feb 2018 at 07:37 Emilian Bold 
> wrote:
>
>> The bug that keeps on giving.
>>
>> I was able to recreate something which I *believe* is the same issue that
> stops the NB  build on fedora, using only packages from their distro. So,
> our hands are clean ;) Seriously, though, this means they are able to
> reproduce it more easily.
> I filed this as https://bugzilla.redhat.com/show_bug.cgi?id=1542899
> Will keep you informed if anything happens.
> Peter
>
>
>


Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread John Muczynski
Hi guys,

re: LICENSE being slightly different in the source tarball
Here at SimuQuest, we've had similar confusions between files which are
templates in version control but fleshed out in the release.
Our solution has been to
   * keep the templates in a separate folder
   * use a templating language like the one in maven or Velocity
   * try to keep comments in each file saying what it is and where it came
from
   * not include the template folder in the binary release

For us, this has been motivated less by tarball comparisons and more by
wanting developers to modify and commit the "right" copy of the file.

Hope the info helps.

Kind Regards,
Johnny


--
Johnny Muczynski
734-262-2045

On Fri, Feb 9, 2018 at 5:39 AM, Neil C Smith  wrote:

> On Fri, 9 Feb 2018 at 10:30 Bertrand Delacretaz 
> wrote:
>
> > I think LICENSE being slightly different (better actually, right?) in
> > the source tarball is perfectly fine if there's a rational reason for
> > it - you just need to reassure people that it's not a mistake.
> >
>
> Thanks.  Yes it's better - to clarify I meant aiming towards checking in
> and tracking history in git of the version in the full source bundle.
> Something for a later discussion anyway.
>
>
> >
> > For that you just need to be able to answer such questions with "have
> > a look at http://netbeans.apache.org/release-management.html; instead
> > of re-explaining every time.
> >
> >
> Definitely one to add to the list of initial pages we were discussing the
> other day then! ;-)
>
> Thanks and best wishes,
>
> Neil
> --
> Neil C Smith
> Artist & Technologist
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
>


Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread Neil C Smith
On Fri, 9 Feb 2018 at 10:30 Bertrand Delacretaz 
wrote:

> I think LICENSE being slightly different (better actually, right?) in
> the source tarball is perfectly fine if there's a rational reason for
> it - you just need to reassure people that it's not a mistake.
>

Thanks.  Yes it's better - to clarify I meant aiming towards checking in
and tracking history in git of the version in the full source bundle.
Something for a later discussion anyway.


>
> For that you just need to be able to answer such questions with "have
> a look at http://netbeans.apache.org/release-management.html; instead
> of re-explaining every time.
>
>
Definitely one to add to the list of initial pages we were discussing the
other day then! ;-)

Thanks and best wishes,

Neil
-- 
Neil C Smith
Artist & Technologist
www.neilcsmith.net

Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org


Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread Bertrand Delacretaz
On Fri, Feb 9, 2018 at 11:24 AM, Neil C Smith  wrote:
> ...it's a real gotcha I think we're going to have to keep answering.  I'd
> be interested in your (and other mentors) thoughts on this...

I think LICENSE being slightly different (better actually, right?) in
the source tarball is perfectly fine if there's a rational reason for
it - you just need to reassure people that it's not a mistake.

For that you just need to be able to answer such questions with "have
a look at http://netbeans.apache.org/release-management.html; instead
of re-explaining every time.

On that page there can be a justification for that minor difference as
well as any things that people need to know about how you build
releases.

-Bertrand

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread Neil C Smith
On Fri, 9 Feb 2018 at 10:11 Bertrand Delacretaz 
wrote:

> On Fri, Feb 9, 2018 at 11:05 AM, Neil C Smith 
> wrote:
> > ...That's because the tail of this file is generated as part of building
> the
> > source zip isn't it?..
>
> Bingo - removing the tail produces a match, thanks for clarifying!
>
> IMO those things ("the tag will not be identical" etc) should be
> documented on a NetBeans release management page, to be able to answer
> such questions with an URL.
>
>
Yes, it's a real gotcha I think we're going to have to keep answering.  I'd
be interested in your (and other mentors) thoughts on this, because I think
we should be aiming for a situation where git cloning the tag and a full
source zip are identical?

Best wishes,

Neil
-- 
Neil C Smith
Artist & Technologist
www.neilcsmith.net

Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org


Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread Bertrand Delacretaz
On Fri, Feb 9, 2018 at 11:05 AM, Neil C Smith  wrote:
> ...That's because the tail of this file is generated as part of building the
> source zip isn't it?..

Bingo - removing the tail produces a match, thanks for clarifying!

IMO those things ("the tag will not be identical" etc) should be
documented on a NetBeans release management page, to be able to answer
such questions with an URL.

-Bertrand

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread Neil C Smith
On Fri, 9 Feb 2018 at 09:51 Bertrand Delacretaz 
wrote:

> I still see differences, incubating-netbeans-java-9.0-beta-source.zip
> contains
>
> MD5 (LICENSE) = 6a87311b0cbacb9250a56cf5950ba9b3
>
> But
> https://raw.githubusercontent.com/apache/incubator-netbeans/9.0-beta-rc3/LICENSE
> has
>
> MD5 (LICENSE) = b1e01b26bacfc2232046c90a330332b3
>

That's because the tail of this file is generated as part of building the
source zip isn't it?

I still dislike the fact we're doing this.  But I guess something reviewers
need to be aware of too?

Best wishes,

Neil
-- 
Neil C Smith
Artist & Technologist
www.neilcsmith.net

Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org


Re: [Mentors] 9.0 beta rc3 vote thread

2018-02-09 Thread Bertrand Delacretaz
On Fri, Feb 9, 2018 at 8:29 AM, Jan Lahoda  wrote:
> FYI, I've moved the tag to "41da26b7de7506c86dee891b88b50f3c6f37b5bb":
> https://github.com/apache/incubator-netbeans/releases/tag/9.0-beta-rc3

I still see differences, incubating-netbeans-java-9.0-beta-source.zip contains

MD5 (LICENSE) = 6a87311b0cbacb9250a56cf5950ba9b3

But 
https://raw.githubusercontent.com/apache/incubator-netbeans/9.0-beta-rc3/LICENSE
has

MD5 (LICENSE) = b1e01b26bacfc2232046c90a330332b3

-Bertrand

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Unable to quit after cancelling Savables

2018-02-09 Thread Marco Rossi
I tested with my app and now it works as expected.
Thank you.

> Il giorno 07 feb 2018, alle ore 22:05, Emilian Bold 
>  ha scritto:
> 
> I've updated the PR. If it's OK, I'll commit it tomorrow or so.
> 
> --emi
> ​
> 
>  Original Message 
> On 7 February 2018 1:21 AM, John McDonnell  wrote:
> 
>> Hi Emilian,
>> 
>> It's fairly hard to say how long is too long to assume that the user has
>> cancelled the save dialog.
>> 
>> I've been messing around here, and I can see no difference to calling
>> performQuit() or cancelQuit() on the response object (Only tested with JDK8
>> so far)
>> 
>> Can we not then go simplier?
>> and add the line:
>> response.cancelQuit();
>> to both
>> handleQuitRequestWith(QuitEvent e, QuitResponse response)
>> methods?
>> 
>> Since NetBeans handles the shutdown elsewhere after the save dialog is
>> resolved, this doesn't appear to do anything from my rudimentary tests.
>> 
>> (Was going to create a Jira/PR shortly but you beat me to it...)
>> 
>> 
>> Regards
>> 
>> John
>> 
>> 
>> On 6 February 2018 at 23:06, Emilian Bold emilian.b...@protonmail.ch
>> wrote:
>> 
>>> A proper fix would be nice but I just thought of a nice workaround. See
>>> https://github.com/apache/incubator-netbeans/pull/411
>>> --emi
>>>  Original Message 
>>> On 7 February 2018 12:15 AM, Geertjan Wielenga <
>>> geertjan.wiele...@googlemail.com> wrote:
 Yes, a pull request for this would be great -- maybe starting with an
 issue on Apache NetBeans JIRA.
 Gj
 On Tue, Feb 6, 2018 at 11:08 PM, Emilian Bold
 emilian.b...@protonmail.ch wrote:
> [Also sending this interesting bug to dev@]
> Hello all,
> Note this interesting NetBeans bug on macOS: users can't quit the app if
> they cancelled once!
> 
> Might actually explain why sometimes NetBeans prevents Macs from
> shutting down!
> 
> Marco here seems to have (re)discovered it.
> Anybody want to take a crack at it?
> --emi
>  Original Message 
> On 7 February 2018 12:05 AM, Emilian Bold emilian.b...@protonmail.ch
> wrote:
> 
> 
>> I does look like a bug in org.netbeans.modules.applemenu.
>> NbApplicationAdapterJDK8.handleQuitRequestWith(AppEvent.QuitEvent e,
>> QuitResponse response)
>> 
> 
> 
>> Seems to me that when the user cancels QuitResponse.cancelQuit should
>> be called.
>> 
> 
> 
>> Actually, the Javadoc is quite clear https://docs.oracle.com/
>> javase/9/docs/api/java/awt/desktop/QuitHandler.html :
>> 
> 
> 
>> 
>>> Implementors must call either QuitResponse.cancelQuit(),
>>> QuitResponse.performQuit(), or ensure the application terminates.
>>> 
>> 
> 
> 
>> 
>>> Please report the bug for NETBEANS on the Apache Jira:
>>> issues.apache.org/jira/
>>> 
>> 
> 
> 
>> Great find! Seems to me the whole exit action design is unable to send
>> an answer back in case of cancel.
>> 
> 
> 
>> I also see this has been reported multiple times in the old Bugzilla:
>> https://netbeans.org/bugzilla/show_bug.cgi?id=268549
>> https://netbeans.org/bugzilla/show_bug.cgi?id=271946
>> https://netbeans.org/bugzilla/show_bug.cgi?id=269724
>> (probably) https://netbeans.org/bugzilla/show_bug.cgi?id=247690
>> --emi
>>  Original Message 
>> On 6 February 2018 11:22 PM, Marco Rossi ma...@markreds.it wrote:
>>> Hi Emilian,
>>> I’ve created this small project (attached here as a zip, hope it’s
>>> ok) and got the same issue. Please note that this seems to be related 
>>> to OS
>>> X only (in Windows it works).
>>> 
>> 
> 
> 
>> 
>>> My environment is Netbeans IDE 8.2 on OS X 10.11.6 with Java 1.8.
 Il giorno 06 feb 2018, alle ore 19:05, Emilian Bold
 emilian.b...@protonmail.ch ha scritto:
 
>>> 
>> 
> 
> 
>> 
>>> 
 Might be something more subtle, I know I could be able to press
 Cancel with Salvables.
 
>>> 
>> 
> 
> 
>> 
>>> 
 Can you create a simple project that reproduces this problem?
 --emi
 To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org
 For additional commands, e-mail: users-h...@netbeans.apache.org
 For further information about the NetBeans mailing lists, visit:
 https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
 
>>> 
>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> To unsubscribe, e-mail: