[CANCEL] [RESULT] [VOTE] Release Apache NLPCraft 0.5.0-rc1

2020-04-27 Thread Aaron Radzinski
NLPCraft-ers, To avoid further confusion I'm cancelling the vote for 0.5.0-rc1 release. Its artifacts were also removed from the "dev" area [1]. As a reminder - the NLPCraft community approved the 0.5.0-rc1 release but decided NOT to go for an official ASF release with it. 1.

[RESULT] [VOTE] Release Apache NLPCraft 0.5.0

2020-04-22 Thread Aaron Radzinski
NLPCraft-ers, The vote for 0.5.0 release is closed now. Vote result: The vote PASSES with 4 votes +1 and no -1. +1 votes: - Nikita Ivanov - Sergey Kamov - Furkan KAMACI - Sergey Makov Thank you, -- Aaron Radzinski

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-22 Thread Furkan KAMACI
Hi, +1 from me. I checked: - Incubating in name - DISCLAIMER exists - LICENSE and NOTICE are fine - No unexpected binary files - Checked PGP signatures - Checked Checksums - Code compiles and tests successfully run Kind Regards, Furkan KAMACI On Wed, Apr 22, 2020 at 8:57 PM Nikita Ivanov

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-22 Thread Nikita Ivanov
Can we please get any of the mentors to review and vote on the release? Thanks, -- Nikita Ivanov On Mon, Apr 20, 2020 at 1:46 AM Sergey Makov wrote: > +1 > > Tested on mac only: > - mvn clean verify > - ZIP signatures check > > Regards, > Sergey > > On Sun, Apr 19, 2020 at 11:21 AM Aaron

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-22 Thread Aaron Radzinski
gt; Performing releases is an important task for a project. Given that it is >>> a >>> formal activity, it needs to be very clear what is being voted on and >>> what >>> the result was. >>> >>> At the moment, we have one email saying "[RESULT][VOTE] Re

Re: [RESULT] [VOTE] Release Apache NLPCraft 0.5.0

2020-04-22 Thread Konstantin Boudnik
Yup, officially the PPMC vote isn't binding - hence IPMC needs to cast the votes (usual binding votes to make the release an official ASF one). --   Cos On 2020-04-21 13:24, Paul King wrote: Actually, below is premature. Once dev vote has been handled, it needs the second round of voting by

Re: [RESULT] [VOTE] Release Apache NLPCraft 0.5.0

2020-04-21 Thread Paul King
Actually, below is premature. Once dev vote has been handled, it needs the second round of voting by sending to gene...@incubator.apache.org as per: https://incubator.apache.org/policy/incubation.html#releases Unless you are just practicing release procedures and don't want the previous release

Re: [RESULT] [VOTE] Release Apache NLPCraft 0.5.0

2020-04-21 Thread Paul King
No problems. If approved, we would expect release to be available in a nlpcraft folder under here: https://dist.apache.org/repos/dist/release/incubator/ Can also be found externally via the now preferred alias for above: https://downloads.apache.org/incubator/ The nlpcraft folder would also be

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-20 Thread Aaron Radzinski
en that it is a > formal activity, it needs to be very clear what is being voted on and what > the result was. > > At the moment, we have one email saying "[RESULT][VOTE] Release Apache > NLPCraft 0.5.0" saying it passed and then another [VOTE] email with the > same subj

Re: [RESULT] [VOTE] Release Apache NLPCraft 0.5.0

2020-04-20 Thread Aaron Radzinski
NLPCraft-ers, Correction on the subject of this email (and its thread). This vote was for the "0.5.0-rc1" build. Thanks, -- Aaron Radzinski On Wed, Apr 15, 2020 at 5:58 PM Aaron Radzinski wrote: > NLPCraft-ers, > The vote for a new release candidate is closed now. > Vote result: The vote

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-20 Thread Sergey Makov
+1 Tested on mac only: - mvn clean verify - ZIP signatures check Regards, Sergey On Sun, Apr 19, 2020 at 11:21 AM Aaron Radzinski wrote: > > NLPCraft-ers, > This is the GA release following up on the 0.5.0-rc1 release. This mostly > addressed issues highlighted by Paul King in [1]. This final

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Paul King
Performing releases is an important task for a project. Given that it is a formal activity, it needs to be very clear what is being voted on and what the result was. At the moment, we have one email saying "[RESULT][VOTE] Release Apache NLPCraft 0.5.0" saying it passed and then ano

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Paul King
Understood, so the signature file was correctly renamed as per previous feedback but that didn't make the email voting template. I think that is something we can work with as long as everyone is aware. But obviously, we should fix the template for next time. On Sun, Apr 19, 2020 at 8:45 PM Sergey

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Paul King
+1 for concluding this thread with a formal [CANCEL] email from the release manager. Managing releases is one of the main tasks of a PMC, so keeping things very clear is always a good idea. On Thu, Apr 16, 2020 at 6:21 PM Furkan KAMACI wrote: > Hi, > > Apart from creating release candidates for

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Paul King
On Mon, Apr 20, 2020 at 7:28 AM Nikita Ivanov wrote: > Paul, team, > I can see the confusion as far as KEYS file. It should be under "release" > sub-folder of the https://dist.apache.org/repos/dist/ and NOT under "dev" > sub-folder. Also, release candidates should go to "dev" and the releases >

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Nikita Ivanov
Paul, team, I can see the confusion as far as KEYS file. It should be under "release" sub-folder of the https://dist.apache.org/repos/dist/ and NOT under "dev" sub-folder. Also, release candidates should go to "dev" and the releases should go to "release". One more question: do we upload proposed

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Aaron Radzinski
Furkan, I guess it's just my terminology... All I meant is that this release contains quick fixes for the issues discovered on RC1. Thanks, -- Aaron Radzinski On Sun, Apr 19, 2020 at 5:57 AM Furkan KAMACI wrote: > Hi, > > What does following up on the 0.5.0-rc1 release mean? This seems a new

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Furkan KAMACI
Hi, What does following up on the 0.5.0-rc1 release mean? This seems a new release candidate with new commits which has a different checksum? By the way, I've written advices about release candidate votes and cancel vote e-mails. Kind Regards, Furkan KAMACI On Sun, Apr 19, 2020 at 3:27 PM Paul

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Paul King
Also, it is usually good to mention the KEYS file location in the vote email and that file still needs to be moved, i.e. not be in the dev area but only in the release area even at this stage. On Sun, Apr 19, 2020 at 8:45 PM Sergey Kamov wrote: > ok, > > but note please that valid pgp link is >

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Sergey Kamov
+1 Files checked, tests and examples checked under IDEA and maven, under mac and win Regards, Sergey Kamov 19.04.2020 11:21, Aaron Radzinski пишет: NLPCraft-ers, This is the GA release following up on the 0.5.0-rc1 release. This mostly addressed issues highlighted by Paul King in [1].

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Sergey Kamov
ok, but note please that valid pgp link is not https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig but https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.asc Sergey 19.04.2020

[VOTE] Release Apache NLPCraft 0.5.0

2020-04-19 Thread Aaron Radzinski
NLPCraft-ers, This is the GA release following up on the 0.5.0-rc1 release. This mostly addressed issues highlighted by Paul King in [1]. This final 0.5.0 release is ready and up for the vote: 1. Apache dist location 1. Quick

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-16 Thread Paul King
No probs, most of those items should be fine for next release. I'd consider fixing the location of the KEYS file straight away since that might cause -1 votes in the next round of voting by IPMC or may cause Infra to require it to be fixed. The duplicate within the jar shouldn't matter, just the

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-16 Thread Furkan KAMACI
Hi, Apart from creating release candidates for each cycle of the release process, you can send a cancel vote thread as a convention when you decide to run new voting for a new release candidate. You can check an example from here:

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-16 Thread Aaron Radzinski
Paul, Your feedback is captured in [1] and will be addressed in the next point release. Thank you, 1. https://issues.apache.org/jira/browse/NLPCRAFT-38 -- Aaron Radzinski On Tue, Apr 14, 2020 at 1:55 AM Paul King wrote: > +1 (with some comments below): > > Tested: > - signature okay > -

[RESULT] [VOTE] Release Apache NLPCraft 0.5.0

2020-04-15 Thread Aaron Radzinski
NLPCraft-ers, The vote for a new release candidate is closed now. Vote result: The vote PASSES with 5 votes +1 and no -1. +1 votes: - Nikita Ivanov - Sergey Kamov - Furkan KAMACI - Sergey Makov - Paul King Thank you, -- Aaron Radzinski

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-15 Thread Furkan KAMACI
Hi, +1 from me. I checked: - Incubating in name - DISCLAIMER exists - LICENSE and NOTICE are fine - No unexpected binary files - Checked PGP signatures - Checked Checksums - Code compiles and tests successfully run Kind Regards, Furkan KAMACI On Wed, Apr 15, 2020 at 8:53 PM Nikita Ivanov

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-15 Thread Nikita Ivanov
NLPCraft-ers, The vote's timeline is over but we still need more votes. Can some of the mentors please vote? We need to move this forward... Thank you, -- Nikita Ivanov On Tue, Apr 14, 2020 at 1:55 AM Paul King wrote: > +1 (with some comments below): > > Tested: > - signature okay > -

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-14 Thread Paul King
+1 (with some comments below): Tested: - signature okay - checksums okay - LICENSE, DISCLAIMER okay - NOTICE has more than needed (lines 6-95 should be deleted for source zip, I don't believe a showstopper but fix for next time) - incubating in name - mvn clean package (okay on Windows and Linux

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-13 Thread Sergey Makov
+1 Tested on mac only: - mvn clean verify - ZIP signatures check Regards, Sergey On Sun, Apr 12, 2020 at 9:26 PM Nikita Ivanov wrote: > > +1 > > Tested (mac only): > - mvn clean package > - mvn verify > - mvn apache-rat:check -Prelease > - Rat check: Summary over all files. Unapproved: 0,

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-12 Thread Nikita Ivanov
+1 Tested (mac only): - mvn clean package - mvn verify - mvn apache-rat:check -Prelease - Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 318 licenses. - ZIP signatures check - DISCLAIMER, KEYS, LICENSE, NOTE files are present -- Nikita Ivanov. On Sat,

Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-12 Thread Sergey Kamov
Hi +1 (Files checked, tests and examples checked (under mac and win)) 11.04.2020 23:23, Aaron Radzinski пишет: NLPCraft-ers, We've made another round of fixes. Note that the internal version of this release is now 0.5.0-rc1. If and when voted in - we'll simply upgrade the version to 0.5.0.

[VOTE] Release Apache NLPCraft 0.5.0 (incubating)

2020-04-11 Thread Aaron Radzinski
NLPCraft-ers, We've made another round of fixes. Note that the internal version of this release is now 0.5.0-rc1. If and when voted in - we'll simply upgrade the version to 0.5.0. NOTE: the 'dist' location has double 'nlpcraft' folders which may look suspicious. First 'nlpcraft' is a root for the

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-11 Thread Aaron Radzinski
Since we got several -1 votes we are concluding this vote. I'll upload the next releases shortly that would address found issues. Thank you, -- Aaron Radzinski On Thu, Apr 9, 2020 at 2:17 PM Aaron Radzinski wrote: > NLPCraft-ers, > After several rounds of discussion and fixes I've prepared

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-11 Thread Nikita Ivanov
1. GPG issue is a warning. My key is also not counter-signed (we all should try to fix it: https://infra.apache.org/release-signing.html) 2. I fixed the JIRA by un-releasing 0.5.0. We'll release again when the build gets voted in. 3. Tag is removed and will be re-created (as v0.5.0-rc1 as we adopt

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-11 Thread Nikita Ivanov
+1 on Furkan suggestions. It should be 0.5.0-rc1 next cut. -- Nikita Ivanov On Sat, Apr 11, 2020 at 8:53 AM Furkan KAMACI wrote: > Hi Aaron, > > I don't wanna fork this vote thread but you can consider naming such > releases as release candidate and increment at each cycle as like here: >

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-11 Thread Sergey Kamov
Some additional remarks: 1) gpg --verify apache-nlpcraft-incubating-0.5.0.zip.asc apache-nlpcraft-incubating-0.5.0.zip gpg: Signature made Thu Apr  9 23:54:11 2020 MSK gpg:    using RSA key 223A2AADD175994F4450467491D161EDD8405C82 gpg: Good signature from "Aaron Radzinski "

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-11 Thread Furkan KAMACI
Hi Aaron, I don't wanna fork this vote thread but you can consider naming such releases as release candidate and increment at each cycle as like here: https://dist.apache.org/repos/dist/dev/incubator/druid/ Kind Regards, Furkan KAMACI On Sat, Apr 11, 2020 at 6:18 PM Sergey Kamov wrote: >

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-11 Thread Sergey Kamov
yes, apache-nlpcraft-incubating-0.5.0.zipcontent cannot be built under win 10, java8 (`mvn clean package` failed with 2 errors) -1 11.04.2020 18:02, Sergey Makov пишет: Most probably -1 Looks like our build is failing on Windows (at least on Jenkins with the latest master):

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-11 Thread Sergey Makov
Most probably -1 Looks like our build is failing on Windows (at least on Jenkins with the latest master): https://builds.apache.org/view/Incubator%20Projects/job/incubator-nlpcraft/1/console I don't have a Windows PC at hand, can someone double-check 0.5.0 on Windows please? Thanks, Sergey On

[VOTE] Release Apache NLPCraft 0.5.0

2020-04-09 Thread Aaron Radzinski
NLPCraft-ers, After several rounds of discussion and fixes I've prepared another cut for our first ASF release. Release version remains 0.5.0. All licensing issues were addressed. NOTE: the 'dist' location has double 'nlpcraft' folders which may look suspicious. First 'nlpcraft' is a root for the

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-03 Thread Dave Fisher
> On Mar 31, 2020, at 1:29 PM, Aaron Radzinski > wrote: > > NLPCraft-ers, > Our first ASF release is ready and up for the vote: > 1. ZIP tarball > > (SHA256 >

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-02 Thread Furkan KAMACI
Hi Aaron, Thanks for preparing the release! I have some comments for the first Apache release candidate. 1) You can create a mail structure to make easier for the people who want to review the release candidate. It is not something that every incubator projects does but you can follow this as a

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-04-02 Thread Nikita Ivanov
NLPCraft-ers, I believe we still need 2 more *binding* (i.e. PMC members) votes for the 0.5.0 release to be voted in (correct me if I'm wrong here for incubating releases). Thanks, -- Nikita Ivanov On Tue, Mar 31, 2020 at 2:06 PM Sergey Makov wrote: > +1 > > On Tue, Mar 31, 2020 at 11:58 PM

Re: [VOTE] Release Apache NLPCraft 0.5.0

2020-03-31 Thread Sergey Kamov
+1 31.03.2020 23:29, Aaron Radzinski пишет: NLPCraft-ers, Our first ASF release is ready and up for the vote: 1. ZIP tarball (SHA256