buildbot success in on ofbiz-trunk

The Buildbot has detected a restored build on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1438 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranchScheduler

buildbot failure in on ofbiz-trunk

The Buildbot has detected a new failure on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1437 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranchScheduler scheduler

Re: Groovy and semicolon at EOL

Personally I will go this way: I will add or changes lines without putting semicolons. I'm in favour of bulk changing files, but I'd prefer by component or webapp to ease reviews. Jacques Le 16/09/2016 à 15:36, Rishi Solanki a écrit : I was saying #2 as per the comment from Taher

Re: [VOTE] ASL2 header in README files?

I agree we should have a AL2 (and not ASL2 I learnt) header in README.md. For the rest it really depends on the content and we can't apply a global rule. Only "creative" ones should have a header. Of course "creative" is subjective, but I guess in most cases we will agree. Jacques Le

Re: svn commit: r1761076 - /ofbiz/trunk/build.gradle

Ah yes good idea, old Ant reflex, I will Jacques Le 16/09/2016 à 22:23, Taher Alkhateeb a écrit : Jacques .. I think it is bad practice to put commented out code. If this is really necessary we can put a task for it if needed. On Fri, Sep 16, 2016 at 11:15 PM, wrote:

Re: svn commit: r1761076 - /ofbiz/trunk/build.gradle

Jacques .. I think it is bad practice to put commented out code. If this is really necessary we can put a task for it if needed. On Fri, Sep 16, 2016 at 11:15 PM, wrote: > Author: jleroux > Date: Fri Sep 16 20:15:43 2016 > New Revision: 1761076 > > URL:

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

Thanks Taher for trying on Windows :) I think our last messages crossed on Wire. When you sent your message I had just identified the real issue (thanks to Jacopo on HipChat) and committed the fix. I should have spotted this issue on BuildBot in 1st place but I was convinced I did already

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

Hi Jacques, in reply: - The build does not compile on windows (until you made the correction) ! This is NOT related to the OS as I mentioned, but related to erroneous code. - You unnecessarily inserted a tab character next to the delegator. Please be careful, quality matters more than quantity.

buildbot success in on ofbiz-trunk

The Buildbot has detected a restored build on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1432 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

Sorry Taher, was my bad. I forgot I did not commit the change in EntityListIterator that I had pending for a week Done Jacques Le 16/09/2016 à 17:03, Jacques Le Roux a écrit : HEAD of course, see tools/test.bat BTW I checked I have jdk1.8.0_74 installed. 101 is the JRE I have also

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

HEAD of course, see tools/test.bat BTW I checked I have jdk1.8.0_74 installed. 101 is the JRE I have also installed by the Java auto update. So I thought it could be due to a JDK version (weird because try-with-ressources is not new) And BTW the xlint below is with my last commit reverted. I

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

And if you are interested here is with |-Xlint:unchecked and -Xlint:deprecation| C:\projectASF-Mars\ofbiz>gradlew build :compileJava C:\projectASF-Mars\ofbiz\framework\base\src\main\java\org\apache\ofbiz\base\test\GenericTestCaseBase.java:353: warning: [unchecked] Possible heap pollution from

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

What revision are you on? On Fri, Sep 16, 2016 at 5:51 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > And if you are interested here is with |-Xlint:unchecked and > -Xlint:deprecation| > > C:\projectASF-Mars\ofbiz>gradlew build > :compileJava >

Re: [VOTE] ASL2 header in README files?

You are wrong there. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Fri, Sep 16, 2016 at 12:57 PM, Michael Brohl wrote: > Pierre, > > it seems you are not

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

Sorry, I used locally tools/test.bat which is svn up && gradlew cleanAll eclipse loadDefault testIntegration And it works perfectly It also compiles w/o problems with "gradlew clean build": C:\projectASF-Mars\ofbiz>gradlew clean build :clean :compileJava Note: Some input files use unchecked

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

Jacques it seems you don't get it. The problem is not an OS problem. The problem is in your code, it's all wrong on many levels. And by the way, the system does not even compile (on windows and linux!) On Fri, Sep 16, 2016 at 5:21 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: >

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/account ing: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

Thanks Taher for support, Tests pass locally on Windows 7 with java version "1.8.0_101" -- 2016-09-16 15:07:08,916 |main

Re: Groovy and semicolon at EOL

I was saying #2 as per the comment from Taher Quick Reference: One reply from Taher ... in the same thread. == Okay, given the priorities and work we have at the moment, I suggest we keep semicolons and use it as the standard unless someone volunteers to make a full switch. WDYT?

Re: svn commit: r1761023 - in /ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting: finaccount/FinAccountServices.java payment/PaymentGatewayServices.java

Jacques are you even compiling (let alone testing) before committing? Do you know what you're doing here? On Fri, Sep 16, 2016 at 2:53 PM, wrote: > Author: jleroux > Date: Fri Sep 16 11:53:27 2016 > New Revision: 1761023 > > URL: http://svn.apache.org/viewvc?rev=1761023=rev

buildbot exception in on ofbiz-trunk

The Buildbot has detected a build exception on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1430 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranchScheduler

Re: [VOTE] ASL2 header in README files?

Well, for the README.md you can add the license using the HTML version in APACHE2_HEADER. For the rest of the README files you can use the standard header. On Fri, Sep 16, 2016 at 2:41 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 16/09/2016 à 12:31, Jacopo Cappellato a écrit :

Re: [VOTE] ASL2 header in README files?

Le 16/09/2016 à 12:31, Jacopo Cappellato a écrit : On Fri, Sep 16, 2016 at 12:24 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: I simply wonder how we, as a community, can decide on this subject if no vote can be done. Jacques Jacques, please do not be elusive... I am simply

Re: [VOTE] ASL2 header in README files?

I cancel this vote because it makes no sense to force to have an ASL2 headers in ALL readme files as I described them Jacques Le 16/09/2016 à 12:31, Jacopo Cappellato a écrit : On Fri, Sep 16, 2016 at 12:24 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: I simply wonder how we,

Re: [VOTE] ASL2 header in README files?

Pierre, it seems you are not sure about it, assuming from your question in legal-discuss here: https://lists.apache.org/thread.html/cdc08a88d47709738c4aa7595a3dc2446e7aa5450d4b6ffc8cc56b52@%3Clegal-discuss.apache.org%3E Regards, Michael Am 16.09.16 um 10:43 schrieb Pierre Smits: -1

Re: [VOTE] ASL2 header in README files?

On Fri, Sep 16, 2016 at 12:24 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > > I simply wonder how we, as a community, can decide on this subject if no > vote can be done. > > Jacques > Jacques, please do not be elusive... I am simply asking you if this vote is still valid or you

Re: [VOTE] ASL2 header in README files?

Some love to discuss (and digress), Jacques. Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Fri, Sep 16, 2016 at 12:24 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 16/09/2016 à

Re: [VOTE] ASL2 header in README files?

Le 16/09/2016 à 12:08, Jacopo Cappellato a écrit : On Fri, Sep 16, 2016 at 12:04 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Le 16/09/2016 à 11:22, Jacopo Cappellato a écrit : On Fri, Sep 16, 2016 at 10:41 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: So we can't

Re: [VOTE] ASL2 header in README files?

On Fri, Sep 16, 2016 at 12:04 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 16/09/2016 à 11:22, Jacopo Cappellato a écrit : > >> On Fri, Sep 16, 2016 at 10:41 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> So we can't decide as a community? Weird :-o >>> >>>

Re: [VOTE] ASL2 header in README files?

Le 16/09/2016 à 11:22, Jacopo Cappellato a écrit : On Fri, Sep 16, 2016 at 10:41 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: So we can't decide as a community? Weird :-o Jacques Jacques, are you saying that we are allowed, as a community, to decide to not include the license

Re: Groovy and semicolon at EOL

I guess you mean 2) by file, then it's OK with me. Though I'd no be against having semicolon inconsistency in Groovy files, which was my initial question. So no strong opinion about 2 here. Jacques Le 16/09/2016 à 11:31, Rishi Solanki a écrit : To summarize the overall conversation; 1) We

Re: [VOTE] ASL2 header in README files?

Le 16/09/2016 à 10:21, Jacopo Cappellato a écrit : On Fri, Sep 16, 2016 at 9:43 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Hi Devs, There are mixed opinions about putting or not the ASL2 header in OFBiz README files. One one hand we can read at http://www.apache.org/legal/sr

Re: Groovy and semicolon at EOL

To summarize the overall conversation; 1) We have decided to bulk remove semicolons from groovy. 2) Until #1 is not complete, we would keep adding semicolon for consistency. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847

Re: [VOTE] ASL2 header in README files?

+1 Le 16/09/2016 à 10:32, Jacopo Cappellato a écrit : Also, if I recall, it was initially decided to not include a license header to the main README.md file in the root folder: however now that the file represents an important part of the OFBiz documentation, I think we should revisit that

Re: [VOTE] ASL2 header in README files?

What license would you propose? Remember we are an Apache project, which of course does not mean we must use the ASL2 license, but simplifies potential users evaluation regarding the licensing aspect. Jacques Le 16/09/2016 à 10:43, Pierre Smits a écrit : -1 regarding the use of the ASL2

Re: Remove unused labels?

Le 16/09/2016 à 11:18, Taher Alkhateeb a écrit : Hi Jacques, Yeah I looked at your explanation, still doable, in fact, it seems to be a great thing to do in Groovy. A couple of hours in authoring a script could iterate through all the variations and clean them up, and that could be part of our

Re: [VOTE] ASL2 header in README files?

Hi Jacopo, yeah it's good to have that file. I meant specifically for "Markdown" because we had an issue of formatting. After a bit of research I realized that HTML comments in Markdown will be ignored in most Markdown readers including github's reader. In fact we should update that file to

Re: [VOTE] ASL2 header in README files?

On Fri, Sep 16, 2016 at 10:41 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > So we can't decide as a community? Weird :-o > > Jacques Jacques, are you saying that we are allowed, as a community, to decide to not include the license header to files containing some degree of

Re: Remove unused labels?

Hi Jacques, Yeah I looked at your explanation, still doable, in fact, it seems to be a great thing to do in Groovy. A couple of hours in authoring a script could iterate through all the variations and clean them up, and that could be part of our tools. We would really benefit from writing scripts

Re: [VOTE] ASL2 header in README files?

On Fri, Sep 16, 2016 at 10:38 AM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > I agree Jacopo. After a little bit of research I realized that we can add > the header license without affecting the format by using html comment > format > > Therefore I think it is wise to keep the license

Re: [VOTE] ASL2 header in README files?

-1 regarding the use of the ASL2 license for readme files. Because it is the wrong license for that kind of work. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Fri, Sep 16, 2016 at

Re: [VOTE] ASL2 header in README files?

So we can't decide as a community? Weird :-o Jacques Le 16/09/2016 à 10:21, Jacopo Cappellato a écrit : On Fri, Sep 16, 2016 at 9:43 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Hi Devs, There are mixed opinions about putting or not the ASL2 header in OFBiz README files. One

Re: [VOTE] ASL2 header in README files?

I agree Jacopo. After a little bit of research I realized that we can add the header license without affecting the format by using html comment format Therefore I think it is wise to keep the license header in all of our files On Sep 16, 2016 11:32 AM, "Jacopo Cappellato" <

Re: [VOTE] ASL2 header in README files?

Also, if I recall, it was initially decided to not include a license header to the main README.md file in the root folder: however now that the file represents an important part of the OFBiz documentation, I think we should revisit that decision and add a license header to it. Jacopo On Fri, Sep

Re: [VOTE] ASL2 header in README files?

On Fri, Sep 16, 2016 at 9:43 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Devs, > > There are mixed opinions about putting or not the ASL2 header in OFBiz > README files. > > One one hand we can read at http://www.apache.org/legal/sr > c-headers.html#faq-exceptions that README

Re: Guest Access Link for OFBiz HipChat Room

Pierre, I plan to put it in the "Resources & Tools" section What would you suggest as content text to explain the link? Thanks Jacques Le 02/09/2016 à 10:45, Pierre Smits a écrit : I suggest to put a link (button) on the home page of our site. Best regards, Pierre Smits ORRTIZ.COM

[VOTE] ASL2 header in README files?

Hi Devs, There are mixed opinions about putting or not the ASL2 header in OFBiz README files. One one hand we can read at http://www.apache.org/legal/src-headers.html#faq-exceptions that README files don't require a header But to protect our work we can decide to put a header in all README

Re: Removing the ecomclone webapp from the ecommerce component

+1 Michael > Am 16.09.2016 um 05:55 schrieb Jacopo Cappellato > : > > In the "ecommerce" component there are two web applications: > - ecommerce: the actual web application > - ecomclone: a clone of the above, that leverages the controller's > "include"

Re: Removing the ecomclone webapp from the ecommerce component

+1 Op vrijdag 16 september 2016 heeft Taher Alkhateeb < slidingfilame...@gmail.com> het volgende geschreven: > +1 > > On Sep 16, 2016 7:52 AM, "Jacques Le Roux" > > wrote: > > > Le 16/09/2016 à 05:55, Jacopo Cappellato a écrit : > > > >> In the