Re: Proposal: Mandatory JUnit tests for new functions

2014-10-07 Thread Jacques Le Roux
I agree Hans, it's good to know that Jacopo and Scott's had the same concern and have already taken action :) Jacques Le 07/10/2014 10:06, Hans Bakker a écrit : Hi Nicolas, thanks also you for the support for this proposal it started actually with the commit of Scott, which initially did

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-07 Thread Hans Bakker
Hi Nicolas, thanks also you for the support for this proposal it started actually with the commit of Scott, which initially did not have a test, that seems to be already resolved. I get really concerned when new especially framework functionality is added to the trunk without proper automa

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-07 Thread Nicolas Malin
For the issue OFBIZ-5699, it was already in my mind to complete unit test ;) In most case, add/improve/complete the unit test will be very beneficial for the quality project. But set it as mandatory, I fear that will be a contribution brake. +1 for encourage it ! I'm sure some contributor want

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-06 Thread Jacques Le Roux
Here is my vote inline Le 06/10/2014 03:49, Hans Bakker a écrit : Good morning, If you are following the relatively new developments in software development you will be aware of continuous integration or the next step: continuous deployment. This is all part of the 'continuous improvement' pri

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-06 Thread Taher Alkhateeb
I personally think all the testing we need is in JUnit, Selenium and JMeter for unit, integration and performance testing respectively. Unfortunately we are firing selenium after and above OFBiz using gradle scripts. Integration of Selenium into the framework is necessary in my opinion and not only

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-06 Thread Jacopo Cappellato
Let's keep thinking and talking about how to improve our toolset for unit tests (and ui tests).I would also add to the mix load and performance tests. It is important that we do not only select the tools we consider important but also how we use them in OFBiz. I have also some ideas floating in m

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
Jacopo, I stand corrected! yes indeed the wrong Issue. not 2699 but OFBIZ-4053, you are right. Thank you and Scott for supporting the idea, so we get the quality of OFBiz better. Left one open question to answer, how we are going to include user interface tests. Once we had selenium i

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Jacopo Cappellato
A few days ago Scott and I had already discussed about unit tests for the new query builder and they will come soon: the new API will not go into any release without unit tests. In fact I think that Scott told you that he is not going to work on OFBIZ-5699 because he is busy with the query build

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Scott Gray
Like I said in my earlier email, new unit tests only prevent future regression they don't serve as an indicator to the quality of the contribution they're submitted with. If I were to provide unit tests for the EntityQuery class it would tell you exactly zero about whether or not upgrading exis

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
So Scott, you introduce a new API named EntityQuery without a unit test, then you are going to replace the existing well working API with something which is not tested continuously i love the idea :-( and then everybody asking for reliability and quality. Regards, Hans On 06/10/14

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Jacopo Cappellato
a big +1 to put more "social" pressure on contributors to provide and implement unit tests; it will be a big win when we all new code will be committed with unit tests, so I agree that it is the way to go but I just want to be realistic and enforcing this rule may have a big impact on the projec

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Adrian Crum
Unit tests should be encouraged, but not required. I don't know what you mean by "When the OFBiz system was initially implemented this was already recognized that automated tests are required for a quality product." If you are referring to the OFBiz "product" then it is important to remember t

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Scott Gray
On 6/10/2014, at 3:24 pm, Hans Bakker wrote: > On 06/10/14 09:15, Scott Gray wrote: >> Hi Hans, >> .. >> Lastly, the majority of our tests are implemented in mini-lang and I'm >> really not a fan of it at all. If there were support for converting them to >> groovy (do we even support g

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
On 06/10/14 09:15, Scott Gray wrote: Hi Hans, .. Lastly, the majority of our tests are implemented in mini-lang and I'm really not a fan of it at all. If there were support for converting them to groovy (do we even support groovy tests?), I'd be glad to help lead that change. Try if g

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Scott Gray
Hi Hans, Two thoughts: 1. Are we sure we want to raise the barrier for any new potential major contributions? We don't receive so many as it is. Same thing with bug reports, would we ignore them if they don't have a test? Would we delay fixing the issue until someone feels like writing one?

Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
Good morning, If you are following the relatively new developments in software development you will be aware of continuous integration or the next step: continuous deployment. This is all part of the 'continuous improvement' principle. When the OFBiz system was initially implemented this was a