Re: Review Request 69916: OOZIE-3427 - Use best practices in HTTP response headers

2019-02-07 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69916/#review212639 --- Ship it! Ship It! - András Piros On Feb. 7, 2019, 3:48

Re: Review Request 69916: OOZIE-3427 - Use best practices in HTTP response headers

2019-02-07 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69916/#review212636 --- Changes look good to me. Waiting on Zsombor Gegesy's last review

Re: Review Request 69916: OOZIE-3427 - Use best practices in HTTP response headers

2019-02-07 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69916/#review212626 ---

Re: Review Request 69657: OOZIE-3407 - Cleanup TestPurgeXCommand

2019-01-10 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69657/#review211827 --- Ship it! Ship It! - András Piros On Jan. 10, 2019, 1:26

Re: Review Request 69657: OOZIE-3407 - Cleanup TestPurgeXCommand

2019-01-03 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69657/#review211648 --- The patch does a great job into the right direction. Only a few

Re: Review Request 69594: OOZIE-3400: Fix PurgeService sub-sub-workflow checking

2019-01-02 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69594/#review211601 --- Ship it! Ship It! - András Piros On Dec. 27, 2018, 3:13

Re: Review Request 69594: OOZIE-3400: Fix PurgeService sub-sub-workflow checking

2018-12-21 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69594/#review211500 --- core/src/main/java/org/apache/oozie/command/PurgeXCommand.java

Re: Review Request 69594: OOZIE-3400: Fix PurgeService sub-sub-workflow checking

2018-12-20 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69594/#review211473 --- Nice job so far. I really would rather extract functionality into

Re: Review Request 69330: OOZIE-3379 Auth token cache file name should include Oozie URL

2018-12-05 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69330/#review211036 --- Ship it! Ship It! - András Piros On Dec. 4, 2018, 5:29

Re: Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-12-01 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69492/ --- (Updated Dec. 1, 2018, 2:21 p.m.) Review request for oozie, Andras Salamon and

Re: Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-12-01 Thread András Piros via Review Board
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote: > > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java > > Line 121 (original), 120 (patched) > > > > > > Could you please add assert message.

Re: Review Request 69408: OOZIE-3382 - Optimize SshActionExecutor's drainBuffers method

2018-12-01 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69408/#review210997 --- Ship it! Ship It! - András Piros On Nov. 30, 2018, 4:04

Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-11-30 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69492/ --- Review request for oozie, Andras Salamon and Kinga Marton. Repository:

Re: Review Request 69469: OOZIE-3393: Add Oozie instrumentation delayed metric in CoordMaterializeTriggerService

2018-11-28 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69469/#review210927 --- Overall direction is OK. Please add some unit tests, and sample

Re: Review Request 69330: OOZIE-3379 Auth token cache file name should include Oozie URL

2018-11-28 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69330/#review210926 ---

Re: Review Request 69408: OOZIE-3382 - Optimize SshActionExecutor's drainBuffers method

2018-11-26 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69408/#review210855 --- Thanks for the works, it's a very neat improvement to SSH action.

Re: Review Request 69330: OOZIE-3379 Auth token cache file name should include Oozie URL

2018-11-20 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69330/#review210704 ---

Re: Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions

2018-11-20 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69348/ --- (Updated Nov. 20, 2018, 10:54 a.m.) Review request for oozie and Kinga Marton.

Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions

2018-11-15 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69348/ --- Review request for oozie and Kinga Marton. Repository: oozie-git Description

Re: Review Request 69252: OOZIE 3378 - Coordinator action's status is SUBMITTED after E1003 error

2018-11-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69252/#review210346 --- Ship it! Ship It! - András Piros On Nov. 6, 2018, 9 a.m.,

Re: Review Request 69252: OOZIE 3378 - Coordinator action's status is SUBMITTED after E1003 error

2018-11-05 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69252/#review210330 ---

Review Request 69251: OOZIE-3377 [docs] Remaining 5.1.0 documentation changes

2018-11-05 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69251/ --- Review request for oozie, Peter Cseh and Peter Bacsko. Repository: oozie-git

Review Request 69250: OOZIE-3376 [tests] TestGraphGenerator should assume JDK8 minor version at least 1.8.0_u40

2018-11-05 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69250/ --- Review request for oozie, Peter Cseh and Peter Bacsko. Repository: oozie-git

Review Request 68909: amend OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

2018-10-03 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68909/ --- Review request for oozie and Peter Bacsko. Repository: oozie-git Description

Review Request 68837: OOZIE-3340 [fluent-job] Create error handler ACTION only if needed

2018-09-25 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68837/ --- Review request for oozie, Kinga Marton and Peter Bacsko. Repository: oozie-git

Re: Review Request 68737: OOZIE-3307 [core][oya] Limit heap usage of LauncherAM

2018-09-24 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68737/ --- (Updated Sept. 24, 2018, 3:17 p.m.) Review request for oozie and Peter Bacsko.

Re: Review Request 68737: OOZIE-3307 [core][oya] Limit heap usage of LauncherAM

2018-09-24 Thread András Piros via Review Board
> On Sept. 20, 2018, 3:05 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 2063 (patched) > > > > > > General thoughts, as we discussed: > > > >

Re: Review Request 68783: OOZIE-3342: Missing examples archive from fluentjob examples

2018-09-21 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68783/#review208839 --- Ship it! Ship It! - András Piros On Sept. 20, 2018, 1:53

Re: Review Request 68737: OOZIE-3307 [core][oya] Limit heap usage of LauncherAM

2018-09-20 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68737/ --- (Updated Sept. 20, 2018, 2:27 p.m.) Review request for oozie and Peter Bacsko.

Re: Review Request 68140: OOZIE-3229 Improved filtering options in V2SLAServlet

2018-09-20 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68140/#review208795 --- Ship it! Ship It! - András Piros On Sept. 19, 2018, 4:07

Re: Review Request 68737: OOZIE-3307 [core][oya] Limit heap usage of LauncherAM

2018-09-19 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68737/ --- (Updated Sept. 19, 2018, 10:38 a.m.) Review request for oozie and Peter

Re: Review Request 68737: OOZIE-3307 [core][oya] Limit heap usage of LauncherAM

2018-09-18 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68737/ --- (Updated Sept. 18, 2018, 1:06 p.m.) Review request for oozie and Peter Bacsko.

Re: Review Request 68140: OOZIE-3229 Improved filtering options in V2SLAServlet

2018-09-18 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68140/#review208701 --- Great work thus far! Only a couple of thingies left.

Re: Review Request 68737: OOZIE-3307 [core][oya] Limit heap usage of LauncherAM

2018-09-18 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68737/ --- (Updated Sept. 18, 2018, 8:20 a.m.) Review request for oozie and Peter Bacsko.

Review Request 68737: OOZIE-3307 [core][oya] Limit heap usage of LauncherAM

2018-09-17 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68737/ --- Review request for oozie and Peter Bacsko. Repository: oozie-git Description

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-14 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208626 --- Ship it! Ship It! - András Piros On Sept. 13, 2018, 12:34

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-12 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208555 --- docs/src/site/markdown/ENG_Building.md Lines 154 (patched)

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-11 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208510 --- docs/src/site/twiki/DG_CommandLineTool.twiki Lines 461-469

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-09-10 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Sept. 10, 2018, 3:37 p.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-10 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208479 --- Reviewed following HTML / Markdown files: *

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-09-07 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Sept. 7, 2018, 8:08 a.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-09-07 Thread András Piros via Review Board
> On Sept. 6, 2018, 9:42 p.m., Peter Bacsko wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > > Lines 377 (patched) > > > > > > What's the reason for the list? Couldn't it be

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-09-07 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/#review208444 ---

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-09-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Sept. 6, 2018, 3:59 p.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-05 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208345 --- Checked generated artifacts: * `AG_ActionConfiguration.html` *

Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

2018-09-04 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67885/#review208313 --- Ship it! Ship It! - András Piros On Sept. 4, 2018, 3:45

Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

2018-09-04 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67885/#review208310 ---

Re: Review Request 68505: OOZIE-2877 Git action

2018-09-04 Thread András Piros via Review Board
> On Aug. 31, 2018, 10:03 a.m., Andras Salamon wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java > > Line 134 (original), 134 (patched) > > > > > > Shouldn't we register this

Re: Review Request 68140: OOZIE-3229 Improved filtering options in V2SLAServlet

2018-09-04 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68140/#review208294 --- core/src/main/java/org/apache/oozie/FilterParser.java Lines 49

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-09-03 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Sept. 3, 2018, 9:10 a.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-09-03 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Sept. 3, 2018, 7:59 a.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-31 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Aug. 31, 2018, 10:50 a.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-31 Thread András Piros via Review Board
> On Aug. 30, 2018, 1:34 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > > Lines 575 (patched) > > > > > > Can't we just compare the IDs as strings?

Re: Review Request 68505: OOZIE-2877 Git action

2018-08-31 Thread András Piros via Review Board
> On Aug. 31, 2018, 10:03 a.m., Andras Salamon wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java > > Line 175 (original), 175 (patched) > > > > > > Shouldn't we register this

Re: Review Request 68505: OOZIE-2877 Git action

2018-08-31 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68505/ --- (Updated Aug. 31, 2018, 9:50 a.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68505: OOZIE-2877 Git action

2018-08-30 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68505/ --- (Updated Aug. 30, 2018, 6:42 p.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68517: OOZIE 3210 - revision information is empty

2018-08-29 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68517/#review208093 --- Ship it! Ship It! - András Piros On Aug. 27, 2018, 2:45

Review Request 68505: OOZIE-2877 Git action

2018-08-24 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68505/ --- Review request for oozie, Andras Salamon, Clay B., Peter Cseh, Kinga Marton,

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

2018-08-24 Thread András Piros via Review Board
> On May 30, 2017, 11:08 a.m., András Piros wrote: > > sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestIntegrationGitActionExecutor.java > > Lines 60 (patched) > > > > > > Are system props reset after

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

2018-08-24 Thread András Piros via Review Board
> On April 30, 2018, 3:12 p.m., Peter Cseh wrote: > > client/src/main/resources/git-action-0.1.xsd > > Lines 32 (patched) > > > > > > I don't know if it's possible to define uris outside > >

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

2018-08-24 Thread András Piros via Review Board
> On Aug. 7, 2018, 12:38 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java > > Lines 182-183 (patched) > > > > > > These nested ifs can be merged. Done. > On

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

2018-08-24 Thread András Piros via Review Board
> On June 5, 2018, 4:46 p.m., Robert Kanter wrote: > > sharelib/git/src/main/java/org/apache/oozie/action/hadoop/GitMain.java > > Lines 216 (patched) > > > > > > Is this necessary? Why not simply throw whatever

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

2018-08-24 Thread András Piros via Review Board
> On Aug. 8, 2018, 9:57 a.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java > > Lines 152 (patched) > > > > > > Better naming suggested: ActionConfVerifier Done.

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

2018-08-24 Thread András Piros via Review Board
> On July 2, 2018, 12:46 p.m., Peter Bacsko wrote: > > docs/src/site/twiki/WorkflowFunctionalSpec.twiki > > Lines 1667-1669 (patched) > > > > > > Do we really need to access a different cluster other than the one

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-24 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Aug. 24, 2018, 2:18 p.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68140: OOZIE-3229 Improved filtering options in V2SLAServlet

2018-08-24 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68140/#review207874 ---

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-24 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Aug. 24, 2018, 12:17 p.m.) Review request for oozie, Andras Salamon,

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-24 Thread András Piros via Review Board
> On Aug. 24, 2018, 8:02 a.m., Andras Salamon wrote: > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > > Lines 1389 (patched) > > > > > > extra space indentation

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-23 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Aug. 23, 2018, 6:35 p.m.) Review request for oozie, Attila Sasvari

Re: Review Request 68482: OOZIE 3331 - SparkOptionsSplitter inconsistency

2018-08-23 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68482/#review207813 --- Ship it! Ship It! - András Piros On Aug. 23, 2018, 7:04

Re: Review Request 68411: OOZIE-3264 - Flaky test TestCoordMaterializeTransitionXCommand#testLastOnlyMaterialization

2018-08-22 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68411/#review207745 ---

Re: Review Request 68467: OOZIE-2684 Bad database schema error for WF_ACTIONS table

2018-08-22 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68467/#review207741 ---

Re: Review Request 68438: OOZIE 3330 - [spark-action] Remove double quotes inside plain option values

2018-08-21 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68438/#review207658 --- Ship it! Ship It! - András Piros On Aug. 21, 2018, 10:18

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-13 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Aug. 13, 2018, 3:39 p.m.) Review request for oozie, Attila Sasvari

Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

2018-08-10 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67885/#review207076 ---

Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-10 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- (Updated Aug. 10, 2018, 10:52 a.m.) Review request for oozie, Attila Sasvari

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-08-09 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67999/#review207018 --- Ship it! Ship It! - András Piros On Aug. 9, 2018, 8:11

Re: Review Request 68255: OOZIE 3314 - Remove findbugs-filter.xml and convert its contents to annotations

2018-08-08 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68255/#review206973 --- Ship it! Ship It! - András Piros On Aug. 8, 2018, 9:15

Re: Review Request 68255: OOZIE 3314 - Remove findbugs-filter.xml and convert its contents to annotations

2018-08-07 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68255/#review206941 --- core/src/main/java/org/apache/oozie/command/XCommand.java Lines

Review Request 68237: OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-08-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68237/ --- Review request for oozie, Attila Sasvari and Peter Bacsko. Repository:

Re: Review Request 68180: OOZIE-3315 Datelist Java Main example fails

2018-08-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68180/#review206881 --- Ship it! Ship It! - András Piros On Aug. 6, 2018, 12:21

Re: Review Request 68140: OOZIE-3229 Improved filtering options in V2SLAServlet

2018-08-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68140/#review206880 --- client/src/main/java/org/apache/oozie/client/OozieClient.java

Re: Review Request 68180: OOZIE-3315 Datelist Java Main example fails

2018-08-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68180/#review206878 --- examples/src/main/java/org/apache/oozie/example/DateList.java

Re: Review Request 68180: OOZIE-3315 Datelist Java Main example fails

2018-08-03 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68180/#review206836 --- examples/pom.xml Lines 108-112 (patched)

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-08-01 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/#review206741 --- Ship it! Ship It! - András Piros On Aug. 1, 2018, 1:44

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-08-01 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/#review206739 ---

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-08-01 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/#review206740 --- Ship it! Ship It! - András Piros On Aug. 1, 2018, 9:59

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-07-31 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67999/#review206660 ---

Re: Review Request 68008: OOZIE-2942 [examples] Fix Findbugs warnings

2018-07-31 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68008/#review206650 --- Ship it! Ship It! - András Piros On July 22, 2018, 1:16

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-30 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/#review206596 ---

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-07-30 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/#review206592 ---

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-19 Thread András Piros via Review Board
> On July 6, 2018, 1:40 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 88 (patched) > > > > > > Problem is we can have ```hdfs://my/jar.jar#myjar.jar```

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/#review205796 --- docs/src/site/twiki/AG_Install.twiki Lines 60 (patched)

Re: Review Request 66656: Exclusion pattern for sharelib.

2018-07-03 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66656/#review205669 ---

Re: Review Request 66656: Exclusion pattern for sharelib.

2018-07-03 Thread András Piros via Review Board
> On June 20, 2018, 10:56 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutorLibAddition.java > > Lines 433-441 (patched) > > > > > > Extract method

Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-07-02 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67766/#review205634 --- Ship it! Ship It! - András Piros On July 2, 2018, 8:06

Re: Review Request 67784: Escape log-streaming's HTML-specific characters

2018-07-02 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67784/#review205629 --- Ship it! Ship It! - András Piros On June 29, 2018, 12:28

Re: Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-07-02 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67763/#review205625 --- Ship it! Ship It! - András Piros On July 1, 2018, 10:47

Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-06-28 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67766/#review205500 ---

Re: Review Request 66656: Exclusion pattern for sharelib.

2018-06-20 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66656/#review205055 ---

  1   2   3   >