Re: [VOTE] release Apache OpenJPA-4.0.0

[Francesco Chicchiriccò]

On 06/02/24 08:46, Maxim Solodovnik wrote:

On Tue, 6 Feb 2024 at 14:03, Francesco Chicchiriccò  wrote:

On 06/02/24 04:07, Maxim Solodovnik wrote:

Hello Francesco,

On Mon, 5 Feb 2024 at 19:16, Francesco Chicchiriccò  wrote:

Hi Maxim, if I follow [1] for Linux, I am doing

sha1sum apache-openjpa-4.0.0-source.zip

and then compare the value obtained with the content of

Hashes definitely passes "comparing by eye"
but :)) `sha1sum --check` able to check properly formatted hashes
automatically :)
AFAIK this is known behavior of hashes generated by java/maven


sha1sum apache-openjpa-4.0.0-source.zip

I confirm that those are matching.

Side note: MD5 and SHA-1 are deprecated, we should move to SHA-256 or SHA-512 
anytime soon.

I would agree :)


About build errors, I confirm that local build works fine for me, and so did 
last commit available on GitHub [2].

I cannot see in git, however, the tag from which the 4.0.0 artifacts were 
built, nor the commits for version advance: Mark, can you push your local 
commits and tag?

I have downloaded "source" artifact from here:
https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/org/apache/openjpa/apache-openjpa/4.0.0/

check, unzip and build it :)

Yup, just did the same and it worked flawlessly.

FYI built with

Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /opt/apache-maven-3.9.5
Java version: 11.0.21, vendor: Azul Systems, Inc., runtime: 
/usr/lib/jvm/zulu11-ca-amd64
Default locale: it_IT, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-15-generic", arch: "amd64", family: "unix"

My bad
I was using Java17 :((

Everything works as expected with Java 11!
Sorry for the noise

I'm changing my VOTE to be +1 :))


Good news :-)

I'd count the compatibility with JDK 17 as an additional TODO, however.

Regards.


[1] https://www.apache.org/info/verification.html#CheckingHashes
[2] 
https://github.com/apache/openjpa/commit/65eab774b3d41f978174a8777018e0f1c105d996

On 05/02/24 05:44, Maxim Solodovnik wrote:

Hello All,

My VOTE is +0.5

Apache OpenMeeting works as expected with pre-build version


Here are the problems I got:

Signatures check (with standard Linux utilities) failed:
   md5sum --check apache-openjpa-4.0.0-source.zip.md5
md5sum: apache-openjpa-4.0.0-source.zip.md5: no properly formatted MD5
checksum lines found

   sha1sum --check apache-openjpa-4.0.0-source.zip.sha1
sha1sum: apache-openjpa-4.0.0-source.zip.sha1: no properly formatted
SHA1 checksum lines found


build from sources failed:

[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running 
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
elapsed: 1.122 s <<< FAILURE! - in
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest
[ERROR] 
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest.addresses
Time elapsed: 1.095 s  <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at 
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest.addresses(KubernetesTCPRemoteCommitProviderTest.java:165)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.jmock.integration.junit4.JUnitRuleMockery$1.evaluate(JUnitRuleMockery.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.P

Re: [VOTE] release Apache OpenJPA-4.0.0

[Francesco Chicchiriccò]

On 06/02/24 04:07, Maxim Solodovnik wrote:

Hello Francesco,

On Mon, 5 Feb 2024 at 19:16, Francesco Chicchiriccò  wrote:

Hi Maxim, if I follow [1] for Linux, I am doing

sha1sum apache-openjpa-4.0.0-source.zip

and then compare the value obtained with the content of

Hashes definitely passes "comparing by eye"
but :)) `sha1sum --check` able to check properly formatted hashes
automatically :)
AFAIK this is known behavior of hashes generated by java/maven


sha1sum apache-openjpa-4.0.0-source.zip

I confirm that those are matching.

Side note: MD5 and SHA-1 are deprecated, we should move to SHA-256 or SHA-512 
anytime soon.

I would agree :)


About build errors, I confirm that local build works fine for me, and so did 
last commit available on GitHub [2].

I cannot see in git, however, the tag from which the 4.0.0 artifacts were 
built, nor the commits for version advance: Mark, can you push your local 
commits and tag?

I have downloaded "source" artifact from here:
https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/org/apache/openjpa/apache-openjpa/4.0.0/

check, unzip and build it :)


Yup, just did the same and it worked flawlessly.

FYI built with

Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /opt/apache-maven-3.9.5
Java version: 11.0.21, vendor: Azul Systems, Inc., runtime: 
/usr/lib/jvm/zulu11-ca-amd64
Default locale: it_IT, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-15-generic", arch: "amd64", family: "unix"

Regards.


[1] https://www.apache.org/info/verification.html#CheckingHashes
[2] 
https://github.com/apache/openjpa/commit/65eab774b3d41f978174a8777018e0f1c105d996

On 05/02/24 05:44, Maxim Solodovnik wrote:

Hello All,

My VOTE is +0.5

Apache OpenMeeting works as expected with pre-build version


Here are the problems I got:

Signatures check (with standard Linux utilities) failed:
  md5sum --check apache-openjpa-4.0.0-source.zip.md5
md5sum: apache-openjpa-4.0.0-source.zip.md5: no properly formatted MD5
checksum lines found

  sha1sum --check apache-openjpa-4.0.0-source.zip.sha1
sha1sum: apache-openjpa-4.0.0-source.zip.sha1: no properly formatted
SHA1 checksum lines found


build from sources failed:

[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running 
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
elapsed: 1.122 s <<< FAILURE! - in
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest
[ERROR] 
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest.addresses
   Time elapsed: 1.095 s  <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at 
org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest.addresses(KubernetesTCPRemoteCommitProviderTest.java:165)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.jmock.integration.junit4.JUnitRuleMockery$1.evaluate(JUnitRuleMockery.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.

Re: [VOTE] release Apache OpenJPA-4.0.0

[Francesco Chicchiriccò]

res: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] 
[INFO] Reactor Summary for OpenJPA Parent POM 4.0.0:
[INFO]
[INFO] OpenJPA Parent POM . SUCCESS [  2.014 s]
[INFO] OpenJPA Utilities Library .. SUCCESS [  5.607 s]
[INFO] OpenJPA Kernel . SUCCESS [  4.281 s]
[INFO] OpenJPA JDBC ... SUCCESS [  3.378 s]
[INFO] OpenJPA Persistence  SUCCESS [  1.994 s]
[INFO] OpenJPA Persistence JDBC ... SUCCESS [10:02 min]
[INFO] OpenJPA Persistence Locking Tests .. SUCCESS [23:31 min]
[INFO] OpenJPA tools .. SUCCESS [  0.028 s]
[INFO] OpenJPA Maven Plugin ... SUCCESS [ 34.834 s]
[INFO] OpenJPA XML Store .. SUCCESS [  1.679 s]
[INFO] OpenJPA Slice .. SUCCESS [  0.614 s]
[INFO] OpenJPA JEST ... SUCCESS [  3.228 s]
[INFO] OpenJPA Kubernetes . FAILURE [  2.101 s]
[INFO] OpenJPA Aggregate Jar .. SKIPPED
[INFO] OpenJPA Aggregate Jar with Dependencies  SKIPPED
[INFO] OpenJPA Project Docs and Assemblies  SKIPPED
[INFO] OpenJPA Examples ... SKIPPED
[INFO] OpenJPA Examples - Simple .. SKIPPED
[INFO] OpenJPA Examples - image-gallery ... SKIPPED
[INFO] OpenJPA Examples - OpenBooks ... SKIPPED
[INFO] OpenJPA Integration Tests .. SKIPPED
[INFO] OpenJPA Integration Tests - Daytrader .. SKIPPED
[INFO] OpenJPA Integration Tests - Examples ... SKIPPED
[INFO] OpenJPA Integration Tests - SLF4JLogFactory  SKIPPED
[INFO] OpenJPA Integration Tests - JPA TCK  SKIPPED
[INFO] OpenJPA Integration Tests - Bean Validation  SKIPPED
[INFO] OpenJPA Integration Tests - JMX Platform MBeans  SKIPPED
[INFO] OpenJPA Fetching Statistic Tool  SKIPPED
[INFO] OpenJPA Fetching Statistic Tool -- WAS Bundle .. SKIPPED
[INFO] OpenJPA Features ... SKIPPED
[INFO] OpenJPA JUnit 5  SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  34:33 min

On Sat, 3 Feb 2024 at 14:23, Romain Manni-Bucau  wrote:

+1

Le sam. 3 févr. 2024 à 07:06, Francesco Chicchiriccò 
a écrit :


On 02/02/24 17:58, Mark Struberg wrote:

Good afternoon!

I'd like to call a VOTE on releasing Apache OpenJPA-4.0.0
This is a release targetting the JPA-3.0 spec. Note that we do not yet

pass all the TCK tests, so we will not claim full compat albeit we are
working on it.

The staging repo is


https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/


The source distribution can be found at


https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/org/apache/openjpa/apache-openjpa/4.0.0/

sha1 is 3ca5e4e0c8c7721a208f4889ac7728d8ad4861b5

Please VOTE:

[+1] ship it!
[+0] don't care
[-1] there is a ${showstopper}

The VOTE is open for 72h.

+1 Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/






--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [VOTE] release Apache OpenJPA-4.0.0

[Francesco Chicchiriccò]

On 02/02/24 17:58, Mark Struberg wrote:

Good afternoon!

I'd like to call a VOTE on releasing Apache OpenJPA-4.0.0
This is a release targetting the JPA-3.0 spec. Note that we do not yet pass all 
the TCK tests, so we will not claim full compat albeit we are working on it.

The staging repo is
https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/


The source distribution can be found at
https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/org/apache/openjpa/apache-openjpa/4.0.0/

sha1 is 3ca5e4e0c8c7721a208f4889ac7728d8ad4861b5

Please VOTE:

[+1] ship it!
[+0] don't care
[-1] there is a ${showstopper}

The VOTE is open for 72h.


+1 Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: gonna roll a 4.0.0 release

[Francesco Chicchiriccò]

On 02/02/24 10:50, Mark Struberg wrote:

Enough talking - will kick off the 4.0.0 release train now to get us moving.


Great news, thank you Mark.

Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Multi-tenancy and caching issues

[Francesco Chicchiriccò]

FYI, I've adopted a similar solution: still a few things to iron, but globally 
it works.

Thank you.
Regards.

On 09/01/24 11:58, Romain Manni-Bucau wrote:

Don't have everything ready for spring-data but had something like that in
mind:


public class RoutedEMFConf {
 @Bean
 @Primary
 LocalContainerEntityManagerFactoryBean
mainEntityManagerFactory(final Tenant tenant, final ApplicationContext
context) {
 final var emfs = findDelegates(context); // can be other beans
with qualifiers
 final var routedEmf =
EntityManagerFactory.class.cast(Proxy.newProxyInstance(
 RoutedEMFConf.class.getClassLoader(),
 // opt: use SessionFactoryImplementor.class if you
need hibernate internals
 new Class[]{EntityManagerFactory.class, Marking.class},
 (proxy, method, args) -> {
 switch (method.getName()) {
 case "equals":
 return args[0] instanceof Marking; //
assume there is a single one per app, otherwise complete the impl
 case "hashCode":
 return 1;
 default:
 try {
 final var id = tenant.get();
 return
method.invoke(requireNonNull(emfs.get(id), () -> "No emf for '" + id +
"'"), args);
 } catch (final InvocationTargetException ite) {
 throw ite.getTargetException();
 }
 }
 }
 ));
 return new LocalContainerEntityManagerFactoryBean() {
 @Override
 protected EntityManagerFactory
createNativeEntityManagerFactory() throws PersistenceException {
 return routedEmf;
 }
 };
 }

 private Map findDelegates(final
ListableBeanFactory lbf) {
 return Stream.of(lbf.getBeanNamesForType(EntityManagerFactory.class))
 .filter(it -> !"mainEntityManagerFactory".equals(it))
 .collect(toMap(identity(), k -> lbf.getBean(k,
EntityManagerFactory.class)));
 }

 public interface Marking {}

 // modelize the tenant lookup but can be a class, interface is not
always needed
 public interface Tenant extends Supplier {
 }
}

Side note: the delegate must have a valid name (likely make it a spring
extension registering beans from your conf or "properties" models).
The missing part is mainly the Tenant impl but guess you already have
something for that ;) - I assume some security context and meta for login.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 9 janv. 2024 à 11:28, Francesco Chicchiriccò 
a écrit :


Thank Romain, I share your considerations and concerns below, and also
agree that EMF routing is the way to go.

I probably need to tune my current exploration to let evolve what we
currently have in Syncope towards proper EMF routing.

Do you have any sample I could follow about that?

Regards.

On 09/01/24 10:51, Romain Manni-Bucau wrote:

Hi Francesco,

While you have an EMF router you don't have pitfall 4, it only happens if
your routing is done at datasource level but it also means you have way
more side effects and you start to loose the hability to tune per tenant

(a

common pattern is to tune the cache per tenant "size"/usage, there all
would be shared, not isolated so no real way to handle anything there).

Note: having routed caches can make it work somehow but will need a lot

of

reimplementation of the cache whereas it is free when using a routed emf.
It can be faked with PartitionedDataCache overriding the key name
(appending the tenant) but in terms of supervision I fear it will be way
harder and I'm not sure it would be very consummable for people (you end

up

making the leak risk higher for users by design and you don't get any
benefit from that - you don't reduce the overhead, you don't reduce the
pool size etc which are at another level).

In terms of spring-data integration there is also no link, just @Bean EMF
routedEmf() and you'll get it working transparently while a tx - cache
scope of spring - is for a single tenant.

Hope I'm not missing something "key" ;).

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <

https://github.com/rmannibucau> |

LinkedIn <https://www.li

Re: Multi-tenancy and caching issues

[Francesco Chicchiriccò]

Thank Romain, I share your considerations and concerns below, and also agree 
that EMF routing is the way to go.

I probably need to tune my current exploration to let evolve what we currently 
have in Syncope towards proper EMF routing.

Do you have any sample I could follow about that?

Regards.

On 09/01/24 10:51, Romain Manni-Bucau wrote:

Hi Francesco,

While you have an EMF router you don't have pitfall 4, it only happens if
your routing is done at datasource level but it also means you have way
more side effects and you start to loose the hability to tune per tenant (a
common pattern is to tune the cache per tenant "size"/usage, there all
would be shared, not isolated so no real way to handle anything there).

Note: having routed caches can make it work somehow but will need a lot of
reimplementation of the cache whereas it is free when using a routed emf.
It can be faked with PartitionedDataCache overriding the key name
(appending the tenant) but in terms of supervision I fear it will be way
harder and I'm not sure it would be very consummable for people (you end up
making the leak risk higher for users by design and you don't get any
benefit from that - you don't reduce the overhead, you don't reduce the
pool size etc which are at another level).

In terms of spring-data integration there is also no link, just @Bean EMF
routedEmf() and you'll get it working transparently while a tx - cache
scope of spring - is for a single tenant.

Hope I'm not missing something "key" ;).

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 9 janv. 2024 à 10:32, Francesco Chicchiriccò 
a écrit :


Hi Romain,
see my replies embedded below.

Regards.

On 08/01/24 17:43, Romain Manni-Bucau wrote:

Hi Francesco,

Normally if you have one EMF per tenant there is no leak between them

since the cache instance is stored in the EMF - used that approach in TomEE.

As I am saying below, this is what we have already in Syncope.

My company is also supporting customers heavily using this particular
feature: it works, I have no issues with that.
Someone is also building a SaaS solution on top of that, so runtime tenant
addition and removal is also fine.

I am exploring this different approach because it would allow to introduce
Spring Data JPA, which could have some benefits - see
https://issues.apache.org/jira/browse/SYNCOPE-1799


You can check it in

org.apache.openjpa.datacache.DataCacheManagerImpl#initialize of each emf
which should be different.

Thanks for the pointer.


So overall if there is a leak it is likely that it leaks accross

transactions or some spring cache level.

I think that things are more subtle: consider the following use case.

We have MyEntity with String @Id.

Suppose we have two tenants: A and B.

1. Tenant A will make a REST call which creates a MyEntity instance with
key "key1" under the db for A.

2. Tenant A will make another REST call which looks for the newly created
MyEntity instance via:

entityManager.find(MyEntity.class, "key1");

3. Tenant B makes the same call as (1) with the same key "key1": all is
fine, a new row is created under the db for B.

4. Tenant B makes the same call as (2) with the same key "key1": if not
already evicted, entityManager will return the MyEntity instance for Tenant
A from the cache.

I need to avoid the pitfalls from (4).


Side note: the datasource routing pattern is useless if you have an

entity manager routing pattern and only use JPA to do database work, both
will more easily conflict than help.

The idea is not to have an entity manager routing pattern, rather to have
a cache routing patter on the single entity manager factory; or just to
configure some predefined partitions.


If you still want to plug the datacase (query cache) configuration in

the jpa properties can take a custom fully qualified name too.

Le lun. 8 janv. 2024 à 17:14, Francesco Chicchiriccò <

ilgro...@apache.org>

a écrit :


Hi there,
at Syncope we have been implementing multi-tenancy by relying on

something

like:

* 1 data source per tenant
* 1 entity manager factory per tenant
* 1 transaction manager per tenant
* etc

So far so good.

Now I am experimenting a different approach similar to [1], e.g.

* 1 low-level data source per tenant
* 1 data source extending Spring's AbstractRoutingDataSource using the
value of a ThreadLocal variable as lookup key
* 1 single entity manager factory configured with the routing data

source

* 1 single transaction manager
* etc

It mostly works but I am having caching issues with concurrent

operations

working on different tenants, so I was wonderin

Re: Multi-tenancy and caching issues

[Francesco Chicchiriccò]

Hi Romain,
see my replies embedded below.

Regards.

On 08/01/24 17:43, Romain Manni-Bucau wrote:

Hi Francesco,

Normally if you have one EMF per tenant there is no leak between them since the 
cache instance is stored in the EMF - used that approach in TomEE.


As I am saying below, this is what we have already in Syncope.

My company is also supporting customers heavily using this particular feature: 
it works, I have no issues with that.
Someone is also building a SaaS solution on top of that, so runtime tenant 
addition and removal is also fine.

I am exploring this different approach because it would allow to introduce 
Spring Data JPA, which could have some benefits - see
https://issues.apache.org/jira/browse/SYNCOPE-1799


You can check it in 
org.apache.openjpa.datacache.DataCacheManagerImpl#initialize of each emf which 
should be different.


Thanks for the pointer.


So overall if there is a leak it is likely that it leaks accross transactions 
or some spring cache level.


I think that things are more subtle: consider the following use case.

We have MyEntity with String @Id.

Suppose we have two tenants: A and B.

1. Tenant A will make a REST call which creates a MyEntity instance with key 
"key1" under the db for A.

2. Tenant A will make another REST call which looks for the newly created 
MyEntity instance via:

entityManager.find(MyEntity.class, "key1");

3. Tenant B makes the same call as (1) with the same key "key1": all is fine, a 
new row is created under the db for B.

4. Tenant B makes the same call as (2) with the same key "key1": if not already 
evicted, entityManager will return the MyEntity instance for Tenant A from the cache.

I need to avoid the pitfalls from (4).


Side note: the datasource routing pattern is useless if you have an entity 
manager routing pattern and only use JPA to do database work, both will more 
easily conflict than help.


The idea is not to have an entity manager routing pattern, rather to have a 
cache routing patter on the single entity manager factory; or just to configure 
some predefined partitions.


If you still want to plug the datacase (query cache) configuration in the jpa 
properties can take a custom fully qualified name too.

Le lun. 8 janv. 2024 à 17:14, Francesco Chicchiriccò 
a écrit :


Hi there,
at Syncope we have been implementing multi-tenancy by relying on something
like:

* 1 data source per tenant
* 1 entity manager factory per tenant
* 1 transaction manager per tenant
* etc

So far so good.

Now I am experimenting a different approach similar to [1], e.g.

* 1 low-level data source per tenant
* 1 data source extending Spring's AbstractRoutingDataSource using the
value of a ThreadLocal variable as lookup key
* 1 single entity manager factory configured with the routing data source
* 1 single transaction manager
* etc

It mostly works but I am having caching issues with concurrent operations
working on different tenants, so I was wondering: how can I extend the
various OpenJPA (query, data, L1, L2, every one) caches to hold back
different actual instances per tenant and to use the appropriate one
depending on the same ThreadLocal value I have already used above for data
sources?

Thanks in advance.
Regards.

[1] https://github.com/Cepr0/sb-multitenant-db-demo


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Multi-tenancy and caching issues

[Francesco Chicchiriccò]

Hi there,
at Syncope we have been implementing multi-tenancy by relying on something like:

* 1 data source per tenant
* 1 entity manager factory per tenant
* 1 transaction manager per tenant
* etc

So far so good.

Now I am experimenting a different approach similar to [1], e.g.

* 1 low-level data source per tenant
* 1 data source extending Spring's AbstractRoutingDataSource using the value of 
a ThreadLocal variable as lookup key
* 1 single entity manager factory configured with the routing data source
* 1 single transaction manager
* etc

It mostly works but I am having caching issues with concurrent operations 
working on different tenants, so I was wondering: how can I extend the various 
OpenJPA (query, data, L1, L2, every one) caches to hold back different actual 
instances per tenant and to use the appropriate one depending on the same 
ThreadLocal value I have already used above for data sources?

Thanks in advance.
Regards.

[1] https://github.com/Cepr0/sb-multitenant-db-demo

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Error with latest openjpa-maven-plugin 4.0.0-SNAPSHOT

[Francesco Chicchiriccò]

Hi,
I am also in favor of a milestone release, which might also serve to check (and 
possibly fine-tune) the release process for 4.0.

Regards.

On 31/10/23 07:31, Richard Zowalla wrote:

  From the sideline: I am still in favour for some sort of fast release (even a 
Milestone would be fine...) to be able to proceed with a TomEE 10 milestone 

Gruß
Richard

Am 31. Oktober 2023 07:14:20 MEZ schrieb Mark Struberg 
:

Thanks Francesco, missed the bval release.

With that gone we could approach a openjpa 4.0.0 release?
Or should we go for JPA-3.1 API level immediately and only doing the release 
afterwards?

LieGrue,
strub


Am 29.10.2023 um 16:58 schrieb Francesco Chicchiriccò :

I've just set BVal 3.0.0 which seemed the correct action to take on OpenJPA
root pom.

Regards.

Il giorno dom 29 ott 2023 alle ore 13:33 Romain Manni-Bucau <
rmannibu...@gmail.com> ha scritto:


done but it is 3.0.1-SNAPSHOT now so openjpa can need to use the final
release (or temporarly you force the last snapshot in your pom)

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <
https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<
https://www.packtpub.com/application-development/java-ee-8-high-performance


Le dim. 29 oct. 2023 à 12:27, Francesco Chicchiriccò 
a écrit :


If so, I wonder how Ubuntu can work...

Anyway, do you think you can trigger a new deploy for BVal?

Regards.

Il dom 29 ott 2023, 12:11 Romain Manni-Bucau  ha
scritto:


Hi

Isnt it just the snapshot eviction on nexus?

Le dim. 29 oct. 2023 à 11:51, Francesco Chicchiriccò  a 
écrit :

Hi all,
with latest 4.0.0SNAPSHOT artifacts, we've started getting build errors, but 
only on Windows and Mac OS.

The reported error is [1][2]

Failed to execute goal
org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance (enhancer)
on project syncope-core-persistence-jpa: Execution enhancer of goal
org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance failed:
Plugin org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT or one of its 
dependencies could not be resolved: The following artifacts could not be 
resolved: org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT
(absent): Could not find artifact
org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT in
apache.snapshots (https://repository.apache.org/snapshots) -> [Help1]
On Ubuntu, instead, all is working fine [3].

When I visit [4] I can see there is no artifact, as the error message is 
claiming.

FTR, latest successful build is Oct 23rd, first failing is Oct 25th.

Any idea?

Regards.

[1] https://github.com/apache/syncope/actions/runs/6677784818/job/18148134892
[2] https://github.com/apache/syncope/actions/runs/6677784818/job/18148134968
[3] https://github.com/apache/syncope/actions/runs/6677784818/job/18148134801
[4] 
https://repository.apache.org/content/groups/snapshots/org/apache/bval/org.apache.bval.bundle/3.0.0-SNAPSHOT/


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Error with latest openjpa-maven-plugin 4.0.0-SNAPSHOT

[Francesco Chicchiriccò]

I've just set BVal 3.0.0 which seemed the correct action to take on OpenJPA
root pom.

Regards.

Il giorno dom 29 ott 2023 alle ore 13:33 Romain Manni-Bucau <
rmannibu...@gmail.com> ha scritto:

> done but it is 3.0.1-SNAPSHOT now so openjpa can need to use the final
> release (or temporarly you force the last snapshot in your pom)
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le dim. 29 oct. 2023 à 12:27, Francesco Chicchiriccò 
> a écrit :
>
> > If so, I wonder how Ubuntu can work...
> >
> > Anyway, do you think you can trigger a new deploy for BVal?
> >
> > Regards.
> >
> > Il dom 29 ott 2023, 12:11 Romain Manni-Bucau  ha
> > scritto:
> >
> > > Hi
> > >
> > > Isnt it just the snapshot eviction on nexus?
> > >
> > > Le dim. 29 oct. 2023 à 11:51, Francesco Chicchiriccò <
> > ilgro...@apache.org>
> > > a écrit :
> > >
> > > > Hi all,
> > > > with latest 4.0.0SNAPSHOT artifacts, we've started getting build
> > errors,
> > > > but only on Windows and Mac OS.
> > > >
> > > > The reported error is [1][2]
> > > >
> > > > Failed to execute goal
> > > > org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance
> > (enhancer)
> > > > on project syncope-core-persistence-jpa: Execution enhancer of goal
> > > > org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance
> failed:
> > > > Plugin org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT or one
> of
> > > its
> > > > dependencies could not be resolved: The following artifacts could not
> > be
> > > > resolved: org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT
> > > > (absent): Could not find artifact
> > > > org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT in
> > > > apache.snapshots (https://repository.apache.org/snapshots) -> [Help
> 1]
> > > >
> > > > On Ubuntu, instead, all is working fine [3].
> > > >
> > > > When I visit [4] I can see there is no artifact, as the error message
> > is
> > > > claiming.
> > > >
> > > > FTR, latest successful build is Oct 23rd, first failing is Oct 25th.
> > > >
> > > > Any idea?
> > > >
> > > > Regards.
> > > >
> > > > [1]
> > > >
> > >
> >
> https://github.com/apache/syncope/actions/runs/6677784818/job/18148134892
> > > > [2]
> > > >
> > >
> >
> https://github.com/apache/syncope/actions/runs/6677784818/job/18148134968
> > > > [3]
> > > >
> > >
> >
> https://github.com/apache/syncope/actions/runs/6677784818/job/18148134801
> > > > [4]
> > > >
> > >
> >
> https://repository.apache.org/content/groups/snapshots/org/apache/bval/org.apache.bval.bundle/3.0.0-SNAPSHOT/
> > > >
> > > > --
> > > > Francesco Chicchiriccò
> > > >
> > > > Tirasa - Open Source Excellence
> > > > http://www.tirasa.net/
> > > >
> > > > Member at The Apache Software Foundation
> > > > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> > > > http://home.apache.org/~ilgrosso/
> > > >
> > > >
> > >
> >
>


-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Error with latest openjpa-maven-plugin 4.0.0-SNAPSHOT

[Francesco Chicchiriccò]

If so, I wonder how Ubuntu can work...

Anyway, do you think you can trigger a new deploy for BVal?

Regards.

Il dom 29 ott 2023, 12:11 Romain Manni-Bucau  ha
scritto:

> Hi
>
> Isnt it just the snapshot eviction on nexus?
>
> Le dim. 29 oct. 2023 à 11:51, Francesco Chicchiriccò 
> a écrit :
>
> > Hi all,
> > with latest 4.0.0SNAPSHOT artifacts, we've started getting build errors,
> > but only on Windows and Mac OS.
> >
> > The reported error is [1][2]
> >
> > Failed to execute goal
> > org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance (enhancer)
> > on project syncope-core-persistence-jpa: Execution enhancer of goal
> > org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance failed:
> > Plugin org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT or one of
> its
> > dependencies could not be resolved: The following artifacts could not be
> > resolved: org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT
> > (absent): Could not find artifact
> > org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT in
> > apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
> >
> > On Ubuntu, instead, all is working fine [3].
> >
> > When I visit [4] I can see there is no artifact, as the error message is
> > claiming.
> >
> > FTR, latest successful build is Oct 23rd, first failing is Oct 25th.
> >
> > Any idea?
> >
> > Regards.
> >
> > [1]
> >
> https://github.com/apache/syncope/actions/runs/6677784818/job/18148134892
> > [2]
> >
> https://github.com/apache/syncope/actions/runs/6677784818/job/18148134968
> > [3]
> >
> https://github.com/apache/syncope/actions/runs/6677784818/job/18148134801
> > [4]
> >
> https://repository.apache.org/content/groups/snapshots/org/apache/bval/org.apache.bval.bundle/3.0.0-SNAPSHOT/
> >
> > --
> > Francesco Chicchiriccò
> >
> > Tirasa - Open Source Excellence
> > http://www.tirasa.net/
> >
> > Member at The Apache Software Foundation
> > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> > http://home.apache.org/~ilgrosso/
> >
> >
>

Error with latest openjpa-maven-plugin 4.0.0-SNAPSHOT

[Francesco Chicchiriccò]

Hi all,
with latest 4.0.0SNAPSHOT artifacts, we've started getting build errors, but 
only on Windows and Mac OS.

The reported error is [1][2]

Failed to execute goal 
org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance (enhancer) on 
project syncope-core-persistence-jpa: Execution enhancer of goal 
org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance failed: Plugin 
org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT or one of its dependencies 
could not be resolved: The following artifacts could not be resolved: 
org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT (absent): Could not find 
artifact org.apache.bval:org.apache.bval.bundle:jar:3.0.0-SNAPSHOT in 
apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]

On Ubuntu, instead, all is working fine [3].

When I visit [4] I can see there is no artifact, as the error message is 
claiming.

FTR, latest successful build is Oct 23rd, first failing is Oct 25th.

Any idea?

Regards.

[1] https://github.com/apache/syncope/actions/runs/6677784818/job/18148134892
[2] https://github.com/apache/syncope/actions/runs/6677784818/job/18148134968
[3] https://github.com/apache/syncope/actions/runs/6677784818/job/18148134801
[4] 
https://repository.apache.org/content/groups/snapshots/org/apache/bval/org.apache.bval.bundle/3.0.0-SNAPSHOT/

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [openjpa] branch master updated: OPENJPA-2911 DetachedState as ASM

[Francesco Chicchiriccò]

Thanks Mark.
I can see that Jenkins is green now, while GH actions workflow remains red,
regardless of the fact they are essentially running the same mvn switches...

Il ven 14 lug 2023, 12:20 Mark Struberg  ha
scritto:

> Hi Francesco!
>
> I think this was just some infra hiccup. Later build turned green again.
>
> txs and LieGrue,
> strub
>
> > Am 12.07.2023 um 15:34 schrieb Francesco Chicchiriccò <
> ilgro...@apache.org>:
> >
> > Hi Mark,
> > as far as I can see the last commits are breaking the build process: see
> >
> >
> https://github.com/apache/openjpa/actions/runs/5529698930/jobs/10088123713
> > https://ci-builds.apache.org/job/OpenJPA/job/OpenJPA-master-deploy/102/
> >
> > Can you have a look? Thanks!
> > Regards.
> >
> > On 12/07/23 11:06, strub...@apache.org wrote:
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> struberg pushed a commit to branch master
> >> in repository https://gitbox.apache.org/repos/asf/openjpa.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/master by this push:
> >>  new 7700fdfd4 OPENJPA-2911 DetachedState as ASM
> >> 7700fdfd4 is described below
> >>
> >> commit 7700fdfd45d0f1995d7e4592d5a8c6c713c05faa
> >> Author: Mark Struberg 
> >> AuthorDate: Wed Jul 12 11:05:04 2023 +0200
> >>
> >> OPENJPA-2911 DetachedState as ASM
> >> ---
> >>  .../org/apache/openjpa/enhance/PCEnhancer.java | 85
> +++---
> >>  1 file changed, 43 insertions(+), 42 deletions(-)
> >>
> >> diff --git
> a/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java
> b/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java
> >> index 483f05aa3..2ff67b469 100644
> >> ---
> a/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java
> >> +++
> b/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java
> >> @@ -1687,7 +1687,7 @@ public class PCEnhancer {
> >>  // pcVersionInit = true;
> >>  instructions.add(new VarInsnNode(Opcodes.ALOAD,
> 0)); // this
> >>  instructions.add(new InsnNode(Opcodes.ICONST_1));
> >> -putfield(instructions, getType(_meta),
> VERSION_INIT_STR, boolean.class);
> >> +putfield(classNode, instructions, getType(_meta),
> VERSION_INIT_STR, boolean.class);
> >>  }
> >>instructions.add(new InsnNode(Opcodes.RETURN));
> >> @@ -4633,13 +4633,10 @@ public class PCEnhancer {
> >>  // accessor methods
> >>  if (_meta.getPCSuperclass() == null || getCreateSubclass() ||
> parentDetachable != _meta.isDetachable()) {
> >>  addIsDetachedMethod(classNode);
> >> -AsmHelper.readIntoBCClass(pc, _pc);
> >> -
> >>  addDetachedStateMethods(_meta.usesDetachedState() !=
> Boolean.FALSE);
> >>  }
> >> -else {
> >> -AsmHelper.readIntoBCClass(pc, _pc);
> >> -}
> >> +
> >> +AsmHelper.readIntoBCClass(pc, _pc);
> >>// if we detach on serialize, we also need to implement the
> >>  // externalizable interface to write just the state for the
> fields
> >> @@ -4662,54 +4659,55 @@ public class PCEnhancer {
> >>  private void addDetachedStateMethods(boolean impl) {
> >>  Field detachField = _meta.getDetachedStateField();
> >>  String name = null;
> >> -String declarer = null;
> >> +Class declarer = null;
> >> +final ClassNode classNode = pc.getClassNode();
> >> +
> >> +
> >>  if (impl && detachField == null) {
> >>  name = PRE + "DetachedState";
> >> -declarer = _pc.getName();
> >> -BCField field = _pc.declareField(name, Object.class);
> >> -field.makePrivate();
> >> -field.setTransient(true);
> >> +FieldNode field = new FieldNode(Opcodes.ACC_PRIVATE |
> Opcodes.ACC_TRANSIENT,
> >> +name,
> >> +
> TYPE_OBJECT.getDescriptor(),
> >> +null, null);
> >> +classNode.fields.add(field);
> >>  }
> >> 

Re: [openjpa] branch master updated: OPENJPA-2911 DetachedState as ASM

[Francesco Chicchiriccò]

 getDetachedStateMeth.instructions.add(new 
InsnNode(Opcodes.ACONST_NULL));
+}
+getDetachedStateMeth.instructions.add(new InsnNode(Opcodes.ARETURN));
+
  
  // public void pcSetDetachedState (Object state)

-method = _pc.declareMethod(PRE + "SetDetachedState",
-   void.class, new Class[]{Object.class});
-method.setAccessFlags(access);
-code = method.getCode(true);
+MethodNode setDetachedStateMeth = new MethodNode(Opcodes.ACC_PUBLIC,
+ PRE + 
"SetDetachedState",
+ 
Type.getMethodDescriptor(Type.VOID_TYPE, TYPE_OBJECT),
+ null, null);
+classNode.methods.add(setDetachedStateMeth);
+
  if (impl) {
  // pcDetachedState = state;
-loadManagedInstance(code, false);
-code.aload().setParam(0);
-putfield(code, _managedType.getProject().loadClass(declarer),
- name, Object.class);
+setDetachedStateMeth.instructions.add(new 
VarInsnNode(Opcodes.ALOAD, 0)); // this
+setDetachedStateMeth.instructions.add(new 
VarInsnNode(Opcodes.ALOAD, 1)); // 1st parameter
+putfield(classNode, setDetachedStateMeth.instructions, declarer, 
name, Object.class);
  }
-code.vreturn();
-code.calculateMaxStack();
-code.calculateMaxLocals();
+setDetachedStateMeth.instructions.add(new InsnNode(Opcodes.RETURN));
  }
  
  /**

@@ -4859,9 +4857,11 @@ public class PCEnhancer {
   * When this method is invoked, the value to load must
   * already be on the top of the stack,
   * and the instance to load into must be second.
- * @param declarer internal class name (org/bla/..) which contains the 
field
+ *
+ * @param classNode
+ * @param declarer  internal class name (org/bla/..) which contains the 
field
   */
-private void putfield(InsnList instructions, Class declarer, String 
attrName, Class fieldType) {
+private void putfield(ClassNode classNode, InsnList instructions, Class 
declarer, String attrName, Class fieldType) {
  String fieldName = toBackingFieldName(attrName);
  
  if (getRedefine() || getCreateSubclass()) {

@@ -4889,7 +4889,8 @@ public class PCEnhancer {
  
  }

  else {
-instructions.add(new FieldInsnNode(Opcodes.PUTFIELD, 
Type.getInternalName(declarer), fieldName, Type.getDescriptor(fieldType)));
+String owner = declarer != null ? Type.getInternalName(declarer) : 
classNode.name;
+instructions.add(new FieldInsnNode(Opcodes.PUTFIELD, owner, 
fieldName, Type.getDescriptor(fieldType)));
  }
  }
  
@@ -5486,7 +5487,7 @@ public class PCEnhancer {

  // just do a subclass approach instead. But this is not a good option,
  // since it would sacrifice lazy loading and efficient dirty tracking.
  if (getRedefine() || isFieldAccess(fmd)) {
-putfield(instructions, fmd.getDeclaringType(), fmd.getName(), 
fmd.getDeclaredType());
+putfield(classNode, instructions, fmd.getDeclaringType(), 
fmd.getName(), fmd.getDeclaredType());
  }
  else if (getCreateSubclass()) {
  // property access, and we're not redefining. invoke the
@@ -5520,7 +5521,7 @@ public class PCEnhancer {
  // just do a subclass approach instead. But this is not a good option,
  // since it would sacrifice lazy loading and efficient dirty tracking.
  if (getRedefine() || isFieldAccess(fmd)) {
-putfield(instructions, getType(_meta), fmd.getName(), 
fmd.getDeclaredType());
+putfield(classNode, instructions, getType(_meta), fmd.getName(), 
fmd.getDeclaredType());
  }
  else if (getCreateSubclass()) {
  // property access, and we're not redefining. invoke the



--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: enhance without Serp - Update

[Francesco Chicchiriccò]

Thanks Mark, your last commit seems to have fixed, our build is green again.

Nice job!

Il lun 3 lug 2023, 18:10 Mark Struberg  ha
scritto:

> Francesco, I've now pushed this change. Can you please try it out? Looks
> good over here now.
> Now I started the full Syncope build and hope all comes green again.
>
> txs and LieGrue,
> strub
>
> > Am 03.07.2023 um 17:55 schrieb Mark Struberg :
> >
> > Think I found the solution, but first want to run all tests in OpenJPA.
> >
> > I did use the standard ClassWriter in ASMHelper. This does use
> Class.forName.
> > Changed ASMHelper to use the BCClassWriter you wrote some time ago. That
> should do the trick I hope.
> >
> > Gimme 10 minutes plz.
> >
> > LieGrue,
> > strub
> >
> >
> >> Am 03.07.2023 um 17:34 schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com>:
> >>
> >> @Francesco: can you *javap -v -cp $yourclasspath the.class.which.Fail*
> when
> >> it works vs when it fails please?
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >> <https://rmannibucau.metawerx.net/> | Old Blog
> >> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >>
> >>
> >> Le lun. 3 juil. 2023 à 17:23, Mark Struberg 
> a
> >> écrit :
> >>
> >>> Does not yet ring any bells, sorry :(
> >>>
> >>> Right now trying to fire up the enhancer manually in the debugger.
> >>> Difference really is that we now do the ASM part way earlier, but still
> >>> class per class.
> >>> Before that it was done as part of the ASMAdapter.
> >>>
> >>> Still digging.
> >>>
> >>> LieGrue,
> >>> strub
> >>>
> >>>
> >>>> Am 03.07.2023 um 17:00 schrieb Francesco Chicchiriccò <
> >>> ilgro...@apache.org>:
> >>>>
> >>>> Adding some info.
> >>>>
> >>>> First of all, the class to which the error message is referring is not
> >>> always the same.
> >>>>
> >>>> Secondly, at least about AccountPolicy as reported below, the original
> >>> error message is stating
> >>>>
> >>>> Execution enhancer of goal
> >>> org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance failed:
> An
> >>> error occurred while enhancing
> >>> org.apache.syncope.core.persistence.jpa.entity.JPARealm. Exception
> message:
> >>> Type
> org/apache/syncope/core/persistence/api/entity/policy/AccountPolicy
> >>> not present:
> >>> org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy
> >>>>
> >>>> If you look at JPARealm:
> >>>>
> >>>>
> >>>
> https://github.com/apache/syncope/blob/master/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPARealm.java#L82
> >>>>
> >>>> it declares
> >>>>
> >>>>   @ManyToOne(fetch = FetchType.EAGER)
> >>>>   private JPAAccountPolicy accountPolicy;
> >>>>
> >>>> e.g. a reference to the JPA entity JPAAccountPolicy, not to the
> >>> interface that this class implements, e.g. AccountPolicy
> >>>>
> >>>> It looks to me that somewhere the OpenJPA enhancement process is
> trying
> >>> to resolve more than it should do.
> >>>>
> >>>> Does this make ringing any bell?
> >>>>
> >>>> Regards.
> >>>>
> >>>> On 03/07/23 16:32, Francesco Chicchiriccò wrote:
> >>>>> On 03/07/23 16:27, Mark Struberg wrote:
> >>>>>> Went forward and compiled the Syncope main branch.
> >>>>>>
> >>>>>> Getting this error when running with mvn -X
> >>>>>>
> >>>>>> Caused by: java.lang.ClassNotFoundException:
> >>> org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy
> >>>>>>at
> >>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass
> >>> (SelfFirstStrategy.java:50)
> >>>>>>at
> >>>
> org.codehaus.plexu

Re: enhance without Serp - Update

[Francesco Chicchiriccò]

Or maybe the issue is just the enhancement order?

In the JPARealm sample below, in fact, I can see that JPARealm.class is not yet 
enhanced so the error is raised while enhancing, and possibly because 
JPAAccountPolicy was not enhanced yet.

On 03/07/23 17:00, Francesco Chicchiriccò wrote:

Adding some info.

First of all, the class to which the error message is referring is not always 
the same.

Secondly, at least about AccountPolicy as reported below, the original error 
message is stating

Execution enhancer of goal 
org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance failed: An error 
occurred while enhancing 
org.apache.syncope.core.persistence.jpa.entity.JPARealm. Exception message: 
Type org/apache/syncope/core/persistence/api/entity/policy/AccountPolicy not 
present: org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy

If you look at JPARealm:

https://github.com/apache/syncope/blob/master/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPARealm.java#L82

it declares

    @ManyToOne(fetch = FetchType.EAGER)
    private JPAAccountPolicy accountPolicy;

e.g. a reference to the JPA entity JPAAccountPolicy, not to the interface that 
this class implements, e.g. AccountPolicy

It looks to me that somewhere the OpenJPA enhancement process is trying to 
resolve more than it should do.

Does this make ringing any bell?

Regards.

On 03/07/23 16:32, Francesco Chicchiriccò wrote:

On 03/07/23 16:27, Mark Struberg wrote:

Went forward and compiled the Syncope main branch.

Getting this error when running with mvn -X

Caused by: java.lang.ClassNotFoundException: 
org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy
 at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass 
(SelfFirstStrategy.java:50)
 at 
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass 
(ClassRealm.java:271)
 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:247)
 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:239)
 at java.lang.Class.forName0 (Native Method)
 at java.lang.Class.forName (Class.java:467)
 at org.apache.xbean.asm9.ClassWriter.getCommonSuperClass 
(ClassWriter.java:1043)
 at org.apache.xbean.asm9.SymbolTable.addMergedType (SymbolTable.java:1202)
 at org.apache.xbean.asm9.Frame.merge (Frame.java:1299)
 at org.apache.xbean.asm9.Frame.merge (Frame.java:1244)
 at org.apache.xbean.asm9.MethodWriter.computeAllFrames 
(MethodWriter.java:1611)
 at org.apache.xbean.asm9.MethodWriter.visitMaxs (MethodWriter.java:1547)
 at org.apache.xbean.asm9.tree.MethodNode.accept (MethodNode.java:767)
 at org.apache.xbean.asm9.tree.MethodNode.accept (MethodNode.java:647)
 at org.apache.xbean.asm9.tree.ClassNode.accept (ClassNode.java:468)
 at org.apache.openjpa.util.asm.AsmHelper.readIntoBCClass 
(AsmHelper.java:146)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:606)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:5889)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:5829)
 at org.apache.openjpa.enhance.PCEnhancer$1.run (PCEnhancer.java:5799)
 at org.apache.openjpa.lib.conf.Configurations.launchRunnable 
(Configurations.java:760)
 at org.apache.openjpa.lib.conf.Configurations.runAgainstAllAnchors 
(Configurations.java:745)


Is this the one you experience too?


Yes, exactly.

As you might have found out, AccountPolicy is an interface implemented by 
JPAAccountPolicy, which is the corresponding JPA entity.
We take this approach for all JPA entities, actually.

I thought the reason why AccountPolicy or JPAAccountPolicy are not found is 
that enhancement does not actually finds them.


Will take a look at it now.


Thank you very much!

Regards.

Am 03.07.2023 um 15:49 schrieb Mark Struberg :

Hi Francesco!

Can you see which one of the classes fail to enhance?

In which case you might try to run the enhancement of that very class manually 
in your IDE.

Main class: org.apache.openjpa.enhance.PCEnhancer
VMOptions:: -ea 
-Dopenjpa.ConnectionURL=jdbc:derby:target/database/openjpa-derby-database;create=true
 -Dopenjpa.ConnectionDriverName=org.apache.derby.jdbc.EmbeddedDriver
or something similar for your connection

Then you also need the parameter pointing to the class file which you want to 
enhance, e.g.
target/test-classes/org/apache/openjpa/persistence/proxy/entities/Annuity.class

Please keep me updated!


LieGrue,
strub

PS: does it add value if we'd write all this up? You will likely know most of 
that stuff, but others who dig into OpenJPA do not.




Am 03.07.2023 um 15:28 schrieb Francesco Chicchiriccò :

Hi Mark,
thanks for your reply.

So I am proceeding as follows.

Took the executions at

https://ci-builds.apache.org/job/OpenJPA/job/OpenJPA-master-deploy/

(the Jenkins job which is publishing SNAPSHOT artifacts from master to ASF

Re: enhance without Serp - Update

[Francesco Chicchiriccò]

Adding some info.

First of all, the class to which the error message is referring is not always 
the same.

Secondly, at least about AccountPolicy as reported below, the original error 
message is stating

Execution enhancer of goal 
org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance failed: An error 
occurred while enhancing 
org.apache.syncope.core.persistence.jpa.entity.JPARealm. Exception message: 
Type org/apache/syncope/core/persistence/api/entity/policy/AccountPolicy not 
present: org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy

If you look at JPARealm:

https://github.com/apache/syncope/blob/master/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPARealm.java#L82

it declares

    @ManyToOne(fetch = FetchType.EAGER)
    private JPAAccountPolicy accountPolicy;

e.g. a reference to the JPA entity JPAAccountPolicy, not to the interface that 
this class implements, e.g. AccountPolicy

It looks to me that somewhere the OpenJPA enhancement process is trying to 
resolve more than it should do.

Does this make ringing any bell?

Regards.

On 03/07/23 16:32, Francesco Chicchiriccò wrote:

On 03/07/23 16:27, Mark Struberg wrote:

Went forward and compiled the Syncope main branch.

Getting this error when running with mvn -X

Caused by: java.lang.ClassNotFoundException: 
org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy
 at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass 
(SelfFirstStrategy.java:50)
 at 
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass 
(ClassRealm.java:271)
 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:247)
 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:239)
 at java.lang.Class.forName0 (Native Method)
 at java.lang.Class.forName (Class.java:467)
 at org.apache.xbean.asm9.ClassWriter.getCommonSuperClass 
(ClassWriter.java:1043)
 at org.apache.xbean.asm9.SymbolTable.addMergedType (SymbolTable.java:1202)
 at org.apache.xbean.asm9.Frame.merge (Frame.java:1299)
 at org.apache.xbean.asm9.Frame.merge (Frame.java:1244)
 at org.apache.xbean.asm9.MethodWriter.computeAllFrames 
(MethodWriter.java:1611)
 at org.apache.xbean.asm9.MethodWriter.visitMaxs (MethodWriter.java:1547)
 at org.apache.xbean.asm9.tree.MethodNode.accept (MethodNode.java:767)
 at org.apache.xbean.asm9.tree.MethodNode.accept (MethodNode.java:647)
 at org.apache.xbean.asm9.tree.ClassNode.accept (ClassNode.java:468)
 at org.apache.openjpa.util.asm.AsmHelper.readIntoBCClass 
(AsmHelper.java:146)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:606)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:5889)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:5829)
 at org.apache.openjpa.enhance.PCEnhancer$1.run (PCEnhancer.java:5799)
 at org.apache.openjpa.lib.conf.Configurations.launchRunnable 
(Configurations.java:760)
 at org.apache.openjpa.lib.conf.Configurations.runAgainstAllAnchors 
(Configurations.java:745)


Is this the one you experience too?


Yes, exactly.

As you might have found out, AccountPolicy is an interface implemented by 
JPAAccountPolicy, which is the corresponding JPA entity.
We take this approach for all JPA entities, actually.

I thought the reason why AccountPolicy or JPAAccountPolicy are not found is 
that enhancement does not actually finds them.


Will take a look at it now.


Thank you very much!

Regards.

Am 03.07.2023 um 15:49 schrieb Mark Struberg :

Hi Francesco!

Can you see which one of the classes fail to enhance?

In which case you might try to run the enhancement of that very class manually 
in your IDE.

Main class: org.apache.openjpa.enhance.PCEnhancer
VMOptions:: -ea 
-Dopenjpa.ConnectionURL=jdbc:derby:target/database/openjpa-derby-database;create=true
 -Dopenjpa.ConnectionDriverName=org.apache.derby.jdbc.EmbeddedDriver
or something similar for your connection

Then you also need the parameter pointing to the class file which you want to 
enhance, e.g.
target/test-classes/org/apache/openjpa/persistence/proxy/entities/Annuity.class

Please keep me updated!


LieGrue,
strub

PS: does it add value if we'd write all this up? You will likely know most of 
that stuff, but others who dig into OpenJPA do not.




Am 03.07.2023 um 15:28 schrieb Francesco Chicchiriccò :

Hi Mark,
thanks for your reply.

So I am proceeding as follows.

Took the executions at

https://ci-builds.apache.org/job/OpenJPA/job/OpenJPA-master-deploy/

(the Jenkins job which is publishing SNAPSHOT artifacts from master to ASF 
Maven repo) and saw that the artifacts with which the Syncope build succeeded 
last Friday are the one from May 16th, so the corresponding commit id is

b238417dabeac935846fe1ce2fef28aafaeef205

I confirm that building locally from that commit id everything is working.

As soon as I move

Re: enhance without Serp - Update

[Francesco Chicchiriccò]

On 03/07/23 16:27, Mark Struberg wrote:

Went forward and compiled the Syncope main branch.

Getting this error when running with mvn -X

Caused by: java.lang.ClassNotFoundException: 
org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy
 at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass 
(SelfFirstStrategy.java:50)
 at 
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass 
(ClassRealm.java:271)
 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:247)
 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:239)
 at java.lang.Class.forName0 (Native Method)
 at java.lang.Class.forName (Class.java:467)
 at org.apache.xbean.asm9.ClassWriter.getCommonSuperClass 
(ClassWriter.java:1043)
 at org.apache.xbean.asm9.SymbolTable.addMergedType (SymbolTable.java:1202)
 at org.apache.xbean.asm9.Frame.merge (Frame.java:1299)
 at org.apache.xbean.asm9.Frame.merge (Frame.java:1244)
 at org.apache.xbean.asm9.MethodWriter.computeAllFrames 
(MethodWriter.java:1611)
 at org.apache.xbean.asm9.MethodWriter.visitMaxs (MethodWriter.java:1547)
 at org.apache.xbean.asm9.tree.MethodNode.accept (MethodNode.java:767)
 at org.apache.xbean.asm9.tree.MethodNode.accept (MethodNode.java:647)
 at org.apache.xbean.asm9.tree.ClassNode.accept (ClassNode.java:468)
 at org.apache.openjpa.util.asm.AsmHelper.readIntoBCClass 
(AsmHelper.java:146)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:606)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:5889)
 at org.apache.openjpa.enhance.PCEnhancer.run (PCEnhancer.java:5829)
 at org.apache.openjpa.enhance.PCEnhancer$1.run (PCEnhancer.java:5799)
 at org.apache.openjpa.lib.conf.Configurations.launchRunnable 
(Configurations.java:760)
 at org.apache.openjpa.lib.conf.Configurations.runAgainstAllAnchors 
(Configurations.java:745)


Is this the one you experience too?


Yes, exactly.

As you might have found out, AccountPolicy is an interface implemented by 
JPAAccountPolicy, which is the corresponding JPA entity.
We take this approach for all JPA entities, actually.

I thought the reason why AccountPolicy or JPAAccountPolicy are not found is 
that enhancement does not actually finds them.


Will take a look at it now.


Thank you very much!

Regards.

Am 03.07.2023 um 15:49 schrieb Mark Struberg :

Hi Francesco!

Can you see which one of the classes fail to enhance?

In which case you might try to run the enhancement of that very class manually 
in your IDE.

Main class: org.apache.openjpa.enhance.PCEnhancer
VMOptions:: -ea 
-Dopenjpa.ConnectionURL=jdbc:derby:target/database/openjpa-derby-database;create=true
 -Dopenjpa.ConnectionDriverName=org.apache.derby.jdbc.EmbeddedDriver
or something similar for your connection

Then you also need the parameter pointing to the class file which you want to 
enhance, e.g.
target/test-classes/org/apache/openjpa/persistence/proxy/entities/Annuity.class

Please keep me updated!


LieGrue,
strub

PS: does it add value if we'd write all this up? You will likely know most of 
that stuff, but others who dig into OpenJPA do not.




Am 03.07.2023 um 15:28 schrieb Francesco Chicchiriccò :

Hi Mark,
thanks for your reply.

So I am proceeding as follows.

Took the executions at

https://ci-builds.apache.org/job/OpenJPA/job/OpenJPA-master-deploy/

(the Jenkins job which is publishing SNAPSHOT artifacts from master to ASF 
Maven repo) and saw that the artifacts with which the Syncope build succeeded 
last Friday are the one from May 16th, so the corresponding commit id is

b238417dabeac935846fe1ce2fef28aafaeef205

I confirm that building locally from that commit id everything is working.

As soon as I move to next commit (dated May 22nd, pushed and deployed today) 
with id

b51d003ed98aa7663465aad7c9a1b554b006cc7d

I see the same behavior as with HEAD, e.g.

2b9b024f273d63e479a02cad751c28b8ef974ace

I will try to take a closer look at the code.
Regards.

On 03/07/23 14:44, Mark Struberg wrote:

Hi Francesco!

That's very valuable information!
Could you please do a git-bisect to find out which change did break it?

Actually the algorithm to select which classes are to be enhanced should not 
have changed. Thus I'm really curious what I did break.

Most times the amount of enhanced classes are the same but slightly differ in 
the generated code. That might be due to now we really generate Java11++ code 
whereas before we only generated Java 1.1 code (yes, not even 1.5!)

What I usually do is to have 2 checkouts. You might want to change the pom GAV 
version of the working checkout to something something different so you might 
have both in your ~/.m2/repository in parallel.

The first thing I do is to compare the class files in target/classes of both 
versions with 'compare with clipboard'.
I just open the class file in target/classes and let Intellij/Netbeans

Re: enhance without Serp - Update

[Francesco Chicchiriccò]

Hi Mark,
thanks for your reply.

So I am proceeding as follows.

Took the executions at

https://ci-builds.apache.org/job/OpenJPA/job/OpenJPA-master-deploy/

(the Jenkins job which is publishing SNAPSHOT artifacts from master to ASF 
Maven repo) and saw that the artifacts with which the Syncope build succeeded 
last Friday are the one from May 16th, so the corresponding commit id is

b238417dabeac935846fe1ce2fef28aafaeef205

I confirm that building locally from that commit id everything is working.

As soon as I move to next commit (dated May 22nd, pushed and deployed today) 
with id

b51d003ed98aa7663465aad7c9a1b554b006cc7d

I see the same behavior as with HEAD, e.g.

2b9b024f273d63e479a02cad751c28b8ef974ace

I will try to take a closer look at the code.
Regards.

On 03/07/23 14:44, Mark Struberg wrote:

Hi Francesco!

That's very valuable information!
Could you please do a git-bisect to find out which change did break it?

Actually the algorithm to select which classes are to be enhanced should not 
have changed. Thus I'm really curious what I did break.

Most times the amount of enhanced classes are the same but slightly differ in 
the generated code. That might be due to now we really generate Java11++ code 
whereas before we only generated Java 1.1 code (yes, not even 1.5!)

What I usually do is to have 2 checkouts. You might want to change the pom GAV 
version of the working checkout to something something different so you might 
have both in your ~/.m2/repository in parallel.

The first thing I do is to compare the class files in target/classes of both 
versions with 'compare with clipboard'.
I just open the class file in target/classes and let Intellij/Netbeans do the 
decompilation for me.

You might find some differences here in which case this needs further 
investigation. Note that the order of the methods might have changed.
Sometimes you will also see some 'cannot decompile' in the code block. This 
happens when something in the bytecode is messed up. You can also watch out for 
ClassNotFound or VerifyError, etc.

If this is the case I then use
$> javap -c -p -constants target/classes/com/foo/mycorp/MyBlaEntity.class > 
MyBlaEntity.decompile
on both versions and check whether something is different.
Often it's a wrong offset in the stack calculation (e.g. ALOAD 1 vs ALOAD 2)

Note that the 'old' Java 1.1 bytecode doesn't understand LDC of Class constants 
(LoaD Constant). This was only introduced in Java 1.4 or 1.5 bytecode afair. 
Before that a dynamic Class.forName was called and stored in a static variable. 
Ugly stuff, and happy to finally get rid of all those hacks...

Hope that helps to get you started. Feel free to ping me again over here or at 
the #apachee ASF slack channel.

txs and LieGrue,
strub




Am 03.07.2023 um 14:13 schrieb Francesco Chicchiriccò :

 From a very preliminary analysis it seems that just a subset of the 
persistence-capable classes are effectively found and enhanced: now [2], it 
used to be [3].

I'll continue investigating.

Regards.

On 03/07/23 13:56, Francesco Chicchiriccò wrote:

Hi Mark,
the build on Syncope master branch, using OpenJPA 4.0.0-SNAPSHOT is now failing 
- it used to work at least until last June 30th.

The issues seem to be related to entity enhancement, which we perform via 
openjpa-maven-plugin - see [1].

Is there anything obvious we should be changing?
Meanwhile I'll try to dig to see if I am able to understand something more.

Regards.

[1] 
https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L143-L174

[2] https://paste.apache.org/gxcm6
[3] https://paste.apache.org/1g9k5


On 03/07/23 12:15, Mark Struberg wrote:

Update: I've now merged the wip to our master and pushed it to the ASF gitox 
repo.

I think we already came pretty far and it looks really promising. So there is a 
high chance that we succeed, although there is still plenty of work in front of 
us.

How it works:

Basically there are 2 sets of information in the PCEnhancer right now:

_managed: the BCClass version of the original class
_pc: the BCClass of the generated/modified class. Might be the same as _managed 
but in case of subclassing or interface case it is different. In those cases 
_managed represents the original class and _pc the subclass/concrete 
implementation.

managed and pc are the ASM variants of _managed and _pc.

The main entry point for debugging into it is PCEnhancer#run()

There are a few methods in ASMHelper to update from BCClass -> ASM and vice 
versa:

AsmHelper.readIntoBCClass(pc, _pc);
takes all the information from the ASM pc, creates a class byte[] and reads 
that back into the existing _pc instance.

pc = AsmHelper.toClassNode(_pc);
is the corresponding method in the other direction. from BCClass to ASM.

Right now we have the following methods left to migrate in PCEnhancer
addAttachDetachCode();
addSerializationCode();
addCloningCode();
runAuxiliaryEnhancers();


I'll be off for a week on holidays 

Re: enhance without Serp - Update

[Francesco Chicchiriccò]

From a very preliminary analysis it seems that just a subset of the 
persistence-capable classes are effectively found and enhanced: now [2], it 
used to be [3].

I'll continue investigating.

Regards.

On 03/07/23 13:56, Francesco Chicchiriccò wrote:

Hi Mark,
the build on Syncope master branch, using OpenJPA 4.0.0-SNAPSHOT is now failing 
- it used to work at least until last June 30th.

The issues seem to be related to entity enhancement, which we perform via 
openjpa-maven-plugin - see [1].

Is there anything obvious we should be changing?
Meanwhile I'll try to dig to see if I am able to understand something more.

Regards.

[1] 
https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L143-L174


[2] https://paste.apache.org/gxcm6
[3] https://paste.apache.org/1g9k5


On 03/07/23 12:15, Mark Struberg wrote:

Update: I've now merged the wip to our master and pushed it to the ASF gitox 
repo.

I think we already came pretty far and it looks really promising. So there is a 
high chance that we succeed, although there is still plenty of work in front of 
us.

How it works:

Basically there are 2 sets of information in the PCEnhancer right now:

_managed: the BCClass version of the original class
_pc: the BCClass of the generated/modified class. Might be the same as _managed 
but in case of subclassing or interface case it is different. In those cases 
_managed represents the original class and _pc the subclass/concrete 
implementation.

managed and pc are the ASM variants of _managed and _pc.

The main entry point for debugging into it is PCEnhancer#run()

There are a few methods in ASMHelper to update from BCClass -> ASM and vice 
versa:

AsmHelper.readIntoBCClass(pc, _pc);
takes all the information from the ASM pc, creates a class byte[] and reads 
that back into the existing _pc instance.

pc = AsmHelper.toClassNode(_pc);
is the corresponding method in the other direction. from BCClass to ASM.

Right now we have the following methods left to migrate in PCEnhancer
addAttachDetachCode();
addSerializationCode();
addCloningCode();
runAuxiliaryEnhancers();


I'll be off for a week on holidays in Venice.
If someone want's to join in with the effort then please go on! You might want 
to compare the current PCEnhancer code with an older version to get an idea how 
it can be done and to see some patterns I've used.

As a quick hint: Java is basically a stack based virtual CPU. The 'this' 
pointer is on position 0 of the stack, so ALOAD 0. After that comes the 
parameters. The size of the param on the stack depends on the type. Mostly 1, 
but for long eg 2 positions. So ALOAD 1 is the 1st method parameter, ALOAD 2 
the 2nd (except 1st param was a 2-pos type).
In case of a static method there is ofc no 'this' on the stack, so the 
parameters start with zero offset.
After all the parameters there are the unnamed 'local' variables. I tried to 
consistently name them xxxVarPos.
See also the various helper methods in ASMHelper. For example for the various 
LOAD, RETURN, STORE operations which depends based on the type (ALOAD vs ILOAD 
vs IALOAD etc)
Also read the guide to ASM PDF from objectweb.

I'll be mostly offline till Sunday, but will try to answer mails if there are 
some questions.

txs and LieGrue,
strub





Am 19.06.2023 um 17:11 schrieb Matt Pavlovich :

+1 thanks for tackling this, Mark!

ASM definitely more widely used going forward.

-Matt


On Jun 17, 2023, at 3:01 PM, Mark Struberg  wrote:

Small update:

I've worked on it over the last few weeks, and I'm getting closer


https://github.com/struberg/openjpa/tree/fb_asmEnhance

contains the latest work on the PCEnhancer. Right in the middle of replacing 
Serp with native ASM code.

Note that I also had to modify a few interfaces with a few more to follow from 
BCClass to ASM ClassNode.

Happy to get some feedback!

If anybody wants to help with this effort I'm happy to also push this feature 
branch to our ASF repo. It looks reasonably promising already.

LieGrue,
strub



Am 25.05.2023 um 18:36 schrieb Mark Struberg :

Hi!

Right now I'm trying to get rid of serp step by step.
The code is right now at my own github repo in the fb_asmEnhance branch:
https://github.com/struberg/openjpa/tree/fb_asmEnhance



The approach I took for now is to create a few methods in AsmHelper to be able to 
move from BCClass -> ASM ClassWriter and the other way around. That way we 
should be able to replace functionality part by part but still keep all things 
afloat.

For now I've started with the PCSubclassValidator.
Right now this evaluates the attributs using Serp plus ASM and then compare the 
results.
If something is fishy, you'll see the following
throw new IllegalStateException("MSX ASMTODO " + bcField + " " + field);


It would be extremely helpful, if you could go through your projects and let it 
run and report how it's going.
If you see that "MSX ASMTODO" somewhere then we know I messed something up.

I

Re: enhance without Serp - Update

[Francesco Chicchiriccò]

Hi Mark,
the build on Syncope master branch, using OpenJPA 4.0.0-SNAPSHOT is now failing 
- it used to work at least until last June 30th.

The issues seem to be related to entity enhancement, which we perform via 
openjpa-maven-plugin - see [1].

Is there anything obvious we should be changing?
Meanwhile I'll try to dig to see if I am able to understand something more.

Regards.

[1] 
https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L143-L174

On 03/07/23 12:15, Mark Struberg wrote:

Update: I've now merged the wip to our master and pushed it to the ASF gitox 
repo.

I think we already came pretty far and it looks really promising. So there is a 
high chance that we succeed, although there is still plenty of work in front of 
us.

How it works:

Basically there are 2 sets of information in the PCEnhancer right now:

_managed: the BCClass version of the original class
_pc: the BCClass of the generated/modified class. Might be the same as _managed 
but in case of subclassing or interface case it is different. In those cases 
_managed represents the original class and _pc the subclass/concrete 
implementation.

managed and pc are the ASM variants of _managed and _pc.

The main entry point for debugging into it is PCEnhancer#run()

There are a few methods in ASMHelper to update from BCClass -> ASM and vice 
versa:

AsmHelper.readIntoBCClass(pc, _pc);
takes all the information from the ASM pc, creates a class byte[] and reads 
that back into the existing _pc instance.

pc = AsmHelper.toClassNode(_pc);
is the corresponding method in the other direction. from BCClass to ASM.

Right now we have the following methods left to migrate in PCEnhancer
addAttachDetachCode();
addSerializationCode();
addCloningCode();
runAuxiliaryEnhancers();


I'll be off for a week on holidays in Venice.
If someone want's to join in with the effort then please go on! You might want 
to compare the current PCEnhancer code with an older version to get an idea how 
it can be done and to see some patterns I've used.

As a quick hint: Java is basically a stack based virtual CPU. The 'this' 
pointer is on position 0 of the stack, so ALOAD 0. After that comes the 
parameters. The size of the param on the stack depends on the type. Mostly 1, 
but for long eg 2 positions. So ALOAD 1 is the 1st method parameter, ALOAD 2 
the 2nd (except 1st param was a 2-pos type).
In case of a static method there is ofc no 'this' on the stack, so the 
parameters start with zero offset.
After all the parameters there are the unnamed 'local' variables. I tried to 
consistently name them xxxVarPos.
See also the various helper methods in ASMHelper. For example for the various 
LOAD, RETURN, STORE operations which depends based on the type (ALOAD vs ILOAD 
vs IALOAD etc)
Also read the guide to ASM PDF from objectweb.

I'll be mostly offline till Sunday, but will try to answer mails if there are 
some questions.

txs and LieGrue,
strub





Am 19.06.2023 um 17:11 schrieb Matt Pavlovich :

+1 thanks for tackling this, Mark!

ASM definitely more widely used going forward.

-Matt


On Jun 17, 2023, at 3:01 PM, Mark Struberg  wrote:

Small update:

I've worked on it over the last few weeks, and I'm getting closer


https://github.com/struberg/openjpa/tree/fb_asmEnhance

contains the latest work on the PCEnhancer. Right in the middle of replacing 
Serp with native ASM code.

Note that I also had to modify a few interfaces with a few more to follow from 
BCClass to ASM ClassNode.

Happy to get some feedback!

If anybody wants to help with this effort I'm happy to also push this feature 
branch to our ASF repo. It looks reasonably promising already.

LieGrue,
strub



Am 25.05.2023 um 18:36 schrieb Mark Struberg :

Hi!

Right now I'm trying to get rid of serp step by step.
The code is right now at my own github repo in the fb_asmEnhance branch:
https://github.com/struberg/openjpa/tree/fb_asmEnhance



The approach I took for now is to create a few methods in AsmHelper to be able to 
move from BCClass -> ASM ClassWriter and the other way around. That way we 
should be able to replace functionality part by part but still keep all things 
afloat.

For now I've started with the PCSubclassValidator.
Right now this evaluates the attributs using Serp plus ASM and then compare the 
results.
If something is fishy, you'll see the following
throw new IllegalStateException("MSX ASMTODO " + bcField + " " + field);


It would be extremely helpful, if you could go through your projects and let it 
run and report how it's going.
If you see that "MSX ASMTODO" somewhere then we know I messed something up.

I'll gonna finally remove the BCClass handling from those parts in a few days. 
Current commit is
https://github.com/struberg/openjpa/commit/3ea2412003028d37f2a69971a47bb20abf589f8b

txs and LieGrue,
strub








--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Softwar

Re: [ANN] master will soon be 4.0.0-SNAOPSHOT (JakartaEE)

[Francesco Chicchiriccò]

FYI: 
https://github.com/apache/syncope/commit/00da39119e6d14a8b29984c2a9b033b5599765f1

Regards.

On 07/05/23 09:06, Francesco Chicchiriccò wrote:

I went ahead and updated GH workflows for both master and 3.2.x.

I did also upgrade the Jenkins jobs at

https://ci-builds.apache.org/job/OpenJPA/

to publish SNAPSHOT artifacts.

Incidentally, I've noticed a few dependabot alerts about out-of-date 
dependencies: shall I go ahead and enable it?
We've done the same in other ASF projects.

Regards.

Il giorno dom 7 mag 2023 alle ore 08:21 Francesco Chicchiriccò 
 ha scritto:

I went ahead and updated GH workflows for both master and 3.2.x.

Incidentally, I've noticed a few dependabot alerts about out-of-date 
dependencies: shall I go ahead and enable it?
We've done the same in other ASF projects.

Regards.

Il giorno sab 6 mag 2023 alle ore 11:04 Mark Struberg 
 ha scritto:

Thanks all!

I've had some troubles with Serp, so I rewrote parts to native ASM.
Tempted to also replace the rest of Serp. But that would need a bit 
time and a good part of reviews.
Our tests are really good, but still I cannot rule out that I broke 
something. Hope we will catch everything.
So I'd be really happy about feedback.

Do you think we could push further in that direction of completely 
getting rid of Serp?
Maybe some pair programming?

LieGrue,
strub


> Am 06.05.2023 um 09:05 schrieb Francesco Chicchiriccò 
:
>
> Very cool, thanks Mark!
>
> Il sab 6 mag 2023, 08:55 Mark Struberg  ha
> scritto:
>
>> Hi!
>>
>> I've done the first steps necessary to move to the jakarta namespace
>> natively and update the minimum Java version to 11.
>> I'll move the current master branch to a 3.2.x branch and merge my
>> fb_jakartaee branch into master today.
>> Right now I'm deploying a 4.0.0-SNAPSHOT version from that branch to 
the
>> ASF snapshots repo.
    >>
>> LieGrue,
>> strub


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [ANN] master will soon be 4.0.0-SNAOPSHOT (JakartaEE)

[Francesco Chicchiriccò]

I went ahead and updated GH workflows for both master and 3.2.x.

I did also upgrade the Jenkins jobs at

https://ci-builds.apache.org/job/OpenJPA/

to publish SNAPSHOT artifacts.

Incidentally, I've noticed a few dependabot alerts about out-of-date
dependencies: shall I go ahead and enable it?
We've done the same in other ASF projects.

Regards.

Il giorno dom 7 mag 2023 alle ore 08:21 Francesco Chicchiriccò <
francesco.chicchiri...@tirasa.net> ha scritto:

> I went ahead and updated GH workflows for both master and 3.2.x.
>
> Incidentally, I've noticed a few dependabot alerts about out-of-date
> dependencies: shall I go ahead and enable it?
> We've done the same in other ASF projects.
>
> Regards.
>
> Il giorno sab 6 mag 2023 alle ore 11:04 Mark Struberg
>  ha scritto:
>
>> Thanks all!
>>
>> I've had some troubles with Serp, so I rewrote parts to native ASM.
>> Tempted to also replace the rest of Serp. But that would need a bit time
>> and a good part of reviews.
>> Our tests are really good, but still I cannot rule out that I broke
>> something. Hope we will catch everything.
>> So I'd be really happy about feedback.
>>
>> Do you think we could push further in that direction of completely
>> getting rid of Serp?
>> Maybe some pair programming?
>>
>> LieGrue,
>> strub
>>
>>
>> > Am 06.05.2023 um 09:05 schrieb Francesco Chicchiriccò <
>> ilgro...@apache.org>:
>> >
>> > Very cool, thanks Mark!
>> >
>> > Il sab 6 mag 2023, 08:55 Mark Struberg  ha
>> > scritto:
>> >
>> >> Hi!
>> >>
>> >> I've done the first steps necessary to move to the jakarta namespace
>> >> natively and update the minimum Java version to 11.
>> >> I'll move the current master branch to a 3.2.x branch and merge my
>> >> fb_jakartaee branch into master today.
>> >> Right now I'm deploying a 4.0.0-SNAPSHOT version from that branch to
>> the
>> >> ASF snapshots repo.
>> >>
>> >> LieGrue,
>> >> strub
>>
>>
>
> --
> Francesco Chicchiriccò
> Tel +393290573276
>
> Amministratore unico @ Tirasa S.r.l.
> Viale Vittoria Colonna 97 - 65127 Pescara
> Tel +39 0859116307 / FAX +39 085973
> http://www.tirasa.net
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
> "To Iterate is Human, to Recurse, Divine"
> (James O. Coplien, Bell Labs)
>


-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [ANN] master will soon be 4.0.0-SNAOPSHOT (JakartaEE)

[Francesco Chicchiriccò]

I went ahead and updated GH workflows for both master and 3.2.x.

Incidentally, I've noticed a few dependabot alerts about out-of-date
dependencies: shall I go ahead and enable it?
We've done the same in other ASF projects.

Regards.

Il giorno sab 6 mag 2023 alle ore 11:04 Mark Struberg
 ha scritto:

> Thanks all!
>
> I've had some troubles with Serp, so I rewrote parts to native ASM.
> Tempted to also replace the rest of Serp. But that would need a bit time
> and a good part of reviews.
> Our tests are really good, but still I cannot rule out that I broke
> something. Hope we will catch everything.
> So I'd be really happy about feedback.
>
> Do you think we could push further in that direction of completely getting
> rid of Serp?
> Maybe some pair programming?
>
> LieGrue,
> strub
>
>
> > Am 06.05.2023 um 09:05 schrieb Francesco Chicchiriccò <
> ilgro...@apache.org>:
> >
> > Very cool, thanks Mark!
> >
> > Il sab 6 mag 2023, 08:55 Mark Struberg  ha
> > scritto:
> >
> >> Hi!
> >>
> >> I've done the first steps necessary to move to the jakarta namespace
> >> natively and update the minimum Java version to 11.
> >> I'll move the current master branch to a 3.2.x branch and merge my
> >> fb_jakartaee branch into master today.
> >> Right now I'm deploying a 4.0.0-SNAPSHOT version from that branch to the
> >> ASF snapshots repo.
> >>
> >> LieGrue,
> >> strub
>
>

-- 
Francesco Chicchiriccò
Tel +393290573276

Amministratore unico @ Tirasa S.r.l.
Viale Vittoria Colonna 97 - 65127 Pescara
Tel +39 0859116307 / FAX +39 085973
http://www.tirasa.net

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

"To Iterate is Human, to Recurse, Divine"
(James O. Coplien, Bell Labs)

Re: [ANN] master will soon be 4.0.0-SNAOPSHOT (JakartaEE)

[Francesco Chicchiriccò]

Very cool, thanks Mark!

Il sab 6 mag 2023, 08:55 Mark Struberg  ha
scritto:

> Hi!
>
> I've done the first steps necessary to move to the jakarta namespace
> natively and update the minimum Java version to 11.
> I'll move the current master branch to a 3.2.x branch and merge my
> fb_jakartaee branch into master today.
> Right now I'm deploying a 4.0.0-SNAPSHOT version from that branch to the
> ASF snapshots repo.
>
> LieGrue,
> strub

Re: Using OpenJPA with Spring Boot 3?

[Francesco Chicchiriccò]

On 28/12/22 10:44, Romain Manni-Bucau wrote:

A bit from memory so can miss a few details but think adding openjpa with
jakarta classifier as a dependency of the plugin does the trick.


That's correct, thank you.

Again, FTR:

    
  org.apache.openjpa
openjpa-maven-plugin
  ${openjpa.version}
  
    
  org.apache.openjpa
  openjpa
  ${openjpa.version}
  jakarta
    
    
  jakarta.persistence
jakarta.persistence-api
  3.1.0
    
    
  jakarta.transaction
jakarta.transaction-api
  2.0.1
    
  
    

Regards.


Le mer. 28 déc. 2022 à 10:40, Francesco Chicchiriccò 
a écrit :


Thank you.

FTR this is my current setup:

root pom.xml:


  org.apache.openjpa
  openjpa
  ${openjpa.version}
  jakarta
  

  org.apache.xbean
  xbean-asm9-shaded


  org.apache.commons
  commons-pool2


org.apache.geronimo.specs
geronimo-jpa_2.2_spec


org.apache.geronimo.specs
geronimo-jta_1.1_spec


org.apache.geronimo.specs
geronimo-jms_1.1_spec

  


core/persistence-jpa/pom.xml:

  
jakarta.persistence
jakarta.persistence-api
  
  
jakarta.transaction
jakarta.transaction-api
  
  
org.apache.openjpa
openjpa
jakarta
  

I am having issues now with entity enhancement.

I see log messages like as

[BuilderThread 0] openjpa.Tool - Enhancer running on type "class
org.apache.syncope.core.persistence.jpa.entity.group.JPAGPlainAttr".

but afterwards:

[BuilderThread 0] openjpa.Tool - No metadata was found for 134 classes;
they have been enhanced as persistence-aware. If you intended for any of
these classes to be persistence-capable, then this means that OpenJPA could
not find any metadata for those classes.

I guess this is because of the namespace mismatch between
openjpa-maven-plugin and the openjpa dependency as declared above.

Regards.

On 28/12/22 08:52, Romain Manni-Bucau wrote:

Use


https://repo.maven.apache.org/maven2/org/apache/openjpa/openjpa/3.2.2/openjpa-3.2.2-jakarta.jar

and exclude transitive deps.

Le mer. 28 déc. 2022 à 08:45, Francesco Chicchiriccò <

ilgro...@apache.org>

a écrit :


On 27/12/22 17:14, Romain Manni-Bucau wrote:

Yes, think you should either move to openjpa-all shade or generate the
class with asm at build time (guess switching the main dep is easier).

Unfortunately just switching to openjpa-all does not change the errors I
am reporting below.

When I look inside




https://repo1.maven.org/maven2/org/apache/openjpa/openjpa-all/3.2.2/openjpa-all-3.2.2.jar

what should I be able to see exactly? e.g. what would be the effect of

the

relocation settings in

https://github.com/apache/openjpa/blob/master/openjpa/pom.xml#L100

?

In case this option is not viable: would you be able to suggest how to
proceed with asm-based alternative you are mentioning above?
TIA.

Regards.


Le mar. 27 déc. 2022 à 17:06, Maxim Solodovnik 

a

écrit :


Sorry fir top-posting

Maybe we shall release Jakarta version?
As 4.x for ex?

from mobile (sorry for typos ;)


On Tue, Dec 27, 2022, 23:01 Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 27/12/22 16:50, Romain Manni-Bucau wrote:

Hi,

Well I guess the jakarta shade should handle jakarta properly else

user

can

use what he wants and finally worse case you can still integrate the
mapping in spring glue code (not sure you have something particular

in

mind

so shouting in the wind ;)).

For instance, I would like to keep these classes [1] working, but

when

I

attempt to build it, I am receiving the following errors:

[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[56,55]

cannot access javax.persistence.EntityTransaction
[ERROR]   class file for javax.persistence.EntityTransaction not

found

[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[89,34]

no suitable method found for cast(jakarta.persistence.EntityManager)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManagerFactory)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.EntityManagerFactory)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManager)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.EntityManager)

Re: Using OpenJPA with Spring Boot 3?

[Francesco Chicchiriccò]

Thank you.

FTR this is my current setup:

root pom.xml:

  
    org.apache.openjpa
    openjpa
    ${openjpa.version}
    jakarta
    
  
    org.apache.xbean
    xbean-asm9-shaded
  
  
    org.apache.commons
    commons-pool2
  
  
org.apache.geronimo.specs
geronimo-jpa_2.2_spec
  
  
org.apache.geronimo.specs
geronimo-jta_1.1_spec
  
  
org.apache.geronimo.specs
geronimo-jms_1.1_spec
  
    
  

core/persistence-jpa/pom.xml:

    
  jakarta.persistence
  jakarta.persistence-api
    
    
  jakarta.transaction
  jakarta.transaction-api
    
    
  org.apache.openjpa
  openjpa
  jakarta
    

I am having issues now with entity enhancement.

I see log messages like as

[BuilderThread 0] openjpa.Tool - Enhancer running on type "class 
org.apache.syncope.core.persistence.jpa.entity.group.JPAGPlainAttr".

but afterwards:

[BuilderThread 0] openjpa.Tool - No metadata was found for 134 classes; they 
have been enhanced as persistence-aware. If you intended for any of these 
classes to be persistence-capable, then this means that OpenJPA could not find 
any metadata for those classes.

I guess this is because of the namespace mismatch between openjpa-maven-plugin 
and the openjpa dependency as declared above.

Regards.

On 28/12/22 08:52, Romain Manni-Bucau wrote:

Use
https://repo.maven.apache.org/maven2/org/apache/openjpa/openjpa/3.2.2/openjpa-3.2.2-jakarta.jar
and exclude transitive deps.

Le mer. 28 déc. 2022 à 08:45, Francesco Chicchiriccò 
a écrit :


On 27/12/22 17:14, Romain Manni-Bucau wrote:

Yes, think you should either move to openjpa-all shade or generate the
class with asm at build time (guess switching the main dep is easier).

Unfortunately just switching to openjpa-all does not change the errors I
am reporting below.

When I look inside


https://repo1.maven.org/maven2/org/apache/openjpa/openjpa-all/3.2.2/openjpa-all-3.2.2.jar

what should I be able to see exactly? e.g. what would be the effect of the
relocation settings in

https://github.com/apache/openjpa/blob/master/openjpa/pom.xml#L100

?

In case this option is not viable: would you be able to suggest how to
proceed with asm-based alternative you are mentioning above?
TIA.

Regards.


Le mar. 27 déc. 2022 à 17:06, Maxim Solodovnik  a
écrit :


Sorry fir top-posting

Maybe we shall release Jakarta version?
As 4.x for ex?

from mobile (sorry for typos ;)


On Tue, Dec 27, 2022, 23:01 Francesco Chicchiriccò 
On 27/12/22 16:50, Romain Manni-Bucau wrote:

Hi,

Well I guess the jakarta shade should handle jakarta properly else

user

can

use what he wants and finally worse case you can still integrate the
mapping in spring glue code (not sure you have something particular in

mind

so shouting in the wind ;)).

For instance, I would like to keep these classes [1] working, but when

I

attempt to build it, I am receiving the following errors:

[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[56,55]

cannot access javax.persistence.EntityTransaction
[ERROR]   class file for javax.persistence.EntityTransaction not found
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[89,34]

no suitable method found for cast(jakarta.persistence.EntityManager)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManagerFactory)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.EntityManagerFactory)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManager)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.EntityManager)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.Query)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.Query)
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[46,61]

cannot access javax.persistence.spi.PersistenceProvider
[ERROR]   class file for javax.persistence.spi.PersistenceProvider not
found
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[122,46]

incompatible types:


java.lang.Class

cannot be converted to java.lang.Class
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[127,39]

incompatible types:
java.lang.Class
cannot be converted to java.

Re: Using OpenJPA with Spring Boot 3?

[Francesco Chicchiriccò]

On 27/12/22 17:14, Romain Manni-Bucau wrote:

Yes, think you should either move to openjpa-all shade or generate the
class with asm at build time (guess switching the main dep is easier).


Unfortunately just switching to openjpa-all does not change the errors I am 
reporting below.

When I look inside

https://repo1.maven.org/maven2/org/apache/openjpa/openjpa-all/3.2.2/openjpa-all-3.2.2.jar

what should I be able to see exactly? e.g. what would be the effect of the 
relocation settings in

https://github.com/apache/openjpa/blob/master/openjpa/pom.xml#L100

?

In case this option is not viable: would you be able to suggest how to proceed 
with asm-based alternative you are mentioning above?
TIA.

Regards.


Le mar. 27 déc. 2022 à 17:06, Maxim Solodovnik  a
écrit :


Sorry fir top-posting

Maybe we shall release Jakarta version?
As 4.x for ex?

from mobile (sorry for typos ;)


On Tue, Dec 27, 2022, 23:01 Francesco Chicchiriccò 
wrote:


On 27/12/22 16:50, Romain Manni-Bucau wrote:

Hi,

Well I guess the jakarta shade should handle jakarta properly else user

can

use what he wants and finally worse case you can still integrate the
mapping in spring glue code (not sure you have something particular in

mind

so shouting in the wind ;)).

For instance, I would like to keep these classes [1] working, but when I
attempt to build it, I am receiving the following errors:

[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[56,55]

cannot access javax.persistence.EntityTransaction
[ERROR]   class file for javax.persistence.EntityTransaction not found
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[89,34]

no suitable method found for cast(jakarta.persistence.EntityManager)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManagerFactory)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.EntityManagerFactory)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManager)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.EntityManager)
[ERROR] method


org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.Query)

is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager

cannot

be converted to javax.persistence.Query)
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[46,61]

cannot access javax.persistence.spi.PersistenceProvider
[ERROR]   class file for javax.persistence.spi.PersistenceProvider not
found
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[122,46]

incompatible types:


java.lang.Class

cannot be converted to java.lang.Class
[ERROR]


/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[127,39]

incompatible types:
java.lang.Class
cannot be converted to java.lang.Class

Given Maxim's and yours answer about openjpa-all, I believe I'll need to
either depend on that or shade OpenJPA artifacts right on Syncope poms:
correct?

Regards.

[1]


https://github.com/apache/syncope/blob/master/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor

Le mar. 27 déc. 2022 à 16:21, Francesco Chicchiriccò <

ilgro...@apache.org>

a écrit :


Hi all,
so let's suppone one has the weird idea of adding OpenJPA to a Spring

Boot

3 project.

Do we already an idea about how to handle the javax.persistence.*  Vs
jakarta.persistence.* conflicts?

Thanks in advance.
Regards.


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Using OpenJPA with Spring Boot 3?

[Francesco Chicchiriccò]

On 27/12/22 17:06, Maxim Solodovnik wrote:

Sorry fir top-posting

Maybe we shall release Jakarta version?
As 4.x for ex?


+1

I think it would be way better for anyone willing to use OpenJPA with Spring 
Boot 3 and fwd.

Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Using OpenJPA with Spring Boot 3?

[Francesco Chicchiriccò]

On 27/12/22 16:50, Romain Manni-Bucau wrote:

Hi,

Well I guess the jakarta shade should handle jakarta properly else user can
use what he wants and finally worse case you can still integrate the
mapping in spring glue code (not sure you have something particular in mind
so shouting in the wind ;)).


For instance, I would like to keep these classes [1] working, but when I 
attempt to build it, I am receiving the following errors:

[ERROR] 
/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[56,55]
 cannot access javax.persistence.EntityTransaction
[ERROR]   class file for javax.persistence.EntityTransaction not found
[ERROR] 
/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaDialect.java:[89,34]
 no suitable method found for cast(jakarta.persistence.EntityManager)
[ERROR] method 
org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManagerFactory)
 is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager cannot be 
converted to javax.persistence.EntityManagerFactory)
[ERROR] method 
org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.EntityManager)
 is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager cannot be 
converted to javax.persistence.EntityManager)
[ERROR] method 
org.apache.openjpa.persistence.OpenJPAPersistence.cast(javax.persistence.Query) 
is not applicable
[ERROR]   (argument mismatch; jakarta.persistence.EntityManager cannot be 
converted to javax.persistence.Query)
[ERROR] 
/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[46,61]
 cannot access javax.persistence.spi.PersistenceProvider
[ERROR]   class file for javax.persistence.spi.PersistenceProvider not found
[ERROR] 
/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[122,46]
 incompatible types: 
java.lang.Class cannot 
be converted to java.lang.Class
[ERROR] 
/home/ilgrosso/work/syncope/fork/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor/OpenJpaVendorAdapter.java:[127,39]
 incompatible types: 
java.lang.Class cannot be 
converted to java.lang.Class

Given Maxim's and yours answer about openjpa-all, I believe I'll need to either 
depend on that or shade OpenJPA artifacts right on Syncope poms: correct?

Regards.

[1] 
https://github.com/apache/syncope/blob/master/core/persistence-jpa/src/main/java/org/springframework/orm/jpa/vendor


Le mar. 27 déc. 2022 à 16:21, Francesco Chicchiriccò 
a écrit :


Hi all,
so let's suppone one has the weird idea of adding OpenJPA to a Spring Boot
3 project.

Do we already an idea about how to handle the javax.persistence.*  Vs
jakarta.persistence.* conflicts?

Thanks in advance.
Regards.


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Using OpenJPA with Spring Boot 3?

[Francesco Chicchiriccò]

On 27/12/22 16:50, Maxim Solodovnik wrote:

I guess this code should do the job:
https://github.com/apache/openjpa/blob/master/openjpa/pom.xml#L100


Agree, but only for openjpa-all as it seems, correct?

Regards.


On Tue, 27 Dec 2022 at 22:21, Francesco Chicchiriccò
 wrote:

Hi all,
so let's suppone one has the weird idea of adding OpenJPA to a Spring Boot 3 
project.

Do we already an idea about how to handle the javax.persistence.*  Vs 
jakarta.persistence.* conflicts?

Thanks in advance.
Regards.


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Using OpenJPA with Spring Boot 3?

[Francesco Chicchiriccò]

Hi all,
so let's suppone one has the weird idea of adding OpenJPA to a Spring Boot 3 
project.

Do we already an idea about how to handle the javax.persistence.*  Vs 
jakarta.persistence.* conflicts?

Thanks in advance.
Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Fwd: [ANN] Apache OpenJPA 3.2.2

[Francesco Chicchiriccò]

Hi Craig,
thanks for reporting.

It seems I made some mistakes during SVN swap between staging and dist areas.
The correct ASC files should be in place now.

Sorry for inconvenience.

Question: shall I send again the announcement e-mail below?
Regards.

On 19/03/22 18:46, Private List Moderation wrote:

Hi,

I think there is a problem with the download page.
https://openjpa.apache.org/downloads

The signatures
apache-openjpa-3.2.2-binary.zip.asc and
apache-openjpa-3.2.2-source.zip.asc
seem to be 12MB when they should be about 1KB like the signatures for previous 
releases.

Can you please check this out and let us know?

Warm regards,
Craig


Begin forwarded message:

From: Francesco Chicchiriccò 
Subject: [ANN] Apache OpenJPA 3.2.2
Date: March 19, 2022 at 7:55:01 AM PDT
To: announce 

The Apache OpenJPA team is pleased to announce the release of OpenJPA 3.2.2

Apache OpenJPA is a persistent object management kernel for databases, 
relational as well as non-relational. For relational databases, OpenJPA is 
compliant to the Java Persistence Architecture (JPA) version 2.2. OpenJPA runs 
in stand-alone Java SE as well as  containers e.g Java EE, Tomcat, Spring or 
OSGi.

The release will be available within 24h from Central Maven Repository and:
https://openjpa.apache.org/downloads

Read the full change log available here:
https://openjpa.apache.org/builds/3.2.2/apache-openjpa/RELEASE-NOTES.html

We welcome your help and feedback. For more information on how to report 
problems, and to get involved, visit the project website at

https://openjpa.apache.org/

The Apache OpenJPA Team


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: KEYS Was: [VOTE] Apache OpenJPA 3.2.2

[Francesco Chicchiriccò]

On 19/03/22 13:10, Enrico Olivelli wrote:

Francesco,
Thanks for driving this release.
I am sorry I missed the thread and I dis not participate.
I have one question, see below


Il Mer 16 Mar 2022, 10:32 Francesco Chicchiriccò  ha
scritto:


I've created a 3.2.2 release, with the following artifacts up for a vote:

GIT source tag (e5933d6aeed8463b01d1a075d611e336aacddc72):

https://gitbox.apache.org/repos/asf?p=openjpa.git;a=commit;h=e5933d6aeed8463b01d1a075d611e336aacddc72

Staging artifacts:
https://dist.apache.org/repos/dist/dev/openjpa/3.2.2

Maven staging repo:
https://repository.apache.org/content/repositories/orgapacheopenjpa-1011/

PGP release keys (signed using ABCDEFG):
https://downloads.apache.org/syncope/KEYS


This looks like to be hosted not in the OpenJPA space but in Syncope

Is this a problem?
How can OpenJPA users validate the artifacts?

Maybe your KEY is already in the OpenJPA KEYS file, but I just wanted to
clarify


My bad, Enrico, just a dumb copy / paste error, thanks for reporting.

My own key 273DF287 was used to sign the release artifacts and is actually 
reported by

https://downloads.apache.org/openjpa/KEYS

as well.

Regards.


Vote will be open for 72 hours.

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Here's my +1
Regards.


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

[ANN] Apache OpenJPA 3.2.2

[Francesco Chicchiriccò]

The Apache OpenJPA team is pleased to announce the release of OpenJPA 3.2.2

Apache OpenJPA is a persistent object management kernel for databases, 
relational as well as non-relational. For relational databases, OpenJPA is 
compliant to the Java Persistence Architecture (JPA) version 2.2. OpenJPA runs 
in stand-alone Java SE as well as  containers e.g Java EE, Tomcat, Spring or 
OSGi.

The release will be available within 24h from Central Maven Repository and:
https://openjpa.apache.org/downloads

Read the full change log available here:
https://openjpa.apache.org/builds/3.2.2/apache-openjpa/RELEASE-NOTES.html

We welcome your help and feedback. For more information on how to report 
problems, and to get involved, visit the project website at

https://openjpa.apache.org/

The Apache OpenJPA Team

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

[RESULT] [VOTE] Apache OpenJPA 3.2.2

[Francesco Chicchiriccò]

Hi all,
after 72 hours, the vote for OpenJPA 3.2.2 [1] *passes* with 3 PMC + 2 non-PMC 
votes.

+1 (PMC / binding)
* Romain Manni-Bucau
* Maxim Solodovnik
* Francesco Chicchiriccò

+1 (non binding)
* Jean-Baptiste Onofré
* Jean-Louis Monteiro

0


-1


Thanks to everyone participating.

I will now copy this release to OpenJPA' dist directory and promote the 
artifacts to the central Maven repository.

Best regards.

[1] https://lists.apache.org/thread/onpnzbcr6kch78l7n3wkbt2y90d1jydv

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

[VOTE] Apache OpenJPA 3.2.2

[Francesco Chicchiriccò]

I've created a 3.2.2 release, with the following artifacts up for a vote:

GIT source tag (e5933d6aeed8463b01d1a075d611e336aacddc72):
https://gitbox.apache.org/repos/asf?p=openjpa.git;a=commit;h=e5933d6aeed8463b01d1a075d611e336aacddc72

Staging artifacts:
https://dist.apache.org/repos/dist/dev/openjpa/3.2.2

Maven staging repo:
https://repository.apache.org/content/repositories/orgapacheopenjpa-1011/

PGP release keys (signed using ABCDEFG):
https://downloads.apache.org/syncope/KEYS

Vote will be open for 72 hours.

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Here's my +1
Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Any chance to release 3.2.2 anytime soon?

[Francesco Chicchiriccò]

Thanks JB.

I was more asking in case anyone had some unfinished work.

Regards.

On 16/03/22 06:12, Jean-Baptiste Onofré wrote:

Hi

It sounds good to me. I don’t see any concern to have more releases when
required

Regards
JB

Le mer. 16 mars 2022 à 06:07, Francesco Chicchiriccò 
a écrit :


Thanks Maxim.

Anyone else?

Regards.

On 11/03/22 10:50, Maxim Solodovnik wrote:

+1 :)
Let it be more releases

from mobile (sorry for typos ;)


On Fri, Mar 11, 2022, 16:03 Francesco Chicchiriccò 
wrote:


Hi all,
I know 3.2.1 is quite fresh, but I've found a couple of small but
important misses in the recently added support for Java 8 Date / Time

API

[1][2], while moving away Syncope from java.util.Date.

Nevertheless to say, without these two fixes there is no way for Syncope
to make things working, so I'd say we have two options there:

1. depend on OpenJPA 3.2.2-SNAPSHOT (as we're currently doing)
2. keep dependency to OpenJPA 3.2.1 but blind copy the fixed classes

into

Syncope source tree and remove them when 3.2.2 is out

I largely prefer option (1) but this would imply that OpenJPA 3.2.2 is
released in the short term, otherwise we have no option but (2).

WDYT?
Regards.

[1]


https://github.com/apache/openjpa/commit/f228d2c259f23fd17a328f719f2908cdc9ff6f52

[2]


https://github.com/apache/openjpa/commit/a605d872e5b4d929d1f4864eba3aa8aebcee35a7


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Any chance to release 3.2.2 anytime soon?

[Francesco Chicchiriccò]

Thanks Maxim.

Anyone else?

Regards.

On 11/03/22 10:50, Maxim Solodovnik wrote:

+1 :)
Let it be more releases

from mobile (sorry for typos ;)


On Fri, Mar 11, 2022, 16:03 Francesco Chicchiriccò 
wrote:


Hi all,
I know 3.2.1 is quite fresh, but I've found a couple of small but
important misses in the recently added support for Java 8 Date / Time API
[1][2], while moving away Syncope from java.util.Date.

Nevertheless to say, without these two fixes there is no way for Syncope
to make things working, so I'd say we have two options there:

1. depend on OpenJPA 3.2.2-SNAPSHOT (as we're currently doing)
2. keep dependency to OpenJPA 3.2.1 but blind copy the fixed classes into
Syncope source tree and remove them when 3.2.2 is out

I largely prefer option (1) but this would imply that OpenJPA 3.2.2 is
released in the short term, otherwise we have no option but (2).

WDYT?
Regards.

[1]
https://github.com/apache/openjpa/commit/f228d2c259f23fd17a328f719f2908cdc9ff6f52
[2]
https://github.com/apache/openjpa/commit/a605d872e5b4d929d1f4864eba3aa8aebcee35a7


--
Francesco Chicchiriccò
Tel +393290573276

Amministratore unico @ Tirasa S.r.l.
Viale Vittoria Colonna 97 - 65127 Pescara
Tel +39 0859116307 / FAX +39 085973
http://www.tirasa.net

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

"To Iterate is Human, to Recurse, Divine"
(James O. Coplien, Bell Labs)

[DISCUSS] Any chance to release 3.2.2 anytime soon?

[Francesco Chicchiriccò]

Hi all,
I know 3.2.1 is quite fresh, but I've found a couple of small but important 
misses in the recently added support for Java 8 Date / Time API [1][2], while 
moving away Syncope from java.util.Date.

Nevertheless to say, without these two fixes there is no way for Syncope to 
make things working, so I'd say we have two options there:

1. depend on OpenJPA 3.2.2-SNAPSHOT (as we're currently doing)
2. keep dependency to OpenJPA 3.2.1 but blind copy the fixed classes into 
Syncope source tree and remove them when 3.2.2 is out

I largely prefer option (1) but this would imply that OpenJPA 3.2.2 is released 
in the short term, otherwise we have no option but (2).

WDYT?
Regards.

[1] 
https://github.com/apache/openjpa/commit/f228d2c259f23fd17a328f719f2908cdc9ff6f52
[2] 
https://github.com/apache/openjpa/commit/a605d872e5b4d929d1f4864eba3aa8aebcee35a7

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [VOTE] Release Apache OpenJPA 3.2.1

[Francesco Chicchiriccò]

On 03/02/22 11:17, Romain Manni-Bucau wrote:

Hi all,

Here is the late vote for Apache OpenJPA 3.2.1.

here is the changelog:

[image: Critical] [image: Bug] OPENJPA-2891
<https://issues.apache.org/jira/browse/OPENJPA-2891> @Generated annotation
cannot be disabled for static metamodel
<https://issues.apache.org/jira/browse/OPENJPA-2891> Unassigned RESOLVED
[image: Major] [image: Bug] OPENJPA-2614
<https://issues.apache.org/jira/browse/OPENJPA-2614> First rollback after
application start does not work under certain circumstances
<https://issues.apache.org/jira/browse/OPENJPA-2614> Mark Struberg
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=struberg>
RESOLVED
[image: Major] [image: Improvement] OPENJPA-2875
<https://issues.apache.org/jira/browse/OPENJPA-2875> JPA Provider must
filter out other JPA Providers
<https://issues.apache.org/jira/browse/OPENJPA-2875> Unassigned RESOLVED
[image: Major] [image: Bug] OPENJPA-2876
<https://issues.apache.org/jira/browse/OPENJPA-2876> running 'refresh'
schema action creates wrong SQL output
<https://issues.apache.org/jira/browse/OPENJPA-2876> Mark Struberg
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=struberg>
RESOLVED
[image: Major] [image: Bug] OPENJPA-2877
<https://issues.apache.org/jira/browse/OPENJPA-2877> [JPA-2.1] implement
AttributeConverter <https://issues.apache.org/jira/browse/OPENJPA-2877>
Unassigned RESOLVED
[image: Major] [image: Improvement] OPENJPA-2881
<https://issues.apache.org/jira/browse/OPENJPA-2881> runtime exception in
org.apache.openjpa.lib.meta.XMLMetaDataParser.parseNewResource
<https://issues.apache.org/jira/browse/OPENJPA-2881> Maxim Solodovnik
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=solomax>
RESOLVED
[image: Major] [image: Bug] OPENJPA-2883
<https://issues.apache.org/jira/browse/OPENJPA-2883> UseTriggersForAutoAssign
in Oracle seems to be broken
<https://issues.apache.org/jira/browse/OPENJPA-2883> Maxim Solodovnik
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=solomax>
RESOLVED
[image: Major] [image: Task] OPENJPA-2884
<https://issues.apache.org/jira/browse/OPENJPA-2884>
javax.annotation.processing
shouldn't be relocated in jakarta shade
<https://issues.apache.org/jira/browse/OPENJPA-2884> Romain Manni-Bucau
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau>
RESOLVED
[image: Major] [image: Task] OPENJPA-2885
<https://issues.apache.org/jira/browse/OPENJPA-2885> Make openjpa-junit5
support jakarta namespace
<https://issues.apache.org/jira/browse/OPENJPA-2885> Romain Manni-Bucau
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau>
RESOLVED
[image: Major] [image: Bug] OPENJPA-2889
<https://issues.apache.org/jira/browse/OPENJPA-2889> commons-pool2 bundle
version defined in karaf features repository is not aligned with the actual
version used by openjpa <https://issues.apache.org/jira/browse/OPENJPA-2889>
Unassigned RESOLVED
[image: Major] [image: Improvement] OPENJPA-2893
<https://issues.apache.org/jira/browse/OPENJPA-2893> H2 2.x is not working
with OpenJPA <https://issues.apache.org/jira/browse/OPENJPA-2893> Maxim
Solodovnik
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=solomax>
RESOLVED
[image: Major] [image: Bug] OPENJPA-2896
<https://issues.apache.org/jira/browse/OPENJPA-2896> Automatic module name
is not set for bundles
<https://issues.apache.org/jira/browse/OPENJPA-2896> Maxim
Solodovnik
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=solomax>
RESOLVED
[image: Minor] [image: Bug] OPENJPA-2882
<https://issues.apache.org/jira/browse/OPENJPA-2882> Exception passing
javax.persistence.* String values to createEntityManager(Map)
<https://issues.apache.org/jira/browse/OPENJPA-2882> Unassigned RESOLVED

Side note: it fixes a minor issue enabling to fully use OpenJPA with
jakarta namespace on any project.

Tag:
https://gitbox.apache.org/repos/asf?p=openjpa.git;a=commit;h=000c065dbe8ceb4589fc1f789a37b8d68af6311e
Staging:
https://repository.apache.org/content/repositories/orgapacheopenjpa-1010/
Dist: https://dist.apache.org/repos/dist/dev/openjpa/
My key is the same than for other votes.

Please vote:

[ ] +1
[ ] -1 ${cause}


+1

Tested with Apache Syncope against H2, PostgreSQL, MySQL, MariaDB, MS SQL 
Server and Oracle DB.

Thanks for carrying this forward.
Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [VOTE] Release Apache OpenJPA-3.2.0

[Francesco Chicchiriccò]

On 10/05/21 21:05, Mark Struberg wrote:

Hi lords and ladies!

I'd like to call a VOTE on releasing Apache OpenJPA-3.2.0.
We fixed a ton of tickets and had an extended testing period.

The list of resolved tickets is too long, to dump into here. I hope it's ok to 
just link to the release notes:
https://github.com/apache/openjpa/blob/master/openjpa-project/RELEASE-NOTES.html#L133 
<https://github.com/apache/openjpa/blob/master/openjpa-project/RELEASE-NOTES.html#L133>



The staging repository is
https://repository.apache.org/content/repositories/orgapacheopenjpa-1009/ 
<https://repository.apache.org/content/repositories/orgapacheopenjpa-1009/>

The source zip can be found at
https://repository.apache.org/content/repositories/orgapacheopenjpa-1009/org/apache/openjpa/apache-openjpa/3.2.0/
 
<https://repository.apache.org/content/repositories/orgapacheopenjpa-1009/org/apache/openjpa/apache-openjpa/3.2.0/>
sha1 is 82a04e28849aeb87d2e1d78224be7ae94685f688

Please VOTE


[+1] go for it!
[+0] meh, don't care
[-1] whoops stop, there is a ${showstopper}


+1

Besides other checks, I've tested the artifacts in Syncope master branch with 
H2, PostgreSQL and MySQL: all worked flawlessly.

Thanks Mark!
Regards.


The VOTE is open for 72h

txs and LieGrue,
strub


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Errors after recent commits

[Francesco Chicchiriccò]

On 22/04/21 19:38, Romain Manni-Bucau wrote:

Im not sure the gain to have it marked synthetic since other cases will be
problematic anyway with our proxies so I guess we can leave it this way.


+1
Regards.



Le jeu. 22 avr. 2021 à 19:07, Mark Struberg  a
écrit :


Hi!

Thanks for catching this!

Does this mean we should rather close 2800 as won't fix?

LieGrue,
strub


Am 21.04.2021 um 15:43 schrieb Romain Manni-Bucau 
ilgro...@apache.org>

a écrit :


I think that the issue is occurring when:

1. a parent entity is enhanced in a module
2. a child entity is enhanced in another module

In my case, the error was occurring only for child entities in a

different

module.

Regards.

On 21/04/21 13:46, Romain Manni-Bucau wrote:

Hi,

I think it is ok to revert when it breaks and reapply with the fix.
I tested on our opentrader application where there is a hierarchy with

Ask

entity and the method seems well generated with Mark's commit so I

guess

we

need to refine the actual issue.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <

https://github.com/rmannibucau> |

LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<

https://www.packtpub.com/application-development/java-ee-8-high-performance



Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò <

ilgro...@apache.org>

a écrit :


Hi again,
I went ahead, revert the commit and re-opened OPENJPA-2800.

I am not sure to fully understand what is the actual reason for

failure,

though...

Regards.

On 21/04/21 11:29, Francesco Chicchiriccò wrote:

Update: I've found the actual issues is that the pcSetDetachedState()

method is not generated in the parent class AbstractProvidedKeyEntity;

as

you can see from

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245

in fact, the method was still generated on Monday, hence child class

JPACamelRoute was fine.

Regards.

On 21/04/21 11:06, Francesco Chicchiriccò wrote:

Hi,
from the last successful build that was deployed to repository.a.o

by

Jenkins (the day before yesterday, Monday 19th):

https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar

I did decompile a sample entity class:

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470

where, as you can see, the method

pcSetDetachedState(java.lang.Object) from

org.apache.openjpa.enhance.PersistenceCapable

is not implemented: hence, the Maven build error reported below is

effectively correct, even though this was not happening until Monday

19th.

If I revert locally the last commit by Mark:



https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df

all is back working again.

Is it ok if I go ahead and revert that commit? Meanwhile, we can

look

for a proper solution.

WDYT?

Regards.

On 20/04/21 16:02, Romain Manni-Bucau wrote:

Hi Francesco,

Did you try to decompile previous and current version (with jd-gui

for

example) to see the diff?
Normally Mark only changed synthetic flag on fields, nothing else

should

have changed AFAIK.

Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <

ilgro...@apache.org>

a écrit :


Hi there,
with latest 3.1.3-SNAPSHOT artifacts I am getting errors while

building

Syncope.

In particular, we have a Maven module [1] which runs
openjpa-maven-plugin:enhance [2] as part of the build, and several

modules

(like [3][4][5] and others) which are depending on [1], adding

more

entities and also running openjpa-maven-plugin:enhance

All this used to work fine until this morning (and still works

fine

with

OpenJPA 3.1.2 on other Syncope branches); now [1] is still working

fine,

but building other modules give errors like as

[ERROR]


/home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]

org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is

not

abstract and does not override abstract method
pcSetDetachedState(java.lang.Object) in
org.apache.openjpa.enhance.PersistenceCapable

Could you please shed some light? Thanks!
Regards.

[1]

https://github.com/apache/syncope/tree/master/core/persistence-jpa

[2]


https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176

[3]


https://github.com/apache/syncope/tree/master/core/persistence-jpa-json

[4]


https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa

[5]


https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Errors after recent commits

[Francesco Chicchiriccò]

I think that the issue is occurring when:

1. a parent entity is enhanced in a module
2. a child entity is enhanced in another module

In my case, the error was occurring only for child entities in a different 
module.

Regards.

On 21/04/21 13:46, Romain Manni-Bucau wrote:

Hi,

I think it is ok to revert when it breaks and reapply with the fix.
I tested on our opentrader application where there is a hierarchy with Ask
entity and the method seems well generated with Mark's commit so I guess we
need to refine the actual issue.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò 
a écrit :


Hi again,
I went ahead, revert the commit and re-opened OPENJPA-2800.

I am not sure to fully understand what is the actual reason for failure,
though...

Regards.

On 21/04/21 11:29, Francesco Chicchiriccò wrote:

Update: I've found the actual issues is that the pcSetDetachedState()

method is not generated in the parent class AbstractProvidedKeyEntity; as
you can see from



https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245

in fact, the method was still generated on Monday, hence child class

JPACamelRoute was fine.

Regards.

On 21/04/21 11:06, Francesco Chicchiriccò wrote:

Hi,
from the last successful build that was deployed to repository.a.o by

Jenkins (the day before yesterday, Monday 19th):



https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar

I did decompile a sample entity class:

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470

where, as you can see, the method

pcSetDetachedState(java.lang.Object) from

org.apache.openjpa.enhance.PersistenceCapable

is not implemented: hence, the Maven build error reported below is

effectively correct, even though this was not happening until Monday 19th.

If I revert locally the last commit by Mark:



https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df

all is back working again.

Is it ok if I go ahead and revert that commit? Meanwhile, we can look

for a proper solution.

WDYT?

Regards.

On 20/04/21 16:02, Romain Manni-Bucau wrote:

Hi Francesco,

Did you try to decompile previous and current version (with jd-gui for
example) to see the diff?
Normally Mark only changed synthetic flag on fields, nothing else

should

have changed AFAIK.

Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <

ilgro...@apache.org>

a écrit :


Hi there,
with latest 3.1.3-SNAPSHOT artifacts I am getting errors while

building

Syncope.

In particular, we have a Maven module [1] which runs
openjpa-maven-plugin:enhance [2] as part of the build, and several

modules

(like [3][4][5] and others) which are depending on [1], adding more
entities and also running openjpa-maven-plugin:enhance

All this used to work fine until this morning (and still works fine

with

OpenJPA 3.1.2 on other Syncope branches); now [1] is still working

fine,

but building other modules give errors like as

[ERROR]


/home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]

org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
abstract and does not override abstract method
pcSetDetachedState(java.lang.Object) in
org.apache.openjpa.enhance.PersistenceCapable

Could you please shed some light? Thanks!
Regards.

[1]

https://github.com/apache/syncope/tree/master/core/persistence-jpa

[2]


https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176

[3]


https://github.com/apache/syncope/tree/master/core/persistence-jpa-json

[4]


https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa

[5]


https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/




--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Errors after recent commits

[Francesco Chicchiriccò]

Hi again,
I went ahead, revert the commit and re-opened OPENJPA-2800.

I am not sure to fully understand what is the actual reason for failure, 
though...

Regards.

On 21/04/21 11:29, Francesco Chicchiriccò wrote:

Update: I've found the actual issues is that the pcSetDetachedState() method is 
not generated in the parent class AbstractProvidedKeyEntity; as you can see from

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245

in fact, the method was still generated on Monday, hence child class 
JPACamelRoute was fine.

Regards.

On 21/04/21 11:06, Francesco Chicchiriccò wrote:

Hi,
from the last successful build that was deployed to repository.a.o by Jenkins 
(the day before yesterday, Monday 19th):

https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar

I did decompile a sample entity class:

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470

where, as you can see, the method

pcSetDetachedState(java.lang.Object) from 
org.apache.openjpa.enhance.PersistenceCapable

is not implemented: hence, the Maven build error reported below is effectively 
correct, even though this was not happening until Monday 19th.

If I revert locally the last commit by Mark:

https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df

all is back working again.

Is it ok if I go ahead and revert that commit? Meanwhile, we can look for a 
proper solution.
WDYT?

Regards.

On 20/04/21 16:02, Romain Manni-Bucau wrote:

Hi Francesco,

Did you try to decompile previous and current version (with jd-gui for
example) to see the diff?
Normally Mark only changed synthetic flag on fields, nothing else should
have changed AFAIK.

Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò 
a écrit :


Hi there,
with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building
Syncope.

In particular, we have a Maven module [1] which runs
openjpa-maven-plugin:enhance [2] as part of the build, and several modules
(like [3][4][5] and others) which are depending on [1], adding more
entities and also running openjpa-maven-plugin:enhance

All this used to work fine until this morning (and still works fine with
OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine,
but building other modules give errors like as

[ERROR]
/home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
abstract and does not override abstract method
pcSetDetachedState(java.lang.Object) in
org.apache.openjpa.enhance.PersistenceCapable

Could you please shed some light? Thanks!
Regards.

[1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
[2]
https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
[3]
https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
[4]
https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
[5]
https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Errors after recent commits

[Francesco Chicchiriccò]

Update: I've found the actual issues is that the pcSetDetachedState() method is 
not generated in the parent class AbstractProvidedKeyEntity; as you can see from

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245

in fact, the method was still generated on Monday, hence child class 
JPACamelRoute was fine.

Regards.

On 21/04/21 11:06, Francesco Chicchiriccò wrote:

Hi,
from the last successful build that was deployed to repository.a.o by Jenkins 
(the day before yesterday, Monday 19th):

https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar

I did decompile a sample entity class:

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470

where, as you can see, the method

pcSetDetachedState(java.lang.Object) from 
org.apache.openjpa.enhance.PersistenceCapable

is not implemented: hence, the Maven build error reported below is effectively 
correct, even though this was not happening until Monday 19th.

If I revert locally the last commit by Mark:

https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df

all is back working again.

Is it ok if I go ahead and revert that commit? Meanwhile, we can look for a 
proper solution.
WDYT?

Regards.

On 20/04/21 16:02, Romain Manni-Bucau wrote:

Hi Francesco,

Did you try to decompile previous and current version (with jd-gui for
example) to see the diff?
Normally Mark only changed synthetic flag on fields, nothing else should
have changed AFAIK.

Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò 
a écrit :


Hi there,
with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building
Syncope.

In particular, we have a Maven module [1] which runs
openjpa-maven-plugin:enhance [2] as part of the build, and several modules
(like [3][4][5] and others) which are depending on [1], adding more
entities and also running openjpa-maven-plugin:enhance

All this used to work fine until this morning (and still works fine with
OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine,
but building other modules give errors like as

[ERROR]
/home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
abstract and does not override abstract method
pcSetDetachedState(java.lang.Object) in
org.apache.openjpa.enhance.PersistenceCapable

Could you please shed some light? Thanks!
Regards.

[1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
[2]
https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
[3]
https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
[4]
https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
[5]
https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Errors after recent commits

[Francesco Chicchiriccò]

Hi,
from the last successful build that was deployed to repository.a.o by Jenkins 
(the day before yesterday, Monday 19th):

https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar

I did decompile a sample entity class:

https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470

where, as you can see, the method

pcSetDetachedState(java.lang.Object) from 
org.apache.openjpa.enhance.PersistenceCapable

is not implemented: hence, the Maven build error reported below is effectively 
correct, even though this was not happening until Monday 19th.

If I revert locally the last commit by Mark:

https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df

all is back working again.

Is it ok if I go ahead and revert that commit? Meanwhile, we can look for a 
proper solution.
WDYT?

Regards.

On 20/04/21 16:02, Romain Manni-Bucau wrote:

Hi Francesco,

Did you try to decompile previous and current version (with jd-gui for
example) to see the diff?
Normally Mark only changed synthetic flag on fields, nothing else should
have changed AFAIK.

Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò 
a écrit :


Hi there,
with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building
Syncope.

In particular, we have a Maven module [1] which runs
openjpa-maven-plugin:enhance [2] as part of the build, and several modules
(like [3][4][5] and others) which are depending on [1], adding more
entities and also running openjpa-maven-plugin:enhance

All this used to work fine until this morning (and still works fine with
OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine,
but building other modules give errors like as

[ERROR]
/home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
abstract and does not override abstract method
pcSetDetachedState(java.lang.Object) in
org.apache.openjpa.enhance.PersistenceCapable

Could you please shed some light? Thanks!
Regards.

[1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
[2]
https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
[3]
https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
[4]
https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
[5]
https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Errors after recent commits

[Francesco Chicchiriccò]

Hi there,
with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building Syncope.

In particular, we have a Maven module [1] which runs 
openjpa-maven-plugin:enhance [2] as part of the build, and several modules 
(like [3][4][5] and others) which are depending on [1], adding more entities 
and also running openjpa-maven-plugin:enhance

All this used to work fine until this morning (and still works fine with 
OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine, but 
building other modules give errors like as

[ERROR] 
/home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
 org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not abstract 
and does not override abstract method pcSetDetachedState(java.lang.Object) in 
org.apache.openjpa.enhance.PersistenceCapable

Could you please shed some light? Thanks!
Regards.

[1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
[2] 
https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
[3] https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
[4] https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
[5] 
https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] next up 3.1.3 or 3.2.0?

[Francesco Chicchiriccò]

On 18/04/21 12:31, Mark Struberg wrote:

Hi folks!

We fixed a lot of tickets since the last release. Some of them also change/fix 
the behaviour slightly. There are a few main tickets which do not introduce a 
big change, but might very subtly break existing apps in very rare edge cases:

* UnaryOp now respects the target type. For doing that I had to also change the 
Raw handling, finally fixing a bug that got introduced in 2009 ;) Before this 
fix all UnaryOps (SUM, MIN, MAX, CASE, etc) did return the native type coming 
from the JDBC driver. That means that for a TIME WITH TIME ZONE field we even 
did return vendor specific jdbc types like com.microsoft.jdbc.* or com.oracle.* 
types, etc.

This mainly affects 2 areas: First, if there is a select sum, max, min, case, 
etc which is used to return an Object[] and then cast up to the type. This 
might now fail, because we now return the correct type defined in the field.
E.g. if one did do a "select max(f.localDateTimeField) from ..." then this used 
to return a driver specific type for many databases as described above. After the fix, we 
now return the type of the 'localDateFimeField', in this case java.time.LocalDateTime.

Same happens for "select NEW" because right now we only look for a perfectly 
matching constructor and do no coercing. Should we introduce coercing probably? Means if 
a select new will result in a float value but there is only a constructor for double, do 
we want to also accept it in the future?

* Along the way I also implemented BooleanRepresentation handling for SQL 
literals via DBDictionary.


* respect TIMESTAMP precision in Oracle. Due to a bug we did hardcoded round at 
3 digits precision. So we essentially only allowed millis, even on a 
TIMESTAMP(6) field. The new code does respect the second fractions and now 
defaults to 6. It should be compatible but it might behave very subtle 
different.

* fix the reserved column name handling by introducing ColumnIdentifierRule 
(using the invalidColumnWordSet from the DBDictionary being used), separating 
it from the ColumnDefIdentifierRule.

* fix SUM to always return Double as requested by the spec. Previously we did 
return whatever Numeric the JDBC driver did serve, resulting in non portable 
code.

* PostgreSQL now supports setQueryTimeout. User might see this come alive and 
now return different when the situation occurs.


Does all that mean we should rather call the release 3.2.0 rather than 3.1.3?
Or is the change so subtle that we still continue with 3.1.x?

Hi Mark,
first of all, thanks for your recent (hard) work to review and close 
long-standing issues.

I don't have strong preference about versioning, but maybe 3.2.0 would report 
more, to external, the idea of the amount of work done.

Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

SNAPSHOT publishing

[Francesco Chicchiriccò]

Hi,
after opening OPENJPA-2846 I wanted to check if the same issue was happening 
with 3.1.3-SNAPSHOT but noticed that artifacts at [1] were stuck on last Oct 
5th.

I realized that we probably did not follow up with Infra about Jenkins upgrade 
[2] thus I went ahead and created [3].

The job performs a bare "mvn clean install" with JDK 8 and deploys to [1] as 
post-build action: if something different is needed, let's discuss.

Regards.

[1] https://repository.apache.org/content/repositories/snapshots/org/apache/
[2] 
https://lists.apache.org/thread.html/rd8bf18974947742bfa28e925c82e87c822ccc947d26e8ea7e9d9%40%3Cprivate.openjpa.apache.org%3E
[3] https://ci-builds.apache.org/job/OpenJPA/job/OpenJPA-master-deploy/

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [ANN] Apache OpenJPA-3.1.2 released

[Francesco Chicchiriccò]

On 07/09/20 10:58, Maxim Solodovnik wrote:
> Did I miss the VOTE for this release?

I'd say so :-)

https://lists.apache.org/thread.html/r892c0f18a887a2016626fda452fdee1e81a60249cf0742ef5ef3b02f%40%3Cdev.openjpa.apache.org%3E

Regards.

> On Mon, 7 Sep 2020 at 15:47, Mark Struberg  wrote:
>
>> The Apache OpenJPA team is pleased to announce the release of Apache
>> OpenJPA 3.1.2!
>>
>> Apache OpenJPA is a Java Persistence API implementation project at The
>> Apache Software Foundation.
>> It can be used as a stand-alone POJO persistence layer or integrated into
>> any Java EE compliant container and many other lightweight frameworks, such
>> as Tomcat and Spring.
>>
>> The 3.x releases targetting the JSR-338 Java Persistence 2.2 specification
>> is our most current production ready release. It is fully backward
>> compatible compatible to our JPA 2.1, 2.0 and 1.0 releases.
>>
>> The release is available through the official Apache Maven Central
>> repository and on our download page
>> https://openjpa.apache.org/downloads.html
>>
>> The full change log is available here:
>> https://openjpa.apache.org/openjpa-3.1.x.html
>>
>> We welcome your help and feedback. For more information on how to report
>> problems, and to get involved, visit the project website at
>>
>> https://openjpa.apache.org/
>>
>>
>> The Apache OpenJPA Team

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [openjpa] branch master updated: Fix typo

[Francesco Chicchiriccò]

On 23/07/20 22:36, Mark Struberg wrote:
> Txs Francesco!

Np Mark, sorry for jumping head: I was checking the commit e-mails and that 
leading "d" jumped ahead of my eyes.

Regards.

>> Am 23.07.2020 um 14:54 schrieb ilgro...@apache.org:
>>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> ilgrosso pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/openjpa.git
>>
>>
>> The following commit(s) were added to refs/heads/master by this push:
>> new 093a547  Fix typo
>> 093a547 is described below
>>
>> commit 093a547193e0e2b85c737d409e5808c7dafe271a
>> Author: Francesco Chicchiriccò 
>> AuthorDate: Thu Jul 23 14:53:53 2020 +0200
>>
>>Fix typo
>> ---
>> openjpa-examples/simple/src/main/resources/META-INF/persistence.xml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git 
>> a/openjpa-examples/simple/src/main/resources/META-INF/persistence.xml 
>> b/openjpa-examples/simple/src/main/resources/META-INF/persistence.xml
>> index 9a27b9f..694473e 100644
>> --- a/openjpa-examples/simple/src/main/resources/META-INF/persistence.xml
>> +++ b/openjpa-examples/simple/src/main/resources/META-INF/persistence.xml
>> @@ -1,4 +1,4 @@
>> -d
>> +
>> 

Re: Adding GitHub Actions for PR validation

[Francesco Chicchiriccò]

On 17/07/20 16:19, Enrico Olivelli wrote:
> Il Ven 17 Lug 2020, 16:14 Romain Manni-Bucau  ha
> scritto:
>
>> Hi Enrico,
>>
>> While we have a single type of this build tool +1 (= I don't think it would
>> be good to have GH Action + Travis + AppVeryor + SemaphoreCI + ...).
>> What would do the default build? mvn install or would it run all DB
>> profiles based on docker images?
> Just mvn install is enough for me.
>
> More complex/heavier builds should stay on ASF Jenkins, no need to run them
> at every PR validation.

Hi,
chiming in just to remember that we already had such discussion [1],  that we 
don't have Travis CI set up currently (I have it on my own fork, though: [2]) 
and that we have a whole set of (mostly useless?) builds set up at ASF Jenkins: 
[3].

Anyway, +1 to GitHub actions for PR validation.

Regards.

[1] 
https://lists.apache.org/thread.html/82739677363b480e0913496ccd33e449625052e821f4b0275f6101c6%40%3Cdev.openjpa.apache.org%3E
[2] https://github.com/ilgrosso/openjpa/blob/master/.travis.yml
[3] https://builds.apache.org/view/M-R/view/OpenJPA/

>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github <
>> https://github.com/rmannibucau> |
>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>> <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>>
>> Le ven. 17 juil. 2020 à 15:54, Enrico Olivelli  a
>> écrit :
>>
>>> Hey,
>>> what about adding a simple validation of Pull Requests using GitHub
>> actions
>>> ?
>>> I can create a very simple configuration file if you like this idea.
>>>
>>> It will help a lot in contributing patches, this way it is sure for the
>>> committer that the patch is not breaking unit tests (not integration
>> tests,
>>> of course) and it can help the contributor as it given an immediate
>>> feedback of the goodness of the patch
>>>
>>>
>>> Enrico
>>>

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [VOTE] Release Apache OpenJPA-3.1.2

[Francesco Chicchiriccò]

On 08/07/20 22:43, Mark Struberg wrote:
> Hi folks!
>
> Please VOTE on releasing Apache OpenJPA-3.1.2.
>
> We've fixed the following tickets:
>
> Bug
>
> [OPENJPA-2807 <https://issues.apache.org/jira/browse/OPENJPA-2807>] - 
> javax.persistence.Index#columnList should strip spaces
> [OPENJPA-2810 <https://issues.apache.org/jira/browse/OPENJPA-2810>] - Major 
> version is returned instead of minor
> Improvement
>
> [OPENJPA-2790 <https://issues.apache.org/jira/browse/OPENJPA-2790>] - Convert 
> build from SVN to GIT
> [OPENJPA-2798 <https://issues.apache.org/jira/browse/OPENJPA-2798>] - OpenJPA 
> need to be more Java11 friendly
> Task
>
> [OPENJPA-2809 <https://issues.apache.org/jira/browse/OPENJPA-2809>] - Add 
> openjpa-junit5 helper to enhance entities at test run
> [OPENJPA-2811 <https://issues.apache.org/jira/browse/OPENJPA-2811>] - Upgrade 
> to ASM 8
> [OPENJPA-2812 <https://issues.apache.org/jira/browse/OPENJPA-2812>] - Enable 
> to force snake_case for column names
> [OPENJPA-2813 <https://issues.apache.org/jira/browse/OPENJPA-2813>] - 
> Implement basic support of PersistenceProvidergenerateSchema
> [OPENJPA-2815 <https://issues.apache.org/jira/browse/OPENJPA-2815>] - Basic 
> jakarta bundle
>
> The staging repo is:
> https://repository.apache.org/content/repositories/orgapacheopenjpa-1008/ 
> <https://repository.apache.org/content/repositories/orgapacheopenjpa-1008/>
>
> The source release can be found at
> https://repository.apache.org/content/repositories/orgapacheopenjpa-1008/org/apache/openjpa/openjpa/3.1.2/
>  
> <https://repository.apache.org/content/repositories/orgapacheopenjpa-1008/org/apache/openjpa/openjpa/3.1.2/>
> sha1 is 140e75c560bb97a84f41ea9907233b270c051c10
>
> Please VOTE:
>
> [+1] let's ship it!
> [0] meh, don't care
> [-1] stop, I found a ${showstopper}
>
> The VOTE is open for 72h.

LGTM, I have also verified with Syncope building.

+1, thanks Mark.
Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: release openjpa 3.1.2 as is?

[Francesco Chicchiriccò]

On 06/07/20 08:31, Mark Struberg wrote:
> Hi!
>
> I had plans to add a few more fixes but didn't find enough time. Right now 
> working on improving the test suite and move it to junit4.
> This might still take some time. So should I better roll an openjpa release 
> now?

+1
Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Fwd: Build failed in Jenkins: OpenJPA-master #110

[Francesco Chicchiriccò]

Hi all,
FYI, Jenkins keep failing (see attachments).

Can someone check recent commits?

Regards.


--- Begin Message ---
See 


Changes:

[rmannibucau] OPENJPA-2811 asm8 support


--
[...truncated 5.13 KB...]
[INFO] OpenJPA Fetching Statistic Tool[jar]
[INFO] OpenJPA Fetching Statistic Tool -- WAS Bundle  [jar]
[INFO] OpenJPA Features   [pom]
[INFO] OpenJPA JUnit 5[jar]
[INFO] 
[INFO] -< org.apache.openjpa:openjpa-parent >--
[INFO] Building OpenJPA Parent POM 3.1.2-SNAPSHOT[1/31]
[INFO] [ pom ]-
[INFO] 
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ openjpa-parent ---
[INFO] 
[INFO] --- buildnumber-maven-plugin:1.4:create (default) @ openjpa-parent ---
[INFO] Executing: /bin/sh -c cd 
' && 'git' 
'rev-parse' '--verify' 'HEAD'
[INFO] Working directory: 

[INFO] Storing buildNumber: a975a3d1c63a82a6897b79a5cc9fcc4a3ebbb01f at 
timestamp: April 27, 2020 at 2:52 PM
[WARNING] Cannot get the branch information from the git repository: 
Detecting the current branch failed: fatal: ref HEAD is not a symbolic ref

[INFO] Executing: /bin/sh -c cd 
' && 'git' 
'rev-parse' '--verify' 'HEAD'
[INFO] Working directory: 

[INFO] Storing buildScmBranch: UNKNOWN
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
openjpa-parent ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (default) @ openjpa-parent ---
[INFO] 
[INFO] --- maven-checkstyle-plugin:3.1.1:checkstyle (default) @ openjpa-parent 
---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.7.0:process 
(process-resource-bundles) @ openjpa-parent ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.0:testCompile (test-source-compile) @ 
openjpa-parent ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-site-plugin:3.7.1:attach-descriptor (attach-descriptor) @ 
openjpa-parent ---
[INFO] Attaching 'src/site/site.xml' site descriptor with classifier 'site'.
[INFO] 
[INFO] --- apache-rat-plugin:0.12:check (default) @ openjpa-parent ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from 

[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 70 implicit excludes (use -debug for more details).
[INFO] Exclude: **/.*/**
[INFO] Exclude: **/target/**/*
[INFO] 4953 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 4944 licenses.
[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
openjpa-parent ---
[INFO] Installing 
 to 
/home/jenkins/.m2/repository/org/apache/openjpa/openjpa-parent/3.1.2-SNAPSHOT/openjpa-parent-3.1.2-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/openjpa/openjpa-parent/3.1.2-SNAPSHOT/openjpa-parent-3.1.2-SNAPSHOT-site.xml
[INFO] 
[INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @ openjpa-parent 
---
Downloading from apache.snapshots.https: 
https://repository.apache.org/content/repositories/snapshots/org/apache/openjpa/openjpa-parent/3.1.2-SNAPSHOT/maven-metadata.xml
Progress (1): 820 B   Downloaded from apache.snapshots.https: 
https://repository.apache.org/content/repositories/snapshots/org/apache/openjpa/openjpa-parent/3.1.2-SNAPSHOT/maven-metadata.xml
 (820 B at 882 B/s)
Uploading to apache.snapshots.https: 
https://repository.apache.org/content/repositories/snapshots/org/apache/openjpa/openjpa-parent/3.1.2-SNAPSHOT/openjpa-parent-3.1.2-20200427.145259-10.pom
Progress (1): 2.0/112 kBProgress (1): 4.1/112 kBProgress (1): 6.1/112 
kBProgress (1): 8.2/112 kBProgress (1): 10/112 kB Progress (1): 12/112 
kBProgress (1): 14/112 kBProgress (1): 16/112 kBProgress (1): 18/112 kBProgress 
(1): 20/112 kBProgress (1): 23/112 kBProgress (1): 25/112 kBProgress (1): 
27/112 kBProgress (1): 29/112 kBProgress (1): 31/112 kBProgress (1): 33/112 
kBProgress (1): 35/112 kBProgress (1): 37/112 kBProgress (1): 39/112 kBProgress 
(1): 41/112 kBProgress (1): 43/112 kBProgress (1): 45/112 kBProgress (1): 
47/112 

Re: Match commits to JIRA items

[Francesco Chicchiriccò]

On 22/04/20 04:17, Maxim Solodovnik wrote:
> Hello All,
>
> I just merged PR and noticed Git commits are not listed in JIRA comments
> Do we need such integration?
> Shall I request it from INFRA?

Huge +1

I think we should also accommodate at least for keywords, PR-style and 
notifications settings - see [1].

Regards.

[1] 
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Build failed in Jenkins: OpenJPA-trunk #102

[Francesco Chicchiriccò]

It seems there was still some issue, I should have fixed with

https://github.com/apache/openjpa/commit/666ae82f3baabed49b00217f219ba1be9d4ed748

I also renamed the jobs on Jenkins to reflect that we have master now, not 
trunk:

https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-master/
https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-master-deploy/

Regards.

On 23/03/20 08:56, Romain Manni-Bucau wrote:
> Hi Francesco,
>
> thanks for the heads up, should be fixed now
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le lun. 23 mars 2020 à 08:48, Francesco Chicchiriccò 
> a écrit :
>
>> Hi there,
>> not sure if you are aware, but just in case: all recent builds are failing
>> - see attached messages or
>>
>> https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-trunk/
>> https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-Trunk-Deploy/
>>
>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Fwd: Build failed in Jenkins: OpenJPA-trunk #102

[Francesco Chicchiriccò]

Hi there,
not sure if you are aware, but just in case: all recent builds are failing - 
see attached messages or

https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-trunk/
https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-Trunk-Deploy/

Regards.


--- Begin Message ---
See 


Changes:

[rmannibucau] OPENJPA-2809 ensure embeddabe too are enhanced


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H25 (ubuntu) in workspace 

No credentials specified
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://gitbox.apache.org/repos/asf/openjpa.git 
 > # timeout=10
Fetching upstream changes from https://gitbox.apache.org/repos/asf/openjpa.git
 > git --version # timeout=10
 > git fetch --tags --progress -- 
 > https://gitbox.apache.org/repos/asf/openjpa.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision f9b0906c1baa080ea67b3b1b26430a2489013671 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f9b0906c1baa080ea67b3b1b26430a2489013671
Commit message: "OPENJPA-2809 ensure embeddabe too are enhanced"
 > git rev-list --no-walk ae9b2a904bc5611257e2db888d3c61c7235be19f # timeout=10
Setting ANT_1_9_7_HOME=/home/jenkins/tools/ant/apache-ant-1.9.7
ERROR: No tool found matching MAVEN_3_0_4_HOME
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_5_4_HOME=/home/jenkins/tools/maven/apache-maven-3.5.4
[OpenJPA-Trunk-Deploy] $ /bin/bash -xe /tmp/jenkins4778168856738375299.sh
+ export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.7
+ ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.7
+ export JAVA_HOME=/home/jenkins/tools/java/latest1.8
+ JAVA_HOME=/home/jenkins/tools/java/latest1.8
+ export M2_HOME=/home/jenkins/tools/maven/apache-maven-3.5.4
+ M2_HOME=/home/jenkins/tools/maven/apache-maven-3.5.4
+ export 
PATH=/home/jenkins/tools/ant/apache-ant-1.9.7/bin:/home/jenkins/tools/java/latest1.8/bin:/home/jenkins/tools/maven/apache-maven-3.5.4/bin:/home/jenkins/tools/java/latest1.8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
+ 
PATH=/home/jenkins/tools/ant/apache-ant-1.9.7/bin:/home/jenkins/tools/java/latest1.8/bin:/home/jenkins/tools/maven/apache-maven-3.5.4/bin:/home/jenkins/tools/java/latest1.8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
+ mvn clean deploy -DskipTests
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for 
org.apache.openjpa:openjpa-junit5:[unknown-version]: Could not find artifact 
org.apache.openjpa:openjpa-parent:pom:3.0.1-SNAPSHOT and 'parent.relativePath' 
points at wrong local POM @ line 24, column 13
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.apache.openjpa:openjpa-junit5:[unknown-version] 
(
 has 1 error
[ERROR] Non-resolvable parent POM for 
org.apache.openjpa:openjpa-junit5:[unknown-version]: Could not find artifact 
org.apache.openjpa:openjpa-parent:pom:3.0.1-SNAPSHOT and 'parent.relativePath' 
points at wrong local POM @ line 24, column 13 -> [Help 2]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] 
http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting ANT_1_9_7_HOME=/home/jenkins/tools/ant/apache-ant-1.9.7
ERROR: No tool found matching MAVEN_3_0_4_HOME
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_5_4_HOME=/home/jenkins/tools/maven/apache-maven-3.5.4
Setting ANT_1_9_7_HOME=/home/jenkins/tools/ant/apache-ant-1.9.7
ERROR: No tool found matching MAVEN_3_0_4_HOME
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_5_4_HOME=/home/jenkins/tools/maven/apache-maven-3.5.4
--- End Message ---
--- Begin Message ---
See 


Changes:

[rmannibucau] OPENJPA-2809 ensure embeddabe too are enhanced


--
Started by an SCM change
Running as SYSTEM

Re: [VOTE] release Apache OpenJPA-3.1.1

[Francesco Chicchiriccò]

On 14-feb-20, alle 21:14, Mark Struberg wrote:

> hi folks!
> 
> I'd like to call a VOTE on releasing Apache OpenJPA-3.1.1
> 
> We've fixed a few tickets:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310351=12345232
> Sub-task
> 
> [OPENJPA-2713 <https://issues.apache.org/jira/browse/OPENJPA-2713>] - 
> [JPA-2.2]
> add support for Java8 Date/Time types
> Bug
> 
> [OPENJPA-2743 <https://issues.apache.org/jira/browse/OPENJPA-2743>] -
> AttributeConverter fails to enhance
> [OPENJPA-2799 <https://issues.apache.org/jira/browse/OPENJPA-2799>] - Karaf
> features contains mistake on the commons-collections4 location
> Improvement
> 
> [OPENJPA-2798 <https://issues.apache.org/jira/browse/OPENJPA-2798>] - OpenJPA
> need to be more Java11 friendly
> [OPENJPA-2801 <https://issues.apache.org/jira/browse/OPENJPA-2801>] - 
> Kubernetes
> TCPRemoteCommitProvider
> Task
> 
> [OPENJPA-2803 <https://issues.apache.org/jira/browse/OPENJPA-2803>] - DBCP2
> should be optional in OSGi
> 
> 
> Here is the staging repo:
> https://repository.apache.org/content/repositories/orgapacheopenjpa-1007/
> <https://repository.apache.org/content/repositories/orgapacheopenjpa-1007/>
> 
> And the sources.jar
> https://repository.apache.org/content/repositories/orgapacheopenjpa-1007/org/apache/openjpa/openjpa/3.1.1/
> <https://repository.apache.org/content/repositories/orgapacheopenjpa-1007/org/apache/openjpa/openjpa/3.1.1/>
> sha1 is c72353b9beb694cca03827ed21f2d10593dae2ae
> 
> 
> Please VOTE:
> 
> [+1] go ship it
> [+0] meh ,don't care
> [-1] stop there is a ${showstopper}
> 
> The VOTE is open for 72h.

+1
Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] releasing OpenJPA 3.1.1

[Francesco Chicchiriccò]

On 14/02/20 10:12, Mark Struberg wrote:
> Hi folks!
>
> I will run the release for openjpa-3.1.1.
>
> Any objections?

Not at all, please go ahead.

Thanks, Mark!

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: kubernetes module in bundle?

[Francesco Chicchiriccò]

On 11/02/20 07:49, Romain Manni-Bucau wrote:
> Hi all,
>
> kubernetes module brings kind of the world in our OSGi bundle, any issue to
> drop it from there?

Not at all, I've added it there while thinking to do the right thing, but I 
honestly don't do much wit OSGi hence if you think it's better to remove it, 
please go ahead.

Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] GCP RemoteCommitProvider

[Francesco Chicchiriccò]

I have added a test case, please have a look and let me know.
Regards.

On 23/01/20 14:58, Romain Manni-Bucau wrote:
> I'd try to at least add a test (faking k8s with HttpServer is enough IMHO)
> but it looks a good addition to me
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le jeu. 23 janv. 2020 à 14:50, Francesco Chicchiriccò 
> a écrit :
>
>> Hi all,
>> it turned out that GCP Pub/Sub wasn't the most efficient mean to
>> implement, so we moved to a more generic Kubernetes approach.
>>
>> I have opened
>>
>> https://issues.apache.org/jira/browse/OPENJPA-2801
>>
>> and
>>
>> https://github.com/apache/openjpa/pull/58
>>
>> Please, have a look.
>> Regards.
>>
>> On 07/01/20 09:17, Mark Struberg wrote:
>>> +1
>>>
>>> LieGrue,
>>> strub
>>>
>>>> Am 07.01.2020 um 08:40 schrieb Romain Manni-Bucau :
>>>>
>>>> Hi Francesco,
>>>>
>>>> Id say
>>>>
>>>> 1 yes
>>>> 2 new module
>>>>
>>>> Le mar. 7 janv. 2020 à 08:35, Francesco Chicchiriccò  
>>>> a écrit :
>>>>
>>>> Hi there,
>>>> there is chance I need to build a RemoteCommitProvider working with Google 
>>>> Cloud Platform's Pub/Sub [1], their messaging service.
>>>>
>>>> From a high-level point of view, I believe I can mostly mimic [2], even
>>>> though I would require to add [3] as dependency.
>>>>
>>>> Questions:
>>>>
>>>> 1. are we interested to embed such feature into OpenJPA?
>>>> 2. would it be fine do add [3] to openjpa-kernel or shall we build a
>>>> dedicated sub-module for such feature?
>>>>
>>>> Regards.
>>>>
>>>> [1] https://cloud.google.com/pubsub/docs/
>>>> [2] 
>>>> https://github.com/apache/openjpa/blob/master/openjpa-kernel/src/main/java/org/apache/openjpa/event/JMSRemoteCommitProvider.java
>>>> [3] https://github.com/googleapis/java-pubsub

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] GCP RemoteCommitProvider

[Francesco Chicchiriccò]

Hi all,
it turned out that GCP Pub/Sub wasn't the most efficient mean to implement, so 
we moved to a more generic Kubernetes approach.

I have opened

https://issues.apache.org/jira/browse/OPENJPA-2801

and

https://github.com/apache/openjpa/pull/58

Please, have a look.
Regards.

On 07/01/20 09:17, Mark Struberg wrote:
> +1
>
> LieGrue,
> strub
>
>> Am 07.01.2020 um 08:40 schrieb Romain Manni-Bucau :
>>
>> Hi Francesco,
>>
>> Id say
>>
>> 1 yes
>> 2 new module
>>
>> Le mar. 7 janv. 2020 à 08:35, Francesco Chicchiriccò 
>> a écrit :
>>
>>> Hi there,
>>> there is chance I need to build a RemoteCommitProvider working with Google
>>> Cloud Platform's Pub/Sub [1], their messaging service.
>>>
>>> From a high-level point of view, I believe I can mostly mimic [2], even
>>> though I would require to add [3] as dependency.
>>>
>>> Questions:
>>>
>>> 1. are we interested to embed such feature into OpenJPA?
>>> 2. would it be fine do add [3] to openjpa-kernel or shall we build a
>>> dedicated sub-module for such feature?
>>>
>>> Regards.
>>>
>>> [1] https://cloud.google.com/pubsub/docs/
>>> [2] 
>>> https://github.com/apache/openjpa/blob/master/openjpa-kernel/src/main/java/org/apache/openjpa/event/JMSRemoteCommitProvider.java
>>> [3] https://github.com/googleapis/java-pubsub

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

[DISCUSS] GCP RemoteCommitProvider

[Francesco Chicchiriccò]

Hi there,
there is chance I need to build a RemoteCommitProvider working with Google 
Cloud Platform's Pub/Sub [1], their messaging service.

>From a high-level point of view, I believe I can mostly mimic [2], even though 
>I would require to add [3] as dependency.

Questions:

1. are we interested to embed such feature into OpenJPA?
2. would it be fine do add [3] to openjpa-kernel or shall we build a dedicated 
sub-module for such feature?

Regards.

[1] https://cloud.google.com/pubsub/docs/
[2] 
https://github.com/apache/openjpa/blob/master/openjpa-kernel/src/main/java/org/apache/openjpa/event/JMSRemoteCommitProvider.java
[3] https://github.com/googleapis/java-pubsub

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

[Francesco Chicchiriccò]

On 17/10/19 10:05, Romain Manni-Bucau wrote:
> Oki so corrolar point to my initial thought: do we drop jenkins and ask
> infra to also handle master build (+ maintenance branches) with credentials
> to enable nightly deployments?
>
> I'm +1 while we keep all jobs on the same build platform and infra manages
> it.

FYI we are already using Jenkins and Buildbot as CI platforms, hence we are 
already not keeping all jobs on the same build platform.

My proposal is not to replace either, but to add Travis CI.
As said, Infra is fine with Travis CI (and AppVeyor, for example).

Regards.

> Le jeu. 17 oct. 2019 à 10:02, Francesco Chicchiriccò 
> a écrit :
>
>> On 17/10/19 10:00, Romain Manni-Bucau wrote:
>>> I understand but I don't want something done without infra being aware of
>>> it.
>>> Typically who would be admin on the repo to enable travis and update it
>>> when the webhook will be broken? Should be infra, not us IMHO.
>> Of course! Only infra can enable our repo for Travis - and it's plenty of
>> other ASF projects doing the same BTW.
>>
>> If we can not disagree on Travis CI, next step is to file a request for
>> Infra on JIRA.
>>
>> Regards.
>>
>>> Le jeu. 17 oct. 2019 à 09:24, Francesco Chicchiriccò <
>> ilgro...@apache.org>
>>> a écrit :
>>>
>>>> FYI, we have a working .travis.yml:
>>>>
>>>> https://travis-ci.org/ilgrosso/openjpa/builds/599012496
>>>>
>>>> Regards.
>>>>
>>>> On 17/10/19 08:45, Francesco Chicchiriccò wrote:
>>>>> On 17/10/19 08:23, Romain Manni-Bucau wrote:
>>>>>> Hi Francesco,
>>>>>>
>>>>>> Cant we do it on jenkins?
>>>>>> Rational being to ensure we rely on a centralized and infra solution
>> and
>>>>>> not something on our own, even for PR.
>>>>> Hi Romain,
>>>>> we already have Jenkins jobs [1], but AFAICT they suffer from chronic
>>>> lack of resources to satisfy all projects' needs, especially when it
>> comes
>>>> to build PRs.
>>>>> Besides this aspect, PRs *are* already managed at GitHub, and Infra is
>>>> completely fine with this - as we are, since we decided to switch to
>>>> dual-hosted repository a while ago.
>>>>> BTW, I am not proposing to replace Jenkins, only to add Travis CI.
>>>>>
>>>>> Regards.
>>>>>
>>>>> [1] https://builds.apache.org/view/M-R/view/OpenJPA/
>>>>>
>>>>>> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò <
>>>> ilgro...@apache.org>
>>>>>> a écrit :
>>>>>>
>>>>>>> Hi all,
>>>>>>> I think it would be really useful to enable Travis CI for our GItHub
>>>>>>> repository; besides other benefits, this would also improve our
>>>> ability to
>>>>>>> check PRs.
>>>>>>>
>>>>>>> WDYT?
>>>>>>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

[Francesco Chicchiriccò]

On 17/10/19 10:00, Romain Manni-Bucau wrote:
> I understand but I don't want something done without infra being aware of
> it.
> Typically who would be admin on the repo to enable travis and update it
> when the webhook will be broken? Should be infra, not us IMHO.

Of course! Only infra can enable our repo for Travis - and it's plenty of other 
ASF projects doing the same BTW.

If we can not disagree on Travis CI, next step is to file a request for Infra 
on JIRA.

Regards.

> Le jeu. 17 oct. 2019 à 09:24, Francesco Chicchiriccò 
> a écrit :
>
>> FYI, we have a working .travis.yml:
>>
>> https://travis-ci.org/ilgrosso/openjpa/builds/599012496
>>
>> Regards.
>>
>> On 17/10/19 08:45, Francesco Chicchiriccò wrote:
>>> On 17/10/19 08:23, Romain Manni-Bucau wrote:
>>>> Hi Francesco,
>>>>
>>>> Cant we do it on jenkins?
>>>> Rational being to ensure we rely on a centralized and infra solution and
>>>> not something on our own, even for PR.
>>> Hi Romain,
>>> we already have Jenkins jobs [1], but AFAICT they suffer from chronic
>> lack of resources to satisfy all projects' needs, especially when it comes
>> to build PRs.
>>> Besides this aspect, PRs *are* already managed at GitHub, and Infra is
>> completely fine with this - as we are, since we decided to switch to
>> dual-hosted repository a while ago.
>>> BTW, I am not proposing to replace Jenkins, only to add Travis CI.
>>>
>>> Regards.
>>>
>>> [1] https://builds.apache.org/view/M-R/view/OpenJPA/
>>>
>>>> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò <
>> ilgro...@apache.org>
>>>> a écrit :
>>>>
>>>>> Hi all,
>>>>> I think it would be really useful to enable Travis CI for our GItHub
>>>>> repository; besides other benefits, this would also improve our
>> ability to
>>>>> check PRs.
>>>>>
>>>>> WDYT?
>>>>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

[Francesco Chicchiriccò]

FYI, we have a working .travis.yml:

https://travis-ci.org/ilgrosso/openjpa/builds/599012496

Regards.

On 17/10/19 08:45, Francesco Chicchiriccò wrote:
> On 17/10/19 08:23, Romain Manni-Bucau wrote:
>> Hi Francesco,
>>
>> Cant we do it on jenkins?
>> Rational being to ensure we rely on a centralized and infra solution and
>> not something on our own, even for PR.
> Hi Romain,
> we already have Jenkins jobs [1], but AFAICT they suffer from chronic lack of 
> resources to satisfy all projects' needs, especially when it comes to build 
> PRs.
>
> Besides this aspect, PRs *are* already managed at GitHub, and Infra is 
> completely fine with this - as we are, since we decided to switch to 
> dual-hosted repository a while ago.
>
> BTW, I am not proposing to replace Jenkins, only to add Travis CI.
>
> Regards.
>
> [1] https://builds.apache.org/view/M-R/view/OpenJPA/
>
>> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò 
>> a écrit :
>>
>>> Hi all,
>>> I think it would be really useful to enable Travis CI for our GItHub
>>> repository; besides other benefits, this would also improve our ability to
>>> check PRs.
>>>
>>> WDYT?
>>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

[Francesco Chicchiriccò]

On 17/10/19 08:23, Romain Manni-Bucau wrote:
> Hi Francesco,
>
> Cant we do it on jenkins?
> Rational being to ensure we rely on a centralized and infra solution and
> not something on our own, even for PR.

Hi Romain,
we already have Jenkins jobs [1], but AFAICT they suffer from chronic lack of 
resources to satisfy all projects' needs, especially when it comes to build PRs.

Besides this aspect, PRs *are* already managed at GitHub, and Infra is 
completely fine with this - as we are, since we decided to switch to 
dual-hosted repository a while ago.

BTW, I am not proposing to replace Jenkins, only to add Travis CI.

Regards.

[1] https://builds.apache.org/view/M-R/view/OpenJPA/

> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò 
> a écrit :
>
>> Hi all,
>> I think it would be really useful to enable Travis CI for our GItHub
>> repository; besides other benefits, this would also improve our ability to
>> check PRs.
>>
>> WDYT?
>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

[DISCUSS] Enable Travis CI?

[Francesco Chicchiriccò]

Hi all,
I think it would be really useful to enable Travis CI for our GItHub 
repository; besides other benefits, this would also improve our ability to 
check PRs.

WDYT?
Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Updating OpenJPA Release Managers web page

[Francesco Chicchiriccò]

Hi Jody,
I normally edit the OpenJPA website through ASF CMS [1], while not 
strictly needed, as site sources are still on SVN:


https://svn.apache.org/repos/asf/openjpa/site/trunk/content/

Regards.

[1] https://www.apache.org/dev/cms.html

On 15/05/19 15:30, Jody Grassel wrote:

I noticed the list of release managers on the OpenJPA site is a bit out of
date (http://openjpa.apache.org/release-management.html) -- Heath and
Donald have not been part of the company for several years, and Albert Lee
has moved to a different part of the company for at least as long, so the
release managers for the IBM-owned branches need to be updated.

Presently, myself and William Dazey are the IBM staff that is responsible
for the IBM managed branches (1.0.x, 1.2.x, 2.0.x, 2.1.x, 2.2.x, and
2.2.1.x) . However, I am not sure how to update the website, as looking
through the git repository for openjpa, I don't see a branch that is
obviously intended for building the site (I vaguely remember committing
updates with SVN but that was years ago.)

So I'm reaching out for some help on getting that page up dated.  Thanks!


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: SVN issues

[Francesco Chicchiriccò]

Hi Will,
a while back we migrated from Subversion to git; I have just updated

https://openjpa.apache.org/source-code.html

to reflect such a change.

FYI, the old Subversion repository is R/O (that's why you get the error 
below when attempting to push).


Don't worry, your commit rights don't expire!

Regards.

On 13/05/19 23:22, William Dazey wrote:

The exception I am getting is:

Access to
  
'/repos/asf/!svn/txr/1859199-14tgq/openjpa/branches/2.2.x/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/strats/ValueMapDiscriminatorStrategy.java'
  forbidden

Thanks,
Will Dazey

On Mon, May 13, 2019 at 4:14 PM William Dazey  wrote:


Hello!
I have been away from OpenJPA development for awhile, but I have an issue
that I would like commit and I am getting an error when I try to commit via
SVN. "https://openjpa.apache.org/source-code.html; still lists the svn
repo as the correct one to use. Perhaps my committer status has expired?

Thanks,
Will Dazey


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Entity Enhancement in Spring Boot

[Francesco Chicchiriccò]

Hi,
at Syncope we had this migration from Hibernate to OpenJPA at the time 
of incubation, and we also had to face similar issues.
FYI we are now on OpenJPA since 2011 and we have never been regretting 
such a choice that was initially dictated by licensing.


Coming to your question, we also rely on Spring ORM: see configuration 
[1][2], allowing no persistence.xml, and a very tiny orm.xml [3] - I 
know it's somewhat involved, but we do have to support multi-tenancy, 
hence multiple persistence units, plus multiple DBMSes.


Also, we do entity enhancement at build time [4] via Maven, at the sole 
price of a simple persistence.xml [5] to be used only there.


Finally, we provide a tweak for Spring ORM to look for JPA entity 
classes from multiple JARs in the classpath - see [6].


Please have a look at let me know if there is anything unclear.

Regards.

[1] 
https://github.com/apache/syncope/blob/2_1_X/core/persistence-jpa/src/main/resources/persistenceContext.xml
[2] 
https://github.com/apache/syncope/blob/2_1_X/core/persistence-jpa/src/main/resources/domains/MasterDomain.xml
[3] 
https://github.com/apache/syncope/blob/2_1_X/core/persistence-jpa/src/main/resources/META-INF/spring-orm.xml
[4] 
https://github.com/apache/syncope/blob/2_1_X/core/persistence-jpa/pom.xml#L143-L174
[5] 
https://github.com/apache/syncope/blob/2_1_X/core/persistence-jpa/src/main/resources/persistence-enhance.xml
[6] 
https://github.com/apache/syncope/blob/2_1_X/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/spring/MultiJarAwarePersistenceUnitPostProcessor.java


On 05/05/19 19:32, Ebenezer Graham wrote:

Hello Devs,

I am an Apache Fineract CN contributor currently working on migrating the
project's ORM from Hibernate to OpenJPA (more on the issue
<https://jira.apache.org/jira/projects/FINCN/issues/FINCN-2?filter=allopenissues>
).

https://github.com/ebenezergraham/fineract-cn-postgresql/commit/c10a1e77c3a290c1faa671621baf6c6037ba260a

I want to know how to dynamically enhance entity classes for each
microservice's entity without having to hardcode the configuration in an
XML.

The aim is to do the enhancement with spring or gradle. I would appreciate
it if someone could share their experience on how to handle this (a better
way of doing this https://openjpa.apache.org/enhancement-with-maven.html
with gradle, a plugin or spring boot autoconfiguration).

A brief overview, the project has a PostgreSQL library and a provisioner
microservice which provides persistence functionalities to 13 other
microservices. The goal is to configure the enhancement once in the
PostgreSQL library - a one size fits all approach.

The above issue has led to this error(full log here:
https://pastebin.com/kGQu4qLH)

Error creating bean with name 'jpaMappingContext': Invocation of init
method failed; nested exception is  org.apache.openjpa.util.MetaDataException: The type "class
org.apache.fineract.cn.customer.internal.repository.PortraitEntity" has not
been enhanced.

*Regards,*

*Ebenezer Graham*



--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [VOTE] Release Apache OpenJPA-3.1.0 (take2)

[Francesco Chicchiriccò]

On 10/04/19 22:25, Mark Struberg wrote:

hi folks!

2nd take after fixing the ParameterExpression equals.

We have fixed tons of enhancements and bugs in OpenJPA for our 3.1.0 release.
One of the main improvements is to move to a native JavaEE8 level - JPA-2.2.
Please note that we implemented many JPA-2.2 features but not all yet.
We will work towards implementing the rest of the missing 2.2 stuff in the next 
bugfix releases.


Here are the fixed tickets:

Sub-task
• [OPENJPA-2710] - Create and update to geronimo-jpa_2.2_spec

Bug
• [OPENJPA-1993] - Deadlock Potential with ORM XML Processing
• [OPENJPA-2555] - Timestamp precision from manual schema not respected
• [OPENJPA-2567] - TINY/MEDIUM/LONG TEXT fields for MySQL and MariaDB 
are not supported
• [OPENJPA-2673] - Table is not created in openjpa 3.0.0-SNAPSHOT and 
OSGi
• [OPENJPA-2704] - The openjpa.jdbc.Schema no longer overrides orm.xml 
default
• [OPENJPA-2733] - Subquery parameters are incorrectly assigned
• [OPENJPA-2742] - SchemaTool fails with MySQL
• [OPENJPA-2746] - OpenJPA Karaf feature is not complete
• [OPENJPA-2756] - PostgreSQL requires escaping of search strings in 
all versions
• [OPENJPA-2757] - upgrade to xbean-asm7 to support Java11
• [OPENJPA-2761] - problem inserting more than 4000 charcters in oracle 
XMLTYPE column
• [OPENJPA-2764] - Map path expression tests behave random
• [OPENJPA-2768] - XMLStore SAXParser doesn't distinguish between 
element and extent
• [OPENJPA-2770] - false boolean literal doesn't work
• [OPENJPA-2771] - It seems like h2 'unlimited' is not "LIMIT 0" but rather 
"LIMIT -1"
• [OPENJPA-2772] - list of h2 reserved words is incomplete
• [OPENJPA-2777] - Indices specified using javax.persistence.Index 
annotation are not being created
• [OPENJPA-2780] - ReverseMappingTool does not generate @Enumerated 
annotation
• [OPENJPA-2781] - OpenJPA need internet connection to read the 
persistence.xml
• [OPENJPA-2785] - Queries invoked by Spring data that have parameters 
fail

Improvement
• [OPENJPA-2745] - Clean up try-catch implementation for DB2Dictionary
• [OPENJPA-2747] - Upgrade to JPA 2.2 and use javax.persistence-api spec
• [OPENJPA-2748] - commons-collections should be updated to most recent 
version
• [OPENJPA-2750] - commons-dbcp need to be updated to most recent 
version
• [OPENJPA-2751] - Code clean-up should be performed
• [OPENJPA-2752] - More libraries can be updated
• [OPENJPA-2753] - Create profiles to start various databases via Docker
• [OPENJPA-2755] - support MySQL DATETIME and TIMESTAMP fractions 
(milliseconds, nanos)
• [OPENJPA-2773] - set minIdle to > 0 in DBCPDriverDataSource
• [OPENJPA-2775] - hsqldb doesn't support NullTable to retrieve meta 
information

Task
• [OPENJPA-2744] - commons-pool should be updated to most recent version
• [OPENJPA-2754] - update to latest dbcp and verify moving from 
maxActive to maxTotal
• [OPENJPA-2758] - JPA 2.2 compliance

Dependency upgrade
• [OPENJPA-2784] - update docs before our release

The staging repository is at:
https://repository.apache.org/content/repositories/orgapacheopenjpa-1006/

The source release is at
https://repository.apache.org/content/repositories/orgapacheopenjpa-1006/org/apache/openjpa/openjpa-parent/3.1.0/
sha1 is ccfeb1b83518347f46113bb866027eb7996614f7

I've pushed the release branch to my github repo
https://github.com/struberg/openjpa/tree/release-3.1.0


Please VOTE:

[+1] yeah, ship it!
[+0] meh, don't care
[-1] nah, because ${showstopper}


+1

Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [VOTE] Release Apache OpenJPA-3.1.0

[Francesco Chicchiriccò]

On 2019-04-06 14:52 Mark Struberg wrote:

hi folks!

We have fixed tons of enhancements and bugs in OpenJPA for our 3.1.0 
release.
One of the main improvements is to move to a native JavaEE8 level - 
JPA-2.2.

Please note that we implemented many JPA-2.2 features but not all yet.
We will work towards implementing the rest of the missing 2.2 stuff in
the next bugfix releases.


Here are the fixed tickets:

Sub-task

• [OPENJPA-2710] - Create and update to geronimo-jpa_2.2_spec
Bug

• [OPENJPA-1993] - Deadlock Potential with ORM XML Processing
	• [OPENJPA-2555] - Timestamp precision from manual schema not 
respected

• [OPENJPA-2567] - TINY/MEDIUM/LONG TEXT fields for MySQL and MariaDB
are not supported
	• [OPENJPA-2673] - Table is not created in openjpa 3.0.0-SNAPSHOT and 
OSGi
	• [OPENJPA-2704] - The openjpa.jdbc.Schema no longer overrides orm.xml 
default

• [OPENJPA-2733] - Subquery parameters are incorrectly assigned
• [OPENJPA-2742] - SchemaTool fails with MySQL
• [OPENJPA-2746] - OpenJPA Karaf feature is not complete
• [OPENJPA-2756] - PostgreSQL requires escaping of search strings in
all versions
• [OPENJPA-2757] - upgrade to xbean-asm7 to support Java11
• [OPENJPA-2761] - problem inserting more than 4000 charcters in
oracle XMLTYPE column
• [OPENJPA-2764] - Map path expression tests behave random
• [OPENJPA-2768] - XMLStore SAXParser doesn't distinguish between
element and extent
• [OPENJPA-2770] - false boolean literal doesn't work
• [OPENJPA-2771] - It seems like h2 'unlimited' is not "LIMIT 0" but
rather "LIMIT -1"
• [OPENJPA-2772] - list of h2 reserved words is incomplete
• [OPENJPA-2777] - Indices specified using javax.persistence.Index
annotation are not being created
	• [OPENJPA-2780] - ReverseMappingTool does not generate @Enumerated 
annotation
	• [OPENJPA-2781] - OpenJPA need internet connection to read the 
persistence.xml

Improvement

• [OPENJPA-2745] - Clean up try-catch implementation for DB2Dictionary
	• [OPENJPA-2747] - Upgrade to JPA 2.2 and use javax.persistence-api 
spec
	• [OPENJPA-2748] - commons-collections should be updated to most 
recent version
	• [OPENJPA-2750] - commons-dbcp need to be updated to most recent 
version

• [OPENJPA-2751] - Code clean-up should be performed
• [OPENJPA-2752] - More libraries can be updated
	• [OPENJPA-2753] - Create profiles to start various databases via 
Docker

• [OPENJPA-2755] - support MySQL DATETIME and TIMESTAMP fractions
(milliseconds, nanos)
• [OPENJPA-2773] - set minIdle to > 0 in DBCPDriverDataSource
• [OPENJPA-2775] - hsqldb doesn't support NullTable to retrieve meta
information
Task

	• [OPENJPA-2744] - commons-pool should be updated to most recent 
version

• [OPENJPA-2754] - update to latest dbcp and verify moving from
maxActive to maxTotal
• [OPENJPA-2758] - JPA 2.2 compliance
Dependency upgrade

• [OPENJPA-2784] - update docs before our release


The staging repository is at:
https://repository.apache.org/content/repositories/orgapacheopenjpa-1005/

The source release is at
https://repository.apache.org/content/repositories/orgapacheopenjpa-1005/org/apache/openjpa/openjpa-parent/3.1.0/
sha1 is 1aea7cfff20c3a5fed57fb41fb1fcd4784b999ae

I've pushed the release branch to my github repo
https://github.com/struberg/openjpa/tree/release-3.1.0


Please VOTE:

[+1] yeah, ship it!
[+0] meh, don't care
[-1] nah, because ${showstopper}


+1

..and special thanks to Mark, for his enduring effort!
Regards.
--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

On 25/03/19 15:35, Maxim Solodovnik wrote:

I would say OPENJPA-2754 can be closed as Resolved-Fixed   -- Any objections?


Not at all, please go on.


My opinion 3.0.1/3.1.0 in current state is step forward comparing to 3.0.0
I would say: let's release :)


Same thought here, we're holding Syncope's release for a while, to wait 
for OpenJPA 3.1.0...


Regards.


On Mon, 25 Mar 2019 at 21:22, Francesco Chicchiriccò
 wrote:

Hi all,
it seems we are quite stuck in this pre-release process, let's try to
finalize the great work carried out lately.

By looking at JIRA [1], OpenJPA 3.0.1 (or 3.1.0? it seems to me there
was enough consensus around that), has 29 issues done and 15 to do, e.g.
[2].

  From there, I would say that:

a. not complete, but can be postponed:

OPENJPA-2662
OPENJPA-2665 (should also be updated to Java 8)
OPENJPA-2670

b. to review because some work was probably done; resolve what done and
postpone what to to:

OPENJPA-2670
OPENJPA-2753
OPENJPA-2754
OPENJPA-2709 and its children
   * OPENJPA-2711
   * OPENJPA-2712
   * OPENJPA-2713
   * OPENJPA-2714
   * OPENJPA-2715

c. issues reported but not yet confirmed or solved - to postpone:

OPENJPA-2673
OPENJPA-2694
OPENJPA-2728

Are you fine with such plan?
All, but @Mark, @Maxim in particular: please review group (a) and (b),
thanks.

If we agree on that, I think we can start rolling over this long awaited
release: WDYT?

Regards.

[1] https://issues.apache.org/jira/projects/OPENJPA/versions/12343421
[2]
https://issues.apache.org/jira/issues/?jql=statusCategory%20%3D%20new%20AND%20project%20%3D%2012310351%20AND%20fixVersion%20%3D%2012343421%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC

On 05/03/19 15:30, Romain Manni-Bucau wrote:

+1 for a release, 3.1.0 sounds good to me too

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 5 mars 2019 à 14:50, Francesco Chicchiriccò  a
écrit :


Hi Mark,
huge +1 for rolling a release - thanks for all your work.

3.1.0 would make sense, due to the API-level change - even though I
don't think we'll ever release 3.0.1 with JPA 2.1, anyway...

Regards.

On 05/03/19 14:44, Mark Struberg wrote:

One more question:
What about the version?
[ ] 3.0.1 or[ ] 3.1.0 as we updated the spec-api version?
LieGrue,strub
   On Tuesday, 5 March 2019, 14:40:21 CET, Mark Struberg

 wrote:

 We now have the official JPA-2.2 api jar. Our internal tests do pass.
There are surely a few more bugs to fix, but I'd say we can now do a

release and focus on further bugfixes and more jpa-2.2 features later.

wdyt?
LieGrue,strub

   On Wednesday, 20 February 2019, 08:01:46 CET, Francesco

Chicchiriccò  wrote:

HI there,
what's the updated status here? Thanks!

Regards.

On 05/02/19 08:48, Mark Struberg wrote:

And of course the open tickets from Pawel need to be reviewed/applied.

LieGrue,
strub


Am 05.02.2019 um 08:47 schrieb Mark Struberg :

I worked around it with tweaking the commons-dbcp2 configuration.
More healthy defaults now ;)

I'd love to finish the task for java8 time (MS SQLServer is missing

and DB/2), then we can roll a release imo.

LieGrue,
strub



Am 05.02.2019 um 08:30 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

So...

$ grep SNAPSHOT pom.xml
   3.0.1-SNAPSHOT

If I am not mistaking, there are no more SNAPSHOT dependencies: how

about releasing 3.0.1?

@Mark how about your ongoing work?

Regards.

On 05/02/19 05:08, Maxim Solodovnik wrote:

Thanks :)
have released artifact in Nexus and updated openjpa main pom

so one snapshot down :)

On Mon, 4 Feb 2019 at 23:50, Francesco Chicchiriccò <

ilgro...@apache.org> wrote:

Congrats Maxim!



https://lists.apache.org/thread.html/9100867a1dd69651bcbc1567182c3763f46308f819f8d102154bdb09@%3Cdev.commons.apache.org%3E

On 01/02/19 16:56, Maxim Solodovnik wrote:

Hello All,

Finally commons-collections release might happen:
https://markmail.org/thread/n7o4ca4ffmpc4dlz :)

On Wed, 19 Dec 2018 at 08:17, Maxim Solodovnik <

solomax...@gmail.com> wrote:

Hello All,

I'm trying to create commons-collections RC1 hopefully will be

released :)

On Fri, 14 Dec 2018 at 03:04, Mark Struberg



wrote:


I'd give it a test run.

I upgraded to a snapshot version of commons-pool.
There is a workaround for the problems in this version though: to
increase maxIdle to something higher than 0;
That would be a sane default anyway.

Will try to fix that over the weekend and go back to the releaed
commons-dbcp version.
Then I'm fine to go.

LieGrue,
strub



Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

On 04/12/18 13:25, Maxim Solodovnik wrote:

Additionally some classes are being 

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

Hi all,
it seems we are quite stuck in this pre-release process, let's try to 
finalize the great work carried out lately.


By looking at JIRA [1], OpenJPA 3.0.1 (or 3.1.0? it seems to me there 
was enough consensus around that), has 29 issues done and 15 to do, e.g. 
[2].


From there, I would say that:

a. not complete, but can be postponed:

OPENJPA-2662
OPENJPA-2665 (should also be updated to Java 8)
OPENJPA-2670

b. to review because some work was probably done; resolve what done and 
postpone what to to:


OPENJPA-2670
OPENJPA-2753
OPENJPA-2754
OPENJPA-2709 and its children
 * OPENJPA-2711
 * OPENJPA-2712
 * OPENJPA-2713
 * OPENJPA-2714
 * OPENJPA-2715

c. issues reported but not yet confirmed or solved - to postpone:

OPENJPA-2673
OPENJPA-2694
OPENJPA-2728

Are you fine with such plan?
All, but @Mark, @Maxim in particular: please review group (a) and (b), 
thanks.


If we agree on that, I think we can start rolling over this long awaited 
release: WDYT?


Regards.

[1] https://issues.apache.org/jira/projects/OPENJPA/versions/12343421
[2] 
https://issues.apache.org/jira/issues/?jql=statusCategory%20%3D%20new%20AND%20project%20%3D%2012310351%20AND%20fixVersion%20%3D%2012343421%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC


On 05/03/19 15:30, Romain Manni-Bucau wrote:

+1 for a release, 3.1.0 sounds good to me too

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 5 mars 2019 à 14:50, Francesco Chicchiriccò  a
écrit :


Hi Mark,
huge +1 for rolling a release - thanks for all your work.

3.1.0 would make sense, due to the API-level change - even though I
don't think we'll ever release 3.0.1 with JPA 2.1, anyway...

Regards.

On 05/03/19 14:44, Mark Struberg wrote:

One more question:
What about the version?
[ ] 3.0.1 or[ ] 3.1.0 as we updated the spec-api version?
LieGrue,strub
  On Tuesday, 5 March 2019, 14:40:21 CET, Mark Struberg

 wrote:

We now have the official JPA-2.2 api jar. Our internal tests do pass.
There are surely a few more bugs to fix, but I'd say we can now do a

release and focus on further bugfixes and more jpa-2.2 features later.

wdyt?
LieGrue,strub

  On Wednesday, 20 February 2019, 08:01:46 CET, Francesco

Chicchiriccò  wrote:

   HI there,
what's the updated status here? Thanks!

Regards.

On 05/02/19 08:48, Mark Struberg wrote:

And of course the open tickets from Pawel need to be reviewed/applied.

LieGrue,
strub


Am 05.02.2019 um 08:47 schrieb Mark Struberg :

I worked around it with tweaking the commons-dbcp2 configuration.
More healthy defaults now ;)

I'd love to finish the task for java8 time (MS SQLServer is missing

and DB/2), then we can roll a release imo.

LieGrue,
strub



Am 05.02.2019 um 08:30 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

So...

$ grep SNAPSHOT pom.xml
  3.0.1-SNAPSHOT

If I am not mistaking, there are no more SNAPSHOT dependencies: how

about releasing 3.0.1?

@Mark how about your ongoing work?

Regards.

On 05/02/19 05:08, Maxim Solodovnik wrote:

Thanks :)
have released artifact in Nexus and updated openjpa main pom

so one snapshot down :)

On Mon, 4 Feb 2019 at 23:50, Francesco Chicchiriccò <

ilgro...@apache.org> wrote:

Congrats Maxim!



https://lists.apache.org/thread.html/9100867a1dd69651bcbc1567182c3763f46308f819f8d102154bdb09@%3Cdev.commons.apache.org%3E

On 01/02/19 16:56, Maxim Solodovnik wrote:

Hello All,

Finally commons-collections release might happen:
https://markmail.org/thread/n7o4ca4ffmpc4dlz :)

On Wed, 19 Dec 2018 at 08:17, Maxim Solodovnik <

solomax...@gmail.com> wrote:

Hello All,

I'm trying to create commons-collections RC1 hopefully will be

released :)

On Fri, 14 Dec 2018 at 03:04, Mark Struberg



wrote:


I'd give it a test run.

I upgraded to a snapshot version of commons-pool.
There is a workaround for the problems in this version though: to
increase maxIdle to something higher than 0;
That would be a sane default anyway.

Will try to fix that over the weekend and go back to the releaed
commons-dbcp version.
Then I'm fine to go.

LieGrue,
strub



Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

On 04/12/18 13:25, Maxim Solodovnik wrote:

Additionally some classes are being used without "import" (to

have

same name)

Yep:

$ grep -r "commons\.collections" | grep "\.java" | sed

's/.*://' | sed
's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' |

sort | uniq

org.apache.commons.collections4.bidimap.TreeBidiMap;


org.apache.commons.collections4.comparators.ComparableComparator;

org.apache.commons.collections4.comparators.ComparatorChain;
org.

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

Hi Mark,
huge +1 for rolling a release - thanks for all your work.

3.1.0 would make sense, due to the API-level change - even though I 
don't think we'll ever release 3.0.1 with JPA 2.1, anyway...


Regards.

On 05/03/19 14:44, Mark Struberg wrote:

One more question:
What about the version?
[ ] 3.0.1 or[ ] 3.1.0 as we updated the spec-api version?
LieGrue,strub
 On Tuesday, 5 March 2019, 14:40:21 CET, Mark Struberg 
 wrote:
  
   We now have the official JPA-2.2 api jar. Our internal tests do pass.

There are surely a few more bugs to fix, but I'd say we can now do a release 
and focus on further bugfixes and more jpa-2.2 features later.
wdyt?
LieGrue,strub

     On Wednesday, 20 February 2019, 08:01:46 CET, Francesco Chicchiriccò 
 wrote:
  
  HI there,

what's the updated status here? Thanks!

Regards.

On 05/02/19 08:48, Mark Struberg wrote:

And of course the open tickets from Pawel need to be reviewed/applied.

LieGrue,
strub


Am 05.02.2019 um 08:47 schrieb Mark Struberg :

I worked around it with tweaking the commons-dbcp2 configuration.
More healthy defaults now ;)

I'd love to finish the task for java8 time (MS SQLServer is missing and DB/2), 
then we can roll a release imo.

LieGrue,
strub



Am 05.02.2019 um 08:30 schrieb Francesco Chicchiriccò :

So...

$ grep SNAPSHOT pom.xml
     3.0.1-SNAPSHOT

If I am not mistaking, there are no more SNAPSHOT dependencies: how about 
releasing 3.0.1?

@Mark how about your ongoing work?

Regards.

On 05/02/19 05:08, Maxim Solodovnik wrote:

Thanks :)
have released artifact in Nexus and updated openjpa main pom

so one snapshot down :)

On Mon, 4 Feb 2019 at 23:50, Francesco Chicchiriccò  wrote:

Congrats Maxim!

https://lists.apache.org/thread.html/9100867a1dd69651bcbc1567182c3763f46308f819f8d102154bdb09@%3Cdev.commons.apache.org%3E

On 01/02/19 16:56, Maxim Solodovnik wrote:

Hello All,

Finally commons-collections release might happen:
https://markmail.org/thread/n7o4ca4ffmpc4dlz :)

On Wed, 19 Dec 2018 at 08:17, Maxim Solodovnik  wrote:


Hello All,

I'm trying to create commons-collections RC1 hopefully will be released :)

On Fri, 14 Dec 2018 at 03:04, Mark Struberg 
wrote:


I'd give it a test run.

I upgraded to a snapshot version of commons-pool.
There is a workaround for the problems in this version though: to
increase maxIdle to something higher than 0;
That would be a sane default anyway.

Will try to fix that over the weekend and go back to the releaed
commons-dbcp version.
Then I'm fine to go.

LieGrue,
strub



Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

On 04/12/18 13:25, Maxim Solodovnik wrote:

Additionally some classes are being used without "import" (to have

same name)

Yep:

$ grep -r "commons\.collections" | grep "\.java" | sed 's/.*://' | sed

's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' |
sort | uniq

org.apache.commons.collections4.bidimap.TreeBidiMap;
org.apache.commons.collections4.comparators.ComparableComparator;
org.apache.commons.collections4.comparators.ComparatorChain;
org.apache.commons.collections4.functors.,org.apache.xalan")),
org.apache.commons.collections4.iterators.EmptyIterator;
org.apache.commons.collections4.iterators.FilterIterator;
org.apache.commons.collections4.iterators.IteratorChain;
org.apache.commons.collections4.map.


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

org.apache.commons.collections4.map.LinkedMap;
org.apache.commons.collections4.map.LRUMap
org.apache.commons.collections4.map.ReferenceMap
org.apache.commons.collections4.map.ReferenceMap;
org.apache.commons.collections4.Predicate;
org.apache.commons.collections4.set.MapBackedSet;


On Tue, 4 Dec 2018 at 18:42, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


This is the list of classes from commons-collections4 we're depending

on

ATM:

~/work/openjpa$ grep -r commons.collections | grep import | sed
's/.*://'  | sort | uniq
import org.apache.commons.collections4.bidimap.TreeBidiMap;
import

org.apache.commons.collections4.comparators.ComparableComparator;

import org.apache.commons.collections4.comparators.ComparatorChain;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.FilterIterator;
import org.apache.commons.collections4.iterators.IteratorChain;
import


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

import org.apache.commons.collections4.map.LinkedMap;
import org.apache.commons.collections4.map.ReferenceMap;
import org.apache.commons.collections4.Predicate;
import org.apache.commons.collections4.set.MapBackedSet;

Not many, actually...

On 04/12/18 10:55, Maxim Solodovnik wrote:

I'm afraid the one who will drop commons-collections should have

better

code-understanding than I'm :(

Here is the link to the discussion:


https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd424

Re: About JPA spec compliance

[Francesco Chicchiriccò]

Hi Mark,
this sounds very good, thanks!

Any chance you can also review the draft statement below?

Regards.

On 02/03/19 19:49, Mark Struberg wrote:

  I've now started the release for a jpa-2.2 geronimo-specs api jar.
OpenJPA tests do pass already and I will update once the vote succeeds.
LieGrue,strub

 On Wednesday, 20 February 2019, 08:51:32 CET, Francesco Chicchiriccò 
 wrote:
  
  Hi all,

about fixing the docs for JPA spec compliance, I haven't received any
feedback by Oliver Drotbohm.

Compared to the draft at

https://issues.apache.org/jira/browse/OPENJPA-2765?focusedCommentId=16739156=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16739156

I think there are a couple of items to adjust:

1. 3.0.1 should feature now also Java 8 time API from JPA 2.2 - recently
added by Mark
2. the code is effectively depending on JPA 2.1 specs, and there is the
pending PR #17 to upgrade to JPA 2.2 - any reason not to merge?

Thanks!
Regards.

On 2019/01/09 07:54:11, Francesco Chicchiriccò wrote:
  > Ok, so the draft text should be something like as following:
  >
  > OpenJPA 3.0.0: compatibility set for JPA 2.1; implements: stored
  > procedures, DDL generation (would make sense to include what's missing?
  > is the "what's new" list on [1] reliable?)
  >
  > OpenJPA 3.0.1: compatibility set for JPA 2.2, currently preparing code
  > for JakartaEE JPA TCK tests; implements: stream query results (would
  > make sense to include what's missing? is the "what's new" list on [2]
  > reliable?)
  >
  > I think that, besides what is mentioned in OPENJPA-2765, [3] should be
  > updated or renamed as [4], with consistent text modification.
  >
  > Regards.
  >
  > [1]
https://en.wikibooks.org/wiki/Java_Persistence/What_is_new_in_JPA_2.1%3F
  > [2] https://thoughts-on-java.org/whats-new-in-jpa-2-2/
  > [3] http://openjpa.apache.org/jpa-2.1-development-process.html
  > [4]http://openjpa.apache.org/jpa-2.2-development-process.html
  >
  > On 09/01/19 08:25, Romain Manni-Bucau wrote:
  > > Hmm, wasnt it done in two previous answers?
  > >
  > > Le mer. 9 janv. 2019 08:06, Francesco Chicchiriccò a
  > > écrit :
  > >
  > >> Hi all,
  > >> sorry to bother, but I think we should fix the communication anytime
  > >> soon: I understand that Mark's statement below means that we will be
  > >> soon able to report exactly what's the compatibility status of
  > >> 3.0.1-SNAPSHOT, but what about 3.0.0? I know it depends on JPA 2.1
  > >> specs, but can someone briefly highlight what is missing (and / or
what
  > >> is implemented)?
  > >>
  > >> Regards.
  > >>
  > >> On 07/01/19 12:02, Mark Struberg wrote:
  > >>> I've gradually improved our test coverage and internal code parts by
  > >> adding docker profiles for multiple Databases over the last months.
  > >>> I did add Oracle11_XE yesterday. Although the setup is not yet
perfect
  > >> we can at least run the tests now.
  > >>> So basically everyone can now test against a bunch of different
  > >> databases.
  > >>> The next step will be to include the JakartaEE JPA TCK.
  > >>>
  > >>> And then we will know exactly what's missing.
  > >>>
  > >>> LieGrue,
  > >>> strub
  > >>>
  > >>>
  > >>>> Am 07.01.2019 um 11:47 schrieb Francesco Chicchiriccò <
  > >> ilgro...@apache.org>:
  > >>>> On 07/01/19 11:45, Romain Manni-Bucau wrote:
  > >>>>> Hi Francesco,
  > >>>>>
  > >>>>> I will not have much time these days to help very actively but i'd
  > >> expose
  > >>>>> it the other way around, more roadmap oriented:
  > >>>>>
  > >>>>> OpenJPA 3.0.0: provides stored procedure support of JPA 2.1 etc...
  > >>>>>
  > >>>>> cause structurally we are more about adding features one by one
than
  > >> saying
  > >>>>> "we just miss X and Y" for now - which is fine IMHO but just
trying to
  > >>>>> explain why we must not reference ourself to JPA 2.2
completeness but
  > >> more
  > >>>>> on a kind of timeline.
  > >>>> I understand, that's fine; I would still need to fill up the
statements
  > >> above for both 3.0.0 and 3.0.1: would you be able to provide those?
  > >>>> Regards.
  > >>>>
  > >>>>> Le lun. 7 janv. 2019 à 11:43, Francesco Chicchiriccò <
  > >> ilgro...@apache.org>
  > >>>>> a écrit :
  > 

Re: About JPA spec compliance

[Francesco Chicchiriccò]

Hi all,
about fixing the docs for JPA spec compliance, I haven't received any 
feedback by Oliver Drotbohm.


Compared to the draft at

https://issues.apache.org/jira/browse/OPENJPA-2765?focusedCommentId=16739156=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16739156

I think there are a couple of items to adjust:

1. 3.0.1 should feature now also Java 8 time API from JPA 2.2 - recently 
added by Mark
2. the code is effectively depending on JPA 2.1 specs, and there is the 
pending PR #17 to upgrade to JPA 2.2 - any reason not to merge?


Thanks!
Regards.

On 2019/01/09 07:54:11, Francesco Chicchiriccò wrote:
> Ok, so the draft text should be something like as following:
>
> OpenJPA 3.0.0: compatibility set for JPA 2.1; implements: stored
> procedures, DDL generation (would make sense to include what's missing?
> is the "what's new" list on [1] reliable?)
>
> OpenJPA 3.0.1: compatibility set for JPA 2.2, currently preparing code
> for JakartaEE JPA TCK tests; implements: stream query results (would
> make sense to include what's missing? is the "what's new" list on [2]
> reliable?)
>
> I think that, besides what is mentioned in OPENJPA-2765, [3] should be
> updated or renamed as [4], with consistent text modification.
>
> Regards.
>
> [1] 
https://en.wikibooks.org/wiki/Java_Persistence/What_is_new_in_JPA_2.1%3F

> [2] https://thoughts-on-java.org/whats-new-in-jpa-2-2/
> [3] http://openjpa.apache.org/jpa-2.1-development-process.html
> [4]http://openjpa.apache.org/jpa-2.2-development-process.html
>
> On 09/01/19 08:25, Romain Manni-Bucau wrote:
> > Hmm, wasnt it done in two previous answers?
> >
> > Le mer. 9 janv. 2019 08:06, Francesco Chicchiriccò a
> > écrit :
> >
> >> Hi all,
> >> sorry to bother, but I think we should fix the communication anytime
> >> soon: I understand that Mark's statement below means that we will be
> >> soon able to report exactly what's the compatibility status of
> >> 3.0.1-SNAPSHOT, but what about 3.0.0? I know it depends on JPA 2.1
> >> specs, but can someone briefly highlight what is missing (and / or 
what

> >> is implemented)?
> >>
> >> Regards.
> >>
> >> On 07/01/19 12:02, Mark Struberg wrote:
> >>> I've gradually improved our test coverage and internal code parts by
> >> adding docker profiles for multiple Databases over the last months.
> >>> I did add Oracle11_XE yesterday. Although the setup is not yet 
perfect

> >> we can at least run the tests now.
> >>> So basically everyone can now test against a bunch of different
> >> databases.
> >>> The next step will be to include the JakartaEE JPA TCK.
> >>>
> >>> And then we will know exactly what's missing.
> >>>
> >>> LieGrue,
> >>> strub
> >>>
> >>>
> >>>> Am 07.01.2019 um 11:47 schrieb Francesco Chicchiriccò <
> >> ilgro...@apache.org>:
> >>>> On 07/01/19 11:45, Romain Manni-Bucau wrote:
> >>>>> Hi Francesco,
> >>>>>
> >>>>> I will not have much time these days to help very actively but i'd
> >> expose
> >>>>> it the other way around, more roadmap oriented:
> >>>>>
> >>>>> OpenJPA 3.0.0: provides stored procedure support of JPA 2.1 etc...
> >>>>>
> >>>>> cause structurally we are more about adding features one by one 
than

> >> saying
> >>>>> "we just miss X and Y" for now - which is fine IMHO but just 
trying to
> >>>>> explain why we must not reference ourself to JPA 2.2 
completeness but

> >> more
> >>>>> on a kind of timeline.
> >>>> I understand, that's fine; I would still need to fill up the 
statements

> >> above for both 3.0.0 and 3.0.1: would you be able to provide those?
> >>>> Regards.
> >>>>
> >>>>> Le lun. 7 janv. 2019 à 11:43, Francesco Chicchiriccò <
> >> ilgro...@apache.org>
> >>>>> a écrit :
> >>>>>
> >>>>>> Hi all,
> >>>>>> a recent conversation on Twitter [1] with Oliver Drotbohm, 
Spring Data

> >>>>>> project lead, highlighted the need to clarify what is the JPA spec
> >> level
> >>>>>> implemented by the various OpenJPA releases; for such a 
purpose, [2]

> >> was
> >>>>>> opened.
> >>>>>>
> >>>>>> I personally believe it is quite import

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

HI there,
what's the updated status here? Thanks!

Regards.

On 05/02/19 08:48, Mark Struberg wrote:

And of course the open tickets from Pawel need to be reviewed/applied.

LieGrue,
strub


Am 05.02.2019 um 08:47 schrieb Mark Struberg :

I worked around it with tweaking the commons-dbcp2 configuration.
More healthy defaults now ;)

I'd love to finish the task for java8 time (MS SQLServer is missing and DB/2), 
then we can roll a release imo.

LieGrue,
strub



Am 05.02.2019 um 08:30 schrieb Francesco Chicchiriccò :

So...

$ grep SNAPSHOT pom.xml
3.0.1-SNAPSHOT

If I am not mistaking, there are no more SNAPSHOT dependencies: how about 
releasing 3.0.1?

@Mark how about your ongoing work?

Regards.

On 05/02/19 05:08, Maxim Solodovnik wrote:

Thanks :)
have released artifact in Nexus and updated openjpa main pom

so one snapshot down :)

On Mon, 4 Feb 2019 at 23:50, Francesco Chicchiriccò  wrote:

Congrats Maxim!

https://lists.apache.org/thread.html/9100867a1dd69651bcbc1567182c3763f46308f819f8d102154bdb09@%3Cdev.commons.apache.org%3E

On 01/02/19 16:56, Maxim Solodovnik wrote:

Hello All,

Finally commons-collections release might happen:
https://markmail.org/thread/n7o4ca4ffmpc4dlz :)

On Wed, 19 Dec 2018 at 08:17, Maxim Solodovnik  wrote:


Hello All,

I'm trying to create commons-collections RC1 hopefully will be released :)

On Fri, 14 Dec 2018 at 03:04, Mark Struberg 
wrote:


I'd give it a test run.

I upgraded to a snapshot version of commons-pool.
There is a workaround for the problems in this version though: to
increase maxIdle to something higher than 0;
That would be a sane default anyway.

Will try to fix that over the weekend and go back to the releaed
commons-dbcp version.
Then I'm fine to go.

LieGrue,
strub



Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

On 04/12/18 13:25, Maxim Solodovnik wrote:

Additionally some classes are being used without "import" (to have

same name)

Yep:

$ grep -r "commons\.collections" | grep "\.java" | sed 's/.*://' | sed

's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' |
sort | uniq

org.apache.commons.collections4.bidimap.TreeBidiMap;
org.apache.commons.collections4.comparators.ComparableComparator;
org.apache.commons.collections4.comparators.ComparatorChain;
org.apache.commons.collections4.functors.,org.apache.xalan")),
org.apache.commons.collections4.iterators.EmptyIterator;
org.apache.commons.collections4.iterators.FilterIterator;
org.apache.commons.collections4.iterators.IteratorChain;
org.apache.commons.collections4.map.


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

org.apache.commons.collections4.map.LinkedMap;
org.apache.commons.collections4.map.LRUMap
org.apache.commons.collections4.map.ReferenceMap
org.apache.commons.collections4.map.ReferenceMap;
org.apache.commons.collections4.Predicate;
org.apache.commons.collections4.set.MapBackedSet;


On Tue, 4 Dec 2018 at 18:42, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


This is the list of classes from commons-collections4 we're depending

on

ATM:

~/work/openjpa$ grep -r commons.collections | grep import | sed
's/.*://'  | sort | uniq
import org.apache.commons.collections4.bidimap.TreeBidiMap;
import

org.apache.commons.collections4.comparators.ComparableComparator;

import org.apache.commons.collections4.comparators.ComparatorChain;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.FilterIterator;
import org.apache.commons.collections4.iterators.IteratorChain;
import


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

import org.apache.commons.collections4.map.LinkedMap;
import org.apache.commons.collections4.map.ReferenceMap;
import org.apache.commons.collections4.Predicate;
import org.apache.commons.collections4.set.MapBackedSet;

Not many, actually...

On 04/12/18 10:55, Maxim Solodovnik wrote:

I'm afraid the one who will drop commons-collections should have

better

code-understanding than I'm :(

Here is the link to the discussion:


https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd4241ab3ae6a39d6b35e577b@%3Cuser.commons.apache.org%3E

You can raise your voice :)

On Mon, 3 Dec 2018 at 22:10, Romain Manni-Bucau <

rmannibu...@gmail.com>

wrote:


Does the cost to drop it is that high? Really tempted to say it is a

better

solution for openjpa anyway on the mid term.

Le lun. 3 déc. 2018 à 16:08, Maxim Solodovnik 

a

écrit :


I did ping commons-collwctions community (~6 days ago) - no answer
Will ping again

On Mon, 3 Dec 2018 at 18:54, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


Hi,
did we make any progress?

FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400

Regards.

On 26/11/18 14:07, Maxim Solodovnik wrote:

Additionally commons-collections4 release is required
I'll ping commons community ....

On Mo

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

On 05/02/19 08:47, Mark Struberg wrote:

I worked around it with tweaking the commons-dbcp2 configuration.
More healthy defaults now ;)

I'd love to finish the task for java8 time (MS SQLServer is missing and DB/2), 
then we can roll a release imo.


Sounds like a plan, thanks.

Regards.


Am 05.02.2019 um 08:30 schrieb Francesco Chicchiriccò :

So...

$ grep SNAPSHOT pom.xml
 3.0.1-SNAPSHOT

If I am not mistaking, there are no more SNAPSHOT dependencies: how about 
releasing 3.0.1?

@Mark how about your ongoing work?

Regards.

On 05/02/19 05:08, Maxim Solodovnik wrote:

Thanks :)
have released artifact in Nexus and updated openjpa main pom

so one snapshot down :)

On Mon, 4 Feb 2019 at 23:50, Francesco Chicchiriccò  wrote:

Congrats Maxim!

https://lists.apache.org/thread.html/9100867a1dd69651bcbc1567182c3763f46308f819f8d102154bdb09@%3Cdev.commons.apache.org%3E

On 01/02/19 16:56, Maxim Solodovnik wrote:

Hello All,

Finally commons-collections release might happen:
https://markmail.org/thread/n7o4ca4ffmpc4dlz :)

On Wed, 19 Dec 2018 at 08:17, Maxim Solodovnik  wrote:


Hello All,

I'm trying to create commons-collections RC1 hopefully will be released :)

On Fri, 14 Dec 2018 at 03:04, Mark Struberg 
wrote:


I'd give it a test run.

I upgraded to a snapshot version of commons-pool.
There is a workaround for the problems in this version though: to
increase maxIdle to something higher than 0;
That would be a sane default anyway.

Will try to fix that over the weekend and go back to the releaed
commons-dbcp version.
Then I'm fine to go.

LieGrue,
strub



Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

On 04/12/18 13:25, Maxim Solodovnik wrote:

Additionally some classes are being used without "import" (to have

same name)

Yep:

$ grep -r "commons\.collections" | grep "\.java" | sed 's/.*://' | sed

's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' |
sort | uniq

org.apache.commons.collections4.bidimap.TreeBidiMap;
org.apache.commons.collections4.comparators.ComparableComparator;
org.apache.commons.collections4.comparators.ComparatorChain;
org.apache.commons.collections4.functors.,org.apache.xalan")),
org.apache.commons.collections4.iterators.EmptyIterator;
org.apache.commons.collections4.iterators.FilterIterator;
org.apache.commons.collections4.iterators.IteratorChain;
org.apache.commons.collections4.map.


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

org.apache.commons.collections4.map.LinkedMap;
org.apache.commons.collections4.map.LRUMap
org.apache.commons.collections4.map.ReferenceMap
org.apache.commons.collections4.map.ReferenceMap;
org.apache.commons.collections4.Predicate;
org.apache.commons.collections4.set.MapBackedSet;


On Tue, 4 Dec 2018 at 18:42, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


This is the list of classes from commons-collections4 we're depending

on

ATM:

~/work/openjpa$ grep -r commons.collections | grep import | sed
's/.*://'  | sort | uniq
import org.apache.commons.collections4.bidimap.TreeBidiMap;
import

org.apache.commons.collections4.comparators.ComparableComparator;

import org.apache.commons.collections4.comparators.ComparatorChain;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.FilterIterator;
import org.apache.commons.collections4.iterators.IteratorChain;
import


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

import org.apache.commons.collections4.map.LinkedMap;
import org.apache.commons.collections4.map.ReferenceMap;
import org.apache.commons.collections4.Predicate;
import org.apache.commons.collections4.set.MapBackedSet;

Not many, actually...

On 04/12/18 10:55, Maxim Solodovnik wrote:

I'm afraid the one who will drop commons-collections should have

better

code-understanding than I'm :(

Here is the link to the discussion:


https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd4241ab3ae6a39d6b35e577b@%3Cuser.commons.apache.org%3E

You can raise your voice :)

On Mon, 3 Dec 2018 at 22:10, Romain Manni-Bucau <

rmannibu...@gmail.com>

wrote:


Does the cost to drop it is that high? Really tempted to say it is a

better

solution for openjpa anyway on the mid term.

Le lun. 3 déc. 2018 à 16:08, Maxim Solodovnik 

a

écrit :


I did ping commons-collwctions community (~6 days ago) - no answer
Will ping again

On Mon, 3 Dec 2018 at 18:54, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


Hi,
did we make any progress?

FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400

Regards.

On 26/11/18 14:07, Maxim Solodovnik wrote:

Additionally commons-collections4 release is required
I'll ping commons community ....

On Mon, 26 Nov 2018 at 20:01, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


Hi there,
am I correct if I think that, once commons-pool2 and

commons-dbcp2

are

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

So...

$ grep SNAPSHOT pom.xml
    3.0.1-SNAPSHOT

If I am not mistaking, there are no more SNAPSHOT dependencies: how 
about releasing 3.0.1?


@Mark how about your ongoing work?

Regards.

On 05/02/19 05:08, Maxim Solodovnik wrote:

Thanks :)
have released artifact in Nexus and updated openjpa main pom

so one snapshot down :)

On Mon, 4 Feb 2019 at 23:50, Francesco Chicchiriccò  wrote:

Congrats Maxim!

https://lists.apache.org/thread.html/9100867a1dd69651bcbc1567182c3763f46308f819f8d102154bdb09@%3Cdev.commons.apache.org%3E

On 01/02/19 16:56, Maxim Solodovnik wrote:

Hello All,

Finally commons-collections release might happen:
https://markmail.org/thread/n7o4ca4ffmpc4dlz :)

On Wed, 19 Dec 2018 at 08:17, Maxim Solodovnik  wrote:


Hello All,

I'm trying to create commons-collections RC1 hopefully will be released :)

On Fri, 14 Dec 2018 at 03:04, Mark Struberg 
wrote:


I'd give it a test run.

I upgraded to a snapshot version of commons-pool.
There is a workaround for the problems in this version though: to
increase maxIdle to something higher than 0;
That would be a sane default anyway.

Will try to fix that over the weekend and go back to the releaed
commons-dbcp version.
Then I'm fine to go.

LieGrue,
strub



Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

On 04/12/18 13:25, Maxim Solodovnik wrote:

Additionally some classes are being used without "import" (to have

same name)

Yep:

$ grep -r "commons\.collections" | grep "\.java" | sed 's/.*://' | sed

's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' |
sort | uniq

org.apache.commons.collections4.bidimap.TreeBidiMap;
org.apache.commons.collections4.comparators.ComparableComparator;
org.apache.commons.collections4.comparators.ComparatorChain;
org.apache.commons.collections4.functors.,org.apache.xalan")),
org.apache.commons.collections4.iterators.EmptyIterator;
org.apache.commons.collections4.iterators.FilterIterator;
org.apache.commons.collections4.iterators.IteratorChain;
org.apache.commons.collections4.map.


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

org.apache.commons.collections4.map.LinkedMap;
org.apache.commons.collections4.map.LRUMap
org.apache.commons.collections4.map.ReferenceMap
org.apache.commons.collections4.map.ReferenceMap;
org.apache.commons.collections4.Predicate;
org.apache.commons.collections4.set.MapBackedSet;


On Tue, 4 Dec 2018 at 18:42, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


This is the list of classes from commons-collections4 we're depending

on

ATM:

~/work/openjpa$ grep -r commons.collections | grep import | sed
's/.*://'  | sort | uniq
import org.apache.commons.collections4.bidimap.TreeBidiMap;
import

org.apache.commons.collections4.comparators.ComparableComparator;

import org.apache.commons.collections4.comparators.ComparatorChain;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.FilterIterator;
import org.apache.commons.collections4.iterators.IteratorChain;
import


org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

import org.apache.commons.collections4.map.LinkedMap;
import org.apache.commons.collections4.map.ReferenceMap;
import org.apache.commons.collections4.Predicate;
import org.apache.commons.collections4.set.MapBackedSet;

Not many, actually...

On 04/12/18 10:55, Maxim Solodovnik wrote:

I'm afraid the one who will drop commons-collections should have

better

code-understanding than I'm :(

Here is the link to the discussion:


https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd4241ab3ae6a39d6b35e577b@%3Cuser.commons.apache.org%3E

You can raise your voice :)

On Mon, 3 Dec 2018 at 22:10, Romain Manni-Bucau <

rmannibu...@gmail.com>

wrote:


Does the cost to drop it is that high? Really tempted to say it is a

better

solution for openjpa anyway on the mid term.

Le lun. 3 déc. 2018 à 16:08, Maxim Solodovnik 

a

écrit :


I did ping commons-collwctions community (~6 days ago) - no answer
Will ping again

On Mon, 3 Dec 2018 at 18:54, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


Hi,
did we make any progress?

FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400

Regards.

On 26/11/18 14:07, Maxim Solodovnik wrote:

Additionally commons-collections4 release is required
I'll ping commons community ....

On Mon, 26 Nov 2018 at 20:01, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


Hi there,
am I correct if I think that, once commons-pool2 and

commons-dbcp2

are

released, we will be able to release OpenJPA 3.0.1?
We start needing its features and fixes at Syncope...

Regards.

On 2018/11/13 12:50:33, Mark Struberg wrote:
 > Go for it, I already removed tons of stuff for other

commons

libs

which we now do not need anymore.
 >
 > We still need commons-dbcp (which requires common

Re: Backporting fixes also to 2.4.x?

[Francesco Chicchiriccò]

Il 2 febbraio 2019 12:12:54 CET, Mark Struberg  ha 
scritto:
>Hi folks!
>
>I've done quite a few fixes in the last few weeks.
>Some related to new JPA-2.1/2.2 features, but others totally unrelated
>to that.
>Do we also want to port them back to OpenJPA-2.4.x?

+1, thanks Mark.
Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, 
PonyMail
http://home.apache.org/~ilgrosso/

Re: java8 time API support

[Francesco Chicchiriccò]

On 21/01/19 16:07, Romain Manni-Bucau wrote:

+1000 to make it part of the dictionary, makes way more sense IMHO


+1001 then, I also think it's better :-)

Thanks Mark!
Regards.


Le lun. 21 janv. 2019 à 15:53, Mark Struberg  a
écrit :


hi folks!
Over the last few days I started to implement the Java8 time types which
are required by the JPA-2.2 spec.
* LocalDate* LocalTime* LocalDateTime* OffsetTime* OffsetDateTime
The first 3 are pretty much finished. Will work on the later 2 today.I
first started to implement LocalDate as ValueHandler. But some databases
(postgres, etc) do have native support for those types. So I figured it
might be better to add support for it directly in the DBDictionary. This
also improves performance.
Wdyt?Any input or ideas how to make it better?

LieGrue,strub


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: About JPA spec compliance

[Francesco Chicchiriccò]

Ok, so the draft text should be something like as following:

OpenJPA 3.0.0: compatibility set for JPA 2.1; implements: stored 
procedures, DDL generation (would make sense to include what's missing? 
is the "what's new" list on [1] reliable?)


OpenJPA 3.0.1: compatibility set for JPA 2.2, currently preparing code 
for JakartaEE JPA TCK tests; implements: stream query results (would 
make sense to include what's missing? is the "what's new" list on [2] 
reliable?)


I think that, besides what is mentioned in OPENJPA-2765, [3] should be 
updated or renamed as [4], with consistent text modification.


Regards.

[1] https://en.wikibooks.org/wiki/Java_Persistence/What_is_new_in_JPA_2.1%3F
[2] https://thoughts-on-java.org/whats-new-in-jpa-2-2/
[3] http://openjpa.apache.org/jpa-2.1-development-process.html
[4]http://openjpa.apache.org/jpa-2.2-development-process.html

On 09/01/19 08:25, Romain Manni-Bucau wrote:

Hmm, wasnt it done in two previous answers?

Le mer. 9 janv. 2019 08:06, Francesco Chicchiriccò  a
écrit :


Hi all,
sorry to bother, but I think we should fix the communication anytime
soon: I understand that Mark's statement below means that we will be
soon able to report exactly what's the compatibility status of
3.0.1-SNAPSHOT, but what about 3.0.0? I know it depends on JPA 2.1
specs, but can someone briefly highlight what is missing (and / or what
is implemented)?

Regards.

On 07/01/19 12:02, Mark Struberg wrote:

I've gradually improved our test coverage and internal code parts by

adding docker profiles for multiple Databases over the last months.

I did add Oracle11_XE yesterday. Although the setup is not yet perfect

we can at least run the tests now.

So basically everyone can now test against a bunch of different

databases.

The next step will be to include the JakartaEE JPA TCK.

And then we will know exactly what's missing.

LieGrue,
strub



Am 07.01.2019 um 11:47 schrieb Francesco Chicchiriccò <

ilgro...@apache.org>:

On 07/01/19 11:45, Romain Manni-Bucau wrote:

Hi Francesco,

I will not have much time these days to help very actively but i'd

expose

it the other way around, more roadmap oriented:

OpenJPA 3.0.0: provides stored procedure support of JPA 2.1 etc...

cause structurally we are more about adding features one by one than

saying

"we just miss X and Y" for now - which is fine IMHO but just trying to
explain why we must not reference ourself to JPA 2.2 completeness but

more

on a kind of timeline.

I understand, that's fine; I would still need to fill up the statements

above for both 3.0.0 and 3.0.1: would you be able to provide those?

Regards.


Le lun. 7 janv. 2019 à 11:43, Francesco Chicchiriccò <

ilgro...@apache.org>

a écrit :


Hi all,
a recent conversation on Twitter [1] with Oliver Drotbohm, Spring Data
project lead, highlighted the need to clarify what is the JPA spec

level

implemented by the various OpenJPA releases; for such a purpose, [2]

was

opened.

I personally believe it is quite important to timely react, and I also
offer my availability to align the various docs, if no one else steps
in; for such a purpose, however, I would really appreciate some kind

of

draft statements like as follows:

* OpenJPA 2.x - fully implements JPA 2.0 specs, pass JPA TCK
* OpenJPA 3.0.0 - depends on JPA 2.1 specs, JPA TCK not available at
release time - missing JPA 2.1 features: A,B,C...
* OpenJPA 3.0.1 - not released yet, depends on JPA 2.2 specs, JPA TCK
compliance not yet verified - missing JPA 2.2 features: D,E,F...

WDYT?
Regards.

[1] https://twitter.com/odrotbohm/status/1081713555290972160
[2] https://issues.apache.org/jira/browse/OPENJPA-2765


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: About JPA spec compliance

[Francesco Chicchiriccò]

Hi all,
sorry to bother, but I think we should fix the communication anytime 
soon: I understand that Mark's statement below means that we will be 
soon able to report exactly what's the compatibility status of 
3.0.1-SNAPSHOT, but what about 3.0.0? I know it depends on JPA 2.1 
specs, but can someone briefly highlight what is missing (and / or what 
is implemented)?


Regards.

On 07/01/19 12:02, Mark Struberg wrote:

I've gradually improved our test coverage and internal code parts by adding 
docker profiles for multiple Databases over the last months.
I did add Oracle11_XE yesterday. Although the setup is not yet perfect we can 
at least run the tests now.

So basically everyone can now test against a bunch of different databases.

The next step will be to include the JakartaEE JPA TCK.

And then we will know exactly what's missing.

LieGrue,
strub



Am 07.01.2019 um 11:47 schrieb Francesco Chicchiriccò :

On 07/01/19 11:45, Romain Manni-Bucau wrote:

Hi Francesco,

I will not have much time these days to help very actively but i'd expose
it the other way around, more roadmap oriented:

OpenJPA 3.0.0: provides stored procedure support of JPA 2.1 etc...

cause structurally we are more about adding features one by one than saying
"we just miss X and Y" for now - which is fine IMHO but just trying to
explain why we must not reference ourself to JPA 2.2 completeness but more
on a kind of timeline.

I understand, that's fine; I would still need to fill up the statements above 
for both 3.0.0 and 3.0.1: would you be able to provide those?

Regards.


Le lun. 7 janv. 2019 à 11:43, Francesco Chicchiriccò 
a écrit :


Hi all,
a recent conversation on Twitter [1] with Oliver Drotbohm, Spring Data
project lead, highlighted the need to clarify what is the JPA spec level
implemented by the various OpenJPA releases; for such a purpose, [2] was
opened.

I personally believe it is quite important to timely react, and I also
offer my availability to align the various docs, if no one else steps
in; for such a purpose, however, I would really appreciate some kind of
draft statements like as follows:

* OpenJPA 2.x - fully implements JPA 2.0 specs, pass JPA TCK
* OpenJPA 3.0.0 - depends on JPA 2.1 specs, JPA TCK not available at
release time - missing JPA 2.1 features: A,B,C...
* OpenJPA 3.0.1 - not released yet, depends on JPA 2.2 specs, JPA TCK
compliance not yet verified - missing JPA 2.2 features: D,E,F...

WDYT?
Regards.

[1] https://twitter.com/odrotbohm/status/1081713555290972160
[2] https://issues.apache.org/jira/browse/OPENJPA-2765


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: About JPA spec compliance

[Francesco Chicchiriccò]

On 07/01/19 11:45, Romain Manni-Bucau wrote:

Hi Francesco,

I will not have much time these days to help very actively but i'd expose
it the other way around, more roadmap oriented:

OpenJPA 3.0.0: provides stored procedure support of JPA 2.1 etc...

cause structurally we are more about adding features one by one than saying
"we just miss X and Y" for now - which is fine IMHO but just trying to
explain why we must not reference ourself to JPA 2.2 completeness but more
on a kind of timeline.


I understand, that's fine; I would still need to fill up the statements 
above for both 3.0.0 and 3.0.1: would you be able to provide those?


Regards.


Le lun. 7 janv. 2019 à 11:43, Francesco Chicchiriccò 
a écrit :


Hi all,
a recent conversation on Twitter [1] with Oliver Drotbohm, Spring Data
project lead, highlighted the need to clarify what is the JPA spec level
implemented by the various OpenJPA releases; for such a purpose, [2] was
opened.

I personally believe it is quite important to timely react, and I also
offer my availability to align the various docs, if no one else steps
in; for such a purpose, however, I would really appreciate some kind of
draft statements like as follows:

* OpenJPA 2.x - fully implements JPA 2.0 specs, pass JPA TCK
* OpenJPA 3.0.0 - depends on JPA 2.1 specs, JPA TCK not available at
release time - missing JPA 2.1 features: A,B,C...
* OpenJPA 3.0.1 - not released yet, depends on JPA 2.2 specs, JPA TCK
compliance not yet verified - missing JPA 2.2 features: D,E,F...

WDYT?
Regards.

[1] https://twitter.com/odrotbohm/status/1081713555290972160
[2] https://issues.apache.org/jira/browse/OPENJPA-2765


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

About JPA spec compliance

[Francesco Chicchiriccò]

Hi all,
a recent conversation on Twitter [1] with Oliver Drotbohm, Spring Data 
project lead, highlighted the need to clarify what is the JPA spec level 
implemented by the various OpenJPA releases; for such a purpose, [2] was 
opened.


I personally believe it is quite important to timely react, and I also 
offer my availability to align the various docs, if no one else steps 
in; for such a purpose, however, I would really appreciate some kind of 
draft statements like as follows:


* OpenJPA 2.x - fully implements JPA 2.0 specs, pass JPA TCK
* OpenJPA 3.0.0 - depends on JPA 2.1 specs, JPA TCK not available at 
release time - missing JPA 2.1 features: A,B,C...
* OpenJPA 3.0.1 - not released yet, depends on JPA 2.2 specs, JPA TCK 
compliance not yet verified - missing JPA 2.2 features: D,E,F...


WDYT?
Regards.

[1] https://twitter.com/odrotbohm/status/1081713555290972160
[2] https://issues.apache.org/jira/browse/OPENJPA-2765

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Struggling with buildbot

[Francesco Chicchiriccò]

Hum, it seems that apache-openjpa-*-binary.zip was needed, after all:

https://ci.apache.org/builders/openjpa-master-docs/builds/20

Good news is that now compilation seems to work fine, thanks!

On 06/12/18 10:53, Maxim Solodovnik wrote:

Doc build should be fixed

Will take a look at "Cannot run program "svnversion"" errors

On Wed, 5 Dec 2018 at 19:39, Francesco Chicchiriccò 
wrote:


On 05/12/18 13:27, Maxim Solodovnik wrote:

Hello Francesco,

shall binary assemblies be created during "docs building"?
(Right now I have 2 options: turn off
creating openjpa-project/target/site/downloads/*.zip or understand why it
fails :)) )

I think it is safe to disable, as there is no download link for that in
the website; only, we'll need to adjust


https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf

Regards.


On Mon, 3 Dec 2018 at 23:34, Maxim Solodovnik 

wrote:

I can see blocks like this in output:

[INFO] --- maven-antrun-plugin:1.8:run (set subversion revision) @
openjpa-lib ---
[INFO] Executing tasks

main:
   [exec] Execute failed: java.io.IOException: Cannot run program
"svnversion" (in directory

"/home/solomax/work/tmp/openjpa/openjpa-lib"):

error=2, No such file or directory
   [exec] Execute failed: java.io.IOException: Cannot run program

"svn"

(in directory "/home/solomax/work/tmp/openjpa/openjpa-lib"): error=2, No
such file or directory
 [delete] Deleting:
/home/solomax/work/tmp/openjpa/openjpa-lib/pcenhancer.revision.file
   [echo] Revision: unknown
   [echo] OpenJPA version: 3.0.1-SNAPSHOT

I believe it should be replaced with
https://www.mojohaus.org/buildnumber-maven-plugin/
with


https://www.mojohaus.org/buildnumber-maven-plugin/create-mojo.html#getRevisionOnlyOnce

option set

will try to do after build fix


On Mon, 3 Dec 2018 at 23:21, Maxim Solodovnik 
wrote:


I'm checking OpenJdk build so far
Have fixed couple of errors
will try to finish today/tomorrow

On Mon, 3 Dec 2018 at 23:19, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


On 03/12/18 16:43, Maxim Solodovnik wrote:

I'm re-checking with OpenJdk

According to builbot:

This article states:


https://shdhumale.wordpress.com/2017/06/01/how-to-remove-dmaven-multimoduleprojectdirectory-system-property-is-not-set-check-m2_home-environment-variable-and-mvn-script-match-in-eclipse/

Maven is not match with M2_HOME
Can you try to add $M2_HOME/bin to $PATH ?
Maybe it will help?

After setting PATH, the error looks in-line with yours (e.g. with

Oracle

JDK):




https://ci.apache.org/builders/openjpa-master-docs/builds/13/steps/compile/logs/stdio

...which is a good thing, IMO: now we "only" need to fix javadocs now.

Regards.


On Mon, 3 Dec 2018 at 22:13, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


On 03/12/18 15:57, Maxim Solodovnik wrote:

Just have performed the full build (mvn clean install)
It was successful

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-25T01:41:47+07:00)
Maven home: /opt/maven
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-39-generic", arch: "amd64",

family:

"unix"

Yep, same on Jenkins:

https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-trunk/


`mvn -U clean site install -DskipTests

-Pjavadoc-profile,docbook-profile`

The result is:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:aggregate

(default)

on

project openjpa-parent: An error has occurred in Javadoc report

generation:

[ERROR] Exit code: 1 -


/home/solomax/work/tmp/openjpa/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/CFMetaDataParser.java:54:

warning: no @param for name
[ERROR] protected boolean isPackageElementName(String name) {
[ERROR]   ^
   *lots of errors here*

This because you built with Oracle JDK; if you used OpenJDK,

instead,

you would have ended with same error as I reported below.


According to buildbot
Can I see job configuration?

Sure, it's on SVN:




https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf

Regards.


On Mon, 3 Dec 2018 at 19:12, Maxim Solodovnik <

solomax...@gmail.com>

wrote:

I'll double-check later tonight

Will report back later with java versions

WBR, Maxim
(from mobile, sorry for the typos)

On Mon, Dec 3, 2018, 19:08 Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 03/12/18 13:06, Maxim Solodovnik wrote:

Have you 'git pull'?

Of course: https://paste.apache.org/3SIA

Regards.


On Mon, Dec 3, 2018, 18:58 Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 03/12/18 12:47, Francesco Chicchiriccò wrote:

On 03/12/18 12:22, 

Re: Struggling with buildbot

[Francesco Chicchiriccò]

On 05/12/18 13:27, Maxim Solodovnik wrote:

Hello Francesco,

shall binary assemblies be created during "docs building"?
(Right now I have 2 options: turn off
creating openjpa-project/target/site/downloads/*.zip or understand why it
fails :)) )


I think it is safe to disable, as there is no download link for that in 
the website; only, we'll need to adjust


https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf

Regards.


On Mon, 3 Dec 2018 at 23:34, Maxim Solodovnik  wrote:


I can see blocks like this in output:

[INFO] --- maven-antrun-plugin:1.8:run (set subversion revision) @
openjpa-lib ---
[INFO] Executing tasks

main:
  [exec] Execute failed: java.io.IOException: Cannot run program
"svnversion" (in directory "/home/solomax/work/tmp/openjpa/openjpa-lib"):
error=2, No such file or directory
  [exec] Execute failed: java.io.IOException: Cannot run program "svn"
(in directory "/home/solomax/work/tmp/openjpa/openjpa-lib"): error=2, No
such file or directory
[delete] Deleting:
/home/solomax/work/tmp/openjpa/openjpa-lib/pcenhancer.revision.file
  [echo] Revision: unknown
  [echo] OpenJPA version: 3.0.1-SNAPSHOT

I believe it should be replaced with
https://www.mojohaus.org/buildnumber-maven-plugin/
with
https://www.mojohaus.org/buildnumber-maven-plugin/create-mojo.html#getRevisionOnlyOnce
option set

will try to do after build fix


On Mon, 3 Dec 2018 at 23:21, Maxim Solodovnik 
wrote:


I'm checking OpenJdk build so far
Have fixed couple of errors
will try to finish today/tomorrow

On Mon, 3 Dec 2018 at 23:19, Francesco Chicchiriccò 
wrote:


On 03/12/18 16:43, Maxim Solodovnik wrote:

I'm re-checking with OpenJdk

According to builbot:

This article states:


https://shdhumale.wordpress.com/2017/06/01/how-to-remove-dmaven-multimoduleprojectdirectory-system-property-is-not-set-check-m2_home-environment-variable-and-mvn-script-match-in-eclipse/

Maven is not match with M2_HOME
Can you try to add $M2_HOME/bin to $PATH ?
Maybe it will help?

After setting PATH, the error looks in-line with yours (e.g. with Oracle
JDK):


https://ci.apache.org/builders/openjpa-master-docs/builds/13/steps/compile/logs/stdio

...which is a good thing, IMO: now we "only" need to fix javadocs now.

Regards.


On Mon, 3 Dec 2018 at 22:13, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


On 03/12/18 15:57, Maxim Solodovnik wrote:

Just have performed the full build (mvn clean install)
It was successful

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-25T01:41:47+07:00)
Maven home: /opt/maven
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-39-generic", arch: "amd64",

family:

"unix"

Yep, same on Jenkins:

https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-trunk/


`mvn -U clean site install -DskipTests

-Pjavadoc-profile,docbook-profile`

The result is:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:aggregate

(default)

on

project openjpa-parent: An error has occurred in Javadoc report

generation:

[ERROR] Exit code: 1 -


/home/solomax/work/tmp/openjpa/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/CFMetaDataParser.java:54:

warning: no @param for name
[ERROR] protected boolean isPackageElementName(String name) {
[ERROR]   ^
  *lots of errors here*

This because you built with Oracle JDK; if you used OpenJDK, instead,
you would have ended with same error as I reported below.


According to buildbot
Can I see job configuration?

Sure, it's on SVN:




https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf

Regards.


On Mon, 3 Dec 2018 at 19:12, Maxim Solodovnik 

wrote:

I'll double-check later tonight

Will report back later with java versions

WBR, Maxim
(from mobile, sorry for the typos)

On Mon, Dec 3, 2018, 19:08 Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 03/12/18 13:06, Maxim Solodovnik wrote:

Have you 'git pull'?

Of course: https://paste.apache.org/3SIA

Regards.


On Mon, Dec 3, 2018, 18:58 Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 03/12/18 12:47, Francesco Chicchiriccò wrote:

On 03/12/18 12:22, Maxim Solodovnik wrote:

Hello Francesco,

I just have commited partial fix

The build still fails since there dozed of javadoc errors :(
Should they be suppressed or fixed?

I would vote for fixing them 

I would also like to fix them - consider that, at least on my

laptop,

the build fails with Oracle JDK 8 but succeeds with OpenJDK 8

(with

warnings).

Mmmm, no, it fails anyway as follows:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

On 04/12/18 13:25, Maxim Solodovnik wrote:

Additionally some classes are being used without "import" (to have same name)


Yep:

$ grep -r "commons\.collections" | grep "\.java" | sed 's/.*://' | sed 
's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' 
| sort | uniq

org.apache.commons.collections4.bidimap.TreeBidiMap;
org.apache.commons.collections4.comparators.ComparableComparator;
org.apache.commons.collections4.comparators.ComparatorChain;
org.apache.commons.collections4.functors.,org.apache.xalan")),
org.apache.commons.collections4.iterators.EmptyIterator;
org.apache.commons.collections4.iterators.FilterIterator;
org.apache.commons.collections4.iterators.IteratorChain;
org.apache.commons.collections4.map.
org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;
org.apache.commons.collections4.map.LinkedMap;
org.apache.commons.collections4.map.LRUMap
org.apache.commons.collections4.map.ReferenceMap
org.apache.commons.collections4.map.ReferenceMap;
org.apache.commons.collections4.Predicate;
org.apache.commons.collections4.set.MapBackedSet;


On Tue, 4 Dec 2018 at 18:42, Francesco Chicchiriccò 
wrote:


This is the list of classes from commons-collections4 we're depending on
ATM:

~/work/openjpa$ grep -r commons.collections | grep import | sed
's/.*://'  | sort | uniq
import org.apache.commons.collections4.bidimap.TreeBidiMap;
import org.apache.commons.collections4.comparators.ComparableComparator;
import org.apache.commons.collections4.comparators.ComparatorChain;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.FilterIterator;
import org.apache.commons.collections4.iterators.IteratorChain;
import
org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;
import org.apache.commons.collections4.map.LinkedMap;
import org.apache.commons.collections4.map.ReferenceMap;
import org.apache.commons.collections4.Predicate;
import org.apache.commons.collections4.set.MapBackedSet;

Not many, actually...

On 04/12/18 10:55, Maxim Solodovnik wrote:

I'm afraid the one who will drop commons-collections should have better
code-understanding than I'm :(

Here is the link to the discussion:


https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd4241ab3ae6a39d6b35e577b@%3Cuser.commons.apache.org%3E

You can raise your voice :)

On Mon, 3 Dec 2018 at 22:10, Romain Manni-Bucau 
wrote:


Does the cost to drop it is that high? Really tempted to say it is a

better

solution for openjpa anyway on the mid term.

Le lun. 3 déc. 2018 à 16:08, Maxim Solodovnik  a
écrit :


I did ping commons-collwctions community (~6 days ago) - no answer
Will ping again

On Mon, 3 Dec 2018 at 18:54, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


Hi,
did we make any progress?

FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400

Regards.

On 26/11/18 14:07, Maxim Solodovnik wrote:

Additionally commons-collections4 release is required
I'll ping commons community 

On Mon, 26 Nov 2018 at 20:01, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


Hi there,
am I correct if I think that, once commons-pool2 and commons-dbcp2

are

released, we will be able to release OpenJPA 3.0.1?
We start needing its features and fixes at Syncope...

Regards.

On 2018/11/13 12:50:33, Mark Struberg wrote:
> Go for it, I already removed tons of stuff for other commons

libs

which we now do not need anymore.
>
> We still need commons-dbcp (which requires commons-pool) to be
released before OpenJPA.
>
> Will try to work on that today.
>
> LieGrue,
> strub
>
>
> > Am 13.11.2018 um 08:35 schrieb Romain Manni-Bucau :
> >
> > There is some glue code need but nothing a stream cant solve

for

most of
> > it. The main work will be the map replacement but here again,
nothing crazy
> > and worse case forking 2 classes is still worth it IMHO
> >
> > Le mar. 13 nov. 2018 07:54, Francesco Chicchiriccò a
> > écrit :
> >
> >> On 13/11/18 07:18, Romain Manni-Bucau wrote:
> >>> sounds good (but dropping a lib is too ;))
> >>
> >> Agree: is there anything from commons-collections4 that

cannot

be

> >> replaced by Java 8 features? Maybe some specialized

collection,

as

> >> CollectionUtils, IterableUtils, etc can be easily replaced.
> >>
> >> Regards.
> >>
> >>
> >>> Le mar. 13 nov. 2018 à 07:10, Maxim Solodovnik a
> >>> écrit :
> >>>
> >>>> According to this thread:
https://markmail.org/message/dnbbribu6jvzozfo
> >>>> commons-collections4
> >>>> can
> >>>> be rel

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

This is the list of classes from commons-collections4 we're depending on 
ATM:


~/work/openjpa$ grep -r commons.collections | grep import | sed 
's/.*://'  | sort | uniq

import org.apache.commons.collections4.bidimap.TreeBidiMap;
import org.apache.commons.collections4.comparators.ComparableComparator;
import org.apache.commons.collections4.comparators.ComparatorChain;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.FilterIterator;
import org.apache.commons.collections4.iterators.IteratorChain;
import 
org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;

import org.apache.commons.collections4.map.LinkedMap;
import org.apache.commons.collections4.map.ReferenceMap;
import org.apache.commons.collections4.Predicate;
import org.apache.commons.collections4.set.MapBackedSet;

Not many, actually...

On 04/12/18 10:55, Maxim Solodovnik wrote:

I'm afraid the one who will drop commons-collections should have better
code-understanding than I'm :(

Here is the link to the discussion:
https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd4241ab3ae6a39d6b35e577b@%3Cuser.commons.apache.org%3E

You can raise your voice :)

On Mon, 3 Dec 2018 at 22:10, Romain Manni-Bucau 
wrote:


Does the cost to drop it is that high? Really tempted to say it is a better
solution for openjpa anyway on the mid term.

Le lun. 3 déc. 2018 à 16:08, Maxim Solodovnik  a
écrit :


I did ping commons-collwctions community (~6 days ago) - no answer
Will ping again

On Mon, 3 Dec 2018 at 18:54, Francesco Chicchiriccò 
Hi,
did we make any progress?

FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400

Regards.

On 26/11/18 14:07, Maxim Solodovnik wrote:

Additionally commons-collections4 release is required
I'll ping commons community 

On Mon, 26 Nov 2018 at 20:01, Francesco Chicchiriccò <

ilgro...@apache.org>

wrote:


Hi there,
am I correct if I think that, once commons-pool2 and commons-dbcp2

are

released, we will be able to release OpenJPA 3.0.1?
We start needing its features and fixes at Syncope...

Regards.

On 2018/11/13 12:50:33, Mark Struberg wrote:
   > Go for it, I already removed tons of stuff for other commons

libs

which we now do not need anymore.
   >
   > We still need commons-dbcp (which requires commons-pool) to be
released before OpenJPA.
   >
   > Will try to work on that today.
   >
   > LieGrue,
   > strub
   >
   >
   > > Am 13.11.2018 um 08:35 schrieb Romain Manni-Bucau :
   > >
   > > There is some glue code need but nothing a stream cant solve

for

most of
   > > it. The main work will be the map replacement but here again,
nothing crazy
   > > and worse case forking 2 classes is still worth it IMHO
   > >
   > > Le mar. 13 nov. 2018 07:54, Francesco Chicchiriccò a
   > > écrit :
   > >
   > >> On 13/11/18 07:18, Romain Manni-Bucau wrote:
   > >>> sounds good (but dropping a lib is too ;))
   > >>
   > >> Agree: is there anything from commons-collections4 that

cannot

be

   > >> replaced by Java 8 features? Maybe some specialized

collection,

as

   > >> CollectionUtils, IterableUtils, etc can be easily replaced.
   > >>
   > >> Regards.
   > >>
   > >>
   > >>> Le mar. 13 nov. 2018 à 07:10, Maxim Solodovnik a
   > >>> écrit :
   > >>>
   > >>>> According to this thread:
https://markmail.org/message/dnbbribu6jvzozfo
   > >>>> commons-collections4
   > >>>> can
   > >>>> be released in a week or so ...
   > >>>>
   > >>>> On Tue, 13 Nov 2018 at 13:04, Romain Manni-Bucau > >>>
   > >>>> wrote:
   > >>>>
   > >>>>> yep,
   > >>>>>
   > >>>>> side note: did a quick review and I guess we can drop
   > >> commons-collections
   > >>>>> with not much effort since we are on java8, pool2 and

dbcp2

can

   > >> probably
   > >>>>> too writing a thin pool for tests (like a Queue wrapper)

but

can

   > >> require
   > >>>>> more adaptation
   > >>>>>
   > >>>>> Le mar. 13 nov. 2018 à 06:43, Maxim Solodovnik
   > >> a
   > >>>>> écrit :
   > >>>>>
   > >>>>> Currently there are 3 SNAPSHOT dependencies
   > >>>>> I'm continuously pinging commons-collections
   > >>>>>
   > >>>>> Other 2 are commons-pool2 and commons-dbcp2 (introduced in
   > >>>>> https://github.com/apache/openjpa/pull/24, currently not

merged)

   > >>>>>
   > >>>>

Re: Struggling with buildbot

[Francesco Chicchiriccò]

On 03/12/18 16:43, Maxim Solodovnik wrote:

I'm re-checking with OpenJdk

According to builbot:

This article states:
https://shdhumale.wordpress.com/2017/06/01/how-to-remove-dmaven-multimoduleprojectdirectory-system-property-is-not-set-check-m2_home-environment-variable-and-mvn-script-match-in-eclipse/

Maven is not match with M2_HOME
Can you try to add $M2_HOME/bin to $PATH ?
Maybe it will help?


After setting PATH, the error looks in-line with yours (e.g. with Oracle 
JDK):


https://ci.apache.org/builders/openjpa-master-docs/builds/13/steps/compile/logs/stdio

...which is a good thing, IMO: now we "only" need to fix javadocs now.

Regards.


On Mon, 3 Dec 2018 at 22:13, Francesco Chicchiriccò 
wrote:


On 03/12/18 15:57, Maxim Solodovnik wrote:

Just have performed the full build (mvn clean install)
It was successful

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-25T01:41:47+07:00)
Maven home: /opt/maven
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-39-generic", arch: "amd64", family:
"unix"

Yep, same on Jenkins:

https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-trunk/


`mvn -U clean site install -DskipTests -Pjavadoc-profile,docbook-profile`
The result is:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:aggregate (default)

on

project openjpa-parent: An error has occurred in Javadoc report

generation:

[ERROR] Exit code: 1 -


/home/solomax/work/tmp/openjpa/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/CFMetaDataParser.java:54:

warning: no @param for name
[ERROR] protected boolean isPackageElementName(String name) {
[ERROR]   ^
 *lots of errors here*

This because you built with Oracle JDK; if you used OpenJDK, instead,
you would have ended with same error as I reported below.


According to buildbot
Can I see job configuration?

Sure, it's on SVN:


https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf

Regards.


On Mon, 3 Dec 2018 at 19:12, Maxim Solodovnik 

wrote:

I'll double-check later tonight

Will report back later with java versions

WBR, Maxim
(from mobile, sorry for the typos)

On Mon, Dec 3, 2018, 19:08 Francesco Chicchiriccò 
On 03/12/18 13:06, Maxim Solodovnik wrote:

Have you 'git pull'?

Of course: https://paste.apache.org/3SIA

Regards.


On Mon, Dec 3, 2018, 18:58 Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 03/12/18 12:47, Francesco Chicchiriccò wrote:

On 03/12/18 12:22, Maxim Solodovnik wrote:

Hello Francesco,

I just have commited partial fix

The build still fails since there dozed of javadoc errors :(
Should they be suppressed or fixed?

I would vote for fixing them 

I would also like to fix them - consider that, at least on my

laptop,

the build fails with Oracle JDK 8 but succeeds with OpenJDK 8 (with
warnings).

Mmmm, no, it fails anyway as follows:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle
(default) on project openjpa-tools: An error has occurred in

Checkstyle

report generation.: Failed during checkstyle execution: Unable to

find

configuration file at location:


/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml:

Could not find resource


'/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml'.

-> [Help 1]

Regards.


buildbot, however, has always the same error:



https://ci.apache.org/builders/openjpa-master-docs/builds/11/steps/compile/logs/stdio

Regards.


On Mon, 3 Dec 2018 at 18:00, Francesco Chicchiriccò

wrote:


On 03/12/18 11:58, Maxim Solodovnik wrote:

I see the issue, will try to fix ASAP (most probably be caused by

my

latest

plugin update)
Will report back to this thread

Thanks.

Regards.


On Mon, 3 Dec 2018 at 17:55, Francesco Chicchiriccò


wrote:

On 03/12/18 11:45, Maxim Solodovnik wrote:

"Unknown packaging: bundle" can be ignored (should be treated

as

warning)

I have started thread regarding thin on Mavel list
https://markmail.org/message/jbvxgemsaahk6ern
(was unable to provide PR :(( )

I can try to reproduce your error on my laptop
what command doesn't work for you?

The one that was configured in buildbot, e.g.

mvn -U clean site install -DskipTests
-Pjavadoc-profile,docbook-profile


On Mon, 3 Dec 2018 at 17:32, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 01/12/18 05:23, Maxim Solodovnik wrote:

Hello Francesco,

additional repository might be required for m2e:


https://mvnrepository.com/artifact/org.eclipse.m2e/lifecycle-mapping/1.0.0

This should by a dummy empty dependency, that's why I don't

understand.

Anyway, one of the indicated actions worked, at the end.

Now error is different:

[WARN

Re: Struggling with buildbot

[Francesco Chicchiriccò]

On 03/12/18 15:57, Maxim Solodovnik wrote:

Just have performed the full build (mvn clean install)
It was successful

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-25T01:41:47+07:00)
Maven home: /opt/maven
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-39-generic", arch: "amd64", family:
"unix"


Yep, same on Jenkins:

https://builds.apache.org/view/M-R/view/OpenJPA/job/OpenJPA-trunk/


`mvn -U clean site install -DskipTests -Pjavadoc-profile,docbook-profile`
The result is:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:aggregate (default) on
project openjpa-parent: An error has occurred in Javadoc report generation:
[ERROR] Exit code: 1 -
/home/solomax/work/tmp/openjpa/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/CFMetaDataParser.java:54:
warning: no @param for name
[ERROR] protected boolean isPackageElementName(String name) {
[ERROR]   ^
*lots of errors here*


This because you built with Oracle JDK; if you used OpenJDK, instead, 
you would have ended with same error as I reported below.



According to buildbot
Can I see job configuration?


Sure, it's on SVN:

https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf

Regards.


On Mon, 3 Dec 2018 at 19:12, Maxim Solodovnik  wrote:


I'll double-check later tonight

Will report back later with java versions

WBR, Maxim
(from mobile, sorry for the typos)

On Mon, Dec 3, 2018, 19:08 Francesco Chicchiriccò 
On 03/12/18 13:06, Maxim Solodovnik wrote:

Have you 'git pull'?

Of course: https://paste.apache.org/3SIA

Regards.


On Mon, Dec 3, 2018, 18:58 Francesco Chicchiriccò 
On 03/12/18 12:47, Francesco Chicchiriccò wrote:

On 03/12/18 12:22, Maxim Solodovnik wrote:

Hello Francesco,

I just have commited partial fix

The build still fails since there dozed of javadoc errors :(
Should they be suppressed or fixed?

I would vote for fixing them 

I would also like to fix them - consider that, at least on my laptop,
the build fails with Oracle JDK 8 but succeeds with OpenJDK 8 (with
warnings).

Mmmm, no, it fails anyway as follows:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle
(default) on project openjpa-tools: An error has occurred in Checkstyle
report generation.: Failed during checkstyle execution: Unable to find
configuration file at location:


/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml:

Could not find resource


'/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml'.

-> [Help 1]

Regards.


buildbot, however, has always the same error:



https://ci.apache.org/builders/openjpa-master-docs/builds/11/steps/compile/logs/stdio

Regards.


On Mon, 3 Dec 2018 at 18:00, Francesco Chicchiriccò

wrote:


On 03/12/18 11:58, Maxim Solodovnik wrote:

I see the issue, will try to fix ASAP (most probably be caused by

my

latest

plugin update)
Will report back to this thread

Thanks.

Regards.


On Mon, 3 Dec 2018 at 17:55, Francesco Chicchiriccò


wrote:

On 03/12/18 11:45, Maxim Solodovnik wrote:

"Unknown packaging: bundle" can be ignored (should be treated as

warning)

I have started thread regarding thin on Mavel list
https://markmail.org/message/jbvxgemsaahk6ern
(was unable to provide PR :(( )

I can try to reproduce your error on my laptop
what command doesn't work for you?

The one that was configured in buildbot, e.g.

mvn -U clean site install -DskipTests
-Pjavadoc-profile,docbook-profile


On Mon, 3 Dec 2018 at 17:32, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 01/12/18 05:23, Maxim Solodovnik wrote:

Hello Francesco,

additional repository might be required for m2e:


https://mvnrepository.com/artifact/org.eclipse.m2e/lifecycle-mapping/1.0.0

This should by a dummy empty dependency, that's why I don't

understand.

Anyway, one of the indicated actions worked, at the end.

Now error is different:

[WARNING] Unable to create Maven project for
org.postgresql:postgresql:jar:42.2.5 from repository.
org.apache.maven.project.ProjectBuildingException: Some problems
were
encountered while processing the POMs:
[ERROR] Unknown packaging: bundle @ line 11, column 14


According to system property, I believe you can add it to maven

command

line, or not?

I did, but it did not work.


BTW why both Jenkins and buildbot are required?

buildbot is supposed to build and deploy the SNAPSHOT docs;
Jenkins to
build and deploy SNAPSHOT artifacts.

On Fri, 30 Nov 2018 at 22:25, Francesco Chicchiriccò <

ilgro...@apache.org> wrote:

Hi all,
it seems I am not as lucky with buildbot as I've been with
Jenkins:
coming to [1] with same purpose, I am now in the situation

where

Re: Struggling with buildbot

[Francesco Chicchiriccò]

On 03/12/18 13:06, Maxim Solodovnik wrote:

Have you 'git pull'?


Of course: https://paste.apache.org/3SIA

Regards.


On Mon, Dec 3, 2018, 18:58 Francesco Chicchiriccò 
On 03/12/18 12:47, Francesco Chicchiriccò wrote:

On 03/12/18 12:22, Maxim Solodovnik wrote:

Hello Francesco,

I just have commited partial fix

The build still fails since there dozed of javadoc errors :(
Should they be suppressed or fixed?

I would vote for fixing them 

I would also like to fix them - consider that, at least on my laptop,
the build fails with Oracle JDK 8 but succeeds with OpenJDK 8 (with
warnings).

Mmmm, no, it fails anyway as follows:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle
(default) on project openjpa-tools: An error has occurred in Checkstyle
report generation.: Failed during checkstyle execution: Unable to find
configuration file at location:
/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml:

Could not find resource
'/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml'.

-> [Help 1]

Regards.


buildbot, however, has always the same error:



https://ci.apache.org/builders/openjpa-master-docs/builds/11/steps/compile/logs/stdio


Regards.


On Mon, 3 Dec 2018 at 18:00, Francesco Chicchiriccò

wrote:


On 03/12/18 11:58, Maxim Solodovnik wrote:

I see the issue, will try to fix ASAP (most probably be caused by my

latest

plugin update)
Will report back to this thread

Thanks.

Regards.


On Mon, 3 Dec 2018 at 17:55, Francesco Chicchiriccò


wrote:

On 03/12/18 11:45, Maxim Solodovnik wrote:

"Unknown packaging: bundle" can be ignored (should be treated as

warning)

I have started thread regarding thin on Mavel list
https://markmail.org/message/jbvxgemsaahk6ern
(was unable to provide PR :(( )

I can try to reproduce your error on my laptop
what command doesn't work for you?

The one that was configured in buildbot, e.g.

mvn -U clean site install -DskipTests
-Pjavadoc-profile,docbook-profile


On Mon, 3 Dec 2018 at 17:32, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 01/12/18 05:23, Maxim Solodovnik wrote:

Hello Francesco,

additional repository might be required for m2e:


https://mvnrepository.com/artifact/org.eclipse.m2e/lifecycle-mapping/1.0.0

This should by a dummy empty dependency, that's why I don't

understand.

Anyway, one of the indicated actions worked, at the end.

Now error is different:

[WARNING] Unable to create Maven project for
org.postgresql:postgresql:jar:42.2.5 from repository.
org.apache.maven.project.ProjectBuildingException: Some problems
were
encountered while processing the POMs:
[ERROR] Unknown packaging: bundle @ line 11, column 14


According to system property, I believe you can add it to maven

command

line, or not?

I did, but it did not work.


BTW why both Jenkins and buildbot are required?

buildbot is supposed to build and deploy the SNAPSHOT docs;
Jenkins to
build and deploy SNAPSHOT artifacts.

On Fri, 30 Nov 2018 at 22:25, Francesco Chicchiriccò <

ilgro...@apache.org> wrote:

Hi all,
it seems I am not as lucky with buildbot as I've been with
Jenkins:
coming to [1] with same purpose, I am now in the situation where

both

openjpa-master-docs [2] and openjpa-2.4.x-docs [3] fail because

-Dmaven.multiModuleProjectDirectory system property is not set

However, if I attempt to run the build command

mvn -U clean site install -DskipTests
-Pjavadoc-profile,docbook-profile

on my own laptop, I get a different error:

Error resolving project artifact: Failure to find
org.eclipse.m2e:lifecycle-mapping:pom:1.0.0

Any clue?
Regards.

[1] 
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf
[2] https://ci.apache.org/builders/openjpa-master-docs/
[3] https://ci.apache.org/builders/openjpa-2.4.x-docs/


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Struggling with buildbot

[Francesco Chicchiriccò]

On 03/12/18 12:47, Francesco Chicchiriccò wrote:

On 03/12/18 12:22, Maxim Solodovnik wrote:

Hello Francesco,

I just have commited partial fix

The build still fails since there dozed of javadoc errors :(
Should they be suppressed or fixed?

I would vote for fixing them 


I would also like to fix them - consider that, at least on my laptop, 
the build fails with Oracle JDK 8 but succeeds with OpenJDK 8 (with 
warnings).


Mmmm, no, it fails anyway as follows:

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle 
(default) on project openjpa-tools: An error has occurred in Checkstyle 
report generation.: Failed during checkstyle execution: Unable to find 
configuration file at location: 
/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml: 
Could not find resource 
'/home/ilgrosso/work/openjpa/openjpa-tools/../../openjpa-project/checkstyle.xml'. 
-> [Help 1]


Regards.


buildbot, however, has always the same error:

https://ci.apache.org/builders/openjpa-master-docs/builds/11/steps/compile/logs/stdio 



Regards.

On Mon, 3 Dec 2018 at 18:00, Francesco Chicchiriccò 


wrote:


On 03/12/18 11:58, Maxim Solodovnik wrote:

I see the issue, will try to fix ASAP (most probably be caused by my

latest

plugin update)
Will report back to this thread

Thanks.

Regards.

On Mon, 3 Dec 2018 at 17:55, Francesco Chicchiriccò 


wrote:

On 03/12/18 11:45, Maxim Solodovnik wrote:

"Unknown packaging: bundle" can be ignored (should be treated as

warning)

I have started thread regarding thin on Mavel list
https://markmail.org/message/jbvxgemsaahk6ern
(was unable to provide PR :(( )

I can try to reproduce your error on my laptop
what command doesn't work for you?

The one that was configured in buildbot, e.g.

mvn -U clean site install -DskipTests 
-Pjavadoc-profile,docbook-profile



On Mon, 3 Dec 2018 at 17:32, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 01/12/18 05:23, Maxim Solodovnik wrote:

Hello Francesco,

additional repository might be required for m2e:

https://mvnrepository.com/artifact/org.eclipse.m2e/lifecycle-mapping/1.0.0 


This should by a dummy empty dependency, that's why I don't

understand.

Anyway, one of the indicated actions worked, at the end.

Now error is different:

[WARNING] Unable to create Maven project for
org.postgresql:postgresql:jar:42.2.5 from repository.
org.apache.maven.project.ProjectBuildingException: Some problems 
were

encountered while processing the POMs:
[ERROR] Unknown packaging: bundle @ line 11, column 14


According to system property, I believe you can add it to maven

command

line, or not?

I did, but it did not work.


BTW why both Jenkins and buildbot are required?
buildbot is supposed to build and deploy the SNAPSHOT docs; 
Jenkins to

build and deploy SNAPSHOT artifacts.

On Fri, 30 Nov 2018 at 22:25, Francesco Chicchiriccò <

ilgro...@apache.org> wrote:

Hi all,
it seems I am not as lucky with buildbot as I've been with 
Jenkins:

coming to [1] with same purpose, I am now in the situation where

both

openjpa-master-docs [2] and openjpa-2.4.x-docs [3] fail because

-Dmaven.multiModuleProjectDirectory system property is not set

However, if I attempt to run the build command

mvn -U clean site install -DskipTests 
-Pjavadoc-profile,docbook-profile


on my own laptop, I get a different error:

Error resolving project artifact: Failure to find
org.eclipse.m2e:lifecycle-mapping:pom:1.0.0

Any clue?
Regards.

[1] 
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf

[2] https://ci.apache.org/builders/openjpa-master-docs/
[3] https://ci.apache.org/builders/openjpa-2.4.x-docs/




--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Is it time for 3.0.1 release?

[Francesco Chicchiriccò]

Hi,
did we make any progress?

FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400

Regards.

On 26/11/18 14:07, Maxim Solodovnik wrote:

Additionally commons-collections4 release is required
I'll ping commons community 

On Mon, 26 Nov 2018 at 20:01, Francesco Chicchiriccò 
wrote:


Hi there,
am I correct if I think that, once commons-pool2 and commons-dbcp2 are
released, we will be able to release OpenJPA 3.0.1?
We start needing its features and fixes at Syncope...

Regards.

On 2018/11/13 12:50:33, Mark Struberg wrote:
  > Go for it, I already removed tons of stuff for other commons libs
which we now do not need anymore.
  >
  > We still need commons-dbcp (which requires commons-pool) to be
released before OpenJPA.
  >
  > Will try to work on that today.
  >
  > LieGrue,
  > strub
  >
  >
  > > Am 13.11.2018 um 08:35 schrieb Romain Manni-Bucau :
  > >
  > > There is some glue code need but nothing a stream cant solve for
most of
  > > it. The main work will be the map replacement but here again,
nothing crazy
  > > and worse case forking 2 classes is still worth it IMHO
  > >
  > > Le mar. 13 nov. 2018 07:54, Francesco Chicchiriccò a
  > > écrit :
  > >
  > >> On 13/11/18 07:18, Romain Manni-Bucau wrote:
  > >>> sounds good (but dropping a lib is too ;))
  > >>
  > >> Agree: is there anything from commons-collections4 that cannot be
  > >> replaced by Java 8 features? Maybe some specialized collection, as
  > >> CollectionUtils, IterableUtils, etc can be easily replaced.
  > >>
  > >> Regards.
  > >>
  > >>
  > >>> Le mar. 13 nov. 2018 à 07:10, Maxim Solodovnik a
  > >>> écrit :
  > >>>
  > >>>> According to this thread:
https://markmail.org/message/dnbbribu6jvzozfo
  > >>>> commons-collections4
  > >>>> can
  > >>>> be released in a week or so ...
  > >>>>
  > >>>> On Tue, 13 Nov 2018 at 13:04, Romain Manni-Bucau > >>>
  > >>>> wrote:
  > >>>>
  > >>>>> yep,
  > >>>>>
  > >>>>> side note: did a quick review and I guess we can drop
  > >> commons-collections
  > >>>>> with not much effort since we are on java8, pool2 and dbcp2 can
  > >> probably
  > >>>>> too writing a thin pool for tests (like a Queue wrapper) but can
  > >> require
  > >>>>> more adaptation
  > >>>>>
  > >>>>> Le mar. 13 nov. 2018 à 06:43, Maxim Solodovnik
  > >> a
  > >>>>> écrit :
  > >>>>>
  > >>>>> Currently there are 3 SNAPSHOT dependencies
  > >>>>> I'm continuously pinging commons-collections
  > >>>>>
  > >>>>> Other 2 are commons-pool2 and commons-dbcp2 (introduced in
  > >>>>> https://github.com/apache/openjpa/pull/24, currently not merged)
  > >>>>>
  > >>>>> I guess we should get these new releases first
  > >>>>>
  > >>>>>
  > >>>>> On Tue, 13 Nov 2018 at 12:39, Romain Manni-Bucau <
  > >> rmannibu...@gmail.com> wrote:
  > >>>>>>> Hi Maxim
  > >>>>>>>
  > >>>>>>> Tomee is waiting for a java11 release - mainly asm upgrade.
  > >>>>>>> Once done +1
  > >>>>>>>
  > >>>>>>> Le mar. 13 nov. 2018 05:03, Maxim Solodovnik
  > >> a écrit :
  > >>>>>>>> Hello All,
  > >>>>>>>>
  > >>>>>>>> 3.0.0 was release in June, lots of fixes were committed
  > >>>>>>>> Maybe it's time for release?
  > >>>>>>>>
  > >>>>>>>> --
  > >>>>>>>> WBR
  > >>>>>>>> Maxim aka solomax
  > >>>>>>>>
  > >>>>>>
  > >>>>>> --
  > >>>>>> WBR
  > >>>>>> Maxim aka solomax
  > >>>>>>
  > >>>>
  > >>>> --
  > >>>> WBR
  > >>>> Maxim aka solomax


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: Struggling with buildbot

[Francesco Chicchiriccò]

On 03/12/18 12:22, Maxim Solodovnik wrote:

Hello Francesco,

I just have commited partial fix

The build still fails since there dozed of javadoc errors :(
Should they be suppressed or fixed?

I would vote for fixing them 


I would also like to fix them - consider that, at least on my laptop, 
the build fails with Oracle JDK 8 but succeeds with OpenJDK 8 (with 
warnings).


buildbot, however, has always the same error:

https://ci.apache.org/builders/openjpa-master-docs/builds/11/steps/compile/logs/stdio

Regards.


On Mon, 3 Dec 2018 at 18:00, Francesco Chicchiriccò 
wrote:


On 03/12/18 11:58, Maxim Solodovnik wrote:

I see the issue, will try to fix ASAP (most probably be caused by my

latest

plugin update)
Will report back to this thread

Thanks.

Regards.


On Mon, 3 Dec 2018 at 17:55, Francesco Chicchiriccò 

wrote:

On 03/12/18 11:45, Maxim Solodovnik wrote:

"Unknown packaging: bundle" can be ignored (should be treated as

warning)

I have started thread regarding thin on Mavel list
https://markmail.org/message/jbvxgemsaahk6ern
(was unable to provide PR :(( )

I can try to reproduce your error on my laptop
what command doesn't work for you?

The one that was configured in buildbot, e.g.

mvn -U clean site install -DskipTests -Pjavadoc-profile,docbook-profile


On Mon, 3 Dec 2018 at 17:32, Francesco Chicchiriccò <

ilgro...@apache.org

wrote:


On 01/12/18 05:23, Maxim Solodovnik wrote:

Hello Francesco,

additional repository might be required for m2e:


https://mvnrepository.com/artifact/org.eclipse.m2e/lifecycle-mapping/1.0.0

This should by a dummy empty dependency, that's why I don't

understand.

Anyway, one of the indicated actions worked, at the end.

Now error is different:

[WARNING] Unable to create Maven project for
org.postgresql:postgresql:jar:42.2.5 from repository.
org.apache.maven.project.ProjectBuildingException: Some problems were
encountered while processing the POMs:
[ERROR] Unknown packaging: bundle @ line 11, column 14


According to system property, I believe you can add it to maven

command

line, or not?

I did, but it did not work.


BTW why both Jenkins and buildbot are required?

buildbot is supposed to build and deploy the SNAPSHOT docs; Jenkins to
build and deploy SNAPSHOT artifacts.

On Fri, 30 Nov 2018 at 22:25, Francesco Chicchiriccò <

ilgro...@apache.org> wrote:

Hi all,
it seems I am not as lucky with buildbot as I've been with Jenkins:
coming to [1] with same purpose, I am now in the situation where

both

openjpa-master-docs [2] and openjpa-2.4.x-docs [3] fail because

-Dmaven.multiModuleProjectDirectory system property is not set

However, if I attempt to run the build command

mvn -U clean site install -DskipTests -Pjavadoc-profile,docbook-profile

on my own laptop, I get a different error:

Error resolving project artifact: Failure to find
org.eclipse.m2e:lifecycle-mapping:pom:1.0.0

Any clue?
Regards.

[1] 
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/openjpa.conf
[2] https://ci.apache.org/builders/openjpa-master-docs/
[3] https://ci.apache.org/builders/openjpa-2.4.x-docs/


--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/