[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r807497937 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordReader.java ## @@ -265,4 +273,51 @@ public boolean nextK

[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r807496854 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordReader.java ## @@ -69,6 +71,8 @@ private long current

[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r807496556 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java ## @@ -248,15 +248,18 @@ public DictionaryPage

[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r807496428 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1400,34 +1400,67 @@ public Par

[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r807495498 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1400,34 +1400,67 @@ public Par

[GitHub] [parquet-mr] rshkv commented on pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

rshkv commented on pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#issuecomment-1040188533 Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [parquet-mr] sekikn commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

sekikn commented on a change in pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806426714 ## File path: README.md ## @@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here * Type-specific encoding

[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

shangxinli commented on pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1039353753 @sekikn Thanks for working on it! Just leave some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

shangxinli commented on a change in pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806064746 ## File path: README.md ## @@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here * Type-specific encod

[GitHub] [parquet-mr] shangxinli commented on pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

shangxinli commented on pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#issuecomment-1039360003 Thanks for working on it! Can you squash the commits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [parquet-mr] rshkv commented on pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

rshkv commented on pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#issuecomment-1040188533 Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [parquet-mr] sekikn commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

sekikn commented on a change in pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806426714 ## File path: README.md ## @@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here * Type-specific encoding

[GitHub] [parquet-mr] shangxinli commented on pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

shangxinli commented on pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#issuecomment-1039360003 Thanks for working on it! Can you squash the commits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

shangxinli commented on pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1039353753 @sekikn Thanks for working on it! Just leave some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

shangxinli commented on a change in pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806064746 ## File path: README.md ## @@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here * Type-specific encod

[GitHub] [parquet-mr] sekikn opened a new pull request #947: PARQUET-2121: Remove descriptions for the removed modules

sekikn opened a new pull request #947: URL: https://github.com/apache/parquet-mr/pull/947 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in th

[GitHub] [parquet-mr] rshkv commented on a change in pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

rshkv commented on a change in pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#discussion_r805173716 ## File path: parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java ## @@ -75,40 +75,12 @@ public int run() throws IOExcept

[GitHub] [parquet-mr] rshkv commented on a change in pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

rshkv commented on a change in pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#discussion_r805174327 ## File path: parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java ## @@ -75,40 +75,12 @@ public int run() throws IOExcept

[GitHub] [parquet-mr] rshkv commented on a change in pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

rshkv commented on a change in pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#discussion_r805174016 ## File path: parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java ## @@ -122,6 +94,41 @@ public int run() throws IOExcept

[GitHub] [parquet-mr] rshkv commented on a change in pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

rshkv commented on a change in pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#discussion_r805173968 ## File path: parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java ## @@ -75,40 +75,12 @@ public int run() throws IOExcept

[GitHub] [parquet-mr] rshkv commented on a change in pull request #946: PARQUET-2120: Dictionary command should handle missing dictionary pages

rshkv commented on a change in pull request #946: URL: https://github.com/apache/parquet-mr/pull/946#discussion_r805173716 ## File path: parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java ## @@ -75,40 +75,12 @@ public int run() throws IOExcept

[GitHub] [parquet-mr] rshkv opened a new pull request #946: PARQUET-2120: CLI dictionary command should not fail on missing dictionary pages

rshkv opened a new pull request #946: URL: https://github.com/apache/parquet-mr/pull/946 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the

[GitHub] [parquet-mr] shangxinli commented on pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#issuecomment-1036746521 We need more test to cover old parquet data that doesn't have column index. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805065376 ## File path: parquet-hadoop/src/test/java/org/apache/parquet/filter2/recordlevel/PhoneBookWriter.java ## @@ -340,12 +342,21 @@ public static void wr

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805065458 ## File path: parquet-hadoop/src/test/java/org/apache/parquet/filter2/recordlevel/PhoneBookWriter.java ## @@ -315,7 +317,7 @@ public static void writ

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805062241 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1400,34 +1400,67 @@ public Parque

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805060344 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1400,34 +1400,67 @@ public Parque

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805053725 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordReader.java ## @@ -265,4 +273,51 @@ public boolean nextKeyV

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805052859 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordReader.java ## @@ -265,4 +273,51 @@ public boolean nextKeyV

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805052003 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordReader.java ## @@ -69,6 +71,8 @@ private long current =

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805044955 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java ## @@ -265,6 +268,11 @@ public long getRowCount()

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r805042201 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java ## @@ -248,15 +248,18 @@ public DictionaryPage rea

[GitHub] [parquet-mr] prakharjain09 commented on pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#issuecomment-1036460871 > [](https://github.com/prakharjain09)Can you squash the commits to make the review easier? done -- This is an automated message from the Apache Git Service. To

[GitHub] [parquet-mr] shangxinli edited a comment on pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

shangxinli edited a comment on pull request #944: URL: https://github.com/apache/parquet-mr/pull/944#issuecomment-1029589658 > vinooganesh Thanks @vinooganesh for verifying this! @Yikf Given one more person can build without the change, I am assuming it is your local setup issue. Let

[GitHub] [parquet-mr] shangxinli commented on pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

shangxinli commented on pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#issuecomment-1036445953 Can you squash the commits to make the review easier? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [parquet-mr] prakharjain09 commented on pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#issuecomment-1031713582 @shangxinli @gszadovszky Please review the changes when you get chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on a change in pull request #945: URL: https://github.com/apache/parquet-mr/pull/945#discussion_r800879793 ## File path: parquet-column/src/main/java/org/apache/parquet/column/page/PageReadStore.java ## @@ -43,6 +43,14 @@ */ long getRowCount();

[GitHub] [parquet-mr] prakharjain09 opened a new pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 opened a new pull request #945: URL: https://github.com/apache/parquet-mr/pull/945 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references the

[GitHub] [parquet-mr] shangxinli commented on pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

shangxinli commented on pull request #944: URL: https://github.com/apache/parquet-mr/pull/944#issuecomment-1029589658 > vinooganesh Thanks @vinooganesh for verifying this! @Yikf Given one more person can build with the change, I am assuming it is your local setup issue. Let me know

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #707: [PARQUET-1719] Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public

shangxinli commented on a change in pull request #707: URL: https://github.com/apache/parquet-mr/pull/707#discussion_r797956093 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java ## @@ -115,9 +115,9 @@ private ParquetReader(Configuration co

[GitHub] [parquet-mr] dssysolyatin commented on a change in pull request #707: [PARQUET-1719] Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public

dssysolyatin commented on a change in pull request #707: URL: https://github.com/apache/parquet-mr/pull/707#discussion_r794344312 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java ## @@ -104,7 +104,7 @@ public ParquetReader(Configuration c

[GitHub] [parquet-mr] vinooganesh commented on pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

vinooganesh commented on pull request #944: URL: https://github.com/apache/parquet-mr/pull/944#issuecomment-1023464558 It seems like mine works without the change as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [parquet-mr] harsh-tamr commented on a change in pull request #707: [PARQUET-1719] Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public

harsh-tamr commented on a change in pull request #707: URL: https://github.com/apache/parquet-mr/pull/707#discussion_r793802965 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java ## @@ -104,7 +104,7 @@ public ParquetReader(Configuration con

[GitHub] [parquet-mr] shangxinli commented on pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

shangxinli commented on pull request #944: URL: https://github.com/apache/parquet-mr/pull/944#issuecomment-1023337477 @Yikf I tried on my laptop with MAC OS without having your change and it succeeded the build. I guess you may have something missed in your local setup. Anybody else

[GitHub] [parquet-mr] Yikf commented on a change in pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

Yikf commented on a change in pull request #944: URL: https://github.com/apache/parquet-mr/pull/944#discussion_r793205579 ## File path: pom.xml ## @@ -91,6 +91,7 @@ h2 0.10.0 0.15.0 +3.3.1 Review comment: Thanks a lot for your reminder, updated --

[GitHub] [parquet-mr] vinooganesh commented on a change in pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

vinooganesh commented on a change in pull request #944: URL: https://github.com/apache/parquet-mr/pull/944#discussion_r792609226 ## File path: pom.xml ## @@ -91,6 +91,7 @@ h2 0.10.0 0.15.0 +3.3.1 Review comment: @Yikf - I think you're missing the "c"

[GitHub] [parquet-mr] Yikf commented on pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

Yikf commented on pull request #944: URL: https://github.com/apache/parquet-mr/pull/944#issuecomment-1022085407 @shangxinli Could you help take a look when you have a time, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [parquet-mr] Yikf opened a new pull request #944: [PARQUET-2113]BUILD] Fix build failure with specified thrift and mvn command

Yikf opened a new pull request #944: URL: https://github.com/apache/parquet-mr/pull/944 I git clone parquet-mr project with latest version and i build on branch master, i met the build failure with thrift version and mvn command specified as describe in README.md, env as follows: yi

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #943: PARQUET-2112: Fix typo in MessageColumnIO

shangxinli commented on a change in pull request #943: URL: https://github.com/apache/parquet-mr/pull/943#discussion_r790988892 ## File path: parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java ## @@ -186,32 +186,32 @@ private int currentLevel = 0;

[GitHub] [parquet-mr] shangxinli merged pull request #943: PARQUET-2112: Fix typo in MessageColumnIO

shangxinli merged pull request #943: URL: https://github.com/apache/parquet-mr/pull/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [parquet-format] markandrus opened a new pull request #182: Fix typo under "Unsigned Integers"

markandrus opened a new pull request #182: URL: https://github.com/apache/parquet-format/pull/182 I'm pretty sure that, under "Unsigned Integers", we should say > …and `INT(64, false)` must annotate… rather than > …and `INT(64, true)` must annotate… Make sure you

[GitHub] [parquet-mr] shangxinli merged pull request #943: PARQUET-2112: Fix typo in MessageColumnIO

shangxinli merged pull request #943: URL: https://github.com/apache/parquet-mr/pull/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #943: PARQUET-2112: Fix typo in MessageColumnIO

shangxinli commented on a change in pull request #943: URL: https://github.com/apache/parquet-mr/pull/943#discussion_r790988892 ## File path: parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java ## @@ -186,32 +186,32 @@ private int currentLevel = 0;

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #943: PARQUET-2112: Fix typo in MessageColumnIO

ggershinsky commented on a change in pull request #943: URL: https://github.com/apache/parquet-mr/pull/943#discussion_r790512086 ## File path: parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java ## @@ -186,32 +186,32 @@ private int currentLevel = 0;

[GitHub] [parquet-mr] shangxinli commented on pull request #943: PARQUET-2112: Fix typo in MessageColumnIO

shangxinli commented on pull request #943: URL: https://github.com/apache/parquet-mr/pull/943#issuecomment-1019590760 @ggershinsky, can you have a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [parquet-mr] shangxinli opened a new pull request #943: PARQUET-2112: Fix typo in MessageColumnIO

shangxinli opened a new pull request #943: URL: https://github.com/apache/parquet-mr/pull/943 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them i

[GitHub] [parquet-format] shangxinli edited a comment on pull request #181: PARQUET-2110: Fix Typos in LogicalTypes.md

shangxinli edited a comment on pull request #181: URL: https://github.com/apache/parquet-format/pull/181#issuecomment-1018592076 Good catch @jincongho! Thank @wesm and @emkornfield for the review! -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [parquet-format] shangxinli commented on pull request #181: PARQUET-2110: Fix Typos in LogicalTypes.md

shangxinli commented on pull request #181: URL: https://github.com/apache/parquet-format/pull/181#issuecomment-1018592076 Good catch @jincongho! Thank @wesm for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [parquet-format] wesm commented on pull request #181: PARQUET-2110: Fix Typos in LogicalTypes.md

wesm commented on pull request #181: URL: https://github.com/apache/parquet-format/pull/181#issuecomment-1016972458 I went ahead to merge. Thanks @emkornfield -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [parquet-format] wesm merged pull request #181: PARQUET-2110: Fix Typos in LogicalTypes.md

wesm merged pull request #181: URL: https://github.com/apache/parquet-format/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [parquet-format] jincongho opened a new pull request #181: PARQUET-2110: Fix Typos in LogicalTypes.md

jincongho opened a new pull request #181: URL: https://github.com/apache/parquet-format/pull/181 Fix some types on LogicalTypes.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [parquet-mr] akauppi commented on pull request #866: PARQUET-1976: Update Scala and Maven plugin versions

akauppi commented on pull request #866: URL: https://github.com/apache/parquet-mr/pull/866#issuecomment-1012229534 Looking at Parquet, with Scala 2.13 in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [parquet-site] shangxinli merged pull request #7: source/documentation/latest: update links

shangxinli merged pull request #7: URL: https://github.com/apache/parquet-site/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [parquet-site] shangxinli merged pull request #7: source/documentation/latest: update links

shangxinli merged pull request #7: URL: https://github.com/apache/parquet-site/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [parquet-site] shangxinli commented on pull request #7: source/documentation/latest: update links

shangxinli commented on pull request #7: URL: https://github.com/apache/parquet-site/pull/7#issuecomment-1006717345 @kevinburkesegment Thanks for working on it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [parquet-site] kevinburkesegment opened a new pull request #7: source/documentation/latest: update links

kevinburkesegment opened a new pull request #7: URL: https://github.com/apache/parquet-site/pull/7 The compatibility library has not been kept up to date and the Rust library previously linked to a read-only repository. Update both. I am using a M1 Mac and needed to update the ffi

[GitHub] [parquet-mr] shangxinli merged pull request #939: PARQUET-2105: Refactor the test code of creating the test file

shangxinli merged pull request #939: URL: https://github.com/apache/parquet-mr/pull/939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [parquet-mr] shangxinli closed pull request #942: Revert "Improve Travis CI build Performance (#924)"

shangxinli closed pull request #942: URL: https://github.com/apache/parquet-mr/pull/942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [parquet-mr] shangxinli commented on pull request #942: Revert "Improve Travis CI build Performance (#924)"

shangxinli commented on pull request #942: URL: https://github.com/apache/parquet-mr/pull/942#issuecomment-995001395 You are right @gszadovszky @martin-g! I will go ahead to close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [parquet-mr] shangxinli commented on pull request #942: Revert "Improve Travis CI build Performance (#924)"

shangxinli commented on pull request #942: URL: https://github.com/apache/parquet-mr/pull/942#issuecomment-994291728 In the [PR939](https://github.com/apache/parquet-mr/pull/939), it continues failing if I don't revert the change. Let me try one more time and see if that is still the case.

[GitHub] [parquet-mr] gszadovszky commented on pull request #942: Revert "Improve Travis CI build Performance (#924)"

gszadovszky commented on pull request #942: URL: https://github.com/apache/parquet-mr/pull/942#issuecomment-993587714 It seems the current shape of the Travis config is fine, there are no failures so far. I would suggest keeping as is. -- This is an automated message from the Apache Git

[GitHub] [parquet-mr] martin-g edited a comment on pull request #942: Revert "Improve Travis CI build Performance (#924)"

martin-g edited a comment on pull request #942: URL: https://github.com/apache/parquet-mr/pull/942#issuecomment-993234716 @shangxinli I thought the last working solution was to use `dist: focal` (Ubuntu 20.04) instead of `bionic` (18.04) . In #939 I see you didn't merged from master (https

[GitHub] [parquet-mr] martin-g commented on pull request #942: Revert "Improve Travis CI build Performance (#924)"

martin-g commented on pull request #942: URL: https://github.com/apache/parquet-mr/pull/942#issuecomment-993234716 @shangxinli I thought the last working solution was to use `dist: focal` (Ubuntu 20.04) instead of `bionic` (18.04) -- This is an automated message from the Apache Git Serv

[GitHub] [parquet-mr] shangxinli commented on pull request #942: Revert "Improve Travis CI build Performance (#924)"

shangxinli commented on pull request #942: URL: https://github.com/apache/parquet-mr/pull/942#issuecomment-993133482 From the [PR939](https://github.com/apache/parquet-mr/pull/939) travis result, it seems we still need to revert this change. @gszadovszky @martin-g, @YunLemon -- This

[GitHub] [parquet-mr] shangxinli opened a new pull request #942: Revert "Improve Travis CI build Performance (#924)"

shangxinli opened a new pull request #942: URL: https://github.com/apache/parquet-mr/pull/942 This reverts commit 01a5d074829ad4cf4de1f662d54fe7bceb4bef63. Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://

[GitHub] [parquet-mr] gszadovszky merged pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

gszadovszky merged pull request #940: URL: https://github.com/apache/parquet-mr/pull/940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [parquet-mr] alexeykudinkin commented on pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

alexeykudinkin commented on pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#issuecomment-989042060 My bad. Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

gszadovszky commented on a change in pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#discussion_r764664867 ## File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java ## @@ -542,6 +606,10 @@ public static Binary fromCharSequence(CharSe

[GitHub] [parquet-mr] shangxinli merged pull request #941: PARQUET-2107: Fix Travis failures

shangxinli merged pull request #941: URL: https://github.com/apache/parquet-mr/pull/941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [parquet-mr] shangxinli commented on pull request #941: PARQUET-2107: Fix Travis failures

shangxinli commented on pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#issuecomment-988262215 This great help @gszadovszky @martin-g! Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [parquet-mr] alexeykudinkin commented on pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

alexeykudinkin commented on pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#issuecomment-988196165 @gszadovszky good points, will address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [parquet-mr] gszadovszky commented on pull request #941: PARQUET-2107: Fix Travis failures

gszadovszky commented on pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#issuecomment-987987814 It seems it solved the issues. @shangxinli, could you please check it out? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #941: PARQUET-2107: Fix Travis failures

gszadovszky commented on a change in pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#discussion_r763839330 ## File path: .travis.yml ## @@ -18,6 +18,7 @@ # TravisCI is being used as an alternative to GitHub Actions until # the latter provides support for

[GitHub] [parquet-mr] martin-g commented on a change in pull request #941: PARQUET-2107: Fix Travis failures

martin-g commented on a change in pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#discussion_r763834170 ## File path: .travis.yml ## @@ -18,6 +18,7 @@ # TravisCI is being used as an alternative to GitHub Actions until # the latter provides support for AR

[GitHub] [parquet-mr] gszadovszky opened a new pull request #941: PARQUET-2107: Fix Travis failures

gszadovszky opened a new pull request #941: URL: https://github.com/apache/parquet-mr/pull/941 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

gszadovszky commented on a change in pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#discussion_r763814302 ## File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java ## @@ -542,6 +606,10 @@ public static Binary fromCharSequence(CharSe

[GitHub] [parquet-mr] alexeykudinkin commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

alexeykudinkin commented on a change in pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#discussion_r763341502 ## File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java ## @@ -542,6 +606,10 @@ public static Binary fromCharSequence(Cha

[GitHub] [parquet-mr] alexeykudinkin commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

alexeykudinkin commented on a change in pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#discussion_r763340887 ## File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java ## @@ -613,4 +681,60 @@ private static final boolean equals(byte[

[GitHub] [parquet-mr] alexeykudinkin commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

alexeykudinkin commented on a change in pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#discussion_r763340453 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java ## @@ -183,10 +183,10 @@ public String toString() {

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

gszadovszky commented on a change in pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#discussion_r762784053 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java ## @@ -183,10 +183,10 @@ public String toString() {

[GitHub] [parquet-mr] alexeykudinkin opened a new pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path

alexeykudinkin opened a new pull request #940: URL: https://github.com/apache/parquet-mr/pull/940 This refactors `BinaryComparator` to essentially avoid any allocations in the routine of comparing 2 `Binary` objects. More details could be found in [PARQUET-2106](https://issues.apac

[GitHub] [parquet-site] vegarsti commented on a change in pull request #6: Fix small typos in latest documentation

vegarsti commented on a change in pull request #6: URL: https://github.com/apache/parquet-site/pull/6#discussion_r761061301 ## File path: source/documentation/latest.html.md ## @@ -152,7 +152,8 @@ header. We have the - definition levels data, - repetition levels data,

[GitHub] [parquet-mr] gszadovszky commented on pull request #939: PARQUET-2105: Refactor the test code of creating the test file

gszadovszky commented on pull request #939: URL: https://github.com/apache/parquet-mr/pull/939#issuecomment-984430458 It seems that the Travis failures were not related to the recent change. It is strange that the 3 Travis failures are different. Anyway, the last commit did not fix thes

[GitHub] [parquet-mr] shangxinli opened a new pull request #939: PARQUET-2105: Refactor the test code of creating the test file

shangxinli opened a new pull request #939: URL: https://github.com/apache/parquet-mr/pull/939 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them i

[GitHub] [parquet-mr] IgorBerman opened a new pull request #938: disabling statistics under configuration parameter

IgorBerman opened a new pull request #938: URL: https://github.com/apache/parquet-mr/pull/938 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them i

[GitHub] [parquet-mr] IgorBerman commented on pull request #249: PARQUET-343 Caching nulls on group node to improve write performance on wide schema sparse data

IgorBerman commented on pull request #249: URL: https://github.com/apache/parquet-mr/pull/249#issuecomment-981138780 Hi @tsdeng and @isnotinvain I'm a bit late for the party, but have you considered using fastutils object-2-object map for nulls cache? for sparse schemas this cache'

[GitHub] [parquet-mr] shangxinli merged pull request #924: PARQUET-2076: Improve Travis CI build Performance

shangxinli merged pull request #924: URL: https://github.com/apache/parquet-mr/pull/924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [parquet-mr] shangxinli merged pull request #935: PARQUET-2040: Uniform encryption

shangxinli merged pull request #935: URL: https://github.com/apache/parquet-mr/pull/935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [parquet-mr] martin-g commented on pull request #924: PARQUET-2076: Improve Travis CI build Performance

martin-g commented on pull request #924: URL: https://github.com/apache/parquet-mr/pull/924#issuecomment-968646400 I think it is safe to merge this PR! Recent builds have such logs: 1. ``` Still running (3 of 60): mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.ski

[GitHub] [parquet-mr] gszadovszky commented on pull request #754: PARQUET-1784: Column-wise configuration

gszadovszky commented on pull request #754: URL: https://github.com/apache/parquet-mr/pull/754#issuecomment-968643025 > Hi, It is not clear how the property should work with lists Example: > > listField: OPTIONAL F:1 .list: REPEATED F:1 ..element: OPTIONAL INT64 R:1 D:3 @mixer

<    7   8   9   10   11   12   13   14   15   16   >