[jira] [Commented] (XMLBEANS-540) Prevent trim of elements when pretty print is used

2019-04-16 Thread Greg Woolsey (JIRA)
[ https://issues.apache.org/jira/browse/XMLBEANS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819751#comment-16819751 ] Greg Woolsey commented on XMLBEANS-540: --- How does this not break desired leading spaces

[ANNOUNCE] Apache POI 4.1.0 released

2019-04-10 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of POI 4.1.0. Featured are a handful of new areas of functionality, and numerous bug fixes. See the downloads page for binary and source distributions: https://poi.apache.org/download.html Release Notes Changes The most

[ANNOUNCE] Apache POI 4.1.0 released

2019-04-10 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of POI 4.1.0. Featured are a handful of new areas of functionality, and numerous bug fixes. See the downloads page for binary and source distributions: https://poi.apache.org/download.html Release Notes Changes The most

[ANNOUNCE] Apache POI 4.1.0 released

2019-04-09 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of POI 4.1.0. Featured are a handful of new areas of functionality, and numerous bug fixes. See the downloads page for binary and source distributions: https://poi.apache.org/download.html Release Notes Changes The most

New JavaDoc folder for 4.1.x?

2019-04-09 Thread Greg Woolsey
Per the release-guide.txt and what I see on the site currently, I think I need to build javadoc and move it to a new folder, plus updating links in the apidocs/index.xml file. That's what I'm working on today, unless anyone has a strong opinion otherwise.

Re: [VOTE] Apache POI 4.1.0 release (RC3)

2019-04-08 Thread Greg Woolsey
Vote passes with 5 +1 and 1 +0 votes. I'll begin the release process. Thank you all for your help, checks, and discussion. Greg On Mon, Apr 8, 2019 at 2:12 PM Tim Allison wrote: > Hi Andi, > > Y, to be clear, I really like what you’ve done and it is all a bunch > cleaner than my earlier

Re: [VOTE] Apache POI 4.1.0 release (RC3)

2019-04-08 Thread Greg Woolsey
cord > oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord > > oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture > > On Sun, Apr 7, 2019 at 8:27 AM Yegor Kozlov wrote: > > > > +1 > > > > Looks good to me > > > > сб, 6 апр. 2019 г

[VOTE] Apache POI 4.1.0 release (RC3)

2019-04-05 Thread Greg Woolsey
I've prepared artifacts for Apache POI release 4.1.0 (RC3). Notable changes since 4.0.1: * Improved support/fixes for Java 9+ and IBM JVM * New EMF renderer and support of SVG images in XSLF * Security, stability and memory/resource handling improvements * Various bug fixes across function and

Re: Ready for 4.1.0 release?

2019-04-05 Thread Greg Woolsey
Ignore the RC2, I will be doing an RC3 after some meetings. Discovered my FORREST_HOME was in Cygwin/Linux path format, which broke documentation creation, meaning the RC2 artifacts are missing site and other documentation folders/files. Turns out the XMLBeans build needs the Cygwin format, but

Re: Ready for 4.1.0 release?

2019-04-04 Thread Greg Woolsey
) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113) On Thu, Apr 4, 2019 at 11:02 AM Greg Woolsey wrote: > Changed the build.xml URL. > > On Thu, Apr 4, 2019 at 10:56 AM Dominik Stadler > wrote: > >> Try using https://nexus.pentaho.org/, seems the repository moved some >> time >> ago.

[ANNOUNCE] Apache XMLBeans 3.1.0 released

2019-04-04 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of Apache XMLBeans 3.1.0. This is the 4th release since the POI team took over the ownership of XMLBeans. Featured are a handful of memory, stability, coverage, and security fixes. The release package organization has also been updated to

Re: Returned post for annou...@apache.org

2019-04-04 Thread Greg Woolsey
4, 2019 at 6:32 PM Dave Fisher wrote: > You don’t have links to the download or download page. Take a look at > previous announcements. > > Sent from my iPhone > > > On Apr 4, 2019, at 6:09 PM, Greg Woolsey wrote: > > > > Anyone see anything wrong with my XMLB

Fwd: Returned post for annou...@apache.org

2019-04-04 Thread Greg Woolsey
a list moderator directly. --- Enclosed, please find the message you sent. -- Forwarded message -- From: Greg Woolsey To: POI Users List , POI Developers List < dev@poi.apache.org>, gene...@poi.apache.org, annou...@apache.org Cc: Bcc: Date: Sat, 30 Mar 2019 10:54:58

Re: Ready for 4.1.0 release?

2019-04-04 Thread Greg Woolsey
find such issues earlier. > > Dominik. > > On Thu, Apr 4, 2019 at 6:49 PM Greg Woolsey > wrote: > > > I get "Access Denied" when I try to run release-prep1 when it tries to > > retrieve this file: > > > > Can't get > > > > > http:/

Re: Ready for 4.1.0 release?

2019-04-04 Thread Greg Woolsey
ik Stadler wrote: > Sorry for the late reply, I will try to start another run toda, but you > don't to delay release work because of it. > > Dominik > > On Tue, Apr 2, 2019, 00:15 Greg Woolsey wrote: > > > Dominik, is it worth running the regression corpus again, to

Re: Ready for 4.1.0 release?

2019-04-03 Thread Greg Woolsey
As the Vaadin developers are waiting for 4.1.0, and no one has responded with additional work worth waiting for or fixes needed, I'll start the release prep Thursday. Best not to do it while I'm offline over the Atlantic today. On Tue, Apr 2, 2019 at 12:15 AM Greg Woolsey wrote: > Domi

Re: Ready for 4.1.0 release?

2019-04-01 Thread Greg Woolsey
Dominik, is it worth running the regression corpus again, to verify how many of the new errors are cleaned up? On Sat, Mar 30, 2019 at 9:38 PM Greg Woolsey wrote: > Build working again. Latest fix should also remove most of the > differences in the regression run seen last week. I'm

Re: Ready for 4.1.0 release?

2019-03-30 Thread Greg Woolsey
: > Would it be possible to also include > https://bz.apache.org/bugzilla/show_bug.cgi?id=61700? I can also provide > a pull request if that is prefered over the patch. > > Best Regards > > Kai Grabfelder > Greg Woolsey schrieb am 30.03.19 um 21:16: > > Anyone have anyth

Fwd: svn commit: r1856655 - in /poi/trunk/src: java/org/apache/poi/ss/formula/SheetNameFormatter.java testcases/org/apache/poi/hssf/usermodel/TestHSSFEvaluationSheet.java

2019-03-30 Thread Greg Woolsey
I handled this similarly to other code that converted missing external sheet info to empty String values, but if someone thinks this should still throw an exception, I'm open to discussing a new "MissingExternalReference" checked exception or something like that. Appears Excel does this to avoid

Fwd: Build failed in Jenkins: POI-DSL-1.13 #12

2019-03-30 Thread Greg Woolsey
The failing test is new - it's a stack trace that also showed up new in the regression test run. I was going to put off looking into it, but I guess I'll do that now. Not sure what changed that it started showing up in unit tests, as it isn't related to today's changes. -- Forwarded

Ready for 4.1.0 release?

2019-03-30 Thread Greg Woolsey
Anyone have anything else they want in before I start the build and release process? I just cleaned up the recent issues that mattered to me around formula evaluation and data formatting. Turns out they were somewhat related in code, but unrelated in discovery.

[ANNOUNCE] Apache XMLBeans 3.1.0 released

2019-03-30 Thread Greg Woolsey
this release possible. On behalf of the Apache POI PMC, Greg Woolsey [1] Release notes: https://www.apache.org/dyn/closer.lua/poi/xmlbeans/release/dev/RELEASE-NOTES-3.1.0.txt [2] Changelog: https://xmlbeans.apache.org/status.html#rel_310

Re: XMLBeans 3.1.0 candidate build

2019-03-26 Thread Greg Woolsey
> > > > It's ok, but not nice to have the bin directory in the src dist > duplicated in (/bin, /src/shell) - we can change that on the next release. > I still think it's better to have the shell scripts not under /bin in the > source tree. > > +1 > I agree, I didn't like it in /bin, but that's

[VOTE] XMLBeans 3.1.0 release

2019-03-23 Thread Greg Woolsey
Release artifacts: https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.1.0/ https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src The vote will remain open for 3 days. See the CHANGES.txt file for

XMLBeans 3.1.0 candidate build

2019-03-22 Thread Greg Woolsey
I have pushed xmlbeans 3.1.0 release candidate to: https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.1.0/ https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src This has discussed version # changes,

Re: XML Beans 3.0.3 candidate build

2019-03-22 Thread Greg Woolsey
directory when building, and include it mapped to /bin, like the xmlbeans-bin zip file. Thoughts? I lean toward moving it to /bin in the src zip, to match the bin zip. I'll work on that unless someone has a reason not to. On Thu, Mar 21, 2019 at 10:51 AM Greg Woolsey wrote: > I hard f

Re: XML Beans 3.0.3 candidate build

2019-03-21 Thread Greg Woolsey
in the src zip 2. bump the version to 3.1.0 and mention the packaging changes in the changelog 3. fix the README version # Then I would do a 3.1.0 XMLBeans build and deploy to staging. How does that sound to folks? On Thu, Mar 21, 2019 at 10:28 AM Greg Woolsey wrote: > I'm OK with chang

Re: XML Beans 3.0.3 candidate build

2019-03-21 Thread Greg Woolsey
e missing. > > Finally should we use a different version number, e.g. 3.1.0 to indicate > that some more changes in functionality did occur, 3.0.3 would suggest > "drop in replacement", which will not guarantee here? > > Thanks... Dominik. > > On Thu, Mar 21, 20

XML Beans 3.0.3 candidate build

2019-03-20 Thread Greg Woolsey
I have pushed xmlbeans 3.0.3 release candidate to: https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.0.3/ https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src If those look good to folks, what do

Re: Next release of POI/XmlBeans?

2019-03-20 Thread Greg Woolsey
When was the previous regression run? Some of the formula errors mention invalid sheet names, including empty strings. The fix for #60460 committed Dec. 30 handled null sheet names in SheetNameEvaluator, but perhaps that change should also check and handle empty strings? I've never actually

Re: Next release of POI/XmlBeans?

2019-03-19 Thread Greg Woolsey
eg On Mon, Mar 18, 2019 at 12:47 PM Andreas Beeker wrote: > > On 18.03.19 06:11, Greg Woolsey wrote: > > I've not done a release yet, but I'd be willing to read the docs and > > take a stab at it if no one else has time. > > Regarding POI: > > After setting up the envi

Re: Next release of POI/XmlBeans?

2019-03-17 Thread Greg Woolsey
I don't notice XMLBeans except when it breaks, and it hasn't been for me, so I'm happy with that. I'd love a new release soon with the change I just made, that would help a lot with some significant changes I'm submitting to the Vaadin UI component that uses POI. And it was my math error in the

Unit Test failure

2019-03-16 Thread Greg Woolsey
Job POI-DSL-OpenJDK fails, since before my recent change, apparently, with this stack. It passes for me locally, and the other build flavors pass. Anyone know what's going on with this one? javax.imageio.IIOException: Invalid argument to native writeImage at

Re: Poi thread running since a long time

2019-02-25 Thread Greg Woolsey
Which version of POI are you using? That line # is not in that method in the latest version. Many performance and bug fixes have gone into releases over the last couple years. If you have a file we can examine/test, or even better a unit test that shows the issue against the latest release,

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Greg Woolsey
I like this, but wonder about the change to throwing runtime exceptions (IllegalArgumentException specifically) in new cases, especially where we are deprecating a given _input_ but not an entire function, like setCellFormula(null). That seems like it will break a lot of downstream code, and

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Greg Woolsey
Good thoughts - I'm glad you are on board and thinking about the hard-to-track-down issues when implementations of interfaces differ in their behavior. I've not used the different hierarchies much, sticking mostly to XSSF, but I can see how this could lead to tricky bugs. I'm personally partial

Re: [Bug 62969] HYPERLINK() function needs a way to return link reference when display label is also specified

2018-12-02 Thread Greg Woolsey
That replacement method is no longer available, and the maps appear to be static, so making a change would affect all threads, so I don't like that option. Perhaps a separate override map local to an evaluator instance would be a possibility, but then it would need to be available in the proper

Re: Usage of XmlBeans triggers "clearThreadLocalMap" warnings in Tomcat with XSSF

2018-11-03 Thread Greg Woolsey
+1 for more information, like container type and version, platform, jre, etc. I've been using poi in a tomcat deployed webapp for nearly 15 years and never seen this. On Sat, Nov 3, 2018, 14:10 Dominik Stadler There are many places in XmlBeans where ThreadLocal is used and as far as I > could

Re: POI 4.0.1 release

2018-10-30 Thread Greg Woolsey
+1 for next weekend/week as well. Liking the current state of things after the initial 4.0.0 public feedback. On Tue, Oct 30, 2018 at 8:31 AM Alain FAGOT BÉAREZ wrote: > +1 to release 4.0.1 > > The blocking issues related to charts in XDDF are now fixed. Related > Bugzilla issue has also been

Re: svn commit: r1844311 - /poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java

2018-10-19 Thread Greg Woolsey
Thanks for fixing that before I got back online. Not sure how I didn't run those tests locally. On Fri, Oct 19, 2018 at 12:43 AM wrote: > Author: fanningpj > Date: Fri Oct 19 07:43:04 2018 > New Revision: 1844311 > > URL: http://svn.apache.org/viewvc?rev=1844311=rev > Log: > fix class cast

Re: "Could not resolve external workbook name" after setupReferencedWorkbooks

2018-09-27 Thread Greg Woolsey
I recently got this working, but noticed these points of fragility in doing so with the current released code: 1. If the file names had spaces in them, I had to replace them with "%20" in the map keys passed to setupReferencedWorkbooks(), as that's the value used in the stored formula expressions

Re: [VOTE] Apache POI 4.0.0 release (RC1)

2018-09-05 Thread Greg Woolsey
+1 with these sets of regression results plus the detailed checks done earlier on the artifact contents. On Wed, Sep 5, 2018 at 8:07 AM Tim Allison wrote: > +1 > > Reports are here: > http://162.242.228.174/reports/poi-4.0.0-reports-e.tgz > > These reports compare 3.17 with 4.0.0-RC1. > >

Re: Remove OPOIFSFileSystem for 4.0.0?

2018-08-27 Thread Greg Woolsey
3->4 is already a big upgrade, with lots of other API changes (all the Enums, for example). I think the direct use of NPOIFS will be small, and one more easy renaming migration step isn't that bad. I'd rather not keep even deprecated classes around longer than necessary. On Mon, Aug 27, 2018 at

Re: Upgrade OOXML schema to 3rd edition?

2018-08-16 Thread Greg Woolsey
I don't know enough about the differences to have an opinion either way, and won't have time to Google the diffs for myself for a few weeks. As long as the POI APIs stay backward compatible (with current 4.0.0 APIs) it shouldn't matter to me. The few places I touch CT* classes outside POI, it's

Re: Use forrest 0.9?

2018-07-10 Thread Greg Woolsey
+1 On Tue, Jul 10, 2018 at 8:54 AM Javen O'Neal wrote: > +1 >

Re: [Bug 59287] Provide a write() method and change semantics of close() to not automatically write

2018-06-26 Thread Greg Woolsey
I definitely want/need an option to open a document, make changes, and perform the equivalent of "Save As..." on the modified version. I have some static files I use as templates and don't want/can't modify them. They are typically read-only files in the context of the Java process. On Mon, Jun

Re: [VOTE] Re: Review #62355

2018-05-21 Thread Greg Woolsey
I also vote a) -0 b) -1 c) +1 since 4.0 has lots of other breaking changes (removing deprecated APIs in particular) requiring some import reorganizations isn't a big deal in my opinion, and doesn't block the advancement toward supporting future Java versions. I'd rather not need to publish an

Re: Format code in XSSFSheetXMLHandler.SheetContentsHandler

2018-05-06 Thread Greg Woolsey
Don't know the history, but the value is not that straightforward. If the cell has a specifically assigned format, it is used. However, format may also be derived from conditional formatting, which may not be evaluated in that context. In fact, conditional formatting evaluation is quite a

Re: 3.18? Or push for 4?

2018-05-04 Thread Greg Woolsey
I could use a release, but if we do one soon I have some changes to commit. We did a bunch of work replacing ints with Enums, which are breaking changes in most cases - would we branch somehow to avoid those? They were slated or a theoretical 3.18 initially, I think. On Fri, May 4, 2018 at 2:23

Re: Adding a function or two...

2018-03-27 Thread Greg Woolsey
Tests in that package are run in a context without the xssf code. Xssf specific tests need to go in a different location. I don't have it on my phone, but some searching should reveal them, the naming conventions are strong. On Tue, Mar 27, 2018, 17:45 Blake Watson wrote:

Re: publishing poi xmlbeans jars

2018-03-07 Thread Greg Woolsey
+1 On Wed, Mar 7, 2018 at 10:03 AM Mark Murphy wrote: > +1 > > > On Wed, Mar 7, 2018 at 12:40 PM, Dave Fisher > wrote: > > > Hi - > > > > Let’s get back on track. > > > > We want to release XMLBeans 2.7.0 with the org.apache.xmlbeans namespace > >

Re: Fwd: Challenge on automatic generation of documentation

2018-03-01 Thread Greg Woolsey
+1 "never down vote an offer to document open source code" :) I much prefer answering questions to writing documentation. On Thu, Mar 1, 2018 at 11:42 AM pj.fanning wrote: > +1 > > > > -- > Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html > >

Re: baffling save behavior

2018-02-24 Thread Greg Woolsey
I did it - I created a reproducible test case that involves pure POI API calls, no starting workbook produced elsewhere. I'll file a new bug to reference when I commit. On Fri, Feb 23, 2018 at 10:13 PM Greg Woolsey <greg.wool...@gmail.com> wrote: > Yes, I thought of a possible

Re: baffling save behavior

2018-02-23 Thread Greg Woolsey
can verify this going forward. > > Dominik. > > > On Fri, Feb 23, 2018 at 10:34 PM, Greg Woolsey <greg.wool...@gmail.com> > wrote: > > > I'm finally able to work around the problem by changing > > XSSFRow.onDocumentWrite() to always copy the current state of the _cells

Re: baffling save behavior

2018-02-23 Thread Greg Woolsey
it was doing essentially the same loops whether it applied any changes or not. Anyone want to weigh in on that simplification of XSSFRow.onDocumentWrite()? On Fri, Feb 23, 2018 at 12:55 PM Greg Woolsey <greg.wool...@gmail.com> wrote: > For what it's worth, I'm using a build from la

Re: baffling save behavior

2018-02-23 Thread Greg Woolsey
that might affect that. > > Best regards, > Alain FAGOT BÉAREZ > > ⁣ > > Von: Greg Woolsey > Gesendet: Fri Feb 23 03:53:08 GMT-03:00 2018 > An: POI Developers List > Betreff: baffling save behavior > > I hesitate to even bring it up, thinking I should be able to

baffling save behavior

2018-02-22 Thread Greg Woolsey
I hesitate to even bring it up, thinking I should be able to figure it out, but I've never seen behavior like this. Keep reading if you want to twist your brain in knots like mine. TL/DR - stop now if you'd rather be productive for your day job. Somehow, I have a consistent state where a file

Re: Failing gump tests

2018-02-04 Thread Greg Woolsey
+1 to stop. I thought it was for something that depended on POI, not the other way around. On Sun, Feb 4, 2018, 05:11 Dominik Stadler wrote: > Hi, > > In general Gump tries to build Apache projects against the latest trunk > versions of all the dependencies, i.e. trunk

Re: ***UNCHECKED*** RE: adding dependencies on h2 and mockito

2018-01-26 Thread Greg Woolsey
-scala.it> > wrote: > > > > You might have heard of Hypersonic SQL, some 10 years ago. H2 is the > second version thereof. > > > > ⁣Gesendet mit BlueMail ​ > > > > > > Originale Nachricht > > Von: Greg Woolsey <greg.wool...

Re: ***UNCHECKED*** RE: adding dependencies on h2 and mockito

2018-01-26 Thread Greg Woolsey
Total dependency size is important to my deployment, and probably others. I don't use SXSSF at all, and would not need/want the dependency (which I've never heard of in 20 years of database and Java development, which is strange to me, but irrelevant). My preference is to make it optional, even

Re: XMLBeans in 4.0.0 release

2018-01-09 Thread Greg Woolsey
+1 for either of those options resulting in 4.0.0 depending on an updated and fixed XML Beans. I don't care which. An updated attic release is slightly preferable to me, but if that's troublesome to pull off then a POI fork is fine. On Tue, Jan 9, 2018, 00:28 Nick Burch

Re: Can't compile EvaluationConditionalFormatRule

2018-01-05 Thread Greg Woolsey
isValid(val, comp, (Comparable)null); > > > On Fri, Jan 5, 2018 at 8:05 PM, Blake Watson <blake.wat...@pnmac.com> > wrote: > > > On Fri, Jan 5, 2018 at 4:19 PM, Greg Woolsey <greg.wool...@gmail.com> > > wrote: > > > >> for getRules() you can jus

Re: Can't compile EvaluationConditionalFormatRule

2018-01-05 Thread Greg Woolsey
e is large and has a large number of non-empty cells. Patches welcome, of course ;D On Fri, Jan 5, 2018 at 4:10 PM Greg Woolsey <greg.wool...@gmail.com> wrote: > Which Java version is your compiler compatibility set to? POI 4.0 > requires Java 8. > > On Fri, Jan 5, 2018 at 3:1

Re: Can't compile EvaluationConditionalFormatRule

2018-01-05 Thread Greg Woolsey
Which Java version is your compiler compatibility set to? POI 4.0 requires Java 8. On Fri, Jan 5, 2018 at 3:14 PM Blake Watson wrote: > I am trying to =just= recompile two classes: > ConditionalFormattingEvaluator, EvaluationConditionalFormatRule. I'm trying > to expose

Re: Build failed in Jenkins: POI-DSL-Maven #402

2017-11-15 Thread Greg Woolsey
Anyone know what's up with the "permission denied" errors? On Wed, Nov 15, 2017 at 12:06 PM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/POI-DSL-Maven/402/display/redirect?page=changes > > > > Changes: > > [gwoolsey] ignore a unit test that

Re: svn commit: r1812097 - in /poi/trunk/src: java/org/apache/poi/ddf/ java/org/apache/poi/hpsf/ java/org/apache/poi/hssf/record/aggregates/ java/org/apache/poi/hssf/usermodel/ java/org/apache/poi/ss/

2017-10-17 Thread Greg Woolsey
Shoot, I was on vacation. The changes in PR #75 revert performance changes from bug #57840 [1]. I don't know what the proper way to annotate them might be, but in my testing of large files with lots of formulas, the cost of Integer.valueOf() vs. new Integer(int) was quite large. That

Re: [VOTE] Apache POI 3.17 release (RC3)

2017-09-09 Thread Greg Woolsey
+1 works-for-me On Sat, Sep 9, 2017, 07:46 Dominik Stadler wrote: > Hi, > > Package content looks good! > > +1 > > Dominik. > > > On Sat, Sep 9, 2017 at 10:47 AM, pj.fanning wrote: > > > +1 > > > > > > > > -- > > Sent from:

Re: [VOTE] Apache POI 3.17 release (RC2)

2017-08-31 Thread Greg Woolsey
Wouldn't shock me to find out it is at the XML level - Word saving the same text in two different ways under the same parent would be completely within my jaded expectations. On Thu, Aug 31, 2017 at 11:37 AM Allison, Timothy B. wrote: > I ran the regression tests against

Re: [VOTE] Apache POI 3.17 release (RC2)

2017-08-30 Thread Greg Woolsey
If no-one minds, I would create RC3 tomorrow evening. > > Andi > > > On 8/30/17 7:44 PM, Greg Woolsey wrote: > > I would like an RC3 (sorry, I know this is a fair bit of work) to pick > up r1806623 > fixing bug 61468, as I consider that a rather serious calculation b

Re: [VOTE] Apache POI 3.17 release (RC2)

2017-08-30 Thread Greg Woolsey
I would like an RC3 (sorry, I know this is a fair bit of work) to pick up r1806623 fixing bug 61468, as I consider that a rather serious calculation bug, and will likely cause a couple months' delay in my attempts to get Vaadin-Spreadsheet updated to use the new conditional formatting and table

Re: [Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

2017-08-29 Thread Greg Woolsey
This looks incredibly promising. Worth considering for a re-opened 3.17, or a short-cycle 3.18? I know we get requests for array formula support on a regular basis, and maybe it's my childhood rocket scientist hero-worship talking, but the facility name attached gives me an initial level of hope

Re: [Bug 61468] Regression: evaluateInCell results in incorrect value for some formulas

2017-08-29 Thread Greg Woolsey
wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=61468 > > Greg Woolsey <gwool...@apache.org> changed: > >What|Removed |Added > > >Hardw

Re: POI 4.0 and Java 8

2017-08-28 Thread Greg Woolsey
Vaadin is Java 8. On Mon, Aug 28, 2017, 13:48 Javen O'Neal wrote: > Other stakeholders we should ping? > > > Vaadin, if they're on Java 6 or 7. > > On Aug 28, 2017 8:50 AM, "Allison, Timothy B." wrote: > > Thank you, David! > > Anyone with contacts

Re: [VOTE] Apache POI 3.17 release (RC1)

2017-08-23 Thread Greg Woolsey
Once again legacy xmlbeans disappoints. I would prefer making the old behavior the default, with a setting/flag/property that can change to the faster behavior. Consumers can then test it in their environments. On Wed, Aug 23, 2017, 13:49 Dominik Stadler wrote: > Hi, >

Re: Discussions on POI 4.0 / Java7/8 voting

2017-08-22 Thread Greg Woolsey
I'm of two minds regarding 4.0 vs. 3.18. I know there are big changes in discussion, that would warrant a major version, but I'm suspicious I'll find in the next 3 months something else in formula evaluation/conditional formatting/table styles that requires a POI bug fix, and I'd like for that to

Re: Help with task:

2017-08-17 Thread Greg Woolsey
Excellent! One way to do it would be to submit patches or pull requests [1] against the project that contain the new files and, if possible, updates to the documentation web page sources [2] integrating the new examples. If you don't mind waiting longer for developers to review and integrate

Re: 3.17-beta2 vs. 3.17 final?

2017-08-17 Thread Greg Woolsey
I have a pull request with Vaadin [1] that is currently an echo chamber - I think the key developer I've been in contact with is on summer holiday. I think I found the last bug in my POI code, and the remaining issues with their integration tests relate to picking up a POI release with that fix

3.17-beta2 vs. 3.17 final?

2017-08-17 Thread Greg Woolsey
I could use a new release, don't care what we call it :) Anyone have pending things they want to get finalized first? We had targeted end of summer for 3.17 final, but I don't remember any hard criteria for what folks wanted included in 3.17. I know there's been discussion about a new unified

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-13 Thread Greg Woolsey
You will also need to trace through the code to find the methods and properties referenced indirectly, via reflection, unfortunately. To avoid code duplication, Vaadin chose to access some properties of chart types via reflection where the properties are common to all charts, but not defined in a

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-13 Thread Greg Woolsey
Perhaps then it could be a parallel package to start, marked @Beta, independent of the two existing packages, aside from reusing things like enums perhaps. Projects could then explore it and use it as a common alternative. Once it is deemed stable enough to leave beat status we could then mark

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
Vaadin7 requires Java 7, Vaadin 8 requires Java 8, so they are OK there. POI 3.17 already has breaking changes, so they have to put off incorporating my work until a larger release anyway, due to possible customer dependencies. Their next release will at least be using 3.16, so users like me can

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
That might work for me, I'm not sure. Here's more background. There is much I want to do with the charts API already, but I haven't had time to see if this change goes in directions I'm wanting already. In particular I am constantly having to do variations on "instanceof" and type casting

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
I'm all for standardizing the API between modules, however I have a large amount of code using the current XSSF API, in conjunction with another library, Vaadin-Spreadsheet. I'm in the process of submitting a large change request to that group , adding my features to their product. They already

Re: Build failed in Jenkins: POI-DSL-Maven #289

2017-07-28 Thread Greg Woolsey
SVN says I'm fully in sync with HEAD, no local differences. And it passes for me, but the Jenkins build failed. On Fri, Jul 28, 2017 at 3:59 PM Andreas Beeker wrote: > > The two tests in error pass on my local system (Windows 10). > > ... > > Anyone have a clue what is

Re: Build failed in Jenkins: POI-DSL-Maven #289

2017-07-28 Thread Greg Woolsey
The two tests in error pass on my local system (Windows 10). The test log from the build [1] show the failing workbooks used by this test on the build servers had different contents than what I'm seeing locally. Specifically, locally, I'm seeing it pass because the document contains a

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-07-26 Thread Greg Woolsey
aven O'Neal" <one...@apache.org> wrote: > > Greg Woolsey has provided quite a few improvements on Table support for > > XSSF recently (last 6-12 months). > > > > Question to the devs: Are tables part of the XLS binary file format, and > if > > so are us

Re: Unsynchronize xmlbean calls

2017-07-25 Thread Greg Woolsey
+1, and good find by the SO user. On Tue, Jul 25, 2017, 15:31 Andreas Beeker wrote: > Hi, > > does anyone mind, if we unsynchronize the xmlbean calls? [1] > > Andi > > [1] https://stackoverflow.com/questions/45082014/ > >

Re: [Bug 61182] Invalid signature created for streamed xlsx file

2017-07-25 Thread Greg Woolsey
Unless there is some use case I'm missing, unit tests would be the only place a newly written file hash would need to match a precalculated value, meaning c) should be fine by me. I don't think anyone should expect POI to read a file and have the saved result be binarily equal to the input. The

Re: svn commit: r1800341 - in /poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/charts: XSSFCategoryAxis.java XSSFChartAxis.java XSSFDateAxis.java XSSFValueAxis.java

2017-06-29 Thread Greg Woolsey
Good point. I rushed it. There were already some like it in that class, but they should all get that treatment. It exists largely to provide common access to axis elements common to the 3 kinds of axis objects. On Thu, Jun 29, 2017, 21:00 Javen O'Neal wrote: > It's

Re: [Bug 60422] DataFormatter.formatCellValue returns incorrect value for German 'Buchhaltung' format

2017-06-28 Thread Greg Woolsey
I'm suspicious Excel is doing extra work to translate formats for display to match the OS locale display settings even though the underlying storage always uses English standards. On Wed, Jun 28, 2017, 11:24 wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=60422 > >

Re: Moving to Git

2017-06-28 Thread Greg Woolsey
I'd be all for that. Not particularly proficient, but I can Google like everyone else. On Wed, Jun 28, 2017, 01:35 Javen O'Neal wrote: > A fair increase in Github PR's. Having a git repo might increase the > number of (good) PR's we get, as that seems to be where a lot of >

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-06-27 Thread Greg Woolsey
I implemented the current table formula handling, based on a patch I found languishing in the bug database. It's been a year or so, but here's what I remember: Data Table syntax works in most cases, but there is definitely room for more test cases looking for bugs in less common scenarios -

Re: [VOTE] Apache POI 3.17-beta1 release (RC1)

2017-06-27 Thread Greg Woolsey
+1 So far so good in my tests, no sudden slow downs in my performance cases. On Tue, Jun 27, 2017, 05:15 Allison, Timothy B. wrote: > +1 > > Checksums and sig are good. Built/tested on Windows. > > Thank you, Andi! > > -Original Message- > From: Dominik Stadler

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
The example file with AlternateContent wrappers for table element styles is handled correctly now by r1799733 and added as a unit test. Existing tests still pass for me, plus my own downstream integrations. On Fri, Jun 23, 2017 at 1:07 PM Greg Woolsey <greg.wool...@gmail.com> wrote: >

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
to access those - just have a look at XSLFDrawing - if you need help, I > can support. > > So I'm waiting for your modifications (+EMUUtils merge), before preparing > the release candidate. > > Andi > > On 6/23/17 8:44 PM, Greg Woolsey wrote: > > In this particular cas

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
y ignoring these is a viable option for now. On Fri, Jun 23, 2017 at 10:02 AM Greg Woolsey <greg.wool...@gmail.com> wrote: > I'll take a look at that exception, I touched XSSFTableStyle. > > On Fri, Jun 23, 2017, 09:14 Allison, Timothy B. <talli...@mitre.org> > wrote: > >&g

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
I'll take a look at that exception, I touched XSSFTableStyle. On Fri, Jun 23, 2017, 09:14 Allison, Timothy B. wrote: > My run just finished as well. > > http://162.242.228.174/reports/reports_poi-3.17-beta1.zip > > +1 to roll > > I get only one new exception (below) in an

Re: Is it time for POI 3.17-beta1?

2017-06-20 Thread Greg Woolsey
+1 from me. Nothing pending atm, table/workbook style/theme changes in and tested. On Tue, Jun 20, 2017 at 12:23 PM Allison, Timothy B. wrote: > +1 -- my few small changes are in. I'll kick off my regression tests > tonight or tomorrow. > > -Original Message- >

Re: Developing POI with an IDE

2017-06-20 Thread Greg Woolsey
MyEclipse here, because it's familiar, cheap, and simpler to install than stock Eclipse. Haven't bothered learning Gradle yet but it's on my list eventually. Notably I can't run all the unit tests directly from Eclipse, I have to use the Ant tasks. Haven't uncovered why yet. On Tue, Jun 20,

Re: Extracting images from pptx using xslf discarding charts.

2017-06-16 Thread Greg Woolsey
, 2017 at 7:12 AM Anil pawar <mr.anilpa...@gmail.com> wrote: > > > On 2017-06-16 21:48 (+0530), Greg Woolsey <greg.wool...@gmail.com> wrote: > > Charts are stored as a definition, not an image, and poi doesn't > currently > > have support for rendering them. >

  1   2   >