[jira] [Resolved] (QPID-7076) qpid-cpp-benchmark throw exception when the number of senders or receivers is zero

2016-02-19 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-7076. -- Resolution: Fixed Patch committed; thank you for the contribution! > qpid-cpp-benchmark throw except

Re: QPID dispatch and SASL.

2016-02-19 Thread Gordon Sim
On 17/02/16 23:11, Alan Conway wrote: According to strace, qdrouterd never opens /usr/local/etc/sasl2/qdrouterd.conf so I suspect there may be a problem with the default install location. The PN_SASL_CONFIG environment variable lets you specify where it looks for that. (Though I agree with

[jira] [Updated] (QPID-7076) qpid-cpp-benchmark throw exception when the number of senders or receivers is zero

2016-02-19 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-7076: - Priority: Minor (was: Critical) > qpid-cpp-benchmark throw exception when the number of send

[jira] [Commented] (QPID-7076) qpid-cpp-benchmark throw exception when the number of senders or receivers is zero

2016-02-19 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153967#comment-15153967 ] Gordon Sim commented on QPID-7076: -- Thanks for the patch! Unfortunately as submitted, it does not apply

[jira] [Assigned] (QPID-7076) qpid-cpp-benchmark throw exception when the number of senders or receivers is zero

2016-02-17 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-7076: Assignee: Gordon Sim > qpid-cpp-benchmark throw exception when the number of senders or receiv

Re: Review Request 42647: PROTON-1071: EventInjector hangs on Windows: add new interrupt primitives to selector and reactor

2016-01-25 Thread Gordon Sim
f so... Since the interrupt is now essentially a special method on the reactor, EventInjector as a separate, user-visiable class doesn't make as much sense in my view. I'd be inclined to try and merge it into Container. - Gordon Sim

Re: Review Request 42700: PROTON-1104 - move the deallocation and cleanup of the reactor's timer to pn_reactor_stop, do not close pipes until reactor is finalized.

2016-01-25 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42700/#review116089 --- Ship it! Seems ok to me. - Gordon Sim On Jan. 24, 2016, 10

Re: Review Request 42647: PROTON-1071: EventInjector hangs on Windows: add new interrupt primitives to selector and reactor

2016-01-25 Thread Gordon Sim
reply, visit: > https://reviews.apache.org/r/42647/ > --- > > (Updated Jan. 22, 2016, 8:11 a.m.) > > > Review request for qpid, Alan Conway, Andrew Stitcher, Gordon Sim, and Justin > Ross. > > > Bugs: PROTON-1

Re: Review Request 42700: PROTON-1104 - move the deallocation and cleanup of the reactor's timer to pn_reactor_stop, do not close pipes until reactor is finalized.

2016-01-25 Thread Gordon Sim
is removed? - Gordon Sim On Jan. 24, 2016, 10:20 p.m., Kenneth Giusti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Created] (QPID-7010) assertion failure if disposition sent for previously settled delivery

2016-01-21 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-7010: Summary: assertion failure if disposition sent for previously settled delivery Key: QPID-7010 URL: https://issues.apache.org/jira/browse/QPID-7010 Project: Qpid

[jira] [Resolved] (QPID-7010) assertion failure if disposition sent for previously settled delivery

2016-01-21 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-7010. -- Resolution: Fixed Fix Version/s: qpid-cpp-next > assertion failure if disposition s

Re: Review Request 41800: C++ broker and client to support TLS1.1 and TLS1.2

2016-01-04 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41800/#review112526 --- Ship it! Ship It! - Gordon Sim On Dec. 30, 2015, 2:16 p.m

[jira] [Closed] (QPID-5628) Build fails when both python 2.7 and 3 are installed

2015-12-02 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim closed QPID-5628. Resolution: Duplicate > Build fails when both python 2.7 and 3 are instal

Re: svn commit: r1717539 - /qpid/trunk/qpid/cpp/src/qpid/broker/amqp/DataReader.cpp

2015-12-02 Thread Gordon Sim
On 12/01/2015 09:35 PM, astitc...@apache.org wrote: Author: astitcher Date: Tue Dec 1 21:35:41 2015 New Revision: 1717539 URL: http://svn.apache.org/viewvc?rev=1717539=rev Log: QPID-6924: Add in a case for PN_INVALID, but carry on doing nothing if we have no data Modified:

[jira] [Commented] (QPID-6786) (0-10) ServerAssembler fails with IndexOutOfBoundsException on receipt of message with large headers

2015-12-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034061#comment-15034061 ] Gordon Sim commented on QPID-6786: -- Yes, lack of support for multi-frame header (or command) segments

[jira] [Resolved] (QPID-6870) [AMQP 1.0]: qpidd does not honour the undeliverable-here field of MODIFIED disposition

2015-11-19 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6870. -- Resolution: Fixed If the undeliverable-here message is set, the message will now be rejected and never

[jira] [Created] (QPID-6870) [AMQP 1.0]: qpidd does not honour the undeliverable-here field of MODIFIED disposition

2015-11-19 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6870: Summary: [AMQP 1.0]: qpidd does not honour the undeliverable-here field of MODIFIED disposition Key: QPID-6870 URL: https://issues.apache.org/jira/browse/QPID-6870 Project

Re: Review Request 40189: QPID-6839: propagate any unhandled exceptions from the Selector thread to the main thread.

2015-11-11 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40189/#review106155 --- Ship it! Ship It! - Gordon Sim On Nov. 11, 2015, 9:03 p.m

[jira] [Resolved] (QPID-6834) allow lifetime of delete-on-close in queue policy

2015-11-10 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6834. -- Resolution: Fixed > allow lifetime of delete-on-close in queue pol

[jira] [Commented] (QPID-6754) Support anonymous relay

2015-11-09 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996682#comment-14996682 ] Gordon Sim commented on QPID-6754: -- That's a good point, thanks! It appears at present proton-c doesn't

[jira] [Commented] (DISPATCH-192) a null target is used in attach response, without subsequent detach, following attempted use of anonymous relay node

2015-11-09 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997288#comment-14997288 ] Gordon Sim commented on DISPATCH-192: - I believe this issue is fixed by the fix to PROTON-1042

[jira] [Assigned] (QPID-6754) Support anonymous relay

2015-11-06 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-6754: Assignee: Gordon Sim > Support anonymous relay > --- > >

[jira] [Created] (QPID-6834) allow lifetime of delete-on-close in queue policy

2015-11-06 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6834: Summary: allow lifetime of delete-on-close in queue policy Key: QPID-6834 URL: https://issues.apache.org/jira/browse/QPID-6834 Project: Qpid Issue Type: Bug

[jira] [Created] (DISPATCH-191) router not replying to detach frame

2015-11-04 Thread Gordon Sim (JIRA)
Gordon Sim created DISPATCH-191: --- Summary: router not replying to detach frame Key: DISPATCH-191 URL: https://issues.apache.org/jira/browse/DISPATCH-191 Project: Qpid Dispatch Issue Type: Bug

[jira] [Commented] (DISPATCH-191) router not replying to detach frame

2015-11-04 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990207#comment-14990207 ] Gordon Sim commented on DISPATCH-191: - note `qd-stat -a` no longer lists the address after

[jira] [Updated] (DISPATCH-191) router not replying to detach frame

2015-11-04 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated DISPATCH-191: Attachment: timed_recv.py Reproducer client. Just run this against the router and observe

[jira] [Commented] (QPID-6826) transfer frame message-format is required to be 0

2015-11-04 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989837#comment-14989837 ] Gordon Sim commented on QPID-6826: -- I believe the message format *is* set on frames sent by proton-c

Re: Crash on inability to catch the internal exception thrown from qpid c++ API

2015-10-29 Thread Gordon Sim
On 10/29/2015 06:14 AM, Sridharan, Venkatesan wrote: I have created the JIRA: https://issues.apache.org/jira/browse/QPID-6811 for the issue. I have attached a patch to the JIRA, am new to qpid development process, not sure how to go about it - can anybody provide some pointers on how to take

Re: How to handle redirection on proton-c?

2015-10-27 Thread Gordon Sim
On 10/26/2015 06:28 PM, Ewerton Scaboro da Silva wrote: Hey folks, Would you have any pointers on how to handle redirection using proton-c? This is the code I'm calling: pn_messenger_recv(messenger, -1); And this is what I get on the logs: [00FF1D78]:0 <- @attach(18)

[jira] [Resolved] (QPID-6790) qpidd crashes in the interop_tests unit test.

2015-10-26 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6790. -- Resolution: Fixed > qpidd crashes in the interop_tests unit t

Re: Review Request 39561: prevent asynchornous acceptance of incoming deliveries after thier associated link has been freed

2015-10-23 Thread Gordon Sim
/qpid/cpp/src/qpid/broker/amqp/Session.h 1710066 trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1710066 Diff: https://reviews.apache.org/r/39561/diff/ Testing --- Passes make test. Thanks, Gordon Sim

Re: Review Request 39561: prevent asynchornous acceptance of incoming deliveries after thier associated link has been freed

2015-10-23 Thread Gordon Sim
--- Passes make test. Thanks, Gordon Sim

Re: Review Request 39561: prevent asynchornous acceptance of incoming deliveries after thier associated link has been freed

2015-10-23 Thread Gordon Sim
to act on the record in completed we see its no longer in pending and don't proceed. On Oct. 23, 2015, 12:55 p.m., Gordon Sim wrote: > > I still have remaining concerns regarding the lifecycle management of > > pn_link objects. If these seem legit, perhaps they should be tracked in

Re: Review Request 39561: prevent asynchornous acceptance of incoming deliveries after thier associated link has been freed

2015-10-22 Thread Gordon Sim
d e-mail. To reply, visit: https://reviews.apache.org/r/39561/#review103641 ------- On Oct. 22, 2015, 5:37 p.m., Gordon Sim wrote: > > --- > This is an a

Review Request 39561: prevent asynchornous acceptance of incoming deliveries after thier associated link has been freed

2015-10-22 Thread Gordon Sim
/amqp/Session.h 1710066 trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1710066 Diff: https://reviews.apache.org/r/39561/diff/ Testing --- Passes make test. Thanks, Gordon Sim

[jira] [Commented] (QPID-6790) qpidd crashes in the interop_tests unit test.

2015-10-22 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969569#comment-14969569 ] Gordon Sim commented on QPID-6790: -- An alternative proposal: https://reviews.apache.org/r/39561/ > qp

Re: Review Request 39561: prevent asynchornous acceptance of incoming deliveries after thier associated link has been freed

2015-10-22 Thread Gordon Sim
ccept will be done asynchronously. - Gordon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39561/#review103629 -----------

Re: Review Request 39427: Do not free proton links until there is no more pending work on the link.

2015-10-22 Thread Gordon Sim
re closing the link, e.g. explicitly settling deliveries and nulling out any reference to them, I'd prefer we ensure that is done rather than querying proton. - Gordon Sim On Oct. 21, 2015, 5:51 p.m., Kenneth Giusti wrote: > > --- > Thi

Re: Review Request 39173: qpidd should dynamically set the SASL service name based on protocol.

2015-10-12 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39173/#review10 --- Ship it! Ship It! - Gordon Sim On Oct. 9, 2015, 8:33 p.m

Re: Review Request 39173: qpidd should dynamically set the SASL service name based on protocol.

2015-10-09 Thread Gordon Sim
in Domain - ~line 222 of qpid/broker/amqp/Domain.cpp - which is used for broker initiated connections. That value can be set explicitly per domain, but since 1.0 defaulst to 'amqp' on the broker side it would be nice to change there as well. - Gordon Sim On Oct. 9, 2015, 3:33 p.m., Kenneth

Re: Establishing AMQP 1.0 Connection from qpidd

2015-10-09 Thread Gordon Sim
On 10/06/2015 07:25 PM, kbr wrote: - I enabled more info in the log files. I see a 1.0 connection being made but it disconnects due to no response from the server. It logs: "No protocol received after 10s, closing". Which is correct, I see the WireShark capture and don't see a response from the

Re: Establishing AMQP 1.0 Connection from qpidd

2015-10-06 Thread Gordon Sim
On 09/28/2015 06:34 PM, kbr wrote: Hello, Here is what I am trying to do: Client -- AMQP 0_10 --> qpidd broker -- AMQP 1.0, SASL, SSL --> Azure service bus 1. I started qpidd using: sudo ./qpidd --config /etc/qpidd.conf --load-module /home/user/workspace/AMQP/qpid-cpp-0.34/build/src/amqp.so

Re: Review Request 38964: QPID-6767: Add --sasl-service-name option to the QPID tools

2015-10-05 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38964/#review101449 --- Ship it! Ship It! - Gordon Sim On Oct. 2, 2015, 7:30 p.m

[jira] [Created] (QPID-6767) qpidd tools don't allow sasl service name to be changed

2015-10-02 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6767: Summary: qpidd tools don't allow sasl service name to be changed Key: QPID-6767 URL: https://issues.apache.org/jira/browse/QPID-6767 Project: Qpid Issue Type: Bug

[jira] [Updated] (QPID-6767) qpidd tools don't allow sasl service name to be changed

2015-10-02 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-6767: - Attachment: sasl-service-name-full.patch proposed fix > qpidd tools don't allow sasl service n

Re: Review Request 38863: Add toggle to control sasl layer to proton.reactor.Container

2015-09-30 Thread Gordon Sim
--- On Sept. 29, 2015, 9:56 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38863/ > --

Re: Review Request 38863: Add toggle to control sasl layer to proton.reactor.Container

2015-09-29 Thread Gordon Sim
--- Thanks, Gordon Sim

Review Request 38863: Add toggle to control sasl layer to proton.reactor.Container

2015-09-29 Thread Gordon Sim
of the allowed_mechs and allow_insecure_mechs options. Diffs - proton-c/bindings/python/proton/reactor.py 8de5d89 Diff: https://reviews.apache.org/r/38863/diff/ Testing --- Thanks, Gordon Sim

Review Request 38688: PROTON-1003: define error handler for ssl transport layer

2015-09-23 Thread Gordon Sim
/38688/diff/ Testing --- make test passes, ssl based reproducer from PRTON-1000 also shows sockets being closed. Thanks, Gordon Sim

Re: sasl negotiation failed

2015-09-15 Thread Gordon Sim
On 09/11/2015 08:26 PM, kbr wrote: Yes, I do. I have it in: /usr/lib/x86_64-linux-gnu/sasl2 But for whatever reason sasl_listmech is returning nothing. Are all other sasl plugins in that same location? How did you install cyrus-sasl? Did you build it yourself or install packages for your

Re: sasl negotiation failed

2015-09-11 Thread Gordon Sim
On 09/11/2015 09:56 AM, Gordon Sim wrote: On 09/10/2015 10:17 PM, kbr wrote: 2015-09-10 16:09:15 [Security] info SASL: Mechanism list: DIGEST-MD5 [...] I matched the --sasl-mechanism on the qpid-config to DIGEST-MD5, but still got the same error. The python client that is used by qpid

Re: sasl negotiation failed

2015-09-11 Thread Gordon Sim
On 09/10/2015 10:17 PM, kbr wrote: 2015-09-10 16:09:15 [Security] info SASL: Mechanism list: DIGEST-MD5 [...] I matched the --sasl-mechanism on the qpid-config to DIGEST-MD5, but still got the same error. The python client that is used by qpid-config requires a special library to be able to

Re: sasl negotiation failed

2015-09-11 Thread Gordon Sim
On 09/11/2015 02:54 PM, kbr wrote: Thanks Gordon. That makes sense. But when I used PLAIN in the qpidd.conf in /etc/qpid/sasl/qpidd.conf the mechanism list shows up empty. pwcheck_method: auxprop auxprop_plugin: sasldb sasldb_path: /usr/lib/sasl2/qpidd.sasldb mech_list: PLAIN Here is the

[jira] [Commented] (QPID-6717) selector can match incorrectly due to different type for values

2015-09-02 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727892#comment-14727892 ] Gordon Sim commented on QPID-6717: -- I believe your test is wrong: BOOST_CHECK(qb::Selector(&q

[jira] [Commented] (QPID-6717) selector can match incorrectly due to different type for values

2015-09-02 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727879#comment-14727879 ] Gordon Sim commented on QPID-6717: -- "x NOT IN ('a', 'b', 'c')" would match where x=1 > selec

[jira] [Commented] (QPID-6717) selector can match incorrectly due to different type for values

2015-09-02 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727908#comment-14727908 ] Gordon Sim commented on QPID-6717: -- Are you sure that fix works? The comparison operators all return false

[jira] [Commented] (QPID-6717) selector can match incorrectly due to different type for values

2015-09-02 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728027#comment-14728027 ] Gordon Sim commented on QPID-6717: -- Yes, it does work because 've>=vl && ve<=vu' will a

[jira] [Assigned] (QPID-6717) selector can match incorrectly due to different type for values

2015-09-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-6717: Assignee: (was: Gordon Sim) > selector can match incorrectly due to different type for val

[jira] [Commented] (QPID-6718) parsing errors for integer literals in selectors

2015-09-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725466#comment-14725466 ] Gordon Sim commented on QPID-6718: -- Apart from stating that "numbers in the range of Java

[jira] [Assigned] (QPID-6717) selector can match incorrectly due to different type for values

2015-09-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-6717: Assignee: Andrew Stitcher > selector can match incorrectly due to different type for val

[jira] [Assigned] (QPID-6714) Add support for JMSHeaders in selectors

2015-09-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-6714: Assignee: Andrew Stitcher (was: Gordon Sim) fyi Tests were added to the python tests. >

[jira] [Created] (QPID-6714) Add support for JMSHeaders in selectors

2015-08-28 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6714: Summary: Add support for JMSHeaders in selectors Key: QPID-6714 URL: https://issues.apache.org/jira/browse/QPID-6714 Project: Qpid Issue Type: Bug

[jira] [Resolved] (QPID-6714) Add support for JMSHeaders in selectors

2015-08-28 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6714. -- Resolution: Fixed Add support for JMSHeaders in selectors

[jira] [Updated] (QPID-6717) selector can match incorrectly due to different type for values

2015-08-28 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-6717: - Description: E.g. a selector x BETWEEN 1 AND 10 would match for a value of x=foo, because of the way

[jira] [Resolved] (QPID-6717) selector can match incorrectly due to different type for values

2015-08-28 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6717. -- Resolution: Fixed selector can match incorrectly due to different type for values

[jira] [Created] (QPID-6718) parsing errors for integer literals in selectors

2015-08-28 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6718: Summary: parsing errors for integer literals in selectors Key: QPID-6718 URL: https://issues.apache.org/jira/browse/QPID-6718 Project: Qpid Issue Type: Bug

[jira] [Created] (QPID-6717) selector can match incorrectly due to different type for values

2015-08-28 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6717: Summary: selector can match incorrectly due to different type for values Key: QPID-6717 URL: https://issues.apache.org/jira/browse/QPID-6717 Project: Qpid Issue

[jira] [Commented] (QPID-6701) [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown

2015-08-25 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711561#comment-14711561 ] Gordon Sim commented on QPID-6701: -- The key purpose of the 'resolution' is to determine

Re: Review Request 37553: Use the monotonic clock to compute the AMQP1.0 idle timer interval

2015-08-18 Thread Gordon Sim
subtracts a FromEpoch duration, computed using the realtime clock, from the now() which is computed from the monotonic clock. Is that even valid? These are arguably separate issues though, just raising tnem for debate. - Gordon Sim On Aug. 17, 2015, 8:34 p.m., Kenneth Giusti wrote

Re: Review Request 37195: Validate the incoming frame header

2015-08-07 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37195/#review94505 --- Ship it! Ship It! - Gordon Sim On Aug. 6, 2015, 6:58 p.m

Re: proton 0.10 blocker

2015-07-28 Thread Gordon Sim
On 07/20/2015 08:53 PM, Rafael Schloming wrote: I'm fine going ahead with Gordon's fix. I don't have a lot of time to dig into the refcounting issue personally right now, but I'd at least leave the bug open until we have made it through a bit more testing. I have an uneasy feeling it (or

[jira] [Updated] (QPID-6661) [AMQP 1.0] heartbeat anomalies

2015-07-28 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-6661: - Priority: Minor (was: Major) [AMQP 1.0] heartbeat anomalies

[jira] [Created] (QPID-6661) [AMQP 1.0] heartbeat anomalies

2015-07-28 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6661: Summary: [AMQP 1.0] heartbeat anomalies Key: QPID-6661 URL: https://issues.apache.org/jira/browse/QPID-6661 Project: Qpid Issue Type: Bug Components: C

[jira] [Resolved] (QPID-6661) [AMQP 1.0] heartbeat anomalies

2015-07-28 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6661. -- Resolution: Fixed [AMQP 1.0] heartbeat anomalies -- Key

[jira] [Created] (QPID-6659) [AMQP 1.0] qpid::messaging can't handle multi-frame transfers

2015-07-27 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6659: Summary: [AMQP 1.0] qpid::messaging can't handle multi-frame transfers Key: QPID-6659 URL: https://issues.apache.org/jira/browse/QPID-6659 Project: Qpid Issue Type

[jira] [Updated] (QPID-6654) mgmt-disable option set to false causes segv on CentOS 6.3

2015-07-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-6654: - Status: Reviewable (was: In Progress) mgmt-disable option set to false causes segv on CentOS 6.3

[jira] [Resolved] (QPID-6654) mgmt-disable option set to false causes segv on CentOS 6.3

2015-07-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6654. -- Resolution: Fixed Fix Version/s: qpid-cpp-next mgmt-disable option set to false causes segv

[jira] [Assigned] (QPID-6654) mgmt-disable option set to false causes segv on CentOS 6.3

2015-07-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-6654: Assignee: Gordon Sim mgmt-disable option set to false causes segv on CentOS 6.3

[jira] [Created] (QPID-6660) [AMQP 1.0] broker attempts to process incoming messages for closed session

2015-07-27 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6660: Summary: [AMQP 1.0] broker attempts to process incoming messages for closed session Key: QPID-6660 URL: https://issues.apache.org/jira/browse/QPID-6660 Project: Qpid

[jira] [Resolved] (QPID-6660) [AMQP 1.0] broker attempts to process incoming messages for closed session

2015-07-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6660. -- Resolution: Fixed [AMQP 1.0] broker attempts to process incoming messages for closed session

[jira] [Resolved] (QPID-6659) [AMQP 1.0] qpid::messaging can't handle multi-frame transfers

2015-07-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6659. -- Resolution: Fixed [AMQP 1.0] qpid::messaging can't handle multi-frame transfers

Re: proton 0.10 blocker

2015-07-17 Thread Gordon Sim
On 07/17/2015 05:36 PM, Rafael Schloming wrote: Hi Gordon, I did my best to dump some useful info on the refcounting stuff in the other thread. I also posted a comment on the review. As I said there it would be helpful to see the stack trace from the crash in order to figure out if the fix is

Re: proton 0.10 blocker

2015-07-17 Thread Gordon Sim
On 07/17/2015 07:17 PM, Rafael Schloming wrote: Given this I believe the incref/decref pair is indeed running into problems when being invoked from inside a finalizer. I'd be curious if an alternative fix would work. I suspect you could replace the additional conditions you added to the if

Re: proton 0.10 blocker

2015-07-17 Thread Gordon Sim
On 07/17/2015 08:15 PM, Rafael Schloming wrote: On Fri, Jul 17, 2015 at 11:56 AM, Gordon Sim g...@redhat.com wrote: On 07/17/2015 07:17 PM, Rafael Schloming wrote: Given this I believe the incref/decref pair is indeed running into problems when being invoked from inside a finalizer. I'd

Re: proton 0.10 blocker

2015-07-17 Thread Gordon Sim
On 07/17/2015 10:04 PM, Rafael Schloming wrote: On Fri, Jul 17, 2015 at 12:47 PM, Gordon Sim g...@redhat.com wrote: On 07/17/2015 08:15 PM, Rafael Schloming wrote: On Fri, Jul 17, 2015 at 11:56 AM, Gordon Sim g...@redhat.com wrote: On 07/17/2015 07:17 PM, Rafael Schloming wrote: Given

Re: Semantics of proton refcounts [was Re: proton 0.10 blocker]

2015-07-16 Thread Gordon Sim
On 07/16/2015 02:40 PM, aconway wrote: Can someone who understand the proton use of refcounts please add some doc comments to explain the semantics? Apologies if this is already there and I missed it, tell me to RTFM. I'm not entirely sure I understand it. However having spent a couple of

Re: Semantics of proton refcounts [was Re: proton 0.10 blocker]

2015-07-16 Thread Gordon Sim
On 07/16/2015 02:40 PM, aconway wrote: The fix mentioned above has this, which make no sense under traditional refcounting: pn_incref(endpoint); pn_decref(endpoint); Note that this is not added as part of my fix, it is already there. The simple explanation is that it is a

Review Request 36509: prevent unwanted finalize for links/sessions

2015-07-15 Thread Gordon Sim
for. Diffs - proton-c/src/engine/engine.c fda719a Diff: https://reviews.apache.org/r/36509/diff/ Testing --- All proton and qpid-cpp tests pass with this additional fix in place. Thanks, Gordon Sim

proton 0.10 blocker

2015-07-15 Thread Gordon Sim
The latest proton code is causing crashes in qpid-cpp tests that use it. I've tracked the problem down to the fix for PROTON-905[1] and proposed an enhancement to that fix, https://reviews.apache.org/r/36509/, which avoids the crash. Could someone who understands the logic controlling the

[jira] [Resolved] (QPID-6639) Incoming connection using cut-through ANONYMOUS SASL fails

2015-07-14 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-6639. -- Resolution: Fixed Fix Version/s: qpid-cpp-next Incoming connection using cut-through ANONYMOUS

[jira] [Assigned] (QPID-6639) Incoming connection using cut-through ANONYMOUS SASL fails

2015-07-13 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-6639: Assignee: Gordon Sim Incoming connection using cut-through ANONYMOUS SASL fails

Re: qpid-proton git commit: PROTON-925: use scanner right for remote_channel_max and remote_max_frame

2015-07-03 Thread Gordon Sim
On 07/02/2015 10:38 PM, mgoul...@apache.org wrote: Repository: qpid-proton Updated Branches: refs/heads/master 7e3190306 - fc38e86a6 PROTON-925: use scanner right for remote_channel_max and remote_max_frame Was the change for remote_max_frame necessary? Unlike channel-max, 0 would be an

Re: qpid-proton git commit: PROTON-911: Implemented encryption/decryption functionality for Cyrus SASL

2015-07-02 Thread Gordon Sim
On 07/01/2015 08:42 PM, astitc...@apache.org wrote: Repository: qpid-proton Updated Branches: refs/heads/master c78392f19 - 395b23f5f PROTON-911: Implemented encryption/decryption functionality for Cyrus SASL [...] Committer: Andrew Stitcher astitc...@apache.org Committed: Wed Jul 1

Re: Review Request 36098: Prevent pn_data_scan from stepping on default value.

2015-07-01 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36098/#review90096 --- Ship it! Ship It! - Gordon Sim On July 1, 2015, 6:02 p.m

Review Request 36102: handle error state on sockets in messenger

2015-07-01 Thread Gordon Sim
Thanks, Gordon Sim

Review Request 36087: only encode expiry- and creation- time if they are explicitly set

2015-07-01 Thread Gordon Sim
tested the actual encoding Thanks, Gordon Sim

[jira] [Closed] (QPID-6615) [AMQP 1.0] unique link names per container should be enforced

2015-06-29 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim closed QPID-6615. Resolution: Duplicate [AMQP 1.0] unique link names per container should be enforced

[jira] [Created] (QPID-6615) [AMQP 1.0] unique link names per container should be enforced

2015-06-29 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-6615: Summary: [AMQP 1.0] unique link names per container should be enforced Key: QPID-6615 URL: https://issues.apache.org/jira/browse/QPID-6615 Project: Qpid Issue Type

Re: C++ client Windows build problem

2015-06-23 Thread Gordon Sim
On 06/23/2015 05:00 PM, Steve Huston wrote: This error has been showing up since late last week... anyone recognize the change? C:\qpid\qpid\trunk\cpp\src\qpid\client\Connector.cpp(82): error C2440: 'return' : cannot convert from 'boost::shared_ptrqpid::framing::ProtocolInitiation' to 'bool'

Re: Review Request 35787: PROTON-490: skip missing environemnts

2015-06-23 Thread Gordon Sim
On June 23, 2015, 6:07 p.m., Kenneth Giusti wrote: I think we're stuck with two choices: leave tox 1.4 as the minimum and remove the 'py34' environment, OR use this patch. We'll want to test against py34, so that mandates this patch And it is easy enough to install an updated tox

<    3   4   5   6   7   8   9   10   11   12   >