Yes,
./systests/src/main/java/org/apache/qpid/test/unit/ack/
Acknowledge2ConsumersTest.java
./systests/src/main/java/org/apache/qpid/test/unit/ack/
AcknowledgeOnMessageTest.java
./systests/src/main/java/org/apache/qpid/test/unit/ack/
AcknowledgeAfterFailoverOnMessageTest.java
Andrew,
I did do a grep on NO_ACKNOWLEDGE and saw those test cases. Thanks for
confirming.
Just wanted to make sure I verified the changes properly.
Btw does the various QueueBrowser tests pass for you ?
Rajith
On Wed, Mar 9, 2011 at 4:55 PM, Andrew Kennedy
andrewinternatio...@gmail.com
Hi Justin,
I'd like the following commits to be included in the 0.10 release branch.
1. http://svn.apache.org/viewvc?rev=1078961view=rev - QPID-3109 - Fairly
low risk.
This is a simple bug fix.
2. http://svn.apache.org/viewvc?rev=1078971view=rev - QPID-2732 - Low
risk.
This is an
Hi, Rajith. I approved item 4.
Robbie, would you indicate briefly up or down for 0.10 in the comments of
qpid-3109 and -2732?
Justin
On Tue, 8 Mar 2011, Rajith Attapattu wrote:
Hi Justin,
I'd like the following commits to be included in the 0.10 release branch.
1.
Done. To summarise here though:
1. QPID-3109: looks good, although as mentioned on the JIRA a second commit
http://svn.apache.org/viewvc?view=revrev=1079059 is also required here, to
enable compilation to succeed.
2. 3. QPID-2732: changes look reasonable.
4. This specific change looks good
On Tue, Mar 8, 2011 at 3:01 PM, Robbie Gemmell robbie.gemm...@gmail.comwrote:
Done. To summarise here though:
1. QPID-3109: looks good, although as mentioned on the JIRA a second commit
http://svn.apache.org/viewvc?view=revrev=1079059 is also required here,
to
enable compilation to succeed.
Hi, Robbie. I appreciate your caution regarding item 4, and I'm prepared
to revert that change if it's not truly low risk.
Anyone else have an opinion on this item?
On Tue, 8 Mar 2011, Robbie Gemmell wrote:
4. This specific change looks good to restore the prior behaviour, though in
general
I disagree with item for #4 being a risk.
Andrew's commit was to restore a feature that I dropped when I committed rev
http://svn.apache.org/viewvc?rev=1076800view=rev
Chances are that there might be apps out there that rely on NO_ACKNOWLEDGE
mode (even though it's not a standard JMS option).
All
On Tue, Mar 8, 2011 at 3:33 PM, Rajith Attapattu rajit...@gmail.com wrote:
On Tue, Mar 8, 2011 at 3:01 PM, Robbie Gemmell
robbie.gemm...@gmail.comwrote:
Done. To summarise here though:
1. QPID-3109: looks good, although as mentioned on the JIRA a second
commit
Sorry if I wasn't clear. I wasn't saying it shouldn't go in, quite the
opposite; in general I wouldn't allow this kind of change at this point, but
in this particular case it is actually putting something back roughly the
way it was until changed a few days ago so I would actually say that it must
As mentioned in the other email I was not saying this change was a risk (I
was actually the one who noticed this particular problem whilst discussing a
different issue with Andrew earlier). I was just saying that in general I
wouldn't be messing with accept modes at this point in the release
Okay, understood.
On Wed, 9 Mar 2011, Robbie Gemmell wrote:
Sorry if I wasn't clear. I wasn't saying it shouldn't go in, quite the
opposite; in general I wouldn't allow this kind of change at this point, but
in this particular case it is actually putting something back roughly the
way it was
On 9 Mar 2011, at 00:40, Robbie Gemmell wrote:
Sorry if I wasn't clear. I wasn't saying it shouldn't go in, quite
the
opposite; in general I wouldn't allow this kind of change at this
point, but
in this particular case it is actually putting something back
roughly the
way it was until
13 matches
Mail list logo
