---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/987/#review965
---
Ship it!
Cliff,
Thanks for your effort on this.
Without this patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1291/
---
(Updated 2011-08-04 17:17:32.509507)
Review request for qpid, Gordon Sim, Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3239/
---
Review request for qpid, Andrew Stitcher, Gordon Sim, Ted Ross, Steve Huston,
the lock goes out
of scope before the object protected by the lock is referenced.
- Chug
On 2011-12-16 21:04:58, Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3239
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3239/
---
(Updated 2011-12-19 22:00:08.704694)
Review request for qpid, Andrew Stitcher,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4063/
---
Review request for qpid, Gordon Sim, Ted Ross, and rajith attapattu.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/
---
Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/
---
(Updated 2012-03-08 21:52:15.960402)
Review request for qpid, Andrew Stitcher,
Ross, Chug Rolke, and Steve
Huston.
Summary
---
The cause of the hang was an outstanding read side completion when the
AsynchIO object in charge of the socket was in the queuedClose state.
The completion handler drains outstanding async requests before closing the
socket. Since
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/
---
Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/
---
(Updated 2012-03-30 15:54:07.491139)
Review request for qpid, Alan Conway,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/
---
(Updated 2012-04-04 15:42:02.279036)
Review request for qpid, Alan Conway,
Ross, Chug Rolke, and Steve
Huston.
Summary
---
The cause of the hang was an outstanding read side completion when the
AsynchIO object in charge of the socket was in the queuedClose state.
The completion handler drains outstanding async requests before closing the
socket. Since
:52:43)
Review request for qpid, Andrew Stitcher, Ted Ross, Chug Rolke, and Steve
Huston.
Summary
---
The cause of the hang was an outstanding read side completion when the
AsynchIO object in charge of the socket was in the queuedClose state.
The completion handler drains
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4857/
---
Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4857/
---
(Updated 2012-04-26 20:08:30.010970)
Review request for qpid, Andrew Stitcher,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5015/
---
Review request for qpid, Alan Conway, Kim van der Riet, and Ted Ross.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5015/
---
(Updated 2012-05-15 13:41:01.807339)
Review request for qpid, Alan Conway, Kim
/XmlExchangePlugin.cpp 1354515
Diff: https://reviews.apache.org/r/5616/diff/
Testing
---
Passes cmake test and automake make check.
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5593/#review8662
---
Ship it!
Ship It!
- Chug Rolke
On June 26, 2012, 7:46 p.m., Alan
/src/qpid/xml/XmlExchange.h 1354515
trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1354515
trunk/qpid/cpp/src/qpid/xml/XmlExchangePlugin.cpp 1354515
Diff: https://reviews.apache.org/r/5616/diff/
Testing
---
Passes cmake test and automake make check.
Thanks,
Chug Rolke
-second time.
I would approve the proposed method if we print only two significant digits of
sub-second time (down to 100ths of a second).
- Chug Rolke
On June 28, 2012, 12:11 a.m., Steve Huston wrote:
---
This is an automatically
/XmlExchangePlugin.cpp 1354515
trunk/qpid/cpp/src/tests/ExchangeTest.cpp 1354515
Diff: https://reviews.apache.org/r/5616/diff/
Testing
---
Passes cmake test and automake make check.
Thanks,
Chug Rolke
/#review8831
---
On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616
generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review8831
---
On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail
://reviews.apache.org/r/5616/#review8833
---
On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616
multiple-node-per-tree tests since that's not how Acl
code uses the node trees.
Thanks,
Chug Rolke
/management/ManagementObject.cpp 1360512
Diff: https://reviews.apache.org/r/5616/diff/
Testing
---
Passes cmake test and automake make check.
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review9105
---
Please don't review this version: changes in progress
- Chug Rolke
1360512
Diff: https://reviews.apache.org/r/5616/diff/
Testing
---
Passes cmake test and automake make check.
Thanks,
Chug Rolke
/5616/diff/
Testing
---
Passes cmake test and automake make check.
Thanks,
Chug Rolke
Diff: https://reviews.apache.org/r/6645/diff/
Testing
---
This feature is generally exercised in file acl.py.
Thanks,
Chug Rolke
/tests/acl.py 1374300
Diff: https://reviews.apache.org/r/6645/diff/
Testing
---
This feature is generally exercised in file acl.py.
Thanks,
Chug Rolke
/diff/
Testing
---
Acl limits exercised for new properties. General allow/deny tests work similar
to queue tests.
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6888/#review11012
---
Ship it!
Ship It!
- Chug Rolke
On Sept. 1, 2012, 6:13 p.m
.
https://issues.apache.org/jira/browse/QPID-4257
Diffs
-
trunk/qpid/cpp/src/qpid/client/windows/SslConnector.cpp 1381603
Diff: https://reviews.apache.org/r/6948/diff/
Testing
---
Thanks,
Chug Rolke
1387614
trunk/qpid/cpp/src/qpidd.cpp 1387614
trunk/qpid/cpp/src/windows/QpiddBroker.cpp 1387614
Diff: https://reviews.apache.org/r/7173/diff/
Testing
---
Passes make test. Compiles and passes on Windows.
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7173/#review11706
---
On Sept. 19, 2012, 4:43 p.m., Chug Rolke wrote
, 2012, 8:32 p.m.)
Review request for qpid, Andrew Stitcher, Chug Rolke, and Steve Huston.
Description
---
This patch introduces a primitive
qpid::sys::SystemInfo::threadSafeShutdown(). It always returns true on Linux
and Solaris. On Windows, it returns true for FreeLibrary
. Well done.
- Chug Rolke
On Sept. 19, 2012, 8:32 p.m., Cliff Jansen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7179
switch names used in acl self tests.
Thanks,
Chug Rolke
tests verify that 1) old code wraps and causes failures, 2) new
code detects pool exhaustion, and 3) new code logs channel numbers being
properly reused.
Normal self tests pass.
Thanks,
Chug Rolke
/qpid/sys/TimerWarnings.cpp 1404293
Diff: https://reviews.apache.org/r/7810/diff/
Testing
---
Passes make test.
Thanks,
Chug Rolke
/#comment28087
The cmake -G Visual Studio 10 builds a 32-bit solution. You may mention
that Visual Studio 10 Win64 builds a 64-bit solution.
- Chug Rolke
On Nov. 2, 2012, 5:19 p.m., Kenneth Giusti wrote:
---
This is an automatically
/Bridge.cpp 1406267
Diff: https://reviews.apache.org/r/7901/diff/
Testing
---
This passes federation 'make test' testing.
Thanks,
Chug Rolke
identical
to windows. So why do gcc versions work? Probably something to do with boost
and ThreadPrivate on the two platforms.
- Chug Rolke
On Nov. 15, 2012, 3:05 a.m., Steve Huston wrote:
---
This is an automatically generated e-mail
/versions.cmake 1420897
Diff: https://reviews.apache.org/r/8556/diff/
Testing
---
Thanks,
Chug Rolke
-CREATION
trunk/qpid/cpp/src/versions.cmake 1420897
Diff: https://reviews.apache.org/r/8556/diff/
Testing
---
Thanks,
Chug Rolke
/9139/#comment34139
This instance is missing the pattern 'if not opts.ssl_certificate:'
- Chug Rolke
On Jan. 29, 2013, 9:32 p.m., Kenneth Giusti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9139/#review15850
---
Ship it!
Ship It!
- Chug Rolke
On Jan. 29, 2013, 9:32 p.m
Diff: https://reviews.apache.org/r/9260/diff/
Testing
---
Three new sections are added to the Acl self test to test individual users,
groups, the all user, and explicit connection denial with a quota of zero.
Thanks,
Chug Rolke
function that gets extern'd
has a pn_ in it. PN_EXTERN would work. Ship it!
- Chug Rolke
On Feb. 5, 2013, 2:33 a.m., Cliff Jansen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9299
' will overwrite values
specified in the command line.
- Chug Rolke
On Feb. 1, 2013, 8:52 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9260
to the Acl self test to test individual users,
groups, the all user, and explicit connection denial with a quota of zero.
Thanks,
Chug Rolke
/broker/Broker.cpp 1444951
trunk/qpid/cpp/src/qpid/log/Logger.cpp 1444951
trunk/qpid/specs/management-schema.xml 1444951
Diff: https://reviews.apache.org/r/9404/diff/
Testing
---
It worked at my development station. Unit tests on the way.
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9494/#review17208
---
Ship it!
Ship It!
- Chug Rolke
On Feb. 18, 2013, 5:21 p.m
/TopicExchange.h 1451602
trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1451602
Diff: https://reviews.apache.org/r/9698/diff/
Testing
---
Passes normal self tests
Thanks,
Chug Rolke
https://reviews.apache.org/r/9703/#comment36692
probably need a try/catch here
- Chug Rolke
On March 1, 2013, 5:07 p.m., Ernie Allen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9703/#review17273
---
Ship it!
- Chug Rolke
On March 1, 2013, 9:53 p.m., Ernie Allen
://reviews.apache.org/r/9824/#comment37361
How about a test that the new thresholds have the down limit at least one
(or N?) below the up limit? If ever down up you get an event storm.
- Chug Rolke
On March 8, 2013, 3:13 p.m., Ted Ross wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9824/#review17617
---
Ship it!
- Chug Rolke
On March 8, 2013, 3:13 p.m., Ted Ross wrote
trunk/qpid/cpp/src/qpid/sys/CopyOnWriteArray.h 1454111
trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1454111
trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1454111
Diff: https://reviews.apache.org/r/9698/diff/
Testing
---
Passes normal self tests
Thanks,
Chug Rolke
.
trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp
https://reviews.apache.org/r/9698/#comment37571
Fixed in the // TODO code that got added.
- Chug Rolke
On March 8, 2013, 7:42 p.m., Chug Rolke wrote
/src/qpid/broker/HeadersExchange.h 1455571
trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1455571
trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1455571
Diff: https://reviews.apache.org/r/9698/diff/
Testing
---
Passes normal self tests
Thanks,
Chug Rolke
Diff: https://reviews.apache.org/r/10020/diff/
Testing (updated)
---
Several tests to exercise rebind code paths.
Thanks,
Chug Rolke
/src/tests/run_queue_rebind PRE-CREATION
trunk/qpid/specs/management-schema.xml 1460944
trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1460944
Diff: https://reviews.apache.org/r/10020/diff/
Testing
---
Several tests to exercise rebind code paths.
Thanks,
Chug Rolke
/XmlExchange.h 1461592
trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1461592
Diff: https://reviews.apache.org/r/10155/diff/
Testing
---
Passes automake and cmake tests.
Thanks,
Chug Rolke
://reviews.apache.org/r/10155/#comment38631
Good point. Moving new function to private.
- Chug Rolke
On March 27, 2013, 2:38 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10155
?
- Chug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10020/#review18422
---
On March 26, 2013, 1:54 a.m., Chug Rolke wrote
://reviews.apache.org/r/10020/diff/
Testing
---
Several tests to exercise rebind code paths.
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10173/#review18518
---
Ship it!
Ship It!
- Chug Rolke
On March 28, 2013, 9:17 p.m
tests to exercise rebind code paths.
Thanks,
Chug Rolke
---
On April 12, 2013, 9:02 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10436
Diff: https://reviews.apache.org/r/10658/diff/
Testing
---
The ACL self test is enhanced to show that brokers running without the ACL
module/file loaded cannot create federation links.
Thanks,
Chug Rolke
processing and Selector setting results.
Dynamic test added to check --log-disable setting and to check management
setting of disabled elements.
Thanks,
Chug Rolke
test is enhanced to show that brokers running without the ACL
module/file loaded cannot create federation links.
Thanks,
Chug Rolke
/tools/src/py/qpidtoollibs/broker.py 1477103
Diff: https://reviews.apache.org/r/10020/diff/
Testing
---
Several tests to exercise rebind code paths.
Thanks,
Chug Rolke
generated e-mail. To reply, visit:
https://reviews.apache.org/r/10020/#review19948
---
On April 29, 2013, 6:12 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail
. To reply, visit:
https://reviews.apache.org/r/627/
---
(Updated 2011-04-20 16:47:00)
Review request for qpid, Andrew Stitcher, Alan Conway, Chug Rolke, and Steve
Huston.
Summary
---
Fixes ttl overflow on the broker. Added
)
Review request for qpid, Andrew Stitcher, Alan Conway, Chug Rolke, and Steve
Huston.
Summary
---
Fixes ttl overflow on the broker. Added equality operator for
qpid::messaging::Duration (needed it in test and seemed generally valuable).
This addresses bug QPID-3222.
https
/
---
(Updated 2011-04-26 20:08:35)
Review request for qpid, Andrew Stitcher, Gordon Sim, and Chug Rolke.
Summary
---
Prevents buffer overflow bug by explicitly allowing RdmaIO layer to reserve
header space in send buffers.
This addresses bug QPID-3227.
https
/management-schema.xml 1478892
trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1478892
Diff: https://reviews.apache.org/r/10020/diff/
Testing
---
Several tests to exercise rebind code paths.
Thanks,
Chug Rolke
and projects that can run on an
arbitrary system elsewhere. For the qpid WinSDK I started forcing the customers
to run cmake in order to generate the examples. If you can get over raising the
bar so high that the customer must run cmake then many packaging issues become
much simpler.
- Chug Rolke
/Modules/WindowsC99SymbolCheck.py
https://reviews.apache.org/r/10363/#comment46878
Is dumpbin automatically added to the path by the build process or must one
run this with Visual Studio tools in the path from the start?
- Chug Rolke
On July 12, 2013, 12:20 a.m., Cliff Jansen wrote
---
There are 222 self.fail() calls that need to be examined and two of them are
changed in this review. The rest need scrutiny and when fixed may reveal
failures in the code as in QPID-5011.
Thanks,
Chug Rolke
://reviews.apache.org/r/13328/#comment48934
Please extend your commenting to these new methods.
This will require additional code in the .NET binding (and others?) to
allow user access to the underlying feature.
The feature makes sense.
- Chug Rolke
On Aug. 7, 2013, 3:31 p.m., Gordon Sim
https://reviews.apache.org/r/13650/#comment49659
Does this need to be bracketed by if (buffer.available()) like line 1011
above? Just move the closing brace line 1215 to after this code.
- Chug Rolke
On Aug. 19, 2013, 5:20 p.m., Ernie Allen wrote
Diff: https://reviews.apache.org/r/13690/diff/
Testing
---
works for me
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13650/#review25749
---
Ship it!
Ship It!
- Chug Rolke
On Aug. 29, 2013, 2:50 p.m
in the .h file.
- Chug Rolke
On Sept. 5, 2013, 2:09 p.m., Pavel Moravec wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14000
of the original
print-stats-at-object-deletion strategy.
- Chug Rolke
On Sept. 6, 2013, 12:56 p.m., Pavel Moravec wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14000
://reviews.apache.org/r/14254/#comment51393
Don't add ACT_ACCESS to this code. It's a subtle change that will confuse
users.
Just qualify the approveCreateQueue() call with 'if (!queues.find(name))'.
- Chug Rolke
On Sept. 20, 2013, 9:10 p.m., Ernie Allen wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14254/#review26321
---
Ship it!
Ship It!
- Chug Rolke
On Sept. 21, 2013, 4:59 p.m
status.
Thanks,
Chug Rolke
?
Windows builds complain of unsafe functions strcat, sprintf, strncpy,
strncat, and getenv for precisely the reason exposed by this bug.
- Chug Rolke
On Oct. 2, 2013, 11:58 a.m., Gordon Sim wrote:
---
This is an automatically generated
/CMakeLists.txt 1528551
trunk/qpid/cpp/src/amqp.cmake 1528551
Diff: https://reviews.apache.org/r/14443/diff/
Testing
---
Windows and Linux clients may create Amqp 0.10 and 1.0 connections without
setting any environment variables.
make test passes all tests.
Thanks,
Chug Rolke
/qpid/cpp/src/amqp.cmake 1528551
Diff: https://reviews.apache.org/r/14443/diff/
Testing
---
Windows and Linux clients may create Amqp 0.10 and 1.0 connections without
setting any environment variables.
make test passes all tests.
Thanks,
Chug Rolke
setting any environment variables.
make test passes all tests.
Thanks,
Chug Rolke
---
Windows and Linux clients may create Amqp 0.10 and 1.0 connections without
setting any environment variables.
make test passes all tests.
Thanks,
Chug Rolke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15273/#review28289
---
Ship it!
Tedious but straightforward.
- Chug Rolke
On Nov. 6
1 - 100 of 161 matches
Mail list logo
