Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
After @hbdeshmukh and I's code review, we created:
* QUICKSTEP-90
* QUICKSTEP-91
in response to some of the issues we found. @zuyu 90 will address the async
upgrade
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r113040305
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113038771
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -194,7 +194,7 @@ P::PhysicalPtr ReuseAggregateExpressions::applyToNode
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
@zuyu Thank you for review. I addressed the minor stuff and will look into
Async when I have more time this coming week.
---
If your project is set up for it, you can reply
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112837404
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836758
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836622
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836342
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836146
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836065
--- Diff: cli/CMakeLists.txt ---
@@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112835877
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,25 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should als
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112787479
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
I should also mention that @hbdeshmukh and I had a discussion yesterday
about refactoring the CLI main method. I was unhappy with how cluttered seeming
it has become, and this PR only
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112686604
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/236
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/234
LTM if comments are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112333485
--- Diff: relational_operators/UnionAllOperator.hpp ---
@@ -149,6 +151,11 @@ class UnionAllOperator : public RelationalOperator
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r11271
--- Diff: relational_operators/UnionAllOperator.cpp ---
@@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders(
}
bool
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112333067
--- Diff: relational_operators/UnionAllOperator.cpp ---
@@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders(
}
bool
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112325082
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324538
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324457
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112323095
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112322839
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
Thanks @hbdeshmukh , fixed validate_cmakelists issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
@hbdeshmukh I created a ticket `QUICKSTEP-87`; maybe you can show me how to
link to this PR later.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/232
Adds network cli interface.
# Adds Network CLI functionality to Single Node
**Functional Changes include:**
Then, run quickstep in `network` mode (defaults to `local
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu I'm going to close this PR and submit another one with the tests as I
think the content has changed sufficiently enough to have another PR
---
If your project is set up
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542826
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542764
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542523
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542459
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542269
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu Thank you for the review
Here's a possibility based on your overall comment: I could add the IOBase
and its subclass GrpcWrapper to this PR. The IOBase abstracts around all
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu is there something special we specify in Travis to get Proto3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
D'oh I think what I read was `EOF` and was thinking, wtf, do I add a EOF?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
What is an EOL? I thought what you were saying was to add a `\n` but is
that not it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
@zuyu updated. I tried adding a new line but it doesn't seem to be added on
github. Does it really matter? If not, I'll merge
---
If your project is set up for it, you can reply
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/228
Refactored out proto GenerateCPP function
Refactored out the GenProto methods from the main cmakelist. This cuts down
on clutter and is something I ran into when making the single-node
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/226
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/226#discussion_r109448735
--- Diff: storage/AggregationOperationState.cpp ---
@@ -949,9 +949,15 @@ void
AggregationOperationState::finalizeHashTableImplThreadPrivate
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/213#discussion_r106643961
--- Diff: release/release_cmds.sh ---
@@ -100,6 +101,23 @@ publish_candidate() {
cd $BASE_DIR
}
+release_audit
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/213#discussion_r106544574
--- Diff: release/release_cmds.sh ---
@@ -50,14 +51,14 @@ create_artifacts() {
# Make the signature. This requires human input
gpg
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/213
Added script for release license audit
@hbdeshmukh Take a look, this will be useful in the future.
You can merge this pull request into a Git repository by running:
$ git pull
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/212
LTGM, covers what Josh said in the @dev chat. There's still more to do in
the NOTICE/LICENSE file, however.
---
If your project is set up for it, you can reply to this email and have
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
That would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/207
These are small changes. Also, travis is failing because of a whitespace
issue addressed in #206 . I will merge this now.
---
If your project is set up for it, you can reply
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/207
Added dockerfile for release testing
Many people have asked for the dockerfile I've been using to test the
release. In light of this, I'll add it to the main repo.
I updated
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/206
fixes travis ws issue
This is going to fix a whitespace issue which is causing travis to fail. I
will merge this before creating RC6.
You can merge this pull request into a Git
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/203
I have no objections ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/204
@hbdeshmukh this should go in before RC6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/204
Cmake changes for default build
This fixes two annoying build issues
1. If the CMAKEBUILDTYPE is not set by the user, it previously defaulted to
none-type which caused one
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/203
@hbdeshmukh This one will be good to have in before the next release
candidate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/203
fixes bug in ordering of cmds
Minor bugfixes to the release scripts. Previously I was saving the wrong
directories to environment variables. Also, adding grep to one of the commands
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/199
@jianqiao it's gtg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@zuyu I cannot recreate the issue you are describing.
```
Starting Quickstep with 8 worker thread(s) and a 11.20 GB buffer pool.
--num_workers is 8, but only specified 0
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/199
Init release scripts
Includes:
- command to create artifacts
- command to publish release candidates
- command to test a release candidate
All commands
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/196
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/198
patch to fix gcc compile error gflags
This fix adds a patch to the third party library `gflags` so that
compilation will work with certain versions of GCC which were previously
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@zuyu yes it fixed the multiple queries issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@jianqiao This does not fix the bug with `\analyze`. That appears to be
something with how the analyze command was written.
---
If your project is set up for it, you can reply
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/188
LGTM, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/188
Adds marcs ssh key to KEYS
For release. I looked at apache KUDU and IMPALA and they both do not keep
the KEYS file in the root of their git project. I wonder if we only need to
keep
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/184
changed and closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/184#discussion_r100139845
--- Diff: BUILDING.md ---
@@ -1,60 +1,71 @@
-Quickstep Build Guide
-=
+# Quickstep Build Guide
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/184
> The job exceeded the maximum time limit for jobs, and has been terminated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/184
Refactor building.md
* Added table of content
* updated building instructions
* Removed some redundancy
* Moved bonus sections into the appendix
You can merge this pull
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
Merged, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
What was your solution to tc malloc issue on mac, just ignore it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
BTW this is so we can build on Mac. @pateljm
I'm still finding that I must specify `cmake -DUSE_TCMALLOC=FALSE ..`. Then
it builds successfully on Mac.
---
If your project
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/183
Adds regex to specify 16.+ versions of Darwin
Before this change, only one recent version of Darwin was correctly
having the compiler flags modified to allow for deprecated syscalls
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Though, I would say, one enhancement we can do right now, is check that the
user has `curl` and stop the script if they don't.
---
If your project is set up for it, you can reply
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Also, @hbdeshmukh, I ran it on my machine, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
@zuyu I think that's a good idea. Maybe though, that could be a version 2
feature. Seeing as before we had 3 commands with `submodule`, this is an
improvement.
---
If your project
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
@zuyu are you suggesting that the `cmake` command should automatically run
the download script?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/129
Does it normally prompt for a uname/pw? I entered my apache name:
```
marc@marc-laptop:incubator-quickstep (master)*$ git push apache master
Username for 'https://git-wip
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/129
@hbdeshmukh What is the site you use with directions to merge?
I have the following error when I try to push to apache's master:
```
marc@marc-laptop:incubator
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/138#discussion_r88716447
--- Diff: utility/NetworkUtil.cpp ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/129
It's happening in #140 as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/140
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/141
LGTM.
I image debugging the distributed version is difficult and I am guessing
that is what this is related to. Was this change warranted by anything
specific?
---
If your
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/129
Has this error happened to anyone before on Travis @hbdeshmukh
@hakanmemisoglu @zuyu ?
```
[ 64%] Building CXX object
types/operations/comparisons/CMakeFiles
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/129#discussion_r88499673
--- Diff: storage/InsertDestination.hpp ---
@@ -517,6 +527,12 @@ class PartitionAwareInsertDestination : public
InsertDestination
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/129
@navsan could you verify these are the changes we wanted from your branch?
Then I will merge, and at a later date, remove the PackedRowStore.
Thanks!
---
If your project is set
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/129
@hbdeshmukh
I ran this with SBB 100 on cloudlab. The experiments mentioned in the
header did not include the HashJoin modification, these results do.
787.11
830.48
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/129
Partial inserts
This change enables use of the PartialBulkInserts feature, an efficient
implementation of which was introduced in the SplitRowStore in #100 . Most of
these changes were
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/125
@hbdeshmukh Here is the change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/125
QUICKSTEP-61 Fixes varlen insert bug.
This change fixes an incorrect estimate for the maximum size of a tuple.
Previously, it was not accounting for the space used by the fixed length
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/114
@saketj so what's the final analysis on why the branchless code takes
longer on these queries? Is it because if the branch is predicted correctly,
then the old code is slightly faster
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
@jianqiao thanks! will close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
@jianqiao Sure, that sounds good. @navsan and I talked about another
alternative which is to call the BitVector constructor instead of `setMemory`.
I made the `set` method because I
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
If that's what were waiting on, then yes, I can go test it. Of course that
will be with a subset of working queries.
---
If your project is set up for it, you can reply to this email
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
@hbdeshmukh I updated for TPCH in the PR header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
Thanks @hakanmemisoglu I tried something similar to what you were
suggesting and the "works but I don't know why" solution I found was to declare
the variables inside the la
1 - 100 of 114 matches
Mail list logo
