Re: Review Request 56309: [RANGER-1351] Fix loggers to be final static fields

: https://reviews.apache.org/r/56309/diff/ Testing --- Thanks, Zsombor Gegesy

Review Request 56306: RANGER-1350: Fix generic type usage, removing SuppressWarning annotations

/ranger/service/XUserPermissionServiceBase.java a5a1213 Diff: https://reviews.apache.org/r/56306/diff/ Testing --- Thanks, Zsombor Gegesy

Review Request 56309: [RANGER-1351] Fix loggers to be final static fields

/ranger/services/storm/client/StormResourceMgr.java 02f94f9 ugsync/src/main/java/org/apache/ranger/usergroupsync/AbstractMapper.java 86b621b Diff: https://reviews.apache.org/r/56309/diff/ Testing --- Thanks, Zsombor Gegesy

Review Request 56888: [RANGER-1377] code cleanup in the security admin module - use collection.isEmpty

: https://reviews.apache.org/r/56888/diff/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 56890: [RANGER-1377] eliminate unnecessary toString methods, and use String.valueOf properly

.apache.org/r/56890/#review166286 --- On Feb. 21, 2017, 3:49 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 56827: [RANGER-1393] Fix generic types in RangerAuditFields

/TestRangerTagDefServiceBase.java 803191e23753b13277b78fba7051c18fd5eb Diff: https://reviews.apache.org/r/56827/diff/ Testing --- Thanks, Zsombor Gegesy

Review Request 56578: [RANGER-1376] Upgrade jersey to 1.19.3 and trying to remove version duplication

19caacdcac0ac58e39ef7204fb873672aa15 security-admin/pom.xml 5a63cb95a687bada3bf38065a7a05922c520c29e Diff: https://reviews.apache.org/r/56578/diff/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 56580: [RANGER-1377] - code cleanup in security-admin module

/apache/ranger/biz/TestServiceDBStore.java 2b773da Diff: https://reviews.apache.org/r/56580/diff/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 56827: [RANGER-1393] Fix generic types in RangerAuditFields

/TestRangerServiceDefServiceBase.java b73a629 security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java 803191c Diff: https://reviews.apache.org/r/56827/diff/ Testing --- Thanks, Zsombor Gegesy

Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields only fr

/57987/diff/1/ Testing --- Thanks, Zsombor Gegesy

Review Request 57990: RANGER-1480 : First version of the druid plugin. Only 'unsecure' mode is tested, and the autocomplete for druid datasource is not implemented

/io.druid.initialization.DruidModule PRE-CREATION druid/pom.xml PRE-CREATION pom.xml 4fb62e25124bc8ddd67c349cbc440c7173ceb42f Diff: https://reviews.apache.org/r/57990/diff/1/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java d81f6b9 Diff: https://reviews.apache.org/r/57988/diff/2/ Changes: https://reviews.apache.org/r/57988/diff/1-2/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

nch - Zsombor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/#review170412 --- On March 29, 2017, 3:34 p.m., Zsomb

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

) - agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java d81f6b9 Diff: https://reviews.apache.org/r/57988/diff/3/ Changes: https://reviews.apache.org/r/57988/diff/2-3/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 57372: Remove a lot of not used code in XResourceService

-admin/src/main/java/org/apache/ranger/service/XResourceService.java b7cbc59 Diff: https://reviews.apache.org/r/57372/diff/1/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

Diffs (updated) - agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java d81f6b9 Diff: https://reviews.apache.org/r/57988/diff/4/ Changes: https://reviews.apache.org/r/57988/diff/3-4/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

nerated e-mail. To reply, visit: https://reviews.apache.org/r/57987/#review170410 --- On March 28, 2017, 9:18 a.m., Zsombor Gegesy wrote: > > --- > This is an automaticall

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

://reviews.apache.org/r/57987/diff/1-2/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 58332: The browser returns garbled when we login ranger security admin in non-English environment. We need support the internationalization function to solve this problem

gs excellent Properties loading support? - Zsombor Gegesy On April 11, 2017, 7:34 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

> On March 31, 2017, 3:31 p.m., Colm O hEigeartaigh wrote: > > I'm wondering if it makes sense to make the default > > getPolicyEngineOptions() configured via "configureDelegateAdmin"? Why not > > just let ServiceREST do that part? > > Zsombor Gegesy

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

/ Changes: https://reviews.apache.org/r/57987/diff/3-4/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 58608: RANGER-1481 : Capture cluster name in ranger audit info

/GrantRevokeRequest.java Lines 81 (patched) <https://reviews.apache.org/r/58608/#comment245725> setClusterName is called twice. - Zsombor Gegesy On April 21, 2017, 3:04 p.m., bhavik patel wrote: > > --- > This is an automatica

Review Request 57372: Remove a lot of not used code in XResourceService

b7cbc59 Diff: https://reviews.apache.org/r/57372/diff/1/ Testing --- Thanks, Zsombor Gegesy

Review Request 61384: RANGER-1722: Duplicate code for exception wrapping in BaseClient

://reviews.apache.org/r/61384/diff/1/ Testing --- https://travis-ci.org/gzsombor/ranger/builds/260348900 Thanks, Zsombor Gegesy

Review Request 61383: RANGER-1721 : HBase plugins use deprecated code

/RangerAuthorizationFilterTest.java 48b8a17 Diff: https://reviews.apache.org/r/61383/diff/1/ Testing --- https://travis-ci.org/gzsombor/ranger/builds/260345062 Thanks, Zsombor Gegesy

Review Request 61624: RANGER-1733 - remove duplicate fields from the services

/service/XUserService.java 294223b Diff: https://reviews.apache.org/r/61624/diff/1/ Testing --- Tested locally. https://travis-ci.org/gzsombor/ranger/builds/264508518 Thanks, Zsombor Gegesy

Review Request 61594: RANGER-1731: Exclude multiple guava versions

and it unable to load the necessary jars, eg. guava 11.0 - which is not needed in the end at all. Diffs - security-admin/pom.xml cc39be8 Diff: https://reviews.apache.org/r/61594/diff/1/ Testing --- https://travis-ci.org/gzsombor/ranger/builds/263479478 Thanks, Zsombor Gegesy

Re: Review Request 61021: RANGER-1672:Ranger supports plugin to enable, monitor and manage apache kylin

xample 'extra options' or some other structure. So next time, when a new service would need a similar functionality, it could reuse the code - and not in a 'copy-paste' sense :) - Zsombor Gegesy On Aug. 8, 2017, 2:08 a.m., Qiang Zhang

Re: Review Request 59604: RANGER-1157 - Handle the review suggestions from Josh Elser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59604/#review182694 --- Ship it! I'm not a commiter, but I like it :) - Zsombor

Review Request 61035: Adding travis.yml to run the tests

, Zsombor Gegesy

Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the tests

PRE-CREATION pom.xml 3fcc4aa Diff: https://reviews.apache.org/r/61035/diff/1/ Testing --- Successful build on travis: https://travis-ci.org/gzsombor/ranger/builds/255768716 Thanks, Zsombor Gegesy

Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the tests

-CREATION pom.xml 7ae0217 Diff: https://reviews.apache.org/r/61035/diff/2/ Changes: https://reviews.apache.org/r/61035/diff/1-2/ Testing --- Successful build on travis: https://travis-ci.org/gzsombor/ranger/builds/255768716 Thanks, Zsombor Gegesy

Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the tests

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/61035/#review181216 ------- On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote: > > --- > This is an au

Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the tests

ed e-mail. To reply, visit: https://reviews.apache.org/r/61035/#review181450 --- On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mai

Review Request 61062: RANGER-1707 : fix hdfs traverse check

/RangerHdfsAuthorizerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/61062/diff/1/ Testing --- Tested locally https://travis-ci.org/gzsombor/ranger/builds/256331500 Thanks, Zsombor Gegesy

Re: Review Request 61384: RANGER-1722: Duplicate code for exception wrapping in BaseClient

/src/main/java/org/apache/ranger/plugin/client/BaseClient.java e1f9796 Diff: https://reviews.apache.org/r/61384/diff/2/ Changes: https://reviews.apache.org/r/61384/diff/1-2/ Testing --- https://travis-ci.org/gzsombor/ranger/builds/260348900 Thanks, Zsombor Gegesy

Re: Review Request 61384: RANGER-1722: Duplicate code for exception wrapping in BaseClient

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61384/#review182399 ------- On Aug. 4, 2017, 8:22 p.m., Zsombor Gegesy wrote: > >

Re: Review Request 61384: RANGER-1722: Duplicate code for exception wrapping in BaseClient

/BaseClient.java e1f9796 Diff: https://reviews.apache.org/r/61384/diff/3/ Changes: https://reviews.apache.org/r/61384/diff/2-3/ Testing --- https://travis-ci.org/gzsombor/ranger/builds/260348900 Thanks, Zsombor Gegesy

Re: Review Request 57990: RANGER-1480 : Druid plugin. Only 'unsecure' mode is tested, authentication should be provided independently (by the kerberos extension)

/ Testing (updated) --- Running a local druid cluster, creating policy, using autocomplete field for finding datasources, etc Thanks, Zsombor Gegesy

Review Request 59606: RANGER-1618 : make the PasswordUtil thread safe

e424f1c agents-common/src/test/java/org/apache/ranger/plugin/util/PasswordUtilsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59606/diff/1/ Testing --- Thanks, Zsombor Gegesy

Review Request 60134: RANGER-1646 : providing more useful error messages in SSL configuration problems

the user could solve it. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b Diff: https://reviews.apache.org/r/60134/diff/1/ Testing --- Thanks, Zsombor Gegesy

Re: Review Request 60134: RANGER-1646 : providing more useful error messages in SSL configuration problems

/r/60134/diff/1-2/ Testing --- Thanks, Zsombor Gegesy

Review Request 58959: RANGER-1431 should be added to ranger-0.7

--- Thanks, Zsombor Gegesy

Re: Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

- Zsombor Gegesy On Oct. 2, 2017, 2:11 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

/ Testing --- Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647 Thanks, Zsombor Gegesy

Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer

- agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 56a24ed Diff: https://reviews.apache.org/r/62659/diff/1/ Testing --- Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647 Thanks, Zsombor Gegesy

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

ed. - Zsombor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63987/#review191793 --- On Nov. 22, 2017, 12:23 p.m., Zsomb

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

with executing: mvn -DskipTests package assembly:assembly; unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt And comparing the results with different versions. With the patch, the guava jar appears correctly. Thanks, Zsombor Gegesy

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

/256331500 Thanks, Zsombor Gegesy

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

plugin" > > > > > for (FsAction action : Arrays.asList(FsAction.EXECUTE, FsAction.READ, > > > FsAction.WRITE)) { > > > > I think the FsAction.EXECUTE is not necessary here, as we are checking > > EXECUTE already in "traverseOnlyCheck". &g

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

ly, visit: https://reviews.apache.org/r/63987/#review191693 --- On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

------ On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63987/ > --

Re: Review Request 64323: RANGER-1915:Optimize the code and keep the code style consistent in the RangerAdminRESTClient class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64323/#review192825 --- Ship it! Ship It! - Zsombor Gegesy On Dec. 5, 2017, 2:39

Re: Review Request 64572: RANGER-1927 - Upgrade Hive to 2.3.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64572/#review193693 --- Ship it! Ship It! - Zsombor Gegesy On Dec. 13, 2017, 11:05

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

. - Zsombor Gegesy On Nov. 17, 2017, 3:23 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 63921: RANGER-1896 : Remove deprecated extractedCommonCriterias call from the SearchUtil and fix the UserREST controller

://rangerhost/service/users?sortBy=emailAddress http://rangerhost/service/users?sortBy=firstName http://rangerhost/service/users?sortBy=lastName Thanks, Zsombor Gegesy

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

/gzsombor/ranger/builds/256331500 Thanks, Zsombor Gegesy

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61062/#review191583 ------- On Nov. 21, 2017, 4:34 p.m., Zsombor Gegesy wrote: > >

Review Request 63987: RANGER-1905 : fix maven assembly creation

-DskipTests package assembly:assembly; unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt And comparing the results with different versions. With the patch, the guava jar appears correctly. Thanks, Zsombor Gegesy

Review Request 63700: [RANGER-1881] Reduce code duplication in kms, where the console handling code is repeated 4 times.

--- Run the command line tools. Travis tests: https://travis-ci.org/gzsombor/ranger/builds/299618293 Thanks, Zsombor Gegesy

Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63575/#review190293 ----------- On Nov. 6, 2017, 10:22 a.m., Zsombor Gegesy wrote: > > --

Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63575/#review190276 ------- On Nov. 6, 2017, 10:22 a.m., Zsombor Gegesy wrote: > > --- &g

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt And comparing the results with different versions. With the patch, the guava jar appears correctly. Thanks, Zsombor Gegesy

Re: Review Request 64228: Traverse check in RangerHdfsAuthorizer works incorrectly

, as in the original test cases, the new code work in a compatible way, not breaking the old tests. - Zsombor Gegesy On Nov. 30, 2017, 10:38 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Review Request 64413: [RANGER-1921] Fix Coverity scan warnings in RangerHdfsAuthorizer

hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerHdfsAuthorizerTest.java 823cd9302 Diff: https://reviews.apache.org/r/64413/diff/1/ Testing --- Tested locally, and with travis: https://travis-ci.org/gzsombor/ranger/builds/312941762 Thanks, Zsombor Gegesy

Re: Review Request 67111: RANGER-2101 : Testcases Improvement to follow best practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67111/#review202998 --- Ship it! Ship It! - Zsombor Gegesy On May 14, 2018, 9:31

Re: Review Request 67117: RANGER-2078

tener delegates to the ConsumerRunnable, so you don't need it. - Zsombor Gegesy On May 14, 2018, 8:10 p.m., Felix Albani wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 66950: RANGER-2096 - remove dead code

a64bb3048 security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 174f919a3 Diff: https://reviews.apache.org/r/66950/diff/2/ Changes: https://reviews.apache.org/r/66950/diff/1-2/ Testing --- Tested locally, and on a cluster Thanks, Zsombor Gegesy

Re: Review Request 66946: Good coding practice for ranger response codes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66946/#review202434 --- Ship it! Ship It! - Zsombor Gegesy On May 4, 2018, 10:26

Review Request 66950: RANGER-2096 - remove dead code

/TestRangerBizUtil.java 10e517fb1 Diff: https://reviews.apache.org/r/66950/diff/1/ Testing --- Tested locally, and on a cluster Thanks, Zsombor Gegesy

Re: Review Request 67196: RANGER-2107 - use spring for injecting DAO by generic parameters, and remove the unnecessary code

--- Tested locally and as a server with a cluster Thanks, Zsombor Gegesy

Re: Review Request 67196: RANGER-2107 - use spring for injecting DAO by generic parameters, and remove the unnecessary code

ail. To reply, visit: https://reviews.apache.org/r/67196/#review203460 --- On May 20, 2018, 9:20 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 67196: RANGER-2107 - use spring for injecting DAO by generic parameters, and remove the unnecessary code

with a cluster Thanks, Zsombor Gegesy

Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

().put(...)' - Zsombor Gegesy On June 12, 2018, 10:33 a.m., bhavik patel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67544/#review204680 --- Ship it! Ship It! - Zsombor Gegesy On June 13, 2018, 10:48

Re: Review Request 67404: RANGER-2118: Update libpam4j version in ranger package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67404/#review204143 --- Ship it! Ship It! - Zsombor Gegesy On May 31, 2018, 8:06

Re: Review Request 67206: RANGER-2108: Ensure that resource and access-type names in service definition are in lower case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67206/#review204145 --- Ship it! Ship It! - Zsombor Gegesy On May 30, 2018, 8:49

Re: Ranger 1.1 release

+1 - I believe in the "release early release often" mantra :) Regards, Zsombor On Sun, Jun 24, 2018 at 5:56 PM, Srikanth Venkat wrote: > +1, it would be nice to have a Ranger release baseline that aligns with > Atlas 1.0. > Thanks Vel for taking the initiative! > > Thx > Srikanth Venkat >

Review Request 65079: RANGER-1951 - fix saveVersion.py

: https://reviews.apache.org/r/65079/diff/1/ Testing --- Executed the build with python3 and python2, checked that hash is generated from 1239 files. Thanks, Zsombor Gegesy

Re: Review Request 62532: RANGER-1805: Code improvement to follow best practices in js

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62532/#review196232 --- Ship it! - Zsombor Gegesy On Jan. 25, 2018, 5:16 a.m., Nitin

Re: Review Request 65288: RANGER-1961

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65288/#review196233 --- Ship it! - Zsombor Gegesy On Jan. 23, 2018, 3:49 p.m

Re: Review Request 65129: RANGER-1954 - Specify a version for the native-maven-plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65129/#review195343 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 12, 2018, 6:26

Review Request 65135: [RANGER-1949] instead of checking that all the keys could be listed, check it one-by-one

- kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java be3700ffa Diff: https://reviews.apache.org/r/65135/diff/1/ Testing --- Tested on a live cluster with 'hadoop key list' and playing around with various KMS policies. Thanks, Zsombor Gegesy

Re: Review Request 65418: Policy engine initialization does not create context enrichers in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65418/#review196514 --- Ship it! Ship It! - Zsombor Gegesy On Jan. 30, 2018, 5:33

Re: Review Request 65485: RANGER-1971 - Switch to use for-each loops

rocess/PolicyMgrUserGroupBuilder.java Line 431 (original), 430 (patched) <https://reviews.apache.org/r/65485/#comment276586> Instead of if (map.containsKey(x)) { ... map.get(x) } value = map.get(x); if (value != null) { ... value } - Zsombor Gege

Re: Review Request 65484: RANGER-1969 - Fix failing Kafka tests with latest maven/JVM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65484/#review196784 --- Ship it! Ship It! - Zsombor Gegesy On febr. 2, 2018, 2:56

Re: Review Request 65567: RANGER-1972 : Ability to label policies, filter/search and show policies by labels

.java Lines 331 (patched) <https://reviews.apache.org/r/65567/#comment277189> System.out - Zsombor Gegesy On Feb. 8, 2018, 12:08 p.m., bhavik patel wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 65525: Show actual hive query on ranger audit UI

matter = { 'hive' : function(model) { ... } } security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js Lines 1633 (patched) <https://reviews.apache.org/r/65525/#comment277188> The same trick could be applied. - Zsombor Gegesy On Feb. 6, 2018, 6:46 a.m., Ni

Review Request 65793: RANGER-1991 : fix errors detected by static code analysis

n/java/org/apache/ranger/rest/ServiceREST.java 9e4d799b Diff: https://reviews.apache.org/r/65793/diff/1/ Testing --- Tested locally Thanks, Zsombor Gegesy

Re: Review Request 65739: RANGER-1985: Auditing for Ranger usersync operations

ountQueryStr and distinctQueryStr can be final static constant value. ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java Lines 184 (patched) <https://reviews.apache.org/r/65739/#comment278322> On error, why don't you set 'isUpdateSinkSucc = false' ? - Zsombor G

Review Request 65777: RANGER-1967 - Kafka 1.0 support

/authorizer/KafkaRangerAuthorizerTest.java fb0a2c0f plugin-kafka/src/test/resources/log4j.properties PRE-CREATION pom.xml fa1d1c7b ranger-kafka-plugin-shim/pom.xml f1aeee6f Diff: https://reviews.apache.org/r/65777/diff/1/ Testing --- Unit & local tests Thanks, Zsombor Gegesy

Re: Review Request 65709: RANGER-1987 - Upgrade to Storm 1.2.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65709/#review198209 --- Ship it! Ship It! - Zsombor Gegesy On Feb. 19, 2018, 4:21

Re: Prep for ranger-1.0.0 release

+1 for Ranger 1.0 ! Regards, Zsombor On Sat, Feb 24, 2018 at 5:03 AM, Velmurugan Periasamy wrote: > +1 for Ranger 1.0 release. > > Thanks Sailaja for volunteering. > > From: pengjianhua <35573...@qq.com> > Reply-To: "dev@ranger.apache.org" > Date:

Re: Review Request 65752: RANGER-1990: Add One-way SSL MySQL support in Ranger Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65752/#review198211 --- Ship it! Ship It! - Zsombor Gegesy On Feb. 22, 2018, 10:31

Re: Review Request 65777: RANGER-1967 - Kafka 1.0 support

://reviews.apache.org/r/65777/diff/2/ Changes: https://reviews.apache.org/r/65777/diff/1-2/ Testing --- Unit & local tests Thanks, Zsombor Gegesy

Re: Review Request 67642: RANGER-2132 : Add unit tests for org.apache.ranger.common package

;, "knox")); Set actualSet = jsonUtil.writeJsonToJavaObject("[\"hdfs\",\"hive\",\"knox\"]", HashSet.class); - Zsombor Gegesy On June 19, 2018, 9:46 a.m., bhavik patel wrote: > > ---

Re: Review Request 67642: RANGER-2132 : Add unit tests for org.apache.ranger.common package

> On June 19, 2018, 10:05 a.m., Zsombor Gegesy wrote: > > security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java > > Line 110 (original), 112 (patched) > > <https://reviews.apache.org/r/67642/diff/1/?file=2042279#file2042279line113> > > >

Re: Review Request 68077: RANGER-2166: A ClassNotFound exception is thrown with atlasrest as a tag source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68077/#review206541 --- Ship it! Ship It! - Zsombor Gegesy On July 27, 2018, 1:37

Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68042/#review206540 --- Ship it! Ship It! - Zsombor Gegesy On July 27, 2018, 7:32

Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

/RangerConstants.java Lines 175 (patched) <https://reviews.apache.org/r/68042/#comment289474> This could be "final", and maybe Set, as only the "contains" method is used. - Zsombor Gegesy On July 25, 2018,

  1   2   3   4   >