Re: Review Request 72882: SENTRY-2558: Issue in creating full snapshot when the storage descriptor for a table is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72882/#review221882 --- Ship it! Ship It! - Na Li On Sept. 17, 2020, 3:40 p.m.,

Re: Review Request 72704: SENTRY-2422: HMS synchronization is causing multiple entries of the same ID in SENTRY_HMS_NOTIFICATION_ID

> On July 24, 2020, 4 p.m., kalyan kumar kalvagadda wrote: > > Lina, > > > > Do you why are we ssting this issue? Notication should be processed by one > > sentry lender and there is only one thread the processes the notfications > > and updates the database. Kalyan, This is deployed on

Re: Review Request 72706: SENTRY-2557: Queries are running too slow after when there are more than 4k roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72706/#review221345 --- Ship it! Ship It! - Na Li On July 23, 2020, 11:38 p.m.,

Review Request 72704: SENTRY-2422: HMS synchronization is causing multiple entries of the same ID in SENTRY_HMS_NOTIFICATION_ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72704/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2422

Re: Review Request 71942: SENTRY-2545: Rolling back Privilege Cache to SimplePrivilegeCache does not work

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71942/ --- (Updated Dec. 29, 2019, 5:23 a.m.) Review request for sentry and kalyan kumar

Review Request 71942: SENTRY-2545: Rolling back Privilege Cache to SimplePrivilegeCache does not work

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71942/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2545

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 22, 2019, 9:45 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 22, 2019, 7:33 a.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

> On Dec. 21, 2019, 12:35 a.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/TreePrivilegeCache.java > > Lines 170 (patched) > > > > > >

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

> On Dec. 21, 2019, 12:35 a.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetaStoreFilterHook.java > > Lines 233-236 (patched) > > > >

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

> On Dec. 20, 2019, 11:07 p.m., Vihang Karajgaonkar wrote: > > sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/FilteredPrivilegeCache.java > > Lines 35 (patched) > > > > > > I

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 20, 2019, 9:27 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 20, 2019, 8:16 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 20, 2019, 8:15 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

> On Dec. 18, 2019, 10:21 p.m., Vihang Karajgaonkar wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > > Line 852 (original), 852 (patched) > >

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

> On Dec. 18, 2019, 10:21 p.m., Vihang Karajgaonkar wrote: > > sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/TreePrivilegeNode.java > > Lines 163 (patched) > > > > > > please

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

> On Dec. 18, 2019, 10:21 p.m., Vihang Karajgaonkar wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetaStoreFilterHook.java > > Lines 269 (patched) > > > > > >

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 18, 2019, 4:52 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 18, 2019, 4:31 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 18, 2019, 5:34 a.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 17, 2019, 10:17 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 17, 2019, 1:25 a.m.) Review request for sentry, kalyan kumar

Re: Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- (Updated Dec. 15, 2019, 6:43 a.m.) Review request for sentry, kalyan kumar

Review Request 71915: SENTRY-2539: PolicyEngine should be able to return privilege directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71915/ --- Review request for sentry, kalyan kumar kalvagadda and Vihang Karajgaonkar.

Re: Review Request 71901: SENTRY-2540: Only use SELECT action for filter SHOW DATABASES and SHOW TABLES command based on configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71901/ --- (Updated Dec. 13, 2019, 4:38 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 71901: SENTRY-2540: Only use SELECT action for filter SHOW DATABASES and SHOW TABLES command based on configuration

> On Dec. 12, 2019, 6:02 p.m., kalyan kumar kalvagadda wrote: > > Code change looks good. Please add unit tests to cover the same. tests are added for the new behavior both default and enabled - Na --- This is an automatically

Re: Review Request 71901: SENTRY-2540: Only use SELECT action for filter SHOW DATABASES and SHOW TABLES command based on configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71901/ --- (Updated Dec. 13, 2019, 12:23 a.m.) Review request for sentry, kalyan kumar

Review Request 71901: SENTRY-2540: Only use SELECT action for filter SHOW DATABASES and SHOW TABLES command based on configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71901/ --- Review request for sentry, kalyan kumar kalvagadda and Vihang Karajgaonkar.

Re: Review Request 71838: SENTRY-2538: consecutiveUpdateFailuresCount is not reset

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71838/#review218892 --- Ship it! Ship It! - Na Li On Nov. 27, 2019, 4:28 p.m.,

Re: Review Request 70846: SENTRY-2240: User can DROP function under a database that he/she has no access

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70846/#review215909 --- Ship it! Ship It! - Na Li On June 14, 2019, 2:58 p.m.,

Re: Review Request 70068: SENTRY-2503: Failed to revoke the privilege from impala-shell if the privilege added from beeline cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70068/ --- (Updated March 4, 2019, 9:49 p.m.) Review request for sentry and kalyan kumar

Re: Review Request 70068: SENTRY-2503: Failed to revoke the privilege from impala-shell if the privilege added from beeline cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70068/ --- (Updated March 4, 2019, 8:46 p.m.) Review request for sentry and kalyan kumar

Re: Review Request 70068: SENTRY-2503: Failed to revoke the privilege from impala-shell if the privilege added from beeline cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70068/ --- (Updated March 1, 2019, 4:01 a.m.) Review request for sentry and kalyan kumar

Review Request 70068: SENTRY-2503: Failed to revoke the privilege from impala-shell if the privilege added from beeline cli

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70068/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2503

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213102 --- Ship it! Ship It! - Na Li On Feb. 22, 2019, 6:40 p.m.,

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213095 ---

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213094 ---

Re: Review Request 69987: SENTRY-2497: show grant role results should handle case where URI doesn't have a defined scheme

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69987/#review213085 --- Ship it! Ship It! - Na Li On Feb. 21, 2019, 8:17 p.m.,

Re: Review Request 70013: SENTRY-2501: Add cache for HMS server filtering hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70013/ --- (Updated Feb. 20, 2019, 9:59 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/ --- (Updated Feb. 20, 2019, 9:39 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 70013: SENTRY-2501: Add cache for HMS server filtering hook

> On Feb. 20, 2019, 3:36 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java > > Lines 479-506 (patched) > > > > >

Review Request 70013: SENTRY-2501: Add cache for HMS server filtering hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70013/ --- Review request for sentry, Arjun Mishra, Haley Reeve, and kalyan kumar

Re: Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/ --- (Updated Feb. 19, 2019, 9:56 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/ --- (Updated Feb. 19, 2019, 7:12 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/ --- (Updated Feb. 19, 2019, 5:01 p.m.) Review request for sentry, Arjun Mishra,

Review Request 70008: SENTRY-2500: CREATE on server does not provide HMS server side read authorization for get_all_tables(database_name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70008/ --- Review request for sentry, Arjun Mishra, Haley Reeve, and kalyan kumar

Re: Review Request 69924: SENTRY-2440: Add a new thrift API for checking if a user is in admin group

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69924/#review212802 --- Ship it! Ship It! - Na Li On Feb. 7, 2019, 11:47 p.m., Hao

Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69536/#review212797 --- Ship it! Ship It! - Na Li On Feb. 7, 2019, 1:04 a.m., Hao

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/#review212599 --- Ship it! Ship It! - Na Li On Jan. 29, 2019, 9:09 p.m.,

Re: Review Request 69573: SENTRY-2477: When requesting for deltas check if nn seq num is 1 more than latest sequence num

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69573/#review212596 ---

Re: Review Request 69573: SENTRY-2477: When requesting for deltas check if nn seq num is 1 more than latest sequence num

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69573/#review212597 --- Ship it! Ship It! - Na Li On Dec. 17, 2018, 5:07 p.m.,

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 30, 2019, 5:02 a.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

> On Jan. 30, 2019, 12:35 a.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive-conf/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > > Lines 113 (patched) > > > > > >

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

> On Jan. 30, 2019, 12:35 a.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java > > Line 158 (original), 162 (patched) > >

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 29, 2019, 4:15 p.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 28, 2019, 10:14 p.m.) Review request for sentry, Arjun Mishra

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 28, 2019, 9:03 p.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69841/ --- (Updated Jan. 28, 2019, 6:55 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

> On Jan. 28, 2019, 1:55 a.m., kalyan kumar kalvagadda wrote: > > Idea here is to make sure that hive client knows the details of the user > > who is sending the request. In this specific case, hive should know the > > details of the user who running sentry service. Using > >

Re: Review Request 69840: SENTRY-2491: Sentry High availability unit tests run into deadlock sometimes

> On Jan. 25, 2019, 9:01 p.m., kalyan kumar kalvagadda wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > > Lines 150 (patched) > > > > > > You

Re: Review Request 69840: SENTRY-2491: Sentry High availability unit tests run into deadlock sometimes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69840/ --- (Updated Jan. 28, 2019, 4:19 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

> On Jan. 28, 2019, 1:55 a.m., kalyan kumar kalvagadda wrote: > > Idea here is to make sure that hive client knows the details of the user > > who is sending the request. In this specific case, hive should know the > > details of the user who running sentry service. Using > >

Re: Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

> On Jan. 28, 2019, 1:55 a.m., kalyan kumar kalvagadda wrote: > > Idea here is to make sure that hive client knows the details of the user > > who is sending the request. In this specific case, hive should know the > > details of the user who running sentry service. Using > >

Re: Review Request 69840: SENTRY-2491: Sentry High availability unit tests run into deadlock sometimes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69840/ --- (Updated Jan. 25, 2019, 9:46 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69840: SENTRY-2491: Sentry High availability unit tests run into deadlock sometimes

> On Jan. 25, 2019, 9:01 p.m., kalyan kumar kalvagadda wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > > Lines 150 (patched) > > > > > > You

Review Request 69841: SENTRY-2486: Wrong user name when sentry HMSFollower gets full snapshot from HMS at insecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69841/ --- Review request for sentry, Arjun Mishra, Haley Reeve, and kalyan kumar

Review Request 69840: SENTRY-2491: Sentry High availability unit tests run into deadlock sometimes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69840/ --- Review request for sentry, Arjun Mishra, HaleyHH HaleyHH, and kalyan kumar

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 24, 2019, 4:15 p.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69353: SENTRY-2454: Add new sentry store api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review212150 --- Ship it! Ship It! - Na Li On Dec. 18, 2018, 11:23 p.m.,

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/#review211938 ---

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/#review211854 ---

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 11, 2019, 4:55 a.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 9, 2019, 10:39 p.m.) Review request for sentry, Arjun Mishra and

Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- Review request for sentry, Arjun Mishra and kalyan kumar kalvagadda. Bugs:

Re: Review Request 69620: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69620/#review211680 --- Ship it! Ship It! - Na Li On Dec. 21, 2018, 5:39 p.m.,

Re: Review Request 69620: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69620/#review211679 ---

Re: Review Request 69620: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69620/#review211585 --- - Na Li On Dec. 21, 2018, 5:39 p.m., Sergio Pena wrote: > >

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69586/#review211441 --- Ship it! Ship It! - Na Li On Dec. 19, 2018, 3:24 p.m.,

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69586/#review211412 ---

Re: Review Request 69567: SENTRY-1679: HDFS tests configure MetastorePlugin which is gone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69567/#review211335 --- Ship it! Ship It! - Na Li On Dec. 13, 2018, 9:10 p.m.,

Re: Review Request 69501: SENTRY-2466: Create generic sentry store metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69501/#review211250 --- Ship it! Ship It! - Na Li On Dec. 3, 2018, 5:22 p.m., Arjun

Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69536/#review211170 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211169 --- Ship it! Ship It! - Na Li On Nov. 29, 2018, 10:14 p.m.,

Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69536/#review211171 --- can you add test case to cover the issue you want to fix? There

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211147 --- Can you add more test cases to cover the cases that mutiple

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211145 ---

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review29 ---

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review28 --- typo: "sentrys tore" should be "sentry store" - Na Li On Dec.

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/#review27 --- Ship it! Ship It! - Na Li On Dec. 7, 2018, 3:14 p.m.,

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210982 --- sentry-dist/src/license/THIRD-PARTY.properties Line 34

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

> On Nov. 29, 2018, 6:44 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 176 (patched) > > > > > > do you want

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210950 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210949 ---

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210930 --- Ship it! Ship It! - Na Li On Nov. 27, 2018, 3:32 a.m.,

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210909 --- Ship it! Ship It! - Na Li On Nov. 27, 2018, 9:34 p.m.,

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

> On Nov. 26, 2018, 7:44 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Line 37 (original), 37 (patched) > > > > > > should this

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210878 ---

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210877 ---

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210874 ---

Re: Review Request 69415: SENTRY-2463: Revoking ALL or * should revoke any other privilege on the entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69415/#review210870 ---

  1   2   3   4   5   6   >