Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 27, 2017, 6 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Nov. 27, 2017, 4:39 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Nov. 27, 2017, 6:22 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 351 (patched) > > > > > > this should be debug level or

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 28, 2017, 10:16 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 2514 (original), 2513 (patched) > >

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Nov. 29, 2017, 5:43 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 29, 2017, 5:20 p.m.) Review request for sentry, Alexander

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 29, 2017, 5:23 p.m.) Review request for sentry, Alexander

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 29, 2017, 5:22 p.m.) Review request for sentry, Alexander

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Nov. 29, 2017, 4:50 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 251-252 (patched) > > > > > > This line is making me

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Nov. 29, 2017, 5:24 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Nov. 29, 2017, 5:28 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Nov. 30, 2017, 10:41 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Nov. 30, 2017, 11:07 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 346 (patched) > > > > > > Is getting empty

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/ --- (Updated Dec. 12, 2017, 5:10 p.m.) Review request for sentry, Brian Towles,

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Dec. 18, 2017, 4:36 p.m.) Review request for sentry, Alexander

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Dec. 18, 2017, 4:34 p.m.) Review request for sentry, Alexander

Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/ --- (Updated Dec. 14, 2017, 1:54 a.m.) Review request for sentry, Brian Towles,

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/ --- (Updated Dec. 13, 2017, 5:34 p.m.) Review request for sentry, Brian Towles,

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

> On Dec. 12, 2017, 7:01 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > > Line 254 (original), 255 (patched) > > > > > >

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/ --- (Updated Dec. 13, 2017, 5:45 p.m.) Review request for sentry, Brian Towles,

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 19, 2017, 9:22 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 263 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 19, 2017, 9:22 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 263 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Dec. 19, 2017, 8:04 p.m.) Review request for sentry, Alexander

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

> On Dec. 13, 2017, 6:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > > Line 281 (original), 282 (patched) > > > > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Dec. 12, 2017, 1:26 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java > > Line 57 (original), 56 (patched) > > > > > > Not

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

> On Dec. 13, 2017, 6:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > > Line 281 (original), 282 (patched) > > > > >

Re: Review Request 63709: SENTRY-2041: Change Index name in Package.jdo to match index name in SQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63709/#review190827 --- Ship it! Should we also remove the corresponding SQL alter

Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:51 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 283 (patched) > > > > > > Why do we

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- (Updated Nov. 21, 2017, 6:34 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/#review191622 --- Ship it! Ship It! - Arjun Mishra On Nov. 21, 2017, 6:34

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- (Updated Nov. 21, 2017, 6:35 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:51 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 283 (patched) > > > > > > Why do we

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- (Updated Nov. 21, 2017, 7:54 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

> On Nov. 21, 2017, 8:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 257 (patched) > > > > > > the logging level can be info to

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191659 --- Ship it! Ship It! - Arjun Mishra On Nov. 21, 2017, 9:27

Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Nov. 16, 2017, 7:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 348 (original), 353 (patched) > > > > > > You can add a log

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

> On Nov. 16, 2017, 7:11 p.m., Vadim Spector wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java > > Line 220 (original), 225 (patched) > > > > > > at this

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

> On Nov. 16, 2017, 8:14 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3251 (original), 3251 (patched) > > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/ --- Review request for sentry, Sergio Pena and Vadim Spector. Repository: sentry

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/ --- (Updated Nov. 8, 2017, 2:59 p.m.) Review request for sentry, Sergio Pena and

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

> On Nov. 8, 2017, 7 a.m., Alexander Kolbasov wrote: > > Do you also want to update PathUpdate.parsePath() to be consistent? I will check with Vadim on that. > On Nov. 8, 2017, 7 a.m., Alexander Kolbasov wrote: > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Dec. 5, 2017, 9:02 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Dec. 5, 2017, 5:32 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Dec. 6, 2017, 9:12 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > > Line 164 (original), 165 (patched) > > > > > > Question

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Dec. 6, 2017, 4:01 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Dec. 6, 2017, 8:25 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Dec. 6, 2017, 9:03 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 30, 2017, 3:09 p.m., Xinran Tinney wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 3574-3580 (patched) > > > > > >

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/ --- (Updated Dec. 12, 2017, 4:08 p.m.) Review request for sentry, Brian Towles,

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 9:11 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 8:23 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202480 --- Ship it! Ship It! - Arjun Mishra On May 4, 2018, 7:25 p.m.,

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 8:44 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 9:26 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 8, 2018, 8:20 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 8, 2018, 7 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66972: SENTRY-2219: Create index AUTHZ_PATH_FK_IDX at table AUTHZ_PATH only when it does not exist for Oracle

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66972/#review202752 --- Ship it! Ship It! - Arjun Mishra On May 8, 2018, 6:52 p.m.,

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203312 ---

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated May 15, 2018, 4:17 p.m.) Review request for sentry, kalyan kumar

Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

> On May 10, 2018, 10:19 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 420 (patched) > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > General question? Who is authorized to perform this operation? Is it just > > admin? Is it tested? Yes just admin for now. There is an upstream jira to allow non-admins to run but that needs to be coded. I'll add an explicit

Review Request 67218: SENTRY-2238: Add support for DATABASE in show grant on command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Lines 192-195 (patched) > >

Re: Review Request 67218: SENTRY-2238: Add support for DATABASE in show grant on command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/ --- (Updated May 18, 2018, 6:47 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 15, 2018, 9:37 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > > Lines 31-142 (original), 32-145 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 15, 2018, 9:37 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 1595 (original), 1595 (patched) > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 15, 2018, 9:37 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 209 (patched) > > > > > > If it

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated May 17, 2018, 4:46 a.m.) Review request for sentry, kalyan kumar

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated May 18, 2018, 11:54 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

- Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204870 --- On June 15, 2018, 8:08 p.m., Arjun Mishra wrote: > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 15, 2018, 10:46 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 291 (patched) > > > > > > I

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 18, 2018, 6:59 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 18, 2018, 7:08 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 15, 2018, 9:02 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Line 206 (original), 211 (patched) > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 15, 2018, 10:46 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 276 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 18, 2018, 9:31 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 295 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 18, 2018, 9:31 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Line 243 (original), 258 (patched) > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 18, 2018, 9:31 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryObjectPrivileges.java > > Lines 27-28 (patched) > > > > > > Assing the

Re: Review Request 67555: SENTRY-2267: Listing user privileges fails because roleName field is required on Thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67555/#review204631 --- Ship it! Ship It! - Arjun Mishra On June 12, 2018, 6:46

Re: Review Request 67555: SENTRY-2267: Listing user privileges fails because roleName field is required on Thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67555/#review204626 ---

Re: Review Request 67555: SENTRY-2267: Listing user privileges fails because roleName field is required on Thrift

> On June 12, 2018, 6:58 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java > > Lines 270 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > General question? Who is authorized to perform this operation? Is it just > > admin? Is it tested? > > Arjun Mishra wrote: > Yes just admin for now. There is an upstream jira to allow non-admins to > run but that needs to be

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 13, 2018, 10:10 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67588: SENTRY-2270: Illegal privileges on columns can be granted on Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67588/#review204783 --- Ship it! Ship It! - Arjun Mishra On June 13, 2018, 10:39

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 15, 2018, 4:22 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > > Lines 492 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 15, 2018, 4:22 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > > Lines 492 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 15, 2018, 7:58 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On June 15, 2018, 4:22 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Line 241 (original), 259 (patched) > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 15, 2018, 8:01 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67218: SENTRY-2238: Add support for DATABASE in show grant on command

> On June 11, 2018, 4:03 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Lines 302-305 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 19, 2018, 7:43 p.m.) Review request for sentry, kalyan kumar

  1   2   3   4   5   >