P. Taylor Goetz created STORM-656:
-
Summary: Document external modules and Committer Sponsors
Key: STORM-656
URL: https://issues.apache.org/jira/browse/STORM-656
Project: Apache Storm
Issue
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/416#issuecomment-72779670
@HeartSaVioR, yes. Basically just an indicator that at least one committer
(i.e. someone with commit rights) is interested in supporting a module.
But your
[
https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304530#comment-14304530
]
ASF GitHub Bot commented on STORM-656:
--
Github user ptgoetz commented on the pull
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304493#comment-14304493
]
ASF GitHub Bot commented on STORM-534:
--
Github user caofangkun commented on the pull
[
https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304668#comment-14304668
]
ASF GitHub Bot commented on STORM-487:
--
Github user dashengju commented on the pull
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/394#issuecomment-72776924
@revans2
it might be good to:
1: the configuration should be paginated
2: we'd better supply three types of configuration and they may
different from
[
https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304506#comment-14304506
]
ASF GitHub Bot commented on STORM-656:
--
GitHub user ptgoetz opened a pull request:
[
https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304681#comment-14304681
]
ASF GitHub Bot commented on STORM-487:
--
Github user dashengju commented on the pull
Github user dashengju commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-72795383
@harshach , ok, you or @HeartSaVioR should responsible for fix this bug,
because I just know how to fix it in linux, but not in windows.
thanks
---
If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/394#issuecomment-72780192
@revans2 @caofangkun Any reason to store storm config in zookeeper. I
don't see any benefit of it and whenever user/admin changes storm config these
needs to be updated
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/416#issuecomment-72780287
@ptgoetz
Yes, it can make sense.
Contributors which bring a new external module to Storm are willing to
contribute more, and it can prevent failing morale
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304568#comment-14304568
]
ASF GitHub Bot commented on STORM-534:
--
Github user harshach commented on the pull
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/394#issuecomment-72782784
@caofangkun Thanks . I think it helps categorizing the configuration into
different section. But in a storm deployment same storm.yaml used on all hosts.
So I don't
Hi,
I have a topology running in local mode. The topology uses kafkaspout and
is configured to use the external zookeeper. But when I start the topology,
I see the following:
org.apache.storm.zookeeper.ZooKeeper - Initiating client connection,
connectString=localhost:2000
I also messages like
[
https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304676#comment-14304676
]
ASF GitHub Bot commented on STORM-487:
--
Github user harshach commented on the pull
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-72794546
@dashengju I second that ,just recently noticed it . We can file a
follow-up jira for it.
---
If your project is set up for it, you can reply to this email and have
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/416
STORM-656: Document external modules and Committer Sponsors
JIRA: https://issues.apache.org/jira/browse/STORM-656
You can merge this pull request into a Git repository by running:
$ git pull
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/416#issuecomment-72778805
PR described committer sponsors clearly, especially only committers can
join external's committer sponsors. Right?
---
If your project is set up for it, you can
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/394#discussion_r24060605
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -18,12 +18,17 @@
[java.util Collections])
(:import [java.io
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304585#comment-14304585
]
ASF GitHub Bot commented on STORM-534:
--
Github user caofangkun commented on a diff in
[
https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304515#comment-14304515
]
ASF GitHub Bot commented on STORM-656:
--
Github user HeartSaVioR commented on the pull
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304566#comment-14304566
]
ASF GitHub Bot commented on STORM-534:
--
Github user harshach commented on a diff in
[
https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304521#comment-14304521
]
ASF GitHub Bot commented on STORM-609:
--
Github user HeartSaVioR commented on the pull
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/365#issuecomment-72779122
@dashengju
According to #416, we should remove ourselves from committer sponsors to
let storm-redis module can be merged into master.
Thanks for
Hi all,
In my topology, kafka spout is responsible for over 85% of the latency. I
have tried different spout max pending and played with the buffer size and
fetch size, still no luck. Any hint on how to optimize the spout? The issue
doesn't seem to be with the kafka side, as I see high
[
https://issues.apache.org/jira/browse/STORM-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302974#comment-14302974
]
Olga Gorun commented on STORM-650:
--
Hi all,
Linking a variant of 'Improve Error Handling'
Github user miguno commented on the pull request:
https://github.com/apache/storm/pull/268#issuecomment-72653588
@tedxia (or @clockfly): Have you experienced similar Storm behavior as [I
described
above](https://github.com/apache/storm/pull/268#issuecomment-72652704) in your
patched
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24043926
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24044371
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/Column.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/415
STORM-581. Add rebalance params to Storm REST API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-581-V1
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/370#issuecomment-72748703
closing this PR. https://github.com/apache/storm/pull/415 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/STORM-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304145#comment-14304145
]
ASF GitHub Bot commented on STORM-581:
--
Github user harshach commented on the pull
[
https://issues.apache.org/jira/browse/STORM-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304147#comment-14304147
]
ASF GitHub Bot commented on STORM-581:
--
Github user harshach closed the pull request
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24015372
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/Column.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-635.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks [~sriharsha],
I merged this
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24014941
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/374#issuecomment-72685012
For the most part it looks OK. I am concerned about a few of the APIs seem
confusing to me and could use some better javadocs. Also I am concerned with
the performance
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303599#comment-14303599
]
ASF GitHub Bot commented on STORM-635:
--
Github user asfgit closed the pull request at:
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24014635
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24014770
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24015210
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcLookupBolt.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-72688638
I rebased it so it would merge cleanly. @kishorvpatil if you could take a
look again that would be great.
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/STORM-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303574#comment-14303574
]
ASF GitHub Bot commented on STORM-570:
--
Github user revans2 commented on the pull
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24016216
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303276#comment-14303276
]
ASF GitHub Bot commented on STORM-329:
--
Github user miguno commented on the pull
[
https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303271#comment-14303271
]
ASF GitHub Bot commented on STORM-329:
--
Github user miguno commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/394#issuecomment-72693402
@caofangkun If you want to reopen this and just add in the nimbus version
information I would support that.
---
If your project is set up for it, you can reply to this
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/394#issuecomment-72693203
Sorry this took me so long to respond to. I am kind of swamped :). I do
like the idea of being able to access the version numbers for nimbus, but also
for the
[
https://issues.apache.org/jira/browse/STORM-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303625#comment-14303625
]
ASF GitHub Bot commented on STORM-350:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303716#comment-14303716
]
ASF GitHub Bot commented on STORM-532:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303617#comment-14303617
]
ASF GitHub Bot commented on STORM-534:
--
Github user revans2 commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/134#issuecomment-72693694
@darionyaphet, if 3.3.0 is out with a different wait strategy it would at
least be worth doing a comparison. Do you have the time to do that?
---
If your project is
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303620#comment-14303620
]
ASF GitHub Bot commented on STORM-534:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303754#comment-14303754
]
ASF GitHub Bot commented on STORM-636:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303875#comment-14303875
]
ASF GitHub Bot commented on STORM-469:
--
Github user rekhajoshm closed the pull request
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/371#issuecomment-72717689
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303868#comment-14303868
]
ASF GitHub Bot commented on STORM-634:
--
GitHub user Parth-Brahmbhatt opened a pull
Github user rekhajoshm commented on the pull request:
https://github.com/apache/storm/pull/385#issuecomment-72723038
created separate pulls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303852#comment-14303852
]
Xavier Stevens commented on STORM-650:
--
I think it would be useful if the kafka spout
[
https://issues.apache.org/jira/browse/STORM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303874#comment-14303874
]
ASF GitHub Bot commented on STORM-469:
--
Github user rekhajoshm commented on the pull
[
https://issues.apache.org/jira/browse/STORM-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303818#comment-14303818
]
ASF GitHub Bot commented on STORM-608:
--
Github user revans2 commented on the pull
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/404#issuecomment-72723482
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/401#issuecomment-72726626
@ptgoetz will send a new PR against 0.9.3 branch. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24037306
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24039560
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcLookupBolt.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/401#issuecomment-72725245
+1. I'd also like to see this back-ported to the 0.9.3 branch, but that
shouldn't block this from getting merged to master.
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/STORM-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303904#comment-14303904
]
ASF GitHub Bot commented on STORM-130:
--
Github user harshach commented on the pull
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24039215
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24039240
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache
Github user miguno commented on a diff in the pull request:
https://github.com/apache/storm/pull/268#discussion_r24039811
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -142,6 +147,15 @@ public void run() {
}
[
https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303988#comment-14303988
]
ASF GitHub Bot commented on STORM-329:
--
Github user miguno commented on a diff in the
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24037432
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java ---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24039341
--- Diff: external/storm-jdbc/pom.xml ---
@@ -0,0 +1,125 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+ Licensed to the Apache Software Foundation
Kai Sasaki created STORM-653:
Summary: missing DRPC HTTP port in SECURITY.md
Key: STORM-653
URL: https://issues.apache.org/jira/browse/STORM-653
Project: Apache Storm
Issue Type: Bug
Affects
[
https://issues.apache.org/jira/browse/STORM-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kai Sasaki reassigned STORM-653:
Assignee: Kai Sasaki
missing DRPC HTTP port in SECURITY.md
-
GitHub user Lewuathe opened a pull request:
https://github.com/apache/storm/pull/413
[STORM-653] missing DRPC HTTP port in SECURITY.md
There is no description about DRPC HTTP port in SECURITY.md.
This port is used by DRPC Client as default 3774
You can merge this pull request
Github user Lewuathe commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-72618892
This ticket was migrated to
[STORM-650](https://issues.apache.org/jira/browse/STORM-650?jql=project%20%3D%20STORM).
---
If your project is set up for it, you can reply
Parth Brahmbhatt created STORM-654:
--
Summary: Create a thrift API to discover nimbus so all the clients
are not forced to contact zookeeper.
Key: STORM-654
URL: https://issues.apache.org/jira/browse/STORM-654
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/394#issuecomment-72770805
@revans2
Yes, not only nimbus server version numbers , but also supervisors and ui
should show up version numbers on UI .
In face , it may be better add
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304426#comment-14304426
]
ASF GitHub Bot commented on STORM-534:
--
Github user caofangkun commented on the pull
Parth Brahmbhatt created STORM-655:
--
Summary: Ad replication count as part of topology summary.
Key: STORM-655
URL: https://issues.apache.org/jira/browse/STORM-655
Project: Apache Storm
GitHub user caofangkun reopened a pull request:
https://github.com/apache/storm/pull/394
STORM-534:Store Nimbus Server Information in zookeeper path
{storm.zookeeper.root}/nimbus
Store Nimbus Server Information in zookeeper path
{storm.zookeeper.root}/nimbus
like
[
https://issues.apache.org/jira/browse/STORM-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302993#comment-14302993
]
ASF GitHub Bot commented on STORM-653:
--
GitHub user Lewuathe opened a pull request:
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302996#comment-14302996
]
ASF GitHub Bot commented on STORM-391:
--
Github user Lewuathe closed the pull request
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302995#comment-14302995
]
ASF GitHub Bot commented on STORM-391:
--
Github user Lewuathe commented on the pull
Github user ogorun commented on the pull request:
https://github.com/apache/storm/pull/406#issuecomment-72620333
@wurstmeister ,
Thank you for pointing me to https://github.com/apache/storm/pull/254 .
It is definitely progress in direction of failure handling functionality
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24040425
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24040287
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/Column.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/370#issuecomment-72736581
Please hold merging this in. I'll send a new PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24041005
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the
93 matches
Mail list logo