[GitHub] storm pull request: STORM-790 Log task is null instead of let wo...

2015-04-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/527#issuecomment-97400633 @ptgoetz I'd like to add this patch to 0.9.x since it verifies that it prevents strange worker crash cause of null task id. Please have a look. --- If your project

[jira] [Commented] (STORM-806) use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519331#comment-14519331 ] ASF GitHub Bot commented on STORM-806: -- GitHub user tedxia opened a pull request:

[jira] [Updated] (STORM-806) use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator

2015-04-29 Thread xiajun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiajun updated STORM-806: - Component/s: storm-kafka Affects Version/s: 0.11.0 Assignee: xiajun Summary:

[jira] [Commented] (STORM-790) Log task id is null instead of let worker died (NPE in consumeBatchToCursor)

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519188#comment-14519188 ] ASF GitHub Bot commented on STORM-790: -- Github user HeartSaVioR commented on the pull

[jira] [Commented] (STORM-763) nimbus reassigned worker A to another machine, but other worker's netty client can't connect to the new worker A

2015-04-29 Thread Adrian Seungjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/STORM-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518959#comment-14518959 ] Adrian Seungjin Lee commented on STORM-763: --- having same problem with Storm 0.9.4

[jira] [Created] (STORM-805) Supervisor crashes with 'org.apache.commons.io.FileExistsException: Destination already exists' error

2015-04-29 Thread Adrian Seungjin Lee (JIRA)
Adrian Seungjin Lee created STORM-805: - Summary: Supervisor crashes with 'org.apache.commons.io.FileExistsException: Destination already exists' error Key: STORM-805 URL:

[jira] [Updated] (STORM-804) HdfsBolt doesn't work after a period of time which caused by network problems

2015-04-29 Thread rujia (JIRA)
[ https://issues.apache.org/jira/browse/STORM-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] rujia updated STORM-804: Description: Two clusters i use in my test case. I submit a topology which write message to hdfs in another

[jira] [Created] (STORM-804) HdfsBolt doesn't work after a period of time which caused by network problems

2015-04-29 Thread rujia (JIRA)
rujia created STORM-804: --- Summary: HdfsBolt doesn't work after a period of time which caused by network problems Key: STORM-804 URL: https://issues.apache.org/jira/browse/STORM-804 Project: Apache Storm

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/534#discussion_r29353105 --- Diff: storm-core/src/clj/backtype/storm/command/rebalance.clj --- @@ -14,19 +14,20 @@ ;; See the License for the specific language governing

[GitHub] storm pull request: STORM-603 Log errors when required kafka param...

2015-04-29 Thread curtisallen
Github user curtisallen commented on the pull request: https://github.com/apache/storm/pull/361#issuecomment-97487810 @revans2 Thanks for looking at this. Before we didn't throw any exceptions when the config was incorrect. I added this

[jira] [Commented] (STORM-603) storm-kafka: Log errors when missing required configuration fields

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519659#comment-14519659 ] ASF GitHub Bot commented on STORM-603: -- Github user curtisallen commented on the pull

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/534#discussion_r29352390 --- Diff: storm-core/src/clj/backtype/storm/command/dev_zookeeper.clj --- @@ -14,13 +14,15 @@ ;; See the License for the specific language governing

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/534#discussion_r29352393 --- Diff: storm-core/src/clj/backtype/storm/command/activate.clj --- @@ -14,11 +14,11 @@ ;; See the License for the specific language governing

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519663#comment-14519663 ] ASF GitHub Bot commented on STORM-436: -- Github user knusbaum commented on a diff in

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519744#comment-14519744 ] ASF GitHub Bot commented on STORM-436: -- Github user knusbaum commented on a diff in

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/534#discussion_r29357225 --- Diff: storm-core/src/clj/backtype/storm/config.clj --- @@ -20,7 +20,8 @@ (:import [backtype.storm Config ConfigValidation$FieldValidator])

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519987#comment-14519987 ] ASF GitHub Bot commented on STORM-436: -- Github user danielcompton commented on the

[GitHub] storm pull request: STORM-603 Log errors when required kafka param...

2015-04-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/361#issuecomment-97512345 @curtisallen I am not really concerned about it being an NPE, or a RuntimeException, my concern is two fold. First If we mis configure something like Config we

[jira] [Commented] (STORM-603) storm-kafka: Log errors when missing required configuration fields

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519779#comment-14519779 ] ASF GitHub Bot commented on STORM-603: -- Github user revans2 commented on the pull

[jira] [Commented] (STORM-404) Worker on one machine crashes due to a failure of another worker on another machine

2015-04-29 Thread Ganesh Chandrasekaran (JIRA)
[ https://issues.apache.org/jira/browse/STORM-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519936#comment-14519936 ] Ganesh Chandrasekaran commented on STORM-404: - We faced a similar problem and

[jira] [Comment Edited] (STORM-404) Worker on one machine crashes due to a failure of another worker on another machine

2015-04-29 Thread Ganesh Chandrasekaran (JIRA)
[ https://issues.apache.org/jira/browse/STORM-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519936#comment-14519936 ] Ganesh Chandrasekaran edited comment on STORM-404 at 4/29/15 6:59 PM:

[jira] [Commented] (STORM-603) storm-kafka: Log errors when missing required configuration fields

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519788#comment-14519788 ] ASF GitHub Bot commented on STORM-603: -- Github user curtisallen commented on the pull

[GitHub] storm pull request: STORM-603 Log errors when required kafka param...

2015-04-29 Thread curtisallen
Github user curtisallen commented on the pull request: https://github.com/apache/storm/pull/361#issuecomment-97513938 @revans2 agreed, the concerns you brought make a lot of sense to me. I should have some time later this week to fail fast ;) --- If your project is set up for it,

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread danielcompton
Github user danielcompton commented on a diff in the pull request: https://github.com/apache/storm/pull/534#discussion_r29369056 --- Diff: storm-core/src/clj/backtype/storm/config.clj --- @@ -20,7 +20,8 @@ (:import [backtype.storm Config ConfigValidation$FieldValidator])

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519957#comment-14519957 ] ASF GitHub Bot commented on STORM-436: -- Github user danielcompton commented on a diff

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread danielcompton
Github user danielcompton commented on a diff in the pull request: https://github.com/apache/storm/pull/534#discussion_r29368825 --- Diff: storm-core/src/clj/backtype/storm/command/dev_zookeeper.clj --- @@ -14,13 +14,15 @@ ;; See the License for the specific language governing

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread danielcompton
Github user danielcompton commented on a diff in the pull request: https://github.com/apache/storm/pull/534#discussion_r29368852 --- Diff: storm-core/src/clj/backtype/storm/command/activate.clj --- @@ -14,11 +14,11 @@ ;; See the License for the specific language governing

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/534#issuecomment-97513417 I'm generally in favor of this. It's something that's bugged me for a while. I did a preliminary review on a portion of the changes. Mostly just some minor spacing

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519784#comment-14519784 ] ASF GitHub Bot commented on STORM-436: -- Github user knusbaum commented on the pull

[GitHub] storm pull request: STORM-603 Log errors when required kafka param...

2015-04-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/361#issuecomment-97525358 @curtisallen Thanks. If you could post a comment here when it is updated I'll take a look and we should hopefully be able to get it in soon. --- If your project is set

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519958#comment-14519958 ] ASF GitHub Bot commented on STORM-436: -- Github user danielcompton commented on a diff

[GitHub] storm pull request: [STORM-436] Clean up ns declarations

2015-04-29 Thread danielcompton
Github user danielcompton commented on the pull request: https://github.com/apache/storm/pull/534#issuecomment-97609813 I think it makes sense to keep committing incrementally as I work to make things easier to review, and squashing it once it's accepted. --- If your project is set

[jira] [Commented] (STORM-790) Log task id is null instead of let worker died (NPE in consumeBatchToCursor)

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520471#comment-14520471 ] ASF GitHub Bot commented on STORM-790: -- Github user ptgoetz commented on the pull

[GitHub] storm pull request: [STORM-796] Add support for error command in...

2015-04-29 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/533#issuecomment-97610607 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-790 Log task is null instead of let wo...

2015-04-29 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/527#issuecomment-97610139 +1 @HeartSaVioR I'll ad this to the list of patches for 0.9.5 --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (STORM-796) The error command isn't supported on ShellSpout

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520477#comment-14520477 ] ASF GitHub Bot commented on STORM-796: -- Github user ptgoetz commented on the pull

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-04-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-97436721 Build is failed from ZkCoordinatorTest. You should also provide Config.STORM_ZOOKEEPER_CONNECTION_TIMEOUT from ZkCoordinatorTest to let build passed. ```

[jira] [Commented] (STORM-806) use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520740#comment-14520740 ] ASF GitHub Bot commented on STORM-806: -- Github user tedxia commented on the pull

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-04-29 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-97638980 @HeartSaVioR sorry about the failure in test, I had added a new patch to fix this. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519647#comment-14519647 ] ASF GitHub Bot commented on STORM-436: -- Github user knusbaum commented on a diff in

[jira] [Commented] (STORM-436) Clean up Clojure namespace declarations

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519648#comment-14519648 ] ASF GitHub Bot commented on STORM-436: -- Github user knusbaum commented on a diff in

[jira] [Commented] (STORM-806) use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520774#comment-14520774 ] ASF GitHub Bot commented on STORM-806: -- Github user tedxia commented on the pull

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-04-29 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-97647385 ``` 48495 [Thread-229] ERROR backtype.storm.task.ShellBolt - Halting process: ShellBolt died. Command: [ruby, tester_bolt.rb], ProcessInfo pid:7283, name:2

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-04-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-97656066 30.1 is random failure of Kafka tests in Travis CI, which seems to be occurred with slow machine. https://issues.apache.org/jira/browse/STORM-798 I can't

[jira] [Commented] (STORM-806) use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator

2015-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520824#comment-14520824 ] ASF GitHub Bot commented on STORM-806: -- Github user HeartSaVioR commented on the pull