[GitHub] storm issue #1667: STORM-2076: Add new atom to prevent sync-processes from d...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1667 Closing this since SupervisorV2 was merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #1605: STORM-2014: Put logic around dropping messages int...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1605#discussion_r79570505 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -144,7 +145,12 @@ public String

[GitHub] storm pull request #1605: STORM-2014: Put logic around dropping messages int...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1605#discussion_r79571602 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -330,11 +328,9 @@ public void ack(Object messageId) {

[GitHub] storm pull request #1605: STORM-2014: Put logic around dropping messages int...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1605#discussion_r79572783 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryService.java --- @@ -29,14 +29,18 @@ */ public

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79576762 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -479,16 +487,17 @@ public OffsetAndMetadata

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79575563 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -277,7 +277,10 @@ private void emit() {

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79574175 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -266,26 +266,32 @@ private void

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79575910 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -451,11 +454,11 @@ public int

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79576337 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -479,16 +482,17 @@ public OffsetAndMetadata

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79669257 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -266,26 +266,32 @@ private void

[GitHub] storm pull request #1667: STORM-2076: Add new atom to prevent sync-processes...

Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1667 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user jfenc91 commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79659246 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -266,26 +266,32 @@ private void

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user jfenc91 commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79662312 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -479,16 +487,17 @@ public OffsetAndMetadata

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user jfenc91 commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79657089 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -451,11 +454,11 @@ public int

[GitHub] storm issue #1679: STORM-2087: storm-kafka-client - tuples not always being ...

Github user jfenc91 commented on the issue: https://github.com/apache/storm/pull/1679 Thats fine @srdo . Thanks again for the reviews. I also created STORM-2106 to keep track of the consequences of this change. --- If your project is set up for it, you can reply to this email and

[GitHub] storm pull request #1697: STORM-2018: Supervisor V2

GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1697 STORM-2018: Supervisor V2 Still need to do some more manual testing but the unit tests passed for me. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #1697: STORM-2018: Supervisor V2

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1697#discussion_r79723534 --- Diff: pom.xml --- @@ -1067,8 +1067,8 @@ org.apache.maven.plugins maven-compiler-plugin

[GitHub] storm issue #1337: STORM-1475: Add storm-elasticsearch2 module

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1337 @dossett ES2 doesn't shade their Guava dependency? I guess ES1 is doing that. I'm not sure we're OK to upgrade Guava version only for this, but there's another PR which gets rid of Guava

Re: [DISCUSS] ElasticSearch 2.x support

Now might be a time to consider making version-sensitive modules ((kafk, ES) maven multi-modules. I've never really liked "storm-Kafka" and "storm-kafka-client" as differentiators of Kafka 0.9..X and 0.10.x. I'd tend toward something like: storm-Kafka/ /0.9.x /0.10.x I would think the

Re: [DISCUSS] ElasticSearch 2.x support

Thanks everyone. Could one or more committers +1 the PR that would support both versions? https://github.com/apache/storm/pull/1337 On Mon, Sep 19, 2016 at 10:52 AM Satish Duggana wrote: > Agree with Bobby, +1 for supporting both versions till EOL and findout how >

Re: [DISCUSS] Provision for dead-letter topic in storm

I like the idea, especially if it can be implemented as generically as possible. Ideally we could "dead letter" both the original tuple and the tuple that itself failed. Intervening transformations could have changed the original tuple. I realize that's adds a lot of complexity to your idea and

Re: [DISCUSS] ElasticSearch 2.x support

+1 on arranging module names on storm-kafka and storm-kafka-client (with versions). Actually there's another trick behind storm-kafka-client. storm-kafka-client 1.0.x supports Kafka 0.9.x and storm-kafka-client 1.1.0 (SNAPSHOT) supports Kafka 0.10.x, which can make a confusion. There was also a

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1691#discussion_r79754113 --- Diff: integration-test/src/test/resources/storm-conf/storm.yaml --- @@ -0,0 +1,17 @@ + +storm.zookeeper.servers: +- "node1" +

[GitHub] storm pull request #1690: STORM-2100 Fix Trident SQL join tests to not rely ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1690: STORM-2100 Fix Trident SQL join tests to not rely on orde...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1690 Thanks @HeartSaVioR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1691#discussion_r79754021 --- Diff: integration-test/src/main/java/org/apache/storm/st/topology/window/TumblingTimeCorrectness.java --- @@ -0,0 +1,164 @@ +/* + * Licensed to

[GitHub] storm pull request #1695: STORM-2101: fixes npe in compute-executors in nimb...

GitHub user abellina opened a pull request: https://github.com/apache/storm/pull/1695 STORM-2101: fixes npe in compute-executors in nimbus You can merge this pull request into a Git repository by running: $ git pull https://github.com/abellina/storm

[GitHub] storm pull request #1694: STORM-2101: fixes npe in compute-executors in nimb...

GitHub user abellina opened a pull request: https://github.com/apache/storm/pull/1694 STORM-2101: fixes npe in compute-executors in nimbus We observed compute-executors can throw NPE while shutting down a topology sporadically. joinMaps (join-maps) will NPE if one of the

[GitHub] storm pull request #1696: STORM-2104: More graceful handling of acked/failed...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1696 STORM-2104: More graceful handling of acked/failed tuples after parti… …tion reassignment in new Kafka spout See https://issues.apache.org/jira/browse/STORM-2104 In order to test

[GitHub] storm issue #1679: STORM-2087: storm-kafka-client - tuples not always being ...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1679 @jfenc91 I borrowed a few classes from this PR for another change to the spout here https://github.com/apache/storm/pull/1696. I hope you don't mind :) --- If your project is set up for it, you can