[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135057#comment-15135057
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52076438
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135065#comment-15135065
]
ASF GitHub Bot commented on STORM-1336:
---
Github user kishorvpatil commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135198#comment-15135198
]
ASF GitHub Bot commented on STORM-1336:
---
Github user d2r commented on a diff in the pull request:
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52083925
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135210#comment-15135210
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1084#discussion_r52034936
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -577,11 +577,11 @@
(defserverfn mk-worker [conf shared-mq-context
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1054#issuecomment-180410973
@redsanket thanks for the review. I have addressed all your concerns
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/1044#issuecomment-180420947
I up-merged this PR. Does anyone have feedback on this change? Are API
breaking changes off the table for 2.0? If so, i can close this PR and come
back to it at a
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/1075#issuecomment-180437922
Requesting this to be merged into 1.x-branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1084#issuecomment-180411794
@satishd Is it happening with all topologies ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134454#comment-15134454
]
ASF GitHub Bot commented on STORM-1524:
---
Github user kishorvpatil commented on the pull request:
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52044357
--- Diff: conf/cgconfig.conf.example ---
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1075#issuecomment-180412081
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/STORM-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134382#comment-15134382
]
ASF GitHub Bot commented on STORM-1516:
---
Github user abhishekagarwal87 commented on a diff in the
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134532#comment-15134532
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52046993
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52053109
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/Constants.java ---
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134627#comment-15134627
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52061120
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystem.java ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134516#comment-15134516
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52045815
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -344,6 +348,12 @@
:sync-retry (atom 0)
:download-lock (Object.)
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52046682
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134603#comment-15134603
]
ASF GitHub Bot commented on STORM-1516:
---
Github user satishd commented on the pull request:
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52058790
--- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/Device.java
---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1075
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134766#comment-15134766
]
ASF GitHub Bot commented on STORM-1524:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134506#comment-15134506
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134623#comment-15134623
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52052852
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -301,7 +303,9 @@
(try
(rmpath
[
https://issues.apache.org/jira/browse/STORM-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134640#comment-15134640
]
Roshan Naik commented on STORM-1526:
[~dossett] i updated the PR title.
> Improve Storm core
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134637#comment-15134637
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/1080#discussion_r52054870
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -58,7 +58,7 @@
(.prepare grouping context (GlobalStreamId. component-id
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134660#comment-15134660
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52054802
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/Hierarchy.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134661#comment-15134661
]
ASF GitHub Bot commented on STORM-1526:
---
Github user roshannaik commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134497#comment-15134497
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52045220
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -344,6 +348,12 @@
:sync-retry (atom 0)
:download-lock (Object.)
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134527#comment-15134527
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134592#comment-15134592
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52050562
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134638#comment-15134638
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52053581
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134709#comment-15134709
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134735#comment-15134735
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134586#comment-15134586
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1084#issuecomment-180478178
@arunmahadevan Right, this issue happens with all topologies. There is
nothing specific about the mentioned topology in JIRA.
---
If your project is set up for it, you
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52052704
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52057370
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommon.java ---
@@ -0,0 +1,226 @@
+/**
+ * Licensed to the Apache Software
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52050012
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134624#comment-15134624
]
ASF GitHub Bot commented on STORM-1336:
---
Github user kishorvpatil commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134668#comment-15134668
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134699#comment-15134699
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52056829
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1082#issuecomment-180250363
Probability of random test failures becomes very high, though I don't know
why.
Anyway, I ran test which is same to travis CI but without native profile
(it
[
https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133839#comment-15133839
]
ASF GitHub Bot commented on STORM-1492:
---
Github user HeartSaVioR commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134357#comment-15134357
]
ASF GitHub Bot commented on STORM-1516:
---
Github user arunmahadevan commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134381#comment-15134381
]
ASF GitHub Bot commented on STORM-1464:
---
Github user dossett commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134860#comment-15134860
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134862#comment-15134862
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52065249
--- Diff: storm-core/test/clj/org/apache/storm/supervisor_test.clj ---
@@ -335,8 +334,8 @@
mock-storm-id
[
https://issues.apache.org/jira/browse/STORM-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134936#comment-15134936
]
ASF GitHub Bot commented on STORM-1528:
---
GitHub user kishorvpatil opened a pull request:
[
https://issues.apache.org/jira/browse/STORM-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134940#comment-15134940
]
ASF GitHub Bot commented on STORM-1528:
---
Github user d2r commented on the pull request:
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52070908
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1062,9 +1072,15 @@
(add-to-classpath [stormjar])
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52072010
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -344,6 +348,12 @@
:sync-retry (atom 0)
:download-lock (Object.)
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52074497
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystemType.java ---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52075177
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-180571721
The proposed changes are launching commands using `exec.command` which may
not work in multi-tenant setup ( for killing workers etc.). It will not work in
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135180#comment-15135180
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52082924
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52084693
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupOperation.java ---
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52075801
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-180583768
Secondly, I don't necessarily like the idea of `ResourceIsolationInterface`
taking up responsibility for starting and stopping workers.. This would be
moving a lot
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135101#comment-15135101
]
ASF GitHub Bot commented on STORM-1336:
---
Github user kishorvpatil commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135124#comment-15135124
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135122#comment-15135122
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52079318
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1367,12 +1367,67 @@ public static int toPositive(int number) {
return
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52079277
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1367,12 +1367,67 @@ public static int toPositive(int number) {
return
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52079760
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -301,7 +303,9 @@
(try
(rmpath
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135130#comment-15135130
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52082237
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/Constants.java ---
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135196#comment-15135196
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52083814
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135195#comment-15135195
]
ASF GitHub Bot commented on STORM-1336:
---
Github user d2r commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135193#comment-15135193
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52083786
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135049#comment-15135049
]
ASF GitHub Bot commented on STORM-1336:
---
Github user d2r commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135171#comment-15135171
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52083808
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134782#comment-15134782
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134868#comment-15134868
]
ASF GitHub Bot commented on STORM-1336:
---
Github user knusbaum commented on the pull request:
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-180535239
Done with first pass. This code could do with a lot more documentation.
I don't want to merge a massive chunk of undocumented code.
---
If your project is set up
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52067649
--- Diff: conf/defaults.yaml ---
@@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10
pacemaker.childopts: "-Xmx1024m"
pacemaker.auth.method: "NONE"
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134916#comment-15134916
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52068474
--- Diff: conf/cgconfig.conf.example ---
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Kishor Patil created STORM-1528:
---
Summary: Fix CsvPreparableReporter log directory
Key: STORM-1528
URL: https://issues.apache.org/jira/browse/STORM-1528
Project: Apache Storm
Issue Type: Bug
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52071474
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1088,8 +1104,26 @@
(str "file:///"
[
https://issues.apache.org/jira/browse/STORM-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134975#comment-15134975
]
Aaron Dossett commented on STORM-602:
-
If nobody objects, I will close this ticket as "not a problem"
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134999#comment-15134999
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135001#comment-15135001
]
ASF GitHub Bot commented on STORM-1336:
---
Github user jerrypeng commented on a diff in the pull
1 - 100 of 228 matches
Mail list logo
