[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209799#comment-15209799 ] ASF GitHub Bot commented on STORM-1632: --- Github user arunmahadevan commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200677018 @harshach I had removed the sleep in the latest run to match what @roshannaik was evaluating. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209798#comment-15209798 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200674706 @arunmahadevan I saw the earlier comment. Is that topology ran with 10ms sleep in the spout? @roshannaik do you also have some numbers like Arun posted , events

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200672407 @harshach > @arunmahadevan @HeartSaVioR Looking at the perf analysis from @roshannaik It looks to be there is enough evidence to consider this as serious

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209789#comment-15209789 ] ASF GitHub Bot commented on STORM-1632: --- Github user arunmahadevan commented on the pull request:

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209778#comment-15209778 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200670850 @arunmahadevan @ptgoetz we are not worried about 0.4 to 0.5% affect on throughput. For most cases no one going to notice that. Lets wait for @roshannaik topology and

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209771#comment-15209771 ] ASF GitHub Bot commented on STORM-1632: --- Github user arunmahadevan commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200669173 @roshannaik did you try passing the map values are arguments and take the measurements? Based on your earlier results it appeared that PersistentMap lookup was

[jira] [Commented] (STORM-1654) HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209767#comment-15209767 ] ASF GitHub Bot commented on STORM-1654: --- Github user harshach commented on the pull request:

[jira] [Commented] (STORM-1654) HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209766#comment-15209766 ] ASF GitHub Bot commented on STORM-1654: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1654 HBaseBolt creates tick tuples with ...

2016-03-23 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1251#issuecomment-200668555 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1654 (1.x) HBaseBolt creates tick tuples...

2016-03-23 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1252#issuecomment-200668486 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209764#comment-15209764 ] ASF GitHub Bot commented on STORM-1268: --- Github user unsleepy22 commented on the pull request:

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-23 Thread unsleepy22
Github user unsleepy22 commented on the pull request: https://github.com/apache/storm/pull/1218#issuecomment-200667388 @abhishekagarwal87 done~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209752#comment-15209752 ] ASF GitHub Bot commented on STORM-1632: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200662946 OK I'm assuming this is valid performance hit whether it is small or huge. For choosing 6 or half a dozen, I think whether turning on or off by default

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209730#comment-15209730 ] ASF GitHub Bot commented on STORM-1268: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-23 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1218#issuecomment-200660046 @unsleepy22 can you squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Assigned] (STORM-1537) Upgrade to Kryo 3

2016-03-23 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal reassigned STORM-1537: --- Assignee: Abhishek Agarwal (was: P. Taylor Goetz) > Upgrade to Kryo 3 >

[GitHub] storm pull request: STORM-676 Trident implementation for sliding a...

2016-03-23 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1072#discussion_r57272190 --- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java --- @@ -0,0 +1,275 @@ +/** + * Licensed

[jira] [Commented] (STORM-676) Storm Trident support for sliding/tumbling windows

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209695#comment-15209695 ] ASF GitHub Bot commented on STORM-676: -- Github user satishd commented on a diff in the pull request:

[jira] [Updated] (STORM-1649) Optimize Kryo instaces creation in HBaseWindowsStore

2016-03-23 Thread Satish Duggana (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated STORM-1649: -- Fix Version/s: 1.0.0 > Optimize Kryo instaces creation in HBaseWindowsStore >

[jira] [Updated] (STORM-1649) Optimize Kryo instaces creation in HBaseWindowsStore

2016-03-23 Thread Satish Duggana (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated STORM-1649: -- Summary: Optimize Kryo instaces creation in HBaseWindowsStore (was: Use DefaultStateSerializer

[jira] [Commented] (STORM-1654) HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209658#comment-15209658 ] ASF GitHub Bot commented on STORM-1654: --- GitHub user HeartSaVioR opened a pull request:

[GitHub] storm pull request: STORM-1654 (1.x) HBaseBolt creates tick tuples...

2016-03-23 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1252 STORM-1654 (1.x) HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs Same patch to #1251, based on 1.x-branch. You can merge this pull request into a Git

[jira] [Commented] (STORM-1654) HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209653#comment-15209653 ] ASF GitHub Bot commented on STORM-1654: --- GitHub user HeartSaVioR opened a pull request:

[GitHub] storm pull request: STORM-1654 HBaseBolt creates tick tuples with ...

2016-03-23 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1251 STORM-1654 HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs Please also refer #893 to see why this change is necessary. Set 'default' flush interval

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209580#comment-15209580 ] ASF GitHub Bot commented on STORM-1268: --- Github user unsleepy22 commented on the pull request:

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209576#comment-15209576 ] ASF GitHub Bot commented on STORM-1268: --- Github user unsleepy22 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-23 Thread unsleepy22
Github user unsleepy22 commented on the pull request: https://github.com/apache/storm/pull/1218#issuecomment-200613922 thanks, addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-23 Thread unsleepy22
Github user unsleepy22 commented on a diff in the pull request: https://github.com/apache/storm/pull/1218#discussion_r57266090 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/metrics/BuiltinMetricsUtil.java --- @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-1650] improve performance by XORShiftRa...

2016-03-23 Thread roshannaik
Github user roshannaik commented on the pull request: https://github.com/apache/storm/pull/1250#issuecomment-200609948 My gut feeling based on profiling storm recently is that there are much bigger bottlenecks elsewhere that will eclipse any potential improvement this can deliver. I

[jira] [Commented] (STORM-1650) improve performance by XORShiftRandom

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209564#comment-15209564 ] ASF GitHub Bot commented on STORM-1650: --- Github user roshannaik commented on the pull request:

[jira] [Commented] (STORM-1650) improve performance by XORShiftRandom

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209495#comment-15209495 ] ASF GitHub Bot commented on STORM-1650: --- Github user hustfxj closed the pull request at:

[GitHub] storm pull request: [STORM-1650] improve performance by XORShiftRa...

2016-03-23 Thread hustfxj
Github user hustfxj closed the pull request at: https://github.com/apache/storm/pull/1250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209475#comment-15209475 ] ASF GitHub Bot commented on STORM-1632: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200591500 We're debating six versus one half dozen. Do we disable it by default and explicitly tell users they have to turn it on for the UI functionality to work? Or do we

[GitHub] storm pull request: STORM-1625: Move storm-sql dependencies out of...

2016-03-23 Thread haohui
Github user haohui commented on the pull request: https://github.com/apache/storm/pull/1239#issuecomment-200583518 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1625) Move storm-sql dependencies out of lib folder

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209424#comment-15209424 ] ASF GitHub Bot commented on STORM-1625: --- Github user haohui commented on the pull request:

[jira] [Commented] (STORM-1580) Secure hdfs spout failed

2016-03-23 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209389#comment-15209389 ] Roshan Naik commented on STORM-1580: [~ght] fyi.. I am beginning to take a look at this. > Secure

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209337#comment-15209337 ] ASF GitHub Bot commented on STORM-1632: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200571684 @roshannaik I'm sorry I feel I picked the wrong word `micro optimization` to confuse you what I mean. `local optimization` seems clearer. Btw, I guess

[jira] [Commented] (STORM-1030) Hive Connector Fixes

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209278#comment-15209278 ] ASF GitHub Bot commented on STORM-1030: --- Github user Parth-Brahmbhatt commented on the pull request:

[GitHub] storm pull request: STORM-1030. Hive Connector Fixes.

2016-03-23 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/871#issuecomment-200564783 This PR has been open for a long time, i am still +1 and will merge this this weekend if no one objects. --- If your project is set up for it, you can reply to

[jira] [Resolved] (STORM-1653) BYLAWS has disappeared

2016-03-23 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1653. Resolution: Invalid It is still there.

[jira] [Assigned] (STORM-1653) BYLAWS has disappeared

2016-03-23 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans reassigned STORM-1653: -- Assignee: Robert Joseph Evans > BYLAWS has disappeared >

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209253#comment-15209253 ] ASF GitHub Bot commented on STORM-1632: --- Github user ptgoetz commented on the pull request:

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209223#comment-15209223 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200553473 @arunmahadevan @HeartSaVioR Looking at the perf analysis from @roshannaik It looks to be there is enough evidence to consider this as serious issue in performance.

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209165#comment-15209165 ] ASF GitHub Bot commented on STORM-1268: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209171#comment-15209171 ] ASF GitHub Bot commented on STORM-1632: --- Github user roshannaik commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-23 Thread roshannaik
Github user roshannaik commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-200543287 @arunmahadevan :-) ... i am not taking the throughput measurements while profiler is attached. It will take some time for me to continue to iterate over and

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-23 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1218#issuecomment-200542649 It looks good to me I am +1, but I would like to see the one minor naming comment addressed. > nodePort2Socket can be renamed to nodePortToSocket. ---

[jira] [Commented] (STORM-1625) Move storm-sql dependencies out of lib folder

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209142#comment-15209142 ] ASF GitHub Bot commented on STORM-1625: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1625: Move storm-sql dependencies out of...

2016-03-23 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1239#issuecomment-200538695 I am fine with that too. +1 we can make this simpler in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (STORM-676) Storm Trident support for sliding/tumbling windows

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209117#comment-15209117 ] ASF GitHub Bot commented on STORM-676: -- Github user ptgoetz commented on a diff in the pull request:

[jira] [Commented] (STORM-1056) allow supervisor log filename to be configurable via ENV variable

2016-03-23 Thread Erik Weathers (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209115#comment-15209115 ] Erik Weathers commented on STORM-1056: -- [~kabhwan]: ahh, seems that [the release notes for storm

[GitHub] storm pull request: STORM-676 Trident implementation for sliding a...

2016-03-23 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1072#discussion_r57232035 --- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java --- @@ -0,0 +1,275 @@ +/** + * Licensed

[jira] [Commented] (STORM-1617) storm.apache.org has no release specific documentation

2016-03-23 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209111#comment-15209111 ] Robert Joseph Evans commented on STORM-1617: I just filed INFRA-11528 > storm.apache.org has

[jira] [Commented] (STORM-1625) Move storm-sql dependencies out of lib folder

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209095#comment-15209095 ] ASF GitHub Bot commented on STORM-1625: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1625: Move storm-sql dependencies out of...

2016-03-23 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1239#issuecomment-200529436 I'm +1 for merging this. I think moving the jars out of the lib folder is the most important part for the 1.0 release. How to package the SQL dependencies for the best

[jira] [Resolved] (STORM-1622) Topology jars referring to shaded classes of older version of storm jar cannot be run in Storm 1.0.0

2016-03-23 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1622. Resolution: Fixed Fix Version/s: 1.0.0 Thanks [~abhishek.agarwal]. Merged to

[jira] [Commented] (STORM-1622) Topology jars referring to shaded classes of older version of storm jar cannot be run in Storm 1.0.0

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209082#comment-15209082 ] ASF GitHub Bot commented on STORM-1622: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1622: Rename classes with older third pa...

2016-03-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209079#comment-15209079 ] ASF GitHub Bot commented on STORM-1279: --- Github user jerrypeng commented on a diff in the pull

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-23 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1184#discussion_r57228512 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java --- @@ -0,0 +1,632 @@ +/** + * Licensed to the Apache

[jira] [Resolved] (STORM-1537) Upgrade to Kryo 3

2016-03-23 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1537. Resolution: Fixed Fix Version/s: 1.0.0 Merged to 1.x-branch. > Upgrade to Kryo 3 >

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209066#comment-15209066 ] ASF GitHub Bot commented on STORM-1537: --- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209062#comment-15209062 ] ASF GitHub Bot commented on STORM-1537: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1537: Upgrade to kryo 3

2016-03-23 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1223#issuecomment-200521136 +1 Tested on a real cluster and compared to 1.x-branch before and after this patch. Throughput increased and latency decreased. --- If your project is set up

[jira] [Created] (STORM-1653) BYLAWS has disappeared

2016-03-23 Thread Kyle Nusbaum (JIRA)
Kyle Nusbaum created STORM-1653: --- Summary: BYLAWS has disappeared Key: STORM-1653 URL: https://issues.apache.org/jira/browse/STORM-1653 Project: Apache Storm Issue Type: Bug

[GitHub] storm pull request: Upgraded HBase version to 1.1.0

2016-03-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1611) port org.apache.storm.pacemaker.pacemaker to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208962#comment-15208962 ] ASF GitHub Bot commented on STORM-1611: --- Github user knusbaum commented on the pull request:

[GitHub] storm pull request: [STORM-1611] port org.apache.storm.pacemaker.p...

2016-03-23 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1195#issuecomment-200497814 By using gauges we're re-implementing stuff that coda hale does, namely windowed stats. Just take a look at DRPCServer.java, like I mentioned. You can use

[jira] [Commented] (STORM-1650) improve performance by XORShiftRandom

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208942#comment-15208942 ] ASF GitHub Bot commented on STORM-1650: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1650] improve performance by XORShiftRa...

2016-03-23 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1250#issuecomment-200490900 @hustfxj If you want to close this pull request I will leave it up to you. In some situations the uniqueness of a number is important, and having Random emit

[GitHub] storm pull request: Upgraded HBase version to 1.1.0

2016-03-23 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1197#issuecomment-200489523 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-587) trident transactional state in zk should be namespaced with topology id

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208899#comment-15208899 ] ASF GitHub Bot commented on STORM-587: -- Github user harshach closed the pull request at:

[GitHub] storm pull request: STORM-587. trident transactional state in zk s...

2016-03-23 Thread harshach
Github user harshach closed the pull request at: https://github.com/apache/storm/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1650) improve performance by XORShiftRandom

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208782#comment-15208782 ] ASF GitHub Bot commented on STORM-1650: --- Github user hustfxj commented on the pull request:

[GitHub] storm pull request: [STORM-1650] improve performance by XORShiftRa...

2016-03-23 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1250#issuecomment-200444929 @revans2 It is used in a non-thread safe way, especialy spout/bolt thread. So we think it may not make sense. So I will close the PR? --- If your project is set up

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208733#comment-15208733 ] ASF GitHub Bot commented on STORM-1279: --- Github user hustfxj commented on a diff in the pull

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-23 Thread hustfxj
Github user hustfxj commented on a diff in the pull request: https://github.com/apache/storm/pull/1184#discussion_r57193403 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java --- @@ -0,0 +1,632 @@ +/** + * Licensed to the Apache

[jira] [Updated] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-23 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz updated STORM-1469: --- Removing from 1.0 release epic since this has been fixed in the 1.x-branch. > Unable to deploy

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208645#comment-15208645 ] ASF GitHub Bot commented on STORM-1279: --- Github user hustfxj commented on a diff in the pull

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-23 Thread hustfxj
Github user hustfxj commented on a diff in the pull request: https://github.com/apache/storm/pull/1184#discussion_r57185550 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncProcessEvent.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208637#comment-15208637 ] ASF GitHub Bot commented on STORM-1268: --- Github user unsleepy22 commented on the pull request:

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-23 Thread unsleepy22
Github user unsleepy22 commented on the pull request: https://github.com/apache/storm/pull/1218#issuecomment-200407083 ping @revans2 , could you take time to have a look? this PR blocks task.clj. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1650) improve performance by XORShiftRandom

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208626#comment-15208626 ] ASF GitHub Bot commented on STORM-1650: --- Github user hustfxj commented on the pull request:

[GitHub] storm pull request: [STORM-1650] improve performance by XORShiftRa...

2016-03-23 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1250#issuecomment-200402469 @revans2 ThreadLocalRandom is 20% faster than XORShiftRandom. But ThreadLocalRandom is static.Yes, we can't use XORShiftRandom in executor.clj due to thread safety

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208619#comment-15208619 ] ASF GitHub Bot commented on STORM-1279: --- Github user jerrypeng commented on a diff in the pull

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-23 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1184#discussion_r57182643 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncProcessEvent.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the Apache

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208613#comment-15208613 ] ASF GitHub Bot commented on STORM-1279: --- Github user jerrypeng commented on a diff in the pull

[jira] [Commented] (STORM-1650) improve performance by XORShiftRandom

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208545#comment-15208545 ] ASF GitHub Bot commented on STORM-1650: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1650] improve performance by XORShiftRa...

2016-03-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1250#discussion_r57174134 --- Diff: storm-core/src/clj/org/apache/storm/config.clj --- @@ -53,7 +54,7 @@ [freq] (let [freq (int freq) start (int 0) -

[jira] [Commented] (STORM-1650) improve performance by XORShiftRandom

2016-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208538#comment-15208538 ] ASF GitHub Bot commented on STORM-1650: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1650] improve performance by XORShiftRa...

2016-03-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1250#discussion_r57173711 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -75,7 +76,7 @@ "Returns a function that returns a vector of which task indices

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-23 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1184#discussion_r57171985 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java --- @@ -0,0 +1,632 @@ +/** + * Licensed to the Apache

  1   2   >