Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2927#discussion_r242663110
--- Diff:
storm-core/test/jvm/org/apache/storm/integration/TopologyIntegrationTest.java
---
@@ -0,0 +1,927 @@
+/*
+ * Copyright 2018 The Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2927#discussion_r242661816
--- Diff:
storm-core/test/jvm/org/apache/storm/integration/TopologyIntegrationTest.java
---
@@ -0,0 +1,927 @@
+/*
+ * Copyright 2018 The Apache
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2908
@srdo @kishorvpatil @jnioche
Sorry this has taken so long. I just rebased/squashed and @srdo I
addressed your nit. Please take another look.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2915
@liu-zhaokun Currently the only way that the user name is transmitted from
the client to the server is through authentication because authentication is
secure and we didn't want to accidentally
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2907#discussion_r241782960
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -170,15 +170,25 @@ public
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2907
+1
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2918#discussion_r239517824
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/RasBlacklistStrategy.java
---
@@ -79,25 +81,46
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2918#discussion_r239519351
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/RasBlacklistStrategy.java
---
@@ -79,25 +81,46
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2907#discussion_r234329136
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -170,15 +170,25 @@ public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2908#discussion_r234303902
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -1197,8 +1238,9 @@ public IBolt makeAckerBoltImpl() {
* When running
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2908
@jnioche you are 100% correct. I'll deprecate sleep too.
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2910
STORM-3288: Fix issue with reources in jar files
Turns out that python has a common directory called `/pkg_resources/` which
gets mangled badly without this fix.
You can merge this pull request
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2908
STORM-3276: Updated Flux to deal with storm local correctly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3276
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2893#discussion_r227418284
--- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
@@ -593,14 +593,17 @@ int recursive_delete(const char *path, int
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2894
STORM-3273: Remove storm.local.hostname from topology conf.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3273
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2881
I have thought about it more and I am fine with NUMA support being at the
supervisor level. I think in the future we will need to move it so that Nimbus
is aware of NUMA simply to be able to combat
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2882
@kishorvpatil
I didn't intend the data to be true JSON. There are some things Thrift
supports that JSON does not, like non-string map keys. Storm uses those in our
thrift data structures
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2892
Added in better docs for local mode testing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm LOCAL_MODE_DOCS
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2891
STORM-3269: Update version of httpclient, and fix version dep issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226707991
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -820,8 +824,15 @@ private long calculateMemoryLimit
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226692517
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1041,6 +1041,19 @@
@isPositiveNumber
@NotNull
public static
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226707791
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -639,6 +639,10 @@ protected String javaCmd(String cmd
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226693412
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -348,14 +350,27 @@ public void doExecutorHeartbeats
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2886
Thanks @d2r I spell checked the whole file and I think I got all of the
typos.
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2886
Improve the security docs on how to configure something like SSO for UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2882
STORM-3260: Add in support to print some state
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3260
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224558607
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224550336
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224547803
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2870
Revert "[STORM-3233] Updated zookeeper client to version 3.4.13 whichâ¦
⦠fixes various issues including ZOOKEEPER-2184 that prevents ZooKeeper
Java clients working in dynamic IP (cont
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2869
Revert "[STORM-3233] Updated zookeeper client to version 3.4.13 whichâ¦
⦠fixes various issues including ZOOKEEPER-2184 that prevents ZooKeeper
Java clients working in dynamic IP (cont
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2868
Revert "[STORM-3233] Updated zookeeper client to version 3.4.13 whichâ¦
⦠fixes various issues including ZOOKEEPER-2184 that prevents ZooKeeper
Java clients working in dynamic IP (cont
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2867
STORM-3249: Make sure times shut down and so does shut down thread
Turns out there are two things blocking nimbus from shutting down.
1) some timer (that turns out to be from the local fs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2861#discussion_r223047510
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -66,10 +64,9 @@ private static Server mkHttpServer
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2863
STORM-3245: Don't blow up if empty log dirs exist
The empty directories are also deleted after they age out.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2858
Sorry @srdo is right we need to make sure that we have the dependencies
setup properly.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2860
The code change looks fine, but could you file a follow on JIRA to clean up
the pom.xml now that clojure is only needed for tests, or you could do it here,
I am fine either way.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2855
And if we can get rid of the code returning a string for success or
failure, please lets do that, especially since it is thrown away.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2855
I am fine with making breaking changes if it is going to make everything
cleaner. This was originally based off of how Hadoop does this in hopes of
being able to reuse scripts, but that didn't
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2852
Oh wait sorry. I forgot that we added docs for all of the metrics. Could
you update docs/ClusterMetrics.md to include this too?
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2852#discussion_r221331973
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2162,7 +2165,12 @@ private boolean isReadyForMKAssignments() throws
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2845
@govind-menon I updated the docs as I checked them in.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2844
@Ethanlm I used the same config that I added as a part of the unit tests
for this. It has garbage data in it, but made it so I didn't have to fully
setup multiple versions on my test cluster.
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2845
STORM-3234: Replace old metrics with better documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3234
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2844
Some example screen shots. On the last one I had to remove the git repo and
user name because of work requirements :(
https://user-images.githubusercontent.com/3441321/45886457-d3199c00-bd7e
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2844
STORM-3232: Display on the UI all versions of storm that are supported
Also display the full version info from STORM-621
You can merge this pull request into a Git repository by running
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2843#discussion_r218922619
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java
---
@@ -95,9 +95,12 @@ private static
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2840
I worked with @zd-project fairly closely to come up with the goals for the
metrics. I just think we can do better on some of the metrics, but it is not
something we have to do right now. I am +1
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2843
STORM-3230: Add in sync if key not found
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3230
Alternatively you
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2842
@danny0405 I changed the log to info. That is a great point, because the
only time you would see that under normally would be if someone had configured
the cluster to use digest auth, which we
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2842
STORM-3229: Add in better error reporting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3229
Alternatively
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2841
The build failures look like issues with downloading the JDK/slowness in
travis.
https://travis-ci.org/revans2/incubator-storm/builds/430134233
is my version that passed.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2839
Actually these are all comments so I'll just take care of it on checkin.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2839#discussion_r218564458
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/TimePortAndAssignment.java
---
@@ -48,4 +48,29 @@ public LocalAssignment getAssignment
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2839#discussion_r218564297
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/PortAndAssignmentImpl.java
---
@@ -45,14 +48,17 @@ public String getOwner
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2839#discussion_r218564194
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/PortAndAssignmentImpl.java
---
@@ -26,13 +26,16 @@ public PortAndAssignmentImpl(int port
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2839#discussion_r218564410
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/TimePortAndAssignment.java
---
@@ -48,4 +48,29 @@ public LocalAssignment getAssignment
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2839
There are some new checkstyle violations that we missed before.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2841
The build is failing do not merge yet...
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2840#discussion_r218485913
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4767,4 +4797,205 @@ public IScheduler getForcedScheduler
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2840#discussion_r218484299
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2922,19 +2948,20 @@ public void launchServer() throws Exception
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2841
STORM-3105: upgrade version of hive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3105
Alternatively you can
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2836
@srdo I think I addressed all of your review comments.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2831
Sorry to pull my +1 back. On both Firefox and Chrome it looks off to me.
Could you take a look at this again?
 throws IOException
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r218106022
--- Diff: storm-server/src/main/java/org/apache/storm/LocalDRPC.java ---
@@ -38,9 +39,9 @@
private final DRPC drpc;
private final String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218088968
--- Diff: storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2800
Please take a look at #2836 as an alternative. It is a much bigger patch,
but I think the refactoring it does will make things much easier longer term.
Having done the other patch I think this one
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2836
STORM-3162: Cleanup heartbeats cache and make it thread safe
This is an alternative to #2800
@zd-project I had such trouble really understanding what was happening with
the heartbeat
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2829
Sorry my bad, there is an overflow.
https://github.com/apache/storm/blob/4605ae0a34858309171e726e1924b9a37695c977/storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java#L94
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2719
The current build is failing because of an Enforcer rule.
```
...
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
storm-hive ---
[WARNING] Rule 1
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2829
The reason we want to send a single tuple is because of how we do flow
control in the spouts. If you want to send more it can be more efficient, but
you risk going over the max.spout.pending amount
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2834
STORM-3226: Update error message to be more clear
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3226
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2833
STORM-3225: Use MediaType for check
Full disclosure I am really just pushing back some changes that
@govind-menon did, but was missed when the majority of UI changes going to java
were put in open
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2830
STORM-3223: Fix NPE on blacklisted rack
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3223
Alternatively you
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2828
https://user-images.githubusercontent.com/3441321/45451964-41d16800-b6a2-11e8-93b0-ed2b2239202c.png;>
This might need to be a separate JIRA, but there are a lot of missing
metr
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217175758
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1096,41 +1104,230 @@ public static String getWindowHint(String window
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176198
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176027
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176251
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217175925
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176354
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176096
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176165
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176297
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176395
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String host
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217175834
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1096,41 +1104,230 @@ public static String getWindowHint(String window
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2827#discussion_r217094208
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -582,11 +582,9 @@ public static Response makeStandardResponse
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2826
STORM-3219: Update javascript to report errors consistently
Some of this was motivated for cases where nimbus was down the UI would not
report any errors. The goal here is to make sure
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2824
STORM-3218: Return the correct error from AuthorizedUserFilter
The changes to ReqContext are not needed. I started to make a change
there, and cleaned it up before realizing that it was not going
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2821
STORM-3216: Add in RasBlacklistStrategy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3216
Alternatively you
1 - 100 of 3470 matches
Mail list logo
