Re: Subversion 1.9.9 up for testing/signing

2018-07-17 Thread Branko Čibej
On 17.07.2018 14:03, Johan Corveleyn wrote: > On Tue, Jul 17, 2018 at 1:33 PM, Branko Čibej wrote: >> On 16.07.2018 20:37, Johan Corveleyn wrote: >>> On Sat, Jul 14, 2018 at 10:54 PM, Julian Foad wrote: >>>> The 1.9.9 release artifacts are now available for testing

Re: Subversion 1.9.9 up for testing/signing

2018-07-17 Thread Branko Čibej
On 16.07.2018 20:37, Johan Corveleyn wrote: > On Sat, Jul 14, 2018 at 10:54 PM, Julian Foad wrote: >> The 1.9.9 release artifacts are now available for testing/signing. >> >> Please get the tarballs from >> https://dist.apache.org/repos/dist/dev/subversion >> and add your signatures there. >> >>

Re: Subversion 1.9.9 up for testing/signing

2018-07-17 Thread Branko Čibej
Summary: +1 to release (Unix) Verified: - Tarball contents and signatures - check ((fsfs, bdb) × (local, svnserve, dav)) - check-all-javahl - check-swig-py - check-swig-rb - check-swig-pl New issues: - In the svnserve+bdb test run, the merge_automatic_tests.py:merge_once_3

Re: [RFC] Move CHANGES and COMMITTERS out of trunk/branches

2018-07-17 Thread Branko Čibej
On 17.07.2018 11:17, Stefan wrote: > That said, if the majority of the team is fine with a change, so will > I be in the end and won't argue against it. Correction: not "if the majority of the team etc." but "if the consensus of the team is etc." We don't do majority votes here. :) -- Brane

Re: [RFC] Move CHANGES and COMMITTERS out of trunk/branches

2018-07-17 Thread Branko Čibej
On 17.07.2018 10:05, Johan Corveleyn wrote: > On Tue, Jul 17, 2018 at 9:03 AM, Branko Čibej wrote: >> On 16.07.2018 21:46, Johan Corveleyn wrote: >>> (why would CHANGES in a 1.9.x tarball need to contain changes of the >>> 1.8 line?) >> Because I, as an admi

Re: [RFC] Move CHANGES and COMMITTERS out of trunk/branches

2018-07-17 Thread Branko Čibej
On 16.07.2018 21:46, Johan Corveleyn wrote: > (why would CHANGES in a 1.9.x tarball need to contain changes of the > 1.8 line?) Because I, as an admin, want to see the whole relevant history in CHANGES when something breaks and I have to fix it.

Re: Subversion 1.10.2 up for testing/signing

2018-07-16 Thread Branko Čibej
Summary: +1 to release (Unix) Verified: - Tarball contents and signatures - check ((fsfs, bdb) × (local, svnserve, dav)) - check-all-javahl - check-swig-py - check-swig-rb - check-swig-pl Known issues: - 'make check-swig-py' requires 'make install install-swig-py'. Probab

Re: Subversion 1.10.2 up for testing/signing

2018-07-15 Thread Branko Čibej
On 16.07.2018 08:08, Branko Čibej wrote: > On 16.07.2018 00:46, Johan Corveleyn wrote: >> On Sat, Jul 14, 2018 at 10:55 PM, Julian Foad wrote: >>> The 1.10.2 release artifacts are now available for testing/signing. >>> >>> Please get the tarballs from >>

Re: Subversion 1.10.2 up for testing/signing

2018-07-15 Thread Branko Čibej
On 16.07.2018 00:46, Johan Corveleyn wrote: > On Sat, Jul 14, 2018 at 10:55 PM, Julian Foad wrote: >> The 1.10.2 release artifacts are now available for testing/signing. >> >> Please get the tarballs from >> https://dist.apache.org/repos/dist/dev/subversion >> and add your signatures there. >> >

Re: svn commit: r1834612 - in /subversion/branches/1.10.x-issue4758/subversion: libsvn_client/shelve.c tests/cmdline/shelve_tests.py

2018-07-14 Thread Branko Čibej
On 13.07.2018 17:36, Philip Martin wrote: > Julian Foad writes: > >> Philip, can you help clarify this? >>> It's not clear to me from the added paragraph whether the restriction >>> "only access the context from a thread at a time" is imposed by the >>> library implementation or by the way API con

Re: [RFC] Move CHANGES and COMMITTERS out of trunk/branches

2018-07-14 Thread Branko Čibej
On 13.07.2018 19:43, Daniel Shahaf wrote: > Julian Foad wrote on Fri, 13 Jul 2018 17:12 +0100: >> $ svn ls ^/subversion >> README >> branches/ >> developer-resources/ >> site/ >> site-ng/ >> svn-logos/ >> tags/ >> trunk/ >> upstream/ >> >> Brane's suggestion of locating CHANGES in the web site tree

Re: [RFC] Move CHANGES and COMMITTERS out of trunk/branches

2018-07-13 Thread Branko Čibej
On 13.07.2018 16:19, Julian Foad wrote: > Our releasing docs say, "CHANGES should always be edited on trunk and then > merged over to the release branch(es)". The 'CHANGES' file in 1.10.1 doesn't > have the latest two fixes that were merged to 1.10.x last night, because I > missed manually re-ex

Re: Intentions for 1.11 release timing

2018-06-29 Thread Branko Čibej
On 29.06.2018 13:32, Julian Foad wrote: > Can others approve or comment on this reduced plan please, especially those > who +1'd the previous statement ( http://svn.apache.org/r1834111 ) which I > now think was too onerous? > > Stefan Sperling wrote: >> I would prefer having just the minimum requ

Re: #4754: Status Cache

2018-06-25 Thread Branko Čibej
On 25.06.2018 13:54, Stefan Sperling wrote: > On Mon, Jun 25, 2018 at 01:44:21PM +0200, Branko Čibej wrote: >> On 25.06.2018 13:37, Stefan Sperling wrote: >>> On Mon, Jun 25, 2018 at 01:29:04PM +0200, Branko Čibej wrote: >>>> On 25.06.2018 13:21, Julian Foad wrote:

Re: #4754: Status Cache

2018-06-25 Thread Branko Čibej
On 25.06.2018 13:37, Stefan Sperling wrote: > On Mon, Jun 25, 2018 at 01:29:04PM +0200, Branko Čibej wrote: >> On 25.06.2018 13:21, Julian Foad wrote: >>> Can someone confirm this makes sense as a feature request? >>> >>> I know the usual caveats apply: detai

Re: #4754: Status Cache

2018-06-25 Thread Branko Čibej
On 25.06.2018 13:21, Julian Foad wrote: > Can someone confirm this makes sense as a feature request? > > I know the usual caveats apply: details need to be filled in, and lack of > resources; but basically? Basically, sure. In practice, though, I've never found these notification services to be v

Re: svn commit: r1833512 - /subversion/trunk/subversion/tests/cmdline/shelf_tests.py

2018-06-14 Thread Branko Čibej
On 14.06.2018 17:36, julianf...@apache.org wrote: > Author: julianfoad > Date: Thu Jun 14 15:36:54 2018 > New Revision: 1833512 > > URL: http://svn.apache.org/viewvc?rev=1833512&view=rev > Log: > Change shelf_tests.py binary data tests to use varying file lengths. I wonder though, isn't this basic

Re: shelf-tests failure on macOS

2018-06-14 Thread Branko Čibej
On 14.06.2018 18:09, Philip Martin wrote: > Philip Martin writes: > >> Julian Foad writes: >> >>> The most unusual thing about these failing tests is the data they >>> write. Strings of 5 or 6 low-value bytes, like: >>> >>> '\0\1\2\3\4\5' >>> '\5\4\3\2\1\0' >> Those are the same size. Could it b

Re: shelf-tests failure on macOS

2018-06-14 Thread Branko Čibej
On 14.06.2018 16:50, Julian Foad wrote: > Branko Čibej wrote: >> The object lifetime and implicit close are very well defined indeed in >> CPython, which we use. We don't use "modern Pythons on other virtual >> machines." >> If this were indeed the source

Re: svn commit: r1833501 - in /subversion/trunk/subversion/tests/cmdline: ./ svntest/

2018-06-14 Thread Branko Čibej
On 14.06.2018 11:02, julianf...@apache.org wrote: > Author: julianfoad > Date: Thu Jun 14 09:02:11 2018 > New Revision: 1833501 > > URL: http://svn.apache.org/viewvc?rev=1833501&view=rev > Log: > In the test suite: replace 'open().write()' with a 'with' construct. > > The form 'with open() as f: f.

Re: shelf-tests failure on macOS

2018-06-13 Thread Branko Čibej
On 14.06.2018 04:04, Branko Čibej wrote: > So, long story short ... changing all the open().write() statements to > the 'with' form should at least remove one possible source of bugs. We also use open().read() a lot, but that should not have timing problems since it doesn&#

Re: shelf-tests failure on macOS

2018-06-13 Thread Branko Čibej
On 13.06.2018 16:31, Julian Foad wrote: > Branko Čibej wrote: >> On 12.06.2018 13:00, Julian Foad wrote: >>> Branko Čibej wrote: >>>> https://ci.apache.org/builders/svn-x64-macosx-apr1.3-nothread/builds/3416/steps/Test%20ra_local%2Bfsfs/logs/faillog >>>> &

Re: shelf-tests failure on macOS

2018-06-12 Thread Branko Čibej
On 12.06.2018 13:00, Julian Foad wrote: > Branko Čibej wrote: >> https://ci.apache.org/builders/svn-x64-macosx-apr1.3-nothread/builds/3416/steps/Test%20ra_local%2Bfsfs/logs/faillog >> >> With the file contents now being printed in the test log, we can see how >>

shelf-tests failure on macOS

2018-06-11 Thread Branko Čibej
https://ci.apache.org/builders/svn-x64-macosx-apr1.3-nothread/builds/3416/steps/Test%20ra_local%2Bfsfs/logs/faillog With the file contents now being printed in the test log, we can see how the test is failing. What's worrying is that we don't see this failure either on Windows or Linux (at least,

Re: handling of reparse points

2018-06-07 Thread Branko Čibej
On 08.06.2018 00:30, Branko Čibej wrote: > On 07.06.2018 18:50, Stefan Kueng wrote: >> >> On 05.06.2018 23:35, Philip Martin wrote: >>> Stefan Küng writes: >>> >>>> Index: subversion/libsvn_subr/io.c >>>> ==

Re: handling of reparse points

2018-06-07 Thread Branko Čibej
On 07.06.2018 18:50, Stefan Kueng wrote: > > > On 05.06.2018 23:35, Philip Martin wrote: >> Stefan Küng writes: >> >>> Index: subversion/libsvn_subr/io.c >>> === >>> --- subversion/libsvn_subr/io.c    (revision 1831874) >>> +++ subver

Re: Shelving / Checkpointing thoughts

2018-06-06 Thread Branko Čibej
On 06.06.2018 16:53, Paul Hammant wrote: > [going back in time to August 29th] > > > > Apache products aren't allowed to depend on GPL'd code for mandatory / > core features. > > > This is academic now as Julian is making great progress with his > shelve tech that's built in to Subversion a

Re: handling of reparse points

2018-05-26 Thread Branko Čibej
On 25.05.2018 20:30, Stefan Kueng wrote: > > > On 25.05.2018 18:07, Daniel Shahaf wrote: >> Stefan Küng wrote on Fri, 25 May 2018 17:37 +0200: >>> Can anyone comment on this please? >> >> I'm not familiar with the Windows side of things, but I gave the >> patch a spin. > > And I'm not familiar with

Re: Minimum version of JDK for Subversion 1.10 (was Re: JDK 10 removal of javah)

2018-05-18 Thread Branko Čibej
On 18.05.2018 14:40, Stefan Sperling wrote: > On Fri, May 18, 2018 at 02:36:06PM +0200, Branko Čibej wrote: >> On 18.05.2018 14:34, Stefan Sperling wrote: >>> On Fri, May 18, 2018 at 08:22:46AM -0400, James McCoy wrote: >>>> On Fri, May 18, 2018 at 09:46:41A

Re: Minimum version of JDK for Subversion 1.10 (was Re: JDK 10 removal of javah)

2018-05-18 Thread Branko Čibej
On 18.05.2018 14:34, Stefan Sperling wrote: > On Fri, May 18, 2018 at 08:22:46AM -0400, James McCoy wrote: >> On Fri, May 18, 2018 at 09:46:41AM +0200, Stefan Sperling wrote: >>> Elsewhere in this discussion thread it was suggested to raise the >>> minimum JDK version requirement to Java 1.8. >>> Y

Re: svn commit: r1831540 - /subversion/trunk/subversion/tests/cmdline/svntest/main.py

2018-05-14 Thread Branko Čibej
On 14.05.2018 08:54, jor...@apache.org wrote: > Author: jorton > Date: Mon May 14 06:54:55 2018 > New Revision: 1831540 > > URL: http://svn.apache.org/viewvc?rev=1831540&view=rev > Log: > * subversion/tests/cmdline/svntest/main.py > (open_pipe): Run Python tests under the same Python executable f

Re: [PATCH] fixed python executable for svntest

2018-05-08 Thread Branko Čibej
On 08.05.2018 12:19, Joe Orton wrote: > As part of the Python 2->3 migration effort in Fedora we've been trying > to get to the point where setting PYTHON=/usr/bin/python3 allows us to > ensure that /usr/bin/python is never used in the build environment. > > One thing that doesn't work right with

Re: JDK 10 removal of javah

2018-05-04 Thread Branko Čibej
On 04.05.2018 14:12, James McCoy wrote: > On Sat, Dec 23, 2017 at 06:44:13PM +0100, Branko Čibej wrote: >> On 23.12.2017 16:30, Andreas Stieger wrote: >>> Hello, >>> >>> I was made aware by our Java package maintainer of the fact that JDK 10 >>> is r

Re: Subversion clients following HTTP 302 response codes.

2018-04-26 Thread Branko Čibej
On 15.04.2018 19:49, Paul Hammant wrote: > > I'm still wondering what you're aiming for though. An obvious example > would be offloading resource content storage from the repository > server > to some other storage. But if you want to do that, relying on > redirects > is har

Re: Subversion clients following HTTP 302 response codes.

2018-04-26 Thread Branko Čibej
On 26.04.2018 11:47, Paul Hammant wrote: > Re https://issues.apache.org/jira/browse/SVN-4738 > > > If I paid for this to be developed (say on UpWork), what criteria > would that work have to meet to be consumed into Subversion's trunk > for later rel

Re: Subversion clients following HTTP 302 response codes.

2018-04-17 Thread Branko Čibej
On 17.04.2018 17:22, Paul Hammant wrote: > https://issues.apache.org/jira/browse/SVN-4738 filed :) Hmmm ... the environment described in that feature is interesting. -- Brane P.S.: Yes, I've often though that the Jira issue creation UI is broken in this respect.

Re: svn commit: r1829344 - in /subversion/trunk/build/ac-macros: lz4.m4 utf8proc.m4

2018-04-17 Thread Branko Čibej
On 17.04.2018 13:34, Johan Corveleyn wrote: > On Tue, Apr 17, 2018 at 1:15 PM, Philip Martin > wrote: >> Johan Corveleyn writes: >> >>> Maybe we could add an extra hint to the error message along the lines >>> of "Maybe you want --with-lz4=internal"? To help self-serviceness and >>> avoid mails

Re: Strange libtool errors when try to build pyhton and ruby bindings (1.10.0)

2018-04-16 Thread Branko Čibej
On 16.04.2018 14:29, James McCoy wrote: > On Mon, Apr 16, 2018 at 10:42:31AM +0200, Branko Čibej wrote: >> [Moved from users@] >> >> On 16.04.2018 10:36, Branko Čibej wrote: >>> The problem is that Swig has become a build-time dependency now. We >>> don'

Re: Strange libtool errors when try to build pyhton and ruby bindings (1.10.0)

2018-04-16 Thread Branko Čibej
[Moved from users@] On 16.04.2018 10:36, Branko Čibej wrote: > On 15.04.2018 21:30, Branko Čibej wrote: >> On 13.04.2018 18:20, Lev Serebryakov wrote: >>> I'm preparing FreeBSD of subversion-1.10.0 and have very strange errors >>> when try to build bindings. &

Re: move certain svn props to top level path?

2018-04-15 Thread Branko Čibej
On 15.04.2018 23:42, Stefan wrote: > On 15/04/2018 22:56, Julian Foad wrote: >> Branko Čibej wrote on 2018-04-15: >>> On 15.04.2018 21:01, Stefan wrote: >>>> On 05/04/2018 00:09, Stefan wrote: >>>>> I'm not sure if there are other tools aro

Re: move certain svn props to top level path?

2018-04-15 Thread Branko Čibej
On 15.04.2018 21:01, Stefan wrote: > On 05/04/2018 00:09, Stefan wrote: >> On 04/04/2018 23:47, Branko Čibej wrote: >>> On 04.04.2018 23:12, Stefan wrote: >>>> Hi, >>>> >>>> atm we specify the following svn properties on trunk

Re: Subversion clients following HTTP 302 response codes.

2018-04-15 Thread Branko Čibej
On 15.04.2018 19:49, Paul Hammant wrote: > > I'm still wondering what you're aiming for though. An obvious example > would be offloading resource content storage from the repository > server > to some other storage. But if you want to do that, relying on > redirects > is har

Re: Subversion clients following HTTP 302 response codes.

2018-04-15 Thread Branko Čibej
On 15.04.2018 15:20, Paul Hammant wrote: > The main conversation - PROPFIND, OPTIONS etc with a canonical > centralized server, _but_ select GETs (among many) being redirected to > other URLs. > > My testing didn't show that that was supported. As a good XPer, I > should be able to conjure up a scr

Re: Subversion clients following HTTP 302 response codes.

2018-04-15 Thread Branko Čibej
On 15.04.2018 14:52, Paul Hammant wrote: > It would be cool if svn.exe (the client) could follow HTTP return code > '302' during svn-co and svn-up operations. > > I'm thinking that this is just for GET* of resources, and that someone > who's managed to _front_ their Mod_Dav_Svn with something that

Re: Subversion1.10.0 up for testing/signing

2018-04-11 Thread Branko Čibej
On 11.04.2018 20:48, Branko Čibej wrote: > +1 to release (Unix and Windows) > > Verified that the tarball contents match the 1.10.0-rc2 release, except > for version numbers. Of course I also verified the signatures and checksums. -- Brane

Re: SVN working copy split DB vs. working area

2018-04-11 Thread Branko Čibej
On 11.04.2018 20:27, Doug Robinson wrote: > Folks: > > I've now seen a request for this twice in as many days.  Once from > a customer and once from someone posting to a Subversion forum > here: > > https://www.svnforum.org/forum/opensource-subversion-forums/apache-subversion-1-8-support/80218-subv

Re: Subversion1.10.0 up for testing/signing

2018-04-11 Thread Branko Čibej
+1 to release (Unix and Windows) Verified that the tarball contents match the 1.10.0-rc2 release, except for version numbers. -- Brane

Re: Warnings from the bindings

2018-04-07 Thread Branko Čibej
On 07.04.2018 21:20, Philip Martin wrote: > Branko Čibej writes: > >> I'll take another look. At the very least this should be using the local >> frame manager object, which is exception-safe, unlike explicitly pushing >> and popping the frame. > ImmutableList::

Re: Warnings from the bindings

2018-04-07 Thread Branko Čibej
On 07.04.2018 00:25, Philip Martin wrote: > Philip Martin writes: > >>Iterator iter(get_iterator()); >>while (iter.has_next()) >> + { >> +m_env.PushLocalFrame(10); >> function(T(m_env, NativeT(iter.next(; >> +m_env.PopLocalFrame(); >> + } >>

Re: FYI - Shelving & Checkpointing featured in Assembla's Cornerstone 4

2018-04-05 Thread Branko Čibej
On 05.04.2018 21:25, Julian Foad wrote: > Branko Čibej wrote: >> On 05.04.2018 21:06, Julian Foad wrote: >>> The Cornerstone 4 svn client for Mac ... >>> >>> https://cornerstone.assembla.com/ >>> >>> ... with Shelving and Checkpointing calle

Re: FYI - Shelving & Checkpointing featured in Assembla's Cornerstone 4

2018-04-05 Thread Branko Čibej
On 05.04.2018 21:06, Julian Foad wrote: > The Cornerstone 4 svn client for Mac ... > > https://cornerstone.assembla.com/ > > ... with Shelving and Checkpointing called out as new features. > > It's exciting for me to see this new work going so quickly into > production! What really "excites" me a

Re: Subversion1.10.0-rc2 up for testing/signing

2018-04-04 Thread Branko Čibej
Summary: +1 to release (Windows) Platform Windows 10 Pro x64 Build tools: Microsoft Visual Studio Professional 2015 CMake 3.2.3 SCons 2.3.4 (patched for MSVC14) Source dependencies: APR 1.5.2 APR-Util 1.5.4 zlib 1.2.8 httpd 2.4.16 with

Re: move certain svn props to top level path?

2018-04-04 Thread Branko Čibej
On 04.04.2018 23:12, Stefan wrote: > > Hi, > > atm we specify the following svn properties on trunk: > > * bugtraq:url > * bugtraq:logregexp > * tsvn:logwidthmarker > * tsvn:projectlanguage > * webviewer:revision > * (possibly by the time you read this, I added webviewer:pathrevision) >

Re: Warnings from the bindings

2018-04-03 Thread Branko Čibej
On 03.04.2018 13:28, Stefan Fuhrmann wrote: > On 30.03.2018 00:27, Philip Martin wrote: > >> WARNING in native method: JNI call made without checking exceptions when >> required to from CallStaticObjectMethod > Seen these in alpha2 but not in rc2. Java8 has > been updated since then. I don't se

Re: Subversion1.10.0-rc2 up for testing/signing

2018-04-02 Thread Branko Čibej
Summary: +1 to release (Unix) Platform macOS High Sierra 10.13.3 Standard dependencies: Apple LLVM version 9.0.0 (clang-900.0.39.2) ruby 2.3.3p222 (2016-11-21 revision 56859) Python 2.7.10 Dependencies from Homebrew: APR 1.6.3 APR-Util 1.6.1

Re: Warnings from the bindings

2018-03-30 Thread Branko Čibej
On 30.03.2018 00:27, Philip Martin wrote: > Philip Martin writes: > >> +1 to release > The swig-pl tests produce warnings for: > > Warning: unable to close filehandle $out_fh properly: Bad file descriptor at > /home/pm/sw/subversion/sign/build/subversion/bindings/swig/perl/native/blib/lib/SVN/C

Re: Script to obliterate the most recent revision(s)

2018-03-27 Thread Branko Čibej
On 26.03.2018 00:32, Johan Corveleyn wrote: > Interesting stuff ... > > On Sat, Mar 24, 2018 at 8:38 PM, Daniel Shahaf > wrote: >> C. Michael Pilato wrote on Fri, Mar 23, 2018 at 08:46:16 -0400: >>> On 03/23/2018 02:04 AM, Daniel Shahaf wrote: Julian Foad wrote on Thu, 22 Mar 2018 22:24 +000

Re: svn commit: r1827100 - /subversion/branches/1.10.x/STATUS

2018-03-18 Thread Branko Čibej
On 18.03.2018 16:04, Daniel Shahaf wrote: > Branko Čibej wrote on Sat, 17 Mar 2018 20:27 +0100: >> On 17.03.2018 20:24, br...@apache.org wrote: >>> >>> + * r1825979 >>> + Minor clarification to docstring. >>> + Justification: >>> +

Re: [PATCH] Hackathon project: Dumping viewspec

2018-03-18 Thread Branko Čibej
On 18.03.2018 13:43, Julian Foad wrote: > Branko Čibej wrote: >> On 16.03.2018 18:33, Julian Foad wrote: >>> I implemented an output format compatible with 'svn-viewspec.py' in >>> r1826990. Then I updated that output format to also support 'switched

Re: svn commit: r1827100 - /subversion/branches/1.10.x/STATUS

2018-03-17 Thread Branko Čibej
On 17.03.2018 20:24, br...@apache.org wrote: > > + * r1825979 > + Minor clarification to docstring. > + Justification: > + Trivial documentation fix. > + Votes: > + +1: danielsh, jamessan > + -1: brane (the docstring "clarification" is wrong, since > +we do not p

Re: svnadmin load error with 1.10 that seems to be fsfs cache related

2018-03-17 Thread Branko Čibej
On 17.03.2018 13:57, Philip Martin wrote: > Julian Foad writes: > >> But does that mean this code isn't being tested by any of our manual >> or buildbot testing in the last 6 months? > Yes, I think so. > > For svnserve the code only gets enabled when svnserve has block-read > enabled and svnservea

Re: [PATCH] Hackathon project: Dumping viewspec

2018-03-17 Thread Branko Čibej
On 16.03.2018 18:33, Julian Foad wrote: > Johan Corveleyn wrote: >> Julian Foad wrote: >>> We need to look at using the viewspec as input next. Semantically >>> speaking, >>> these sorts of things: >>> >>> * a way to check out a new WC to match the spec; >>> * a way to modify an existing WC to matc

Re: svn commit: r1826928 - /subversion/trunk/subversion/libsvn_client/shelf.c

2018-03-16 Thread Branko Čibej
On 16.03.2018 10:22, Daniel Shahaf wrote: > Branko Čibej wrote on Fri, 16 Mar 2018 10:14 +0100: >> On 16.03.2018 10:05, danie...@apache.org wrote: >>> Author: danielsh >>> Date: Fri Mar 16 09:05:45 2018 >>> New Revision: 1826928 >>> >>>

Re: svn commit: r1826928 - /subversion/trunk/subversion/libsvn_client/shelf.c

2018-03-16 Thread Branko Čibej
On 16.03.2018 10:05, danie...@apache.org wrote: > Author: danielsh > Date: Fri Mar 16 09:05:45 2018 > New Revision: 1826928 > > URL: http://svn.apache.org/viewvc?rev=1826928&view=rev > Log: > * subversion/libsvn_client/shelf.c: Add newline at end of file. > I would have added -Wno-newline-eof t

Re: svnadmin load error with 1.10 that seems to be fsfs cache related

2018-03-15 Thread Branko Čibej
On 15.03.2018 20:38, Philip Martin wrote: > Philip Martin writes: > >> I think the raw >> window cache may have to be modified to include the svndiff version. > Experimental patch: Looks approximately correct to me. Hard-coding version 1 would have been wrong before LZ4, too, since version 0 does

Re: svnadmin load error with 1.10 that seems to be fsfs cache related

2018-03-15 Thread Branko Čibej
On 15.03.2018 18:50, Philip Martin wrote: > Philip Martin writes: > >> Evgeny Kotkov writes: >> >>> Philip Martin writes: >>> That works as expected, but vary the cache size of the load process and it fails. The load succeeds with -M64 and smaller but fails with -M65 and larger:

Re: Rolling 1.10.0-rc2

2018-03-14 Thread Branko Čibej
On 14.03.2018 08:58, Julian Foad wrote: > Julian Foad wrote on 2018-02-28: >> I'm happy to announce the release of Apache Subversion 1.10.0-rc1. > > That was 2 weeks ago and we need an RC2. > > I plan to roll 1.10.0-rc2 this week so we can release it by next > Wednesday (3 weeks from RC1). > > Plea

Re: Updating swig-py bindings

2018-03-14 Thread Branko Čibej
On 14.03.2018 04:24, Troy Curtis Jr wrote: > On Tue, Mar 13, 2018 at 9:44 AM Julian Foad wrote: > >> Troy (or others), I want to use swig-py bindings for my new shelving API >> (in svn_client.h) so I am trying to update them. I started by looking at >> the 'Missing argout typemap' warnings for svn

Re: New build requirements for 1.10?

2018-03-13 Thread Branko Čibej
On 13.03.2018 14:27, Mark Phippard wrote: > Starting to put together updated binaries for 1.10 release.  Can > someone summarize any new build requirements, particularly for Windows? > > I see the reference to LZ4.  Should we use the "internal" > implementation or are we expected to build and deliv

Re: Subversion Exception!

2018-03-10 Thread Branko Čibej
[Top-posting on purpose] Would it make sense to require other clients, such as TortoiseSVN, to change the text and links in this exception message? It would be better for everyone if the authors of the distro (in this case, TSVN) were the first to get these error reports. This particular one look

Re: [PATCH] Split long strings into paragraphs to ease translation

2018-03-06 Thread Branko Čibej
On 06.03.2018 23:09, Julian Foad wrote: > Mattias Engdegård wrote in thread "Translation of Subversion": What really needs to be done to make life for translators somewhat bearable is to split the long strings into individual paragraphs; this is standard practice. > > The attached pa

Re: svn commit: r1825787 - /subversion/trunk/subversion/tests/libsvn_subr/utf-test.c

2018-03-03 Thread Branko Čibej
On 03.03.2018 22:03, james...@apache.org wrote: > Author: jamessan > Date: Sat Mar 3 21:03:09 2018 > New Revision: 1825787 > > URL: http://svn.apache.org/viewvc?rev=1825787&view=rev > Log: > * subversion/tests/libsvn_subr/utf-test.c: > (test_utf_conversions): Move maxlen loop after declarations

Re: libsvn_subr/utf-test failure due to unaligned memory access

2018-03-03 Thread Branko Čibej
On 03.03.2018 20:18, James McCoy wrote: > This test has been failing for some time on Debian's alpha buildd[0]. > One of the alpha porters looked into it and gave a thorough diagnosis[1] > of the issue which basically boils down to: using a char* as > apr_uint16_t*/apr_int32_t* is going to result i

Re: Potential regression: high server-side memory consumption during import

2018-03-03 Thread Branko Čibej
On 03.03.2018 19:15, James McCoy wrote: > On Sat, Mar 03, 2018 at 06:54:06PM +0100, Branko Čibej wrote: >> P.S.: Running tests now with the patched 1.10.x, will vote on the >> backport as soon as that's done. If it's approved, I believe we have to >> move our expect

Re: Potential regression: high server-side memory consumption during import

2018-03-03 Thread Branko Čibej
On 03.03.2018 18:46, Philip Martin wrote: > Branko Čibej writes: > >> So if I understand this debate correctly: The authz code is so much >> faster now that parsing the authz file and performing the authz lookups >> beats calculating its MD5 checksum? > More that readin

Re: Potential regression: high server-side memory consumption during import

2018-03-03 Thread Branko Čibej
On 03.03.2018 17:44, Stefan Sperling wrote: > On Sat, Mar 03, 2018 at 04:32:35PM +, Philip Martin wrote: >> Stefan Sperling writes: >> >>> Which leads me to believe that r1778923 may have been based on wrong >>> assumptions about performance. The new authz is not fast enough to >>> significant

Re: Potential regression: high server-side memory consumption during import (was: Subversion 1.10 RC1?)

2018-03-03 Thread Branko Čibej
On 02.03.2018 19:21, Stefan Sperling wrote: > I am just questioning the usefulness of halting the presses and restarting > the soak for another month for something that isn't a security / data > corruption issue. It's a potential DOS that only needs read access. Falls under security by my definiti

Re: APR's check for installed libtool is inconsistent

2018-02-26 Thread Branko Čibej
On 26.02.2018 18:39, Julian Foad wrote: > (CC'ing Subversion as Subversion's build system both uses and kind-of > duplicates this.) > > APR's 'build/buildcheck.sh' says: > [[[ > # Require libtool 1.4 or newer > libtool=`build/PrintPath glibtool1 glibtool libtool libtool15 libtool14` > ... > ]]] > >

Re: New-in-1.10 editor->apply_textdelta_stream() method

2018-02-26 Thread Branko Čibej
On 26.02.2018 13:02, Julian Foad wrote: > Julian Foad wrote: >> My suspicion was raised because I tried using >> svn_delta__get_debug_editor and it wasn't implemented in there. I >> fixed that. If that was the only place it was missing, that's fine. > > That is, I implemented apply_textdelta_stream

Re: Subversion1.10.0-rc1 up for testing/signing

2018-02-24 Thread Branko Čibej
On 24.02.2018 21:55, Julian Foad wrote: > Branko Čibej wrote: >>>    - Warning from JavaHL build: >>> >>> subversion/bindings/javahl/native/SVNRepos.cpp:371:15: warning: >>> 'svn_repos_load_fs5' >>>    is deprecated [-Wdeprecat

Re: Subversion build ... but just client commands?

2018-02-24 Thread Branko Čibej
On 24.02.2018 13:32, Paul Hammant wrote: > I'm probably never going to deploy a Svn server on the Mac or > Windows10(S) - keep up the good work Satya! > > What are the options for ./configure and make to focus on the client > executables only, and skip svnserve and mod_dav_svn? --without-apxs will

Re: Building Subversion on the Mac

2018-02-24 Thread Branko Čibej
On 24.02.2018 13:22, Paul Hammant wrote: > The homebrew install does a source compile rather than pluck of a > binary and compare to a SHA256 ? Depends. By default, it'll get a binary, if it's available (that binary is of course built from source using Homebrew's formulae). If a binary isn't avail

Re: Building Subversion on the Mac

2018-02-24 Thread Branko Čibej
On 24.02.2018 12:42, Paul Hammant wrote: > This seems to work for me, based on your advice: > > ./configure --with-apr=/usr/local/opt/apr > --with-apr-util=/usr/local/opt/apr-util > --with-apxs=/usr/local/opt/apache2/bin/apxs > > I'm thinking those are solid Homebrew paths for most people. Yes, th

Re: Subversion1.10.0-rc1 up for testing/signing

2018-02-24 Thread Branko Čibej
On 23.02.2018 16:32, Branko Čibej wrote: > Summary: > > +1 to release (Unix) > New issues: > > - Warning from JavaHL build: > > subversion/bindings/javahl/native/SVNRepos.cpp:371:15: warning: > 'svn_repos_load_fs5' >

Re: Subversion1.10.0-rc1 up for testing/signing

2018-02-24 Thread Branko Čibej
Summary: +1 to release (Windows) Platform Windows 10 Pro x64 Build tools: Microsoft Visual Studio Professional 2015 CMake 3.2.3 SCons 2.3.4 (patched for MSVC14) Source dependencies: APR 1.5.2 APR-Util 1.5.4 zlib 1.2.8 httpd 2.4.16 with

Re: Building Subversion on the Mac

2018-02-24 Thread Branko Čibej
On 24.02.2018 11:18, Paul Hammant wrote: > Based on Brane's email from yesterday, I did a build for Subversion on > the Mac, with Homebrew and XCode installed already. > > brew install apr apr-util httpd serf zlib berkeley-db swig lz4 utf8proc >   > # These two were necessary for me, for some reaso

Re: Subversion1.10.0-rc1 up for testing/signing

2018-02-23 Thread Branko Čibej
Summary: +1 to release (Unix) Platform macOS High Sierra 10.13.3 Standard dependencies: Apple LLVM version 9.0.0 (clang-900.0.39.2) ruby 2.3.3p222 (2016-11-21 revision 56859) Python 2.7.10 Dependencies from Homebrew: APR 1.6.3 APR-Util 1.6.1

Re: Backward or forward deltas, backend, FSX

2018-02-15 Thread Branko Čibej
On 15.02.2018 22:11, Daniel Shahaf wrote: >> With say, 10 revisions, when someone checks out the last revision: >> svn starts (would start, with the FSX backend) >> with the 30 years old, "fossile" ancient revision? (It would be case >> with the "FSFS-like way".) Which has nothing common >>

Re: [PATCH] Virtual host mode with user name in URL

2018-02-15 Thread Branko Čibej
On 15.02.2018 16:54, Thomas Quinot wrote: > * Philip Martin, 2018-02-15 : > >> That looks correct so far, but it leads me to consider port numbers. >> >> svn ls svn://hostname:3691/repo >> >> Should the server look for the repository under 'hostname:3691' or under >> the plain 'hostname'? I susp

Re: Relaxed STATUS voting rules for experimental features?

2018-02-12 Thread Branko Čibej
On 12.02.2018 16:00, Daniel Shahaf wrote: > The shelving functionality is experimental: > > /** Shelve a change. > ⋮ > * @since New in 1.10. > * @warning EXPERIMENTAL. > */ > SVN_EXPERIMENTAL > svn_error_t * > svn_client_shelve(const char *name, >

Re: server crash in authz object pool

2018-02-12 Thread Branko Čibej
On 12.02.2018 14:27, Stefan Sperling wrote: > On Mon, Feb 12, 2018 at 02:24:56PM +0100, Branko Čibej wrote: >> Out of interest: why are you using APR without threads? > To ensure that this configuration is still being tested. That's good. https://ci.apache.org/builders/svn-

Re: server crash in authz object pool

2018-02-12 Thread Branko Čibej
On 12.02.2018 13:07, Stefan Sperling wrote: > On Mon, Feb 12, 2018 at 12:50:12PM +0100, Stefan Sperling wrote: >> The svn-bb-openbsd bot has found a crash in the object pool code. >> >> It is triggered when running RA serf tests on OpenBSD. The httpd >> work processes crash due to what looks like a

Re: Bad error message when the URL doesn't point to a repository

2018-02-09 Thread Branko Čibej
On 09.02.2018 17:45, Julian Foad wrote: > Daniel Shahaf wrote: >> Branko Čibej wrote on Tue, 06 Feb 2018 22:10 +0100: >>> The error message now looks like this: >>> >>> $ svn ls http://svn.apache.org/foo >>> svn: E170013: Unable to connect to a rep

Re: Bad error message when the URL doesn't point to a repository

2018-02-06 Thread Branko Čibej
On 06.02.2018 18:35, Branko Čibej wrote: > Earlier today, Julian noted the following on IRC: > > $ svn ls http://svn.apache.org/foo > svn: E170013: Unable to connect to a repository at URL > 'http://svn.apache.org/foo' > svn: E175009: The XML response contain

Bad error message when the URL doesn't point to a repository

2018-02-06 Thread Branko Čibej
Earlier today, Julian noted the following on IRC: $ svn ls http://svn.apache.org/foo svn: E170013: Unable to connect to a repository at URL 'http://svn.apache.org/foo' svn: E175009: The XML response contains invalid XML svn: E130003: Malformed XML: no element found While the first error (Unable

Re: Reviewing 1.10 APIs & compatibility

2018-02-06 Thread Branko Čibej
On 06.02.2018 16:39, Julian Foad wrote: > if sbox.repo_url.startswith("http") and svntest.main.options.server_minor_ver Nope; there are predicate functions for that. svntest.main.is_ra_type_dav() in this case. There's no predicate for the actual server version though. -- Brane

Re: svn commit: r1822996 - in /subversion/trunk/subversion: libsvn_subr/x509parse.c tests/libsvn_subr/x509-test.c

2018-02-03 Thread Branko Čibej
On 02.02.2018 19:27, phi...@apache.org wrote: > Author: philip > Date: Fri Feb 2 18:27:44 2018 > New Revision: 1822996 > > URL: http://svn.apache.org/viewvc?rev=1822996&view=rev > Log: > Fix x509 parser to accept RSASSA-PSS certs by no longer assuming that > algorithm parameters are NULL for all a

Re: SVN-4709 shelve: deleted file becomes 'replaced'

2018-01-26 Thread Branko Čibej
On 26.01.2018 09:14, Johan Corveleyn wrote: > On Fri, Jan 26, 2018 at 8:33 AM, Branko Čibej wrote: >> On 25.01.2018 19:47, Johan Corveleyn wrote: >>> On Thu, Jan 25, 2018 at 1:41 PM, Julian Foad wrote: >>>> Branko Čibej wrote: >>>>> On 24.01.2018 22:

Re: SVN-4709 shelve: deleted file becomes 'replaced'

2018-01-25 Thread Branko Čibej
On 25.01.2018 19:47, Johan Corveleyn wrote: > On Thu, Jan 25, 2018 at 1:41 PM, Julian Foad wrote: >> Branko Čibej wrote: >>> On 24.01.2018 22:32, Julian Foad wrote: >>>> When 'svn patch' applies an 'add file' patch onto a WC path whose >>&

Re: SVN-4709 shelve: deleted file becomes 'replaced'

2018-01-24 Thread Branko Čibej
On 24.01.2018 22:32, Julian Foad wrote: > When 'svn patch' applies an 'add file' patch onto a WC path whose > local schedule is 'delete', it changes the schedule to 'replace'. > > Sequences such as this... > > > svn rm foo > > svn diff > rm-foo.diff > > svn patch --reverse-diff rm-foo.diff > > or t

<    1   2   3   4   5   6   7   8   9   10   >