Re: GSoC Progress report

2010-07-29 Thread Branko Čibej
On 28.07.2010 21:55, Daniel Shahaf wrote: Stefan Sperling wrote on Wed, Jul 28, 2010 at 16:05:49 +0200: But there's no harm in making svn patch interpret existing move information in git diffs. We can carry out a corresponding copy + delete. We won't be generating move git diff headers

Re: GSoC Progress report

2010-07-29 Thread Branko Čibej
On 28.07.2010 12:06, Daniel Näslund wrote: * base85 encode binary content Does git do that? Hmmm ... I'd have used base64 myself, not quite as compact but a lot more existing tools and libraries understand it. -- Brane

Re: Suggestion: Transparent Branching

2010-07-29 Thread Branko Čibej
On 07.07.2010 18:29, Greg Hudson wrote: On Wed, 2010-07-07 at 11:44 -0400, Marco Jansen wrote: So therefor, what we would like to see is to be able to have a transparent branch: One which fetches updates from both branch and trunk, without having them listed as changes or triggering

Re: Callbacks, prompts, etc. for issue 2779

2010-07-30 Thread Branko Čibej
On 30.07.2010 03:21, C. Michael Pilato wrote: On 07/29/2010 08:54 PM, Mike Dixon wrote: On 7/29/2010 9:43 AM, C. Michael Pilato wrote: On 07/29/2010 12:28 PM, Mark Phippard wrote: If we just do the redirects, might a user just not perceive SVN as being slow? Well,

Re: Callbacks, prompts, etc. for issue 2779

2010-07-30 Thread Branko Čibej
On 30.07.2010 13:57, C. Michael Pilato wrote: On 07/30/2010 03:55 AM, Branko Čibej wrote: That approach just doesn't sound right to me. I've always understood that a temporary redirect implies that requests should always try the original first. Since there's no concept of a session in HTTP

Re: opening fsfs rev files rw

2010-08-04 Thread Branko Čibej
On 04.08.2010 12:14, Julian Foad wrote: On Tue, 2010-08-03 at 20:08 +0300, Daniel Shahaf wrote: Julian Foad wrote on Tue, Aug 03, 2010 at 17:36:00 +0100: On Tue, 2010-08-03 at 18:19 +0300, Daniel Shahaf wrote: Daniel Shahaf wrote on Tue, Aug 03, 2010 at 11:58:32 +0300:

Re: Proposal: Change repository's UUID over RA layer

2010-08-06 Thread Branko Čibej
I have to agree. While it may make sense to be able create a dumpfile of a remote repository, I'm not so sure that /loading/ a dumpfile remotely is sensible. And it's the load that potentially requires a UUID change. -- Brane On 06.08.2010 16:03, Greg Stein wrote: Back up here. Why would an

Re: Proposal: Change repository's UUID over RA layer

2010-08-06 Thread Branko Čibej
On 06.08.2010 19:26, Justin Erenkrantz wrote: On Fri, Aug 6, 2010 at 7:34 AM, Branko Čibej br...@xbc.nu wrote: Ahem. You guys have forgotten about Justin's RW-master/RO-slave replication hack, which *requires* the slave repositories to have the same UUID as the master. And that 'svnadmin

Re: svn commit: r983222 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-08-07 Thread Branko Čibej
On 07.08.2010 16:32, Ramkumar Ramachandra wrote: Hi Daniel, Daniel Shahaf writes: artag...@apache.org wrote on Sat, Aug 07, 2010 at 12:31:50 -: Author: artagnon Date: Sat Aug 7 12:31:50 2010 New Revision: 983222 URL: http://svn.apache.org/viewvc?rev=983222view=rev Log:

Re: GSoC coming to an end

2010-08-09 Thread Branko Čibej
On 09.08.2010 10:30, Daniel Näslund wrote: Hi! The soft deadline for GSoC 2010 is today. Not much time left then... What has been accomplished: * A parseable diff format for properties. * svn patch can apply properties * We have Python tests for applying properties. * svn diff can

Re: Bikeshed: configuration override order

2010-08-11 Thread Branko Čibej
On 11.08.2010 11:05, Bolstridge, Andrew wrote: The second aspect: client-stored passwords, this isn't so much about storing them on the client but about having different ones. Enterprises want single-signon, ie, a single password, centrally held, that is used for all apps. They don't really

Re: About character encoding of the text files

2010-08-25 Thread Branko Čibej
On 25.08.2010 18:54, Ivan Cenov wrote: На 25.8.2010 г. 19:27, Matthew Bentham написа: Maybe, but doing it this way is consistent with the way that the charset is included in the Content-Type http header alongside the mime type, described eg. here:

Re: [serf-dev] Re: serf 0.7.0 released

2010-08-25 Thread Branko Čibej
On 26.08.2010 01:46, Greg Stein wrote: On Wed, Aug 25, 2010 at 19:39, Justin Erenkrantz jus...@erenkrantz.com wrote: ... I'm not sure there is any API/ABI changes between 0.6.1 and 0.7.0. Greg? Lieven? -- justin 0.6.1 and 0.7.0 are effectively compatible. I think an unused

Re: Two svn_wc__db_t for single-db upgrade

2010-08-26 Thread Branko Čibej
On 26.08.2010 22:00, Bert Huijben wrote: -Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Sent: donderdag 26 augustus 2010 21:33 To: Greg Stein Cc: Bert Huijben; dev@subversion.apache.org Subject: Re: Two svn_wc__db_t for single-db upgrade Philip

Re: Two svn_wc__db_t for single-db upgrade

2010-08-27 Thread Branko Čibej
On 28.08.2010 02:37, Stefan Sperling wrote: On Fri, Aug 27, 2010 at 01:20:31PM -0400, Bob Archer wrote: Or, if not, the user can do a new checkout, and then use a compare tool to apply your pending changes to your new WC. This means, don't auto-update a WC that has pending changes in it.

Re: Enabling Single-DB mode today

2010-08-31 Thread Branko Čibej
On 31.08.2010 15:51, Paul Burba wrote: On Tue, Aug 31, 2010 at 9:40 AM, Julian Foad julian.f...@wandisco.com wrote: We want to get to single-DB mode ASAP. Is anything still blocking us from enabling it today? * One or two test failures? - I see stat_tests 5 and 6 failing at r991181.

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-02 Thread Branko Čibej
On 02.09.2010 10:27, Daniel Shahaf wrote: Daniel Näslund wrote on Thu, Sep 02, 2010 at 07:13:00 +0200: On Wed, Sep 01, 2010 at 06:37:08PM +0100, Julian Foad wrote: This may be off topic, but I'm wondering whether Git has defined such operations on directories fully or at all, since it doesn't

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-02 Thread Branko Čibej
On 02.09.2010 11:10, Daniel Näslund wrote: So this implicitly creates the file if it doesn't exist already; in other words, we do not distinguish setting a property on an existing file (without content changes) from adding a file with properties. Would it be better to make a distinction ---

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-02 Thread Branko Čibej
On 02.09.2010 13:25, Stefan Sperling wrote: For now, an svn symlink will show up as an empty file when the patch is applied with git. I don't think that's a huge problem. Nice to have, but not release critical for Subversion. That's not how I read the patch ... I believe git will create a

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-03 Thread Branko Čibej
On 02.09.2010 10:50, Branko Čibej wrote: On 02.09.2010 10:27, Daniel Shahaf wrote: Daniel Näslund wrote on Thu, Sep 02, 2010 at 07:13:00 +0200: On Wed, Sep 01, 2010 at 06:37:08PM +0100, Julian Foad wrote: This may be off topic, but I'm wondering whether Git has defined such operations

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-04 Thread Branko Čibej
On 04.09.2010 02:44, Augie Fackler wrote: On Sep 3, 2010, at 7:10 AM, Daniel Näslund wrote: On Fri, Sep 03, 2010 at 12:18:37PM +0200, Branko Čibej wrote: On 02.09.2010 10:50, Branko Čibej wrote: Hmm, this is interesting. :) Git faithfully (blindly?) interprets Unix permission bits, whiles

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-04 Thread Branko Čibej
On 04.09.2010 02:46, Augie Fackler wrote: On Sep 2, 2010, at 4:03 AM, Daniel Näslund wrote: $ svn diff --git Index: empty === diff --git a/trunk/empty b/trunk/empty new directory mode 10644 I'd recommend testing this

Re: [PATCH] don't do autoprops on symbolic links

2010-09-04 Thread Branko Čibej
On 03.09.2010 15:08, Stefan Sperling wrote: On Fri, Sep 03, 2010 at 08:58:09PM +0800, Wei-Yin Chen wrote: Sorry, that line should have been matching_filenames = [f for f in matching_filenames if not os.path.islink(dirname+'/'+f)] Hi, thanks for your patch! I think we should use os.sep

Re: Worried about single-db performance

2010-09-04 Thread Branko Čibej
On 04.09.2010 11:23, Bert Huijben wrote: -Original Message- From: justin.erenkra...@gmail.com [mailto:justin.erenkra...@gmail.com] On Behalf Of Justin Erenkrantz Sent: zaterdag 4 september 2010 8:33 To: Greg Stein Cc: Johan Corveleyn; Subversion Development Subject: Re: Worried

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Branko Čibej
On 04.09.2010 21:45, Justin Erenkrantz wrote: On Sat, Sep 4, 2010 at 10:18 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: Notably, AFAICT, we're repeating a few of these queries: - STMT_SELECT_WORKING_NODE (2 times) - STMT_SELECT_ACTUAL_NODE (3 times) - STMT_SELECT_WORKING_PROPS (2

Re: Repeated SQL queries when doing 'svn st'

2010-09-06 Thread Branko Čibej
On 06.09.2010 12:16, Philip Martin wrote: To use a per-directory query strategy we would probably have to cache data in memory, although not to the same extent as in 1.6. We should probably avoid having Subversion make status callbacks into the application while a query is in progress, so we

Re: Worried about single-db performance

2010-09-07 Thread Branko Čibej
On 07.09.2010 14:29, Matthew Bentham wrote: On 07/09/2010 13:02, Bert Huijben wrote: -Original Message- From: Matthew Bentham [mailto:mj...@artvps.com] Sent: dinsdag 7 september 2010 13:48 To: Bert Huijben Cc: 'Justin Erenkrantz'; 'Greg Stein'; 'Johan Corveleyn'; 'Subversion

Re: svn commit: r992041 - in /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp src/org/apache/subversion/javahl/CommitItem.java src/org/tigris/subversion/javahl/CommitItem.java tests/or

2010-09-07 Thread Branko Čibej
On 07.09.2010 15:42, Hyrum K. Wright wrote: On Thu, Sep 2, 2010 at 2:46 PM, Mark Phippard markp...@gmail.com wrote: On Thu, Sep 2, 2010 at 3:17 PM, Mark Phippard markp...@gmail.com wrote: I would not be so sure. When you are dealing with a GUI, adding a handful of milliseconds to something

Re: svn commit: r995478 [1/2] - in /subversion/branches/performance: ./ subversion/bindings/javahl/native/ subversion/bindings/javahl/src/org/apache/subversion/javahl/ subversion/bindings/javahl/src/o

2010-09-10 Thread Branko Čibej
On 10.09.2010 01:45, Hyrum Wright wrote: [1] Well, I've no way of knowing if it was infinite or just taking a long time, but I'll defer a solution to the Halting Problem as an exercise for the reader. :) Step 1: Pull plug from power socket. Step 2: Check if program is still running. If it is

Re: svn commit: r995603 - /subversion/branches/performance/subversion/libsvn_subr/svn_string.c

2010-09-15 Thread Branko Čibej
On 15.09.2010 09:46, Stefan Sperling wrote: On Fri, Sep 10, 2010 at 03:32:14PM +0200, Stefan Sperling wrote: On Thu, Sep 09, 2010 at 10:58:06PM -, stef...@apache.org wrote: Author: stefan2 Date: Thu Sep 9 22:58:06 2010 New Revision: 995603 URL:

Re: svn diff optimization to make blame faster?

2010-09-20 Thread Branko Čibej
On 15.09.2010 14:20, Johan Corveleyn wrote: Some update on this: I have implemented this for svn_diff (excluding the identical prefix and suffix of both files, and only then starting to fill up the token tree and let the lcs-agorithm to its thing). It makes a *huge* difference. On my

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

2010-09-20 Thread Branko Čibej
On 15.09.2010 21:03, Stefan Sperling wrote: On Fri, Sep 10, 2010 at 04:02:52PM +0200, Branko Čibej wrote: On 10.09.2010 15:26, Stefan Sperling wrote: I know we're using C89, but maybe it's time to move on and upgrade to C99 where the benefits are desirable? When Subversion was started, C89

Re: object-model: Wrapping Subversion C-structs in C++

2010-09-23 Thread Branko Čibej
On 22.09.2010 21:41, Hyrum K. Wright wrote: [ apologizes for the somewhat stream-of-conscious nature of these mails ] On Wed, Sep 22, 2010 at 7:16 PM, Hyrum K. Wright hyrum_wri...@mail.utexas.edu wrote: On Wed, Sep 22, 2010 at 5:35 PM, Hyrum K. Wright hyrum_wri...@mail.utexas.edu wrote:

Re: object-model: Wrapping Subversion C-structs in C++

2010-09-24 Thread Branko Čibej
On 24.09.2010 04:05, Hyrum K. Wright wrote: On Thu, Sep 23, 2010 at 2:20 PM, Branko Čibej br...@xbc.nu wrote: On 22.09.2010 21:41, Hyrum K. Wright wrote: [ apologizes for the somewhat stream-of-conscious nature of these mails ] On Wed, Sep 22, 2010 at 7:16 PM, Hyrum K. Wright hyrum_wri

Re: object-model: Wrapping Subversion C-structs in C++

2010-09-24 Thread Branko Čibej
On 24.09.2010 18:43, Hyrum K. Wright wrote: All of the Pools used to hold the child objects are children of the global parent (created with NULL as the parent pool). As such, they are independent of each other, and won't have destruction order issues. It's pretty wasteful in terms of the

Re: object-model: Wrapping Subversion C-structs in C++

2010-09-25 Thread Branko Čibej
On 25.09.2010 10:34, Steinar Bang wrote: Branko Čibej br...@xbc.nu: I suggest you take a look at auto_ptr and auto_ptr_ref. auto_ptr is very limited in that it allows only a single pointer to a single object. Which is why I mentioned auto_ptr_ref, which is a reference to an auto_ptr (non

Re: trunk failing tests on Windows XP (32 bit): prop-tests.py 33, stat-tests.py 5, upgrade-tests.py 11

2010-10-04 Thread Branko Čibej
On 01.10.2010 15:45, Paul Burba wrote: On Thu, Sep 30, 2010 at 8:10 PM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: Johan Corveleyn [mailto:jcor...@gmail.com] Sent: vrijdag 1 oktober 2010 1:51 To: Subversion Development Subject: trunk failing tests on Windows XP (32

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Branko Čibej
On 08.10.2010 16:50, C. Michael Pilato wrote: On 10/08/2010 10:41 AM, Hyrum K. Wright wrote: I dunno. If we get the same ability from Keychain (which is guaranteed to be available on OS X, iirc), then adding gpg-agent support seems a bit redundant. We then have to answer questions about

Re: [Merge request] Merge r985477 from performance branch

2010-10-11 Thread Branko Čibej
Got into this a bit late, sorry, but I'm not at all happy about this change. If we ignore the issue with long-running SVN processes ... ok, let's assume that changing umask requires that you restart daemons ... I cannot ignore two issues: * The default perms will come from the temp

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-12 Thread Branko Čibej
On 12.10.2010 20:35, Hyrum K. Wright wrote: 1) Return everything by value Pros: simpler memory management, less overhead (?) Cons: doesn't allow the return of NULL values, need to establish conventions to represent NULL objects (an isNull() method?) Meh. inline operator bool()

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-12 Thread Branko Čibej
On 12.10.2010 22:30, Hyrum K. Wright wrote: On Tue, Oct 12, 2010 at 2:40 PM, Branko Čibej br...@xbc.nu wrote: On 12.10.2010 20:35, Hyrum K. Wright wrote: 1) Return everything by value Pros: simpler memory management, less overhead (?) Cons: doesn't allow the return of NULL values

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Branko Čibej
On 13.10.2010 16:10, Hyrum K. Wright wrote: On Tue, Oct 12, 2010 at 5:06 PM, Branko Čibej br...@xbc.nu wrote: On 12.10.2010 22:30, Hyrum K. Wright wrote: On Tue, Oct 12, 2010 at 2:40 PM, Branko Čibej br...@xbc.nu wrote: On 12.10.2010 20:35, Hyrum K. Wright wrote: 1) Return everything

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Branko Čibej
On 13.10.2010 22:05, Steinar Bang wrote: I'm divided on whether I would move the delete of the RefCounter object into the dec_ref method, or leave it where it is. On one hand it feels like good encapsulation to put it together with the dec_ref, on the other hand, I've always been wary of

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Branko Čibej
On 14.10.2010 20:39, Hyrum K. Wright wrote: The following is a somewhat naïve implementation, but does it jive with your suggestion? Roughly yes, see the other comment. On reflection, though, I like the suggestion of returning an std::pairstd::string, bool. Make a typedef of that so that users

Re: Branching 1.7.x by Dec-31

2010-11-06 Thread Branko Čibej
On 06.11.2010 19:11, Hyrum K. Wright wrote: As some of you know, on Thursday night we had a Subversion meetup in conjunction with ApacheCon. The meetup wasn't too well attended (a separate mail on that will be forthcoming), but Greg and I did have some discussions about wc-ng and 1.7.x and

Re: How to get the message out (or: why there were only 6 people at the ApacheCon meetup)

2010-11-09 Thread Branko Čibej
On 09.11.2010 08:42, C. Michael Pilato wrote: (Honestly, when was the last time any of us got excited about some new technical thing because we read a press release about it?) Oh my, another Apple Event has been announced! Whatsisname will tell us why we need to buy all those revolutionary new

Re: 1.7.x bug - svn add no longer accepts wildcards?

2010-11-30 Thread Branko Čibej
On 30.11.2010 05:32, Daniel Becroft wrote: Hi, During testing of a 1.7.x build, I've noticed that 'svn add' on trunk no longer accepts wildcards: svn 1.6.x: D:\temp\svn_sandpit\workingcopy\trunk\Aecho 111 1alpha.txt D:\temp\svn_sandpit\workingcopy\trunk\Aecho 111 1beta.txt

Re: subversion cross compile (arm)

2010-12-06 Thread Branko Čibej
On 06.12.2010 08:48, Takács András wrote: Here you are printing 64-bits, so some part of your system thinks that apr_off_t is 64-bits. How are apr_off_t and APR_HAS_LARGE_FILES defined in apr.h? #define APR_HAS_LARGE_FILES 0 typedef off_t apr_off_t; I think this is OK,

Re: Updating revision references in CHANGES

2010-12-08 Thread Branko Čibej
On 08.12.2010 20:25, C. Michael Pilato wrote: On 12/08/2010 02:00 PM, Hyrum K. Wright wrote: Quick question to find out what people think. In writing the CHANGES entry for 1.7, it would be useful to be able to compare with previous releases what has already gone into the various patch

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Branko Čibej
On 15.12.2010 02:30, Stefan Fuhrmann wrote: On 14.12.2010 23:35, Johan Corveleyn wrote: Some considerations: - Maybe I can use APR_INLINE, with similar results? - Maybe I can put just the critical section into a macro (the curp++ / curp-- part), and call a function when a chunk boundary is

Re: svn commit: r1049414 - /subversion/trunk/subversion/tests/svn_test_main.c

2010-12-15 Thread Branko Čibej
On 15.12.2010 06:17, Blair Zajac wrote: On 12/14/10 8:21 PM, hwri...@apache.org wrote: Author: hwright Date: Wed Dec 15 04:21:23 2010 New Revision: 1049414 URL: http://svn.apache.org/viewvc?rev=1049414view=rev Log: Allow tests which cause segfaults to not disrupt the other tests in the C

Re: Default commandline args

2010-12-21 Thread Branko Čibej
On 21.12.2010 08:31, Stefan Sperling wrote: The svnrc file should not be created by libsvn_client, though. The cli client could create it after initializing the client library, at which point the config directory is guaranteed to exist (if I remember correctly). Indeed, the proposed default

Re: Setting $HOME in the testsuite

2010-12-22 Thread Branko Čibej
On 23.12.2010 06:09, Peter Samuelson wrote: And I still think that 90% of end users, maybe 99%, do _not_ think of Subversion as a stack of libraries that just happens to also ship some command-line wrapper programs as a convenience. Consequently I think they'd prefer the smaller

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

2010-12-29 Thread Branko Čibej
On 28.12.2010 23:13, Peter Samuelson wrote: [C. Michael Pilato] svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child svn_fspath__skip_ancestor svn_fspath__is_ancestor svn_fspath__get_longest_ancestor svn_error__locate

Re: [PATCH] Make error messages visible to translator

2010-12-29 Thread Branko Čibej
On 29.12.2010 07:58, vijay wrote: I could see the error messages in mod_dav_svn are not prefixed by an underscore, may be the subsequent layers will handle the errors and translate it? How will a server component select a translation appropriate for the client's language environment? (Yes,

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

2010-12-29 Thread Branko Čibej
On 29.12.2010 09:43, Branko Čibej wrote: On 28.12.2010 23:13, Peter Samuelson wrote: [C. Michael Pilato] svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child svn_fspath__skip_ancestor svn_fspath__is_ancestor

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

2010-12-29 Thread Branko Čibej
On 29.12.2010 20:10, Kamesh Jayachandran wrote: Now I'm really mystified. When I added those location-tracing functions and macros, they were only ever enabled with SVN_DEBUG turned on (i.e., in maintainer-mode). Now I see that those #ifdef wrappers are gone, and can't recall an

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

2010-12-29 Thread Branko Čibej
On 29.12.2010 20:50, Peter Samuelson wrote: [Branko Cibej] Found it, r843793 and I agree with the change. So, effectively, svn_error__locate has been public since then, and r1053469 should be reverted anyway because it breaks the ABI. It doesn't break the ABI. I kept the function itself.

Re: svn commit: r1053996 [1/2] - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_diff/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_neon/ libsvn_ra_serf

2011-01-04 Thread Branko Čibej
On 04.01.2011 16:44, Bert Huijben wrote: -Original Message- From: Branko Čibej [mailto:br...@xbc.nu] Sent: dinsdag 4 januari 2011 16:27 To: dev@subversion.apache.org Subject: Re: svn commit: r1053996 [1/2] - in /subversion/trunk/subversion: include/ include/private/ libsvn_client

Re: svn commit: r1055452 - /subversion/trunk/tools/po/l10n-report.py

2011-01-05 Thread Branko Čibej
On 05.01.2011 14:00, danie...@apache.org wrote: Author: danielsh Date: Wed Jan 5 13:00:07 2011 New Revision: 1055452 URL: http://svn.apache.org/viewvc?rev=1055452view=rev Log: Add some helpful headers to l10-report.py's output. * tools/po/l10n-report.py (svn:keywords): Set to 'all'.

Re: fsfs's fs_serialized_init() not thread safe?

2011-01-09 Thread Branko Čibej
On 09.01.2011 21:09, Blair Zajac wrote: Wanted to confirm a reading of fs_serialized_init() in libsvn_fs_fs/fs.c in a persistent, multithreaded server. It appears that if fs_serialized_init() is called at the same time by two or more threads, then you would have a race on

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Branko Čibej
On 11.01.2011 16:01, Julian Foad wrote: I see a different issue here: The close_wcroot() call is normally handled from pool cleanup for users of the svn_client api. (The svn_wc_context_t is cached in the client context, which is only closed on pool cleanup). Thanks for pointing that out.

Re: headers in the body Re: [l10n] Translation status report for trunk r1057984

2011-01-12 Thread Branko Čibej
On 12.01.2011 15:01, Daniel Shahaf wrote: SVN DEV wrote on Wed, Jan 12, 2011 at 04:21:52 +: X-Mailer: l10n-report.py r1055713 Reply-To: dev@subversion.apache.org Mail-Followup-To: dev@subversion.apache.org Auto-Submitted: auto-generated Translation status report for tr...@r1057984 Looks

Re: svn commit: r1057088 - in /subversion/trunk/subversion: libsvn_fs_base/bdb/env.c libsvn_ra_svn/cyrus_auth.c libsvn_subr/io.c libsvn_subr/sqlite.c

2011-01-12 Thread Branko Čibej
On 12.01.2011 15:12, Daniel Shahaf wrote: Philip Martin wrote on Wed, Jan 12, 2011 at 11:01:12 +: danie...@apache.org writes: Author: danielsh Date: Mon Jan 10 06:03:30 2011 New Revision: 1057088 URL: http://svn.apache.org/viewvc?rev=1057088view=rev Log: Initialize svn_atomic_t's to

Re: headers in the body Re: [l10n] Translation status report for trunk r1057984

2011-01-12 Thread Branko Čibej
On 12.01.2011 16:47, Hyrum K Wright wrote: On Wed, Jan 12, 2011 at 8:14 AM, Branko Čibej br...@xbc.nu wrote: On 12.01.2011 15:01, Daniel Shahaf wrote: SVN DEV wrote on Wed, Jan 12, 2011 at 04:21:52 +: X-Mailer: l10n-report.py r1055713 Reply-To: dev@subversion.apache.org Mail-Followup

Re: headers in the body Re: [l10n] Translation status report for trunk r1057984

2011-01-12 Thread Branko Čibej
On 12.01.2011 18:43, Branko Čibej wrote: On 12.01.2011 16:47, Hyrum K Wright wrote: On Wed, Jan 12, 2011 at 8:14 AM, Branko Čibej br...@xbc.nu wrote: On 12.01.2011 15:01, Daniel Shahaf wrote: SVN DEV wrote on Wed, Jan 12, 2011 at 04:21:52 +: X-Mailer: l10n-report.py r1055713 Reply

Re: Ref-counting for pristine texts

2011-01-13 Thread Branko Čibej
On 13.01.2011 20:01, Julian Foad wrote: I have committed the ref counting for pristine texts (r1058523) and have had a bit more insight into when to perform the deletion. Deleting unreferenced texts on closing a wcroot is too late - too large a granularity - for the way the WC code is

Re: Coding goals / requirements.

2011-01-17 Thread Branko Čibej
On 17.01.2011 08:08, Gavin Beau Baumanis wrote: Is the answer not; Code to the manner that provides the greatest return on a developer's time for THIS problem. You have to take into account the cost of maintaining the code, too. For example, it's usually fastest to not worry about coupling

Re: Ref-counting for pristine texts

2011-01-17 Thread Branko Čibej
On 17.01.2011 14:45, Mark Phippard wrote: On Mon, Jan 17, 2011 at 8:14 AM, Julian Foad julian.f...@wandisco.com wrote: Just want to say thanks for your feedback, Brane. Due to other work commitments I may not have much time to take this forward over the next three weeks. Are you planning to

Re: Coding goals / requirements.

2011-01-17 Thread Branko Čibej
On 17.01.2011 23:07, Gavin Beau Baumanis wrote: Hi Brane, I certainly do take maintainability seriously. What's that well-quoted figure? Something like 80% of the cost of software development is spent in the development phase? I believe it's should be spent rather than is spent ... in

Re: Ref-counting for pristine texts

2011-01-18 Thread Branko Čibej
On 18.01.2011 16:58, Julian Foad wrote: On Thu, 2011-01-13, Branko Čibej wrote: This would indicate that the reference counting happens too soon ... in other words, that a pristine can be dereferenced whilst some part of the code (or database) still refers to it. That breaks database

Re: Ref-counting for pristine texts

2011-01-27 Thread Branko Čibej
On 27.01.2011 20:44, Julian Foad wrote: My thinking was that if I don't have a lock, I can't safely add a reference because another process might delete the text just before I get around to executing that statement. But in fact I don't necessarily need a WC lock, I need *either* a WC lock

Re: Merging /branches/integrate-cache-membuffer to /trunk

2011-01-28 Thread Branko Čibej
On 28.01.2011 05:56, Daniel Shahaf wrote: We could ask ASF infra to enable the optional feature on svn.eu (without enabling it on svn.us). The experimental code gets tested, and if it cooks the disk alive and burns the data then we (pay for a new disk and) svnsync svn.us to svn.eu :-) (Or do

Re: [Feature] New feature about handling 'HTTP Error 302 Movedtemporarily'?

2011-01-31 Thread Branko Čibej
On 31.01.2011 14:49, Bolstridge, Andrew wrote: -Original Message- From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] Sent: 28 January 2011 19:03 To: Bolstridge, Andrew Cc: dev@subversion.apache.org Subject: Re: [Feature] New feature about handling 'HTTP Error 302

Re: Deltifying directories on the server

2011-02-01 Thread Branko Čibej
You do know that diff and delta are two different beasts, and that the diff optimizations have no effect on deltas? :) The problem with directory deltification lies in the length of the delta chain and the frequency of directory lookup compared to file access. The sad fact is that our directory

Re: SQLite and callbacks

2011-02-05 Thread Branko Čibej
On 05.02.2011 15:35, Stefan Sperling wrote: On Sat, Feb 05, 2011 at 03:29:23PM +0100, Stefan Sperling wrote: I think we should strongly consider revving affected callbacks in the 1.7 API and document restriction they have to heed. Then we can bring the r1039808 code back. We can keep the code

Re: mark .svn folders to not get indexed

2011-02-06 Thread Branko Čibej
+1, this is a great idea. On 06.02.2011 10:42, Stefan Küng wrote: Hi, For some time now I've been looking for a way to configure the windows indexing service to not index the .svn folders. I wanted to do that in my installer for TSVN, but after countless hours of searching the web and

Re: SQLite and callbacks

2011-02-06 Thread Branko Čibej
On 05.02.2011 21:55, Johan Corveleyn wrote: On Sat, Feb 5, 2011 at 9:37 PM, Johan Corveleyn jcor...@gmail.com wrote: On Sat, Feb 5, 2011 at 7:14 PM, Stefan Sperling s...@elego.de wrote: On Sat, Feb 05, 2011 at 06:47:35PM +0100, Branko Čibej wrote: I would not worry about existing clients

Re: SQLite and callbacks

2011-02-07 Thread Branko Čibej
On 07.02.2011 02:52, Branko Čibej wrote: Note that I didn't run the tests with this patch, so I'm not claiming it to be bug-free. In fact there's one bug in the recursive proplist of the WC root, where the root props show up twice -- there's an issue with the filter in the query

Re: SQLite and callbacks

2011-02-07 Thread Branko Čibej
On 07.02.2011 21:51, Stefan Sperling wrote: A lot of wc databases out there will be so small that the user will hardly notice the memory increase. All we'd be doing is allowing sqlite to flush data to disk if needed. Even with a temporary table backed by a file, most operations happen in

Re: SQLite and callbacks

2011-02-08 Thread Branko Čibej
On 08.02.2011 16:34, Bert Huijben wrote: An even better solution would be that SQLite tries to do things completely in memory and only *creates* a tempfile when needed. (It seems it now creates the file anyway; but doesn't use it until needed. Introducing a heavy performance penalty on

Re: SQLite and callbacks

2011-02-08 Thread Branko Čibej
On 08.02.2011 18:13, Hyrum K Wright wrote: It shouldn't be difficult to create a large working copy ('svn co ^/subversion') and use that for testing, but getting more insight than just our own dataset would be very nice. Except that, as I noted elsewhere in this thread, even 'svn co

Re: SQLite and callbacks

2011-02-08 Thread Branko Čibej
On 07.02.2011 21:57, Stefan Sperling wrote: On Mon, Feb 07, 2011 at 09:32:48PM +0100, Branko Čibej wrote: On 07.02.2011 17:10, Stefan Sperling wrote: The bug is probabaly in the following query. Maybe the INSERT OR REPLACE doesn't work as intended? And why is COMMIT TRANSACTION commented, BTW

Re: SQLite and callbacks

2011-02-08 Thread Branko Čibej
On 08.02.2011 23:47, Stefan Sperling wrote: On Tue, Feb 08, 2011 at 11:37:16PM +0100, Branko Čibej wrote: On 08.02.2011 18:13, Hyrum K Wright wrote: It shouldn't be difficult to create a large working copy ('svn co ^/subversion') and use that for testing, but getting more insight than just

Re: SQLite and callbacks

2011-02-08 Thread Branko Čibej
On 08.02.2011 23:57, Branko Čibej wrote: On 08.02.2011 23:47, Stefan Sperling wrote: On Tue, Feb 08, 2011 at 11:37:16PM +0100, Branko Čibej wrote: On 08.02.2011 18:13, Hyrum K Wright wrote: It shouldn't be difficult to create a large working copy ('svn co ^/subversion') and use

Re: SQLite and callbacks

2011-02-08 Thread Branko Čibej
On 08.02.2011 23:50, Branko Čibej wrote: Well, here it is, I fixed the thinko in the actual_props query and got all prop_tests to pass with this version. Did I say that the way ACTUAL_NODE is separate from NODE makes these kinds of WC operations (that merge results from both tables) quite

Re: svn commit: r1069001 - in /subversion/trunk/subversion: libsvn_wc/wc_db.c libsvn_wc/wc_db.h tests/libsvn_wc/op-depth-test.c

2011-02-09 Thread Branko Čibej
On 09.02.2011 18:54, phi...@apache.org wrote: Author: philip Date: Wed Feb 9 17:54:02 2011 New Revision: 1069001 URL: http://svn.apache.org/viewvc?rev=1069001view=rev Log: The new revert is non-recursive in the database so remove the depth parameter. Allow actual-only revert. *

Re: Partially recursive revert when node kind changes

2011-02-10 Thread Branko Čibej
On 10.02.2011 17:43, C. Michael Pilato wrote: On 02/10/2011 11:28 AM, Philip Martin wrote: Suppose I have a directory tree: foo/ bar/ zig and I delete the tree foo/bar and replace it by a file foo/bar. What should svn revert --depth=files foo do? Should it revert foo/bar?

Re: libsvn_wc/merge.c:detranslate_wc_file EOL text conflicts

2011-02-11 Thread Branko Čibej
On 11.02.2011 19:38, Philip Martin wrote: Philip Martin philip.mar...@wandisco.com writes: Philip Martin philip.mar...@wandisco.com writes: But does cause 3 FAILs in merge_tests.py: FAIL: merge_tests.py 34: conflict markers should match the file's eol style FAIL: merge_tests.py 35: handle

Re: What is a baton from subversion sources?

2011-02-11 Thread Branko Čibej
On 11.02.2011 21:37, Daniel Becroft wrote: On Sat, Feb 12, 2011 at 6:07 AM, Grigory Petrov grigory@gmail.comwrote: Hello. I'm learning subversion API right now and examining it's source code and examples. It's a lot of things in subversion source code that is called a baton. For

Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite

2011-02-13 Thread Branko Čibej
On 13.02.2011 09:33, Daniel Shahaf wrote: +strncpy(orig_lc_all, setlocale(LC_ALL, NULL), sizeof orig_lc_all); sizeof() with parens please. Why? They're not necessary unless the sizeof operator (not function!) is applied to a type name. There's no ambiguity here at all. -- Brane

Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite

2011-02-13 Thread Branko Čibej
On 13.02.2011 17:44, Daniel Shahaf wrote: Branko Čibej wrote on Sun, Feb 13, 2011 at 16:10:03 +0100: On 13.02.2011 09:33, Daniel Shahaf wrote: +strncpy(orig_lc_all, setlocale(LC_ALL, NULL), sizeof orig_lc_all); sizeof() with parens please. Why? They're not necessary unless the sizeof

Re: [PATCH] extend the SVN_ERR macro with a cleanup statement parameter

2011-02-13 Thread Branko Čibej
On 13.02.2011 21:28, Bert Huijben wrote: -Original Message- From: Danny Trebbien [mailto:dtrebb...@gmail.com] Sent: zondag 13 februari 2011 21:00 To: Subversion Development Subject: [PATCH] extend the SVN_ERR macro with a cleanup statement parameter Attached is a small patch to

Re: Best way to issue a warning in a C test

2011-02-13 Thread Branko Čibej
On 13.02.2011 20:15, Danny Trebbien wrote: I also try the Windows-specific locale strings first because I know that a Linux system successfully ignores them. Does setlocale even have a real effect on Windows? Last time I looked, you couldn't change the per-process locale. -- Brane

Re: SQLite and callbacks

2011-02-14 Thread Branko Čibej
On 14.02.2011 13:37, Stefan Sperling wrote: On Tue, Feb 08, 2011 at 11:50:36PM +0100, Branko Čibej wrote: Well, here it is, I fixed the thinko in the actual_props query and got all prop_tests to pass with this version. Just FYI, the patch doesn't apply to HEAD. I'll try to adjust it when I

Re: Further diff optimization ideas

2011-02-15 Thread Branko Čibej
On 15.02.2011 01:42, Johan Corveleyn wrote: 2) Faster hash function for hashing lines. [ Quick win ] - Currently, we use adler32 (after the line has been normalized). - GNU diff uses some simple bit shifting scheme, which seems to be a lot faster (maybe it has more hash-collisions, but that

Re: SQLite and callbacks

2011-02-16 Thread Branko Čibej
On 16.02.2011 11:52, Philip Martin wrote: Stefan Sperling s...@elego.de writes: [[[ Improve performance of svn proplist in a similar way as was done in r1039808. But, this time, avoid problems with callbacks invoked during sqlite transactions by storing results in a temporary table and

Re: Pristine store - spec

2011-02-16 Thread Branko Čibej
On 16.02.2011 13:06, Daniel Shahaf wrote: Julian Foad wrote on Tue, Feb 15, 2011 at 15:06:43 +: * * This specification is conceptually simple, but requires completing disk * operations within SDB transactions, which may make it too inefficient * in practice. An alternative

Re: SQLite and callbacks

2011-02-16 Thread Branko Čibej
On 16.02.2011 19:25, Julian Foad wrote: On Tue, 2011-02-15, Stefan Sperling wrote: [[[ Improve performance of svn proplist in a similar way as was done in r1039808. But, this time, avoid problems with callbacks invoked during sqlite transactions by storing results in a temporary table and

Re: Restarting Apache during a commit through a proxy

2011-02-16 Thread Branko Čibej
On 16.02.2011 23:15, Philip Martin wrote: Blair Zajac bl...@orcaware.com writes: On 02/16/2011 08:44 AM, Philip Martin wrote: So if the timing is just right it's possible for one Apache process to start writing the transaction, for that process to stop, and for another process to take over

  1   2   3   4   5   6   7   8   9   10   >