Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/74
This has been merged to master branch
---
Github user poornachandra closed the pull request at:
https://github.com/apache/incubator-tephra/pull/74
---
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/72#discussion_r185069321
--- Diff:
tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java
---
@@ -78,6 +78,7 @@ protected void startUp
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/74
TEPHRA-266 Identify log messages when multiple instances of Tephra run on a
single HBase cluster
JIRA - https://issues.apache.org/jira/browse/TEPHRA-266
You can merge this pull
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/73
TEPHRA-267 Save the service reference in ReferenceCountedSupplier only if
startup is successful
JIRA - https://issues.apache.org/jira/browse/TEPHRA-267
You can merge this pull
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/72
TEPHRA-270 TEPHRA-271 Transaction state cache bug fixes
JIRA: https://issues.apache.org/jira/browse/TEPHRA-270
https://issues.apache.org/jira/browse/TEPHRA-271
This PR
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/71
@anew It would be good to commit this against JIRA TEPHRA-285, looks like
you intended to use that but ended up using TEPHRA-275
---
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal I spent some time on the tephra-hbase-compat-1.4 compat
module tests failure. It looks like the 1.4 compat module tests were never run
earlier. When you changed
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/63
@johnament We are planning for the next release of Tephra soon. Can you
take a look at the changes, so that this PR can be part of the next release?
---
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@joshelser There is nothing stopping us from moving Tephra to Java 8. Just
that we'll have to build consensus on the Tephra dev list, and it will add to
the delay of this PR
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal Since HBase-2.0 needs Java 8, let's try changing the compiler
for only HBase-2.0 compat module to use Java 8. We can still keep the other
modules as Java 7. I haven't
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal Just one more question
(https://github.com/apache/incubator-tephra/pull/67#discussion_r169503415).
Also the Java 7 build is failing for HBase 2.0 compat module
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r169503415
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/FilteredInternalScanner.java
---
@@ -0,0 +1,80
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r169195010
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/FilteredInternalScanner.java
---
@@ -0,0 +1,80
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r16679
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/FilteredInternalScanner.java
---
@@ -0,0 +1,80
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r16822
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/FilteredInternalScanner.java
---
@@ -0,0 +1,80
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160400229
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/TransactionAwareHTable.java
---
@@ -0,0 +1,729
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160405134
--- Diff:
tephra-hbase-compat-2.0/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionProcessorTest.java
---
@@ -0,0 +1,677
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160406273
--- Diff:
tephra-hbase-compat-2.0/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionProcessorTest.java
---
@@ -0,0 +1,677
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160397436
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -0,0 +1,182
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160407023
--- Diff:
tephra-hbase-compat-2.0/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionProcessorTest.java
---
@@ -0,0 +1,677
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160402855
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -0,0 +1,583
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160406873
--- Diff:
tephra-hbase-compat-2.0/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionProcessorTest.java
---
@@ -0,0 +1,677
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160398165
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -0,0 +1,182
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160403830
--- Diff:
tephra-hbase-compat-2.0/src/test/java/org/apache/tephra/hbase/AbstractHBaseTableTest.java
---
@@ -0,0 +1,106
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160400034
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/TransactionAwareHTable.java
---
@@ -0,0 +1,729
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160401932
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/TransactionAwareHTable.java
---
@@ -0,0 +1,729
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160404092
--- Diff:
tephra-hbase-compat-2.0/src/test/java/org/apache/tephra/hbase/TransactionAwareHTableTest.java
---
@@ -0,0 +1,1907
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/67#discussion_r160398641
--- Diff:
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/TransactionAwareHTable.java
---
@@ -0,0 +1,729
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal I'm taking a look at the PR. Meanwhile, the Travis build has
failed. Looks like there is some issue finding HBase 2.0 dependencies. Can you
take a look
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/63
@gokulavasan Do you have time to take this PR to completion?
---
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/45
Thanks for the contribution @bijugs!
---
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/62
@anew I have ported over the changes to other comapt modules, please take a
look
---
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/62#discussion_r140183601
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebugTool.java
---
@@ -204,16 +204,19
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/62#discussion_r140183636
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebugTool.java
---
@@ -165,10 +165,10
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/62
@anew I have ported the changes to other compat modules. Please take a look.
---
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/62#discussion_r139777982
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -56,15 +59,18
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/62
TEPHRA-245 Improve prune debug tool
JIRA - https://issues.apache.org/jira/browse/TEPHRA-245
Changes:
1. Improve documentation
2. Accept relative time as parameter
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/61#discussion_r139523472
--- Diff:
tephra-hbase-compat-1.0/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionVisibilityFilter.java
---
@@ -89,13 +89,13
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/58
I did a build and was able to see the new license and notice files in the
distribution jar.
Can we rename `LICENSE_RELEASE` to `LICENSE_DISTRIBUTION` and
`NOTICE_RELEASE
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/53#discussion_r138723289
--- Diff:
tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java
---
@@ -85,44 +99,20 @@ public long getTimestamp
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/53#discussion_r138720628
--- Diff:
tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java
---
@@ -134,57 +124,112 @@ private void
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138480498
--- Diff: tephra-core/src/main/thrift/transaction.thrift ---
@@ -73,15 +79,21 @@ service TTransactionServer {
// TODO remove
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138477861
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -206,12 +210,19 @@ public TransactionManager
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138238770
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionContext.java ---
@@ -311,25 +304,16 @@ private void persist() throws
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138239467
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionSystemClient.java ---
@@ -89,21 +89,38 @@
*
* @param tx
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138237949
--- Diff:
tephra-api/src/main/java/org/apache/tephra/TransactionConflictException.java ---
@@ -22,11 +22,50 @@
* Thrown to indicate
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138270921
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -853,46 +867,45 @@ private void advanceWritePointer(long
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138222710
--- Diff:
tephra-api/src/main/java/org/apache/tephra/TransactionConflictException.java ---
@@ -22,11 +22,50 @@
* Thrown to indicate
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/55#discussion_r137981943
--- Diff: tephra-hbase-compat-1.1-base/src/test/resources/logback-test.xml
---
@@ -0,0 +1,39
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/55#discussion_r137981906
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
@@ -384,7 +384,67
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/49#discussion_r137865504
--- Diff:
tephra-core/src/main/java/org/apache/tephra/distributed/TransactionService.java
---
@@ -121,15 +121,15 @@ public void failed(State
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r131594276
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -177,11 +173,23 @@ public void
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r131594887
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -177,11 +173,23 @@ public void
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/45
@bijugs Just one more comment to address -
https://github.com/apache/incubator-tephra/pull/45#discussion_r128894170
---
If your project is set up for it, you can reply to this email
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r128894190
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/TransactionAwareHTableTest.java
---
@@ -180,6 +182,7 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r128894187
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -56,17 +58,24 @@
private
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r128894170
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -56,17 +58,24 @@
private
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r126789926
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -56,17 +58,24 @@
private
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/45#discussion_r126789026
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
@@ -56,17 +58,24 @@
private
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/45
Thanks @bijugs, I'll continue the review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/44#discussion_r123363497
--- Diff:
tephra-core/src/test/java/org/apache/tephra/snapshot/SnapshotCodecTest.java ---
@@ -375,4 +386,17 @@ private void
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117851160
--- Diff:
tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceClient.java
---
@@ -125,15 +130,20 @@ public static void
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117841761
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java
---
@@ -35,13 +34,24 @@
import
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117834468
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java
---
@@ -35,13 +34,24 @@
import
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117552592
--- Diff:
tephra-hbase-compat-0.98/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -127,7 +126,7
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117552141
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -1378,17 +1403,32 @@ public TransactionType
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117338264
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -763,15 +781,22 @@ private long getNextWritePointer
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117129143
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -763,15 +781,22 @@ private long getNextWritePointer
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117127048
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -347,15 +346,17 @@ private void
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117121506
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionSystemClient.java ---
@@ -44,11 +44,33 @@
Transaction startShort(int
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117117388
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionSystemClient.java ---
@@ -44,11 +44,33 @@
Transaction startShort(int
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/43
TEPHRA-230 Fix reading of saved regions during invalid pruning run
JIRA - https://issues.apache.org/jira/browse/TEPHRA-230
You can merge this pull request into a Git repository
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/41
@gokulavasan Now that we have introduced class `ReferenceCountedSupplier`,
it would be good to use this class in `PruneUpperBoundWriterSupplier` too. It
will reduce code duplication
Github user poornachandra closed the pull request at:
https://github.com/apache/incubator-tephra/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/38
Merged this PR to branch release/0.11.0-incubating
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/38
@anew @chtyim I have addressed comments. Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/38#discussion_r102559503
--- Diff:
tephra-core/src/main/java/org/apache/tephra/txprune/TransactionPruningRunnable.java
---
@@ -57,8 +60,13 @@ public void run
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/38#discussion_r102366609
--- Diff:
tephra-core/src/main/java/org/apache/tephra/txprune/TransactionPruningRunnable.java
---
@@ -57,8 +60,13 @@ public void run
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/38#discussion_r102366454
--- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java ---
@@ -376,6 +376,11 @@
public static final String
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/38
TEPHRA-224 Handle delay between transaction max lifetime check and data
writes while pruning
JIRA - https://issues.apache.org/jira/browse/TEPHRA-224
You can merge this pull request
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102348853
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -1123,15 +1112,14 @@ private boolean
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/37
@anew @gokulavasan I have addressed the comments, please take another look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102127364
--- Diff:
tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102125886
--- Diff:
tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102123021
--- Diff:
tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/37
TEPHRA-223 Encapsulate the two data structures used for invalid
transactions to avoid update issues
JIRA - https://issues.apache.org/jira/browse/TEPHRA-223
Approach
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/35
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100940812
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -97,27 +101,33
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100940705
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -454,28 +442,38
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100931804
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -454,28 +441,39
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100932301
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -356,8 +356,8
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100931439
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -340,12 +345,7
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100931390
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -454,28 +441,39
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100709175
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -81,14 +84,23
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100709097
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -317,31 +317,31
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100709949
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -81,14 +84,23
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/34
@gokulavasan I have ported the changes to other compat modules, please take
a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/34
Thanks @anew. I will squash the commits and then port changes to other
compat modules.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/34
@anew @gokulavasan In addition to addressing comments, I have added two
more commits, please take a look
---
If your project is set up for it, you can reply to this email and have
1 - 100 of 186 matches
Mail list logo
