Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1152
I agree the failed CI build job does not look like it is related to the php
change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1148
Would you be able to rebase this on the current master and push? This
would kick a new build, and I would like to see it pass before merging anything.
---
If your project is set up for it, you
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1152
Not a php expert but this looks okay to me, however I would like to see it
pass CI. How do we trigger a new build on someone else's pull request?
Otherwise, if the original author could rebase
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1082
@jfarrell the Jira ticket was resolved as "Won't Fix" here; can you close
this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1031
Would it be possible to rebase this on master so we can get a clean CI
build? Also enabling unix socket transport in the "make cross" test would be
really nice to validate this code.
-
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1176
THRIFT-4065 fix SIGCHLD handling for perl ForkingServer and document
restrictions
This completes the work started in THRIFT-3848.
You can merge this pull request into a Git repository by running
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1172
So job #2 failed strangely in c_glib which is unrelated to this change.
I pushed an empty change to kick a rebuild. I expect it to clear...
Here's the job that failed:
https://travis
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1174
THRIFT-4043 ensure perl files do not end up in /usr/lib/Thrift
Without the mkdir, perl5 was being moved to /usr/lib directly, rather than
being moved INTO /usr/lib. This caused perl to go
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1171#discussion_r98771831
--- Diff: build/cmake/README-MSYS2.md ---
@@ -0,0 +1,63 @@
+
+
+# Building thrift on Windows (MinGW64/MSYS2)
+
+Thrift uses cmake to make
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1172
Going to add the ability to generate with cpp:no_ostream_operators to omit
definitions for ostream operators entirely (when set, declarations will still
be made, which means consuming
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1172#discussion_r98554132
--- Diff: compiler/cpp/src/thrift/generate/t_cpp_generator.cc ---
@@ -1117,7 +1129,7 @@ void
t_cpp_generator::generate_struct_declaration(ofstream&
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1172
THRIFT-4060 add better support in the cpp generator for custom ostream
operators on structures
This pull request adds support for an annotation that will disable the emit
code for operator
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1171#discussion_r98364736
--- Diff: build/cmake/README-MSYS2.md ---
@@ -0,0 +1,63 @@
+
+
+# Building thrift on Windows (MinGW64/MSYS2)
+
+Thrift uses cmake to make
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1171
THRIFT-4046 fix PlatformSocket.h for mingw64/msys2 and provide instructions
Instructions provided for building with cmake under that toolchain.
See build/cmake/README-MSYS2.md
You can
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/1170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1170
Closing; there are more MinGW issues that need to be handled holistically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1170
THRIFT-3993 fix build error with gcc 6.2 and mingw
We don't have a CI build that covers mingw and gcc 6.2 on windows... can
anybody else try this to see if it works?
You can merge this pull
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1065
Opened a new PR under https://github.com/apache/thrift/pull/1169. This can
be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1169
THRIFT-4045 Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix buildingâ¦
⦠with Address Sanitizer
Replaces GitHub Pull Request #1065
You can merge this pull request into a Git
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1065
I created THRIFT-4045 for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1166
I fixed the build job #17 issue with THRIFT-4044 so you can merge this or
rebase to get a clean build first.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1167
I fixed the build job #17 issue with THRIFT-4044 so you can merge this or
rebase to get a clean build first.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1168
THRIFT-4044 work around an hspec-core 2.4.0 library issue
Was causing all build job #17 on Travis CI to fail
You can merge this pull request into a Git repository by running:
$ git pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1166#discussion_r98337162
--- Diff: build/docker/centos6/Dockerfile ---
@@ -41,7 +41,9 @@ RUN yum install -y epel-release && \
&& yum clean all
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1166
Build job 17 has been failing due to a haskell issue fairly regularly. I
don't know how to fix it, but if we can clear it out it would be nice. :)
---
If your project is set up for it, you can
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1113
@jfarrell could you close this? We believe the issue has already been
addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1083
Hello - when I upgraded a project to thrift-0.10.0 I found I needed to
provide the operator << for enumerations. I am a bit concerned we're not
providing an operator >> as well; I th
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1121
Hello - please rebase on master and force push. I would like to see a CI
build pass before merging; save perhaps job #17 which has been failing.
---
If your project is set up for it, you can
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1164
Job 17 continues to fail on builds. Something to do with haskell. I am
going to ignore it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1164
THRIFT-3854 add a way in java to clear TFramedTransport read buffers
I took https://github.com/apache/thrift/pull/1081 and applied changes to
address the code comments.
You can merge this pull
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1081
I made the requested changes locally but I don't know if I can push on top
of this, so I will likely open a new pull request to obsolete this one.
---
If your project is set up for it, you can
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1081#discussion_r98086075
--- Diff:
lib/java/test/org/apache/thrift/transport/TestTFastFramedTransport.java ---
@@ -19,6 +19,8 @@
package org.apache.thrift.transport
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98002795
--- Diff: lib/c_glib/test/owncloud.level2crm.pem ---
@@ -0,0 +1,59 @@
+-BEGIN CERTIFICATE
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003039
--- Diff: configure.ac ---
@@ -199,6 +196,12 @@ if test "$with_c_glib" = "yes"; then
fi
AM_CONDITIONAL(WITH_C_GLIB, [test
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003689
--- Diff: lib/c_glib/test/Makefile.am ---
@@ -37,16 +37,17 @@ BUILT_SOURCES = \
gen-c_glib/t_test_thrift_test_types.h
AM_CPPFLAGS = -I
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003481
--- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h
---
@@ -0,0 +1,120 @@
+/*
--- End diff --
This looks a lot like
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003205
--- Diff: lib/c_glib/Makefile.am ---
@@ -45,6 +45,7 @@ libthrift_c_glib_la_SOURCES = src/thrift/c_glib/thrift.c \
src
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003634
--- Diff: lib/c_glib/test/CMakeLists.txt ---
@@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND
testoptionalrequired
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97858435
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1060
Would you be able to rebase this against master and force push an update?
This will kick off a new CI build. I would like to see the build pass before
merging into the project.
---
If your
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97841167
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/896
Hi, would you be able to rebase on the current master and squash the
commits, and force push? This will restart the CI build with our current
codebase so we know the change is still applicable
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97789162
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97708735
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/930
It looks like you merged instead of rebasing.
If memory serves you had 11 commits originally.
What I would recommend is that you:
1. git checkout master
2. git fetch upstream
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/930
We cannot merge it until it passes all CI builds.
Recommend you rebase against the current master, squash to a single commit,
and force push to get another build going.
---
If your project
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1116#discussion_r97323288
--- Diff:
lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java ---
@@ -93,7 +93,7 @@ public
TNonblockingServerSocket
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r97247885
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
src
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1162#discussion_r97203001
--- Diff: build/wincpp/build-thrift-compiler.bat ---
@@ -0,0 +1,80 @@
+::
+:: Licensed under the Apache License, Version 2.0 (the "Li
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1162#discussion_r97203010
--- Diff: build/wincpp/build-thrift-compiler.bat ---
@@ -0,0 +1,80 @@
+::
+:: Licensed under the Apache License, Version 2.0 (the "Li
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1162
THRIFT-3973: Provide some tools to make it easier to build thrift C++ on
Windows
As a contributor and committer on the project with a focus on C++ and
CMake, I needed a way to build thrift C
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1086
Looks good to me. I guess there is no TTransportException for the js
runtime? I'd like one other person more familiar with using the language to
approve then we can merge it in, like
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/326
This needs to be rebased against the current master and squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/325
@jfarrell this pull request is not necessary as the work was done in a
duplicate item.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/311
@jfarrell this pull request can be closed - I verified the code was merged
into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/226
This would need to be rebased and corrected, pass CI builds and code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1157
I'm okay making the default for plug-in support "OFF", and you have to
enable it specifically. Would it be okay to merge this as it fixes the ticket
as described, and open a new one
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1157
@jfarrell I'd like one review of this before I merge it. It did fix the
issue I had with the stock 0.10.0 debian package for the compiler not working.
---
If your project is set up for it, you
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1086
As-is the patch would require string parsing to get the statusCode which is
brittle. I like the overall direction of handling unexpected status code with
an exception; consider using a derived
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876704
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -101,9 +102,6 @@ THRIFT_ADD_COMPILER(xml "Enable compiler for XML"
ON)
# we also add t
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876857
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -16,30 +16,30 @@
# specific language governing permissions and limitations
# under the License
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876685
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
src
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1158
Given the Travis CI build passed, I am going to merge this into the
project. The AppVeyor CI getting stuck is unrelated. Folks who had failed
builds will need to rebase and resubmit once
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1157
THRIFT-4033 disable compiler plug-ins for standard debian build
as the thrift-compiler packaging is not ready for it yet
You can merge this pull request into a Git repository by running
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1128
There was just one issue on linux; I reverted a change in
TBufferTransports.h (I had converted an assert to an exception, but we can
figure out what to do with asserts holistically in THRIFT-3978
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r95604407
--- Diff: lib/cpp/src/thrift/windows/config.h ---
@@ -36,6 +36,9 @@
#define USE_BOOST_THREAD 1
#endif
+// Something that defines PRId64
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1128
Hi, I pushed fixes for the open issues however I need to make sure it still
builds on linux; my local build failed so it looks like there will be another
push to clean that up. Thanks for your
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r95217047
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -394,15 +411,19 @@ void THeaderTransport::setHeader(const string& key,
const st
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r95216695
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -375,7 +383,12 @@ void THeaderTransport::resetProtocol() {
}
uint32_t
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r94978623
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1098
@jfarrell should this be closed now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/1151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1151
This was merged into master as it fixed appveyor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1151
fix appveyor builds - ant version change
ANT version changed to 1.9.8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift fix
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r94495800
--- Diff: compiler/cpp/src/thrift/generate/t_erl_generator.cc ---
@@ -984,10 +988,13 @@ void t_erl_generator::export_types_string(string
name, int num
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88805388
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -394,15 +411,19 @@ void THeaderTransport::setHeader(const string& key,
const st
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804996
--- Diff: lib/cpp/test/JSONProtoTest.cpp ---
@@ -262,8 +262,9 @@ BOOST_AUTO_TEST_CASE(test_json_proto_8) {
":[\"i8\",3,1,2,3]},\"
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804989
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -375,7 +383,12 @@ void THeaderTransport::resetProtocol() {
}
uint32_t
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804934
--- Diff: compiler/cpp/src/thrift/thriftl.ll ---
@@ -39,11 +39,17 @@
#endif
#ifdef _MSC_VER
-//warning C4102: 'find_rule' : unreferenced
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804923
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -394,15 +411,19 @@ void THeaderTransport::setHeader(const string& key,
const st
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804076
--- Diff: compiler/cpp/src/thrift/generate/t_erl_generator.cc ---
@@ -968,10 +969,13 @@ void t_erl_generator::export_string(string name, int
num
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88571093
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -135,8 +141,9 @@ class THeaderTransport : public
TVirtualTransport<THeaderTransp
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88560045
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -18,6 +18,16 @@
#
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/version.h.in
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88559811
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -60,7 +60,7 @@
#endif // _WIN32
#endif
-#if defined(_WIN32
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1128
@ben-craig Thanks these are great comments, I will make some changes to
improve this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1117
I resolved the conflicts and committed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1101
@nsuke I simplified this one as you suggested, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1129
By moving the issue with NoStargeReadWriteMutex to THRIFT-3972 this became
much simpler and it ready for approval.
---
If your project is set up for it, you can reply to this email and have your
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1129#discussion_r87711314
--- Diff: lib/cpp/src/thrift/concurrency/Mutex.cpp ---
@@ -37,11 +37,10 @@ namespace concurrency {
#ifndef THRIFT_NO_CONTENTION_PROFILING
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1129
THRIFT-3038 clean up remaining volatile issues; remove unused
NoStarveReadWriteMutex class
This takes care of items 1, 3, and 6 in the PR description.
You can merge this pull request into a Git
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1128
THRIFT-3873: fix compiler warnings on windows with VS2010
Also changed VERSION to THRIFT_VERSION to avoid conflicts with third party
or OS headers.
You can merge this pull request into a Git
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1127
THRIFT-3947 use sockaddr_storage with getsockname for future transport
compatibility (ipv6)
There's also code in windows/SocketPair that uses sockaddr_in however that
code is using loopback so I
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1125#discussion_r87498574
--- Diff: lib/cpp/src/thrift/server/TConnectedClient.cpp ---
@@ -86,7 +86,8 @@ void TConnectedClient::run() {
} catch (const TException&
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1103
I decided to leave setDetached and not deprecate it. I don't see a reason
for someone to change from detachable to joinable (or the reverse) while
running but I believe all of the servers
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1122
Looks like a build system issue:
> Downloading unordered-containers-0.2.7.1...
> Failed to install network-uri-2.6.1.0
> Build log ( /root/.cabal/logs/network-uri-2.
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1123
THRIFT-3958: support RelWithDebInfo and static RTL on windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1122
THRIFT-3957: TConnectedClient does not disconnect from clients when their
timeout is reached
Fix per patches posted to Thrift Jira
You can merge this pull request into a Git repository by running
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
I think a number of those things are in the "reserved" keyword list for the
thrift compiler, so that's okay. Nice, I'll mark this one approved.
---
If your project is set up for it, you
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
I'm not seeing why JavaTypes was introduced - was it simply used to
manually check the build for output of every native type? Is the result from
JavaTypes compilation used in some unit test
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
Does the cmake install job need to be updated as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
801 - 900 of 1222 matches
Mail list logo
