buildbot failure in on tomcat-trunk

2018-11-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3784 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Container packaging

2018-11-23 Thread Mark Thomas
On 23/11/2018 12:57, Rémy Maucherat wrote: > On Fri, Nov 23, 2018 at 1:22 PM Mark Thomas wrote: >> This is a docker image, right? >> > > A bit. There are standard Tomcat images already > https://hub.docker.com/_/tomcat/ but they are more complex. > So this one is a Maven pom to get an

svn commit: r1847326 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 23:08:41 2018 New Revision: 1847326 URL: http://svn.apache.org/viewvc?rev=1847326=rev Log: Fix IDE nags Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java Modified:

svn commit: r1847324 [3/3] - in /tomcat/trunk/java: javax/el/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connector/ org/apache

2018-11-23 Thread markt
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/LocalStrings_fr.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/LocalStrings_fr.properties?rev=1847324=1847323=1847324=diff

svn commit: r1847324 [1/3] - in /tomcat/trunk/java: javax/el/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connector/ org/apache

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 23:06:23 2018 New Revision: 1847324 URL: http://svn.apache.org/viewvc?rev=1847324=rev Log: Update French translations Added: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/LocalStrings_fr.properties (with props) Modified:

svn commit: r1847324 [2/3] - in /tomcat/trunk/java: javax/el/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connector/ org/apache

2018-11-23 Thread markt
Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/LocalStrings_fr.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/tipis/LocalStrings_fr.properties?rev=1847324=1847323=1847324=diff

Re: svn commit: r1847318 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java w

2018-11-23 Thread Mark Thomas
On 23/11/2018 21:18, schu...@apache.org wrote: > Author: schultz > Date: Fri Nov 23 21:18:48 2018 > New Revision: 1847318 > > URL: http://svn.apache.org/viewvc?rev=1847318=rev > Log: > Fix EncryptInterceptor to be thread-safe. > Add multi-threaded unit test. Calling setProviderName() while the

svn commit: r1847323 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 21:43:15 2018 New Revision: 1847323 URL: http://svn.apache.org/viewvc?rev=1847323=rev Log: Remove unnecessary throws Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java Modified:

svn commit: r1847322 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 21:35:00 2018 New Revision: 1847322 URL: http://svn.apache.org/viewvc?rev=1847322=rev Log: Silence a false positive Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL:

svn commit: r1847321 - /tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 21:34:41 2018 New Revision: 1847321 URL: http://svn.apache.org/viewvc?rev=1847321=rev Log: Make code easier to check for correctness Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java Modified:

svn commit: r1847320 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-11-23 Thread schultz
Author: schultz Date: Fri Nov 23 21:25:37 2018 New Revision: 1847320 URL: http://svn.apache.org/viewvc?rev=1847320=rev Log: Simplify. Re-name method that no longer actually initializes any ciphers. Modified:

svn commit: r1847319 - /tomcat/trunk/test/org/apache/coyote/http2/TestAsync.java

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 21:23:14 2018 New Revision: 1847319 URL: http://svn.apache.org/viewvc?rev=1847319=rev Log: Add some debug code to help diagnose intermittent test failures Modified: tomcat/trunk/test/org/apache/coyote/http2/TestAsync.java Modified:

svn commit: r1847318 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java webap

2018-11-23 Thread schultz
Author: schultz Date: Fri Nov 23 21:18:48 2018 New Revision: 1847318 URL: http://svn.apache.org/viewvc?rev=1847318=rev Log: Fix EncryptInterceptor to be thread-safe. Add multi-threaded unit test. Modified:

buildbot success in on tomcat-trunk

2018-11-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3781 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1847310 - /tomcat/trunk/java/org/apache/coyote/http2/Stream.java

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 19:50:33 2018 New Revision: 1847310 URL: http://svn.apache.org/viewvc?rev=1847310=rev Log: Simplify code Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java URL:

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
One correction: using openssl s_client correctly does not hang. Only curl build with OpenSSL hangs. I tried my old curl builds and it seems it starts to hang with curl 7.24.0. Version 7.23.1 does not hang. The OpenSSL lib version on the client side does not seem to matter. I'll do some more

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
Short addition: When using Apache httpd 2.4.37 build with OpenSSL 1.1.1a, there are no hangs with TLS 1.0. So it seems we have a relevant difference in our server-side use of the OpenSSL API. Easy to reproduce, but not easy to debug ... Regards, Rainer Am 23.11.2018 um 15:50 schrieb Rainer

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
Am 23.11.2018 um 14:54 schrieb Mark Thomas: Hi all, Given bugs 62662 and 62944, I plan to tag 1.2.19 early next week with a view to including 1.2.19 in the next round of Tomcat releases. I observed a problem with TLS 1.0 under the following conditions: - using 9.0.13 with NIO plus tcnative

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rémy Maucherat
On Fri, Nov 23, 2018 at 2:54 PM Mark Thomas wrote: > Hi all, > > Given bugs 62662 and 62944, I plan to tag 1.2.19 early next week with a > view to including 1.2.19 in the next round of Tomcat releases. > +1 Rémy

svn commit: r1847270 - /tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 14:01:14 2018 New Revision: 1847270 URL: http://svn.apache.org/viewvc?rev=1847270=rev Log: Add BZ 62892 to change log Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml URL:

[Bug 62892] Memory leak when performing client certificate validation with OCSP

2018-11-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62892 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Tagging Tomcat Native 1.2.19

2018-11-23 Thread Mark Thomas
Hi all, Given bugs 62662 and 62944, I plan to tag 1.2.19 early next week with a view to including 1.2.19 in the next round of Tomcat releases. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

buildbot failure in on tomcat-trunk

2018-11-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3780 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1847260 - /tomcat/trunk/java/org/apache/catalina/core/StandardService.java

2018-11-23 Thread remm
Author: remm Date: Fri Nov 23 12:58:58 2018 New Revision: 1847260 URL: http://svn.apache.org/viewvc?rev=1847260=rev Log: Fix thread configuration for the utility threads. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java Modified:

Re: Container packaging

2018-11-23 Thread Rémy Maucherat
On Fri, Nov 23, 2018 at 1:22 PM Mark Thomas wrote: > On 22/11/2018 15:45, Rémy Maucherat wrote: > > Hi, > > > > After a bit of experimenting, the docker image works well, and is nicer > > (IMO) to configure and customize with the embedded updates from 9.0.14. I > > have verified that Kubernetes

[Bug 62944] Enabling TLSv1.3 with the APR connector breaks TLSv1.0 and TLSv1.1

2018-11-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62944 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1847259 - in /tomcat/native/trunk: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 12:43:07 2018 New Revision: 1847259 URL: http://svn.apache.org/viewvc?rev=1847259=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62944 Fix copy/paste error that prevented TLS 1.0 and TLS 1.1 from being used if TLS 1.3 was available. Patch provided by

Re: svn commit: r1846116 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/tomcat/util/threads/ test/org/apache/catalina/mbeans/ webapps/docs/ webapps/docs/c

2018-11-23 Thread Rémy Maucherat
On Fri, Nov 23, 2018 at 1:05 PM Mark Thomas wrote: > On 08/11/2018 10:17, r...@apache.org wrote: > > Author: remm > > Date: Thu Nov 8 10:17:43 2018 > > New Revision: 1846116 > > > > URL: http://svn.apache.org/viewvc?rev=1846116=rev > > Log: > > Add a scheduled executor service to the Service,

Re: Container packaging

2018-11-23 Thread Mark Thomas
On 22/11/2018 15:45, Rémy Maucherat wrote: > Hi, > > After a bit of experimenting, the docker image works well, and is nicer > (IMO) to configure and customize with the embedded updates from 9.0.14. I > have verified that Kubernetes based discovery works without being too > difficult to

Re: svn commit: r1846116 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/tomcat/util/threads/ test/org/apache/catalina/mbeans/ webapps/docs/ webapps/docs/c

2018-11-23 Thread Mark Thomas
On 08/11/2018 10:17, r...@apache.org wrote: > Author: remm > Date: Thu Nov 8 10:17:43 2018 > New Revision: 1846116 > > URL: http://svn.apache.org/viewvc?rev=1846116=rev > Log: > Add a scheduled executor service to the Service, which can be used to process > utility tasks including periodic

[Bug 62945] JarScanFilter with tldSkip in context.xml still produce INFO msg. if one jar is scanned due to another reason

2018-11-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62945 Remy Maucherat changed: What|Removed |Added Resolution|--- |INVALID OS|

[Bug 62945] New: JarScanFilter with tldSkip in context.xml still produce INFO msg. if one jar is scanned due to another reason

2018-11-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62945 Bug ID: 62945 Summary: JarScanFilter with tldSkip in context.xml still produce INFO msg. if one jar is scanned due to another reason Product: Tomcat 9 Version:

[Bug 62944] New: Enabling TLSv1.3 with the APR connector breaks TLSv1.0 and TLSv1.1

2018-11-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62944 Bug ID: 62944 Summary: Enabling TLSv1.3 with the APR connector breaks TLSv1.0 and TLSv1.1 Product: Tomcat Native Version: 1.2.18 Hardware: PC OS: Linux

svn commit: r1847239 - in /tomcat/trunk/java: javax/el/ org/apache/catalina/authenticator/ org/apache/catalina/core/ org/apache/catalina/filters/ org/apache/catalina/ha/deploy/ org/apache/catalina/rea

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 09:53:29 2018 New Revision: 1847239 URL: http://svn.apache.org/viewvc?rev=1847239=rev Log: German translation updates Added: tomcat/trunk/java/javax/el/LocalStrings_de.properties (with props)

svn commit: r1847238 - in /tomcat/trunk: java/org/apache/catalina/authenticator/jaspic/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org/ap

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 09:52:24 2018 New Revision: 1847238 URL: http://svn.apache.org/viewvc?rev=1847238=rev Log: Russian translation updates Added: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_ru.properties (with props)

svn commit: r1847237 - in /tomcat/trunk: java/org/apache/coyote/LocalStrings_ko.properties webapps/docs/changelog.xml

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 09:47:09 2018 New Revision: 1847237 URL: http://svn.apache.org/viewvc?rev=1847237=rev Log: Korean translation updates Modified: tomcat/trunk/java/org/apache/coyote/LocalStrings_ko.properties tomcat/trunk/webapps/docs/changelog.xml Modified:

svn commit: r1847236 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/ha/deploy/ java/org/apache/catalin

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 09:44:51 2018 New Revision: 1847236 URL: http://svn.apache.org/viewvc?rev=1847236=rev Log: Simplified Chinese translation updates Modified: tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_zh_CN.properties

svn commit: r1847235 - in /tomcat/trunk/java/org/apache: catalina/filters/ catalina/ha/deploy/ catalina/mapper/ catalina/startup/ catalina/tribes/group/interceptors/ catalina/tribes/io/ catalina/tribe

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 09:38:07 2018 New Revision: 1847235 URL: http://svn.apache.org/viewvc?rev=1847235=rev Log: Spanish translation updates Added: tomcat/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings_es.properties (with props) Modified:

svn commit: r1847233 [1/3] - in /tomcat/trunk: java/javax/el/ java/javax/servlet/ java/javax/servlet/http/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/authenticator/jaspic/ java/o

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 09:33:46 2018 New Revision: 1847233 URL: http://svn.apache.org/viewvc?rev=1847233=rev Log: More French translations along with a handful of corrections/improvements. Added: tomcat/trunk/java/org/apache/catalina/storeconfig/LocalStrings_fr.properties (with

svn commit: r1847233 [3/3] - in /tomcat/trunk: java/javax/el/ java/javax/servlet/ java/javax/servlet/http/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/authenticator/jaspic/ java/o

2018-11-23 Thread markt
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties?rev=1847233=1847232=1847233=diff

svn commit: r1847233 [2/3] - in /tomcat/trunk: java/javax/el/ java/javax/servlet/ java/javax/servlet/http/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/authenticator/jaspic/ java/o

2018-11-23 Thread markt
Modified: tomcat/trunk/java/org/apache/catalina/startup/LocalStrings_fr.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/LocalStrings_fr.properties?rev=1847233=1847232=1847233=diff

svn commit: r1847230 - /tomcat/trunk/java/org/apache/catalina/startup/LocalStrings_zh_CN.properties

2018-11-23 Thread markt
Author: markt Date: Fri Nov 23 09:26:07 2018 New Revision: 1847230 URL: http://svn.apache.org/viewvc?rev=1847230=rev Log: Fix escaping of single quotes Modified: tomcat/trunk/java/org/apache/catalina/startup/LocalStrings_zh_CN.properties Modified: