https://issues.apache.org/bugzilla/show_bug.cgi?id=50933
Rainer Jung changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Noticing that e maintain two copies of jarsToSkip lists, one in
catalina.properties and one in TomcatBaseTest, I was thinking about a
test case to compare the two. I then stumbled over our
catalina.properties "copy" in the startup package, which doesn't have a
jarsToSkip at all.
File java/org/apac
https://issues.apache.org/bugzilla/show_bug.cgi?id=51423
Bug #: 51423
Summary: [Patch] to add a path and a version parameters to the
list command
Product: Tomcat 7
Version: trunk
Platform: All
OS/Version: All
https://issues.apache.org/bugzilla/show_bug.cgi?id=51423
Mark Thomas changed:
What|Removed |Added
Attachment #27196|0 |1
is patch|
https://issues.apache.org/bugzilla/show_bug.cgi?id=51425
Bug #: 51425
Summary: Spanish translation "_es.properties" files
Product: Tomcat 7
Version: trunk
Platform: All
OS/Version: All
Status: NEW
Severity: enhan
On 23.06.2011 09:42, Rainer Jung wrote:
> Noticing that e maintain two copies of jarsToSkip lists, one in
> catalina.properties and one in TomcatBaseTest, I was thinking about a
> test case to compare the two. I then stumbled over our
> catalina.properties "copy" in the startup package, which doesn
Author: markt
Date: Thu Jun 23 09:00:51 2011
New Revision: 1138776
URL: http://svn.apache.org/viewvc?rev=1138776&view=rev
Log:
Revert r1137753 - I have a better soution in mind
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified: tomcat/trunk/java/org/apache/c
Author: markt
Date: Thu Jun 23 09:26:10 2011
New Revision: 1138788
URL: http://svn.apache.org/viewvc?rev=1138788&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51395
Better fix for memory leak that aligns ContextConfig with TldConfig
Modified:
tomcat/trunk/java/org/apach
Author: markt
Date: Thu Jun 23 09:31:10 2011
New Revision: 1138789
URL: http://svn.apache.org/viewvc?rev=1138789&view=rev
Log:
Don't cache xml parsing config locally, get it from the Context
Modified:
tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java
Modified: tomcat/trunk/java/or
Author: markt
Date: Thu Jun 23 09:31:39 2011
New Revision: 1138791
URL: http://svn.apache.org/viewvc?rev=1138791&view=rev
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java
URL:
On 23/06/2011 08:42, Rainer Jung wrote:
> Noticing that e maintain two copies of jarsToSkip lists, one in
> catalina.properties and one in TomcatBaseTest, I was thinking about a
> test case to compare the two. I then stumbled over our
> catalina.properties "copy" in the startup package, which doesn
Author: rjung
Date: Thu Jun 23 10:57:18 2011
New Revision: 1138825
URL: http://svn.apache.org/viewvc?rev=1138825&view=rev
Log:
Remove redundant copy of catalina.properties from
o.a.c.startup. Generate this copy for inclusion in
bin and src jars during the ant "compile" task.
Removed:
tomcat/t
Author: rjung
Date: Thu Jun 23 11:01:02 2011
New Revision: 1138828
URL: http://svn.apache.org/viewvc?rev=1138828&view=rev
Log:
Use system properties loaded from catalina.properties
via the class path in unit tests.
Modified:
tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
On 23.06.2011 11:40, Mark Thomas wrote:
> On 23/06/2011 08:42, Rainer Jung wrote:
>> Noticing that e maintain two copies of jarsToSkip lists, one in
>> catalina.properties and one in TomcatBaseTest, I was thinking about a
>> test case to compare the two. I then stumbled over our
>> catalina.propert
Author: rjung
Date: Thu Jun 23 11:27:57 2011
New Revision: 1138835
URL: http://svn.apache.org/viewvc?rev=1138835&view=rev
Log:
Remove unnecessary variable BASEDIR from scripts.
Modified:
tomcat/trunk/bin/catalina.bat
tomcat/trunk/bin/catalina.sh
tomcat/trunk/bin/setclasspath.bat
t
On 21.06.2011 11:40, Konstantin Kolinko wrote:
> 2011/6/20 Rainer Jung :
>> 1) Renaming
>>
>> Since quite some time now the setclasspath script doesn't have anything
>> to do with setting a class path. It only searches for JRE / JDK and sets
>> up the path to the Java or JDB binary plus JAVA_ENDORS
Since OneLineFormatter now uses the DateFormatCache util class, and to
prevent any dependency of juli form other packages that util class sits
in juli, what do we think about using it also in AccessLogValve?
At the moment the valve has a local copy as an inner class. Of course a
dependency on juli
Author: markt
Date: Thu Jun 23 11:44:39 2011
New Revision: 1138839
URL: http://svn.apache.org/viewvc?rev=1138839&view=rev
Log:
Move the statics out of the "instance variable" section
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified: tomcat/trunk/java/org/ap
https://issues.apache.org/bugzilla/show_bug.cgi?id=51423
Mark Thomas changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #1 from Mark Th
Author: rjung
Date: Thu Jun 23 12:08:31 2011
New Revision: 1138847
URL: http://svn.apache.org/viewvc?rev=1138847&view=rev
Log:
Follow-up to r1137925:
Use buf.add(char) when there is a single character string.
Modified:
tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
tomca
Modified:
tomcat/trunk/java/org/apache/catalina/startup/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/LocalStrings_es.properties?rev=1138849&r1=1138848&r2=1138849&view=diff
===
https://issues.apache.org/bugzilla/show_bug.cgi?id=51425
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=51426
Bug #: 51426
Summary: SSL connection failed with jvm mode
Product: Tomcat 5
Version: 5.5.33
Platform: PC
Status: NEW
Severity: major
Priority: P2
On 06/22/2011 08:44 PM, Mark Thomas wrote:
On 22/06/2011 17:43, jean-frederic clere wrote:
On 06/22/2011 03:56 PM, [email protected] wrote:
Author: markt
Date: Wed Jun 22 13:56:05 2011
New Revision: 1138468
URL: http://svn.apache.org/viewvc?rev=1138468&view=rev
Log:
Vote
Modified:
tomcat
Author: rjung
Date: Thu Jun 23 13:50:40 2011
New Revision: 1138880
URL: http://svn.apache.org/viewvc?rev=1138880&view=rev
Log:
Improve JMX unit test.
Modified:
tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trun
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400
--- Comment #9 from Konstantin Preißer 2011-06-23 14:08:49 UTC
---
Hi,
would caching charset misses be a good idea, if the Encoding strings can also
be received from external sources?
For example, if a client makes a POST request to a Se
https://issues.apache.org/bugzilla/show_bug.cgi?id=33262
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|
Rainer,
On 6/23/2011 7:33 AM, Rainer Jung wrote:
> On 21.06.2011 11:40, Konstantin Kolinko wrote:
>> 2011/6/20 Rainer Jung :
>>> 1) Renaming
>>>
>>> Since quite some time now the setclasspath script doesn't have anything
>>> to do with setting a class path. It only searches for JRE / JDK and sets
At the moment the file globs we support in the loader definitions in
catalina.properties are hard coded to DIRECTORY/*.jar.
Sometimes it would be helpful to allow a bit more flexible globs, like
e.g. log4j-1.2.*.jar or similar.
Would there be any interest if I would investigate whether we can use
Hi Chris,
On 23.06.2011 16:29, Christopher Schultz wrote:
> Rainer,
>
> On 6/23/2011 7:33 AM, Rainer Jung wrote:
>> On 21.06.2011 11:40, Konstantin Kolinko wrote:
>>> 2011/6/20 Rainer Jung :
1) Renaming
Since quite some time now the setclasspath script doesn't have anything
to
On 23.06.2011 16:34, Rainer Jung wrote:
> At the moment the file globs we support in the loader definitions in
> catalina.properties are hard coded to DIRECTORY/*.jar.
>
> Sometimes it would be helpful to allow a bit more flexible globs, like
> e.g. log4j-1.2.*.jar or similar.
>
> Would there be
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400
--- Comment #10 from Christopher Schultz
2011-06-23 14:47:42 UTC ---
> would caching charset misses be a good idea, if the Encoding strings can also
> be received from external sources?
+1 to Konstantin Preißer's DOS concerns.
> However,
Rainer,
On 6/23/2011 10:39 AM, Rainer Jung wrote:
> Globs in the file name and not
> the directory part is the most important use case and easy to understand
> in its consequences. So I lean towards this type of improvement right now.
So:
/path/to/*.jar (allowed today)
/path/to/foo*.ja
https://issues.apache.org/bugzilla/show_bug.cgi?id=51426
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400
--- Comment #11 from Konstantin Preißer 2011-06-23 15:25:01
UTC ---
Hi Christopher,
(In reply to comment #10)
> If you read some of the online posts linked from this BZ issue, you'll see
> claims that pre-populating such a cache does not
https://issues.apache.org/bugzilla/show_bug.cgi?id=33262
Mladen Turk changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID
On 23.06.2011 16:51, Christopher Schultz wrote:
> Rainer,
>
> On 6/23/2011 10:39 AM, Rainer Jung wrote:
>> Globs in the file name and not
>> the directory part is the most important use case and easy to understand
>> in its consequences. So I lean towards this type of improvement right now.
>
> S
https://issues.apache.org/bugzilla/show_bug.cgi?id=36362
Mark Thomas changed:
What|Removed |Added
Severity|enhancement |normal
--- Comment #4 from Mark Thom
Author: markt
Date: Thu Jun 23 15:51:55 2011
New Revision: 1138950
URL: http://svn.apache.org/viewvc?rev=1138950&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36362
Handle the case where tag file attributes (which can use any valid XML name)
have a name which is a Java iden
Author: markt
Date: Thu Jun 23 15:54:43 2011
New Revision: 1138953
URL: http://svn.apache.org/viewvc?rev=1138953&view=rev
Log:
Add important missing word
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tom
Author: markt
Revision: 1138950
Modified property: svn:log
Modified: svn:log at Thu Jun 23 15:55:51 2011
--
--- svn:log (original)
+++ svn:log Thu Jun 23 15:55:51 2011
@@ -1,2 +1,2 @@
Fix https://issues.apache.org/bugzill
Author: markt
Date: Thu Jun 23 15:57:07 2011
New Revision: 1138954
URL: http://svn.apache.org/viewvc?rev=1138954&view=rev
Log:
Proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1
Author: markt
Date: Thu Jun 23 15:57:25 2011
New Revision: 1138956
URL: http://svn.apache.org/viewvc?rev=1138956&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
https://issues.apache.org/bugzilla/show_bug.cgi?id=36362
--- Comment #5 from Mark Thomas 2011-06-23 15:57:48 UTC ---
Fixed in 7.0.x and will be included in 7.0.17 onwards.
Proposed for 6.0.x and 5.5.x.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You
And this would be the patch:
http://people.apache.org/~rjung/patches/tc7-loader-glob.patch
Regards,
Rainer
On 23.06.2011 16:39, Rainer Jung wrote:
> On 23.06.2011 16:34, Rainer Jung wrote:
>> At the moment the file globs we support in the loader definitions in
>> catalina.properties are hard co
2011/6/23 Rainer Jung :
> At the moment the file globs we support in the loader definitions in
> catalina.properties are hard coded to DIRECTORY/*.jar.
>
> Sometimes it would be helpful to allow a bit more flexible globs, like
> e.g. log4j-1.2.*.jar or similar.
>
> Would there be any interest if I
https://issues.apache.org/bugzilla/show_bug.cgi?id=33262
--- Comment #6 from Konstantin Kolinko 2011-06-23
18:06:07 UTC ---
Installing it for the current user feels wrong to me. What if there are several
Admins?
Anyway, as a first step, installing it could be made optional. Interested users
ca
Author: markt
Date: Thu Jun 23 18:27:39 2011
New Revision: 1139029
URL: http://svn.apache.org/viewvc?rev=1139029&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=33262
Install monitor to auto-start for current user only rather than all users to be
consistent with menu item cre
https://issues.apache.org/bugzilla/show_bug.cgi?id=33262
--- Comment #7 from Mark Thomas 2011-06-23 18:18:14 UTC ---
I was planning on tackling this along with bug 40510. i.e., make this use HKCU
and then add an option to install for current or all users.
Moving entries from the registry to the
https://issues.apache.org/bugzilla/show_bug.cgi?id=33262
--- Comment #8 from Mark Thomas 2011-06-23 18:28:25 UTC ---
Fixed in 7.0.x for 7.0.17 onwards.
Will be proposed for back-port as a package once the fixes for bug 40510 and
bug 50949 are complete.
--
Configure bugmail: https://issues.apac
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400
--- Comment #12 from Christopher Schultz
2011-06-23 20:02:11 UTC ---
> > I suppose it's a fairly small set of encodings, but with little benefit,
> > there's no reason IMO to pre-populate.
>
> You're right; however if I read the reports co
On 23.06.2011 19:46, Konstantin Kolinko wrote:
> 2011/6/23 Rainer Jung :
>> At the moment the file globs we support in the loader definitions in
>> catalina.properties are hard coded to DIRECTORY/*.jar.
>>
>> Sometimes it would be helpful to allow a bit more flexible globs, like
>> e.g. log4j-1.2.*
Rainer,
On 6/23/2011 4:02 PM, Rainer Jung wrote:
> But supporting a glob in the file name would also work.
I'm always irritated when something that looks like it should work
doesn't work. The fact that .../*.jar works but .../foo*.jar does not
work is surprising, so I'm in support of adding filen
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400
--- Comment #13 from Konstantin Preißer 2011-06-23 20:24:24
UTC ---
Created attachment 27202
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27202
Patch to prepopulate available charsets
I made a example of a patch which uses a
Author: schultz
Date: Thu Jun 23 20:33:01 2011
New Revision: 1139067
URL: http://svn.apache.org/viewvc?rev=1139067&view=rev
Log:
Votes
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=11
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400
--- Comment #14 from Christopher Schultz
2011-06-23 20:44:01 UTC ---
Thanks for the patch -- it looks just fine.
If you wanted to, you could even remove the explicit use of SortedMap and just
use "Charset.availableCharsets().entrySet()" a
Author: markt
Date: Thu Jun 23 22:01:41 2011
New Revision: 1139087
URL: http://svn.apache.org/viewvc?rev=1139087&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=40510
Provide an option to install shortcuts for the current user or all users. Also
ensure registry is correctly c
https://issues.apache.org/bugzilla/show_bug.cgi?id=40510
--- Comment #3 from Mark Thomas 2011-06-23 22:02:35 UTC ---
This has been fixed for 7.0.x and will be included in 7.0.17 onwards.
It will be proposed for back-port in a package along with bug 33363 and bug
50949.
--
Configure bugmail: ht
Author: markt
Date: Thu Jun 23 22:25:12 2011
New Revision: 1139098
URL: http://svn.apache.org/viewvc?rev=1139098&view=rev
Log:
Remove inaccurate comment
Modified:
tomcat/trunk/res/tomcat.nsi
Modified: tomcat/trunk/res/tomcat.nsi
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/tomcat.nsi?
On 23/06/2011 23:25, [email protected] wrote:
> Author: markt
> Date: Thu Jun 23 22:25:12 2011
> New Revision: 1139098
>
> URL: http://svn.apache.org/viewvc?rev=1139098&view=rev
> Log:
> Remove inaccurate comment
>
> Modified:
> tomcat/trunk/res/tomcat.nsi
>
> Modified: tomcat/trunk/res/tomca
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1878
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
Author: markt
Date: Thu Jun 23 22:35:22 2011
New Revision: 1139101
URL: http://svn.apache.org/viewvc?rev=1139101&view=rev
Log:
Use a function to start the service so the service name can be changed during
the install
Modified:
tomcat/trunk/res/tomcat.nsi
Modified: tomcat/trunk/res/tomcat.ns
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1879
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
Author: markt
Date: Thu Jun 23 23:24:36 2011
New Revision: 1139117
URL: http://svn.apache.org/viewvc?rev=1139117&view=rev
Log:
Prep for fixing https://issues.apache.org/bugzilla/show_bug.cgi?id=50949
Use a variable for the service name and ensure the uninstaller still works
Modified:
tomcat/t
Author: rjung
Date: Fri Jun 24 05:33:35 2011
New Revision: 1139157
URL: http://svn.apache.org/viewvc?rev=1139157&view=rev
Log:
Remove dead code and correct comment about
thread-safetyness.
Modified:
tomcat/trunk/java/org/apache/juli/DateFormatCache.java
Modified: tomcat/trunk/java/org/apache
Author: rjung
Date: Fri Jun 24 05:39:19 2011
New Revision: 1139158
URL: http://svn.apache.org/viewvc?rev=1139158&view=rev
Log:
Correctly support 'S' and 'SSS' in SimpleDateFormat
timestamps for the AccessLogValve.
We prefer "msec_frac" as documented, but the common
other cases should at least wor
On Fri, Jun 24, 2011 at 12:27 AM, Mark Thomas wrote:
>> + !define MUI_FINISHPAGE_RUN_FUNCTION "StartService"
>> $INSTDIR\bin\tomcat@[email protected]
>
> Sorry about this random line. I'll fix it in the next commit
>
Does it mean that the service will be always started when the install finish
67 matches
Mail list logo
