Re: svn commit: r1145383 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2011-07-11 Thread Felix Schumacher
Hi Mark, ma...@apache.org schrieb: >Author: markt >Date: Mon Jul 11 22:27:06 2011 >New Revision: 1145383 > >URL: http://svn.apache.org/viewvc?rev=1145383&view=rev >Log: >Protect against infinite loops in the HTTP NIO connector if sendfile is >configured to send more data than is available in the

Re: Use canonical IPv6 text representation in logs

2011-07-11 Thread Ognjen Blagojevic
On 11.7.2011 20:57, Konstantin Kolinko wrote: I wonder how Apache HTTPD server handles IP6 addresses. Out-of-the-box, without any specific configuration, my httpd 2.2.3 installation on CentOS 5.6, seems to use canonized text representation. Here is the log excerpt, slightly obfuscated:

svn commit: r1145388 - /tomcat/trunk/webapps/docs/changelog.xml

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 22:33:54 2011 New Revision: 1145388 URL: http://svn.apache.org/viewvc?rev=1145388&view=rev Log: Maybe someone wants to realize that change. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apac

svn commit: r1145387 - in /tomcat/trunk/webapps/docs: config/ajp.xml config/http.xml config/valve.xml funcspecs/fs-admin-objects.xml

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 22:30:45 2011 New Revision: 1145387 URL: http://svn.apache.org/viewvc?rev=1145387&view=rev Log: Never compare docs and code: - enableLookups for connector was "false" by default at least the last 5 years. - resolveHosts for normal and extended access log valve

svn commit: r1145383 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 22:27:06 2011 New Revision: 1145383 URL: http://svn.apache.org/viewvc?rev=1145383&view=rev Log: Protect against infinite loops in the HTTP NIO connector if sendfile is configured to send more data than is available in the file. (markt) Modified: tomcat/trunk/ja

svn commit: r1145381 - in /tomcat/trunk/webapps/docs: changelog.xml config/valve.xml

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 22:08:30 2011 New Revision: 1145381 URL: http://svn.apache.org/viewvc?rev=1145381&view=rev Log: A little bit of docs is better than nothing ... Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/valve.xml Modified: tomcat/tru

svn commit: r1145380 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 22:08:06 2011 New Revision: 1145380 URL: http://svn.apache.org/viewvc?rev=1145380&view=rev Log: Remove unused attribute Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Modified: tomcat/trunk/java/org/apache/catalina/servlets/Default

svn commit: r1145355 - /tomcat/trunk/java/org/apache/catalina/util/RequestUtil.java

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 21:10:08 2011 New Revision: 1145355 URL: http://svn.apache.org/viewvc?rev=1145355&view=rev Log: Remove unused import Modified: tomcat/trunk/java/org/apache/catalina/util/RequestUtil.java Modified: tomcat/trunk/java/org/apache/catalina/util/RequestUtil.java URL:

[Tomcat Wiki] Update of "HowTo" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "HowTo" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=103&rev2=104 Comment: Replace jakarta references with something more up-to-d

[Tomcat Wiki] Update of "FAQ/Deployment" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Deployment" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Deployment?action=diff&rev1=7&rev2=8 Comment: Replace http://marc.theaimsgroup.com/ wi

[Tomcat Wiki] Update of "FAQ/FDA_Validation" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/FDA_Validation" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/FDA_Validation?action=diff&rev1=5&rev2=6 Comment: Replace http://marc.theaimsgroup

[Tomcat Wiki] Update of "FAQ/Tomcat_User" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Tomcat_User" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Tomcat_User?action=diff&rev1=4&rev2=5 Comment: Replace http://marc.theaimsgroup.com/

[Tomcat Wiki] Update of "FAQ/Windows" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Windows" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Windows?action=diff&rev1=11&rev2=12 Comment: Replace http://marc.theaimsgroup.com/ with h

[Tomcat Wiki] Update of "FAQ/Performance_and_Monitoring" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Performance_and_Monitoring" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Performance_and_Monitoring?action=diff&rev1=8&rev2=9 Comment: Replace

[Tomcat Wiki] Update of "FAQ/Linux_Unix" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Linux_Unix" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Linux_Unix?action=diff&rev1=8&rev2=9 <>'''How do I run without an X server and st

[Tomcat Wiki] Update of "FAQ/Logging" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Logging" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Logging?action=diff&rev1=17&rev2=18 Comment: Replace http://marc.theaimsgroup.com/ with h

[Tomcat Wiki] Update of "FAQ/Database" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Database" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Database?action=diff&rev1=4&rev2=5 Comment: Replace http://marc.theaimsgroup.com/ with h

[Tomcat Wiki] Update of "FAQ/Memory" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Memory" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Memory?action=diff&rev1=9&rev2=10 Comment: Replace http://marc.theaimsgroup.com/ with http

[Tomcat Wiki] Update of "FAQ/Security" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Security" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Security?action=diff&rev1=9&rev2=10 Comment: Replace http://marc.theaimsgroup.com/ with

[Tomcat Wiki] Update of "FAQ/Security" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Security" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Security?action=diff&rev1=8&rev2=9 Comment: Use macro to obfuscate email address == P

[Tomcat Wiki] Update of "HowTo" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "HowTo" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=102&rev2=103 Comment: Replace http://marc.theaimsgroup.com/ with http://marc

[Tomcat Wiki] Update of "FAQ/Class_Not_Found" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Class_Not_Found" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Class_Not_Found?action=diff&rev1=11&rev2=12 Comment: Replace http://marc.theaimsg

[Tomcat Wiki] Update of "FAQ/Miscellaneous" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Miscellaneous" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/Miscellaneous?action=diff&rev1=25&rev2=26 Comment: Replace http://marc.theaimsgroup

svn commit: r1145318 - in /tomcat/tc5.5.x/trunk: build/RELEASE-NOTES container/webapps/docs/status.xml

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 19:59:20 2011 New Revision: 1145318 URL: http://svn.apache.org/viewvc?rev=1145318&view=rev Log: Replace http://marc.theaimsgroup.com/ with http://marc.info/ That is the current address of the Mailing list ARChives site. Modified: tomcat/tc5.5.x/trunk/build/RE

svn commit: r1145305 - in /tomcat/site/trunk: docs/index.html docs/oldnews.html xdocs/index.xml xdocs/oldnews.xml

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 19:43:33 2011 New Revision: 1145305 URL: http://svn.apache.org/viewvc?rev=1145305&view=rev Log: Move old mod-jk 1.2.31 announcement to oldnews. Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/oldnews.html tomcat/site/trunk/xdocs/ind

DO NOT REPLY [Bug 51497] Use canonical IPv6 text representation in logs

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51497 --- Comment #1 from Konstantin Kolinko 2011-07-11 19:32:48 UTC --- Discussion on dev@, 2011-07-11: http://tomcat.markmail.org/thread/jwysfldcsmulkytb http://marc.info/?t=13104034012&r=1&w=2 -- Configure bugmail: https://issues.apache

svn commit: r1145296 - in /tomcat/trunk: java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 19:06:15 2011 New Revision: 1145296 URL: http://svn.apache.org/viewvc?rev=1145296&view=rev Log: Use en_US as locale for creationdate in WebdavServlet. Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java tomcat/trunk/webapps/docs/chang

Re: Use canonical IPv6 text representation in logs

2011-07-11 Thread Konstantin Kolinko
2011/7/11 Ognjen Blagojevic : > >> (or provide a configuration option). > > That is also possibility. What would be good place to configure: > > 1. AccessLogValve XML parameter? AccessLovValve property (and thus it automatically becomes settable through XML, and after additional configuration thr

svn commit: r1145285 - in /tomcat/trunk/java/org/apache/tomcat: jni/Library.java util/net/AprEndpoint.java

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 18:40:48 2011 New Revision: 1145285 URL: http://svn.apache.org/viewvc?rev=1145285&view=rev Log: Followup to r1145209 Do not expose TCN_FULL_VERSION as a public constant, but calculate it when needed. Using this way it will be easier to throw away the code in AprE

Re: Locale and SimpleDateFormat: creationdate in WebdavServlet

2011-07-11 Thread Konstantin Kolinko
2011/7/11 Rainer Jung : > WebdavServlet uses "-MM-dd'T'HH:mm:ss'Z'" witout setting Locale.US. > > The format is specified in http://www.ietf.org/rfc/rfc2518.txt, 23.2 > Appendix 2 - ISO 8601 Date and Time Profile, and I would say it should > also be en_US. > > I don't know much about Webdav tho

Locale and SimpleDateFormat: creationdate in WebdavServlet

2011-07-11 Thread Rainer Jung
WebdavServlet uses "-MM-dd'T'HH:mm:ss'Z'" witout setting Locale.US. The format is specified in http://www.ietf.org/rfc/rfc2518.txt, 23.2 Appendix 2 - ISO 8601 Date and Time Profile, and I would say it should also be en_US. I don't know much about Webdav though ... Agreed? It is the last SDF

svn commit: r1145270 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 18:21:45 2011 New Revision: 1145270 URL: http://svn.apache.org/viewvc?rev=1145270&view=rev Log: Add JMX fix to the proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/

DO NOT REPLY [Bug 46252] Tomcat access log doesn't support Unicode

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 --- Comment #5 from Konstantin Kolinko 2011-07-11 18:17:32 UTC --- Created attachment 27280 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27280 2011-07-11_tc6_bug46252_JMX.patch Additional patch: Expose the new "encoding" opt

svn commit: r1145268 - /tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 18:10:11 2011 New Revision: 1145268 URL: http://svn.apache.org/viewvc?rev=1145268&view=rev Log: Expose recently added "encoding" and "locale" options of AccessLogValve through JMX. Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml

Re: Use canonical IPv6 text representation in logs

2011-07-11 Thread Ognjen Blagojevic
Konstantin, 1. One should really ask system administrators what they prefer What would be the right place to do that? User list, maybe? I assume at least some of Tomcat developers are also involved in system administration, so I hope they will state their opinion here. (or provide a conf

[Tomcat Wiki] Update of "OrphanedPages" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "OrphanedPages" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/OrphanedPages?action=diff&rev1=6&rev2=7 Comment: Add acl + #acl LeoSimons:read,write,admin

[Tomcat Wiki] Update of "PageSize" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PageSize" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/PageSize?action=diff&rev1=6&rev2=7 Comment: Add acl + #acl LeoSimons:read,write,admin,delete,re

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=23&rev2=24 Comment: Add recent spam addresses angelci

[Tomcat Wiki] Trivial Update of "PageSize" by LeeLansford

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PageSize" page has been changed by LeeLansford: http://wiki.apache.org/tomcat/PageSize?action=diff&rev1=4&rev2=5 List of all pages, sorted by their size: <> + + [[http://w

DO NOT REPLY [Bug 51497] New: Use canonical IPv6 text representation in logs

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51497 Bug #: 51497 Summary: Use canonical IPv6 text representation in logs Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: e

[Tomcat Wiki] Trivial Update of "OrphanedPages" by LeeLansford

2011-07-11 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "OrphanedPages" page has been changed by LeeLansford: http://wiki.apache.org/tomcat/OrphanedPages?action=diff&rev1=4&rev2=5 ##language:en A list of pages no other page links to:

svn commit: r1145259 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 17:48:46 2011 New Revision: 1145259 URL: http://svn.apache.org/viewvc?rev=1145259&view=rev Log: change vote. Let's go on with this. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/

Re: Use canonical IPv6 text representation in logs

2011-07-11 Thread Konstantin Kolinko
2011/7/11 Ognjen Blagojevic : > Hi, > > In AccessLogValve and on other places where IPv6 address is logged or > printed, it would bi good if Tomcat would use canonical IPv6 format as > described in RFC 5952 [1] (especially note section "3.2.2. Logging"), e.g: > > 1. instead of logging 2001:4000:0:5

svn commit: r1145246 - /tomcat/trunk/java/org/apache/catalina/util/RequestUtil.java

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 17:13:06 2011 New Revision: 1145246 URL: http://svn.apache.org/viewvc?rev=1145246&view=rev Log: - Remove unused code: Cookie dates are formatted elsewhere. This class used a very strange format: " , dd-MMM-yy kk:mm:ss zz" - Add log.isDebugEnabled() Modifie

svn commit: r1145243 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 17:07:35 2011 New Revision: 1145243 URL: http://svn.apache.org/viewvc?rev=1145243&view=rev Log: update proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS

DO NOT REPLY [Bug 46252] Tomcat access log doesn't support Unicode

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 Konstantin Kolinko changed: What|Removed |Added Attachment #27278|0 |1 is obsolete|

DO NOT REPLY [Bug 46252] Tomcat access log doesn't support Unicode

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 --- Comment #4 from Konstantin Kolinko 2011-07-11 17:03:05 UTC --- Created attachment 27279 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27279 2011-07-11_tc6_bug46252_v2.patch Updated patch: added r1145237 This adds in Acce

Use canonical IPv6 text representation in logs

2011-07-11 Thread Ognjen Blagojevic
Hi, In AccessLogValve and on other places where IPv6 address is logged or printed, it would bi good if Tomcat would use canonical IPv6 format as described in RFC 5952 [1] (especially note section "3.2.2. Logging"), e.g: 1. instead of logging 2001:4000:0:5:0:0:0:66, it should log 2001:4000:0:

svn commit: r1145238 - in /tomcat/trunk: java/org/apache/catalina/valves/ExtendedAccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 16:51:54 2011 New Revision: 1145238 URL: http://svn.apache.org/viewvc?rev=1145238&view=rev Log: Always use en_US as locale for timestamps in ExtendedAccessLogValve. The format is specified in http://www.w3.org/TR/WD-logfile.html and states that the supported times

svn commit: r1145237 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/LocalStrings.properties java/org/apache/juli/FileHandler.java webapps/docs/

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 16:46:28 2011 New Revision: 1145237 URL: http://svn.apache.org/viewvc?rev=1145237&view=rev Log: * JULI FileHandler, AccessLogValve: Create a directory automatically when it is specified as a part of the file name, e.g. in the prefix attribute. Earlier this happen

svn commit: r1145225 - /tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 16:10:15 2011 New Revision: 1145225 URL: http://svn.apache.org/viewvc?rev=1145225&view=rev Log: Revert unintended commit Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyn

svn commit: r1145224 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 16:08:23 2011 New Revision: 1145224 URL: http://svn.apache.org/viewvc?rev=1145224&view=rev Log: Improve logging of error conditions Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java tomcat/trunk/test/org/apache/catalina/core/TestAs

svn commit: r1145218 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 16:03:36 2011 New Revision: 1145218 URL: http://svn.apache.org/viewvc?rev=1145218&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

DO NOT REPLY [Bug 46252] Tomcat access log doesn't support Unicode

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 --- Comment #3 from Konstantin Kolinko 2011-07-11 16:01:05 UTC --- Created attachment 27278 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27278 2011-07-11_tc6_bug46252.patch Correction: that revision number above was r1145200

DO NOT REPLY [Bug 51477] Support all protocol combinations in SSLProtocol of APR Connector

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477 Rainer Jung changed: What|Removed |Added Component|Connectors |Library Version|7.0.16

svn commit: r1145209 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 15:44:10 2011 New Revision: 1145209 URL: http://svn.apache.org/viewvc?rev=1145209&view=rev Log: BZ 51477: Support all SSL protocol combinations in the APR/native connector. This only works when using the native library version 1.1.21 or later which is not yet releas

svn commit: r1145207 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/LocalStrings.properties

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 15:39:47 2011 New Revision: 1145207 URL: http://svn.apache.org/viewvc?rev=1145207&view=rev Log: Move AccessLogValve messages to a separate section and add a comment. No functional change. This is to simplify a patch that will follow. CTR Modified: tomcat/tc6

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Konstantin Kolinko
2011/7/11 Rainer Jung : > >> There is another enhancement on todo list: >> provide "encoding" option for AccessLogValve, >> like already done for FileHandler in JULI. > > I guess that is https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 > > The need for it isn't very convincing, at least aft

DO NOT REPLY [Bug 46252] Tomcat access log doesn't support Unicode

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 --- Comment #2 from Konstantin Kolinko 2011-07-11 15:16:40 UTC --- Implemented in 7.0 with r11145200 and will be in 7.0.19. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this m

svn commit: r1145200 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/valv

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 15:13:13 2011 New Revision: 1145200 URL: http://svn.apache.org/viewvc?rev=1145200&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 Allow to specify character set to be used to write the access log in AccessLogValve. Modified: tomcat

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Christopher Schultz
Rainer, On 7/10/2011 3:38 PM, Rainer Jung wrote: > Unfortunately I stumbled into some code in StandardSession: > > public void setAttribute(String name, Object value, boolean notify) { > ... > if ((manager != null) && manager.getDistributable() && > !(value instanceof Serializable)) > throw

DO NOT REPLY [Bug 51403] Avoid NullPointerException in JULI FileHandler if formatter is misconfigured

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51403 --- Comment #2 from Konstantin Kolinko 2011-07-11 14:20:59 UTC --- Fixed in 6.0 in r1145188 and will be in 6.0.33 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail becaus

svn commit: r1145188 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/changelog.xml

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 14:19:17 2011 New Revision: 1145188 URL: http://svn.apache.org/viewvc?rev=1145188&view=rev Log: Avoid NullPointerException in JULI FileHandler if formatter is misconfigured Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=51403 Modified: tomcat/tc6.0.

svn commit: r1145186 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 14:18:32 2011 New Revision: 1145186 URL: http://svn.apache.org/viewvc?rev=1145186&view=rev Log: Fix javadoc. Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java UR

svn propchange: r1137996 - svn:log

2011-07-11 Thread kkolinko
Author: kkolinko Revision: 1137996 Modified property: svn:log Modified: svn:log at Mon Jul 11 14:10:52 2011 -- --- svn:log (original) +++ svn:log Mon Jul 11 14:10:52 2011 @@ -1,2 +1,2 @@ Avoid NullPointerException in JULI

Re: svn commit: r1145183 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-11 Thread Mark Thomas
On 11/07/2011 15:06, kkoli...@apache.org wrote: > Author: kkolinko > Date: Mon Jul 11 14:06:38 2011 > New Revision: 1145183 > > URL: http://svn.apache.org/viewvc?rev=1145183&view=rev > Log: > add second patch that addressed review comments (I am assuming Mark's vote > for it) > vote Fine with me

svn commit: r1145183 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-11 Thread kkolinko
Author: kkolinko Date: Mon Jul 11 14:06:38 2011 New Revision: 1145183 URL: http://svn.apache.org/viewvc?rev=1145183&view=rev Log: add second patch that addressed review comments (I am assuming Mark's vote for it) vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Mark Thomas
On 11/07/2011 14:50, Rainer Jung wrote: > On 10.07.2011 23:11, Filip Hanik - Dev Lists wrote: >> go ahead add it in, if you add in a flag to toggle the behavior, and the >> flag is defaulted to today's behavior. you're safe, and you give users >> an option > > Thanks for the feedback. I will go wi

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Rainer Jung
On 11.07.2011 13:41, Konstantin Kolinko wrote: > 2011/7/10 Rainer Jung : >> >> I think checking for serializability in StandardSession isn't good, >> because AFAIK StandardSession isn't used by any mechanism Tomcat >> supports to implement "distributable". >> >> And in DeltaSession I would like to

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Rainer Jung
On 10.07.2011 23:11, Filip Hanik - Dev Lists wrote: > go ahead add it in, if you add in a flag to toggle the behavior, and the > flag is defaulted to today's behavior. you're safe, and you give users > an option Thanks for the feedback. I will go with Konstantin's suggestion of making it overwrita

Re: Using juli DateFormatCache in AccessLogValve?

2011-07-11 Thread Rainer Jung
On 11.07.2011 13:19, Konstantin Kolinko wrote: > 2011/6/23 Rainer Jung : >> Since OneLineFormatter now uses the DateFormatCache util class, and to >> prevent any dependency of juli form other packages that util class sits >> in juli, what do we think about using it also in AccessLogValve? >> >> At

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Rainer Jung
On 11.07.2011 12:35, Konstantin Kolinko wrote: > 2011/7/11 Rainer Jung : >> On 11.07.2011 01:24, Konstantin Kolinko wrote: >> I suggest we at least make the behaviour consistent: >> >> - Change the defaults to en_US > > I think it has to be en_US. Right. CLF will now always use en_US. Fortunatel

svn commit: r1145166 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/valv

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 13:17:09 2011 New Revision: 1145166 URL: http://svn.apache.org/viewvc?rev=1145166&view=rev Log: Allow choosing a locale for timestamp formatting in AccessLogValve. Only relevant to timestamps explicitely given by SimpleDateFormat syntax. Also: use Locale.US for CLF

svn commit: r1145165 - /tomcat/trunk/webapps/docs/

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 13:16:29 2011 New Revision: 1145165 URL: http://svn.apache.org/viewvc?rev=1145165&view=rev Log: Ignore doc copied in during build process Modified: tomcat/trunk/webapps/docs/ (props changed) Propchange: tomcat/trunk/webapps/docs/ -

svn commit: r1145160 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContextValve.java webapps/docs/changelog.xml

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 13:05:30 2011 New Revision: 1145160 URL: http://svn.apache.org/viewvc?rev=1145160&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51494 Prevent an NPE when a long running request completes if the associated web application was destroyed while th

svn commit: r1145137 - in /tomcat/trunk/webapps/docs: config/filter.xml config/valve.xml manager-howto.xml

2011-07-11 Thread rjung
Author: rjung Date: Mon Jul 11 12:16:36 2011 New Revision: 1145137 URL: http://svn.apache.org/viewvc?rev=1145137&view=rev Log: Replace by in docs. The physical markup was only used in few places. Mostly we use the logical markup . Modified: tomcat/trunk/webapps/docs/config/filter.xml t

Re: 7.0.18 installer does not work under windows with a custom service name

2011-07-11 Thread Konstantin Kolinko
2011/7/11 etienne massip : > It is, but it would have been accurate to tell me that the service did > already exist instead of leading me on permission issues. I filed https://issues.apache.org/bugzilla/show_bug.cgi?id=51496 Best regards, Konstantin Kolinko --

DO NOT REPLY [Bug 51496] New: NSIS - Warn that duplicate service name will result in install failure

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51496 Bug #: 51496 Summary: NSIS - Warn that duplicate service name will result in install failure Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Window

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Konstantin Kolinko
2011/7/10 Rainer Jung : > I implemented an addition to DeltaManager which allows to filter which > session attributes actually get replicated (not yet committed). > > This is useful, because many applications > > - use non-serializable session attributes, so >  it is not possible to simply replicat

Re: Using juli DateFormatCache in AccessLogValve?

2011-07-11 Thread Konstantin Kolinko
2011/6/23 Rainer Jung : > Since OneLineFormatter now uses the DateFormatCache util class, and to > prevent any dependency of juli form other packages that util class sits > in juli, what do we think about using it also in AccessLogValve? > > At the moment the valve has a local copy as an inner clas

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Konstantin Kolinko
2011/7/11 Rainer Jung : > On 11.07.2011 01:24, Konstantin Kolinko wrote: >> 2011/7/10  : >>> Author: rjung >>> Date: Sun Jul 10 11:22:40 2011 >>> New Revision: 1144833 >>> >>> URL: http://svn.apache.org/viewvc?rev=1144833&view=rev >>> Log: >>> Another regression in 7.0.18: year number formatting >>

DO NOT REPLY [Bug 51490] if.jsp has many bugs and c:if example not useful

2011-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51490 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1145093 - /tomcat/trunk/webapps/docs/changelog.xml

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 09:37:58 2011 New Revision: 1145093 URL: http://svn.apache.org/viewvc?rev=1145093&view=rev Log: Update changelog for bz51490 fixes Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/vi

svn commit: r1145088 - /tomcat/trunk/webapps/examples/jsp/tagplugin/choose.jsp

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 09:32:32 2011 New Revision: 1145088 URL: http://svn.apache.org/viewvc?rev=1145088&view=rev Log: Fix broken HTML Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/choose.jsp Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/choose.jsp URL: http://svn.ap

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Rainer Jung
On 11.07.2011 01:24, Konstantin Kolinko wrote: > 2011/7/10 : >> Author: rjung >> Date: Sun Jul 10 11:22:40 2011 >> New Revision: 1144833 >> >> URL: http://svn.apache.org/viewvc?rev=1144833&view=rev >> Log: >> Another regression in 7.0.18: year number formatting >> in AccessLogValve is broken due t

svn commit: r1145086 - /tomcat/trunk/webapps/examples/jsp/tagplugin/foreach.jsp

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 09:31:09 2011 New Revision: 1145086 URL: http://svn.apache.org/viewvc?rev=1145086&view=rev Log: Fix broken HTML Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/foreach.jsp Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/foreach.jsp URL: http://svn.

svn commit: r1145084 - /tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 09:29:28 2011 New Revision: 1145084 URL: http://svn.apache.org/viewvc?rev=1145084&view=rev Log: Reduce variable scope to reduce testing issues Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/if.

svn commit: r1145083 - /tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 09:28:25 2011 New Revision: 1145083 URL: http://svn.apache.org/viewvc?rev=1145083&view=rev Log: Ensure it is clear when tag isn't working Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp U

svn commit: r1145081 - /tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp

2011-07-11 Thread markt
Author: markt Date: Mon Jul 11 09:19:59 2011 New Revision: 1145081 URL: http://svn.apache.org/viewvc?rev=1145081&view=rev Log: Fix broken HTML Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp Modified: tomcat/trunk/webapps/examples/jsp/tagplugin/if.jsp URL: http://svn.apache.org

Re: svn commit: r1144690 - in /tomcat/trunk: java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/ClusterRuleSetFactory.java webapps/docs/changelog.xml

2011-07-11 Thread Ivan
Yes, merging the two components is one of the solutions. From other side, it is something like a registry <-> provider scenario, not sure Tomcat will support the functions like customized configurations in the server.xml in the future, and this might be a place to begin it. 2011/7/11 Mark Thomas

Re: svn commit: r1144690 - in /tomcat/trunk: java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/ClusterRuleSetFactory.java webapps/docs/changelog.xml

2011-07-11 Thread Mark Thomas
On 11/07/2011 08:23, Ivan wrote: > Hi, this changes brought a cycle dependency between the tomcat-catalina and > tomcat-catalina-ha module, could you please help to fix it. I'm not sure that is much of a problem. I'm wondering if we should drop the separate catalina.ha.jar and just merge it into c

Re: svn commit: r1144690 - in /tomcat/trunk: java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/ClusterRuleSetFactory.java webapps/docs/changelog.xml

2011-07-11 Thread Ivan
Hi, this changes brought a cycle dependency between the tomcat-catalina and tomcat-catalina-ha module, could you please help to fix it. Thanks. 2011/7/10 > Author: markt > Date: Sat Jul 9 16:05:42 2011 > New Revision: 1144690 > > URL: http://svn.apache.org/viewvc?rev=1144690&view=rev > Log: > R

Re: 7.0.18 installer does not work under windows with a custom service name

2011-07-11 Thread etienne massip
It is, but it would have been accurate to tell me that the service did already exist instead of leading me on permission issues. And allowing user to enter service name and service description would be a must :-) On Fri, Jul 8, 2011 at 6:27 PM, Mark Thomas wrote: > On 08/07/2011 17:22, etienne m