Re: svn commit: r1596004 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

2014-05-19 Thread Konstantin Kolinko
gt; +log.info(msg, cnfe); This method does not throw anything... Thus it is not really a "ClassNotFoundException", because a class is not really "not found", but execution continues further and it may occasionally find the class. > + } >

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-05-19 Thread Konstantin Kolinko
were OK. http://ci.apache.org/projects/tomcat/tomcat8/1595898/ http://ci.apache.org/projects/tomcat/tomcat8/1595898/TEST-org.apache.catalina.valves.TestStuckThreadDetectionValve.NIO.txt A difference is that there was an attempt to load a class which failed on a sto

Re: [VOTE] Release Apache Tomcat 8.0.8

2014-05-19 Thread Konstantin Kolinko
n the frameset) that was supposed to be opened for some time, closed nearly immediately. Thus chat messages could be printed. The browser I was using is Firefox 29.0.1. Connector: NIO. I think this is not fatal and qualifies as beta. Best regards, Konstantin Kolinko ---

Re: Tomcat commit e-mails missing

2014-05-19 Thread Konstantin Kolinko
-0700 (PDT) As of now, I see no noticeable delays in mail delivery. So the issue is resolved. Thank you for your work! [1] http://mail-archives.apache.org/mod_mbox/tomcat-dev/201405.mbox/browser Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat commit e-mails missing

2014-05-15 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat commit e-mails missing

2014-05-14 Thread Konstantin Kolinko
2014-05-08 11:51 GMT+04:00 Konstantin Kolinko : > cc: dev > > Hi! > > Where are svn commit e-mails for Apache Tomcat? > > The last one received by dev@tomcat.a.o list was on May 2.(r1592052) > http://mail-archives.apache.org/mod_mbox/tomcat-dev/201405.mbox/browser >

Re: Questions on Jasper's BodyContentImpl, bug #43925, and proposed solution

2014-05-02 Thread Konstantin Kolinko
he mail stream. 3) It is better to reference an issue # in changelog. 2. A quick formal review of the patch itself: 1) You are changing system-wide defaults for all web applications. Thus I think a better place for your changes is the Constants class. There are already

Re: udp port used by the tribes tests

2014-04-29 Thread Konstantin Kolinko
2014-04-29 18:57 GMT+04:00 Konstantin Kolinko : > 2014-04-29 18:41 GMT+04:00 jean-frederic clere : >> Hi, >> >> Does someone know which upd ports are used by the tribes tests? >> I tried to allow 4000-4005 but that didn't help :-( >> > > From old e-mail

Re: udp port used by the tribes tests

2014-04-29 Thread Konstantin Kolinko
I have not looked into the code. Maybe try running org.apache.catalina.tribes.TesterMulticast ? It is mentioned in BUILDING.txt Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For addi

Re: svn commit: r1590835 - in /tomcat/trunk: java/org/apache/el/parser/AstLiteralExpression.java test/org/apache/el/TestELEvaluation.java webapps/docs/changelog.xml

2014-04-28 Thread Konstantin Kolinko
l > Good! With this my side of ELParser test passes successfully. I'll commit shortly. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Reviewing EL processing fix (BZ 56334)

2014-04-28 Thread Konstantin Kolinko
>> XmlEscapeNonELVisitor has not been updated. >> >> I think it is a bug here. > > Do you want to wait with 7.0.54? Yes, I think it is a bug. You are also missing o.a.naming issue. Best regards, Konstantin Kolinko -

Reviewing EL processing fix (BZ 56334)

2014-04-28 Thread Konstantin Kolinko
whether they are followed by '{'. The code in ELParser does not check for following '{'. (No bug here. The implementation is correct. Only the comment is off). 4) Validator$ValidateVisitor$XmlEscapeNonELVisitor.visit(Text) The code in ELParser.TextBuilder.visit(Text

Re: Reporting Tomcat version information to end user

2014-04-27 Thread Konstantin Kolinko
ng to your liking. > For me, it would for sure be a welcome feature to be able to turn this off > without losing the version information on the back end process such as > logfiles. > > What's your take on this? I filed https://issues.apache.org/bugzilla/show_bug.cg

Re: Time for 8.0.6

2014-04-26 Thread Konstantin Kolinko
with NIO2 and TestCoyoteAdapter.testBug54928 that > I'd like to get to the bottom of. > If someone is able to edit Buildbot configuration, maybe it is possible to skip that "RAT report publishing" step? I wrote on this issue on builds@ mailing list (several days ago),

Re: Time for 8.0.6

2014-04-26 Thread Konstantin Kolinko
2014-04-27 0:25 GMT+04:00 Konstantin Kolinko : > 2014-04-26 23:38 GMT+04:00 Mark Thomas : >> The remaining open 8.0.x bugs are related to cookie parsing and I don't >> plan on addressing them until at least after the next release. >> >> The remaining open 7.0.x issu

Re: Time for 8.0.6

2014-04-26 Thread Konstantin Kolinko
This should fit in 2 hours while you are running the tests. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat wiki - edit permissions

2014-04-25 Thread Konstantin Kolinko
. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1589672 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/

2014-04-24 Thread Konstantin Kolinko
2014-04-24 17:14 GMT+04:00 Rémy Maucherat : > 2014-04-24 15:04 GMT+02:00 Konstantin Kolinko : > >> 2. AbstractEndpoint,unlockAccept() >> >> s.setSoLinger(getSocketProperties().getSoLingerOn(),getSocketProperties().getSoLingerTime()); >> >> I expect the ab

Re: svn commit: r1589672 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/

2014-04-24 Thread Konstantin Kolinko
NPE. 3. It seems that APR connector is broken. Firefox fails to connect to http;//localhost:8080/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1589635 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/compiler/Validator.java test/org/apache/jasper/compiler/TestELParse

2014-04-24 Thread Konstantin Kolinko
yntaxAllowedAsLiteral; > protected StringBuilder output = new StringBuilder(); > > +protected TextBuilder(boolean isDeferredSyntaxAllowedAsLiteral) { > +this.isDeferredSyntaxAllowedAsLiteral = > isDeferredSyntaxAllowedAsLiteral; > +} > + > public String getText() { > return output.toString(); > } > @@ -464,18 +571,18 @@ public class ELParser { > > @Override > public void visit(Function n) throws JasperException { > -output.append(n.getOriginalText()); > +output.append(escapeLiteralExpression(n.getOriginalText(), > isDeferredSyntaxAllowedAsLiteral)); > output.append('('); > } > > @Override > public void visit(Text n) throws JasperException { > -output.append(n.getText()); > + > output.append(escapeLiteralExpression(n.getText(),isDeferredSyntaxAllowedAsLiteral)); > } > > @Override > public void visit(ELText n) throws JasperException { > -output.append(n.getText()); > +output.append(escapeELText(n.getText())); > } > } > } > (...) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Konstantin Kolinko
2014-04-23 0:43 GMT+04:00 Mark Thomas : > On 22/04/2014 21:35, Konstantin Kolinko wrote: >> 2014-04-23 0:30 GMT+04:00 Mark Thomas : >>> On 22/04/2014 21:21, Christopher Schultz wrote: >>> >>>> Before posting, I checked just so I wouldn't embarrass myself

Re: svn commit: r1589195 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-22 Thread Konstantin Kolinko
lly expect "1" (or let's assume that the value of FIPS_ON is configurable), then non-1 value does not mean that "FIPS mode is off". It means "FIPS mode value is different from expected" and would better have a separate error message. Best regards,

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Konstantin Kolinko
Exception e) { > throw new IllegalStateException(e); > } > > > This failure looks correct to me since it should be illegal to change > the value of a final variable after it has been declared. 1.

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Konstantin Kolinko
ative code need them documented and their signatures fixed as well. E.g. "fipsModeSet()" Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Back-porting patches; margeinfo for svn-linked directories

2014-04-18 Thread Konstantin Kolinko
changed) > tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/tc7/ > (props changed) > tomcat/tc7.0.x/trunk/webapps/examples/websocket-deprecated/ (props > changed) > > Those are not pulled in via externals like jdbc-pool. > Tomc

Re: [Tomcat Wiki] Update of "Security/Heartbleed" by KonstantinKolinko

2014-04-18 Thread Konstantin Kolinko
ht be worth pointing to a page that describes the version compatibility. It should be. New methods are added (and used by newer versions of Tomcat) but old ones are not removed. Of course, nobody tested all combinations, and the license applies (no warranty etc.). Best regards, Konstantin Ko

Re: [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2014-04-16 Thread Konstantin Kolinko
2014-04-16 13:48 GMT+04:00 Mark Thomas : > On 16/04/2014 10:36, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=50078 >> >> --- Comment #4 from Andrea Wilson --- > > This idiot has had their account locked. I also deleted the spam comment. > There is also a spam c

Re: Back-porting patches; margeinfo for svn-linked directories

2014-04-15 Thread Konstantin Kolinko
Anyway I do not know of any harm from those mergeinfos. Both reverting and non-reverting are OK with me. BTW, TortoiseSVN released an update yesterday. (HTTPS clients such as svn are vulnerable to heartbleed from rogue servers). Best regards, Konstantin Kolinko --

Re: svn commit: r1587456 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-15 Thread Konstantin Kolinko
will* require 1.1.30. I decided to > split-out the version requirements due to Heartbleed, but it seems it's > really not appropriate.) > > I can back-out these patches in Tomcat 8 and Tomcat 7 but the same code > will go right back in with a subsequent patch > (http://svn.apac

Re: svn commit: r1587379 - in /tomcat/trunk: java/org/apache/catalina/core/AprLifecycleListener.java java/org/apache/catalina/core/LocalStrings.properties java/org/apache/tomcat/jni/SSL.java webapps/d

2014-04-15 Thread Konstantin Kolinko
ly be done with Tomcat native > +library version 1.2.23 or later -- either of which must be built > +against the FIPS-compatible OpenSSL library. > +If this attribute is set to any of the above values, SS

Re: [ANN] Apache Tomcat Connectors 1.2.40 released

2014-04-15 Thread Konstantin Kolinko
Were this and TCNative announcements sent to announce@a.o mailing list as well? The @a.o mail address is not present among To: headers, nor there is such mail in the archives, https://www.apache.org/foundation/mailinglists.html#foundation-announce Best regards, Konstantin Kolinko 2014-04-15

Re: Adding "startup" messages

2014-04-15 Thread Konstantin Kolinko
nfiguration option. 3. (Maybe not for this issue) It would be useful to dump info on connectors used by Tomcat. As by default Tomcat does not fail when connectors startup fails, it might be useful to log whether those connectors have actua

Re: Can't build Tomcat 7.0.x trunk deps (dbcp)

2014-04-15 Thread Konstantin Kolinko
2014-04-15 5:25 GMT+04:00 Christopher Schultz : > All, > > While back-porting r1587378 to Tomcat 7.0, it appears that I can't build > Tomcat 7.0.x trunk: > > $ echo $JAVA_HOME > /usr/local/java-7 JAVA_HOME should point to a Java 6 JDK for Tomcat 7. java.7.home in build.properties should point to

Re: Wiki

2014-04-14 Thread Konstantin Kolinko
2014-04-14 11:28 GMT+04:00 Ognjen Blagojevic : > On 14.4.2014 4:47, Konstantin Kolinko wrote: >> >> 2014-04-14 3:03 GMT+04:00 Ognjen Blagojevic >> : >>> >>> Hi, >>> >>> Please allow me to edit Tomc

Re: Wiki

2014-04-13 Thread Konstantin Kolinko
2014-04-14 3:03 GMT+04:00 Ognjen Blagojevic : > Hi, > > Please allow me to edit Tomcat wiki. > OK, but did you create an account there? Your Wiki account name = ? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For a

Re: svn commit: r1586890 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java test/org/apache/jasper/compiler/TestELParser.java test/org/apache/jasper/compiler/TestParser.java test/webapp

2014-04-13 Thread Konstantin Kolinko
it(Text n) throws JasperException { > -output.append(n.getText()); > +output.append(Generator.escape(n.getText())); > } > > @Override > public void visit(ELText n) throws JasperException { > -output.append(n.getT

Re: svn commit: r1586992 - in /tomcat/site/trunk: docs/security-6.html docs/security-7.html docs/security-8.html xdocs/security-6.xml xdocs/security-7.xml xdocs/security-8.xml

2014-04-13 Thread Konstantin Kolinko
ate page for Tomcat-Native, http://tomcat.apache.org/security-native.html Strictly speaking, this affects "Windows" versions (zip, exe) of Tomcat that bundle those versions of TC-Native, Best regards, Konstantin Kolinko

Re: Tomcat 6 End of life plan

2014-04-11 Thread Konstantin Kolinko
ves 1,5 more years, until end of 2015. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: VOTE] Release Apache Tomcat Connectors 1.2.40

2014-04-11 Thread Konstantin Kolinko
0/ There are no asc/md5/sha1 files for the -src.zip and -src.tar.gz at [1]. Are they missing, or just unreadable? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat 6 timing of next release

2014-04-10 Thread Konstantin Kolinko
; There is one more Jasper EL regression that I think is need to be addressed in Tomcat 6. https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Thus far I have tested that it is reproducible with war from bugzilla (in 8.0.x or in 7.0.x, I don't remember), but have not dug further to fix it.

Re: svn commit: r1585657 - /tomcat/jk/trunk/native/common/jk_connect.c

2014-04-10 Thread Konstantin Kolinko
st); The "getaddrinfo" method is called twice in this method. The above modifies the first call. Apply the same change to the second call, a few lines below? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.1.30

2014-04-10 Thread Konstantin Kolinko
rs. > > The Apache Tomcat Native 1.1.30 is > [x] Stable, go ahead and release > [ ] Broken because of ... > I've run current 8.0.x (@r1586315) testsuite with JDK 7u51 32-bit on Windows7 with non-OSCP and with OSCP binaries. Both runs have completed successfu

Re: svn commit: r1585898 - in /tomcat/native/branches/1.1.x: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2014-04-09 Thread Konstantin Kolinko
/* Set default (nistp256) elliptic curve for ephemeral ECDH keys */ > +EC_KEY *ecdh = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1); > +SSL_CTX_set_tmp_ecdh(c->ctx, ecdh); > +EC_KEY_free(ecdh); > SSL_CTX_set_tmp_rsa_callback(c->ctx, SSL_callback_tmp_RSA); &

Re: Tagging JK 1.2.40

2014-04-08 Thread Konstantin Kolinko
rotocol, but apparently it is enabled by default. A test tool: https://github.com/FiloSottile/Heartbleed A discussion of this security issue: http://security.stackexchange.com/questions/55076/what-should-one-do-about-the-heartbleed-openssl-exploit Best regards, Konsta

Re: svn commit: r1584806 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ res/maven/ webapps/docs/

2014-04-04 Thread Konstantin Kolinko
rting compilerSourceVM/compilerTargetVM = 1.8 in Tomcat 6, but technically I have no objections if somebody wants this feature. For the record: ECJ 4.3.2 is OK to be used as replacement for 4.3.1 - it has the same mix of 1.2/1.6 classes. E

Re: [VOTE] Release Apache Tomcat 7.0.53

2014-03-28 Thread Konstantin Kolinko
. Unit tests (BIO,NIO,APR x JDK 6u45, 7u51) - OK. Smoke testing OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Java 8 support

2014-03-26 Thread Konstantin Kolinko
ww.oracle.com/technetwork/java/javase/8-known-issues-2157115.html 3. BTW, I usually use "test.entry" property to run a single test class (as documented in BUILDING.txt), though "test.name" is more capable. Best regards, Konstantin Kolinko

Re: Running Tomcat under Eclipse Debugger

2014-03-25 Thread Konstantin Kolinko
2014-03-26 0:20 GMT+04:00 Christopher Schultz : > All, > > I've only just started running Tomcat under the Eclipse Debugger and it > seemed to take forever to launch -- due to web application deployment. > See below for the catalina.out log for a launch this morning. > Did you follow the documente

Re: svn commit: r1579941 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-03-21 Thread Konstantin Kolinko
n, but that's no excuse not to log > + a potential problem. 1) Is your vote still -1, or -0, or +0? 2) If inputStream.close() fails it does not mean that the stream is left open. Also no data is lost (un

Re: Debugging Tomcat 7 Cors Filter

2014-03-21 Thread Konstantin Kolinko
forming authentication such as BasicAuthenticator, DigestAuthenticator. See references to HttpServletResponse.SC_UNAUTHORIZED You can always put a breakpoint in CoyoteAdapter.service(). You may put one at Response.sendError(), Response.setStatus(). Best regards, Konstantin Kolinko -

Re: ant version 1.8.2 or later is required for Tomcat 7 build

2014-03-21 Thread Konstantin Kolinko
computer". > Wdyt? +1. Best regards, Konstantin Kolinko > > Regards > Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1579428 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-03-21 Thread Konstantin Kolinko
http://svn.apache.org/viewvc?view=revision&revision=1429172 > -- it > seemed to provide the useful service of decommissioning any Filter that > had already been started. Is that something that never actually happens? > That is a package-visible method, it is not part of the API.

Re: [VOTE] Release Apache Tomcat 8.0.4

2014-03-21 Thread Konstantin Kolinko
urrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) ]]] The test that it was running was Testcase: testFirstCallToOnWritePossible took 0,086 sec Well, it is good that Tomcat can be started and stopped in less that 0.1 second. Best regards,

Re: svn commit: r1579170 - in /tomcat/trunk: java/org/apache/jasper/compiler/JDTCompiler.java webapps/docs/changelog.xml

2014-03-19 Thread Konstantin Kolinko
umentation (jasper-howto, web.xml) "1.7" is already the default. I see that this changes the fallback for incorrect values. I will be offline for the next 4 hours. Best regards, Konstantin Kolinko > > Modified: > tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler

Re: Time for 8.0.4

2014-03-18 Thread Konstantin Kolinko
2) In documentation part: update required version of tc-native in description of this feature. 3) Update "recommended"/"required" versions in APRLifecycleListener? 4) Code style: position of opening '{'. Best regards, Konstantin Kolinko

Re: Time for 8.0.4

2014-03-17 Thread Konstantin Kolinko
ns are either escaped elsewhere (I have not found where, but that would split the escaping logic between two places in the code), or not at all. Looking at Generator.java L1806 ( Generator$GenerateVisitor.visit(Node.UninterpretedTag n) ), it does escape double quotes ther

Re: svn commit: r1577199 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/LocalStrings.properties java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/catalina/startup/H

2014-03-15 Thread Konstantin Kolinko
2014-03-16 0:14 GMT+04:00 Konstantin Kolinko : > 2014-03-13 19:30 GMT+04:00 : >> Author: markt >> Date: Thu Mar 13 15:30:35 2014 >> New Revision: 1577199 >> >> URL: http://svn.apache.org/r1577199 >> Log: >> Fix https://issues.apache.org/bugzilla/s

Re: svn commit: r1577199 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/LocalStrings.properties java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/catalina/startup/H

2014-03-15 Thread Konstantin Kolinko
2014-03-13 19:30 GMT+04:00 : > Author: markt > Date: Thu Mar 13 15:30:35 2014 > New Revision: 1577199 > > URL: http://svn.apache.org/r1577199 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56248 > Allow the deployer to update an existing WAR file without > undeploying the existing

Re: svn commit: r1577328 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/DigesterFactory.java java/org/apache/tomcat/util/descriptor/LocalStrings.properties webapps/docs/changelo

2014-03-13 Thread Konstantin Kolinko
1. addSelf() is odd, does not match with TC8. Bad merge? 2. Both add() and addSelf() should display a warning. Maybe move "log.warn()" into locationFor(..) method. 3. What is the point of putting null values into the maps. 4. Message: > digesterFactory.missingSchema=The XML schema [{0}] could not b

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Konstantin Kolinko
r that, and I think that such a change would make the things worse. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1576770 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/MemoryRealm.java test/org/apache/catalina/realm/TestMemoryRealm.java webapps/docs/changelog.xml

2014-03-13 Thread Konstantin Kolinko
2014-03-12 18:53 GMT+04:00 : > Author: markt > Date: Wed Mar 12 14:53:29 2014 > New Revision: 1576770 > > URL: http://svn.apache.org/r1576770 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56246 > Fix NullPointerException in MemoryRealm when authenticating an unknown user. > > Add

Re: svn commit: r1576079 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/mbeans-descriptors.xml

2014-03-11 Thread Konstantin Kolinko
gt; Revert r1576000 >> It obviously was meant to be applied for trunk, not for Tomcat 6. > > Thanks for fixing this for me. I'm sorry for not being careful while > making that edit. > OK, it happens. Note that I've already fixed this in trunk. https://iss

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-11 Thread Konstantin Kolinko
2014-03-11 17:30 GMT+04:00 Konstantin Kolinko : > 2014-03-11 17:09 GMT+04:00 Rémy Maucherat : >> 2014-03-11 13:14 GMT+01:00 Konstantin Kolinko : >> >>> The only test that fails is org.apache.tomcat.util.net.TestSsl. >>> Its failure repeats consistently (all 6 of 6

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-11 Thread Konstantin Kolinko
2014-03-11 17:09 GMT+04:00 Rémy Maucherat : > 2014-03-11 13:14 GMT+01:00 Konstantin Kolinko : > >> The only test that fails is org.apache.tomcat.util.net.TestSsl. >> Its failure repeats consistently (all 6 of 6 runs), with NIO2. >> BIO,NIO,APR connectors do not fail

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-11 Thread Konstantin Kolinko
t java.io.BufferedReader.readLine(BufferedReader.java:382) at org.apache.tomcat.util.net.TestSsl.testRenegotiateWorks(TestSsl.java:206) Testcase: testRenegotiateFail took 0,004 sec ]]] Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: NIO 2 connector

2014-03-10 Thread Konstantin Kolinko
2014-03-08 4:41 GMT+04:00 Rémy Maucherat : > 2014-03-07 23:16 GMT+01:00 Konstantin Kolinko : > >> 1. It is a month since release 8.0.3 and thus I think 8.0.4 is >> expected in a week or so.. >> >> I am -1 to destabilize 8.0.x now. >> > > As a new compon

Tomcat 8: Firing listeners from within a synchronized(writeLock) in onWritePossible()

2014-03-08 Thread Konstantin Kolinko
form the actual writing. I expect that releasing this write lock to be an other way to resolve deadlock that I reported (that was fixed by r1568804). The r1568804 itself is OK. I am just saying that this side of that issue can also be impr

Re: NIO 2 connector

2014-03-07 Thread Konstantin Kolinko
aren't any. I'd need some time to compare). 3). What are the selling points of this implementation? The documentation part of the patch does not say anything in particular. Also my -1 that it does not say that this connector is an "experimental" one. Best regards, Konstantin K

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-03-06 Thread Konstantin Kolinko
per.compiler.TestELInterpreterFactory.BIO.txt So the good news is that IllegalStateException patch (r1574944) works. It is this test case that is broken. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...

Re: svn commit: r1574785 - in /tomcat/trunk: java/org/apache/jasper/JspC.java java/org/apache/jasper/servlet/JspCServletContext.java test/org/apache/jasper/servlet/TestJspCServletContext.java

2014-03-06 Thread Konstantin Kolinko
2014-03-06 11:40 GMT+04:00 : > Author: markt > Date: Thu Mar 6 07:40:12 2014 > New Revision: 1574785 > > URL: http://svn.apache.org/r1574785 > Log: > Better fix for BZ56199 > Fix failing unit tests caused by original fix. > > Modified: > tomcat/trunk/java/org/apache/jasper/JspC.java > tom

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-05 Thread Konstantin Kolinko
t.java:121) ]]] It is the same NPE error for all test cases. http://ci.apache.org/projects/tomcat/tomcat8/logs/1574657/TEST-org.apache.jasper.servlet.TestJspCServletContext.BIO.txt Best regards, Konstantin Kolinko - To unsubscri

Re: svn commit: r1574167 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2014-03-05 Thread Konstantin Kolinko
2014-03-04 22:10 GMT+04:00 : > Author: remm > Date: Tue Mar 4 18:10:56 2014 > New Revision: 1574167 > > URL: http://svn.apache.org/r1574167 > Log: > Avoid possible NPE. > > Modified: > tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java > > Modified: tomcat/trunk/java/org/apach

Re: svn commit: r1573484 - in /tomcat/trunk: build.properties.default build.xml

2014-03-04 Thread Konstantin Kolinko
2014-03-03 13:10 GMT+04:00 : > Author: markt > Date: Mon Mar 3 09:10:13 2014 > New Revision: 1573484 > > URL: http://svn.apache.org/r1573484 > Log: > DBCP 2.0 has been released. > Congratulations, Mark! Change log update for this =? > Modified: > tomcat/trunk/build.properties.default >

Re: svn commit: r1570115 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml

2014-03-02 Thread Konstantin Kolinko
2014-03-03 0:21 GMT+04:00 Mark Thomas : > On 25/02/2014 12:17, Konstantin Kolinko wrote: > >> Regarding the use of filesonly="true" in >> http://svn.apache.org/r1570629 >> >> It is known that such setting breaks some jar scanning technologies, e.g >> h

Re: TldScanner + Config, was: Jasper Improvements

2014-02-27 Thread Konstantin Kolinko
nk it wouldn't be good to delay application startup for that time. > I was thinking there to combine the TLD and JSP scans into one. Those are different scans. For TLDs you have to scan jar files. For JSPs you have to scan application resou

Re: Connectors, blocking, and keepalive

2014-02-25 Thread Konstantin Kolinko
ming >> I/O whether it's doing blocking I/O or non-blocking I/O, right? > > Correct. (excluding sendFile, async, WebSocket, Comet) It is worth adding those four (sendfile etc.) as rows into the table. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1570115 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml

2014-02-25 Thread Konstantin Kolinko
2014-02-21 19:40 GMT+04:00 Mark Thomas : > On 21/02/2014 15:35, Konstantin Kolinko wrote: >> 2014-02-20 13:53 GMT+04:00 Konstantin Kolinko : >>> 2014-02-20 13:26 GMT+04:00 Mark Thomas : >>>> On 20/02/2014 09:10, Konstantin Kolinko wrote: >>>>> 2014-

Re: ASF svn server certficate + svn client

2014-02-21 Thread Konstantin Kolinko
2014-02-21 23:06 GMT+04:00 Konstantin Kolinko : > 2014-02-21 23:01 GMT+04:00 Christopher Schultz : >> Sebb, >> >> On 2/21/14, 11:09 AM, sebb wrote: >>> The certs were changed recently. The new fingerprints should be on the >>> infra website somewhere. &g

Re: ASF svn server certficate + svn client

2014-02-21 Thread Konstantin Kolinko
.html#ssl-keys > > Yeah, I could see that the cert was new as of a few days ago. I was > mostly wondering how to tell my svn client about whatever cert chain (or > portion thereof) is missing. > The easy way is to type "p" in that dialog. Best regards, Konstantin Ko

Re: svn commit: r1570115 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml

2014-02-21 Thread Konstantin Kolinko
2014-02-20 13:53 GMT+04:00 Konstantin Kolinko : > 2014-02-20 13:26 GMT+04:00 Mark Thomas : >> On 20/02/2014 09:10, Konstantin Kolinko wrote: >>> 2014-02-20 13:04 GMT+04:00 : >>>> Author: markt >>>> Date: Thu Feb 20 09:04:52 2014 >>>> New

Re: svn commit: r1570115 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml

2014-02-20 Thread Konstantin Kolinko
2014-02-20 13:26 GMT+04:00 Mark Thomas : > On 20/02/2014 09:10, Konstantin Kolinko wrote: >> 2014-02-20 13:04 GMT+04:00 : >>> Author: markt >>> Date: Thu Feb 20 09:04:52 2014 >>> New Revision: 1570115 >>> >>> URL: http://svn.apache.org/r15

Re: svn commit: r1570115 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml

2014-02-20 Thread Konstantin Kolinko
xml (original) > +++ tomcat/tc7.0.x/trunk/build.xml Thu Feb 20 09:04:52 2014 > @@ -277,20 +277,18 @@ > > > > - > - > - > - > - > - > + > + > + > + > > > > - > - > - > - > - > + I do not like these *.class patterns. I think occasionally having an empty package is less evil than missing a *.properties fil

Re: false in filter?

2014-02-19 Thread Konstantin Kolinko
2014-02-19 17:21 GMT+04:00 Mark Thomas : > On 18/02/2014 17:43, Konstantin Kolinko wrote: >> 2014-02-18 20:05 GMT+04:00 Mark Thomas : >>> On 18/02/2014 13:07, Romain Manni-Bucau wrote: >>>> 2014-02-18 13:10 GMT+01:00 Mark Thomas : >>> >>> >>

Re: false in filter?

2014-02-18 Thread Konstantin Kolinko
2014-02-18 20:05 GMT+04:00 Mark Thomas : > On 18/02/2014 13:07, Romain Manni-Bucau wrote: >> 2014-02-18 13:10 GMT+01:00 Mark Thomas : > > > >>> Looks like there might be a couple of problems here. Any chance you >>> could debug this and provide the full text of the merged web.xml? >>> >> >> https:

Re: new classloader parent?

2014-02-18 Thread Konstantin Kolinko
is OK, I'll back-port it to 7.0.x with the one change that > j2seClassLoader will be a protected rather than private field in 7.0.x. By the way, "j2se" is called "JavaSE" nowadays, starting with Java 5. Best regards, Konstantin Kolinko ---

Re: feedback on 7.0.52

2014-02-17 Thread Konstantin Kolinko
2014-02-18 3:36 GMT+04:00 Romain Manni-Bucau : > Hi > > just upgraded tomee on 7.0.52 (still waiting TCKs feedback) but API is > harder and harder to extend. basically we were filtering SCIs (and > everything but here SCIs API changed) and now it is really hard to do > so without some hacky solutio

Re: svn commit: r1567742 - /tomcat/tc7.0.x/trunk/bin/service.bat

2014-02-15 Thread Konstantin Kolinko
2014-02-15 23:03 GMT+04:00 Konstantin Preißer : > Hi, > >> -Original Message----- >> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] >> Sent: Saturday, February 15, 2014 6:50 PM >> To: Tomcat Developers List >> Subject: Re: svn commit: r1567742 - /

Re: svn commit: r1567742 - /tomcat/tc7.0.x/trunk/bin/service.bat

2014-02-15 Thread Konstantin Kolinko
n failure and does not clear PR_STDOUTPUT, PR_STDERROR variables. Actually, it is not needed at all and can be removed, thanks to "setlocal" call earlier. It was needed earlier when Tomcat7.exe was called several times in succession with different sets of variables. Best regards, Kon

Re: Special requirements on session id generator

2014-02-14 Thread Konstantin Kolinko
d it out in detail, but it looks easy to do and useful. > OK. Does it need to be "jvm route", or maybe just a prefix/suffix? Do you intend to set it programmatically, or via configuration? (A class name + maybe a set of prefixed properties like "socket." ones in AbstractEndpoint.setProperty(...)?). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.52

2014-02-14 Thread Konstantin Kolinko
est, regardless of connector type: {date,time} org.apache.catalina.loader.WebappClassLoader clearReferencesThreads SEVERE: The web application [] appears to have started a thread named [http-bio-127.0.0.1-auto-4-exec-1] but has failed to stop it. This is very likely to create a memory leak. I think these issues are not showstoppers, but they may need further investigation. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1567717 - /tomcat/tc7.0.x/trunk/build.xml

2014-02-12 Thread Konstantin Kolinko
2014-02-12 22:43 GMT+04:00 : > Author: markt > Date: Wed Feb 12 18:43:45 2014 > New Revision: 1567717 > > URL: http://svn.apache.org/r1567717 > Log: > Remove use of optimize flag that has been a NO-OP since Java 1.1 > > Modified: > tomcat/tc7.0.x/trunk/build.xml > > Modified: tomcat/tc7.0.x/tr

Re: [VOTE] Release Apache Tomcat 7.0.51

2014-02-11 Thread Konstantin Kolinko
2014-02-11 19:15 GMT+04:00 Konstantin Kolinko : > 2014-02-11 18:57 GMT+04:00 Mark Thomas : >> On 11/02/2014 14:38, Konstantin Kolinko wrote: >>> 2014-02-11 17:32 GMT+04:00 Mark Thomas : >>> I see you also took care of metadata-complete=\"true\". OK. >

Re: [Tomcat Wiki] Update of "PoweredBy" by PierreJean

2014-02-11 Thread Konstantin Kolinko
2014-02-11 22:59 GMT+04:00 Konstantin Kolinko : > 2014-02-10 19:59 GMT+04:00 dahu : >> Le 10/02/2014 16:54, Apache Wiki a écrit : >> >> Explict remove & cleaning : >> >> - AS-ComTec IT Service : url in description only > OK. > (They are out of alphabet

Re: [Tomcat Wiki] Update of "PoweredBy" by PierreJean

2014-02-11 Thread Konstantin Kolinko
nweb.it: subpage optimize in description All OK. > - hahnefeld IT : all 200 && empty Subpage links can be removed. (It is section for hosting offering, the rest of text is irrelevant) > - dreamshared.com : timeout && empty > - Hosting Habitat : timeout && empty

Re: [VOTE] Release Apache Tomcat 7.0.51

2014-02-11 Thread Konstantin Kolinko
2014-02-11 18:57 GMT+04:00 Mark Thomas : > On 11/02/2014 14:38, Konstantin Kolinko wrote: >> 2014-02-11 17:32 GMT+04:00 Mark Thomas : >> I see you also took care of metadata-complete=\"true\". OK. >> >> The following also comes to mind: >> , in 2.4 do n

Re: [VOTE] Release Apache Tomcat 7.0.51

2014-02-11 Thread Konstantin Kolinko
do not make sense in previous versions. For the recored: the test suite (BIO,NIO,APR) completed successfully, on Win7 using Java 6u45 32-bit. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 7.0.51-dev async test failures (Was: Time for 7.0.51)

2014-02-10 Thread Konstantin Kolinko
2014-02-10 16:50 GMT+04:00 Mark Thomas : > On 10/02/2014 09:48, Mark Thomas wrote: >> On 07/02/2014 13:58, Konstantin Kolinko wrote: > >>> On reruns this failure reproduces consistently. >> >> I can repeat this one on Linux but not Windows. Looking to see which >

Re: Update of "PoweredBy"

2014-02-09 Thread Konstantin Kolinko
o/dir/ 4. You removed section #4 (Surveys). I think it should be added back. That section is about software surways that says how many % of surveyed people are using Tomcat. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.3

2014-02-07 Thread Konstantin Kolinko
e with BIO, NIO, APR - OK. On Windows 7, using Java 7u51 32-bit. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ContributorRequest

2014-02-07 Thread Konstantin Kolinko
consider to > just put this page down ? or put all links in "nofollow" ? The links are generated by MoinMoin. It would be better to make MoinMoin itself mark them as "nofollow". It might be even easier to put "nofollow" into META tag in the head section of

<    5   6   7   8   9   10   11   12   13   14   >