[jira] [Commented] (ZOOKEEPER-1933) Windows release build of zk client cannot connect to zk server

2014-06-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044921#comment-14044921 ] Raul Gutierrez Segales commented on ZOOKEEPER-1933: --- Hi [~fpj

Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-26 Thread Raul Gutierrez Segales
PRE-CREATION src/c/tests/ZKMocks.h fbcfc4f src/c/tests/ZKMocks.cc f97c943 src/c/tests/quorum.cfg PRE-CREATION src/c/tests/zkServer.sh 0af80f8 Diff: https://reviews.apache.org/r/23081/diff/ Testing --- all tests pass, *should* compile on Windows. Thanks, Raul Gutierrez

[jira] [Commented] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045028#comment-14045028 ] Raul Gutierrez Segales commented on ZOOKEEPER-827: -- Sure, [~fpj], here

Review Request 23085: ZOOKEEPER-1274: Support child watches to be displayed with 4 letter zookeeper commands (i.e. wchs, wchp and wchc)

2014-06-26 Thread Raul Gutierrez Segales
src/java/main/org/apache/zookeeper/server/DataTree.java f2a4f86 src/java/main/org/apache/zookeeper/server/WatchManager.java 39bf82e Diff: https://reviews.apache.org/r/23085/diff/ Testing --- Thanks, Raul Gutierrez Segales

Re: Review Request 23085: ZOOKEEPER-1274: Support child watches to be displayed with 4 letter zookeeper commands (i.e. wchs, wchp and wchc)

2014-06-26 Thread Raul Gutierrez Segales
/something/ ``` Thanks, Raul Gutierrez Segales

[jira] [Commented] (ZOOKEEPER-1274) Support child watches to be displayed with 4 letter zookeeper commands (i.e. wchs, wchp and wchc)

2014-06-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045044#comment-14045044 ] Raul Gutierrez Segales commented on ZOOKEEPER-1274: --- Ah fair, do you

[jira] [Commented] (ZOOKEEPER-1274) Support child watches to be displayed with 4 letter zookeeper commands (i.e. wchs, wchp and wchc)

2014-06-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045272#comment-14045272 ] Raul Gutierrez Segales commented on ZOOKEEPER-1274: --- Hmm

[jira] [Commented] (ZOOKEEPER-1851) Follower and Observer Request Processors Do Not Forward create2 Requests

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043775#comment-14043775 ] Raul Gutierrez Segales commented on ZOOKEEPER-1851: --- [~thawan

[jira] [Commented] (ZOOKEEPER-1784) Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043832#comment-14043832 ] Raul Gutierrez Segales commented on ZOOKEEPER-1784: --- [~phunt

[jira] [Commented] (ZOOKEEPER-1919) Update the C implementation of removeWatches to have it match ZOOKEEPER-1910

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043835#comment-14043835 ] Raul Gutierrez Segales commented on ZOOKEEPER-1919: --- Oops, sorry

[jira] [Commented] (ZOOKEEPER-1877) Malformed ACL Id can crash server with skipACL=yes

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043838#comment-14043838 ] Raul Gutierrez Segales commented on ZOOKEEPER-1877: --- [~cchen

[jira] [Commented] (ZOOKEEPER-1946) Server logging should reflect dynamically reconfigured address

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043914#comment-14043914 ] Raul Gutierrez Segales commented on ZOOKEEPER-1946: --- [~vuakko]: what

[jira] [Commented] (ZOOKEEPER-1787) Add support for enabling local session in rolling upgrade

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044211#comment-14044211 ] Raul Gutierrez Segales commented on ZOOKEEPER-1787: --- [~thawan

[jira] [Updated] (ZOOKEEPER-1274) Support child watches to be displayed with 4 letter zookeeper commands (i.e. wchs, wchp and wchc)

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1274: -- Summary: Support child watches to be displayed with 4 letter

[jira] [Updated] (ZOOKEEPER-1274) Support child watches to be displayed with 4 letter zookeeper commands (i.e. wchs, wchp and wchc)

2014-06-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1274: -- Attachment: ZOOKEEPER-1274.patch Here's an updated version

[jira] [Commented] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-24 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042727#comment-14042727 ] Raul Gutierrez Segales commented on ZOOKEEPER-827: -- Actually, ignoring

[jira] [Commented] (ZOOKEEPER-1946) Server logging should reflect dynamically reconfigured address

2014-06-24 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043073#comment-14043073 ] Raul Gutierrez Segales commented on ZOOKEEPER-1946: --- Hi [~vuakko

[jira] [Updated] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-18 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-827: - Attachment: ZOOKEEPER-827.patch Made the Windows related #ifdefs

[jira] [Commented] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-18 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036336#comment-14036336 ] Raul Gutierrez Segales commented on ZOOKEEPER-827: -- Hmm, weird

[jira] [Commented] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034440#comment-14034440 ] Raul Gutierrez Segales commented on ZOOKEEPER-827: -- Thanks

[jira] [Commented] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034449#comment-14034449 ] Raul Gutierrez Segales commented on ZOOKEEPER-827: -- Hmm, looks like we

[jira] [Commented] (ZOOKEEPER-1934) Stale data received from sync'd ensemble peer

2014-06-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034553#comment-14034553 ] Raul Gutierrez Segales commented on ZOOKEEPER-1934: --- Well, but you

[jira] [Updated] (ZOOKEEPER-1938) bump version in the C library as we prepare for 3.5.0 release

2014-06-12 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1938: -- Attachment: ZOOKEEPER-1938.patch Oops, good catch [~rakeshr

[jira] [Commented] (ZOOKEEPER-1939) ReconfigRecoveryTest.testNextConfigUnreachable is failing

2014-06-12 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030137#comment-14030137 ] Raul Gutierrez Segales commented on ZOOKEEPER-1939: --- patch lgtm, +1

[jira] [Commented] (ZOOKEEPER-1937) init script needs fixing for ZOOKEEPER-1719

2014-06-12 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030166#comment-14030166 ] Raul Gutierrez Segales commented on ZOOKEEPER-1937: --- [~marshall

[jira] [Created] (ZOOKEEPER-1938) bump version in the C library as we prepare for 3.5.0 release

2014-06-11 Thread Raul Gutierrez Segales (JIRA)
Raul Gutierrez Segales created ZOOKEEPER-1938: - Summary: bump version in the C library as we prepare for 3.5.0 release Key: ZOOKEEPER-1938 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1938

[jira] [Commented] (ZOOKEEPER-1938) bump version in the C library as we prepare for 3.5.0 release

2014-06-11 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028829#comment-14028829 ] Raul Gutierrez Segales commented on ZOOKEEPER-1938: --- cc: [~michim

[jira] [Updated] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-10 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-827: - Attachment: ZOOKEEPER-827.patch hi [~michim], i've updated the patch

[jira] [Commented] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-09 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026126#comment-14026126 ] Raul Gutierrez Segales commented on ZOOKEEPER-827: -- Thanks

[jira] [Assigned] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-08 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales reassigned ZOOKEEPER-827: Assignee: Raul Gutierrez Segales (was: Sergey Doroshenko

[jira] [Updated] (ZOOKEEPER-827) enable r/o mode in C client library

2014-06-08 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-827: - Attachment: ZOOKEEPER-827.patch I've rebased the available patch

[jira] [Commented] (ZOOKEEPER-1929) std::length_error on update children

2014-05-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009080#comment-14009080 ] Raul Gutierrez Segales commented on ZOOKEEPER-1929: --- how can I

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2014-05-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009082#comment-14009082 ] Raul Gutierrez Segales commented on ZOOKEEPER-1907: --- [~rakeshr

[jira] [Commented] (ZOOKEEPER-770) Slow add_auth calls with multi-threaded client

2014-05-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009094#comment-14009094 ] Raul Gutierrez Segales commented on ZOOKEEPER-770: -- lgtm, +1 - thanks

[jira] [Created] (ZOOKEEPER-1919) Update the C implementation of removeWatches to have it match ZOOKEEPER-1910

2014-04-24 Thread Raul Gutierrez Segales (JIRA)
Raul Gutierrez Segales created ZOOKEEPER-1919: - Summary: Update the C implementation of removeWatches to have it match ZOOKEEPER-1910 Key: ZOOKEEPER-1919 URL: https://issues.apache.org/jira/browse

[jira] [Commented] (ZOOKEEPER-1910) RemoveWatches wrongly removes the watcher if multiple watches exists on a path

2014-04-24 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980645#comment-13980645 ] Raul Gutierrez Segales commented on ZOOKEEPER-1910: --- +1, thanks

[jira] [Commented] (ZOOKEEPER-730) Recursively Delete a znode

2014-04-24 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980653#comment-13980653 ] Raul Gutierrez Segales commented on ZOOKEEPER-730: -- [~michim]: I am

[jira] [Commented] (ZOOKEEPER-1910) RemoveWatches wrongly removes the watcher if multiple watches exists on a path

2014-04-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978768#comment-13978768 ] Raul Gutierrez Segales commented on ZOOKEEPER-1910: --- I like

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2014-04-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978968#comment-13978968 ] Raul Gutierrez Segales commented on ZOOKEEPER-1366: --- [~michim]: I

[jira] [Commented] (ZOOKEEPER-1910) RemoveWatches wrongly removes the watcher if multiple watches exists on a path

2014-04-22 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977159#comment-13977159 ] Raul Gutierrez Segales commented on ZOOKEEPER-1910: --- Sounds

[jira] [Commented] (ZOOKEEPER-1910) RemoveWatches wrongly removes the watcher if multiple watches exists on a path

2014-04-22 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977163#comment-13977163 ] Raul Gutierrez Segales commented on ZOOKEEPER-1910: --- Just

Re: Review Request 20448: ZOOKEEPER-1910: RemoveWatches wrongly removes the watcher if multiple watches exists on a path

2014-04-21 Thread Raul Gutierrez Segales
/20448/ --- (Updated April 17, 2014, 12:45 p.m.) Review request for zookeeper, michim and Raul Gutierrez Segales. Bugs: ZOOKEEPER-1910 https://issues.apache.org/jira/browse/ZOOKEEPER-1910 Repository: zookeeper

Re: Review Request 20448: ZOOKEEPER-1910: RemoveWatches wrongly removes the watcher if multiple watches exists on a path

2014-04-21 Thread Raul Gutierrez Segales
://reviews.apache.org/r/20448/#comment74352 typo: *registered. ./src/java/main/org/apache/zookeeper/ZooKeeper.java https://reviews.apache.org/r/20448/#comment74353 whether watches can be removed... - Raul Gutierrez Segales On April 17, 2014, 12:45 p.m., Rakesh R wrote

[jira] [Created] (ZOOKEEPER-1913) Invalid manifest files due to bogus revision property value

2014-04-18 Thread Raul Gutierrez Segales (JIRA)
Raul Gutierrez Segales created ZOOKEEPER-1913: - Summary: Invalid manifest files due to bogus revision property value Key: ZOOKEEPER-1913 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1913

[jira] [Updated] (ZOOKEEPER-1913) Invalid manifest files due to bogus revision property value

2014-04-18 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1913: -- Attachment: ZOOKEEPER-1913.patch [~michim], [~rakeshr]: have you

[jira] [Commented] (ZOOKEEPER-1913) Invalid manifest files due to bogus revision property value

2014-04-18 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974589#comment-13974589 ] Raul Gutierrez Segales commented on ZOOKEEPER-1913: --- Thanks

[jira] [Commented] (ZOOKEEPER-1910) RemoveWatches wrongly removes the watcher if multiple watches exists on a path

2014-04-14 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968543#comment-13968543 ] Raul Gutierrez Segales commented on ZOOKEEPER-1910: --- Yeah I

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2014-04-14 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968548#comment-13968548 ] Raul Gutierrez Segales commented on ZOOKEEPER-1807: --- Maybe you

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2014-04-14 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968654#comment-13968654 ] Raul Gutierrez Segales commented on ZOOKEEPER-1807: --- Sorry guys - I

[jira] [Updated] (ZOOKEEPER-1909) removeWatches doesn't return NOWATCHER when there is no watch set

2014-04-12 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1909: -- Attachment: ZOOKEEPER-1909.patch Thanks for the review [~rakeshr

[jira] [Updated] (ZOOKEEPER-1909) removeWatches doesn't return NOWATCHER when there is no watch set

2014-04-11 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1909: -- Attachment: ZOOKEEPER-1909.patch Updated according to [~rakeshr]'s

[jira] [Updated] (ZOOKEEPER-1911) REST contrib module does not include all required files when packaged

2014-04-11 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1911: -- Fix Version/s: 3.5.0 REST contrib module does not include all

[jira] [Commented] (ZOOKEEPER-1911) REST contrib module does not include all required files when packaged

2014-04-11 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966818#comment-13966818 ] Raul Gutierrez Segales commented on ZOOKEEPER-1911: --- fwiw, lgtm +1

[jira] [Updated] (ZOOKEEPER-1911) REST contrib module does not include all required files when packaged

2014-04-11 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1911: -- Affects Version/s: 3.5.0 REST contrib module does not include all

[jira] [Commented] (ZOOKEEPER-1909) removeWatches doesn't return NOWATCHER when there is no watch set

2014-04-10 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965037#comment-13965037 ] Raul Gutierrez Segales commented on ZOOKEEPER-1909: --- bq. I hope

[jira] [Updated] (ZOOKEEPER-1909) removeWatches doesn't return NOWATCHER when there is no watch set

2014-04-10 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1909: -- Attachment: ZOOKEEPER-1909.patch Added a test case. It is a bit

[jira] [Commented] (ZOOKEEPER-1887) C implementation of removeWatches

2014-04-09 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963898#comment-13963898 ] Raul Gutierrez Segales commented on ZOOKEEPER-1887: --- [~michim]: did

Re: Review Request 20071: Improve the thread handling by detecting if any of the critical thread dies.

2014-04-08 Thread Raul Gutierrez Segales
and print that out? We can either go over all threads and check or we can have isRunning throw something like CriticalThreadNotRunning() or such? - Raul Gutierrez Segales On April 7, 2014, 2:01 a.m., Rakesh R wrote

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2014-04-08 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963305#comment-13963305 ] Raul Gutierrez Segales commented on ZOOKEEPER-1907: --- (And I forgot

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2014-04-08 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963304#comment-13963304 ] Raul Gutierrez Segales commented on ZOOKEEPER-1907: --- Commented

[jira] [Updated] (ZOOKEEPER-1887) C implementation of removeWatches

2014-04-07 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1887: -- Attachment: ZOOKEEPER-1887.patch Addressed [~thawan]'s comments

[jira] [Commented] (ZOOKEEPER-1887) C implementation of removeWatches

2014-04-07 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962551#comment-13962551 ] Raul Gutierrez Segales commented on ZOOKEEPER-1887: --- Hmm, so failed

[jira] [Commented] (ZOOKEEPER-1887) C implementation of removeWatches

2014-04-03 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959468#comment-13959468 ] Raul Gutierrez Segales commented on ZOOKEEPER-1887: --- Hey [~michim

[jira] [Commented] (ZOOKEEPER-1904) WatcherTest#testWatchAutoResetWithPending is failing

2014-03-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948072#comment-13948072 ] Raul Gutierrez Segales commented on ZOOKEEPER-1904: --- I see, thanks

[jira] [Commented] (ZOOKEEPER-1904) WatcherTest#testWatchAutoResetWithPending is failing

2014-03-26 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948268#comment-13948268 ] Raul Gutierrez Segales commented on ZOOKEEPER-1904: --- lgtm, +1

Re: Review Request 19522: ZOOKEEPER-1263: Fix handling of min/max session timeout value initialization

2014-03-25 Thread Raul Gutierrez Segales
it all uppercase like a constant (sorry i missed this before). - Raul Gutierrez Segales On March 25, 2014, 6:01 p.m., Rakesh R wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19522

Re: Review Request 19522: ZOOKEEPER-1263: Fix handling of min/max session timeout value initialization

2014-03-25 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19522/#review38498 --- Ship it! Ship It! - Raul Gutierrez Segales On March 25, 2014, 6

Re: Review Request 19522: ZOOKEEPER-1263: Fix handling of min/max session timeout value initialization

2014-03-24 Thread Raul Gutierrez Segales
/19522/#comment70384 why do we need to create/get anything? sounds like asserting you that the negotiated timeout is what was expected should be enough no? - Raul Gutierrez Segales On March 21, 2014, 7:58 a.m., Rakesh R wrote

[jira] [Commented] (ZOOKEEPER-1900) HTTP ERROR 410 Problem accessing /getimage. Reason: GetImage failed. java.io.IOException: Namenode is not expecting an new image UPLOAD_START

2014-03-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944486#comment-13944486 ] Raul Gutierrez Segales commented on ZOOKEEPER-1900: --- [~ddvinay

[jira] [Commented] (ZOOKEEPER-1870) flakey test in StandaloneDisabledTest.startSingleServerTest

2014-03-20 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942159#comment-13942159 ] Raul Gutierrez Segales commented on ZOOKEEPER-1870: --- The last patch

[jira] [Commented] (ZOOKEEPER-1870) flakey test in StandaloneDisabledTest.startSingleServerTest

2014-03-19 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941226#comment-13941226 ] Raul Gutierrez Segales commented on ZOOKEEPER-1870: --- I just got

[jira] [Commented] (ZOOKEEPER-1870) flakey test in StandaloneDisabledTest.startSingleServerTest

2014-03-19 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941227#comment-13941227 ] Raul Gutierrez Segales commented on ZOOKEEPER-1870: --- Also, I

[jira] [Updated] (ZOOKEEPER-1870) flakey test in StandaloneDisabledTest.startSingleServerTest

2014-03-19 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1870: -- Attachment: test.log Hi Michi, Platform is Fedora Linux

[jira] [Commented] (ZOOKEEPER-1870) flakey test in StandaloneDisabledTest.startSingleServerTest

2014-03-19 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941252#comment-13941252 ] Raul Gutierrez Segales commented on ZOOKEEPER-1870: --- Oh

[jira] [Created] (ZOOKEEPER-1896) Reconfig error messages when upgrading from 3.4.6 to 3.5.0

2014-03-17 Thread Raul Gutierrez Segales (JIRA)
Raul Gutierrez Segales created ZOOKEEPER-1896: - Summary: Reconfig error messages when upgrading from 3.4.6 to 3.5.0 Key: ZOOKEEPER-1896 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1896

[jira] [Commented] (ZOOKEEPER-1878) Inconsistent behavior in autocreation of dataDir and dataLogDir

2014-03-14 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935245#comment-13935245 ] Raul Gutierrez Segales commented on ZOOKEEPER-1878: --- lgtm, +1

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

2014-03-14 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review37219 --- Ship it! Ship It! - Raul Gutierrez Segales On March 14, 2014, 2

[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option

2014-03-13 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932896#comment-13932896 ] Raul Gutierrez Segales commented on ZOOKEEPER-1893: --- Would you like

[jira] [Commented] (ZOOKEEPER-1862) ServerCnxnTest.testServerCnxnExpiry is intermittently failing

2014-03-13 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933806#comment-13933806 ] Raul Gutierrez Segales commented on ZOOKEEPER-1862: --- Nice patch

[jira] [Commented] (ZOOKEEPER-1883) C client unit test failures

2014-03-13 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933816#comment-13933816 ] Raul Gutierrez Segales commented on ZOOKEEPER-1883: --- bq. Ok so

[jira] [Commented] (ZOOKEEPER-1883) C client unit test failures

2014-03-13 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933827#comment-13933827 ] Raul Gutierrez Segales commented on ZOOKEEPER-1883: --- Oh, it's fine

[jira] [Commented] (ZOOKEEPER-1894) ObserverTest.testObserver fails consistently

2014-03-13 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934647#comment-13934647 ] Raul Gutierrez Segales commented on ZOOKEEPER-1894: --- bq. It looks

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

2014-03-12 Thread Raul Gutierrez Segales
generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/ --- (Updated March 12, 2014, 4:17 a.m.) Review request for zookeeper, fpj, michim, and Raul Gutierrez Segales. Bugs: ZOOKEEPER-1878 https://issues.apache.org

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

2014-03-12 Thread Raul Gutierrez Segales
workflow, not for the project in general Raul Gutierrez Segales wrote: what about things like: https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/cli/CliCommand.java i see: ``` import org.apache.commons

Re: Review Request 15568: See ZOOKEEPER-1810

2014-03-07 Thread Raul Gutierrez Segales
On March 5, 2014, 6:12 p.m., Raul Gutierrez Segales wrote: ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java, line 569 https://reviews.apache.org/r/15568/diff/4/?file=510840#file510840line569 if this is only used for tests, shouldn't we extend this class

Re: Review Request 15568: See ZOOKEEPER-1810

2014-03-05 Thread Raul Gutierrez Segales
i said above about moving this assertion inline with the test cases. - Raul Gutierrez Segales On March 5, 2014, 3:26 p.m., German Blanco wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk

2014-03-05 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921143#comment-13921143 ] Raul Gutierrez Segales commented on ZOOKEEPER-1810: --- Thanks

[jira] [Commented] (ZOOKEEPER-1887) C implementation of removeWatches

2014-03-03 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918359#comment-13918359 ] Raul Gutierrez Segales commented on ZOOKEEPER-1887: --- Thanks

[jira] [Commented] (ZOOKEEPER-1889) Implement Top-N sort operator

2014-02-25 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13912335#comment-13912335 ] Raul Gutierrez Segales commented on ZOOKEEPER-1889: --- Sounds like

[jira] [Commented] (ZOOKEEPER-1887) C implementation of removeWatches

2014-02-24 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910489#comment-13910489 ] Raul Gutierrez Segales commented on ZOOKEEPER-1887: --- Heads-up

[jira] [Updated] (ZOOKEEPER-1887) C implemenation of removeWatches

2014-02-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1887: -- Summary: C implemenation of removeWatches (was: C implmemenation

[jira] [Created] (ZOOKEEPER-1887) C implmemenation of removeWatches

2014-02-23 Thread Raul Gutierrez Segales (JIRA)
Raul Gutierrez Segales created ZOOKEEPER-1887: - Summary: C implmemenation of removeWatches Key: ZOOKEEPER-1887 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1887 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-1887) C implementation of removeWatches

2014-02-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1887: -- Summary: C implementation of removeWatches (was: C implemenation

[jira] [Commented] (ZOOKEEPER-1829) Umbrella jira for removing watches that are no longer of interest

2014-02-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909960#comment-13909960 ] Raul Gutierrez Segales commented on ZOOKEEPER-1829: --- Hi [~abalmin

[jira] [Updated] (ZOOKEEPER-1887) C implementation of removeWatches

2014-02-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1887: -- Attachment: ZOOKEEPER-1887.patch No tests yet, will add them later

[jira] [Updated] (ZOOKEEPER-1887) C implementation of removeWatches

2014-02-23 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1887: -- Attachment: ZOOKEEPER-1887.patch Added (very) basic tests

[jira] [Commented] (ZOOKEEPER-1885) Znodes deletable by anyone without having the rights to do so

2014-02-20 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907234#comment-13907234 ] Raul Gutierrez Segales commented on ZOOKEEPER-1885: --- Two things

[jira] [Updated] (ZOOKEEPER-1883) C client unit test failures

2014-02-19 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1883: -- Fix Version/s: 3.5.0 C client unit test failures

[jira] [Updated] (ZOOKEEPER-1883) C client unit test failures

2014-02-19 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1883: -- Attachment: ZOOKEEPER-1883.patch C client unit test failures

[jira] [Commented] (ZOOKEEPER-1883) C client unit test failures

2014-02-19 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906209#comment-13906209 ] Raul Gutierrez Segales commented on ZOOKEEPER-1883: --- Thanks

<    3   4   5   6   7   8   9   10   >