[
https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044921#comment-14044921
]
Raul Gutierrez Segales commented on ZOOKEEPER-1933:
---
Hi [~fpj
PRE-CREATION
src/c/tests/ZKMocks.h fbcfc4f
src/c/tests/ZKMocks.cc f97c943
src/c/tests/quorum.cfg PRE-CREATION
src/c/tests/zkServer.sh 0af80f8
Diff: https://reviews.apache.org/r/23081/diff/
Testing
---
all tests pass, *should* compile on Windows.
Thanks,
Raul Gutierrez
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045028#comment-14045028
]
Raul Gutierrez Segales commented on ZOOKEEPER-827:
--
Sure, [~fpj], here
src/java/main/org/apache/zookeeper/server/DataTree.java f2a4f86
src/java/main/org/apache/zookeeper/server/WatchManager.java 39bf82e
Diff: https://reviews.apache.org/r/23085/diff/
Testing
---
Thanks,
Raul Gutierrez Segales
/something/
```
Thanks,
Raul Gutierrez Segales
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045044#comment-14045044
]
Raul Gutierrez Segales commented on ZOOKEEPER-1274:
---
Ah fair, do you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045272#comment-14045272
]
Raul Gutierrez Segales commented on ZOOKEEPER-1274:
---
Hmm
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043775#comment-14043775
]
Raul Gutierrez Segales commented on ZOOKEEPER-1851:
---
[~thawan
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043832#comment-14043832
]
Raul Gutierrez Segales commented on ZOOKEEPER-1784:
---
[~phunt
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043835#comment-14043835
]
Raul Gutierrez Segales commented on ZOOKEEPER-1919:
---
Oops, sorry
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043838#comment-14043838
]
Raul Gutierrez Segales commented on ZOOKEEPER-1877:
---
[~cchen
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043914#comment-14043914
]
Raul Gutierrez Segales commented on ZOOKEEPER-1946:
---
[~vuakko]: what
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044211#comment-14044211
]
Raul Gutierrez Segales commented on ZOOKEEPER-1787:
---
[~thawan
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1274:
--
Summary: Support child watches to be displayed with 4 letter
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1274:
--
Attachment: ZOOKEEPER-1274.patch
Here's an updated version
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042727#comment-14042727
]
Raul Gutierrez Segales commented on ZOOKEEPER-827:
--
Actually, ignoring
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043073#comment-14043073
]
Raul Gutierrez Segales commented on ZOOKEEPER-1946:
---
Hi [~vuakko
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-827:
-
Attachment: ZOOKEEPER-827.patch
Made the Windows related #ifdefs
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036336#comment-14036336
]
Raul Gutierrez Segales commented on ZOOKEEPER-827:
--
Hmm, weird
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034440#comment-14034440
]
Raul Gutierrez Segales commented on ZOOKEEPER-827:
--
Thanks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034449#comment-14034449
]
Raul Gutierrez Segales commented on ZOOKEEPER-827:
--
Hmm, looks like we
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034553#comment-14034553
]
Raul Gutierrez Segales commented on ZOOKEEPER-1934:
---
Well, but you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1938:
--
Attachment: ZOOKEEPER-1938.patch
Oops, good catch [~rakeshr
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030137#comment-14030137
]
Raul Gutierrez Segales commented on ZOOKEEPER-1939:
---
patch lgtm, +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030166#comment-14030166
]
Raul Gutierrez Segales commented on ZOOKEEPER-1937:
---
[~marshall
Raul Gutierrez Segales created ZOOKEEPER-1938:
-
Summary: bump version in the C library as we prepare for 3.5.0
release
Key: ZOOKEEPER-1938
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1938
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028829#comment-14028829
]
Raul Gutierrez Segales commented on ZOOKEEPER-1938:
---
cc: [~michim
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-827:
-
Attachment: ZOOKEEPER-827.patch
hi [~michim], i've updated the patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026126#comment-14026126
]
Raul Gutierrez Segales commented on ZOOKEEPER-827:
--
Thanks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales reassigned ZOOKEEPER-827:
Assignee: Raul Gutierrez Segales (was: Sergey Doroshenko
[
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-827:
-
Attachment: ZOOKEEPER-827.patch
I've rebased the available patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009080#comment-14009080
]
Raul Gutierrez Segales commented on ZOOKEEPER-1929:
---
how can I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009082#comment-14009082
]
Raul Gutierrez Segales commented on ZOOKEEPER-1907:
---
[~rakeshr
[
https://issues.apache.org/jira/browse/ZOOKEEPER-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009094#comment-14009094
]
Raul Gutierrez Segales commented on ZOOKEEPER-770:
--
lgtm, +1 - thanks
Raul Gutierrez Segales created ZOOKEEPER-1919:
-
Summary: Update the C implementation of removeWatches to have it
match ZOOKEEPER-1910
Key: ZOOKEEPER-1919
URL: https://issues.apache.org/jira/browse
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980645#comment-13980645
]
Raul Gutierrez Segales commented on ZOOKEEPER-1910:
---
+1, thanks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980653#comment-13980653
]
Raul Gutierrez Segales commented on ZOOKEEPER-730:
--
[~michim]: I am
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978768#comment-13978768
]
Raul Gutierrez Segales commented on ZOOKEEPER-1910:
---
I like
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978968#comment-13978968
]
Raul Gutierrez Segales commented on ZOOKEEPER-1366:
---
[~michim]: I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977159#comment-13977159
]
Raul Gutierrez Segales commented on ZOOKEEPER-1910:
---
Sounds
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977163#comment-13977163
]
Raul Gutierrez Segales commented on ZOOKEEPER-1910:
---
Just
/20448/
---
(Updated April 17, 2014, 12:45 p.m.)
Review request for zookeeper, michim and Raul Gutierrez Segales.
Bugs: ZOOKEEPER-1910
https://issues.apache.org/jira/browse/ZOOKEEPER-1910
Repository: zookeeper
://reviews.apache.org/r/20448/#comment74352
typo: *registered.
./src/java/main/org/apache/zookeeper/ZooKeeper.java
https://reviews.apache.org/r/20448/#comment74353
whether watches can be removed...
- Raul Gutierrez Segales
On April 17, 2014, 12:45 p.m., Rakesh R wrote
Raul Gutierrez Segales created ZOOKEEPER-1913:
-
Summary: Invalid manifest files due to bogus revision property
value
Key: ZOOKEEPER-1913
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1913
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1913:
--
Attachment: ZOOKEEPER-1913.patch
[~michim], [~rakeshr]: have you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974589#comment-13974589
]
Raul Gutierrez Segales commented on ZOOKEEPER-1913:
---
Thanks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968543#comment-13968543
]
Raul Gutierrez Segales commented on ZOOKEEPER-1910:
---
Yeah I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968548#comment-13968548
]
Raul Gutierrez Segales commented on ZOOKEEPER-1807:
---
Maybe you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968654#comment-13968654
]
Raul Gutierrez Segales commented on ZOOKEEPER-1807:
---
Sorry guys - I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1909:
--
Attachment: ZOOKEEPER-1909.patch
Thanks for the review [~rakeshr
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1909:
--
Attachment: ZOOKEEPER-1909.patch
Updated according to [~rakeshr]'s
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1911:
--
Fix Version/s: 3.5.0
REST contrib module does not include all
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966818#comment-13966818
]
Raul Gutierrez Segales commented on ZOOKEEPER-1911:
---
fwiw, lgtm +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1911:
--
Affects Version/s: 3.5.0
REST contrib module does not include all
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965037#comment-13965037
]
Raul Gutierrez Segales commented on ZOOKEEPER-1909:
---
bq. I hope
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1909:
--
Attachment: ZOOKEEPER-1909.patch
Added a test case. It is a bit
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963898#comment-13963898
]
Raul Gutierrez Segales commented on ZOOKEEPER-1887:
---
[~michim]: did
and print that out? We can either go over all threads and check or we
can have isRunning throw something like CriticalThreadNotRunning() or such?
- Raul Gutierrez Segales
On April 7, 2014, 2:01 a.m., Rakesh R wrote
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963305#comment-13963305
]
Raul Gutierrez Segales commented on ZOOKEEPER-1907:
---
(And I forgot
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963304#comment-13963304
]
Raul Gutierrez Segales commented on ZOOKEEPER-1907:
---
Commented
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1887:
--
Attachment: ZOOKEEPER-1887.patch
Addressed [~thawan]'s comments
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962551#comment-13962551
]
Raul Gutierrez Segales commented on ZOOKEEPER-1887:
---
Hmm, so failed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959468#comment-13959468
]
Raul Gutierrez Segales commented on ZOOKEEPER-1887:
---
Hey [~michim
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948072#comment-13948072
]
Raul Gutierrez Segales commented on ZOOKEEPER-1904:
---
I see, thanks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948268#comment-13948268
]
Raul Gutierrez Segales commented on ZOOKEEPER-1904:
---
lgtm, +1
it all uppercase like a constant
(sorry i missed this before).
- Raul Gutierrez Segales
On March 25, 2014, 6:01 p.m., Rakesh R wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19522
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19522/#review38498
---
Ship it!
Ship It!
- Raul Gutierrez Segales
On March 25, 2014, 6
/19522/#comment70384
why do we need to create/get anything? sounds like asserting you that the
negotiated timeout is what was expected should be enough no?
- Raul Gutierrez Segales
On March 21, 2014, 7:58 a.m., Rakesh R wrote
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944486#comment-13944486
]
Raul Gutierrez Segales commented on ZOOKEEPER-1900:
---
[~ddvinay
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942159#comment-13942159
]
Raul Gutierrez Segales commented on ZOOKEEPER-1870:
---
The last patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941226#comment-13941226
]
Raul Gutierrez Segales commented on ZOOKEEPER-1870:
---
I just got
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941227#comment-13941227
]
Raul Gutierrez Segales commented on ZOOKEEPER-1870:
---
Also, I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1870:
--
Attachment: test.log
Hi Michi,
Platform is Fedora Linux
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941252#comment-13941252
]
Raul Gutierrez Segales commented on ZOOKEEPER-1870:
---
Oh
Raul Gutierrez Segales created ZOOKEEPER-1896:
-
Summary: Reconfig error messages when upgrading from 3.4.6 to 3.5.0
Key: ZOOKEEPER-1896
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1896
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935245#comment-13935245
]
Raul Gutierrez Segales commented on ZOOKEEPER-1878:
---
lgtm, +1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19089/#review37219
---
Ship it!
Ship It!
- Raul Gutierrez Segales
On March 14, 2014, 2
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932896#comment-13932896
]
Raul Gutierrez Segales commented on ZOOKEEPER-1893:
---
Would you like
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933806#comment-13933806
]
Raul Gutierrez Segales commented on ZOOKEEPER-1862:
---
Nice patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933816#comment-13933816
]
Raul Gutierrez Segales commented on ZOOKEEPER-1883:
---
bq. Ok so
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933827#comment-13933827
]
Raul Gutierrez Segales commented on ZOOKEEPER-1883:
---
Oh, it's fine
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934647#comment-13934647
]
Raul Gutierrez Segales commented on ZOOKEEPER-1894:
---
bq. It looks
generated e-mail. To reply, visit:
https://reviews.apache.org/r/19089/
---
(Updated March 12, 2014, 4:17 a.m.)
Review request for zookeeper, fpj, michim, and Raul Gutierrez Segales.
Bugs: ZOOKEEPER-1878
https://issues.apache.org
workflow, not for the project in general
Raul Gutierrez Segales wrote:
what about things like:
https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/cli/CliCommand.java
i see:
```
import org.apache.commons
On March 5, 2014, 6:12 p.m., Raul Gutierrez Segales wrote:
./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java,
line 569
https://reviews.apache.org/r/15568/diff/4/?file=510840#file510840line569
if this is only used for tests, shouldn't we extend this class
i said above about moving this assertion inline with the test cases.
- Raul Gutierrez Segales
On March 5, 2014, 3:26 p.m., German Blanco wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921143#comment-13921143
]
Raul Gutierrez Segales commented on ZOOKEEPER-1810:
---
Thanks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918359#comment-13918359
]
Raul Gutierrez Segales commented on ZOOKEEPER-1887:
---
Thanks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13912335#comment-13912335
]
Raul Gutierrez Segales commented on ZOOKEEPER-1889:
---
Sounds like
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910489#comment-13910489
]
Raul Gutierrez Segales commented on ZOOKEEPER-1887:
---
Heads-up
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1887:
--
Summary: C implemenation of removeWatches (was: C implmemenation
Raul Gutierrez Segales created ZOOKEEPER-1887:
-
Summary: C implmemenation of removeWatches
Key: ZOOKEEPER-1887
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1887
Project: ZooKeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1887:
--
Summary: C implementation of removeWatches (was: C implemenation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909960#comment-13909960
]
Raul Gutierrez Segales commented on ZOOKEEPER-1829:
---
Hi [~abalmin
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1887:
--
Attachment: ZOOKEEPER-1887.patch
No tests yet, will add them later
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1887:
--
Attachment: ZOOKEEPER-1887.patch
Added (very) basic tests
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907234#comment-13907234
]
Raul Gutierrez Segales commented on ZOOKEEPER-1885:
---
Two things
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1883:
--
Fix Version/s: 3.5.0
C client unit test failures
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-1883:
--
Attachment: ZOOKEEPER-1883.patch
C client unit test failures
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906209#comment-13906209
]
Raul Gutierrez Segales commented on ZOOKEEPER-1883:
---
Thanks
701 - 800 of 954 matches
Mail list logo