Re: [VOTE] move Apache Zookeeper to git

Patrick, The 'dummy commit' is a Github trick. In any commit message you can write "closes #", like "closes #84" (by my own experience you can also write "fixes #". You can put as many of those messages as you like in the commit message even if the commit doesn't have relation with the PRs. Then

Re: [VOTE] move Apache Zookeeper to git

On Wed, Dec 7, 2016 at 2:09 PM, Patrick Hunt wrote: > Interesting, thanks for the update Edward. > > "close via a dummy commit" - I don't think that's possible, doesn't GH > match up a PR to a commit based on the hash? > ​Afaik, yes. I didn't understand what he meant by 'dummy

Re: [VOTE] move Apache Zookeeper to git

Interesting, thanks for the update Edward. "close via a dummy commit" - I don't think that's possible, doesn't GH match up a PR to a commit based on the hash? Patrick On Tue, Dec 6, 2016 at 6:17 AM, Edward Ribeiro wrote: > Oh, Patrick (and Flavio, and Ben Reed), > >

Re: [VOTE] move Apache Zookeeper to git

Oh, Patrick (and Flavio, and Ben Reed), I asked some questions to one ASF committer that has been using the Github-JIRA-Apache combo for a while now. According to him, committers *cannot* manually close 3rd party PRs. :( He said this is a combination of Github limitations and INFRA policies, his

Re: [VOTE] move Apache Zookeeper to git

No problem Edward. Did you get any insight on what to do with the PR? Patrick On Thu, Nov 24, 2016 at 10:52 AM, Edward Ribeiro wrote: > Hi, Patrick, > > Thanks for merging this change. :) > > Sincerely, I don't know why it didn't close the PR automatically. Nor why >

Re: [VOTE] move Apache Zookeeper to git

Hi, Patrick, Thanks for merging this change. :) Sincerely, I don't know why it didn't close the PR automatically. Nor why you can close it in the GH mirror. In any case, I manually closed it. I will ping folks from other Apache projects using similar tool to inquire why it didn't close the PR

Re: [VOTE] move Apache Zookeeper to git

Thanks Edward, this should be very helpful for folks. I committed, however I notice the PR is still open. I followed the steps here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes however I don't see a way to close the PR? https://github.com/apache/zookeeper/pull/103 says

Re: [VOTE] move Apache Zookeeper to git

Hi Patrick, I've just opened a PR https://github.com/apache/zookeeper/pull/103/ PR It asks for JIRA_PASSWORD at CLI prompt *IF* it's absent but JIRA_USERNAME is already set. Please, when you have time, see if it fits what you need and then I can open a JIRA, rename the feature branch, etc. Let

Re: [VOTE] move Apache Zookeeper to git

Hi Patrick, We can change the script so that it asks for jira password input on CLI prompt if the JIRA username is set, for example. The change should be straigthforward. Alternatively, the python systems I have dealt with put credentials for database access, etc, in configuration -- sometimes

Re: [VOTE] move Apache Zookeeper to git

AFAIK, yes. I say, if you mean to run unit tests and other CI tasks on PR. PS: I have just created a simple script HowTo at https://cwiki.apache.org/confluence/display/ZOOKEEPER/Merging+Github+Pull+Requests and linked from https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index On Wed, Oct

Re: [VOTE] move Apache Zookeeper to git

What about QA, are we still missing a github pre-commit queue? -Flavio > On 26 Oct 2016, at 18:53, Michael Han wrote: > > The comment bridging should be fixed now - see INFRA-12752 for more > details. > > On Wed, Oct 26, 2016 at 10:03 AM, Michael Han

Re: [VOTE] move Apache Zookeeper to git

The comment bridging should be fixed now - see INFRA-12752 for more details. On Wed, Oct 26, 2016 at 10:03 AM, Michael Han wrote: > >> The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA. > > The bridge was working the day Infra made the change - see the

Re: [VOTE] move Apache Zookeeper to git

>> The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA. The bridge was working the day Infra made the change - see the previous comments made by git bot on ZOOKEEPER-761. Now it seems stop working. I am reopening INFRA-12752 and building a case. On Wed, Oct 26, 2016 at 9:45

Re: [VOTE] move Apache Zookeeper to git

Thanks, Eddie. This is great. > On 26 Oct 2016, at 17:45, Edward Ribeiro wrote: > (still very crude, but feel free to improve it). I would like to move this > text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index but > looks like I don't have permission to

Re: [VOTE] move Apache Zookeeper to git

Dear community, The zk-merger-pr.py script has been merged into master (thanks a LOT Ben Reed for reviewing/discussing/testing and commiting): https://issues.apache.org/jira/browse/ZOOKEEPER-2597 As stated in the issue and on GH, this tool is a modified version of similar tools from Kafka, that

Re: [VOTE] move Apache Zookeeper to git

This is not supported at the moment if nothing has changed: https://issues.apache.org/jira/browse/INFRA-11000 -Flavio > On 08 Oct 2016, at 00:54, Benjamin Reed wrote: > > it doesn't look like we need to setup keys. this

Re: [VOTE] move Apache Zookeeper to git

it doesn't look like we need to setup keys. this seems to work for me: https://git-wip-us.apache.org/#committers-getting-started it does seem strange that we aren't using public keys and that i'm sticking a password in .netrc :P i'm wondering if other projects were able to get this going over

Re: [VOTE] move Apache Zookeeper to git

Hey folks, So I'm trying to get in a patch but this has not been updated to tell committers how to actually get the git keys set up: https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes Can someone float me a link that says how to do this? Also a bunch of our documentation

Re: [VOTE] move Apache Zookeeper to git

Excuse me guys! I've written on Macbook Pro. No idea why GMail messed it up. I was only able to see the strange characters when I pasted on a gist text area. The previous message is below, but if anyone is still having trouble (I tried to remove the weird character), I left a copy at:

Re: [VOTE] move Apache Zookeeper to git

Eddie's mail contains lots of '=E2=80=8B'' which is unicode character zero-width space, which might cause parsing trouble for some mail clients. On Wed, Oct 5, 2016 at 6:42 AM, Flavio Junqueira wrote: > Dude, I'm just not able to parse your e-mail, did you write that on a >

Re: [VOTE] move Apache Zookeeper to git

Dude, I'm just not able to parse your e-mail, did you write that on a phone or something? -Flavio > On 05 Oct 2016, at 03:54, Edward Ribeiro wrote: > > Hi, > > The patch attached on ZOOKEEPER-2597 is a > ​straightforward adaptation of > Kafka's one. It takes care of

Re: [VOTE] move Apache Zookeeper to git

Apparently, infra allowed Kafka to not have comments written to the dev list or jira. There is a thread discussing whether that decision should be reverted or not. Not sure how much value it adds to this discussion, but it is good to have another reference:

Re: [VOTE] move Apache Zookeeper to git

Hi, The patch attached on ZOOKEEPER-2597 is a ​straightforward adaptation of Kafka's one. It takes care of merging Github PR into Apache git repo and ​ a​ subsequent closing of the PR on the GH side ​ among other things (rewriting of commit messages, etc)​ . The current status is: the script

Re: [VOTE] move Apache Zookeeper to git

>> as long as the opening/closing/commenting all get sent to the mailing list or recorded in jira Yeah, this is my impression as well, that we need to keep certain paper trail regarding activities and comments on ASF side (JIRA or mail list). Infra page said: - Any Pull Request that gets

Re: [VOTE] move Apache Zookeeper to git

Until ZOOKEEPER-2597 is fixed, we can't merge via github. For code reviews, we can use GH as long as the opening/closing/commenting all get sent to the mailing list or recorded in jira. I don't think we have that yet, but it is possible

Re: [VOTE] move Apache Zookeeper to git

Hi, Now we've moved to git, what is the policy for uploading patches and doing code reviews? I am asking because I've seen recently there are git pull requests coming in without associated patch file uploaded to JIRA. I've checked

Re: [VOTE] move Apache Zookeeper to git

Cool, just open https://issues.apache.org/jira/browse/ZOOKEEPER-2597 PS: I removed the REPO_HOME global variable. On Wed, Sep 21, 2016 at 6:53 AM, Flavio Junqueira wrote: > Better to have that in the form of a pull request or diff. > > REPO_HOME does seem to be unused. > >

Re: [VOTE] move Apache Zookeeper to git

Better to have that in the form of a pull request or diff. REPO_HOME does seem to be unused. -Flavio > On 20 Sep 2016, at 18:57, Edward Ribeiro wrote: > > Hey, I have started porting the kafka-merge.py to work on ZK repos. I would > need someone to review it and

Re: [VOTE] move Apache Zookeeper to git

Hey, I have started porting the kafka-merge.py to work on ZK repos. I would need someone to review it and help me test it now. The files were uploaded below, but I will create a github repo yet today. https://www.dropbox.com/sh/od8bet2574jttm3/AADv1DXTb8vfyVCmelFbYCEha?dl=0 I uploaded the kafka

Re: [VOTE] move Apache Zookeeper to git

On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed wrote: > what you are suggesting sounds good, but i don't know how to do it? since > in the end we are still just accepting diffs on patches, the only thing > that changes is that we use svn rather than git right? > > Notice the

Re: [VOTE] move Apache Zookeeper to git

Interesting, still works for me copying and pasting from the message. -Flavio > On 20 Sep 2016, at 16:11, Patrick Hunt wrote: > > I'm afraid that link doesn't work for me, updated link: > http://markmail.org/message/4engzfzfpjd42smp > > Patrick > > On Tue, Sep 20, 2016 at

Re: [VOTE] move Apache Zookeeper to git

I'm afraid that link doesn't work for me, updated link: http://markmail.org/message/4engzfzfpjd42smp Patrick On Tue, Sep 20, 2016 at 5:51 AM, Flavio Junqueira wrote: > This is the mail thread where Chris raised it: > > http://mail-archives.apache.org/mod_mbox//zookeeper-dev/ >

Re: [VOTE] move Apache Zookeeper to git

This is the mail thread where Chris raised it: http://mail-archives.apache.org/mod_mbox//zookeeper-dev/201607.mbox/%3cd3b6a1e8.4977a%25cnaur...@hortonworks.com%3e -Flavio > On

Re: [VOTE] move Apache Zookeeper to git

Just out of curiosity, what's the motivation behind getting rid of CHANGES.txt? Eddie On Mon, Sep 19, 2016 at 8:11 PM, Benjamin Reed wrote: > what you are suggesting sounds good, but i don't know how to do it? since > in the end we are still just accepting diffs on patches,

Re: [VOTE] move Apache Zookeeper to git

what you are suggesting sounds good, but i don't know how to do it? since in the end we are still just accepting diffs on patches, the only thing that changes is that we use svn rather than git right? i LOVE chris's idea! lets do it! ben On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt

Re: [VOTE] move Apache Zookeeper to git

Ben, do you also want to update the "Applying a patch" section to make it git specific? We (committers) should move to a model where authors get proper credit in git. Our old workflow in svn resulted in only the committer being listed (except that we listed the patch author in the commit

Re: [VOTE] move Apache Zookeeper to git

> > > 1) actually in the previous step that was just adding new files. you > still > > need the commit -a for the rest of the changes. that's my normal > workflow. > > I think that will be confusing for most folks. They typically stage > all the changes and then commit or don't stage and use -a. >

Re: [VOTE] move Apache Zookeeper to git

On Wed, Sep 14, 2016 at 9:35 AM, Benjamin Reed wrote: > 1) actually in the previous step that was just adding new files. you still > need the commit -a for the rest of the changes. that's my normal workflow. I think that will be confusing for most folks. They typically stage

Re: [VOTE] move Apache Zookeeper to git

1) actually in the previous step that was just adding new files. you still need the commit -a for the rest of the changes. that's my normal workflow. 2) i figured since we are using git now that we should use git's default. the patch should work (by default it seems to strip the first path

Re: [VOTE] move Apache Zookeeper to git

btw, there is an INFRA jira to get gerritt, but the status of it is very unclear: https://issues.apache.org/jira/browse/INFRA-2205 On Tue, Sep 13, 2016 at 1:30 AM, Flavio Junqueira wrote: > Thanks, Ben and Pat. Is there anyone wiling to pick this up? I believe > there are some

Re: [VOTE] move Apache Zookeeper to git

A few references that Ismael Juma kindly passed to me with respect to the github integration and might be helpful here: Blogs from Infra: https://blogs.apache.org/infra/entry/github_pull_request_builds_now https://blogs.apache.org/infra/entry/improved_integration_between_apache_and Kafka merge

Re: [VOTE] move Apache Zookeeper to git

Infra doesn't allow projects to admin their own gh.com mirrors (I just checked). Michael - can you comment on https://issues.apache.org/jira/browse/INFRA-12573 and point this out? I agree that the default should be master. Thanks Michael. Patrick On Tue, Sep 13, 2016 at 10:03 PM, Michael Han

Re: [VOTE] move Apache Zookeeper to git

I noticed that in https://github.com/apache/zookeeper, the default branch is set to ZOOKEEPER-823. Not sure if that is intended, but I remembered the old mirror (before git-svn migration) was set to trunk. Probably we should set the default branch to master. On Tue, Sep 13, 2016 at 2:02 PM,

Re: [VOTE] move Apache Zookeeper to git

Hi Ben. I didn't review it fully, but it looks like there are at least two issues: 1) you shouldn't have the person "git commit -a" given the previous commands added the files the user is interested in submitting. I think you just mean to "git commit" ? 2) you dropped the "--no-prefix" from the

Re: [VOTE] move Apache Zookeeper to git

Hey, Flavio, I am with some sparing cycles this week (and genuinely curious about this integration between ASF git repo and Github's), so I can volunteer to pick up this. Could you or another committer guide me, please? :) Thanks, Edward On Tue, Sep 13, 2016 at 5:30 AM, Flavio Junqueira

Re: [VOTE] move Apache Zookeeper to git

Thanks, Ben and Pat. Is there anyone wiling to pick this up? I believe there are some scripts involved to do the workflow integration with github. I'd look at projects like Kafka and BookKeeper, which I know have done it, and replicate it. You don't have to be a committer to work on this, but

Re: [VOTE] move Apache Zookeeper to git

Cool, thanks. I've re-enabled the precommit job, reconfigured it, and it seems to be working again. LMK if you notice any issues. Patrick On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés wrote: > On 12 September 2016 at 17:48, Patrick Hunt wrote: > >>

Re: [VOTE] move Apache Zookeeper to git

On 12 September 2016 at 17:48, Patrick Hunt wrote: > On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés > wrote: > > On 12 September 2016 at 09:58, Patrick Hunt wrote: > > > >> Here it is, please take a look, review, and commit it

Re: [VOTE] move Apache Zookeeper to git

On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés wrote: > On 12 September 2016 at 09:58, Patrick Hunt wrote: > >> Here it is, please take a look, review, and commit it to master >> (remember, needs to be git now :-) ) >>

Re: [VOTE] move Apache Zookeeper to git

On 12 September 2016 at 09:58, Patrick Hunt wrote: > Here it is, please take a look, review, and commit it to master > (remember, needs to be git now :-) ) > https://issues.apache.org/jira/browse/ZOOKEEPER-2576 Merged:

Re: [VOTE] move Apache Zookeeper to git

Here it is, please take a look, review, and commit it to master (remember, needs to be git now :-) ) https://issues.apache.org/jira/browse/ZOOKEEPER-2576 Patrick On Mon, Sep 12, 2016 at 9:10 AM, Patrick Hunt wrote: > I worked up a patch last night, I'll create the jira and

Re: [VOTE] move Apache Zookeeper to git

I worked up a patch last night, I'll create the jira and attach the patch later today when I get a few. Patrick On Mon, Sep 12, 2016 at 7:29 AM, Flavio Junqueira wrote: > >> On 12 Sep 2016, at 06:42, Patrick Hunt wrote: >> >> afaik there has never been github

Re: [VOTE] move Apache Zookeeper to git

> On 12 Sep 2016, at 06:42, Patrick Hunt wrote: > > afaik there has never been github integration for anything with ZK. > QAbot only runs against jira/svn. I'm not sure what you're trying to say here. Both Apache Kafka and Apache BookKeeper use ZK and currently use github.

Re: [VOTE] move Apache Zookeeper to git

afaik there has never been github integration for anything with ZK. QAbot only runs against jira/svn. FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten them working again. There was a ton of cruft in there which I attempted to cleanup. I think things should be ok, but I will

Re: [VOTE] move Apache Zookeeper to git

sure. i'll update it to reference git rather than svn. if i understand correctly pull requests that were submitted via github were reviewed by the qa bot (or something like that) in the past, but it was turned off. we should turn that back on i think. thanx ben On Sun, Sep 11, 2016 at 8:49 PM,

Re: [VOTE] move Apache Zookeeper to git

FYI Apache INFRA has made the cutover - https://issues.apache.org/jira/browse/INFRA-12573 At this point we need to update the "how to contribute" etc... Ben do you want to take a stab at that? I can update the respective Jenkins jobs. What else is there? Patrick On Wed, Sep 7, 2016 at 9:59 AM,

Re: [VOTE] move Apache Zookeeper to git

Thank you for doing this, Eddie. I just picked up the code review. --Chris Nauroth On 9/7/16, 9:49 AM, "Edward Ribeiro" wrote: Hey folks, as part of this major change, I took a look at the gitignore and it already lacks a lot of file extensions for a modern

Re: [VOTE] move Apache Zookeeper to git

Hey folks, as part of this major change, I took a look at the gitignore and it already lacks a lot of file extensions for a modern Java project. Therefore, I created a trivial patch (shameless plug) that updates for more commonly extensions: https://issues.apache.org/jira/browse/ZOOKEEPER-2557

Re: [VOTE] move Apache Zookeeper to git

+1 > On 07 Sep 2016, at 06:10, Patrick Hunt wrote: > > Quick update (more details on the INFRA jira). It might take upwards of 24 > hours to do the svn->git migration although our repo isn't that large, > likely less. INFRA can do it, for example, on Saturday around 18:00 UTC.

Re: [VOTE] move Apache Zookeeper to git

Quick update (more details on the INFRA jira). It might take upwards of 24 hours to do the svn->git migration although our repo isn't that large, likely less. INFRA can do it, for example, on Saturday around 18:00 UTC. Any concerns with such an approach? Patrick On Sun, Sep 4, 2016 at 9:20 PM,

Re: [VOTE] move Apache Zookeeper to git

Follow along here: https://issues.apache.org/jira/browse/INFRA-12573 Patrick On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed wrote: > with 10 votes for (5 of which are from the PMC) on no votes against. the > vote passes. > > pat please make git happen! :) > > thanx for voting!

Re: [VOTE] move Apache Zookeeper to git

with 10 votes for (5 of which are from the PMC) on no votes against. the vote passes. pat please make git happen! :) thanx for voting! On Thu, Sep 1, 2016 at 9:25 AM, Michael Han wrote: > +1 > > On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan wrote: > >

Re: [VOTE] move Apache Zookeeper to git

+1 On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan wrote: > +1 > > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira wrote: > > > +1 > > > > > On 01 Sep 2016, at 13:28, Edward Ribeiro > > wrote: > > > > > > +1 (non binding) > > > >

Voting procedure (was: Re: [VOTE] move Apache Zookeeper to git)

We say in the bylaws that for technical decisions, the votes of active committers are binding, so some of the votes I see here are actually binding (e.g., Rakesh's vote). As for length, 72 hours sounds appropriate and lazy consensus is my preference, even though so far all votes are +1, so it

Re: [VOTE] move Apache Zookeeper to git

+1 On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira wrote: > +1 > > > On 01 Sep 2016, at 13:28, Edward Ribeiro > wrote: > > > > +1 (non binding) > > > > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman < > jor...@jordanzimmerman.com > >> wrote: > > >

Re: [VOTE] move Apache Zookeeper to git

+1 > On 01 Sep 2016, at 13:28, Edward Ribeiro wrote: > > +1 (non binding) > > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman > wrote: > >> +1 (non binding) >> >>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed wrote: >>>

Re: [VOTE] move Apache Zookeeper to git

+1 (non binding) On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman wrote: > +1 (non binding) > > > On Aug 31, 2016, at 8:29 PM, Benjamin Reed wrote: > > > > flip the switch to git and update the relevant scripts and docs. > > > > i couldn't figure

Re: [VOTE] move Apache Zookeeper to git

+1 (non-binding) Rakesh On Thu, Sep 1, 2016 at 10:40 AM, Raúl Gutiérrez Segalés wrote: > +1 > > -rgs > > On Aug 31, 2016 3:29 PM, "Benjamin Reed" wrote: > > > flip the switch to git and update the relevant scripts and docs. > > > > i couldn't figure

Re: [VOTE] move Apache Zookeeper to git

+1 -rgs On Aug 31, 2016 3:29 PM, "Benjamin Reed" wrote: > flip the switch to git and update the relevant scripts and docs. > > i couldn't figure out which timeframe this falls under in the voting > procedure table, but i think it's safe to go with 3 days, so the vote will >

Re: [VOTE] move Apache Zookeeper to git

+1. Patrick On Wed, Aug 31, 2016 at 9:48 PM, Chris Nauroth wrote: > +1 > > --Chris Nauroth > > On 8/31/16, 6:29 PM, "Benjamin Reed" wrote: > > flip the switch to git and update the relevant scripts and docs. > > i couldn't figure out which

Re: [VOTE] move Apache Zookeeper to git

+1 --Chris Nauroth On 8/31/16, 6:29 PM, "Benjamin Reed" wrote: flip the switch to git and update the relevant scripts and docs. i couldn't figure out which timeframe this falls under in the voting procedure table, but i think it's safe to go with 3 days, so

[VOTE] move Apache Zookeeper to git

flip the switch to git and update the relevant scripts and docs. i couldn't figure out which timeframe this falls under in the voting procedure table, but i think it's safe to go with 3 days, so the vote will close on Saturday, September 3 at 6:30pm pdt. +1 from me