Re: ZooKeeper 3.4.10 release discussion

Thank you everyone for the great support! ZOOKEEPER-2693 has been merged. I hope we are good to go and I will prepare release candidate. Regards, Rakesh On Wed, Feb 8, 2017 at 10:06 AM, Rakesh Radhakrishnan wrote: > Thank you Michael for the useful comments. I've updated

Re: ZooKeeper 3.4.10 release discussion

Thank you Michael for the useful comments. I've updated the wiki page, kindly review it again. Rakesh On Wed, Feb 8, 2017 at 4:17 AM, Michael Han wrote: > Hi Rakesh, > > My super late feedback for > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ >

Re: ZooKeeper 3.4.10 release discussion

Hi Rakesh, My super late feedback for https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+git with two minor comments: * In Branching section, it said: # create new branch-X.Y from master branch git checkout -b branch-X.Y master # commit and push the changes to remote repo

Re: ZooKeeper 3.4.10 release discussion

Hi PMCs/committers, It would be great to see feedback on the updated branching release procedure mentioned in the cwiki page. How about publishing an initial release candidate by following the new procedure, probably you all can verify the RC-0 and do voting? Thanks, Rakesh On Thu, Feb 2, 2017

Re: ZooKeeper 3.4.10 release discussion

Hi all, Any chance of us getting ZOOKEEPER-2184 and ZOOKEEPER-2680 into 3.4.10 release? IMHO, those look in good shape and would benefit from a final commit review. Thanks, Eddie On Thu, Feb 2, 2017 at 2:13 PM, Rakesh Radhakrishnan wrote: > Hi All, > > I've tried an

Re: ZooKeeper 3.4.10 release discussion

Hi All, I've tried an attempt by converting all the applicable svn commands to git commands in "HowToRelease using git" cwiki page. Welcome comments, thanks! https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+git Thanks, Rakesh On Fri, Jan 27, 2017 at 11:54 PM, Edward

Re: ZooKeeper 3.4.10 release discussion

​​ Hi Rakesh, I have comment on ZK-2622. Took a look at the 'HowToRelease' using git page and have one minor comment: 2. "If not already done, merge desired patches from master into the branch and commit these changes. (...) " AFAIK merging from master to branch-3.4 would bring all those

Re: ZooKeeper 3.4.10 release discussion

Thanks Edward for the interest. I hope you are watching 'HowToRelease' using git page discussion, which is still in progress. I'd like to give some more time to the folks to push their interesting issues(I'd prefer issues with low risk) until the release procedure is finalized. I've marked

Re: ZooKeeper 3.4.10 release discussion

Thanks Flavio. I've added few points, please go through and let me know your feedback. >- It might be a better idea to preserve the HowToRelease document for future reference, clone the document, and change the cloned document to reflect the git >commands rather than svn. Agreed. I've

Re: ZooKeeper 3.4.10 release discussion

Hi, Rakesh and Flavio, what do you think about merging ZOOKEEPER-2622 to branch-3.4 and include it in 3.4.10 besides branch-3.5 and master? Edward On Thu, Jan 26, 2017 at 8:20 AM, Flavio Junqueira wrote: > Here are a few comments on the proposal of changes to the release

Re: ZooKeeper 3.4.10 release discussion

Here are a few comments on the proposal of changes to the release process: - It might be a better idea to preserve the HowToRelease document for future reference, clone the document, and change the cloned document to reflect the git commands rather than svn. - We still need to modify Step 2

Re: ZooKeeper 3.4.10 release discussion

Agreed, will try to resolve ZK-2184. I have included this to 3.4.10 releasing. I could see few open review comments in the PR, probably will push once this is concluded. Thanks, Rakesh On Thu, Jan 26, 2017 at 2:01 AM, Flavio Junqueira wrote: > I'd like to have ZK-2184 in as

Re: ZooKeeper 3.4.10 release discussion

Thanks Patrick for the comments. 4 changes.txt - how does one do this? can we provide the exact steps to the RM? Recently, https://issues.apache.org/jira/browse/ZOOKEEPER-2672 issue created to remove the CHANGE.txt file itself. Sorry for not mentioned this in the cwiki page. Could you

Re: ZooKeeper 3.4.10 release discussion

Thanks for driving this Rakesh. I finally got some time to try the changes (as much as possible w/o cutting a release myself) and noticed the following: 4 changes.txt - how does one do this? can we provide the exact steps to the RM? 6. TODO - put this in red? We need to have a process before you

Re: ZooKeeper 3.4.10 release discussion

I'd like to have ZK-2184 in as well. I have seen many cases in which applications are affected by that problem. If folks can help me push it through, I'd appreciate. -Flavio > On 25 Jan 2017, at 17:01, Rakesh Radhakrishnan wrote: > > I've reviewed ZOOKEEPER-2044 pull

Re: ZooKeeper 3.4.10 release discussion

I've reviewed ZOOKEEPER-2044 pull request and added few comments. I hope this will be committed soon. I'm planning to keep the CHANGE.txt file for this release. But, not updating the commit history considering that git revision can be used as a reference. Please see my comment

Re: ZooKeeper 3.4.10 release discussion

Hi Rakesh, Thanks for driving 3.4.10 release. I've been looking at https://issues.apache.org/jira/browse/ZOOKEEPER-2044 today I think this could be a good addition to 3.4.10 release - what do you think? Should we get this in 3.4.10? On Tue, Jan 24, 2017 at 9:13 AM, Rakesh Radhakrishnan

Re: ZooKeeper 3.4.10 release discussion

Hi folks, ZOOKEEPER-2573 fix is agreed and will be resolved soon. After committing this jira, I'm planning to start cutting a release candidate based on my proposed "HowToRelease" ZK cwiki changes. Appreciate feedback on proposed ZK cwiki https://cwiki.apache.org/

Re: ZooKeeper 3.4.10 release discussion

OK. I have modified ZK cwiki page https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease directly. Please review the newly added lines in orange color to understand the changes. The following sections has been modified: - *Updating the release branch -> modified steps **1, 4, 10,

Re: ZooKeeper 3.4.10 release discussion

Perhaps you can make the changes directly on the wiki page as a duplicate line item under the original in a different color? It's hard for me to really follow, esp as it's not a 1:1 replacement iiuc. Could you try editing the wiki directly to start with, leave the original line and add the new

Re: ZooKeeper 3.4.10 release discussion

Hi folks, As we all know, 3.4.10 release is the first ZooKeeper release after the github repository migration. I have tried an attempt to modify the steps described in the ' https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease' page to make the release. Since this release is from an

Re: ZooKeeper 3.4.10 release discussion

Thanks for pointing this jira. I will take a look at this. Rakesh On Fri, Jan 13, 2017 at 7:27 PM, Edward Ribeiro wrote: > Hi Rakesh, > > Thansk for stepping up to this task! Pretty cool! :) > > Do you think https://issues.apache.org/jira/browse/ZOOKEEPER-2573 is

Re: ZooKeeper 3.4.10 release discussion

Hi Rakesh, Thansk for stepping up to this task! Pretty cool! :) Do you think https://issues.apache.org/jira/browse/ZOOKEEPER-2573 is worth targeting 3.4.10 too? Edward On Fri, Jan 13, 2017 at 7:56 AM, Rakesh Radhakrishnan wrote: > Hi All, > > I hope to cut an RC in a

Re: ZooKeeper 3.4.10 release discussion

Hi All, I hope to cut an RC in a week - giving some more time for your favorite outstanding blocker/critical issues. Will start moving out any tickets that are not blockers and/or won’t fit the timeline - there are 1 blocker, 5 critical, 15 major, 7 minor tickets outstanding as of now. Appreciate