Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2013-11-22 Thread Benjamin Smedberg
With the landing of bug 672843, the NS_ENSURE_* macros are now considered deprecated. If you are writing code that wants to issue warnings when methods fail, please either use NS_WARNING directly or use the new NS_WARN_IF macro. if (NS_WARN_IF(somethingthatshouldbetrue)) return

Re: Plug-in feature not available in the web platform. Alternatives?

2013-11-21 Thread Benjamin Smedberg
On 11/20/2013 2:11 PM, fma spew wrote: The prompt part is not needed to be provided by WebCrypto. In the latest releases, the prompt part has been taken care of our plugin. However, in our new prototype, the scripting UI part (Dojo) will take care of it. I expect that the browser will need to

Re: How to reduce the time m-i is closed?

2013-11-21 Thread Benjamin Smedberg
On 11/21/2013 1:11 PM, Robert Kaiser wrote: Philip Chee schrieb: I thought that there was a plan to pre-allocate on startup some memory for the minidump/crash reporter? For one thing, I'm not sure how far that went, for the other, we are calling a Windows function to generate the minidump

Re: [Mozilla Enterprise] 17.0.11 and 24.1.1 XULRunner?

2013-11-20 Thread Benjamin Smedberg
On 11/20/2013 8:02 AM, Look, Yuriy wrote: Hi, On or around November 13 2013 Firefox of versions 25.0.1, 24.1.1 ESR and 17.0.1 ESR were rereleased, along with XULRunner 25.0.1, but not for ESR versions. My question is was any incompatibilities between Fx and XULRunner introduced with these

Re: Plug-in feature not available in the web platform. Alternatives?

2013-11-20 Thread Benjamin Smedberg
On 11/20/2013 3:10 AM, fma spew wrote: Our customers' end-users have their end-user certificates stored in the Personal logical certificate store on Windows. The rest of needed certificates, (Intermediary and/or Trusted Root Certificates) are also stored on Windows certificate stores. Our

Re: [Mozilla Enterprise] 17.0.11 and 24.1.1 XULRunner?

2013-11-20 Thread Benjamin Smedberg
On 11/20/2013 11:16 AM, Wilkins, Brian wrote: That's odd because on RHEL, Xulrunner 17 ESR is in the RHEL Repo. Is this just a RHEL versioning mismatch with the official versions? I don't understand the question. Some Linux distros build Firefox on top of their XULRunner package, and so they

Welcome Nathan Froyd as an XPCOM peer

2013-11-18 Thread Benjamin Smedberg
I'd like to announce and welcome Nathan Froyd as a peer of the XPCOM module. Nathan is a careful and thoughtful reviewer, and I'm happy that he has agreed to help spread review load and serve as the resident expert on performance and memshrink issues within XPCOM. --BDS

Re: what is the difference between Tb/Fx minor and patch version bumps

2013-11-13 Thread Benjamin Smedberg
On 11/13/2013 3:11 PM, al...@yahoo.com wrote: e.g. the first Fx24 esr update was 24.1.0, the next one is 24.1.1 what circumstances call for one vs. the other We are spinning a Firefox 25.0.1 build to fix some important regressions. So: 25 == 24.1.0ESR 25.0.1 == 24.1.1ESR 26 == 24.2ESR

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-11 Thread Benjamin Smedberg
On 11/11/2013 10:23 AM, Henri Sivonen wrote: In principle, the right way to deal with this would be moving code to comm-central. However, this would involve annoyances like setting up a new XPCOM component there and making sure the category manager merges m-c-defined and c-c-defined category

Re: .elementFromPoint including XBL anonymous nodes?

2013-11-11 Thread Benjamin Smedberg
On 11/10/2013 7:54 PM, Robert O'Callahan wrote: On Sat, Nov 9, 2013 at 7:32 PM, Benjamin Smedberg benja...@smedbergs.uswrote: Is there a chrome-only API like .elementFromPoint that will tell me which XBL anonymous element is at a point? I don't think so. You probably need to add another

Re: Plug-in feature not available in the web platform. Alternatives?

2013-11-09 Thread Benjamin Smedberg
to, in this case, Windows stuff. Google has provided alternatives though. Can you be more specific about the alternatives in Chrome? We are planning out the implementation of WebCrypto, but it's not clear from your post whether that would meet your needs or not. 4- So, as encouraged by Benjamin Smedberg

.elementFromPoint including XBL anonymous nodes?

2013-11-09 Thread Benjamin Smedberg
Is there a chrome-only API like .elementFromPoint that will tell me which XBL anonymous element is at a point? Background: in the replacement binding for click-to-play plugins, we have a div class=mainBox child which fills up the plugin area. So that users can click on the binding, we set the

Re: Cost of ICU data

2013-10-22 Thread Benjamin Smedberg
On 10/15/2013 12:06 PM, Benjamin Smedberg wrote: With the landing of bug 853301, we are now shipping ICU in desktop Firefox builds. This costs us about 10% in both download and on-disk footprint I'm going to try and summarize the discussion and indicate next steps. == First, I want

Re: Cost of ICU data

2013-10-22 Thread Benjamin Smedberg
On 10/22/2013 6:19 PM, Ehsan Akhgari wrote: On 2013-10-22 4:06 PM, Benjamin Smedberg wrote: I don't think that there is enough data yet to make a decision. Hopefully funnelcake results which help make a more informed choice. If it turns out that that Firefox wants this decision reconsidered

Re: Capturing text from Firefox

2013-10-18 Thread Benjamin Smedberg
On 10/17/2013 7:30 PM, Look, Yuriy wrote: I am working on GUI automation component of a performance monitoring product. One of the common approaches to monitoring application is periodically capture text from the control where changes are expected (content area of the browser for Web

Re: Killing the Moz Audio Data API

2013-10-17 Thread Benjamin Smedberg
On 10/17/2013 2:28 AM, smaug wrote: On 10/17/2013 12:09 AM, Ehsan Akhgari wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of

Re: Cost of ICU data

2013-10-16 Thread Benjamin Smedberg
On 10/16/2013 9:39 AM, Gervase Markham wrote: On 15/10/13 17:06, Benjamin Smedberg wrote: You have given on-disk footprint values, but surely download size values are the important ones for the issue you are raising? After all, some of this data may be very compressible, and some may

Cost of ICU data

2013-10-15 Thread Benjamin Smedberg
With the landing of bug 853301, we are now shipping ICU in desktop Firefox builds. This costs us about 10% in both download and on-disk footprint: see https://bugzilla.mozilla.org/show_bug.cgi?id=853301#c2. After a discussion with Waldo, I'm going to post some details here about how much this

Re: Cost of ICU data

2013-10-15 Thread Benjamin Smedberg
On 10/15/2013 1:18 PM, Brian Smith wrote: On Tue, Oct 15, 2013 at 9:06 AM, Benjamin Smedberg benja...@smedbergs.us wrote: Do we need this data for any language other than the language Firefox ships in? Can we just include the relevant language data in each localized build of Firefox, and allow

Re: Cost of ICU data

2013-10-15 Thread Benjamin Smedberg
On 10/15/2013 1:50 PM, Anne van Kesteren wrote: As far as JavaScript API features go, I don't think we should vary our offering by locale. E.g. for Firefox OS we want changing locale to just work and not require a new version of Firefox OS. The same goes for a computer in a hotel or hostel or

Synchronous workers

2013-10-14 Thread Benjamin Smedberg
One of the shumway goals has been to run most or all of shumway in a worker, so that it can run in parallel with a web page the same way Flash currently does. This will significantly help solve jank associated with shumway loading. However, we still need to support the Flash externalInterface

Re: Synchronous workers

2013-10-14 Thread Benjamin Smedberg
On 10/14/2013 12:06 PM, Bobby Holley wrote: How common are the blocking API calls? Expect them to be very common or almost universal for real Flash. Much less common for simple display ads. Can we somehow predict whether the SWF will need that, and optionally use a worker/non-worker context

Re: Synchronous workers

2013-10-14 Thread Benjamin Smedberg
On 10/14/2013 4:12 PM, Robert O'Callahan wrote: On Mon, Oct 14, 2013 at 11:03 AM, Benjamin Smedberg benja...@smedbergs.us mailto:benja...@smedbergs.us wrote: Having this blocking interface will also support blocking shumway on graphics rendering; there are a fair number of SWF files

Re: java click to run problem on Firefox

2013-10-10 Thread Benjamin Smedberg
On 10/10/2013 11:44 AM, Thierry Milard wrote: I have a java Web application (www.free-visit.net). the way Mozilla manages the java player is ... killing my users experience : they have not choce to go to chrome, because I can not do otherwyse : java won'y run even f they have the

Re: java click to run problem on Firefox

2013-10-10 Thread Benjamin Smedberg
On 10/10/2013 3:46 PM, Thierry Milard wrote: Benjamin, here is my description of the java Plugin activation issue I do have. * * *1) Warning sign not displayd upper left when applet is in the middle* The No entry sign is displaid on the upper left of the html page, not placed where my java

Re: What platform features can we kill?

2013-10-09 Thread Benjamin Smedberg
On 10/9/2013 12:18 PM, Boris Zbarsky wrote: On 10/9/13 12:01 PM, Gervase Markham wrote: In the spirit of learning from this, what's next on the chopping block? RDF I'm all for this, although the risk is probably quite small because we don't expose RDF to content. --BDS

Re: What platform features can we kill?

2013-10-09 Thread Benjamin Smedberg
On 10/9/2013 2:25 PM, Ehsan Akhgari wrote: On 2013-10-09 12:18 PM, Boris Zbarsky wrote: On 10/9/13 12:01 PM, Gervase Markham wrote: In the spirit of learning from this, what's next on the chopping block? RDF We use RDF in Firefox, in localstore.rdf among others I guess. This is not that

Re: Proposal: stop exporting JS symbols

2013-10-01 Thread Benjamin Smedberg
On 9/20/2013 9:06 AM, Benjamin Smedberg wrote: So I would like to propose that we link the JS libraries statically into libxul and stop exporting JSAPI symbols entirely. This will effectively prevent extensions from using it. This has been checked in for Firefox 27 in bug 920731

Re: Hang monitoring for non-main threads

2013-09-30 Thread Benjamin Smedberg
On 9/30/2013 2:48 PM, Jim Chen wrote: So far I looked at the main thread hang monitor [1], but it seems to make a lot of assumptions about the main thread. Yes. I think it would make sense to have a separate, generic hang monitor that can monitor multiple other threads. Each thread would

Re: Proposal: stop exporting JS symbols

2013-09-23 Thread Benjamin Smedberg
On 9/20/2013 3:12 PM, Philipp Kewisch wrote: What about JS_NewDateObject, JS_NewDateObjectMsec, JS_ObjectIsDate, js_DateIsValid? Most of these are in jsapi.h, and we need it in Lightning for this code:

Re: Proposal: stop exporting JS symbols

2013-09-23 Thread Benjamin Smedberg
On 9/23/2013 8:45 AM, Philipp Kewisch wrote: Initially it seems it would be easy to replace calDateTime with a JS component and I had started to do this, but unfortunately calDateTime is instanciated directly (via constructor, not via xpcom) in a few locations in our C code, so replacing

Re: Implementing Pepper since Google is dropping NPAPI for good

2013-09-23 Thread Benjamin Smedberg
On 9/23/2013 4:29 PM, Hubert Figuière wrote: Hi all, Today Google said they'd drop NPAPI for good. We also intend to someday drop NPAPI for good. I don't think that by the end of 2014 is a realistic timeline for either Chrome or us, given the number of users who still rely on Java and other

Proposal: stop exporting JS symbols

2013-09-20 Thread Benjamin Smedberg
Currently, extensions are able to use the JSAPI via its exported symbols. This pretty much invariably leads to stability or security issues with extensions that actually do this: * the JSAPI is complicated, and even within Mozilla we get reviews from a select set of people on JSAPI code * the

Re: Proposal: stop exporting JS symbols

2013-09-20 Thread Benjamin Smedberg
On 9/20/2013 9:23 AM, Mike Hommey wrote: We're already statically linking js libraries info libxul. Except on windows, but that's work in progress in bug 915735 I am primarily worried about doing this on Windows. , although we don't know yet if it's going to work at all: after dealing with the

Logging of quality events

2013-09-18 Thread Benjamin Smedberg
Right now our stability efforts are primarily focused on crashes. However, as we have been very successful at reducing our crash rate, some other stability issues which are not crashes have come to be more prominent. Some examples: * very slow startup * very slow/hung shutdown * hangs while

Re: How to check if an element is visible...

2013-09-13 Thread Benjamin Smedberg
On 9/13/2013 10:04 AM, Mike de Boer wrote: …reliably from C++? Some background: in bug 257061 I'm implementing to count and display the number of found items in the findbar. Gavin mentions in https://bugzilla.mozilla.org/show_bug.cgi?id=257061#c88 that there has to be some prior art related

Re: How to create a child process in a chrome mochitest?

2013-09-06 Thread Benjamin Smedberg
On 9/6/2013 2:32 AM, Nicholas Nethercote wrote: In theory, this is as easy as iframe mozbrowser remote or browser remote html:iframe mozbrowser remote is what B2G uses. It requires the prefs than Kan-Ru mentions. xul:browser remote=true is what desktop uses. It does not require special

Re: C++ style question: virtual annotations on methods

2013-09-04 Thread Benjamin Smedberg
On 9/4/2013 12:45 AM, Chris Pearce wrote: On 04-Sep-13 4:18 PM, Robert O'Callahan wrote: I like to put virtual on all methods that are virtual, even when it's not strictly necessary because the method overrides a virtual method of the parent class. Other people disagree, especially when the

Re: On builds getting slower

2013-08-27 Thread Benjamin Smedberg
On 8/26/2013 5:59 PM, Brian Smith wrote: Immediate rebuild (no-op) was 10:13.05. A second no-op rebuild was 10:32.36. It looks like every shared library and every executable got relinked. This is a bug (rather serious at that!) which should be filed seprately from generic build speed

Re: Flash and e10s

2013-08-07 Thread Benjamin Smedberg
On 8/6/2013 8:46 PM, Robert O'Callahan wrote: I was talking to people about plans for Flash on e10s. Who were you talking to? John Schoenick currently owns that bug, although I don't think he's working on it yet. We've talked about it on an off. Full support for windowed Flash on e10s is

Re: Rethinking separate Mercurial repositories

2013-07-29 Thread Benjamin Smedberg
On 7/29/2013 1:43 PM, Gregory Szorc wrote: I don't particularly care for our model of a single Mercurial repository per logical entity. I think it makes sense for things like twigs and to some extent integration repositories - you can do your work in your own little world without disrupting

Re: Proposal: requiring build peer review for Makefile.in changes

2013-07-18 Thread Benjamin Smedberg
On 7/18/2013 2:43 AM, Tim Taubert wrote: The proposal sounds good to me but I guess you wouldn't want to be notified of every small addition/change to Makefiles in test directories? I suppose you're targeting actual changes to dependencies etc, but where do we draw the line? I thought the

Re: suggested reviewers for bugzilla products and components

2013-07-18 Thread Benjamin Smedberg
On 7/18/2013 12:45 PM, Gregory Szorc wrote: A number of people use the bzexport Mercurial extension [1] to upload patches from the command line so they don't need to muck about with a browser. It would be awesome to integrate suggested reviewers into that tool. That would require having an

Re: unreported JS exception bugs

2013-07-18 Thread Benjamin Smedberg
On 7/18/2013 7:11 PM, Gavin Sharp wrote: Seeing the filing of bug 895340 pushed me over the edge, because I knew we had many other similar bugs on file about unreported JS exceptions. I ended up filing https://bugzilla.mozilla.org/show_bug.cgi?id=895548, a tracking bug from which I could link a

Re: Three RDFa-related W3C Proposed (Edited) Recommendations

2013-07-17 Thread Benjamin Smedberg
On 7/16/2013 7:12 PM, L. David Baron wrote: The W3C has released three RDFA-related documents, one proposed recommendation: HTML+RDFa 1.1: http://www.w3.org/TR/2013/PR-html-rdfa-20130625/ If there are comments you think Mozilla should send as part of the review, or if you think Mozilla

Re: Generic data update service?

2013-07-15 Thread Benjamin Smedberg
On 7/15/2013 9:30 AM, Gervase Markham wrote: On 13/07/13 00:36, Clint Talbert wrote: This is all good stuff, and I want to support us being nimble. We also need to balance that against security and quality in our builds. We go through the release process for a reason, and we exert the energy to

Re: review stop-energy (was 24hour review)

2013-07-15 Thread Benjamin Smedberg
On 7/15/2013 2:58 PM, Steve Fink wrote: On Mon 15 Jul 2013 11:43:05 AM PDT, Boris Zbarsky wrote: On 7/15/13 2:36 PM, Chris Peterson wrote: If reviewee submits a new version of (say) patch 1 of 6, should they: * attach patch 1 version 2 * an interdiff between patch 1 version 1 and 2 Yes, to

Re: Mail Explosion

2013-07-10 Thread Benjamin Smedberg
On 7/10/2013 6:09 PM, Dustin Oprea wrote: I've only been auditing the devs for a couple of months, but does anyone know what's going on with the mail? I just received like forty messages. Mail delivery for people subscribed to this forum (and many other forums) via mailman was interrupted,

Re: Replacing Gecko's URL parser

2013-07-02 Thread Benjamin Smedberg
On 7/2/2013 6:55 AM, Anne van Kesteren wrote: On Tue, Jul 2, 2013 at 12:51 AM, Mike Hommey m...@glandium.org wrote: Note that some custom schemes may be relying on empty host names. In Gecko, we have about:foo as well as resource:///foo. In both cases, foo is the path part. about URLs don't

Re: Replacing Gecko's URL parser

2013-07-01 Thread Benjamin Smedberg
On 7/1/2013 12:43 PM, Anne van Kesteren wrote: I'm interested in hearing what people think. I outlined two issues below, but I'm sure there are more. By the way, independently of the parser bit, we are proceeding with implementing the URL API as drafted in the URL Standard in Gecko, which

Re: Best way to make xpcshell provide consistent stack limits?

2013-06-28 Thread Benjamin Smedberg
On 6/26/13 7:06 PM, Andrew Sutherland wrote: d) Change xpconnect to use jsnativestack.cpp's ability to tell us what the platform stack size actually is and/or nsThread's knowledge of the stack size it was created with. So on linux we'd use whatever 'ulimit -s' is telling us to do, etc. The

Re: Need for unit testing changing the code?

2013-05-30 Thread Benjamin Smedberg
On 5/30/13 3:14 PM, Milan Sreckovic wrote: Add public accessors, even if they're (currently) only used by the unit tests. If it doesn't hurt, this seems like a pretty good solution. --BDS ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: Code Review Session

2013-05-28 Thread Benjamin Smedberg
On 5/24/2013 10:50 AM, Justin Lebar wrote: * I think we should experiment (again) with real pull-request integration into bugzilla. I'm totally in favor of better tools and real pull requests, and of course the PRs need to be linked to bugzilla /somehow/. But I want to qualify integration into

Re: Code Review Session

2013-05-24 Thread Benjamin Smedberg
On 5/23/2013 5:32 AM, Scott Johnson wrote: Members of dev-platform: As part of the Web Rendering work-week in Taiwan, we had a discussion of the process of code review, graciously led by roc. If you were unable to attend, or were able to attend and would like to review the proceedings, notes

Re: OS.File and shutdown

2013-05-10 Thread Benjamin Smedberg
On 5/10/13 4:45 PM, Felipe Gomes wrote: Hi, does OS.File guarantees that write tasks that have started will be completed if a shutdown occurs? My use case is for writeAtomic but I'm interested about the behavior of both write and writeAtomic. Corner case: what if I call write/writeAtomic from

Re: We should drop MathML

2013-05-07 Thread Benjamin Smedberg
On 5/6/2013 7:20 PM, Robert O'Callahan wrote: Hopefully Web Components will provide a good solution to let authors extend the browser with support for vocabularies that can be rendered via a straightforward decomposition to HTML or MathML or SVG. I think the layout requirements of MathML are

Re: determining release channel from javascript?

2013-05-07 Thread Benjamin Smedberg
On 5/7/2013 9:55 AM, Byron Jones wrote: i initially thought about using browser/config/version/version.txt based on the version in the user-agent, however this reflects the current default channel, and not necessarily the channel the user's application is using. for example if someone

Re: Storage in Gecko

2013-05-03 Thread Benjamin Smedberg
On 5/2/2013 7:43 PM, Gregory Szorc wrote: On 5/2/2013 4:40 PM, Kyle Huey wrote: On Thu, May 2, 2013 at 4:36 PM, Gregory Szorc g...@mozilla.com mailto:g...@mozilla.com wrote: We seemed to converge on a (presumably C++-based) storage service that has named branches/buckets with

Re: Implementing CSS/SVG filters

2013-05-01 Thread Benjamin Smedberg
On 5/1/2013 12:11 AM, Andreas Gal wrote: You propose SIMD optimization for the software fallback path. I wonder whether we should focus on one fast GPU path via GLSL, and have one precise, working, I-don't-care-how-slow CPU fallback. All hardware made the last few years will have a GPU we

Re: multiline pref value strings in user.js

2013-04-29 Thread Benjamin Smedberg
On 4/27/2013 6:26 PM, al...@yahoo.com wrote: ... appear to be possible without the \ escape. In fact the \ can not be present as it does not escape the newline but becomes a part of the string. Once upon a time, prefs files were actually JS: we created a function pref and user_pref and then

Re: Storage in Gecko

2013-04-26 Thread Benjamin Smedberg
On 4/26/2013 2:50 PM, Gavin Sharp wrote: On Fri, Apr 26, 2013 at 11:36 AM, Andreas Gal g...@mozilla.com wrote: Preferences are as the name implies intended for preferences. There is no sane use case for storing data in preferences. I would give any patch I come across doing that an automatic

Re: Increasing the platform meeting's relevance for engineers

2013-04-25 Thread Benjamin Smedberg
On 4/25/2013 1:07 AM, Ehsan Akhgari wrote: On 2013-04-24 3:35 PM, Benjamin Smedberg wrote: On 4/24/2013 3:13 PM, Justin Lebar wrote: and last time I checked there's no way to get notified when a meeting's notes are up (via RSS or e-mail or whatever). https://blog.mozilla.org/meeting-notes

Re: Increasing the platform meeting's relevance for engineers

2013-04-24 Thread Benjamin Smedberg
On 4/24/2013 3:13 PM, Justin Lebar wrote: and last time I checked there's no way to get notified when a meeting's notes are up (via RSS or e-mail or whatever). https://blog.mozilla.org/meeting-notes/archives/tag/mozillaplatform and it shows up on the projects planet as well. --BDS

Re: Annotating Commits

2013-04-11 Thread Benjamin Smedberg
On 4/10/2013 11:23 PM, Gregory Szorc wrote: Mercurial and Git both support the ability to attach arbitrary key-value string data to commits. There is an abundance of awesomeness that could be realized if we started storing [machine readable] information inside our commits (not inside the commit

Re: reorganizing some test directories

2013-04-11 Thread Benjamin Smedberg
On 4/11/2013 11:47 AM, jmaher wrote: Great question- the main goal is to have each test type in a directory for that specific harness. Yes, but why is that a good thing? In general, I feel that our directory structures are way too deep already, and it would be better to make them as flat as

Re: Virtual Memory fragmentation issues

2013-04-09 Thread Benjamin Smedberg
On 4/9/13 7:12 AM, Kevin Gadd wrote: This is one of the problems Heap Profiler was written to solve: https://github.com/kevingadd/HeapProfiler It enables stack trace captures at allocation time, so at any given point in the capture you can open the heap and see who allocated a given block of

Re: Virtual Memory fragmentation issues

2013-04-08 Thread Benjamin Smedberg
On 4/8/2013 7:46 PM, Benjamin Smedberg wrote: In this case, the crash report shows Available Virtual Memory as 303558656, but in fact the largest contiguous block of available VM is 64k. Correct, I had wrong math. The largest block available is about 3MB, and the allocation being requested

Re: Moz2D Repository Creation

2013-03-28 Thread Benjamin Smedberg
On 3/27/2013 7:37 PM, Robert O'Callahan wrote: Adding a subrepository just for Moz2D seems like it could add global complexity for the benefit of just a small set of people. So it seems much more worthwhile if we regard it as an experiment to blaze a trail other modules would follow if the

Re: Adjusting Windows 64-bit per-checkin builds (not related to nightly builds)

2013-03-27 Thread Benjamin Smedberg
On 3/27/2013 1:19 PM, Armen Zambrano G. wrote: On another note, there could be a tree booked for win64 and move nightly win64 users there (orthogonal to updating users to 32-bit builds) since it would allow the community control which merges from mozilla-central to take in (and back out from

Re: TBPL job visibility policy - now documented

2013-03-26 Thread Benjamin Smedberg
On 3/26/2013 12:07 PM, Dave Townsend wrote: This is awesome, thanks for writing this up, it's made me spot one more place where Jetpack is failing. Can we get some more definition around Runs on all trees that merge into mozilla-central? In particular I want to make that true for Jetpack but

Re: getter_AddRefs

2013-03-26 Thread Benjamin Smedberg
On 3/26/2013 10:16 AM, Neil wrote: Why does getter_AddRefsT have an operator nsISupports**? So far most of the uses I've found appear to be people enumerating an nsISimpleEnumerator directly into an nsCOMPtrT type, although the documented idl return value is nsISupports. Is this an acceptable

Re: Decoupling the build config via moz.build files (nuking all.js)

2013-03-15 Thread Benjamin Smedberg
On 3/15/2013 2:33 PM, Gregory Szorc wrote: I /think/ our current spaghetti configuration is a historical artifact from using Makefile.in's to define the build config combined with the complexity required to do things right. Yes, I believe you are mostly correct. With moz.build files, we

Re: Turning off window.Components for the web

2013-03-05 Thread Benjamin Smedberg
On 3/4/2013 6:10 PM, Bobby Holley wrote: Q: Will this break websites? A: Some, probably. Telemetry indicates that a bit under 10% of users encounter at least one reference to Components during their browsing session. Approximately half of these appear to be simple accesses of the object itself

Re: Turning off window.Components for the web

2013-03-05 Thread Benjamin Smedberg
On 3/5/2013 12:11 PM, Boris Zbarsky wrote: Peter has suggested making Components.interfaces.nsIXMLHttpRequest == window.XMLHttpRequest, for what it's worth. Yes. I think this shim could be implemented entirely in JS: window.Components = { interfaces: { nsIXMLHttpRequest:

Re: improving access to telemetry data

2013-02-28 Thread Benjamin Smedberg
On 2/28/2013 10:33 AM, Benoit Jacob wrote: Please, please make your plans include the ability to get raw text files (CSV or JSON or something else, I don't care as long as I can easily parse it). Could you be more specific? Note that while the text files currently provided on crash-analysis,

Re: Soliciting advice on #650960 (replacement for print progress bars)

2013-02-25 Thread Benjamin Smedberg
On 2/25/2013 4:14 PM, Zack Weinberg wrote: The current thinking is that we need *some* indication that a print job is in progress, because we need to prevent the user from closing the tab or window until the print job has been completely handed off to the OS. Why? Is the user allowed to

Re: Running mousemove events from the refresh driver

2013-02-13 Thread Benjamin Smedberg
On 2/12/2013 10:18 PM, Robert O'Callahan wrote: Context: bug 837985. At times we can be flooded by OS-level mousemove events. On what OSes? Windows by default coalesces mouse move events. They are like WM_PAINT events in that they are only delivered when the event queue is empty. See

Re: Proposed W3C Charter: HTML Working Group

2013-02-12 Thread Benjamin Smedberg
On 2/8/2013 5:37 PM, L. David Baron wrote: W3C is proposing a revised charter for the HTML Working Group. For more details, see: http://lists.w3.org/Archives/Public/public-new-work/2013Feb/0009.html http://www.w3.org/html/wg/charter/2012/ Mozilla has the opportunity to send comments or

Re: Sparse localizations of toolkit and the chrome registry's getSelectedLocale()

2013-02-12 Thread Benjamin Smedberg
On 2/12/2013 12:41 PM, Axel Hecht wrote: Hi Benjamin, Dave, for mobile (and fxos) we're looking into doing sparse localizations of toolkit. The work on the mobile side is bug 792077. The current attempt is to leave the 'global' and other toolkit packages untranslated, and use chrome

Re: The future of PGO on Windows

2013-02-04 Thread Benjamin Smedberg
On 2/4/2013 4:27 PM, Brian Smith wrote: Ehsan Akhgari wrote: Brian Smith wrote: 2. AFAICT, we did not seriously investigate the possibility of splitting things out of libxul more. So far we've tried cutting things off the top of the dependency tree. Maybe now we need to try cutting things off

Re: mozilla-central/inbound closed -- we hit the Windows PGO memory limit

2013-01-22 Thread Benjamin Smedberg
On 1/22/2013 9:28 AM, Axel Hecht wrote: How are the perf numbers looking? One of the reasons for asking is that I expect RDF to be part of the startup and window-open codepaths, at least. I would not expect PGO to optimize any of the RDF code for speed, even if they were in the startup

Re: Detecting bad static casts

2013-01-14 Thread Benjamin Smedberg
On 1/14/2013 2:05 PM, Jesse Ruderman wrote: Should we make debug builds check casts to (vtableful?) pointer types? This could be done by adding and calling an assert_cast function, or by adding a new sanitizer mode [6] to clang. In order to keep our custom goop to a minimum, I don't think that

Re: profile breaking changes

2013-01-09 Thread Benjamin Smedberg
On 1/9/2013 7:52 AM, al...@yahoo.com wrote: Generally, opening a profile with version-1 of Fx or Tb works. But conceivably an app upgrade could introduce a breaking change to the profile, is that right? If the programmer doesn't take care, then yes. In Firefox at least we have in the past said

Re: Emacs and vim modelines

2013-01-04 Thread Benjamin Smedberg
On 1/4/13 3:49 PM, Nicholas Nethercote wrote: On Fri, Jan 4, 2013 at 12:23 PM, Nicholas Nethercote n.netherc...@gmail.com wrote: But putting sts in would be reasonable for those that don't have |smarttab| set. So it sounds like the recommended mode lines should look like this: /* -*- Mode:

Re: Emacs and vim modelines

2013-01-03 Thread Benjamin Smedberg
On 1/3/13 7:44 PM, Nicholas Nethercote wrote: Hi https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style says that mozilla code files should have the following Emacs and Vim mode lines: /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim:

Re: removing warning/debug messages from NSPR (debug) logging

2013-01-02 Thread Benjamin Smedberg
On 1/2/2013 2:34 PM, Nathan Froyd wrote: Hi all, Over in bug 794178, we're hitting cases where the combination of write poisoning (crashing if writes to disk are detected after a certain point) and logging are causes crashes. These same crashes are blocking testing for WebRTC (bug 811764).

Re: NS_NewArrayEnumerator

2012-12-18 Thread Benjamin Smedberg
On 12/18/2012 11:05 AM, Neil wrote: While looking at tbsaunde's patch to remove the nsISupportsArray version of NS_NewArrayEnumerator I noticed that many users of NS_NewArrayEnumerator copy entries from a hash into a temporary array which they then enumerate, which works by creating an

Re: Integrating ICU into Mozilla build

2012-12-10 Thread Benjamin Smedberg
On 12/7/2012 4:39 PM, Norbert Lindenberg wrote: On Dec 7, 2012, at 6:18 , Benjamin Smedberg wrote: On 12/6/2012 9:21 PM, Norbert Lindenberg wrote: The benefit is that the ECMAScript Internationalization API lets developers create a more consistent localized experience for their users

Re: Integrating ICU into Mozilla build

2012-12-07 Thread Benjamin Smedberg
On 12/6/2012 9:21 PM, Norbert Lindenberg wrote: The benefit is that the ECMAScript Internationalization API lets developers create a more consistent localized experience for their users, with the correct date, time, and number formats, the culturally appropriate calendar, correct currency

Re: Shipping a component as part of the test package

2012-11-08 Thread Benjamin Smedberg
On 11/8/2012 2:20 PM, Honza Bambas wrote: If a test runner doesn't currently support resource://testing-common/, please file a bug and let's get it implemented everywhere. Alternatively, I suppose we could hack up the main manifest file to include resource://testing-common if ENABLE_TESTS is

Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Benjamin Smedberg
On 10/12/2012 10:25 AM, Ehsan Akhgari wrote: Do we require to maintain source or binary compatibility, or both? Also, is it acceptable for us to add new preprocessor definitions such as NO_NSPR_10_SUPPORT to optionally remove some of the NSPR feature which we would like Gecko to avoid,

Re: xulrunner incredible ammount of calls to getrlimit while running flash

2012-09-20 Thread Benjamin Smedberg
On 9/20/2012 9:14 AM, Estanislao Gonzalez wrote: Hi, This is probably nothing... but I was testing something else and I wondered why there are so many calls to getrlimit about the size of the stack... These are the top 10 calls from one second dump of strace for the xulrunner process (first

Re: xulrunner incredible ammount of calls to getrlimit while running flash

2012-09-20 Thread Benjamin Smedberg
On 9/20/2012 10:02 AM, Estanislao Gonzalez wrote: I might have answered too fast... #0 0xb653b8ec in epoll_wait () from /lib/libc.so.6 #1 0xb5b5ec97 in ?? () from /usr/lib/libevent-1.4.so.2 #2 0xb5b51c5a in event_base_loop () from /usr/lib/libevent-1.4.so.2 #3 0xb7330e80 in ?? () from

Re: Components.utils.import caches?

2012-08-20 Thread Benjamin Smedberg
On 8/20/2012 9:25 AM, sebastiang...@gmail.com wrote: Am Dienstag, 1. Februar 2011 06:16:50 UTC+1 schrieb johnjbarton: I recall reading some rumors about Components.utils.import being cached in such a way that devs can't change the source and see changes. Any truth to this? Any workaround if

Re: Compiling Binary XPCOM Plugin with Gecko 15

2012-08-17 Thread Benjamin Smedberg
On 8/17/2012 3:14 AM, orangespidermas...@googlemail.com wrote: I maintain a binary XPCOM component for Firefox. While compiling it with the Gecko SDK 15 I get the following error: xpcomglue_s_nomozalloc.lib(nsStringAPI.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value

Re: quick! use lisp! before it's too late!

2012-08-15 Thread Benjamin Smedberg
On 8/15/2012 2:24 AM, Pedro Bessa wrote: Ian, Mozilla, I thought all fast functional programming languages were Lisp dialects, but that's not true and you can use other fast functional programming languages, but now that you said Rust, I think the programming language that you should use must

Re: telemetry data retention strategy

2012-08-15 Thread Benjamin Smedberg
On 8/15/2012 5:03 PM, Taras Glek wrote: Hi, According to metrics we have about 1TB of telemetry data in hadoop. This is almost a year worth of telemetry data. Our telemetry ping packets keep growing as we add more probes. As the hadoop database gets bigger, query times get worse, etc. We need

Re: Registering XPTs in a bootstrapped extension

2012-08-07 Thread Benjamin Smedberg
On 8/6/2012 12:00 PM, Matthew Gertner wrote: I guess the interfaces directive is not support in the chrome.manifest of bootstrapped extensions. We're using nsIComponentRegistrar.registerFactory to register XPCOM components, but we also need to register some additional XPCOM interfaces. I'm

<    1   2   3