Re: Intent to implement: CSSOM-View scroll-behavior property

2014-05-27 Thread Robert O'Callahan
On Wed, May 28, 2014 at 6:14 AM, kgilb...@mozilla.com wrote: Is this behavior acceptable or would it be more desirable to always return the actual scroll position in DOM methods? All DOM methods that depend on the scroll position (not just scrollLeft/scrollTop but getBoundingClientRect etc

Re: Intent to implement: CSSOM-View scroll-behavior property

2014-05-25 Thread Robert O'Callahan
On Sun, May 25, 2014 at 4:59 PM, L. David Baron dba...@dbaron.org wrote: On Saturday 2014-05-24 20:00 -0700, Jonas Sicking wrote: I guess what I'm arguing is that smooth-scrolling vs. instant scrolling shouldn't be a per-element CSS property, but rather a per-callsite API argument. I

Re: Intent to implement: CSSOM-View scroll-behavior property

2014-05-23 Thread Robert O'Callahan
On Fri, May 23, 2014 at 10:12 PM, Jonas Sicking jo...@sicking.cc wrote: How will scroll-behavior: instant work on platforms that use APZ? I worry about authors expect it to enable them to do a bunch of DOM mutations and then set the scroll position and allow them to be sure that rendering

Re: Can we remove NS_HIDDEN, NS_HIDDEN_(...)?

2014-05-21 Thread Robert O'Callahan
Android and B2G got fixed to use #pragma GCC visibility. So, we can go ahead and remove all NS_HIDDEN-related code now. This also means that when modifying Android and B2G-specific code that uses symbols imported from other dynamic libraries, you will need to add to config/system-headers (when

Re: using namespace

2014-05-20 Thread Robert O'Callahan
On Wed, May 21, 2014 at 1:11 PM, L. David Baron dba...@dbaron.org wrote: I wonder if the problem is that we're overusing namespaces (i.e., we have too many of them or put many classes at places too deeply nested in the namespace hierarchy)? Perhaps it makes sense to have a guideline that

Re: Intent to ship: Hyperlink Auditing (a ping)

2014-05-16 Thread Robert O'Callahan
Seems to me we should indicate pings in the link status text (bug 401352), indicate pinging in the status text while we load the next page, and retain the about:config pref to disable pinging. The first two measures seem low-cost and constitute a strict improvement on the current privacy

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Robert O'Callahan
On Tue, May 6, 2014 at 8:13 AM, Ian Hickson i...@hixie.ch wrote: drawFocusIfNeeded() isn't a particularly good name either, since you're not drawing the focus, you're drawing the focus ring. In the old email thread, Jatinder Mann objected to using the term ring since the focus drawn might not

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Robert O'Callahan
On Tue, May 6, 2014 at 4:13 PM, Ian Hickson i...@hixie.ch wrote: On Tue, 6 May 2014, Robert O'Callahan wrote: We could probably come up with a slightly better name, but only very slightly better, so at this point I would rather not reopen the discussion. If someone else wants to, that's

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Robert O'Callahan
On Tue, May 6, 2014 at 4:44 PM, Rik Cabanier caban...@gmail.com wrote: FWIW the discussion was public. See http://lists.w3.org/Archives/Public/public-canvas-api/2014JanMar/0003.html Haha, OK, apology withdrawn :-). Thanks, Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus

Re: Can we remove NS_HIDDEN, NS_HIDDEN_(...)?

2014-04-22 Thread Robert O'Callahan
On Wed, Apr 23, 2014 at 1:25 AM, Benjamin Smedberg benja...@smedbergs.uswrote: On 4/22/2014 7:31 AM, Robert O'Callahan wrote: It's all over the tree, inconsistently applied. Is it relevant anymore? Can we remove it entirely, or there some places where it's still relevant, and if so, where

Re: Using rr to track down intermittent test failures

2014-04-18 Thread Robert O'Callahan
The Timelapse project is cool but this thread got derailed. We have a long list of future improvements to make to rr, and improving support for JS debugging is on that list. The point of this thread is that if you're debugging intermittent test failures and you don't need much JS debugging then

Re: Using rr to track down intermittent test failures

2014-04-16 Thread Robert O'Callahan
Building a debugger for a high-level language on top of a low-level recording is unexplored territory but it's definitely possible and it would have some nice features. However, you can't get much leverage from any existing debugging support built into a VM. We could build some JS debugging

Re: Oculus VR support somehwat-non-free code in the tree

2014-04-15 Thread Robert O'Callahan
On Tue, Apr 15, 2014 at 10:41 AM, Vladimir Vukicevic vladim...@gmail.comwrote: I have a prototype of VR display and sensor integration with the web, along with an implementation for the Oculus VR. Despite there really being only one vendor right now, there is a lot of interest in VR. I'd

Re: Oculus VR support somehwat-non-free code in the tree

2014-04-15 Thread Robert O'Callahan
On Wed, Apr 16, 2014 at 3:14 AM, Benoit Jacob jacob.benoi...@gmail.comwrote: If VR is not yet a thing on the Web, could you elaborate on why you think it should be? I'm asking because the Web has so far mostly been a common denominator, conservative platform. For example, WebGL stays at a

Using rr to track down intermittent test failures

2014-04-15 Thread Robert O'Callahan
We just released rr 1.2 and I think this would be a good time for people to try to use it for one of the tasks it was designed for: debugging intermittent test failures. Consult http://rr-project.org for more information, but the gist is this: you can use rr to record the execution of Firefox

Re: Using rr to track down intermittent test failures

2014-04-15 Thread Robert O'Callahan
On Wed, Apr 16, 2014 at 11:05 AM, Robert O'Callahan rob...@ocallahan.orgwrote: 4) Create a script somewhere called rr-record that does exec ~/rr/bin/rr record $* Sorry; this script, of course, needs to exec rr from wherever it was installed. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon

Re: Using rr to track down intermittent test failures

2014-04-15 Thread Robert O'Callahan
On Wed, Apr 16, 2014 at 11:05 AM, Robert O'Callahan rob...@ocallahan.orgwrote: 1) Install rr on a Westmere-or-later Linux system (or VM with performance counters virtualized), build 32-bit Firefox (opt or debug) and verify that recording Firefox works for you. If it doesn't, please file

Re: Using rr to track down intermittent test failures

2014-04-15 Thread Robert O'Callahan
On Wed, Apr 16, 2014 at 11:14 AM, Gijs Kruitbosch gijskruitbo...@gmail.comwrote: 1) Is anyone working on something similar that works for frontend code (particularly, chrome JS)? I realize we have a JS debugger, but sometimes activating the debugger at the wrong time makes the bug go away, and

Re: Using rr to track down intermittent test failures

2014-04-15 Thread Robert O'Callahan
On Wed, Apr 16, 2014 at 12:24 PM, Ted Mielczarek t...@mielczarek.org wrote: Do you have any idea on a timeframe for x86-64 support? It's technically not that hard, but it's a reasonably large project so it's not going to happen right away. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus

Re: Recommendations on source control and code review

2014-04-13 Thread Robert O'Callahan
On Sat, Apr 12, 2014 at 8:29 AM, Gregory Szorc g...@mozilla.com wrote: I came across the following articles on source control and code review: * https://secure.phabricator.com/book/phabflavor/article/ recommendations_on_revision_control/ *

Re: B2G emulator issues

2014-04-07 Thread Robert O'Callahan
When you say debug, you mean the emulator is running a FirefoxOS debug build, not that the emulator itself is built debug --- right? Given that, is it a correct summary to say that the problem is that the emulator is just too slow? Applying time dilation might make tests green but we'd be left

Re: mozilla::Atomic considered harmful

2014-04-01 Thread Robert O'Callahan
On Wed, Apr 2, 2014 at 12:11 AM, Joshua Cranmer  pidgeo...@gmail.comwrote: My original design for mozilla::Atomic was meant to avoid what I saw as the biggest footgun: you cannot misuse mozilla::Atomic in such a way that you combine atomic and non-atomic accesses on a single variable. You

Intent to ship: DOMRect, DOMPoint, DOMQuad, and GeometryUtils

2014-03-18 Thread Robert O'Callahan
DOMRect, DOMPoint and DOMQuad are defined in the Geometry Interfaces spec: http://dev.w3.org/fxtf/geometry/Overview.html GeometryUtils is defined in the CSSOM View spec: http://dev.w3.org/csswg/cssom-view/#geometry The spec for the GeometryUtils methods is quite incomplete but we've discussed the

Re: Intent to implement (and ship?): canvas context alpha attribute

2014-03-12 Thread Robert O'Callahan
Sounds good :-) Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r sGients uapr,e tfaokreg iyvoeunr, 'm aotr atnod sgaoy ,h o'mGee.t uTph eann dt

Re: How to efficiently walk the DOM tree and its strings

2014-03-04 Thread Robert O'Callahan
On Wed, Mar 5, 2014 at 8:47 AM, Felipe G fel...@gmail.com wrote: If I go with the clone route (to work on the snapshot'ed version of the data), how can I later associate the cloned nodes to the original nodes from the document? One way that I thought is to set a a userdata on the DOM nodes

Re: How to efficiently walk the DOM tree and its strings

2014-03-03 Thread Robert O'Callahan
On Tue, Mar 4, 2014 at 9:19 AM, Boris Zbarsky bzbar...@mit.edu wrote: How feasible is just doing .innerHTML to do that, then doing some sort of async parse (e.g. XHR or DOMParser) to get a DOM snapshot? That said, this would mean that you end up with a snapshot that's actual DOM stuff, on the

Re: Cairo being considered as the basis of a standard C++ drawing API

2014-02-11 Thread Robert O'Callahan
On Tue, Feb 11, 2014 at 8:23 PM, Botond Ballo bba...@mozilla.com wrote: I think at least one of the goals of the standard drawing API is to make C++ easier to learn by allowing people learning the language to create simple graphical applications without having to set up third-party libraries

Re: DXR UI refresh is live!

2014-02-11 Thread Robert O'Callahan
On Wed, Feb 12, 2014 at 9:18 AM, Reed Loden r...@reedloden.com wrote: I do like the slickness and quickness, but it still seems greatly-lacking usability-wise (as compared to mxr)... A few things off the top of my head: * Where are the non-mozilla-central repositories? * Where's the

Re: Cairo being considered as the basis of a standard C++ drawing API

2014-02-09 Thread Robert O'Callahan
I've already given my feedback on the cairo mailing list. Summary: Moz2D is the right thing for us, and probably for other application frameworks, but for applications that just want to draw their stuff on the screen or to print, cairo might be a better fit. Anyway ti doesn't really matter to us

Re: Cairo being considered as the basis of a standard C++ drawing API

2014-02-09 Thread Robert O'Callahan
On Mon, Feb 10, 2014 at 11:49 AM, Brian Smith br...@briansmith.org wrote: On Sun, Feb 9, 2014 at 2:38 PM, Robert O'Callahan rob...@ocallahan.org wrote: I've already given my feedback on the cairo mailing list. Summary: Moz2D is the right thing for us, and probably for other application

Re: Please handle non-printable keys with keydown event handler instead of keypress event handler

2014-02-04 Thread Robert O'Callahan
On Wed, Feb 5, 2014 at 8:33 PM, Masayuki Nakano masay...@d-toybox.comwrote: I filed bug 968056 for changing our keypress event behavior for conformance with D3E definition. https://bugzilla.mozilla.org/show_bug.cgi?id=968056 In D3E definition, keypress event shouldn't be fired for

Re: Subpixel AA text rendering on OSX

2014-01-24 Thread Robert O'Callahan
On Wed, Jan 22, 2014 at 6:27 AM, Jeff Muizelaar jrmui...@mozilla.comwrote: On Jan 20, 2014, at 5:48 PM, Matt Woodrow m...@mozilla.com wrote: - A fully transparent surface containing only text. It should be fairly easy to get this to happen by 3d transforming a text element. I suspect we

Re: Exact rooting is now enabled on desktop

2014-01-17 Thread Robert O'Callahan
Congratulations! This has been an epic journey :-). Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r sGients uapr,e tfaokreg iyvoeunr, 'm aotr atnod

Re: Style guide clarity on C++-isms

2014-01-07 Thread Robert O'Callahan
I agree that those are the current best practices. We have a lot of places where we write void Method() { ... } all on one line for trivial setters and getters. I wonder if we should permit that. We have a lot of places where the opening brace of a class declaration is on the same line as the

Re: Mozilla style guide issues, from a JS point of view

2014-01-07 Thread Robert O'Callahan
On Wed, Jan 8, 2014 at 9:46 AM, Mike Hoye mh...@mozilla.com wrote: On 1/7/2014, 3:22 PM, Adam Roach wrote: Since people are introducing actual research information here, let's run some numbers. According to Paterson et. al. [1], reading comprehension speed is actively hindered by lines that

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-06 Thread Robert O'Callahan
On Tue, Jan 7, 2014 at 7:06 AM, Bobby Holley bobbyhol...@gmail.com wrote: * There are a lot of SpiderMonkey hackers who don't hack on anything else, and don't consider themselves Gecko hackers. This has always bothered me a lot. It needs to change. Rob -- Jtehsauts tshaei dS,o n Wohfy

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-06 Thread Robert O'Callahan
On Tue, Jan 7, 2014 at 10:27 AM, Brian Smith br...@briansmith.org wrote: AFAICT, there are not many rules that module owners are bound by. There are lots of tree-wide or Gecko-wide rules that module owners are bound by. The reason module owners can dictate style is because module owners

Re: Mozilla style guide issues, from a JS point of view

2014-01-06 Thread Robert O'Callahan
On Tue, Jan 7, 2014 at 1:46 PM, Jeff Walden jwalden+...@mit.edu wrote: JS widely uses 99ch line lengths (allows a line-wrap character in 100ch terminals). Given C++ symbol names, especially with templates, get pretty long, it's a huge loss to revert to 80ch because of how much has to wrap.

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-25 Thread Robert O'Callahan
On Wed, Dec 25, 2013 at 11:54 AM, Nicholas Nethercote n.netherc...@gmail.com wrote: On Mon, Dec 23, 2013 at 8:45 PM, Robert O'Callahan rob...@ocallahan.org wrote: That's a mistake. Module owners don't have the authority to make up their own style. Who has been doing this? I was under

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-23 Thread Robert O'Callahan
On Fri, Dec 20, 2013 at 2:35 PM, Jeff Gilbert jgilb...@mozilla.com wrote: Personally, there are a couple of things I don't like about moz-style (though revisions to the central style guide at least have made it better than it used to be), but instead of bikeshedding the central style guide,

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-23 Thread Robert O'Callahan
I think the best way to expend energy on this topic would be to work on tools. https://bugzilla.mozilla.org/show_bug.cgi?id=875605 seems worth getting over the line. Some other kind of checker, possibly based on clang-format, could also be a fine alternative. Just get something working that is

Re: (un)safety of NS_LITERAL_STRING(...).get()

2013-12-12 Thread Robert O'Callahan
On Fri, Dec 13, 2013 at 3:02 PM, Chris Peterson cpeter...@mozilla.comwrote: On 12/12/13, 5:09 PM, L. David Baron wrote: The preferred form would now be: #include mozilla/Char16.h const PRUnichar *comma = MOZ_UTF16(,); I think char16_t is preferred over PRUnichar for new code.

Re: Can we start using C++ STL containers in Mozilla code?

2013-12-10 Thread Robert O'Callahan
On Wed, Dec 11, 2013 at 10:29 AM, Chris Pearce cpea...@mozilla.com wrote: It seems to me that we should be optimizing for developer productivity first, and use profiling tools to find code that needs to be optimized. i.e. we should be able to use STL containers where we need basic ADTs in

Re: Can we start using C++ STL containers in Mozilla code?

2013-12-10 Thread Robert O'Callahan
On Wed, Dec 11, 2013 at 10:50 AM, Benoit Jacob jacob.benoi...@gmail.comwrote: 2013/12/10 Robert O'Callahan rob...@ocallahan.org Keep in mind that proliferation of different types for the same functionality hurts developer productivity in various ways, especially when they have quite

Re: Should we disable autoplay feature of HTMLMediaElement on mobile?

2013-12-08 Thread Robert O'Callahan
Don't these arguments apply to desktop Firefox used at work, in an Internet cafe, or in a library, as well? I think it's important to have an easy way to mute/unmute the browser, but disabling autoplay is probably not the right way to address these issues. Rob -- Jtehsauts tshaei dS,o n Wohfy

Re: Should we disable autoplay feature of HTMLMediaElement on mobile?

2013-12-08 Thread Robert O'Callahan
Maybe we can build something clever based on the per-window volume and muting infrastructure in bug 923247? I think easy per-tab muting is a good thing to try here. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o

NSPR logging dropping log messages

2013-12-05 Thread Robert O'Callahan
I can reproducibly (but nondeterministically) reproduce a problem where setting NSPR_LOG_MODULES, but not NSPR_LOG_FILE, redirecting stdout and stderr to a file using bash , and using mach mochitest-plain, the occasional log message gets dropped. This can be very disturbing when trying to debug

Re: NSPR logging dropping log messages

2013-12-05 Thread Robert O'Callahan
Bill McCloskey pointed me to bug 924253, and his patch there fixed my problem. So basically, don't trust mochitest output until bug 924253 is fixed. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o Whhei csha

Re: Mitigating unified build side effects Was: Thinking about the merge with unified build

2013-11-29 Thread Robert O'Callahan
If everyone puts using namespace foo; inside namespace mozilla {}, that won't help much, right? I'd prefer to minimize the source code changes required here. A tinderbox non-unified build seems like the way to go. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni

Re: Support for non-UTF-8 platform charset

2013-11-25 Thread Robert O'Callahan
On Tue, Nov 26, 2013 at 12:46 AM, Henri Sivonen hsivo...@hsivonen.fiwrote: We have a concept of platform charset that goes back to pre-NT Windows, Mac OS Classic, OS/2 and pre-UTF-8 *nix platforms. This concept gets in the way of doCOMtaminating old code to use only new facilities in

Re: Recent build time improvements due to unified sources

2013-11-20 Thread Robert O'Callahan
On Thu, Nov 21, 2013 at 11:06 AM, Zack Weinberg za...@panix.com wrote: On 2013-11-20 12:37 PM, Benoit Jacob wrote: Talking about ideas for further extending the impact of UNIFIED_SOURCES, it seems that the biggest limitation at the moment is that sources can't be unified between different

Re: Unified builds

2013-11-18 Thread Robert O'Callahan
On Tue, Nov 19, 2013 at 3:31 AM, Boris Zbarsky bzbar...@mit.edu wrote: While true, in the new setup we have a different problem: adding or removing a .cpp file makes other random .cpp files not compile. I don't think we should worry much about this until we have more data on how often it's a

Re: Changes in how Gecko code linkage is defined in the build system

2013-11-18 Thread Robert O'Callahan
Lovely!!! On Tue, Nov 19, 2013 at 3:02 PM, Mike Hommey m...@glandium.org wrote: - FINAL_LIBRARY defines what library your code is going to be linked into. That needs to match an existing LIBRARY_NAME in some other moz.build. Most code will go in either xul, gkmedias or gklayout. Note

Re: Changes in how Gecko code linkage is defined in the build system

2013-11-18 Thread Robert O'Callahan
On Tue, Nov 19, 2013 at 3:32 PM, Mike Hommey m...@glandium.org wrote: FWIW, there's an open bug to fold gkmedias back into xul, but it looks like it's not going to happen soon. https://bugzilla.mozilla.org/show_bug.cgi?id=922912 Egad! Oh well. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon

Re: Unified builds

2013-11-18 Thread Robert O'Callahan
On Tue, Nov 19, 2013 at 4:04 PM, L. David Baron dba...@dbaron.org wrote: I expect that otherwise we'd get pretty frequent bustage with people forgetting to add #includes, and that bustage would then show up when we add or remove files, which would make it a huge pain to add or remove files.

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Robert O'Callahan
When you say iframes you mean content documents that aren't toplevel content documents, right? Can you explain why sessionstore.js needs to observe non-toplevel-content documents at all? I assume there's an obvious answer, I just don't know what it is :-). Rob -- Jtehsauts tshaei dS,o n Wohfy

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Robert O'Callahan
On Wed, Nov 13, 2013 at 5:09 AM, David Rajchenbach-Teller dtel...@mozilla.com wrote: Or we could not save dynamic iframes in non-current positions in the history. Does this mean that currently, if a page creates an IFRAME, loads url A into it, then loads url B into it, sessionstore.js will

Re: .elementFromPoint including XBL anonymous nodes?

2013-11-10 Thread Robert O'Callahan
On Sat, Nov 9, 2013 at 7:32 PM, Benjamin Smedberg benja...@smedbergs.uswrote: Is there a chrome-only API like .elementFromPoint that will tell me which XBL anonymous element is at a point? I don't think so. You probably need to add another parameter to nsIDOMWindowUtils::nodesFromRect

Re: Mozilla development bootcamp

2013-11-03 Thread Robert O'Callahan
On Sun, Nov 3, 2013 at 1:24 PM, bbo...@gmail.com wrote: Added to the etherpad too but here's the list I have so far. I started a github project a month or so ago here: (Still pretty early) https://github.com/bbondy/codefirefox/ And here are some videos, layout will be changing, that's just

Re: Style guidance on declaring foreign namespace return types/args/members in classes

2013-10-31 Thread Robert O'Callahan
On Fri, Nov 1, 2013 at 6:27 AM, Jonathan Watt jw...@jwatt.org wrote: The style guide doesn't seem to address this: When I have, say, a class in the global namespace called nsSVGUtils, what is preferred: class nsSVGUtils { public: // blah blah static mozilla::gfx::FillRule

Re: Layer Construction for Off Main Thread canvas

2013-10-31 Thread Robert O'Callahan
On Thu, Oct 31, 2013 at 11:19 PM, Nicolas Silva nical.si...@gmail.comwrote: With OMTC these days the Layer classes don't hold any logic. All the fancy stuff goes into classes inheriting from CompositableClient (and CompositableHost on the compositor side). While Layer classes can only be

Re: Javascript Based Layout/Rendering Engine DOM

2013-10-30 Thread Robert O'Callahan
On Thu, Oct 31, 2013 at 3:40 AM, Trevor Linton trevor.lin...@gmail.comwrote: I have a curious question which probably won't be possible in any immediate future. Is it possible to re-implement a layout/rendering/render tree system within native JavaScript with DOM bindings (also written in

Re: Layer Construction for Off Main Thread canvas

2013-10-30 Thread Robert O'Callahan
On Thu, Oct 31, 2013 at 5:28 PM, Kyle Huey m...@kylehuey.com wrote: One thing that's come up that we're not quite how to deal with for OMTcanvas is how to modify GetCanvasLayer. Our problem here is that the context here lives on the worker thread, and presumably we need to construct the

Re: Synchronous workers

2013-10-14 Thread Robert O'Callahan
On Mon, Oct 14, 2013 at 11:03 AM, Benjamin Smedberg benja...@smedbergs.uswrote: Having this blocking interface will also support blocking shumway on graphics rendering; there are a fair number of SWF files that use an API to get a synchronous bitmap of their stage, which requires a blocking

Re: Synchronous workers

2013-10-14 Thread Robert O'Callahan
On Mon, Oct 14, 2013 at 4:16 PM, Benjamin Smedberg benja...@smedbergs.uswrote: Is canvas-on-a-worker a short-term project? WebGL is at least. Also from reading the whatwg discussion, I thought you had proposed .toBlob but not .toDataURI specifically so that the bitmap was not synchronously

Re: Synchronous workers

2013-10-14 Thread Robert O'Callahan
On Mon, Oct 14, 2013 at 4:29 PM, Till Schneidereit t...@tillschneidereit.net wrote: From talking to Kyle, it sounds like getting WebGL into workers is much closer than getting all of Context2D, too. Specifically, we need text rendering to work, because we have to be able to render device

Re: Transparent Black, or Are all transparent colors create equal?

2013-10-07 Thread Robert O'Callahan
On Mon, Oct 7, 2013 at 3:11 PM, Chris Peterson cpeter...@mozilla.comwrote: I stumbled upon some layout code that for transparent colors using != or == NS_RGBA(0,0,0,0): http://dxr.mozilla.org/**mozilla-central/search?q=**

Re: C++ Standards Committee meeting next week

2013-09-23 Thread Robert O'Callahan
On Tue, Sep 24, 2013 at 5:18 AM, Trevor Saunders trev.saund...@gmail.comwrote: - virtual constants Yeah baby! - ability to say classes should only be used on stack / heap or not used in one of those That's another good idea! Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus

Re: You want faster builds, don't you?

2013-09-22 Thread Robert O'Callahan
On Mon, Sep 23, 2013 at 1:04 PM, Gregory Szorc g...@mozilla.com wrote: On Sep 22, 2013, at 16:35, Anthony Jones ajo...@mozilla.com wrote: On 21/09/13 17:58, Robert O'Callahan wrote: I don't think that's necessarily true on Windows. If we can find a way to generate Visual Studio projects

Re: [b2g] RFC: new attribute 'mozscrollgrab' for B2G address bar scrolling

2013-09-19 Thread Robert O'Callahan
This should probably be a CSS property. We should write a proper spec for it and propose it to www-style. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d

Re: How to check if an element is visible...

2013-09-13 Thread Robert O'Callahan
On Fri, Sep 13, 2013 at 7:25 AM, Benjamin Smedberg benja...@smedbergs.uswrote: This is a hard problem, and it depends on what question you're asking: * Is a node visible if it's in the window but some other window is covering the current window? * Is a node visible if it's currently scrolled

Re: vsync proposal

2013-09-06 Thread Robert O'Callahan
On Sat, Sep 7, 2013 at 7:02 AM, Jeff Gilbert jgilb...@mozilla.com wrote: Could you clarify number 2? It's a little dense. A better way to state it is this: every layer tree update by the main thread eventually gets a response in the form of a vsync-driven request to tick the corresponding

Re: vsync proposal

2013-09-06 Thread Robert O'Callahan
On Fri, Sep 6, 2013 at 2:51 PM, Robert O'Callahan rob...@ocallahan.orgwrote: On some non-main thread: 1. Wait for vsync event 2. Dispatch refresh driver ticks to all windows that don't already have a pending refresh driver tick unacknowledged by a layer tree update response 3. Wait for N ms

nsTHashtable changes

2013-09-05 Thread Robert O'Callahan
nsTHashtable and its subclasses no longer have an Init method; they are fully initialized on construction, like any good C++ object. You can specify an initial number of buckets by passing an integer parameter to the constructor. nsTHashtables are always initialized now; there is no uninitialized

Re: nsTHashtable changes

2013-09-05 Thread Robert O'Callahan
On Thu, Sep 5, 2013 at 10:16 PM, Kyle Huey m...@kylehuey.com wrote: Did you fix LDAP in comm-central to not use nsInterfaceHashtableMT? That's why I haven't finished Bug 849654. I guess that should get duped to wherever this happened. No, I completely stuffed up my search through

Re: vsync proposal

2013-09-05 Thread Robert O'Callahan
I had some off-thread discussion with Bas about lowering latency. We seem to have agreed on the following plan: On some non-main thread: 1. Wait for vsync event 2. Dispatch refresh driver ticks to all windows that don't already have a pending refresh driver tick unacknowledged by a layer tree

Re: Pass more than one permissions to prompt dialog.

2013-09-04 Thread Robert O'Callahan
On Wed, Sep 4, 2013 at 11:34 PM, ay...@mozilla.com wrote: I'm working on bug 853356 which requires to pass new permissions 'audio-capture' and 'video-capture' together to permission prompt dialog via getUserMedia. My current implementation is to replaced the string 'type' [1] with a string

Re: C++ style question: virtual annotations on methods

2013-09-04 Thread Robert O'Callahan
On Thu, Sep 5, 2013 at 7:40 AM, Ehsan Akhgari ehsan.akhg...@gmail.comwrote: On 2013-09-04 12:18 AM, Robert O'Callahan wrote: I like to put virtual on all methods that are virtual, even when it's not strictly necessary because the method overrides a virtual method of the parent class

Re: Do you consider to port mp3 support on Windows XP

2013-09-03 Thread Robert O'Callahan
On Wed, Sep 4, 2013 at 3:51 AM, lchenneb...@gmail.com wrote: I have an html5 interactive player that works on most famous navigators unless Opera and Firefox. Because of lack of MP3 and MP4 support. It would be great if I could play this kind of medias on firefox because I don't (and

Re: Should we build a new in-process unwind library?

2013-08-30 Thread Robert O'Callahan
On Fri, Aug 30, 2013 at 8:58 PM, Julian Seward jsew...@acm.org wrote: I am not sure how to deal with (4). Really it's completely unrelated to the unwind mechanism -- it has to do with SPS' sampling policy at the level above. There have been some ideas floated around to detect when a thread

Re: Should we build a new in-process unwind library?

2013-08-30 Thread Robert O'Callahan
On Fri, Aug 30, 2013 at 9:41 PM, Julian Seward jsew...@acm.org wrote: That said, AFAICS the core problem is that once a thread blocks and we drop the sampling rate, we have no obvious (direct, notification-based) way to know when it has resumed, and hence are in danger of losing high-frequency

Reproducing bug 837489

2013-08-19 Thread Robert O'Callahan
Can any platform people with AMD graphics hardware on Windows reproduce https://bugzilla.mozilla.org/show_bug.cgi?id=837489, random-looking visual corruption especially (but not only) in the chrome area? Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu

Re: vsync proposal

2013-08-14 Thread Robert O'Callahan
On Wed, Aug 14, 2013 at 9:39 PM, Bas Schouten bschou...@mozilla.com wrote: From: Robert O'Callahan rob...@ocallahan.org That would be good in some ways, but it doesn't handle off-main-thread animation when the main thread's drawing is late (e.g. because the main thread is stuck doing

Re: vsync proposal

2013-08-13 Thread Robert O'Callahan
On Wed, Aug 14, 2013 at 2:13 AM, Jeff Muizelaar jmuizel...@mozilla.comwrote: On 2013-08-12, at 11:05 PM, Robert O'Callahan wrote: Tell me what you think. https://wiki.mozilla.org/User:Roc/VsyncProposal A couple things that are not clear to me from this proposal: - when the vsync event

Re: vsync proposal

2013-08-13 Thread Robert O'Callahan
On Wed, Aug 14, 2013 at 12:13 PM, Bas Schouten bschou...@mozilla.comwrote: Since you want composition to occur whenever drawing has occurred, I don't really think it should really be what's working on doing any processing for the vblank event. The VBlank event should just fire,

vsync proposal

2013-08-12 Thread Robert O'Callahan
Tell me what you think. https://wiki.mozilla.org/User:Roc/VsyncProposal Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r sGients uapr,e tfaokreg

Re: vsync proposal

2013-08-12 Thread Robert O'Callahan
On Tue, Aug 13, 2013 at 3:05 PM, Robert O'Callahan rob...@ocallahan.orgwrote: Tell me what you think. https://wiki.mozilla.org/User:Roc/VsyncProposal Forgot to mention --- this is the result of brainstorming with Matt Woodrow and Nick Cameron this morning. Rob -- Jtehsauts tshaei dS,o n

Re: Exposing the CSS/SVG Filters as Canvas API's

2013-08-08 Thread Robert O'Callahan
Markus is moving with great speed and we should have the necessary Moz2D support landed soonish. I think the biggest outstanding issue is how to spec the canvas API for this. The most obvious approach to me is to add a filter attribute to CanvasRenderingContext2D that takes a CSS filter value and

Re: Exposing the CSS/SVG Filters as Canvas API's

2013-08-08 Thread Robert O'Callahan
On Fri, Aug 9, 2013 at 9:29 AM, K. Gadd k...@luminance.org wrote: Consider this my +1 in favor of a dedicated .colorMatrix attribute, Good, then I'll expect you to back me up in WHATWG with usecases :-). preferably in the form of a Uint8Array or Float32Array instead of another *!@$ string.

Re: Exposing the CSS/SVG Filters as Canvas API's

2013-08-08 Thread Robert O'Callahan
On Fri, Aug 9, 2013 at 10:00 AM, Cameron McCormack c...@mcc.id.au wrote: Why should color matrix become a property if other filters go through a .filter property on the context object? Wouldn't it be more consistent if we just introduced a color-matrix() CSS value? To avoid string parsing

Re: Exposing the CSS/SVG Filters as Canvas API's

2013-08-08 Thread Robert O'Callahan
On Fri, Aug 9, 2013 at 10:00 AM, Benoit Jacob jacob.benoi...@gmail.comwrote: I think that it would make more sense to first try to see to what extent we manage to fix these issues, see what is left of SVG filters after these issues are fixed, and only then consider propagating these concepts

Re: Flash and e10s

2013-08-07 Thread Robert O'Callahan
On Wed, Aug 7, 2013 at 6:05 PM, Markus Stange msta...@themasta.com wrote: On 07.08.13 06:39, Robert O'Callahan wrote: Running windowed Flash within the content process itself would mean giving that content process access to the main window's HWND. What would be the disadvantages of forcing

Re: Flash and e10s

2013-08-07 Thread Robert O'Callahan
On Thu, Aug 8, 2013 at 2:14 AM, Benjamin Smedberg benja...@smedbergs.uswrote: The primary reason I know for windowed Flash to be a huge PITA is because of the deadlock issues caused by attached input queues. I'd love to force Flash to be windowless and use our fullscreen support instead of

Flash and e10s

2013-08-06 Thread Robert O'Callahan
I was talking to people about plans for Flash on e10s. Full support for windowed Flash on e10s is possible but would be a ton of work. Flash is on a downward trajectory and it would be a shame to do a ton of work to support something that may not be relevant for much longer. One idea I had is

Re: Flash and e10s

2013-08-06 Thread Robert O'Callahan
On Wed, Aug 7, 2013 at 4:31 PM, Justin Lebar justin.le...@gmail.com wrote: On Tue, Aug 6, 2013 at 5:46 PM, Robert O'Callahan rob...@ocallahan.org wrote: I was talking to people about plans for Flash on e10s. Full support for windowed Flash on e10s is possible but would be a ton of work

Re: On indirect feedback

2013-08-03 Thread Robert O'Callahan
On Sat, Aug 3, 2013 at 12:43 PM, Brian Smith br...@briansmith.org wrote: I think some people may interpret what you say in that last paragraph the opposite of how you intend. I am pretty sure you mean something like If somebody starts to complain to you about somebody else, then stop them and

On indirect feedback

2013-08-02 Thread Robert O'Callahan
On Sat, Aug 3, 2013 at 9:13 AM, Gregory Szorc g...@mozilla.com wrote: Many of the complaints I've heard have been from overhearing hallway conversations, noticing non-directed complaints on IRC, having 3rd parties report anecdotes, etc. *Please, please, please voice your complaints directly

Re: Using C++0x auto

2013-07-21 Thread Robert O'Callahan
On Mon, Jul 22, 2013 at 3:58 PM, L. David Baron dba...@dbaron.org wrote: Is the idea here that nsRefPtr/nsCOMPtr/etc. would have move constructors, and we'd just return them, and the move constructors plus return value optimizations would take care of avoiding excess reference counting?

Re: Using C++0x auto

2013-07-21 Thread Robert O'Callahan
On Mon, Jul 22, 2013 at 5:39 PM, Justin Lebar justin.le...@gmail.comwrote: But if we return nsRefPtr, then if I have nsRefPtrFoo GetFoo(); Foo* = GetFoo(); that compiles fine (I think?) because nsRefPtrT has an implicit conversion to T*. It doesn't leak, though. OTOH you probably get

Re: Using C++0x auto

2013-07-18 Thread Robert O'Callahan
On Fri, Jul 19, 2013 at 3:34 AM, Ehsan Akhgari ehsan.akhg...@gmail.comwrote: On 2013-07-18 5:48 AM, mscl...@googlemail.com wrote: r-value references 4.3@10.0! Yes This is very useful. I believe the JS engine already rolls their own tricks to implement this semantics.

<    1   2   3   4   >