Re: Intent to implement and ship: Gamepad Extensions `multi touch` and `light indicator`

2019-02-27 Thread Ted Mielczarek
On Wed, Feb 27, 2019, at 6:43 AM, James Graham wrote: > The current thinking is that hardware interaction APIs which rely on > mocks to test should specify the API for testing as part of the > specification (e.g. [1]). So it seems like the same approach could be > used here. > > [1]

Re: Type-based alias analysis and Gecko C++

2019-02-15 Thread Ted Mielczarek
On Fri, Feb 15, 2019, at 4:00 AM, Henri Sivonen wrote: > How committed are we to -fno-strict-aliasing? FWIW, some work was done to investigate re-enabling strict aliasing a while ago but it proved untenable at the time: https://bugzilla.mozilla.org/show_bug.cgi?id=414641 -Ted

Re: New and improved "about:config" for Firefox Desktop

2019-01-25 Thread Ted Mielczarek
On Thu, Jan 24, 2019, at 2:35 PM, Paolo Amadini wrote: > Last year a group of students, Luke, Matthias, and Vincent, designed and > implemented a new version of "about:config" in order to improve the > ergonomics and align the look and feel with other in-content Firefox > pages. They did an

Re: Dropping support for compiling with MSVC in the near future

2018-12-11 Thread Ted Mielczarek
On Mon, Dec 10, 2018, at 8:29 PM, Kartikaya Gupta wrote: > This is sort of tangential, but what's the linking story currently? > Are we still linking with MSVC, or with lld? We're using lld-link for Windows builds in CI:

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Thu, Dec 6, 2018, at 3:34 PM, Jonathan Kew wrote: > While I sympathize with the concern that "supporting more than one > compiler is a maintenance burden", this still leaves me feeling a little > uneasy. Ensuring that our code builds successfully with multiple > compilers is a useful way to

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Thu, Dec 6, 2018, at 6:08 PM, Gijs Kruitbosch wrote: > Can someone elaborate on what this means for debugging on Windows, and > for our onboarding story on Windows? For debugging: as others have pointed out, nothing should change. For onboarding we will continue to require users to install

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Fri, Dec 7, 2018, at 8:37 AM, Simon Sapin wrote: > On 07/12/2018 00:08, Gijs Kruitbosch wrote: > > We're already making people install MSVS to get the relevant Windows > > SDKs (manually, not supported via ./mach bootstrap, and hopefully > > ticking the right boxes in the installer or they have

Dropping support for compiling with MSVC in the near future

2018-12-06 Thread Ted Mielczarek
Hello, In light of the fact that we've switched to clang-cl for our Windows builds[1], we are planning to drop support for compiling Firefox with MSVC in the near future[2]. Our estimate is that this will happen sometime in Q1. Supporting more than one compiler is a maintenance burden and

Please enable build system telemetry

2018-11-09 Thread Ted Mielczarek
TL;DR: the next time you run `mach bootstrap` please answer yes to the prompt to enable build system telemetry. Hello, Those of us who work on the build system realize that building Firefox is not always a pleasant experience. We've done a lot of work over the years to try to improve that

Re: Windows launcher process enabled by default on Nightly

2018-09-27 Thread Ted Mielczarek
Hi Aaron, Great work getting this landed, and thanks for doing the work to minimize the impact on everyone! On Thu, Sep 27, 2018, at 11:19 AM, Aaron Klotz wrote: > 2. Debugging the browser process > > > If you launch Firefox via a debugger, the initial process

Re: Input Delay Metric proposal

2018-09-20 Thread Ted Mielczarek
On Wed, Sep 19, 2018, at 2:42 PM, Randell Jesup wrote: > Problem: > Various measures have been tried to capture user frustration with having > to wait to interact with a site they're loading (or to see the site > data). This includes: > > FID - First Input Delay -- >

Re: Lando: Commit Series Landing Support Beta

2018-09-18 Thread Ted Mielczarek
On Tue, Sep 18, 2018, at 12:28 PM, Steven MacLeod wrote: > Lando support for pushing a series of commits from a Phabricator stack has > been live for the past week or so. Anyone who would like to test & provide > feedback is welcome to start using it. We are leaving the current non-series >

Re: MinGW Target Re-Enabled on TaskCluster

2018-09-12 Thread Ted Mielczarek
On Wed, Sep 12, 2018, at 1:09 AM, Tom Ritter wrote: > Previous Thread: > https://groups.google.com/forum/#!topic/mozilla.dev.platform/r3mYWbb42pM > > As of a few hours ago, there is a new Tier 2 MinGW build on TaskCluster. > It's in the 'Windows MinGW all' line, with the group WMC64 for 'Windows

Re: Rebuild speeds (Was: Re: JS compilation/evaluation APIs are now in #include "js/CompilationAndEvaluation.h")

2018-08-31 Thread Ted Mielczarek
On Thu, Aug 30, 2018, at 6:28 PM, Michael Shal wrote: > On Thu, Aug 30, 2018 at 6:04 PM, Michael Shal wrote: > > > > > > In this case, the 99:44 rebuild times look to be an artifact of how the > > outputs of GenerateServoStyleConsts.py are consumed by a large chunk of the > > Rust and C++ code.

Re: Dead-code removal of unused Rust FFI exports

2018-08-30 Thread Ted Mielczarek
I thought we had filed a Rust issue on this but apparently not. There's some good discussion in this issue: https://github.com/rust-lang/rust/issues/37530 For Firefox, simply having an equivalent to `-fvisilbility=hidden` so that all the symbols in the generated static library are hidden would

Re: Rebuild speeds (Was: Re: JS compilation/evaluation APIs are now in #include "js/CompilationAndEvaluation.h")

2018-08-29 Thread Ted Mielczarek
On Wed, Aug 29, 2018, at 9:08 AM, Boris Zbarsky wrote: > > https://taskcluster-artifacts.net/CLtUuQugTjKONONL4hh5Nw/0/public/14day_report.html > > So my main conclusion from looking at this data is that anything that > causes us to rebuild any rust stuff is just painful... I don't think that's

Re: JS compilation/evaluation APIs are now in #include "js/CompilationAndEvaluation.h"

2018-08-29 Thread Ted Mielczarek
On Tue, Aug 28, 2018, at 10:42 PM, Jeff Walden wrote: > jsapi.h and jsfriendapi.h are mega-huge, monolithic headers. A one-stop > shop is maybe (maybe) convenient for users. But it's terrible for Gecko > and SpiderMonkey: touching jsapi.h rebuilds the world. (The one-stop > shop approach is

Re: Stopgap for Commit Series in Phabricator

2018-08-06 Thread Ted Mielczarek
Thanks for this, Kris! Just an FYI for anyone planning to try this: I was behind a few versions on Mercurial (at 4.3) and I had to update to 4.7 for this extension to work. -Ted On Thu, Jul 26, 2018, at 12:09 PM, Kris Maglione wrote: > Here's an approximate equivalent for hg which doesn't

Re: C++ standards proposal for a embedding library

2018-07-19 Thread Ted Mielczarek
On Wed, Jul 18, 2018, at 12:45 PM, Botond Ballo wrote: > Hi everyone, > > With the proposal for a standard 2D graphics library now on ice [1], > members of the C++ standards committee have been investigating > alternative ways of giving C++ programmers a standard way to write > graphical and

Re: PSA: Automated code analysis now also in Phabricator

2018-07-17 Thread Ted Mielczarek
On Tue, Jul 17, 2018, at 9:22 AM, Jan Keromnes wrote: > TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential > defects in pending patches for Firefox. Great work! This sounds super useful! -Ted ___ dev-platform mailing list

Re: Rust crate approval

2018-07-05 Thread Ted Mielczarek
On Sun, Jul 1, 2018, at 7:56 PM, Xidorn Quan wrote: > The point is that adding a new crate dependency is too easy > accidentally, and it is very possible for reviewers to overlook that. So > it may make sense to introduce a blacklist-ish thing to avoid that to > happen. FYI, we had some

Gecko natvis file now in-tree

2018-05-09 Thread Ted Mielczarek
Hello, I recently landed a patch[1] that added a Gecko.natvis file[2] to the tree. natvis files[3] are Microsoft's current way of providing nicer views of data types for their debuggers. The file as-landed was written by Vlad a few years ago so it could definitely use some changes (there's a

Re: Removing tinderbox-builds from archive.mozilla.org

2018-05-09 Thread Ted Mielczarek
On Wed, May 9, 2018, at 1:11 PM, L. David Baron wrote: > > mozregression won't be able to bisect into inbound branches then, but I > > believe we've always been expiring build artifacts created from integration > > branches after a few months in any case. > > > > My impression was that people use

Uploading symbols from try builds

2018-05-08 Thread Ted Mielczarek
Hello, I landed some patches yesterday[1] that have now merged to m-c to allow uploading symbols from try builds to the symbol server. Previously if you wanted to debug a try server build it involved a bunch of annoying manual steps, but now you can simply ask for symbol upload tasks to run

Re: Default Rust optimization level decreased from 2 to 1

2018-04-25 Thread Ted Mielczarek
On Wed, Apr 25, 2018, at 12:32 PM, Jeff Muizelaar wrote: > At minimum we should make --enable-profiling build with rust-opt. This sounds reasonable, although the quirk is that we default --enable-profiling on for nightly[1], so anyone building m-c will have it enabled. We could make the build

Re: Editing a vendored crate for a try push

2018-04-10 Thread Ted Mielczarek
On Mon, Apr 9, 2018, at 7:18 AM, Henri Sivonen wrote: > What's the current status of tooling for editing vendored crates for > local testing and try pushes? > > It looks like our toml setup is too complex for cargo edit-locally to > handle (or, alternatively, I'm holding it wrong). It also seems

Re: Reading data needed by MOZ_GTEST_BENCH outside the timed benchmark

2018-03-15 Thread Ted Mielczarek
On Thu, Mar 15, 2018, at 9:07 AM, Henri Sivonen wrote: > On Thu, Mar 15, 2018 at 2:51 PM, Ted Mielczarek <t...@mielczarek.org> wrote: > > On Thu, Mar 15, 2018, at 7:22 AM, Henri Sivonen wrote: > >> Do we have a way to read the prerequisite data for MOZ_GTEST_BENCH > &g

Re: Reading data needed by MOZ_GTEST_BENCH outside the timed benchmark

2018-03-15 Thread Ted Mielczarek
On Thu, Mar 15, 2018, at 7:22 AM, Henri Sivonen wrote: > Do we have a way to read the prerequisite data for MOZ_GTEST_BENCH > outside MOZ_GTEST_BENCH so that the disk IO doesn't get timed? I don't know that we have any stock way to do this. I can offer three plausible solutions: 1) If putting

FYI: sccache 0.2.6 released, contains fix for frequent hang in 0.2.5

2018-03-13 Thread Ted Mielczarek
Hello, Yesterday I tagged and released sccache 0.2.6: https://github.com/mozilla/sccache/releases/tag/0.2.6 This contains a fix for a hang that users were encountering with sccache 0.2.5 due to the make jobserver support added in that version. If you are using 0.2.5 you will want to update. If

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

2018-03-09 Thread Ted Mielczarek
On Thu, Mar 8, 2018, at 7:41 PM, Bobby Holley wrote: > (C) The API uses complex arguments like promises that XPIDL doesn't handle > in a nice way. I think this is an understated point. WebIDL was designed explicitly to allow expressing the semantics of JS APIs, where XPIDL is some arbitrary set

Debugging Try server builds

2018-02-12 Thread Ted Mielczarek
If you've debugged builds from the try server in the past (or wanted to but found the process too difficult) I'd be interested to hear from you. Historically this has been a painful process with many manual steps[1], but thanks to some work done[2] by Peter Bengtsson on the new

Re: gkrust compilation RAM requirements and 32-bit systems

2018-02-09 Thread Ted Mielczarek
On Fri, Feb 9, 2018, at 4:49 AM, Henri Sivonen wrote: > Is it expected that Firefox can no longer be built on a 32-bit system? Yes. > The cross-compilation documentation on MDN seems to predate Rust code > in Firefox. Is there an up-to-date guide for compiling Firefox for > ARMv7+NEON (or

Re: Ci, Cr, Cc, and Cu are now automatically defined in all chrome scopes

2018-02-02 Thread Ted Mielczarek
On Thu, Feb 1, 2018, at 5:11 PM, Andrew McCreight wrote: > Bug 767640 just merged to mozilla-central. This patch makes it so that Ci, > Cr, Cc, and Cu are automatically defined in any chrome scope that has a > Components object. Rejoice, because you no longer need to add "var Ci = >

Re: Faster gecko builds with IceCC on Mac and Linux

2018-01-16 Thread Ted Mielczarek
On Tue, Jan 16, 2018, at 10:51 AM, Jean-Yves Avenard wrote: > Sorry for resuming an old thread. > > But I would be interested in knowing how long that same Lenovo P710 > takes to compile *today*….> In the past 6 months, compilation times have > certainly increased > massively.> > Anyhow, I’ve

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

2017-11-21 Thread Ted Mielczarek
On Tue, Nov 21, 2017, at 06:54 AM, Alexey Zvyagin wrote: > Hi! > > I made some crashes by hands (crashfirefox.exe) in Windows 7 and in Unix > through kill -ABRT > > What are the symptoms? In random moments the Firefox v56.* has only-one > core CPU 100% eating. In Windows 7 (64bit) & Linux

Re: How much context does CF_HTML really need?

2017-10-31 Thread Ted Mielczarek
On Tue, Oct 31, 2017, at 05:46 AM, Henri Sivonen wrote: > (Context: I'm trying to understand the requirements for our > serializers in case we rewrite them [in Rust].) > > The HTML fragment parsing algorithm can have only one context node. > The context is never a chain of nodes towards to the

Re: Visual Studio 2017 coming soon

2017-10-25 Thread Ted Mielczarek
On Wed, Oct 25, 2017, at 05:48 PM, David Major wrote: > I'm planning to move production Windows builds to VS2017 (15.4.1) in bug > 1408789. Thanks for doing the work on this! > VS2017 has optimizer improvements that produce faster code. I've seen > 3-6% > improvement on Speedometer. There is

Re: We need better canaries for JS code

2017-10-19 Thread Ted Mielczarek
On Thu, Oct 19, 2017, at 03:19 PM, Mark Banner wrote: > The only thing that might help (that has been discussed) is something > along the lines of flow - an analyser that could work out that 'spice()' > didn't exist, but Dave Townsend mentioned these don't seem to be viable > for us. > >

Re: We need better canaries for JS code

2017-10-19 Thread Ted Mielczarek
On Wed, Oct 18, 2017, at 07:51 AM, Mark Banner wrote: > Looping in firefox-dev as well, as I thin this is an important > discussion. > > On 18/10/2017 09:28, David Teller wrote: > > Hi everyone, > > > >Yesterday, Nightly was broken on Linux and MacOS because of a typo in > > JS code [1].

Re: MinGW Target on TaskCluster

2017-10-09 Thread Ted Mielczarek
On Mon, Oct 9, 2017, at 01:31 AM, Tom Ritter wrote: > As part of our work with Tor, we’ve been working on getting a MinGW-based > build of Windows into TaskCluster. Tor is currently using ESR releases, > and > every ESR they have to go through a large amount of work to get the build > working

Re: How to get pretty stack trace on Linux?

2017-09-21 Thread Ted Mielczarek
On Thu, Sep 21, 2017, at 08:51 PM, Masayuki Nakano wrote: > I'd like to get pretty stack trance which shows method names rather than > only address with tryserver build on Linux. However, > nsTraceRefcnt::WalkTheStack() cannot get method names on Linux as you > know. > > The reason why I need

Re: Re-visiting the DOM tree depth limit in layout

2017-09-15 Thread Ted Mielczarek
On Thu, Sep 14, 2017, at 02:23 AM, Henri Sivonen wrote: > Do I understand correctly that this is an address space issue only and > Windows doesn't actually physically map the pages belonging to the > stack until they are written to? That is, do I understand correctly > that there's no obstacle for

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

2017-09-08 Thread Ted Mielczarek
On Wed, Sep 6, 2017, at 03:45 AM, Alexey Zvyagin wrote: > Dear developers of Firefox, > > I have 55.* version of Firefox at work and at home > At work i have Windows 7 OS, at home the Ubuntu 16.04 LTE > I have my own synced profile. I don't have problem with syncing... > > In both OSes i

PSA: symbol server now available via https

2017-09-01 Thread Ted Mielczarek
Just an FYI, yesterday the symbol server (symbols.mozilla.org) was moved to a different server backend[1], and as a result it's now also available via https. It should continue to work seamlessly at the existing URL, but you can update your symbol server paths to https://symbols.mozilla.org/ if

Re: Implementing a Chrome DevTools Protocol server in Firefox

2017-08-31 Thread Ted Mielczarek
On Wed, Aug 30, 2017, at 08:20 PM, Eric Rescorla wrote: > I assume this is going to involve TLS (generally this is a requirement > for > H2). In Firefox, this is done with NSS. Does Tokio/Hyper cleanly separate > out the TLS stack so that you can do that? This was mostly answered in another

Re: sccache as ccache

2017-08-18 Thread Ted Mielczarek
On Thu, Aug 17, 2017, at 10:01 PM, Mike Hommey wrote: > On Wed, Jul 26, 2017 at 09:54:14AM -0400, Alex Gaynor wrote: > > If you're on macOS, you can also get sccache with `brew install sccache`. > > If you're on macOS and were hitting errors building openvr, this is > fixed in sccache master.

Re: Firefox and clang-cl

2017-08-15 Thread Ted Mielczarek
On Mon, Aug 14, 2017, at 04:36 PM, Ehsan Akhgari wrote: > > * Performance: We switched from msvc+pgo to clang without pgo and got > > comparable perf. We did have to use an order file (/order: flag to > > link.exe) to get comparable startup perf. > That is very interesting! This is one of the

Re: sccache as ccache

2017-08-02 Thread Ted Mielczarek
On Wed, Aug 2, 2017, at 12:26 PM, Ben Kelly wrote: > On Wed, Jul 26, 2017 at 9:05 AM, Ted Mielczarek > <t...@mielczarek.org> wrote:>> Yesterday I published sccache 0.2 to > crates.io, so you can now `cargo>> install sccache` and get the latest > version (it'

Re: refcounting [WAS: More Rust code]

2017-08-02 Thread Ted Mielczarek
On Wed, Aug 2, 2017, at 08:32 AM, Nathan Froyd wrote: > On Wed, Aug 2, 2017 at 7:37 AM, Enrico Weigelt, metux IT consult > wrote: > > On 31.07.2017 13:53, smaug wrote: > >> Reference counting is needed always if both JS and C++ can have a > >> pointer to the object. > > >

Re: sccache as ccache

2017-07-26 Thread Ted Mielczarek
On Wed, Jul 26, 2017, at 12:57 PM, Simon Sapin wrote: > On 26/07/2017 15:05, Ted Mielczarek wrote: > >ac_add_options --with-ccache=sccache > > When used together with icecc, this appears to force all jobs to run > locally which makes icecc pointless. We should figur

Re: sccache as ccache

2017-07-26 Thread Ted Mielczarek
On Wed, Jul 26, 2017, at 10:46 AM, Kan-Ru Chen wrote: > Windows support sounds very exciting! Will it support cache sharing? Currently sccache supports a few different cache storage backends: * local disk * Amazon S3 * Google Cloud Storage * Redis However, the cache keys currently wind up with

sccache as ccache

2017-07-26 Thread Ted Mielczarek
Yesterday I published sccache 0.2 to crates.io, so you can now `cargo install sccache` and get the latest version (it'll install to ~/.cargo/bin). If you build Firefox on Linux or OS X you can (and should) use sccache in place of ccache for local development. It's as simple as adding this to your

Re: More Rust code

2017-07-17 Thread Ted Mielczarek
Nick, Thanks for kicking off this discussion! I felt like a broken record talking to people about this in SF. From my perspective Rust is our single-biggest competitive advantage for shipping Firefox, and every time we choose C++ over Rust we throw that away. We know the costs of shipping

Re: More Rust code

2017-07-17 Thread Ted Mielczarek
On Wed, Jul 12, 2017, at 07:41 PM, Mike Hommey wrote: > On Wed, Jul 12, 2017 at 04:06:39PM -0700, Eric Rahm wrote: > > Interesting points. > > > >- *using breakpad* - was the problem that creating wrappers to access > >the c/c++ code was too tedious? Could bindgen help with that, if not

Re: switch to macosx cross-compiled builds on taskcluster on trunk

2017-06-22 Thread Ted Mielczarek
On Thu, Jun 22, 2017, at 01:08 AM, Ralph Giles wrote: > On Wed, Jun 21, 2017 at 9:47 PM, Randell Jesup > wrote: > > > > Does this have affect on our still using the 10.7 Mac SDK? > > > We are still building against the macOS 10.7 SDK, but we can update to > 10.9 > once

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Ted Mielczarek
On Tue, Jun 20, 2017, at 03:59 AM, Julian Seward wrote: > I've used VTune on Linux and have some idea what it can and can't do. > I have tried it on Mac, but my impression, from the Intel web site, is > that it is at least available for Mac. Apparently the version for Mac is just a GUI for

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Ted Mielczarek
On Thu, Jun 1, 2017, at 09:23 PM, Mike Hommey wrote: > On Thu, Jun 01, 2017 at 09:09:44PM -0400, Nathan Froyd wrote: > > Could we try to make a bare --enable-optimize --enable-debug build use > > -Og if it was available? > > It might make sense, but we need to be careful that this will affect the

Re: Have you run 'mach bootstrap' lately?

2017-05-12 Thread Ted Mielczarek
On Fri, May 12, 2017, at 10:45 AM, Sylvestre Ledru wrote: > Would it be possible to add a check like: > "You haven't updated your local configuration since XX days, please > consider running > mach bootstrap ?" We've had mach produce nag messages like that in the past and they have been

Re: CodeCoverage Monthly Update

2017-05-09 Thread Ted Mielczarek
On Tue, May 9, 2017, at 05:48 AM, Henri Sivonen wrote: > On Thu, Apr 6, 2017 at 6:26 AM, Kyle Lahnakoski > wrote: > > * Getting Rust to emit coverage artifacts is important: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1335518 > > Is there a plan to factor "cargo

Re: Editing vendored crates take #2

2017-05-02 Thread Ted Mielczarek
On Tue, May 2, 2017, at 02:54 PM, Josh Matthews wrote: > On 2017-04-28 3:07 PM, Boris Zbarsky wrote: > > On 4/28/17 1:05 PM, Josh Matthews wrote: > > 2) Run "cargo vendor" and watch it fail because of something I never > > figured out. > > My cargo from April 19 claims that "cargo vendor" isn't

FYI: Visual C++ 2017 build system support landing

2017-04-25 Thread Ted Mielczarek
I'm about to land some patches[1] that will allow configure to detect a Visual C++ 2017 installation. You should be able to launch a MozillaBuild `start-shell.bat` shell and build without having to have the Visual C++ environment configured. The only thing that will change from the current state

Re: Faster gecko builds with IceCC on Mac and Linux

2017-03-24 Thread Ted Mielczarek
On Fri, Mar 24, 2017, at 12:10 AM, Jeff Muizelaar wrote: > I have a Ryzen 7 1800 X and it does a Windows clobber builds in ~20min > (3 min of that is configure which seems higher than what I've seen on > other machines). This compares pretty favorably to the Lenovo p710 > machines that people are

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 02:43 PM, Ted Mielczarek wrote: > Similarly, I heard from someone (I can't remember who it was) that said > they could do a Linux Firefox build in ~8(?) minutes on the same > hardware. (I will try to track down the source of that number.) That > gives us a fair

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 03:16 PM, Ben Kelly wrote: > On Fri, Mar 17, 2017 at 2:52 PM, Ben Kelly <bke...@mozilla.com> wrote: >> On Fri, Mar 17, 2017 at 2:43 PM, Ted Mielczarek >> <t...@mielczarek.org> wrote: >> >> >> >> >> >>

Re: Third Party Library Alert Service

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 02:40 PM, trit...@mozilla.com wrote: > On Friday, March 17, 2017 at 1:35:15 PM UTC-5, Sylvestre Ledru wrote: > > Looks like we are duplicating some contents and efforts with: > > https://dxr.mozilla.org/mozilla-central/source/tools/rewriting/ThirdPartyPaths.txt > > Any

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 02:20 PM, Ben Kelly wrote: > On Fri, Mar 17, 2017 at 1:36 PM, Ted Mielczarek <t...@mielczarek.org> > wrote: > > > Back to the original topic, I recently set up a fresh Windows machine > > and I followed the same basic steps (enable performanc

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 01:12 PM, Chris Peterson wrote: > On 3/17/2017 1:45 AM, Honza Bambas wrote: > > I have a very similar setup, with even way more exceptions added, but > > none of them has the desired effect. Unfortunately, the only way to make > > MsMpEng shut up is to disable run-time

Re: Is there a way to improve partial compilation times?

2017-03-09 Thread Ted Mielczarek
On Wed, Mar 8, 2017, at 05:43 PM, Ehsan Akhgari wrote: > On 2017-03-08 11:31 AM, Simon Sapin wrote: > > On 08/03/17 15:24, Ehsan Akhgari wrote: > >> What we did in the Toronto office was walked to people who ran Linux on > >> their desktop machines and installed the icecream server on their > >>

Re: Editing vendored crates

2017-02-27 Thread Ted Mielczarek
On Mon, Feb 27, 2017, at 12:32 PM, Henri Sivonen wrote: > On Mon, Feb 27, 2017 at 7:04 PM, Ralph Giles wrote: > > On Mon, Feb 27, 2017 at 4:03 AM, Henri Sivonen wrote: > > > >> I find this level of difficulty (self-inflicted quasi-Tivoization > >>

Re: Should cheddar-generated headers be checked in?

2017-02-23 Thread Ted Mielczarek
On Thu, Feb 23, 2017, at 06:40 AM, Emilio Cobos Álvarez wrote: > On Thu, Feb 23, 2017 at 08:25:30AM +0200, Henri Sivonen wrote: > > On Wed, Feb 22, 2017 at 5:49 PM, Ted Mielczarek <t...@mielczarek.org> wrote: > > > Given that > > > the C API here is under your com

Re: Should cheddar-generated headers be checked in?

2017-02-23 Thread Ted Mielczarek
On Thu, Feb 23, 2017, at 08:27 AM, Nathan Froyd wrote: > On Thu, Feb 23, 2017 at 1:25 AM, Henri Sivonen > wrote: > >> Alternately you could just generate it at build time, and we could pass > >> the path to $(DIST)/include in a special environment variable so you > >> could

Re: Should cheddar-generated headers be checked in?

2017-02-22 Thread Ted Mielczarek
On Wed, Feb 22, 2017, at 07:11 AM, Henri Sivonen wrote: > Looking at mp4parse, the C header is generated: > https://searchfox.org/mozilla-central/source/media/libstagefright/binding/mp4parse_capi/build.rs > But also checked in: >

Re: Doxygen output?

2017-02-21 Thread Ted Mielczarek
We have auto-generated docs using Sphinx on ReadTheDocs[1]. If someone was motivated, it looks like there does exist code[2] to bridge doxygen docs into Sphinx, so it should be possible to get those docs into the existing RTD setup. There are even docs on RTD[3] for how to add new docs! -Ted 1.

Re: FYI: We've forked the Breakpad client code

2017-02-09 Thread Ted Mielczarek
On Thu, Feb 9, 2017, at 02:47 PM, Aaron Klotz wrote: > This is great news, Ted! > > Are you going to be creating a module for this? Who are the peers? I don't think a new module is necessary, we've covered the existing integration code (nsExceptionHandler.cpp etc) under the Toolkit module for a

FYI: We've forked the Breakpad client code

2017-02-09 Thread Ted Mielczarek
FYI, I landed a patch[1] yesterday that forked the Breakpad client code. Everything that was in toolkit/crashreporter/google-breakpad/src/client is now in toolkit/crashreporter/breakpad-client. Google has switched Chromium to using Crashpad (their new crash reporting library) on Windows, OS X and

Re: Decision owner for Rust usage in Gecko.

2017-02-07 Thread Ted Mielczarek
On Tue, Feb 7, 2017, at 03:50 PM, Johnny Stenback wrote: > Hey all, > > Over the coming weeks/months/years we'll be adding more and more Rust > code > into Gecko. As that work progresses (it's already in full swing in case > you > haven't been paying attention) it'll become more and more

Re: A reminder about MOZ_MUST_USE and [must_use]

2017-01-20 Thread Ted Mielczarek
On Fri, Jan 20, 2017, at 08:19 AM, Nicolas B. Pierron wrote: > > The Rust case is helped by the fact that `Result` is the defacto type > > for returning success or error, and it's effectively `must_use`. We > > don't have a similar default convention in C++. > > We have > >

Re: A reminder about MOZ_MUST_USE and [must_use]

2017-01-20 Thread Ted Mielczarek
On Thu, Jan 19, 2017, at 07:00 PM, gsquel...@mozilla.com wrote: > > I think the point is that it's not obvious that "must check the return > > value" is a sufficiently-dominant common case for arbitrary return values. > > FWIW, Rust took the [must_use] rather than [can_ignore] approach too. > >

Re: [dev-servo] Intent to vendor Servo in mozilla-central

2017-01-11 Thread Ted Mielczarek
On Wed, Jan 11, 2017, at 06:03 AM, Henri Sivonen wrote: > Does that mean that crates under third_party/rust/ are going to have > their entire histories imported in the future? Currently, they only > have vendoring-time snapshots. I'm unaware of any plans to do this. I'd expect us to have a

Re: Rust required to build Gecko

2017-01-03 Thread Ted Mielczarek
On Wed, Dec 21, 2016, at 04:56 PM, Julian Seward wrote: > On 21/12/16 07:55, Jim Blandy wrote: > > The only things I really want anyway are: > > > > mk_add_options MOZ_OBJDIR=obj-bug > > ac_add_options --enable-debug='-g3 -O0 -fno-inline' > > ac_add_options --disable-optimize > > As a side note,

Re: Introducing mozilla::Result for better error handling

2016-12-21 Thread Ted Mielczarek
On Wed, Dec 21, 2016, at 12:30 PM, Jason Orendorff wrote: > The implicit conversion solves a real problem. Imagine these two > operations > have two different error types: > > MOZ_TRY(JS_DoFirstThing()); // JS::Error& > MOZ_TRY(mozilla::pkix::DoSecondThing()); // pkix::Error > >

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Ted Mielczarek
On Wed, Nov 9, 2016, at 11:41 AM, Kartikaya Gupta wrote: > I'm actually trying to debug a rust issue right now and have some > questions. I've done the |mach vendor rust| step and got all the > vendored crates. Now let's say that in one of the dependencies (the > 'cmake' crate in my case) there's

Adding Rust code to Gecko, now documented

2016-11-09 Thread Ted Mielczarek
I recently wrote some documentation on how to add Rust code to Gecko: http://gecko.readthedocs.io/en/latest/build/buildsystem/rust.html It should be fairly straightforward for most use cases (thanks to Nathan Froyd for doing the lion's share of the work to make it so), but if there's anything

Re: Converting assertions into release assertions

2016-09-23 Thread Ted Mielczarek
On Fri, Sep 23, 2016, at 10:20 AM, Ehsan Akhgari wrote: > On 2016-09-23 8:49 AM, Gijs Kruitbosch wrote: > > Then this enables me to answer Ehsan's question. These are the builds > > I've recently tried using (e.g. when debugging intermittents in VMs > > because then I don't need to set up too much

Re: Converting assertions into release assertions

2016-09-23 Thread Ted Mielczarek
On Fri, Sep 23, 2016, at 05:58 AM, Panos Astithas wrote: > I used to do that in the past, but nowadays artifact builds have changed > the cost-benefit trade-off so very few people bother AFAIK, when not > touching C++ code. If we could get artifact builds to use --enable-debug > and

Re: Rust 1.10 (to be) required to build Firefox with --enable-rust

2016-08-10 Thread Ted Mielczarek
On Wed, Aug 10, 2016, at 11:28 AM, Gregory Szorc wrote: > I'll be marking that bug wontfix as soon as I get in front of a computer > with my BMO credentials. We plan to have no more releases of > MozillaBuild. > > There is support for installing Rust via rustup in 'mach bootstrap'. That >

Re: Rust code in mozilla-central now builds via cargo

2016-08-08 Thread Ted Mielczarek
On Sun, Aug 7, 2016, at 06:06 PM, Nathan Froyd wrote: > TL; DR: Bug 1231764 has landed on mozilla-central; the build system > now invokes cargo to build all the Rust code in m-c. This should > result in a better Rust developer experience, as well as making it > easier to import Rust libraries

Re: realtime audio on linux

2016-07-18 Thread Ted Mielczarek
You've got great timing, support for --enable-jack just landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/4ab76338931e -Ted ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Enabling seccomp-bpf for content process on nightly Linux desktop

2016-07-06 Thread Ted Mielczarek
On Tue, Jul 5, 2016, at 11:18 PM, Jed Davis wrote: > Benjamin Smedberg writes: > > > Assuming these crashes show up in crash-stats.mozilla.com, are there > > particular signatures, metadata, or other patterns that would let us say > > "this crash is caused by a sandbox

Re: Documentation on how to read crash reports

2016-06-03 Thread Ted Mielczarek
On Thu, May 26, 2016, at 02:41 PM, Benoit Girard wrote: > - Crash address can give you a hint as to what's going on: 0x0 -> null > crash, 0x8 -> null offset accessing a member like this->mFoo, N.B.: due to the way addressing works on x86-64, if the crash address is "0x0" for a Linux/OS X crash

Re: Documentation on how to read crash reports

2016-06-03 Thread Ted Mielczarek
On Thu, May 26, 2016, at 09:52 AM, Benjamin Smedberg wrote: > https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/Debugging_a_minidump I spent some time today cleaning this page up a bit. I streamlined the Windows section (since you no longer need to manually download the matching binaries

Re: All about crashes

2016-06-03 Thread Ted Mielczarek
On Tue, May 24, 2016, at 04:58 PM, Lawrence Mandel wrote: > "Improve ranking of crash clusters." > > I think this is weighting or estimating impact of a crash instead of > volume > of submissions, which is how we have historically processed the clusters. > Severity is one component with startup

Re: All about crashes

2016-06-03 Thread Ted Mielczarek
On Wed, May 25, 2016, at 01:47 AM, Eric Rahm wrote: > Details on using rr to debug crashes would certainly be nice. In my experience, if a crash is reproducible it's generally straightforward to fix. rr could be useful if a crash is hard to reproduce or intermittent, but once a developer can

Re: All about crashes

2016-06-03 Thread Ted Mielczarek
On Wed, May 25, 2016, at 10:27 PM, Eric Rescorla wrote: > - Making it so that certain kinds of defects still happen but they are > safer. > For instance, in C writing dereferencing past the end of an array is > undefined behavior and may well cause something horrible, in Python > you get an

Re: Common crashes due to MOZ_CRASH and MOZ_RELEASE_ASSERT

2016-06-01 Thread Ted Mielczarek
On Tue, May 31, 2016, at 09:26 PM, Jeff Gilbert wrote: > On Tue, May 31, 2016 at 4:39 PM, Nicholas Nethercote > wrote: > > On Wed, Jun 1, 2016 at 1:05 AM, Benjamin Smedberg > > wrote: > >> You shouldn't need to annotate the file/line separately,

Re: Readable Bug Statuses in Bugzilla

2016-05-24 Thread Ted Mielczarek
On Tue, May 24, 2016, at 11:45 AM, Emma Humphries wrote: > Last week the bugzilla.mozilla.org team had a work week in the San > Francisco office. They were finishing the work on the modal edit view in > Bugzilla, and joined them to land another new feature: Readable Statuses. > > Bugs in

Re: pushPrefEnv/popPrefEnv/flushPrefEnv now return Promises

2016-05-20 Thread Ted Mielczarek
On Thu, May 19, 2016, at 07:09 PM, Matthew N. wrote: > Hello, > > One of the reasons developers have been avoiding pushPrefEnv compared to > the synchronous set*Pref (with a registerCleanupFunction) is because > pushPrefEnv required using a callback function to wait for the > preference change

Re: How should I measure responsiveness?

2016-05-17 Thread Ted Mielczarek
On Tue, May 17, 2016, at 05:13 PM, Jason Orendorff wrote: > Hi everyone. > > I'm trying to figure out how to measure the effects of a possible change > Morgan Phillips is making to the Slow Script dialog.[1] One specific > thing > we want to measure is "responsiveness" in the few seconds after a

Re: Updating 32-bit Windows users to 64-bit Windows builds?

2016-05-12 Thread Ted Mielczarek
arget, but information about > plugins or RAM is not something we know about when serving updates. > > On 2016-05-12 11:45 AM, Ted Mielczarek wrote: > > Hello, > > > > Given all the discussion around SSE[2] lately, I was curious as to > > whether we had made any pl

Updating 32-bit Windows users to 64-bit Windows builds?

2016-05-12 Thread Ted Mielczarek
Hello, Given all the discussion around SSE[2] lately, I was curious as to whether we had made any plans to update Windows users that are running 32-bit Windows builds on a 64-bit Windows OS to our 64-bit Windows builds. The 64-bit Windows builds do use SSE2, since that's a baseline requirement

  1   2   >