Re: Intent to ship: accept spaces and tabs in unquoted values (of e.g. "filename") used in Content-Disposition parameterized header pairs to to align with other browsers

2020-08-19 Thread Gijs Kruitbosch
It's been pointed out to me that I neglected to merge the "intent to prototype" requirements into my email. So: Platform coverage: everywhere. Preference: no pref. DevTools bug: covered by existing network tooling (it already shows the full header). Other browsers: as noted, they already do th

Intent to ship: accept spaces and tabs in unquoted values (of e.g. "filename") used in Content-Disposition parameterized header pairs to to align with other browsers

2020-08-19 Thread Gijs Kruitbosch
As of Firefox 81 I intend to update our parsing of Content-Disposition headers so that spaces/tabs in unquoted values are treated as part of the value (rather than as a separator, cutting off the value). This is what Blink and Webkit already do. Bug for this change: https://bugzilla.mozilla.or

Re: Proposal: remove support for running desktop Firefox in single-process mode (e10s disabled) anywhere but in tests

2020-06-17 Thread Gijs Kruitbosch
t this has started breaking I think it is actively harmful to our users for us to allow them to disable e10s. On Wed, Jun 10, 2020 at 11:30 AM Gijs Kruitbosch wrote: (Copied to fx-dev; Replies to dev-platform please.) Hello, Just over a year ago, I started a discussion[0] about our supp

Re: Proposal: remove support for running desktop Firefox in single-process mode (e10s disabled) anywhere but in tests

2020-06-10 Thread Gijs Kruitbosch
ope of keeping it working without running the full test suite in that mode and I don't think anyone wants to do that. Now that this has started breaking I think it is actively harmful to our users for us to allow them to disable e10s. On Wed, Jun 10, 2020 at 11:30 AM Gijs Kruitbosch wrote:

Re: Proposal: remove support for running desktop Firefox in single-process mode (e10s disabled) anywhere but in tests

2020-06-10 Thread Gijs Kruitbosch
hat in the 80 cycle if others agree that's worth doing, though I am probably not the best person to try to fix our valgrind/gtest stuff... [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1549856 [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1552140 [2] https://bugzilla.mozilla.org/show_bug.c

Proposal: remove support for running desktop Firefox in single-process mode (e10s disabled) anywhere but in tests

2020-06-10 Thread Gijs Kruitbosch
(Copied to fx-dev; Replies to dev-platform please.) Hello, Just over a year ago, I started a discussion[0] about our support for disabling e10s. The outcome of that was that we removed support for disabling e10s with a pref on Desktop Firefox with version 68, except for use from automation. W

Re: PSA: The `mach bootstrap` installed Mercurial `evolve` extension needs an update

2019-12-03 Thread Gijs Kruitbosch
Note that running `./mach vcs-setup` will do this, when it prompts: It looks like the setup wizard has already installed a copy of the evolve extension on your machine, at {evolve_dir}. (Relevant config option: extensions.evolve) Would you like to update evolve to the latest version? (Yn) a

Re: Intent to ship: Add image/webp to default Accept header

2019-11-01 Thread Gijs Kruitbosch
Would this fix https://bugzilla.mozilla.org/show_bug.cgi?id=1526731#c15 ? (That is, would we now send image/webp as part of the accept header for the fetch() / nsIWebBrowserPersist requests?) ~ Gijs On 31/10/2019 23:31, Junior Hsu wrote: Summary: I'd like to increase the visibility for this c

Re: C++ standards proposal for a embedding library

2019-10-25 Thread Gijs Kruitbosch
On 25/10/2019 21:52, Eric Rescorla wrote: On Fri, Oct 25, 2019 at 12:21 PM Botond Ballo wrote: My understanding (which may be wrong!) is that the purpose of the C++ proposal isn't to enable creating Web browsers around the API but to use the API to render the GUI for a local C++ app whose prim

Re: C++ standards proposal for a embedding library

2019-10-24 Thread Gijs Kruitbosch
Is there some visibility into the feedback by other participants (esp. other browser vendors) and why they think this is a good idea? What are the arguments *for* this thing, and have they engaged with our arguments against at all? As a desktop Firefox person, "embedding" Gecko and providing U

Re: Intent to ship: Web Speech API

2019-10-12 Thread Gijs Kruitbosch
The document says "The WebSpeech API allows websites to enable speech input within their experiences." and that it is emphatically NOT "Text-to-speech/narration". This doesn't correspond to the original email here: As of October 11th, the Emerging Technologies Team intend to turn "Web Speech

Re: Intent to ship: Web Speech API

2019-10-07 Thread Gijs Kruitbosch
On 07/10/2019 02:55, Marcos Caceres wrote: - speech is processed in our cloud servers, not on device. Is this the case for both recognition and synthesizing? It's not clear from this concise description. Also, hasn't window.speechSynthesis been shipped before now? It's used from e.g. read

Re: Debug builds and WebGL/OpenGL

2019-09-18 Thread Gijs Kruitbosch
Yes, there are newer builds accessible via https://tools.taskcluster.net/index/gecko.v2.mozilla-central.latest.firefox (click a platform, e.g. linux64-debug on the left, then find the `target.tar.bz2` file (target.dmg for mac, target.zip for windows) on the right-hand-side) We should probab

Re: Help: why won't Thunderbird display mail in mochitest conditions?

2019-08-28 Thread Gijs Kruitbosch
On 26/08/2019 23:40, Geoff Lankow wrote: Hi Over the past year or so, I've been adding mochitests for new Thunderbird features. It's recently occurred to me that in a mochitest, Thunderbird does not display mail messages. Not even the message header list, just a blank rectangle where the mess

Re: Revising the frequency threshold for disabling intermittents?

2019-07-08 Thread Gijs Kruitbosch
On 08/07/2019 18:29, Maher( 馬羅成 )Joel wrote: Getting accurate data on this is hard as we do a great job of tracking all failures, but not all passing instances. How hard would it be to fix this? Is it tracked / part of some team's work at the moment? ~ Gijs __

Re: Coding style 🙄 : `int` vs `intX_t` vs `unsigned/uintX_t`

2019-07-05 Thread Gijs Kruitbosch
On 05/07/2019 17:36, Ehsan Akhgari wrote: On Thu, Jul 4, 2019 at 8:05 AM Gerald Squelart wrote: - Our latest coding style [1] points at Google's, which has a section about Integer Types [3], and the basic gist is: Use plain `int` for "not-too-big" numbers If you can 100% guarantee that they

Re: Outline of a plan to remove all XUL documents from mozilla-central

2019-05-15 Thread Gijs Kruitbosch
see any. ~ Gijs On 15/05/2019 16:42, Brendan Dahl wrote: https://bugzilla.mozilla.org/show_bug.cgi?id=1550801 On Wed, May 15, 2019 at 6:30 AM Gijs Kruitbosch wrote: On 14/05/2019 16:32, Brian Grinstead wrote: 1. Load all XUL documents as XHTML using the prototype cache. This

Re: Outline of a plan to remove all XUL documents from mozilla-central

2019-05-15 Thread Gijs Kruitbosch
On 14/05/2019 16:32, Brian Grinstead wrote: 1. Load all XUL documents as XHTML using the prototype cache. This doesn’t require any file renaming, we will just detect a .xul file and act like it’s .xhtml. This is tracked in bug 1550801

Changes to turning off e10s

2019-05-13 Thread Gijs Kruitbosch
(Cross-post: m-d-platform and firefox-dev) Hello, (If you don't care about turning off e10s, you can stop reading.) At the end of last week I landed changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1548941 that may affect how you turn off e10s. The broad aim was to ensure that we stop g

Re: Lack of browser mochitests in non-e10s configuration and support for turning off e10s on desktop going forward

2019-05-03 Thread Gijs Kruitbosch
On 01/05/2019 19:01, Bobby Holley wrote: This thread is getting long, so here's a quick recap: * It it well-understood that a number of developers use --disable-e10s as a debugging aid, so more +1s to that effect aren't needed. * The "please speak up" is aimed at developers who want to _remove_ 1

Re: Lack of browser mochitests in non-e10s configuration and support for turning off e10s on desktop going forward

2019-04-29 Thread Gijs Kruitbosch
On 26/04/2019 18:05, Joel Maher wrote: This was announced last night: https://groups.google.com/forum/#!topic/mozilla.dev.platform/k-irJtmCcqg This seems to suggest we shouldn't make fennec-related changes until the 71 cycle and that we're not 100% certain that we won't ship it past esr68. O

Re: Lack of browser mochitests in non-e10s configuration and support for turning off e10s on desktop going forward

2019-04-25 Thread Gijs Kruitbosch
currently on automation are probably sufficient to continue support for this use-case, but if we turn those off, we should consider this workflow and how much we're willing to do to preserve it. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1530977#c0 On Wed, Apr 17, 2019 at 5:40 AM Gijs Krui

Lack of browser mochitests in non-e10s configuration and support for turning off e10s on desktop going forward

2019-04-17 Thread Gijs Kruitbosch
Hello, Today it came to my attention that there are no 1proc (non-e10s) browser mochitests running anymore. It appears they were disabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1433276 in early 2018, which is somewhat odd because it looks like the bug talks about linux32, but remov

Re: Proposal to remove unnecessary [type] attributes on script tags in mozilla-central

2019-04-09 Thread Gijs Kruitbosch
ibutes and URLs etc. end up shown in the debugger? ~ Gijs Brian On Apr 9, 2019, at 3:57 AM, Gijs Kruitbosch wrote: On 09/04/2019 11:16, James Graham wrote: I also wonder if there are other non-wpt tests that would be broken by such a change?? This was my thought as well. Is there a compell

Re: Proposal to remove unnecessary [type] attributes on script tags in mozilla-central

2019-04-09 Thread Gijs Kruitbosch
On 09/04/2019 11:16, James Graham wrote: I also wonder if there are other non-wpt tests that would be broken by such a change?? This was my thought as well. Is there a compelling reason to want to do this rewrite for extant HTML mochitest test files? ~ Gijs _

Re: Intent to implement and ship: CSS 'prefers-color-scheme' media feature

2019-04-01 Thread Gijs Kruitbosch
Are there also plans to revisit our longstanding foreground/background/link/visited-link colouring prefs (as well as their companion use_system_colors pref) in light of this set of changes? They've never really worked very well, nobody has really taken on fixing their UX, and it would be nice i

Re: Intent to ship: aligning with the spec on document.open behavior and removing wyciwyg

2019-02-22 Thread Gijs Kruitbosch
On 22/02/2019 22:14, Boris Zbarsky wrote: All the "wyciwyg" bits in the tree are being removed in the process. \o/ ~ Gijs ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Dropping support for compiling with MSVC in the near future

2018-12-06 Thread Gijs Kruitbosch
Can someone elaborate on what this means for debugging on Windows, and for our onboarding story on Windows? I don't do this very often, but I ran into this today and the story is already very poor. I'm currently trying to work out why a patch I have crashes on startup. I tried using google, an

Re: What is the future of XMLHttpRequest.mozAnon ?

2018-09-14 Thread Gijs Kruitbosch
On 14/09/2018 10:34, john.biel...@googlemail.com wrote: For example, if multiple www-authenticate headers are send, fetch will return them as a list joined by "," while XHR returns them as a list joined by "\n". Since a digest auth header includes "," itself, XHR is for me the better option her

Re: Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

2018-08-22 Thread Gijs Kruitbosch
On 22/08/2018 21:29, Mark Banner wrote: I would like to propose that we require dangling commas for multi-line object/arrays in Javascript code for mozilla-central. Strong +1 from me as well. I would propose that we roll it out on a per-directory basis. For example, we could do all of browser

Re: Intent to move Activity Stream into its own process

2018-06-18 Thread Gijs Kruitbosch
Hey, This sounds really interesting. However, wouldn't this mean that we will do a process switch for the tab's browser whenever we load a URL in the same tab that has AS in it? Or would you still intend to run the actual AS new tab page in a "normal" tab process? If it *would* mean a proces

Re: Is super-review still a thing?

2018-04-21 Thread Gijs Kruitbosch
On 20/04/2018 22:23, Kris Maglione wrote: I can't remember the last time I saw a super-review request, but it's still documented as a policy[1]. Is it still a thing? Do we want it to still be a thing? Not in the way it used to be. See https://groups.google.com/forum/#!topic/mozilla.governance

Re: Using WebIDL objects in XPIDL

2018-04-19 Thread Gijs Kruitbosch
Dumb question because I don't do this very often - sorry! I am intending to async-ify a sync JS-implemented idl-defined API (which currently returns an unsigned long), that has a few C++ consumers. I was thinking the simplest solution would be a separate method definition in the idl that took

Re: XPT files shouldn't be added to package-manifest.in any more

2018-04-18 Thread Gijs Kruitbosch
Err, so it seems a side-effect of this (which wasn't very obvious to me when this was posted) is that it's now no longer possible to change a .idl file for a JS component in an artifact build and have it "work". Specifically, I ran into this when changing the return type of an extant idl metho

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

2018-04-12 Thread Gijs Kruitbosch
On 12/04/2018 00:00, da...@openweb.io wrote: On Tuesday, 10 April 2018 00:57:43 UTC-7, Gijs Kruitbosch wrote: On 10/04/2018 03:07, Cameron McCormack wrote: On Tue, Apr 10, 2018, at 11:58 AM, Jeff Gilbert wrote: Do we have a heuristic for when to /not/ include something from HTML in SVG? If

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

2018-04-10 Thread Gijs Kruitbosch
On 10/04/2018 09:03, Gijs Kruitbosch wrote: On 09/04/2018 22:11, longs...@gmail.com wrote: Summary: HTML anchor elements have ping, rel, referrerPolicy, relList, hreflang, type and text properties. SVG anchor elements should support these properties too according to the SVG 2 specification and

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

2018-04-10 Thread Gijs Kruitbosch
On 09/04/2018 22:11, longs...@gmail.com wrote: Summary: HTML anchor elements have ping, rel, referrerPolicy, relList, hreflang, type and text properties. SVG anchor elements should support these properties too according to the SVG 2 specification and https://github.com/w3c/svgwg/issues/315. B

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

2018-04-10 Thread Gijs Kruitbosch
On 10/04/2018 03:07, Cameron McCormack wrote: On Tue, Apr 10, 2018, at 11:58 AM, Jeff Gilbert wrote: Do we have a heuristic for when to /not/ include something from HTML in SVG? If it doesn't make two features which already exist in both HTML and SVG more consistent, then I wouldn't include i

Re: Web-Feed subscription improvements

2018-03-14 Thread Gijs Kruitbosch
On 14/03/2018 14:28, gdk...@gmail.com wrote: On Wednesday, March 14, 2018 at 12:03:19 PM UTC+1, Gijs Kruitbosch wrote: Unfortunately, our web feed implementation is pretty unused. This, tied together with approximately 750-odd bugs would be enough reason for me to drop the component all

Re: Web-Feed subscription improvements

2018-03-14 Thread Gijs Kruitbosch
On 14/03/2018 14:16, Boris Zbarsky wrote: On 3/14/18 7:03 AM, Gijs Kruitbosch wrote: Unfortunately, our web feed implementation is pretty unused. Not least because it's not discoverable, ever since we removed the "there is a feed link on this page" icon, right? The toolb

Re: Web-Feed subscription improvements

2018-03-14 Thread Gijs Kruitbosch
On 13/03/2018 15:26, gdk...@gmail.com wrote: Hello dear Firefox development community! As a fond user of the "subscribe to this page" button I sadly acknowledge to see the deprecation of navigator.registerContentHandler(). I'm not here to grouse about it, but rather inquire about any plans to

Re: PSA: HTML injection in chrome documents is now automatically sanitized

2018-02-09 Thread Gijs Kruitbosch
d it be very difficult to warn when something is sanitized and removed? I wasted a good deal of time trying to figure out why createContextualFragment wasn't working. On Fri, Feb 2, 2018 at 2:10 AM, Gijs Kruitbosch wrote: FWIW, if you're running into this with the usecase "I have a l

Re: PSA: HTML injection in chrome documents is now automatically sanitized

2018-02-02 Thread Gijs Kruitbosch
FWIW, if you're running into this with the usecase "I have a localized string that needs to have links (or other markup) in it" and were formerly using getFormattedString combined with innerHTML, we now have a utility method that can help a little bit. Rather than hand-rolling splitting the str

Re: Please stop using keypress event to handle non-printable keys

2018-01-18 Thread Gijs Kruitbosch
On 18/01/2018 17:36, Mark Banner wrote: On 18/01/2018 16:56, Nicholas Alexander wrote: On Wed, Jan 17, 2018 at 6:34 PM, Masayuki Nakano mailto:masay...@d-toybox.com>> wrote: Hello, everyone. Please stop using keypress event for handling non-printable keys in new code when you writ

Re: Please stop using keypress event to handle non-printable keys

2018-01-18 Thread Gijs Kruitbosch
On 18/01/2018 16:56, Nicholas Alexander wrote: On Wed, Jan 17, 2018 at 6:34 PM, Masayuki Nakano mailto:masay...@d-toybox.com>> wrote: Please stop using keypress event for handling non-printable keys in new code when you write new code and new automated tests. Could someone who is know

Re: Intent to unship: remote jar: protocol pref

2018-01-16 Thread Gijs Kruitbosch
On 17/01/2018 00:01, Daniel Veditz wrote: On Fri, Jan 12, 2018 at 2:12 PM, Gijs Kruitbosch wrote: the most likely group of people to have enabled this (given 0 public reports on breakage so far, as far as I'm aware) are people on ESR or otherwise in enterprise environments ​Or those t

Re: Intent to unship: remote jar: protocol pref

2018-01-12 Thread Gijs Kruitbosch
tell us much about enterprise users, who are probably the most likely people to make use of it. On Fri, Jan 12, 2018 at 09:47:44PM +, Gijs Kruitbosch wrote: Hello, jar: is an internal protocol that enables loading resources from inside a jar/zip file . Firefox is the only browser I'm a

Re: Intent to unship: remote jar: protocol pref

2018-01-12 Thread Gijs Kruitbosch
On 12/01/2018 22:12, Gijs Kruitbosch wrote: As Kris already pointed out in his footnote, the most likely group of people to have enabled this (given 0 public reports on breakage so far, as far as I'm aware) are people on ESR or otherwise in enterprise environments, and our collection rat

Intent to unship: remote jar: protocol pref

2018-01-12 Thread Gijs Kruitbosch
Hello, jar: is an internal protocol that enables loading resources from inside a jar/zip file . Firefox is the only browser I'm aware of that supports it. In Firefox 55, due to security concerns, we put using jar: with remote content (ie loaded over http(s), ftp - anything apart from file://,

Re: performing cross-context instanceof checks

2018-01-11 Thread Gijs Kruitbosch
in a different compartment. On Thu, Jan 11, 2018 at 3:58 PM, Gijs Kruitbosch wrote: On 11/01/2018 05:29, Cameron McCormack wrote: For use in the meantime, I just landed bug 1428531 on inbound, which adds a new chrome-only static method "isInstance" to Web IDL defined interfaces,

Re: performing cross-context instanceof checks

2018-01-11 Thread Gijs Kruitbosch
On 11/01/2018 05:29, Cameron McCormack wrote: For use in the meantime, I just landed bug 1428531 on inbound, which adds a new chrome-only static method "isInstance" to Web IDL defined interfaces, so you can write for example: Document.isInstance(otherWindow.document) So that we don't have

Re: PSA: searchfox now indexes rust

2018-01-08 Thread Gijs Kruitbosch
On 08/01/2018 21:51, Mike Hommey wrote: On Mon, Jan 08, 2018 at 11:15:13AM -0500, Kartikaya Gupta wrote: Just a heads-up, thanks to a bunch of work by Emilio, searchfox.org now indexes rust code as well, so you can do things like jump to function definitions and call sites and whatnot. Please us

Re: Announcing the next Extended Support Release of Firefox - ESR60 with policy engine

2018-01-05 Thread Gijs Kruitbosch
On 04/01/2018 18:06, Tom Ritter wrote: I am curious what Enterprise users are asking for. I'd like to think/hope that a primary concern of enterprise is "Security" (or the separate topic of Privacy); but I'm not certain it is. In particular, I am curious if enterprise users would be interested

Re: Refactoring proposal for the observer service

2018-01-04 Thread Gijs Kruitbosch
On 04/01/2018 23:47, Gijs Kruitbosch wrote: On 04/01/2018 22:49, Gabriele Svelto wrote: On 04/01/18 00:05, Gijs Kruitbosch wrote: Unfortunately, there are quite a lot ( https://searchfox.org/mozilla-central/search?q=obs.addObserver&case=false®exp=false&path= -- sync, the add-ons

Re: Refactoring proposal for the observer service

2018-01-04 Thread Gijs Kruitbosch
On 04/01/2018 22:49, Gabriele Svelto wrote: On 04/01/18 00:05, Gijs Kruitbosch wrote: Unfortunately, there are quite a lot ( https://searchfox.org/mozilla-central/search?q=obs.addObserver&case=false®exp=false&path= -- sync, the add-ons manager, session store, etc. etc.). That'

Re: Refactoring proposal for the observer service

2018-01-04 Thread Gijs Kruitbosch
On 03/01/2018 23:18, Nihanth Subramanya wrote: ++ from me as well, this sounds awesome. Ideally, I would like a solution where especially JS-only observer topics don't require a non-artifact build. A JS forwarder for the "real" observer service may help with that goal, by making the "new" argu

Re: Refactoring proposal for the observer service

2018-01-03 Thread Gijs Kruitbosch
This is really interesting, thanks for looking at this! On 03/01/2018 22:09, Gabriele Svelto wrote: This would have quite a few coding benefits: - It would make it far easier to retire/rename a topic, since ... JS would throw. Why would it? I think it would pass undefined (as the topic wouldn

Re: Password autofilling

2018-01-02 Thread Gijs Kruitbosch
On 01/01/2018 20:08, Jonathan Kingston wrote: We have the ability to turn off the whole login manager within Firefox preferences: "Remember logins and passwords for web sites" but no way to prevent autofill. There's an about:config pref, as [1] points out, which does this. I wonder if there's

Re: All about Prefs

2017-12-18 Thread Gijs Kruitbosch
On 18/12/2017 03:38, Nicholas Nethercote wrote: I am working on a redesign that will fix a lot of the problems. There was a meeting about this in Austin. I hope to implement this in Q1 2018. Yay! If you have changes related to Prefs, please let me (or another Prefs peer) know about it. Thanks

Re: new code to help with cross-process windows/workers (and Clients API)

2017-12-09 Thread Gijs Kruitbosch
On 08/12/2017 20:23, Ben Kelly wrote: Please let me know if you have any question or if you think you have a feature that could integrate with the clients infrastructure. While the initial implementation is limited to Clients API needs, I've tried to design it to support other internal uses. I'

Re: Intent to implement and ship: constructible EventTarget

2017-11-20 Thread Gijs Kruitbosch
On 20/11/2017 17:13, Boris Zbarsky wrote: On 11/20/17 6:28 AM, Gijs Kruitbosch wrote: Devtools' inspector lets you see which DOM nodes have event listeners attached to them. It would be neat if they could provide the same support in the debugger for instances of EventTarget (o

Re: Intent to implement and ship: constructible EventTarget

2017-11-20 Thread Gijs Kruitbosch
On 19/11/2017 03:55, Boris Zbarsky wrote: Devtools bug: I don't think devtools need to do anything special here. Devtools' inspector lets you see which DOM nodes have event listeners attached to them. It would be neat if they could provide the same support in the debugger for instances of Eve

Re: Proposal: Stop using Object.freeze/Object.seal on most of our Javascript Objects

2017-11-20 Thread Gijs Kruitbosch
On 20/11/2017 10:01, Mark Banner wrote: Now that we don't have legacy add-ons outside of our control, I would like to propose that we stop using Object.freeze/Object.seal on most of our objects. I believe that this was originally done to provide some extra security/stability relating to add-o

Re: Intent to unship: mozmm CSS unit.

2017-11-12 Thread Gijs Kruitbosch
On 12/11/2017 16:36, Emilio Cobos Álvarez wrote: On 11/12/2017 05:14 PM, Xidorn Quan wrote: I doubt if there is anything changed since then (except that we still haven't pushed this on csswg), so maybe we still shouldn't remove it. I'm definitely ok with adding something like that if there's a

Re: Intent to unship: mozmm CSS unit.

2017-11-12 Thread Gijs Kruitbosch
On 12/11/2017 16:56, Gijs Kruitbosch wrote: because layout already adjusts some (but not all!) sizes to align to device pixels For reference: https://bugzilla.mozilla.org/show_bug.cgi?id=477157 and friends. ~ Gijs ___ dev-platform mailing list

Re: Pulsebot in #developers

2017-11-06 Thread Gijs Kruitbosch
On 06/11/2017 12:49, Philipp Kewisch wrote: If there is a better place to ask ad-hoc questions about Gecko, I am happy to go there (and we should make sure the channel is promoted in our docs). I think different teams have ended up with different IRC channels, as Kris said. Frontend Firefox st

Re: Pulsebot in #developers

2017-11-06 Thread Gijs Kruitbosch
On 06/11/2017 00:23, zbranie...@mozilla.com wrote: but please, be careful because #developers is also the most natural channel for any newcomers to go to in order to ask entry level questions about our codebase. No, that should be (and is and has been for a considerable amount of time, IME),

Re: Pulsebot in #developers

2017-11-05 Thread Gijs Kruitbosch
I agree with Kris' points. Perhaps there's some kind of middle ground possible? Maybe if pulsebot reported landed patch author + reviewer names (to keep the mentions) on the hour every hour, with a link to pushlogs, or something. And all the merges were coalesced to "autoland and inbound were

Re: Reminder on Try usage and infrastructure resources

2017-09-14 Thread Gijs Kruitbosch
This only works once you have a run that failed the test you're interested in, right? There's no way to tell the test-centric UI "find me the chunk for test with name X". ~ Gijs On 14/09/2017 16:55, Cameron Dawson wrote: Marco— I don’t know of a way to do exactly that yet. But that is in th

Re: Intent to unship: :-moz-system-metric pseudo-class and media queries in content pages.

2017-09-02 Thread Gijs Kruitbosch
On 01/09/2017 20:06, Emilio Cobos Álvarez wrote: Hi dev-platform@, I'd like to unship access to the :-moz-system-metric pseudo-class, and the system metric media queries, from content pages. I just filed for that. They're not in any spec, a

Re: Intent to ship version 4 of the Safe Browsing protocol

2017-08-16 Thread Gijs Kruitbosch
On 16/08/2017 11:11, Enrico Weigelt, metux IT consult wrote: On 16.08.2017 01:46, Francois Marier wrote: After a year's worth of development, bug fixes, and integration testing, we are now ready to enable the latest version [1] of the Safe Browsing API in Firefox 56, two releases ahead of schedu

Re: Phabricator and confidential reviews

2017-08-09 Thread Gijs Kruitbosch
On 09/08/2017 01:30, Mark Côté wrote: If you have any thoughts on this, please reply. I'll answer any questions and summarize the feedback with a decision in a few days. Note that we can, of course, try a simple approach to start, and add in more complex functionality after an evaluation per

Super-review - proposal to remove given lack of super-review-specific usage

2017-07-28 Thread Gijs Kruitbosch
(x-post platform + governance + bmo, please followup-to governance) Today I was asked for super-review. Although I've been around a while, I am not a super-reviewer. I can't remember the last time before today that I was asked (it's quite possibly: never). The person who asked me was mostly ju

Re: Linting for common causes of oranges in mochitests (need ideas)

2017-07-07 Thread Gijs Kruitbosch
IME panels/popups/context-menus are flaky generally, and especially on Linux. I don't know how to meaningfully lint for this. The other thing is various incantations that try to do variations on the "load x in a tab" theme. It turns out that it's not trivial to not race with an expectant page

Re: Switching to per-channel profiles

2017-06-26 Thread Gijs Kruitbosch
On 26/06/2017 14:03, Ben Hearsum wrote: On 2017-06-23 06:43 PM, Dave Townsend wrote: TL;DR: We should make each Firefox channel use its own profile data allowing you to run multiple channels at the same time. Running multiple channels of Firefox is currently harder than it needs to be. You can'

Re: Intent to unship: -moz-placeholder pseudo-element and pseudo-class

2017-05-24 Thread Gijs Kruitbosch
On 24/05/2017 03:13, Ku(顧思捷)CJ wrote: I intend to remove "-moz-placeholder" pseudo-element and pseudo-class in bug 1300896. Which will ship in which release? 55 or 56? Esp. asking given the upcoming feature freeze for 55. ~ Gijs ___ dev-platform ma

Re: unowned module: Firefox::New Tab Page, help me find an owner

2017-03-22 Thread Gijs Kruitbosch
On 22/03/2017 13:22, jma...@mozilla.com wrote: I have not been able to find an owner for the Firefox::New Tab Page bugzilla component (bug 1346908). There are 35 tests in the tree and without anyone to assume responsibility for them when they are intermittent (bug 1338848), I plan to delete t

Re: Startup JS debugging (sometimes) possible via Browser Toolbox

2017-03-13 Thread Gijs Kruitbosch
On 13/03/2017 16:48, J. Ryan Stinnett wrote: On Thu, Mar 9, 2017 at 2:18 AM, Panos Astithas > wrote: You almost completely resolved the 4-year-old bug 814298, yay! I now wonder if this makes it easier to improve mochitest debugging per bug 929535. Thank

Re: Please use Add*VarCache and not Get* when reading pref values in any even possibly warm code paths

2017-02-22 Thread Gijs Kruitbosch
ached pref name is a string prefix of another pref name. :-) ~ Gijs On 22/02/2017 13:23, smaug wrote: Huh, that is a horrible bug. On 02/22/2017 01:42 PM, Gijs Kruitbosch wrote: Related note: add*varcache uses a pref observer behind the scenes. Pref observers always prefix-match, and the

Re: Please use Add*VarCache and not Get* when reading pref values in any even possibly warm code paths

2017-02-22 Thread Gijs Kruitbosch
Related note: add*varcache uses a pref observer behind the scenes. Pref observers always prefix-match, and the *varcache implementation doesn't bother re-checking whether the pref for which it gets a notification matches the one you requested a cache for. So if you have prefs "blah.foo" and "bl

Re: Intent to unship: xml:base attribute

2017-02-16 Thread Gijs Kruitbosch
On 16/02/2017 06:51, Xidorn Quan wrote: Tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=903372 Summary: * It has been removed from the spec years ago. * No other browser supports it. * We pay performance penalty for it. * It makes things trickier for stylo to handle URL values. The t

Re: Please don't add JS implemented telemetry probes to hot code paths. (eom)

2017-02-12 Thread Gijs Kruitbosch
Can you clarify what you mean by "JS implemented" here? I was under the impression the telemetry implementation was in C++... Separately, was there a concrete reason for you posting this warning? I don't wish to shame people, but a concrete example of a 'wrong' pattern might help in making it

Re: Introducing LocaleService and mozILocaleService

2017-02-07 Thread Gijs Kruitbosch
On 07/02/2017 19:38, zbranie...@mozilla.com wrote: JS [2]: ``` const localeService = Components.classes["@mozilla.org/intl/localeservice;1"] .getService(Components.interfaces.mozILocaleService); const appLocales = localeService.getAppLocales(); Please can you add an alias into Services.jsm

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread Gijs Kruitbosch
On 03/02/2017 15:11, Ryan VanderMeulen wrote: A friendly reminder that per the MDN commit rules, the use of "No bug" in the commit message is to be used sparingly - in general for minor things like whitespace changes/comment fixes/etc where traceability isn't as important. https://developer.mo

Re: Deprecating XUL in new UI

2017-01-17 Thread Gijs Kruitbosch
On 17/01/2017 17:55, Bobby Holley wrote: On Tue, Jan 17, 2017 at 8:56 AM, Boris Zbarsky wrote: On 1/16/17 4:28 PM, Matthew N. wrote: Does it just work from XHTML documents? Yes, as far as I know. Is our implementation of Web Components ready to replace it and riding the trains? No.

Re: Intent to implement and ship: CSS caret-color property

2016-12-24 Thread Gijs Kruitbosch
On 24/12/2016 13:33, Xidorn Quan wrote: On Sat, Dec 24, 2016, at 11:59 PM, Gijs Kruitbosch wrote: On 24/12/2016 01:24, Ehsan Akhgari wrote: On 2016-12-23 8:13 PM, Xidorn Quan wrote: I don't think that would be a problem, because the number of people who use navigation caret is rather li

Re: Intent to implement and ship: CSS caret-color property

2016-12-24 Thread Gijs Kruitbosch
On 24/12/2016 01:24, Ehsan Akhgari wrote: On 2016-12-23 8:13 PM, Xidorn Quan wrote: I don't think that would be a problem, because the number of people who use navigation caret is rather limited, and thus I don't think websites would likely hide the caret for normal text intentionally to annoy p

Re: Firefox Behaving Improperly to Standard

2016-12-20 Thread Gijs Kruitbosch
On 20/12/2016 16:12, Gijs Kruitbosch wrote: On 20/12/2016 02:24, Mark Legate wrote: I was directed here from a firefox bug. For context, can you provide a link to the bug? Mark replied: https://bugzilla.mozilla.org/show_bug.cgi?id=1322952 ~ Gijs

Re: Firefox Behaving Improperly to Standard

2016-12-20 Thread Gijs Kruitbosch
On 20/12/2016 02:24, Mark Legate wrote: I was directed here from a firefox bug. For context, can you provide a link to the bug? ~ Gijs ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Removing navigator.buildID?

2016-11-01 Thread Gijs Kruitbosch
The buildID changing rapidly provides a bigger, rather than a smaller, fingerprinting surface. ~ Gijs On 01/11/2016 08:09, Chris Pearce wrote: It's not just Netflix that the media playback team has used navigator.buildID in order to validate fixes; we've used it with other large video sites to

Re: Removing the Battery Status API?

2016-10-26 Thread Gijs Kruitbosch
On 26/10/2016 08:54, Anne van Kesteren wrote: On Wed, Oct 26, 2016 at 9:30 AM, Chris Peterson wrote: (Could that counter be inadvertently triggered by web content that simply enumerates the navigator object's properties without actually calling navigator.getBattery()?) That seems unlikely giv

Re: So, what's the point of Cu.import, these days?

2016-09-27 Thread Gijs Kruitbosch
On 27/09/2016 10:28, David Teller wrote: On 26/09/16 19:50, zbranie...@mozilla.com wrote: So, it seems to me that we're talking about two aspects of module loading: 1) Singleton vs. per-instance Cu.import allows us to share a single object between all the code that references it. ES6 modu

Re: Why I don't like DXR

2016-09-26 Thread Gijs Kruitbosch
On 26/09/2016 14:14, Honza Bambas wrote: Today I tried to search for an identifier on DXR. Something that was so easy with MXR... I wanted to find usage of a member called "io_pending". Typing that string to the DXR search field gives me a number of results that are definitely not what I'm loo

Re: Converting assertions into release assertions

2016-09-23 Thread Gijs Kruitbosch
On 23/09/2016 11:20, Ted Mielczarek wrote: On Fri, Sep 23, 2016, at 05:58 AM, Panos Astithas wrote: I used to do that in the past, but nowadays artifact builds have changed the cost-benefit trade-off so very few people bother AFAIK, when not touching C++ code. If we could get artifact builds to

Re: Converting assertions into release assertions

2016-09-22 Thread Gijs Kruitbosch
On 22/09/2016 05:28, Nicholas Nethercote wrote: Greetings, Assertions, such as MOZ_ASSERT, are great. But they only run in debug builds. Release assertions, such as MOZ_RELEASE_ASSERT, run in all builds. I want to highlight a nice case where converting a normal assertion into a release asserti

Re: PSA: tpaint test is testing more than just window opening and is regressing with each run

2016-09-12 Thread Gijs Kruitbosch
On 09/09/2016 13:29, zbranie...@mozilla.com wrote: The test at the moment is both noisy, and has a steady regression with each run which makes it hard to feel confident about it and also makes it impossible to just increase the number of runs in order to increase significance and reliability o

Re: What if you could reinvent Firefox theming?

2016-09-09 Thread Gijs Kruitbosch
On 08/09/2016 23:41, Justin Dolske wrote: On Thu, Sep 8, 2016 at 8:41 AM, Jared Wein wrote: What capabilities would you like themes to have? [...] Also at 3% of responses were requests from users who require larger icons and improved readability of the browser's user interface for improved acce

Re: Reorganization of Firefox-UI tests in mozilla-central

2016-09-02 Thread Gijs Kruitbosch
On 02/09/2016 13:49, Henrik Skupin wrote: Gijs Kruitbosch wrote on 09/02/2016 11:37 AM: We should be doing the same for firefox-ui tests. Not just to avoid duplication of files in archives, but because otherwise, if we want to add new tests somewhere else, we both have to add the manifests to

Re: Reorganization of Firefox-UI tests in mozilla-central

2016-09-02 Thread Gijs Kruitbosch
On 02/09/2016 10:54, James Graham wrote: On 02/09/16 10:37, Gijs Kruitbosch wrote: On 02/09/2016 08:08, Henrik Skupin wrote: The problematic piece here will be the package-tests step which currently picks complete subfolders. It would mean if we mix-up tests for firefox-ui-tests and eg

Re: Reorganization of Firefox-UI tests in mozilla-central

2016-09-02 Thread Gijs Kruitbosch
On 02/09/2016 08:08, Henrik Skupin wrote: Gijs Kruitbosch wrote on 09/01/2016 06:24 PM: As I did over IRC, I would like to strongly object to the continued use of per-test-type subfolders in our test directories. You can already use a specific mach command per test type, and the tests are

  1   2   3   >