tps://reviews.apache.org/r/17393/
> ---
>
> (Updated Jan. 27, 2014, 3:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> On Jan. 27, 2014, 4:54 p.m., Sumit Mohanty wrote:
> > Can we add a unit test that verifies that upgradestack is called when
> > "ambari-server upgrade" is called?
> >
> > This is not critical for this specific JIRA but if upgradestack encounters
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32869
---
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 27, 2014, 6:56 p.m
/configuration/hdfs-site.xml
7e8bfba
ambari-web/app/data/HDP2/site_properties.js e52c6a0
Diff: https://reviews.apache.org/r/17425/diff/
Testing
---
Thanks,
Sumit Mohanty
.
Thanks,
Sumit Mohanty
/main/python/UpgradeHelper_HDP2.py
You can add only one node for this script only and rest all the scripts can
come in as a folder.
- Sumit Mohanty
On Jan. 27, 2014, 11:17 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically
---
Manually verified by performing upgrade.
Thanks,
Sumit Mohanty
/AmbariManagementControllerTest.java
f36471f
Diff: https://reviews.apache.org/r/17465/diff/
Testing
---
All but one unit tests passed for ambari-server - one unit test failure is a
known issue.
Thanks,
Sumit Mohanty
.
- Sumit Mohanty
On Jan. 29, 2014, 4:30 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17505/#review33133
---
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 29, 2014, 5:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17463/#review33341
---
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 30, 2014, 7:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17657/#review33441
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 3, 2014, 12:41 p.m
/17669/diff/
Testing
---
All python resource based unit tests and AmbariManagementControllerTest tests
passed.
Thanks,
Sumit Mohanty
associated with the
stack definition to fix this? If yes we can add a dependency that NAMENODE
start depends on ZOOKEEPER start.
- Sumit Mohanty
On Feb. 3, 2014, 6:49 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e
batch API. We can note this issue somewhere.
- Sumit Mohanty
On Feb. 4, 2014, 9:35 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17725/#review33676
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 4, 2014, 9:35 p.m
orrect? If yes
should we allow that?
- Sumit Mohanty
On Feb. 3, 2014, 6:49 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On Feb. 5, 2014, 7:18 p.m., Sumit Mohanty wrote:
> > Got it. Thanks for the explanation.
> >
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
> > * import org.apache.ambari.server.*; -- can you expand it back
For every host component (e.g. NAMENODE on a host) there is a flag
""stale_configs" : false," that indicates if the applied config for that
component is not of the same version as the applied config at the
cluster/host level.
E.g.
http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6402.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17770/#review33795
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 6, 2014, 9:23 a.m
the savanna code iterates the 'tag' associated with
'global' and 'core-site' configuration during the add host sequence
(from 'v1' to 'v2'). Would that explain this?
On Feb 6, 2014, at 10:53 AM, Sumit Mohanty wrote:
> For every hos
. passive
state? Hypothetically, agent is down on Nagios server and missed some
modification custom actions. Should we always send the passive state summary
upon registration?
"List ok = new ArrayList();" - why
the variable is named ok?
- Sumit Mohanty
On Feb. 8, 2014, 2:32 p.m.,
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> ---
>
> (Updated Feb. 8, 2014, 2:32 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit
45s
FAILED (failures=1)
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Agent .. FAILURE [14.867s]
Thanks,
Sumit Mohanty
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17962/#review34235
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 11, 2014, 10:14 p.m
SUCCESS [7.048s]
[INFO] Ambari Views .. SUCCESS [2.193s]
[INFO] Ambari Server . FAILURE [14:43.027s]
Thanks,
Sumit Mohanty
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18275/#review34886
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 19, 2014, 5:38 p.m
?
- Sumit Mohanty
On Feb. 19, 2014, 11:09 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/ambari/server/scheduler/ExecutionScheduleManager.java
Do we need the "import org.quartz.JobDataMap;"?
Why does addTaskCountToProperties() need explicit throws ?
- Sumit Mohanty
On Feb. 20, 2014, 5:02 a.m., Sid Wagle wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18315/#review35023
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 20, 2014, 6:19 p.m
> On Feb. 19, 2014, 11:41 p.m., Sumit Mohanty wrote:
> > Can copyFromLocal be part of the resource management library?
>
> Sid Wagle wrote:
> Good point. Currently it seems the python library does not deal with any
> explicit hadoop commands. Maybe Andrew / Dmitry
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18292/#review35039
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 20, 2014, 12:02 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18290/#review35156
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 19, 2014, 8:44 p.m
.. SUCCESS [1.424s]
[INFO] Ambari Server . SUCCESS [2:30.954s]
[INFO] Ambari Agent .. SUCCESS [9.297s]
[INFO] Ambari Client . SUCCESS [0.526s]
Thanks,
Sumit Mohanty
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18483/#review35474
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 25, 2014, 9:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18610/#review35763
---
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 28, 2014, 5:33 a.m
> On Feb. 28, 2014, 5:39 a.m., Sumit Mohanty wrote:
> > Ship It!
Minor nit:
Change "Report arrived after command is no longer running ..." to "Received
report for a command that is no longer active ...". Also, do we log the command
id
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18671/#review35934
---
Ship it!
Ship It!
- Sumit Mohanty
On March 2, 2014, 9:06 p.m
e code.
- Sumit Mohanty
On March 2, 2014, 9:06 p.m., Mahadev Konar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18693/#review35977
---
Ship it!
Ship It!
- Sumit Mohanty
On March 3, 2014, 5:22 p.m
r.java
<https://reviews.apache.org/r/18708/#comment67201>
Could you talk to Tom about this? While this is powerful - editing
predicates on the fly - I am not sure if we should allow it in a formal way.
- Sumit Mohanty
On March 4, 2014, 4:57 p.m., Dmitro Lisni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18903/#review36693
---
Ship it!
Ship It!
- Sumit Mohanty
On March 7, 2014, 1:38 p.m
/AmbariCustomCommandExecutionHelper.java
<https://reviews.apache.org/r/19002/#comment67934>
If one issues RESTART directly on one hostcomponent it will not work. But
we allow Start and Stop.
- Sumit Mohanty
On March 11, 2014, 1:47 a.m., Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/#review36816
---
Ship it!
Ship It!
- Sumit Mohanty
On March 11, 2014, 5:51 p.m
hosts.
- Sumit Mohanty
On March 14, 2014, 4:26 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
;] be None?
- Sumit Mohanty
On March 14, 2014, 2:56 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On March 14, 2014, 4:34 p.m., Sumit Mohanty wrote:
> > Dmytro Sen, why would the command['configurationTags'] be None?
>
> Dmytro Sen wrote:
> Don't know. Actually, before this patch configurationTags as well were
> copied from config.json to DATAN
dating
HDFS_CLIENT only when DATANODE/NAMENODE/SNAMENODE.etc. are updated.
- Sumit Mohanty
On March 14, 2014, 2:56 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/TestActualConfigHandler.py
<https://reviews.apache.org/r/19185/#comment68646>
Should we assert that HBASE_CLIENT is not tag2?
- Sumit Mohanty
On March 14, 2014, 2:56 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail.
/BootStrapTest.java
<https://reviews.apache.org/r/19300/#comment68984>
Even 2000*100 might be too long for test. Do we need to wait that long
before failing?
- Sumit Mohanty
On March 17, 2014, 4:39 p.m., Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19300/#review37446
---
Ship it!
Ship It!
- Sumit Mohanty
On March 17, 2014, 4:39 p.m
/ActionScheduler.java
<https://reviews.apache.org/r/19067/#comment68987>
We should also log the host name.
- Sumit Mohanty
On March 17, 2014, 5:08 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19067/#review37451
---
Ship it!
Ship It!
- Sumit Mohanty
On March 17, 2014, 5:08 p.m
/internal/HostComponentResourceProvider.java
<https://reviews.apache.org/r/18708/#comment68991>
Do we also need a change where if predicate is state=INSTALL_FAILED then we
will filter based on sch.getState() value and not sch.getDesiredState()?
- Sumit Mohanty
On March 13, 2014, 3:
> On March 17, 2014, 8:18 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java,
> > line 308
> > <https://reviews.apache.org/r/18708/diff/3/?file=518613#file518613line308>
> >
/TestActualConfigHandler.py
<https://reviews.apache.org/r/19185/#comment68993>
Can you add an assert that HBASE_CLIENT 's config did not change to "tag2"?
- Sumit Mohanty
On March 17, 2014, 3:21 p.m., Dmytro Sen wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19185/#review37460
---
Ship it!
Ship It!
- Sumit Mohanty
On March 17, 2014, 3:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19300/#review37466
---
Ship it!
Ship It!
- Sumit Mohanty
On March 17, 2014, 8:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19337/#review37520
---
Ship it!
Ship It!
- Sumit Mohanty
On March 18, 2014, 1:02 a.m
/UpgradeCatalog150.java
<https://reviews.apache.org/r/19369/#comment69372>
This should be serviceComponentDesiredStateEntityJT's desired state.
- Sumit Mohanty
On March 19, 2014, 3:42 p.m., Andrew Onischuk wrote:
>
> ---
tps://reviews.apache.org/r/19369/#comment69373>
Yeah, this works too :-)
- Sumit Mohanty
On March 19, 2014, 3:42 p.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19369/#review37730
---
Ship it!
Ship It!
- Sumit Mohanty
On March 19, 2014, 3:42 p.m
- will this mapping query also skip adding clusterconfigmapping entries?
- Sumit Mohanty
On March 19, 2014, 8:14 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
t have deployed
hbase/oozie and will get those configs as well.
- Sumit Mohanty
On March 19, 2014, 8:14 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On March 19, 2014, 9:05 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java,
> > line 593
> > <https://reviews.apache.org/r/19420/diff/1/?file=528404#file528404line593>
> >
> > Will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19418/#review37798
---
Ship it!
Ship It!
- Sumit Mohanty
On March 19, 2014, 8:14 p.m
/DBAccessorImpl.java
<https://reviews.apache.org/r/19442/#comment69600>
Why logging twice?
- Sumit Mohanty
On March 20, 2014, 12:54 a.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19442/#review37844
---
Ship it!
Ship It!
- Sumit Mohanty
On March 20, 2014, 12:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19479/#review37928
---
Ship it!
Ship It!
- Sumit Mohanty
On March 20, 2014, 5:56 p.m
In fact the python support makes it much much easier to to add custom
services and custom scripts. So I will encourage you to try that and
provide feedback.
Python support is at par with puppet support and so its mature..
On Thu, Mar 20, 2014 at 12:42 PM, Erin Boyd wrote:
> It's my understandi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19529/#review38120
---
Ship it!
Ship It!
- Sumit Mohanty
On March 21, 2014, 2:52 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19548/#review38190
---
Ship it!
Ship It!
- Sumit Mohanty
On March 21, 2014, 8:29 p.m
/package/scripts/params.py
<https://reviews.apache.org/r/19535/#comment70189>
If we are adding support for default then we should do that for YARN, HDFS,
and MAPREDUCE - all three.
- Sumit Mohanty
On March 21, 2014, 4:48 p.m., Andrew Onischuk
not very clear about
what will happen when custom jdk is used.
- Sumit Mohanty
On March 24, 2014, 5:13 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19654/#review38561
---
Ship it!
Ship It!
- Sumit Mohanty
On March 26, 2014, 12:02 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19698/#review38663
---
Ship it!
Ship It!
- Sumit Mohanty
On March 26, 2014, 9:41 p.m
--
Total run:521
Total errors:0
Total failures:0
Thanks,
Sumit Mohanty
/
Testing
---
OK
--
Total run:521
Total errors:0
Total failures:0
Thanks,
Sumit Mohanty
/20236/diff/
Testing
---
OK
--
Total run:521
Total errors:0
Total failures:0
Thanks,
Sumit Mohanty
d7de77f
Diff: https://reviews.apache.org/r/20236/diff/
Testing
---
OK
--
Total run:521
Total errors:0
Total failures:0
Thanks,
Sumit Mohanty
ver/src/main/resources/scripts/cluster_blueprint.py
<https://reviews.apache.org/r/20244/#comment73027>
We would need to accept host/port user/password as parameters for silent
option.
- Sumit Mohanty
On April 11, 2014, 1:09 a.m., Sid Wagle wrote:
>
>
treating Nagios as special makes sense. The
configuration version change under the cover may be risky as it does not
confirm to the pattern of how we handle config. Let's me comment on the JIRA.
- Sumit Mohanty
On April 11, 2014, 4:30
tps://reviews.apache.org/r/20267/#comment73082>
Lets add a new test as users can upgrade to 2.0 or 2.1 - one test will add
ATS and the other will not.
- Sumit Mohanty
On April 11, 2014, 6:04 p.m., Andrew Onischuk wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20267/#review40175
---
Ship it!
Ship It!
- Sumit Mohanty
On April 11, 2014, 6:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20417/#review40604
---
Ship it!
Ship It!
- Sumit Mohanty
On April 16, 2014, 5:21 p.m
+1 for the release.
On Thu, Apr 17, 2014 at 10:54 AM, Yusaku Sako wrote:
> +1 for the release.
> Verified checksums, ran rat check, was able to build successfully.
>
> Yusaku
>
> On Wed, Apr 16, 2014 at 8:47 PM, Tom Beerbower
> wrote:
> > All,
> >
> > I have created an ambari-1.5.1 release cand
<https://reviews.apache.org/r/20263/#comment73902>
Can you make the changes to the upgrade code as well?
- Sumit Mohanty
On April 18, 2014, 3:18 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail.
/HeartBeatHandler.java
<https://reviews.apache.org/r/20263/#comment73903>
Can we modify an existing HB handler test to assert that restart required
flag is set?
- Sumit Mohanty
On April 18, 2014, 3:18 p.m., Dmytro Sen wrote:
>
> --
---
Thanks,
Sumit Mohanty
/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/20263/#comment74378>
Is this for gmonds?
- Sumit Mohanty
On April 18, 2014, 5:49 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20263/#review41020
---
Ship it!
Ship It!
- Sumit Mohanty
On April 18, 2014, 5:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/#review41209
---
Ship it!
Ship It!
- Sumit Mohanty
On April 23, 2014, 8:36 p.m
roller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/20704/#comment74897>
Do we need this line?
- Sumit Mohanty
On April 25, 2014, 1:49 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20714/#review41482
---
Ship it!
Ship It!
- Sumit Mohanty
On April 25, 2014, 3:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20717/#review41487
---
Ship it!
Ship It!
- Sumit Mohanty
On April 25, 2014, 5:24 p.m
1.3 and 2.0 repo urls.
Without that 1.3 stack will not deploy.
- Sumit Mohanty
On April 25, 2014, 8:53 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
you want to commit this
before RE updates the repo url for 1.3.7.
Otherwise, you can obtain the dev repo url (if it exists) from them and add
that to repoinfo.xml. Then we can open a JIRA to replace that closer to the end
of 1.6.0.
- Sumit Mohanty
On April 25, 2014, 8:53 p.m., Nate Cole wrote
Should it not start working on snmp now? Do we need to skip suse?
- Sumit Mohanty
On April 28, 2014, 8:18 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Hi Gordon,
its read from the ambari-server config property file (property java.home)
and is now automatically being passed in as a hostLevelParams when the
commands are sent to the agent.
E.g. some stack services access it as
config['hostLevelParams']['java_home'].
How was the property being use
<https://reviews.apache.org/r/20858/#comment75316>
We could take umask to check as an input and have it default to 0022. Lets
open a separate task as an improvement that we can commit later.
- Sumit Mohanty
On April 29, 2014, 5:37 p.m., Vitalyi Brodetskyi
1 - 100 of 1734 matches
Mail list logo