Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-02 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61274/#review182029 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 2, 2017, 8:48

Review Request 61370: ATLAS-2014: populate createdBy, updatedBy fields on type create and update

2017-08-01 Thread Madhan Neethiraj
/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java e2a80108 Diff: https://reviews.apache.org/r/61370/diff/1/ Testing --- Updated the unit tests and verified that fields createdBy and updatedBy are populated correctly. Thanks, Madhan Neethiraj

Re: 0.8.1 release of Apache Atlas

2017-08-02 Thread Madhan Neethiraj
+1 for 0.8.1 release. This will be the first Atlas release after graduation. The number of enhancements and fixes look impressive. Sarath – thanks for taking initiative to release 0.8.1. release. Thanks, Madhan On 8/2/17, 5:36 PM, "Sarath Subramanian" wrote: Atlas

Re: Review Request 61389: ATLAS-2017: Import API: Request Parameter Made Optional

2017-08-02 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61389/#review182065 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 2, 2017, 10:26

[ANNOUNCE] New Committer: Mandy Chessell

2017-08-15 Thread Madhan Neethiraj
Atlas community, Apache Atlas PMC has asked Mandy Chessell to become a committer and we are pleased to announce that she has accepted. Welcome Mandy, great to have you on board. On behalf of Apache Atlas PMC, Madhan

[ANNOUNCE] New Committer: Ashutosh Mestry

2017-08-13 Thread Madhan Neethiraj
Atlas community, Apache Atlas PMC has asked Ashutosh Mestry to become a committer and we are pleased to announce that he has accepted. Welcome Ashutosh, great to have you on board. On behalf of Apache Atlas PMC, Madhan

[ANNOUNCE] New Committer: David Radley

2017-08-13 Thread Madhan Neethiraj
Atlas community, Apache Atlas PMC has asked David Radley to become a committer and we are pleased to announce that he has accepted. Welcome David, great to have you on board. On behalf of Apache Atlas PMC, Madhan

Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-10 Thread Madhan Neethiraj
, 1359 (patched) <https://reviews.apache.org/r/61589/#comment258641> Shouldn't this also handle AtlasRelationshipEdgeDirection.BOTH? - Madhan Neethiraj On Aug. 10, 2017, 11:43 p.m., Sarath Subramanian wrote: > > --- > Thi

Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

2017-08-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/#review182810 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 11, 2017, 4:25

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

2017-08-16 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61667/#review183093 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 17, 2017, 1:19

Review Request 61708: ATLAS-2052: updated packaing to exclude junit jar

2017-08-16 Thread Madhan Neethiraj
, Madhan Neethiraj

Re: Review Request 60792: ATLAS-1945 : UI : Moving all plugins to fix release version

2017-07-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60792/#review180294 --- Ship it! Ship It! - Madhan Neethiraj On July 12, 2017, 6:50

Re: Review Request 60851: [ATLAS-1949]: Fix coverity scan issues and IT failure due to ATLAS-1907

2017-07-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60851/#review180463 --- Ship it! Ship It! - Madhan Neethiraj On July 13, 2017, 8:12

Re: Review Request 60722: Fix for: Export of hive_table with fetchType "connected" fails

2017-07-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60722/#review180695 --- Ship it! Ship It! - Madhan Neethiraj On July 10, 2017, 3:59

Re: Testing API...

2017-07-17 Thread Madhan Neethiraj
“/api/v2/search” is not the correct URI. Can you try with “api/atlas/v2/search”? Madhan On 7/17/17, 11:51 AM, "Jean Georges Perrin" wrote: Hi, I installed and run Atlas on my Mac. Everything seems to be working fine in the UI, but I cannot get the API to work...

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-07-11 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60578/#review180183 --- Ship it! Ship It! - Madhan Neethiraj On July 11, 2017, 7:40

Re: Review Request 60722: Fix for: Export of hive_table with fetchType "connected" fails

2017-07-09 Thread Madhan Neethiraj
eplace context.guidsInSink.contains(guid) with context.sink.hasEntity(guid) - Madhan Neethiraj On July 8, 2017, 12:12 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Draft Board Report for Apache Atlas: July-2017

2017-07-10 Thread Madhan Neethiraj
that, this looks good to me. +1 Thanks hemanth ____ From: Madhan Neethiraj <mad...@apache.org> Sent: Monday, July 10, 2017 8:21 PM To: dev@atlas.apache.org Subject: Draft Board Report for Apache Atlas: J

Re: Assign as contributor

2017-07-07 Thread Madhan Neethiraj
Chandana, Done. Welcome to Apache Atlas community. Madhan On 7/7/17, 6:18 PM, "Chandana Mirashi" wrote: Hi, I would like to contribute to Atlas. Can someone please add me so that I can assign myself JIRA to work on? Regards, Chandana Mirashi

Re: Review Request 60857: ATLAS-1950: Import API: Improvement: Specify Supertypes in Import Transforms

2017-07-14 Thread Madhan Neethiraj
putAll(attribtueTransformMap). - Madhan Neethiraj On July 14, 2017, 6 p.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60852: ATLAS-1947: Improvements for ATLAS-1880 and some change to AtlasSearchResult

2017-07-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60852/#review180602 --- Ship it! Ship It! - Madhan Neethiraj On July 14, 2017, 10

Re: Review Request 60863: ATLAS-1952 : UI : Render Search table using referredEntity.

2017-07-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60863/#review180604 --- Ship it! Ship It! - Madhan Neethiraj On July 14, 2017, 12

Review Request 60940: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering

2017-07-18 Thread Madhan Neethiraj
/SearchContext.java 55a07f3d repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 14818094 Diff: https://reviews.apache.org/r/60940/diff/1/ Testing --- Validated that the search completes much quicker with this update. Thanks, Madhan Neethiraj

Re: Review Request 60922: ATLAS-1925: Misc bugfixes for ATLAS-1880

2017-07-17 Thread Madhan Neethiraj
/apache/atlas/discovery/EntityDiscoveryService.java Lines 479 (patched) <https://reviews.apache.org/r/60922/#comment255987> keep this inside a finally {} block, to ensure that search-context gets removed when search method exits. - Madhan Neethiraj On July 17, 2017, 9:37 p.m., Apoor

Re: Review Request 60705: ATLAS-1927 : UI - changing the look and feel of attribute in details page.

2017-07-18 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60705/#review180812 --- Ship it! Ship It! - Madhan Neethiraj On July 18, 2017, 11

Re: JIRA contributor permission

2017-07-10 Thread Madhan Neethiraj
Robert, Done. Welcome to Apache Atlas community. Madhan On 7/10/17, 3:09 AM, "Robert Kern" wrote: Hi, I would like to contribute to Atlas. Could a PMC member with admin access please add me as a contributor in JIRA so that I can assign items to myself? My

Re: JIRA contributor permission

2017-07-10 Thread Madhan Neethiraj
Peter, Done. Welcome to Apache Atlas community. Madhan On 7/10/17, 4:23 AM, "Peter Gergo Barna" wrote: Hi All, I would like to contribute to Atlas, currently I am working on this issue: https://issues.apache.org/jira/browse/ATLAS-1879. I would like to be

Re: Review Request 60742: ATLAS-1938 : UI - Search using entity and trait attributes - Refresh Button fires the search query (Basic/DSL) again.

2017-07-10 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60742/#review180030 --- Ship it! Ship It! - Madhan Neethiraj On July 10, 2017, 11

Draft Board Report for Apache Atlas: July-2017

2017-07-10 Thread Madhan Neethiraj
Atlas team, Please review the draft board report below and send your feedback/comments, if any. The report is due on Wednesday this week, July-12. Thanks, Madhan ## Description:   Apache Atlas is a scalable and extensible set of core foundational governance   services that

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-20 Thread Madhan Neethiraj
ting --- - validated that the fix addressed the error cases listed above Thanks, Madhan Neethiraj

Re: Review Request 60940: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering

2017-07-18 Thread Madhan Neethiraj
/ Testing --- Validated that the search completes much quicker with this update. Thanks, Madhan Neethiraj

Re: Review Request 60971: ATLAS-1914 : UI - Search using entity and trait attributes : "Clear" button doesn't clear the filter applied to a type

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60971/#review180948 --- Ship it! Ship It! - Madhan Neethiraj On July 19, 2017, 2:22

Re: Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread Madhan Neethiraj
/v1/AtlasRelationshipDefStoreV1.java Lines 484 (patched) <https://reviews.apache.org/r/60970/#comment256292> @David - makes sense. I will commit the patch shortly. Thanks! - Madhan Neethiraj On July 19, 2017, 2:26 p.m., David Radley

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-18 Thread Madhan Neethiraj
ansmit when large number of entities are referenced (for example hive_db.tables referring to 1000s of tables). Storing AtlasObjectId (or List) is enough. Same comment for line #474 below. - Madhan Neethiraj On July 18, 2017, 6:25 a.m., Sarath Subramanian

Re: Review Request 61002: ATLAS-1968: Import File Signature Change

2017-07-20 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61002/#review181062 --- Ship it! Ship It! - Madhan Neethiraj On July 20, 2017, 5:22

Re: Review Request 60954: ATLAS-1948: Addressed Case Where Export Order List Did Not Add Process Guids At the End In All Cases

2017-07-19 Thread Madhan Neethiraj
gt; - "ATLAS-400-00-021" ==> AtlasErrorCode.INVALID_OBJECT_ID.getErrorCode() - { } - Madhan Neethiraj On July 19, 2017, 4:56 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 61007: [ATLAS-1979]: Update storm model relationship category and fix for UT and Coverity scan issues

2017-07-20 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61007/#review181089 --- Ship it! Ship It! - Madhan Neethiraj On July 20, 2017, 9:16

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-20 Thread Madhan Neethiraj
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review181094 ------- On July 21, 2017, 1:39 a.m., Madhan Neethiraj wrote: > > --

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-20 Thread Madhan Neethiraj
ache/atlas/discovery/SearchProcessor.java 7950127d Diff: https://reviews.apache.org/r/60980/diff/4/ Changes: https://reviews.apache.org/r/60980/diff/3-4/ Testing --- - validated that the fix addressed the error cases listed above Thanks, Madhan Neethiraj

Re: GIT repo move

2017-07-21 Thread Madhan Neethiraj
will shortly update incubator references in documents and website. Please let me know if you have any questions. Thanks, Madhan On 7/1/17, 11:00 PM, "Madhan Neethiraj" <mneethi...@hortonworks.com on behalf of mad...@apache.org> wrote: INFRA-14486 is the JIRA to track infras

Re: Review Request 61046: ATLAS-1960: Export, Import & ImportFile APIs EndPoints Handled in HA PASSIVE State

2017-07-21 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61046/#review181161 --- Ship it! Ship It! - Madhan Neethiraj On July 21, 2017, 9:45

Re: Relationship attributes

2017-07-24 Thread Madhan Neethiraj
: "dev@atlas.apache.org" <dev@atlas.apache.org> Cc: Madhan Neethiraj <mneethi...@hortonworks.com>, Sarath Subramanian <sar...@apache.org>, Graham Wallis <graham_wal...@uk.ibm.com> Subject: Re: Relationship attributes Hi all, I have just had a chat with G

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-07-24 Thread Madhan Neethiraj
/v1/AtlasRelationshipStoreV1.java Lines 128 (patched) <https://reviews.apache.org/r/61085/#comment256778> consider using vertex.getEdges(direction, edgeLabel), instead of iterating through edges to find the one with the expected label. - Madhan Neethiraj On July 24, 2017, 5:18 p.m.,

Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation

2017-07-23 Thread Madhan Neethiraj
results after this enhancement Thanks, Madhan Neethiraj

Review Request 61073: ATLAS-1982: Update references to "incubator" in website

2017-07-23 Thread Madhan Neethiraj
are removed. Thanks, Madhan Neethiraj

Re: Review Request 61073: ATLAS-1982: Update references to "incubator" in website

2017-07-23 Thread Madhan Neethiraj
d verified that incubator references are removed. Thanks, Madhan Neethiraj

Re: Review Request 61088: [ATLAS-1988]: Implement REST API to search for related entities

2017-07-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61088/#review181438 --- Ship it! Ship It! - Madhan Neethiraj On July 25, 2017, 7:51

Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Madhan Neethiraj
java 596b43bc Diff: https://reviews.apache.org/r/60980/diff/1/ Testing --- - validated that the fix addressed the error cases listed above Thanks, Madhan Neethiraj

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/#review181009 --- Ship it! Ship It! - Madhan Neethiraj On July 19, 2017, 7:27

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Madhan Neethiraj
SearchProcessor - avoid the need to pass additional parameter. - Madhan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review180967 ------

Re: Relationship attributes

2017-07-24 Thread Madhan Neethiraj
hipAttributes, I prefer relationships as it is simpler - is there a reason you need attribute in the name? all the best, David. From: Sarath Subramanian <sar...@apache.org> To: dev@atlas.apache.org Cc: Madhan Neethiraj <mad...@apache.org>

Re: Review Request 60783: [ATLAS-1943] : Fix IT failure due to incorrect inverse reference check using relationship

2017-07-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60783/#review180362 --- Ship it! Ship It! - Madhan Neethiraj On July 11, 2017, 8:14

Re: Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread Madhan Neethiraj
NONE. - Madhan Neethiraj On July 19, 2017, 2:26 p.m., David Radley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Madhan Neethiraj
nges: https://reviews.apache.org/r/60980/diff/1-2/ Testing --- - validated that the fix addressed the error cases listed above Thanks, Madhan Neethiraj

Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation

2017-07-21 Thread Madhan Neethiraj
0d1c39b7 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 28621658 Diff: https://reviews.apache.org/r/61040/diff/1/ Testing --- verified that the search returns correct results after this enhancement Thanks, Madhan Neethiraj

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60159/#review179336 --- Ship it! Ship It! - Madhan Neethiraj On June 30, 2017, 6:27

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Madhan Neethiraj
/reviews.apache.org/r/60578/#comment254106> Please move these comments from here to appropriate file. - Madhan Neethiraj On June 30, 2017, 8:25 p.m., Sarath Subramanian wrote: > > -

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Madhan Neethiraj
tps://reviews.apache.org/r/60578/#comment254121> for types that don't have superTypes, this method would return null - and cause NPE in #347/#348/#353/#354 Instead of computing this List (why not Set?) every time, consider adding a method to appropriate AtlasEntityType. - Madhan Neethiraj

Re: Review Request 60457: ATLS-1899

2017-07-01 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60457/#review179467 --- Ship it! Ship It! - Madhan Neethiraj On June 27, 2017, 9:04

GIT repo move

2017-07-01 Thread Madhan Neethiraj
Team Atlas, Congratulations on graduation to a Top Level Project! As we move out of incubation to a TLP, our git repo will move from https://git-wip-us.apache.org/repos/asf/incubator-atlas.git to https://git-wip-us.apache.org/repos/asf/atlas.git. I will be filing an INFRA ticket for

Re: GIT repo move

2017-07-02 Thread Madhan Neethiraj
INFRA-14486 is the JIRA to track infrastructure changes related to Atlas moving to a TLP. I will keep this list updated of the progress. Thanks, Madhan On 7/1/17, 10:43 AM, "Madhan Neethiraj" <mad...@apache.org> wrote: Team Atlas, Congratulations on gra

Re: Review Request 61191: [ATLAS-1999]: Use AtlasRelatedObjectId to display relationshipAttribute values during entity retrieval

2017-08-07 Thread Madhan Neethiraj
<https://reviews.apache.org/r/61191/#comment258239> Consider using AtlasRelatedObjectId constructor which takes relationship guid and attributes as well. - Madhan Neethiraj On July 27, 2017, 7:49 p.m., Sarath Subramanian wrote: > > --

Re: Review Request 61518: ATLAS-2033: Changed Pretty JSON Generation to Ugly for v1 Entity Serializers

2017-08-09 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61518/#review182471 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 9, 2017, 4:43

Re: Review Request 61195: ATLAS-1995: Performance Improvement Using IndexQuery for Attribute-based Entity Lookup

2017-07-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61195/#review181625 --- Ship it! Ship It! - Madhan Neethiraj On July 27, 2017, 10

Draft Board Report for Apache Atlas: August-2017

2017-08-07 Thread Madhan Neethiraj
Atlas team, Please review the draft board report below and send your feedback/comments, if any. The report is due on Wednesday this week, August-9. Thanks, Madhan ## Description: Apache Atlas is a scalable and extensible set of core foundational governance services

Re: Review Request 61747: [ATLAS-2059]: Update test-patch.sh script for PreCommit-ATLAS-Build jenkins job

2017-08-18 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61747/#review183245 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 18, 2017, 6:11

Re: Review Request 61721: [ATLAS-2054]: Add flag to exclude attribute mapping in FullTextMapper

2017-08-17 Thread Madhan Neethiraj
/FullTextMapperV2.java Line 127 (original), 143 (patched) <https://reviews.apache.org/r/61721/#comment259181> excludeAttributes - has attributes for the entity-type. It should be for classification.getTypeName() here. Please review. - Madhan Neethiraj On Aug. 17, 2017, 9:02 p.m.,

Re: Review Request 61686: ATLAS-2046 : UI Regression : Columns Filter not listing all attributes of a datatype

2017-08-16 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61686/#review183045 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 16, 2017, 12

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-16 Thread Madhan Neethiraj
ipType) Madhan - Madhan Neethiraj On July 24, 2017, 5:18 p.m., David Radley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61764: ATLAS-2061: Entity, Tag filter fetches empty results when applied on an enum attribute.

2017-08-18 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61764/#review183282 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 18, 2017, 11

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-20 Thread Madhan Neethiraj
<https://reviews.apache.org/r/61526/#comment259327> For better readability: "+e.getMessage()" ==> "+ e.getMessage()" - Madhan Neethiraj On Aug. 20, 2017, 11:34 a.m., David Radley wrote: > > ---

Re: Review Request 61825: [ATLAS-2079]: Fix IT failures introduced by ATLAS-2062

2017-08-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61825/#review183571 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 22, 2017, 10

Re: Review Request 61824: [ATLAS-2078]: Updating types using v1 API doesn't route to createUpdateTypesDef in v2 API

2017-08-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61824/#review183570 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 22, 2017, 10

Re: Review Request 61657: ATLAS-2045 Renumber shipped Atlas models

2017-08-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61657/#review183141 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 15, 2017, 1:59

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread Madhan Neethiraj
dition in line #99 should be: "if (!type1.equals(type2)) {". Please review. - Madhan Neethiraj On June 26, 2017, 12:29 p.m., David Radley wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60272/#review178890 --- Ship it! Ship It! - Madhan Neethiraj On June 26, 2017, 12

Re: Review Request 59799: ATLAS-1766 : Atlas with Kafka SASL_SSL protocol

2017-06-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59799/#review178894 --- Ship it! Ship It! - Madhan Neethiraj On June 26, 2017, 8:37

Re: Review Request 58434: Import API: Improved the API to Update Existing Types Attributes

2017-06-26 Thread Madhan Neethiraj
omment253262> addAttributes() ==> addElements() - Madhan Neethiraj On June 22, 2017, 2:51 p.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-25 Thread Madhan Neethiraj
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java Lines 429 (patched) <https://reviews.apache.org/r/60272/#comment253135> Instead of compating json-ified endDefs, consider the following: if (!newRelationshipDef.getEnd1().equals(existingRelationsh

Re: Review Request 58434: Import API: Improved the API to Update Existing Types Attributes

2017-06-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58434/#review178955 --- Ship it! Ship It! - Madhan Neethiraj On June 27, 2017, 5:27

Re: [DISCUSS] Restrict AtlasStruct and AtlasClassification attributes to primitive and enum types

2017-06-28 Thread Madhan Neethiraj
Mandy, The relationship introduced in ATLAS-1690 requires entity-type be specified for each end; effectively injecting an attribute to the entity types specified. This doesn’t allow struct or a classification types at relationship ends. In addition, allowing structs to hold entity references

Re: Review Request 62355: ATLAS-2102 : Atlas UI Improvements: Search results page

2017-09-15 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62355/#review185492 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 15, 2017, 2

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62110/#review185330 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 13, 2017, 7

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-13 Thread Madhan Neethiraj
ld be: return ((Collection)attrValue).contains(value); repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java Lines 526 (patched) <https://reviews.apache.org/r/62110/#comment261630> this should be: return ((Collection)value).contains(attrVal); - Madhan Neethira

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review185423 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 13, 2017, 1

Re: Review Request 62244: ATLAS2058 Add description to attributedefs and relationship enddefs

2017-09-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62244/#review185420 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 12, 2017, 5

Re: Review Request 62039: ATLAS-2100: UserProfile & SavedSearch Implementation

2017-09-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62039/#review185523 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 16, 2017, 8

Re: Review Request 62420: ATLAS-2148: Enhancement to Saved Search

2017-09-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62420/#review185761 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 19, 2017, 11

Re: Review Request 62342: [ATLAS-2136]: Change audit and notification entityChangeListener to start using v2 API structure

2017-09-19 Thread Madhan Neethiraj
02 (patched) <https://reviews.apache.org/r/62342/#comment261975> FullTextMapperV2.java uses RequestContext to get the entity from cache, if it exists. It will be efficient than loading entities from the store again. Please review FullTextMapperV2.getAndCacheEntity(guid) - Madhan

Re: Atlas issues about 0.9 release

2017-09-19 Thread Madhan Neethiraj
Junheng, Ismaël, > 1. The Atlas version 0.9 is in development phase, I can see the version > 0.9-SNAPSHOT published on your website and then where can I get the 0.9 > package? 0.9 version is still under development in the master branch. Only after it is released, 0.9 libraries will

Re: Review Request 62390: ATLAS-2146: Remove Powermock Usage

2017-09-18 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62390/#review185639 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 18, 2017, 7

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62455/#review186034 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 22, 2017, 9

Re: Review Request 62491: ATLAS-2151: Surrounding brace fix for multiple filters on same attribute

2017-09-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62491/#review186042 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 23, 2017, 1

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-20 Thread Madhan Neethiraj
ne 451 (original), 451 (patched) <https://reviews.apache.org/r/62455/#comment262186> Edge label should be created for struct type attributes as well. - Madhan Neethiraj On Sept. 20, 2017, 9:55 p.m., Apoor

Re: Review Request 62366: ATLAS-2140 - removing unnecessary exceptions

2017-09-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62366/#review185525 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 16, 2017, 2

Re: Review Request 62039: ATLAS-2100: UserProfile & SavedSearch Implementation

2017-09-15 Thread Madhan Neethiraj
;saved" webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java Lines 362 (patched) <https://reviews.apache.org/r/62039/#comment261825> "save" ==> "saved" - Madhan Neethiraj On Sept. 15, 2017, 10:33 p.m., Ashutosh Mestry wrote: > >

Re: Review Request 62337: ATLAS-2028: Search attribute validation

2017-09-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62337/#review185452 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 14, 2017, 6

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62129/#review185373 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 14, 2017, 5

Re: Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query

2017-09-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62338/#review185449 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 14, 2017, 6

Re: Review Request 62127: ATLAS-2118: Basic search contains issue

2017-09-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62127/#review185450 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 14, 2017, 4

  1   2   3   4   5   6   7   8   9   10   >