s/discovery/GremlinSearchStep.java
Lines 89 (patched)
<https://reviews.apache.org/r/60159/#comment252746>
searchParameters.getTypeName() ==> searchParameters.getClassification():
attributes referenced in tagFilters will be defined in the classification
(and not the given entity).
Better yet, consi
t252756>
Should the double quotes be escaped here as well - similar to previous
values?
"\"true\""
- Madhan Neethiraj
On June 22, 2017, 4:27 a.m., Ashutosh Mestry wrote:
>
> ---
> This
764>
relationshipAttrDef may not be necessary. Consider the following:
AtlasAttribute relationshipAttr = end1Type.getAttribute(attrName);
- Madhan Neethiraj
On June 21, 2017, 7:14 p.m., Sarath Subramanian wrote:
>
> ---
> This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60285/#review178772
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 22, 2017, 9:51
ent253027>
"List" ==> "List" - since the return type of this method is "List".
This update would require bunch of other updates..which endup with
inconsistencies in types returned/expected. Please review.
- M
ationshipDef.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
Lines 429 (patched)
<https://reviews.apache.org/r/60272/#comment253135>
Instead of compating json-ified endDefs, consider the following:
if
(!newRelationshipDef.getEnd1().equals(exi
dition in line #99 should be:
"if (!type1.equals(type2)) {".
Please review.
- Madhan Neethiraj
On June 26, 2017, 12:29 p.m., David Radley wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60272/#review178890
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 26, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59799/#review178894
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 26, 2017, 8:37
omment253262>
addAttributes() ==> addElements()
- Madhan Neethiraj
On June 22, 2017, 2:51 p.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58434/#review178955
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 27, 2017, 5:27
Mandy,
The relationship introduced in ATLAS-1690 requires entity-type be specified for
each end; effectively injecting an attribute to the entity types specified.
This doesn’t allow struct or a classification types at relationship ends. In
addition, allowing structs to hold entity references ad
w query object needs to be instantiated here. Please
review.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
Lines 373 (patched)
<https://reviews.apache.org/r/60159/#comment253761>
vertexIndexKeys should be recomputed after index updates for type
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/#review179336
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 30, 2017, 6:27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60528/#review179338
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 30, 2017, 8:22
lt;https://reviews.apache.org/r/60578/#comment254106>
Please move these comments from here to appropriate file.
- Madhan Neethiraj
On June 30, 2017, 8:25 p.m., Sarath Subramanian wrote:
>
> ---
tps://reviews.apache.org/r/60578/#comment254121>
for types that don't have superTypes, this method would return null - and
cause NPE in #347/#348/#353/#354 Instead of computing this List (why not Set?)
every time, consider adding a method to appropriate AtlasEntityType.
- Madhan Neethir
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60457/#review179467
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 27, 2017, 9:04
Team Atlas,
Congratulations on graduation to a Top Level Project!
As we move out of incubation to a TLP, our git repo will move from
https://git-wip-us.apache.org/repos/asf/incubator-atlas.git to
https://git-wip-us.apache.org/repos/asf/atlas.git. I will be filing an INFRA
ticket for this
INFRA-14486 is the JIRA to track infrastructure changes related to Atlas moving
to a TLP. I will keep this list updated of the progress.
Thanks,
Madhan
On 7/1/17, 10:43 AM, "Madhan Neethiraj" wrote:
Team Atlas,
Congratulations on graduation to a Top Lev
Chandana,
Done. Welcome to Apache Atlas community.
Madhan
On 7/7/17, 6:18 PM, "Chandana Mirashi" wrote:
Hi,
I would like to contribute to Atlas. Can someone please add me so that
I can assign myself JIRA to work on?
Regards,
Chandana Mirashi
eplace context.guidsInSink.contains(guid) with
context.sink.hasEntity(guid)
- Madhan Neethiraj
On July 8, 2017, 12:12 a.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Peter,
Done. Welcome to Apache Atlas community.
Madhan
On 7/10/17, 4:23 AM, "Peter Gergo Barna" wrote:
Hi All,
I would like to contribute to Atlas, currently I am working on this issue:
https://issues.apache.org/jira/browse/ATLAS-1879.
I would like to be able to assign JIRA issues
Robert,
Done. Welcome to Apache Atlas community.
Madhan
On 7/10/17, 3:09 AM, "Robert Kern" wrote:
Hi,
I would like to contribute to Atlas. Could a PMC member with admin access
please add me as a contributor in JIRA so that I can assign items to myself?
My username is robkern.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60742/#review180030
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 10, 2017, 11
Atlas team,
Please review the draft board report below and send your feedback/comments, if
any. The report is due on Wednesday this week, July-12.
Thanks,
Madhan
## Description:
Apache Atlas is a scalable and extensible set of core foundational governance
services that
think i would need to be added as committer. Could you please add me
(eralmas7) as committer please?
Thanks,
Almas
On Mon, Jul 10, 2017 at 6:09 PM, Madhan Neethiraj wrote:
> Robert,
>
> Done. Welcome to Apache Atlas community.
>
> Mad
Thanks
hemanth
____
From: Madhan Neethiraj
Sent: Monday, July 10, 2017 8:21 PM
To: dev@atlas.apache.org
Subject: Draft Board Report for Apache Atlas: July-2017
Atlas team,
Please review the draft board
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60578/#review180183
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 11, 2017, 7:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60792/#review180294
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 12, 2017, 6:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60783/#review180362
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 11, 2017, 8:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60851/#review180463
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 13, 2017, 8:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/#review180596
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 14, 2017, 9:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60852/#review180602
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 14, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60863/#review180604
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 14, 2017, 12
Transforms().get(s).putAll(attribtueTransformMap).
- Madhan Neethiraj
On July 14, 2017, 6 p.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60722/#review180695
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 10, 2017, 3:59
“/api/v2/search” is not the correct URI. Can you try with
“api/atlas/v2/search”?
Madhan
On 7/17/17, 11:51 AM, "Jean Georges Perrin" wrote:
Hi,
I installed and run Atlas on my Mac. Everything seems to be working fine in
the UI, but I cannot get the API to work... I am sure it i
/apache/atlas/discovery/EntityDiscoveryService.java
Lines 479 (patched)
<https://reviews.apache.org/r/60922/#comment255987>
keep this inside a finally {} block, to ensure that search-context gets
removed when search method exits.
- Madhan Neethiraj
On July 17, 2017, 9:37 p.m., Apoor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60923/#review180780
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 17, 2017, 9:36
/SearchContext.java
55a07f3d
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
14818094
Diff: https://reviews.apache.org/r/60940/diff/1/
Testing
---
Validated that the search completes much quicker with this update.
Thanks,
Madhan Neethiraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60705/#review180812
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 18, 2017, 11
/titan/query/NativeTitanMultiVertexQuery.java
Lines 29 (patched)
<https://reviews.apache.org/r/60927/#comment255998>
This interface doesn't seem to be used. Please review. If not required,
please remove.
- Madhan Neethiraj
On July 17, 2017, 10:31 p.m., Apoorv
/
Testing
---
Validated that the search completes much quicker with this update.
Thanks,
Madhan Neethiraj
ansmit when large number of entities are referenced (for
example hive_db.tables referring to 1000s of tables). Storing AtlasObjectId
(or List) is enough.
Same comment for line #474 below.
- Madhan Neethiraj
On July 18, 2017, 6:25 a.m., Sarath Subramanian
gt;
- "ATLAS-400-00-021" ==> AtlasErrorCode.INVALID_OBJECT_ID.getErrorCode()
- { }
- Madhan Neethiraj
On July 19, 2017, 4:56 a.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To
NONE.
- Madhan Neethiraj
On July 19, 2017, 2:26 p.m., David Radley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/v1/AtlasRelationshipDefStoreV1.java
Lines 484 (patched)
<https://reviews.apache.org/r/60970/#comment256292>
@David - makes sense. I will commit the patch shortly. Thanks!
- Madhan Neethiraj
On July 19, 2017, 2:26 p.m., David Radley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60971/#review180948
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 19, 2017, 2:22
java
596b43bc
Diff: https://reviews.apache.org/r/60980/diff/1/
Testing
---
- validated that the fix addressed the error cases listed above
Thanks,
Madhan Neethiraj
nges: https://reviews.apache.org/r/60980/diff/1-2/
Testing
---
- validated that the fix addressed the error cases listed above
Thanks,
Madhan Neethiraj
SearchProcessor -
avoid the need to pass additional parameter.
- Madhan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60980/#review180967
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60938/#review181009
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 19, 2017, 7:27
2-3/
Testing
---
- validated that the fix addressed the error cases listed above
Thanks,
Madhan Neethiraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61002/#review181062
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 20, 2017, 5:22
ache/atlas/discovery/SearchProcessor.java
7950127d
Diff: https://reviews.apache.org/r/60980/diff/4/
Changes: https://reviews.apache.org/r/60980/diff/3-4/
Testing
---
- validated that the fix addressed the error cases listed above
Thanks,
Madhan Neethiraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61007/#review181089
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 20, 2017, 9:16
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60980/#review181094
-------
On July 21, 2017, 1:39 a.m., Madhan Neethiraj wrote:
>
> --
which is used in other places like search
results. Currently AtlasEntityHeader.displayText field is set to either ‘name’
or ‘qualifiedName’ attribute value.
Thanks,
Madhan
From: David Radley
Date: Friday, July 21, 2017 at 3:01 AM
To: Madhan Neethiraj , Sarath Subramanian
Cc: "
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61026/#review181117
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 21, 2017, 1:22
0d1c39b7
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
28621658
Diff: https://reviews.apache.org/r/61040/diff/1/
Testing
---
verified that the search returns correct results after this enhancement
Thanks,
Madhan Neethiraj
shortly update incubator references in documents and website. Please let
me know if you have any questions.
Thanks,
Madhan
On 7/1/17, 11:00 PM, "Madhan Neethiraj" wrote:
INFRA-14486 is the JIRA to track infrastructure changes related to Atlas
moving to a TLP. I will keep this li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61046/#review181161
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 21, 2017, 9:45
results after this enhancement
Thanks,
Madhan Neethiraj
removed.
Thanks,
Madhan Neethiraj
d verified that incubator references are removed.
Thanks,
Madhan Neethiraj
tionships as it is simpler - is there a reason you need
attribute in the name?
all the best, David.
From: Sarath Subramanian
To: dev@atlas.apache.org
Cc: Madhan Neethiraj
Date: 24/07/2017 07:09
Subject:Re: Relation
om
IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
Tel: +44-1962-815356Tie: 7-245356
From: Madhan Neethiraj
To: "dev@atlas.apache.org" , Sarath Subramanian
Date: 24/07/2017 09:04
Subject:Re: Relationship attributes
Sent by:Madhan
/v1/AtlasRelationshipStoreV1.java
Lines 128 (patched)
<https://reviews.apache.org/r/61085/#comment256778>
consider using vertex.getEdges(direction, edgeLabel), instead of iterating
through edges to find the one with the expected label.
- Madhan Neethiraj
On July 24, 2017, 5:18 p.m.,
his if the you and the community prefer the
relatedEntities.
all the best, David
From: Madhan Neethiraj
To: David Radley , "dev@atlas.apache.org"
Cc: Sarath Subramanian , Graham Wallis
Date
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61100/#review181317
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 25, 2017, 5:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61103/#review181342
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 25, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61088/#review181438
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 25, 2017, 7:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61195/#review181625
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 27, 2017, 10
--
>
> (Updated July 28, 2017, 9:47 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Repository: atlas
>
>
> Description
> ---
>
> Right now in the V2 API, if an entity update is performed with an invalid
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61233/#review181749
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 28, 2017, 9:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61130/#review181772
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 30, 2017, 4:53
hProcessor.java
31d145cd
Diff: https://reviews.apache.org/r/61246/diff/1/
Testing
---
Verified that tag-filtering executes correctly for numeric, date, string, enum
type attributes.
Thanks,
Madhan Neethiraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66816/#review202018
---
Ship it!
Ship It!
- Madhan Neethiraj
On April 26, 2018, 4
David - I agree on option #3 for 1.0 release.
Thanks,
Madhan
On 4/26/18, 9:14 AM, "David Radley" wrote:
Hi there,
We had a meeting to discuss how we would like to document the embedded
Cassandra support in Atlas v1.0. We talked of 3 options :
1) Include it in the code
/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 1080 (patched)
<https://reviews.apache.org/r/66833/#comment283699>
Consider moving this referredEntitiesContains() check before line #1074,
which avoid calls to getEntityVertex(guid) and getGuid(entityVertex).
- Madhan Nee
-ATLAS-Build-Test/311/
Thanks,
Madhan Neethiraj
rameters() will fail with appropriate error code.
- Madhan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66838/#review202041
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66833/#review202045
---
Ship it!
Ship It!
- Madhan Neethiraj
On April 26, 2018, 11
below:
for (BaseColumnInfo baseColumn :
ColumnLineageUtils.getBaseCols(entry.getValue())) {
- Madhan Neethiraj
On April 27, 2018, 2:10 p.m., Gergo Barna wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/atlas/services/MetricsService.java
Line 67 (original), 69 (patched)
<https://reviews.apache.org/r/66772/#comment283758>
batchSize ==> typesBatchSize
- Madhan Neethiraj
On April 24, 2018, 6:02 a.m., Apoorv Naik wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66876/#review202184
---
Ship it!
Ship It!
- Madhan Neethiraj
On April 30, 2018, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66884/#review202191
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 1, 2018, 5:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66891/#review202218
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 1, 2018, 8:58
t.guid;
}
Also, update all derived classes to call this copy constructor from their
copy constructor implementation.
- Madhan Neethiraj
On May 1, 2018, 9:38 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66907/#review202357
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 3, 2018, 3:05
ted to
atlas-migration-exporter module.
- Madhan Neethiraj
On May 3, 2018, 7:06 p.m., Sarath Subramanian wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/#review202381
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 3, 2018, 7:06
HOOK",
kafkaMsg.getPartition()), kafkaMessage.getOffset() + 1);
return;
}
...
}
- Madhan Neethiraj
On May 3, 2018, 11:29 p.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To r
/atlas/repository/graph/GraphHelper.java
Lines 886 (patched)
<https://reviews.apache.org/r/66941/#comment284211>
rename: relationshipGuid ==> guidRelationshipToExclude
Also, please rename corresponding bind parameter name.
- Madhan Neethiraj
On May 3, 2018, 11:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66899/#review202459
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 4, 2018, 4:33
om of the page, and
easy to miss. Consider moving these to the top
- 'Properties' tab: term relationship attribute values should be editable -
similar to classification attributes. Currently only 'Delete' button is shown.
- Madhan Neethiraj
Diff: https://reviews.apache.org/r/66976/diff/1/
Testing
---
Thanks,
Madhan Neethiraj
Shivji Kumar,
> In java lingo, we are simply looking for something of the
> sort of map representing attribute name
> and any subtype of Object.
Entity-type 'Process' has 2 attributes, 'inputs' and 'outputs',
of type 'array'. Each element in the array value can
be of a sub-type of 'DataSet' - like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66989/#review202575
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 7, 2018, 6:42
1 - 100 of 3395 matches
Mail list logo
