[GitHub] sohami commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199210264 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/lateraljoin/TestE2EUnnestAndLateral.java

[jira] [Created] (DRILL-6559) Travis timing out

2018-06-29 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6559: -- Summary: Travis timing out Key: DRILL-6559 URL: https://issues.apache.org/jira/browse/DRILL-6559 Project: Apache Drill Issue Type: Improvement

[GitHub] arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-29 Thread GitBox
arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199212137 ## File path:

Re: [DISCUSSION] Travis build failures

2018-06-29 Thread Vitalii Diravka
Agree, TestTpchExplain and TestTpchPlanning are fast enough. TestTpchLimit0 has PlannerTest category, but it is slower than the above tests. Actually only TestTpchSingleMode and TestTpchLimit0 are candidates for excluding. I am not sure that it is enough for Travis (45 seconds on my machine). What

[GitHub] vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-29 Thread GitBox
vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199215493 ## File path:

Re: DRILL-6519 Tavis CI timing out

2018-06-29 Thread Vitalii Diravka
Hi Charles, Recently there was a discussion in dev mailing list regarding this. Please take a look. Also I have created Jira ticket [1]. [1] https://issues.apache.org/jira/browse/DRILL-6559 Kind regards Vitalii On Fri, Jun 29, 2018 at 5:43 PM Charles Givre wrote: > Hi Arina, > Could you or

Re: DRILL-6519 Tavis CI timing out

2018-06-29 Thread Charles Givre
Hi Vitalii I saw the discussion but is there anything that I can do to prevent this from happening? Sent from my iPhone > On Jun 29, 2018, at 12:34, Vitalii Diravka wrote: > > Hi Charles, > > Recently there was a discussion in dev mailing list regarding this. Please > take a look. > Also I

[GitHub] vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-29 Thread GitBox
vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199217282 ## File path:

[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401424556 @arina-ielchiieva, I thought about that - but it's a bit more complicated in how i'd like it to be: An "Export All"

[jira] [Created] (DRILL-6562) Provide option to Export All storage plugin configurations at once

2018-06-29 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-6562: -- Summary: Provide option to Export All storage plugin configurations at once Key: DRILL-6562 URL: https://issues.apache.org/jira/browse/DRILL-6562 Project: Apache

Re: Travis CI Timed Out

2018-06-29 Thread Timothy Farkas
The timeouts are a sporadic issue. You can click on the failed build to bring up Travis. For now, since you are a committer you will have a restart build button to the right of the console (non-committers don't get this button for some reason), this will try the build again and it will probably

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199251973 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230469 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230386 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-06-29 Thread GitBox
KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199242382 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199228648 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

2018-06-29 Thread GitBox
vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199237071 ## File path:

[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401441469 Filed DRILL-6562 to track this. Regarding one vs multiple files, my reasoning was to keep it more human readable

[GitHub] ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199263635 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

Re: DRILL-6519 Tavis CI timing out

2018-06-29 Thread Arina Yelchiyeva
We are just finalizing the list of tests we are going to be marked as slow. Once done, this would be an easy fix :) Kind regards, Arina On Fri, Jun 29, 2018 at 7:41 PM Charles Givre wrote: > Hi Vitalii > I saw the discussion but is there anything that I can do to prevent this > from happening?

Re: Actual vectorization execution

2018-06-29 Thread Aman Sinha
Hi Weijie, the Panama project is an OpenJDK initialitve, right [1] ? not Intel specific. It would be quite a bit of work to test and certify with Intel's JVM which may be still in the experimental stage. Also, you may have seen the Gandiva project for Apache Arrow which aims to improve

[jira] [Created] (DRILL-6563) TPCDS query 10 has regressed

2018-06-29 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6563: - Summary: TPCDS query 10 has regressed Key: DRILL-6563 URL: https://issues.apache.org/jira/browse/DRILL-6563 Project: Apache Drill Issue Type: Bug

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-40105 If logging needs to be enabled just for QA purposes, I still don't see why it needs to be enabled per query or be dynamic

[GitHub] ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401453225 @vrozov My understanding was the following. QA has setup automatic tests of both the performance of batch sizing as well

Re: Actual vectorization execution

2018-06-29 Thread Paul Rogers
Hi Weijie, As it turns out, vectorized processing in Drill is more aspirational than operational at this point in time. The code used in Drill is not actually vector-based even though the data itself is columnar. Drill generally does row-wise operations because row-wise operations fit the SQL

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401466019 I'll work on adding the instructions into both the docs dir on this repo and the write-up on Parth's repo once the PR is in.

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230067 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401437213 Sounds fair regarding the enhancement Jira. I think keeping export button even in update mode is also good.

[GitHub] KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-06-29 Thread GitBox
KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#issuecomment-401439843 WIP: going to exclude unneeded dependencies from dependencies added to dependencyManagement.

[jira] [Created] (DRILL-6565) cume_dist does not return enough rows

2018-06-29 Thread Robert Hou (JIRA)
Robert Hou created DRILL-6565: - Summary: cume_dist does not return enough rows Key: DRILL-6565 URL: https://issues.apache.org/jira/browse/DRILL-6565 Project: Apache Drill Issue Type: Bug

[GitHub] priteshm commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin

2018-06-29 Thread GitBox
priteshm commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin URL: https://github.com/apache/drill/pull/1272#issuecomment-401474974 @akumarb2010 is this ready to be committed? This is an automated

Re: [DISCUSSION] Travis build failures

2018-06-29 Thread Arina Yelchiyeva
Or we can be more radical here and exclude all tests from contib module? On Fri, Jun 29, 2018 at 7:28 PM Vitalii Diravka wrote: > Agree, TestTpchExplain and TestTpchPlanning are fast enough. > TestTpchLimit0 has PlannerTest category, but it is slower than the above > tests. > Actually only

[GitHub] ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401424230 @vrozov I discussed the logging with @sachouche. The issue is that some information needed to be logged for QA purposes on

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199272513 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199272414 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199274859 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199274012 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199289952 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[jira] [Created] (DRILL-6567) Jenkins Regression: TPCDS query 93 fails with INTERNAL_ERROR ERROR: java.lang.reflect.UndeclaredThrowableException.

2018-06-29 Thread Robert Hou (JIRA)
Robert Hou created DRILL-6567: - Summary: Jenkins Regression: TPCDS query 93 fails with INTERNAL_ERROR ERROR: java.lang.reflect.UndeclaredThrowableException. Key: DRILL-6567 URL:

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199307744 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199310178 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199308452 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199308790 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@

[GitHub] sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

2018-06-29 Thread GitBox
sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401513254 @kkhatua, can you please review this fix? Thanks!

[GitHub] sachouche opened a new pull request #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

2018-06-29 Thread GitBox
sachouche opened a new pull request #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354 Reserving same size intermediary buffers to handle the case of false-positive; that is, a column is first thought to be fixed length

[GitHub] sachouche opened a new pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement

2018-06-29 Thread GitBox
sachouche opened a new pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355 This PR is reserved for internal Drill testing. It provides more logging control when testing the batch sizing functionality. At this

[GitHub] sachouche commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement

2018-06-29 Thread GitBox
sachouche commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355#issuecomment-401513955 @bitblender, can you please review this PR? Thanks!

Re: Actual vectorization execution

2018-06-29 Thread weijie tong
Yes, Panama is a OpenJDK project ,Intel is the prime contributor. Some team of our company has tried this feature . I have a plan to try this feature to Drill. As @aman points out, it really will take some work to validate its stable and the newer version JDK. Gandiva brings a great idea to

[jira] [Created] (DRILL-6566) Jenkins Regression: TPCDS query 66 fails with RESOURCE ERROR: One or more nodes ran out of memory while executing the query. AGGR OOM at First Phase.

2018-06-29 Thread Robert Hou (JIRA)
Robert Hou created DRILL-6566: - Summary: Jenkins Regression: TPCDS query 66 fails with RESOURCE ERROR: One or more nodes ran out of memory while executing the query. AGGR OOM at First Phase. Key: DRILL-6566 URL:

[GitHub] ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401498074 @Ben-Zvi Thank you Boaz for the thorough review and giving me a +1 finally.

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198928698 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198886347 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199270039 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the Apache

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198883586 ## File path: common/src/main/java/org/apache/drill/common/exceptions/DrillIOException.java ## @@ -19,24 +19,23 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073178 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -63,17

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073307 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199075637 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199079357 ## File path: distribution/src/deb/control/conffiles ## @@ -16,3 +16,4 @@ /etc/drill/conf/drill-override.conf

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199076849 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199105919 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -25,6

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198926537 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199093883 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -25,6

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199266170 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276671 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -393,7 +393,11 @@ drill.exec: { //port

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276599 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199104274 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the Apache

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198882971 ## File path: common/src/main/java/org/apache/drill/common/config/CommonConstants.java ## @@ -31,4 +31,7 @@ /**

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198931779 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ## @@ -248,6 +248,12 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198928608 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginMap.java ## @@ -111,7 +112,7

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276235 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198884749 ## File path: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java ## @@ -36,11 +36,11 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073387 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198892158 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -251,6 +251,9 @@ drill.exec: {

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198932079 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199077537 ## File path: logical/src/main/java/org/apache/drill/common/config/LogicalPlanPersistence.java ## @@ -37,12 +37,12

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073271 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276413 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401508476 @arina-ielchiieva , on second thoughts, i think having a seperate profile is better. Created a new profile called 'docker'.

[GitHub] HanumathRao commented on issue #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-29 Thread GitBox
HanumathRao commented on issue #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#issuecomment-401513962 @amansinha100 Thank you for the review. This is an

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199305514 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199307586 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199306162 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199306981 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,69

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199218902 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199305835 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -17,22

[jira] [Created] (DRILL-6569) Jenkins Regression: TPCDS query 19 fails with INTERNAL_ERROR ERROR: Can not read value at 2 in block 0 in file maprfs:///drill/testdata/tpcds_sf100/parquet/store_sales/1_

2018-06-29 Thread Robert Hou (JIRA)
Robert Hou created DRILL-6569: - Summary: Jenkins Regression: TPCDS query 19 fails with INTERNAL_ERROR ERROR: Can not read value at 2 in block 0 in file maprfs:///drill/testdata/tpcds_sf100/parquet/store_sales/1_13_1.parquet Key:

[GitHub] kkhatua commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
kkhatua commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401503825 I'd be more comfortable with single plugins to avoid any possible corruption (e.g. format, etc) as debugging could be a

[jira] [Created] (DRILL-6568) Jenkins Regression: TPCDS query 68 fails with IllegalStateException: Unexpected EMIT outcome received in buildSchema phase

2018-06-29 Thread Robert Hou (JIRA)
Robert Hou created DRILL-6568: - Summary: Jenkins Regression: TPCDS query 68 fails with IllegalStateException: Unexpected EMIT outcome received in buildSchema phase Key: DRILL-6568 URL:

[GitHub] ilooner commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-06-29 Thread GitBox
ilooner commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401509765 @priteshm will take a look monday. @vrozov please fix conflict and travis failures.

[GitHub] priteshm commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
priteshm commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401478271 I do see that a similar approach is followed for other operators for batch sizing. I do agree with @ilooner that it would

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230386 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[jira] [Created] (DRILL-6570) IndexOutOfBoundsException when using Flat Parquet Reader

2018-06-29 Thread salim achouche (JIRA)
salim achouche created DRILL-6570: - Summary: IndexOutOfBoundsException when using Flat Parquet Reader Key: DRILL-6570 URL: https://issues.apache.org/jira/browse/DRILL-6570 Project: Apache Drill

[jira] [Created] (DRILL-6560) Allow options for controlling the batch size per operator

2018-06-29 Thread salim achouche (JIRA)
salim achouche created DRILL-6560: - Summary: Allow options for controlling the batch size per operator Key: DRILL-6560 URL: https://issues.apache.org/jira/browse/DRILL-6560 Project: Apache Drill

[jira] [Created] (DRILL-6561) Lateral excluding the columns from output container provided by projection push into rules

2018-06-29 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6561: Summary: Lateral excluding the columns from output container provided by projection push into rules Key: DRILL-6561 URL: https://issues.apache.org/jira/browse/DRILL-6561

[GitHub] chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-06-29 Thread GitBox
chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199068099 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -32,35

[GitHub] vvysotskyi commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

2018-06-29 Thread GitBox
vvysotskyi commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#discussion_r199072062 ## File path:

[GitHub] chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-06-29 Thread GitBox
chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199060984 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -32,35

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-06-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199113139 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -32,35

[jira] [Created] (DRILL-6557) Use size in bytes during Hive statistics calculation if present

2018-06-29 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-6557: --- Summary: Use size in bytes during Hive statistics calculation if present Key: DRILL-6557 URL: https://issues.apache.org/jira/browse/DRILL-6557 Project: Apache

[GitHub] arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-29 Thread GitBox
arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199199005 ## File path:

  1   2   >