quot; most places
correct?
- Brock Noland
On July 10, 2012, 9:56 a.m., Juhani Connolly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
What leads you to that conclusion about FC? (I am curious in case there is
something I am unaware of.) This is where a Put ends up being written and
there is no flush until a commit.
https://github.com/apache/flume/blob/trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/chan
+1 for git
--
Brock Noland
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Wednesday, July 11, 2012 at 7:19 PM, Ralph Goers wrote:
> If it isn't obvious, I'm also in favor of this. I think it has the potential
> to make the RTC process much better.
>
> Ralp
+1 to accept git
On Sunday, July 15, 2012 at 9:20 PM, Mubarak Seyed wrote:
> +1
>
> On Jul 15, 2012, at 12:36 PM, Will McQueen wrote:
>
> > +1
> >
> > On Jul 15, 2012, at 12:22 PM, Hari Shreedharan
> > wrote:
> >
> > > This is a call for VOTE to change the primary source control for Apac
Hi,
I think a tool like this could be useful. Do you want to create a JIRA and
attach it so we can have a look?
Brock
On Thu, Jul 26, 2012 at 1:12 AM, Denny Ye wrote:
> hi all,
> In the progress of maintaining Flume NG, it's hard to manage
> configuration in too many flows.
> Meanwhile
ment20455>
Any reason we are using an exception to log this timeout message?
Also, we have combined the interrupt and timeout into one log message.
- Brock Noland
On July 28, 2012, 7:19 p.m., Hari Shreedharan wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6183/#review9589
---
Ship it!
Ship It!
- Brock Noland
On July 30, 2012, 6:51 a.m
This also came up here:
http://mail-archives.apache.org/mod_mbox/flume-user/201207.mbox/%3CCAFukC=6C=jBayVSVAQdiJA+6kWUQ46_uXbDWBbUjDxb+U=a...@mail.gmail.com%3E
I think it would be great if we could get a standalone python client working.
Brock
On Mon, Jul 30, 2012 at 3:34 AM, Juhani Connolly
w
Looks like I was able to commit just now! Note that I had to setup
the .netrc file described here: https://git-wip-us.apache.org/ RHEL
6.2 with git from the repo.
Brock
On Mon, Jul 30, 2012 at 2:50 PM, Ralph Goers wrote:
> The CMS is built on top of svn so I'm pretty sure the site has to stay o
/hdfs/HDFSEventSink.java
d65c5a8
Diff: https://reviews.apache.org/r/6220/diff/
Testing
---
Thanks,
Brock Noland
/hdfs/BucketWriter.java
<https://reviews.apache.org/r/6220/#comment20532>
Where are we calling the .get() method on timedRollFuture?
- Brock Noland
On July 31, 2012, 1:55 a.m., Brock Noland wrote:
>
> ---
> This is a
Congrats!!
--
Brock Noland
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Tuesday, July 31, 2012 at 1:21 AM, Inder Pall wrote:
> Congrats Mubarak.
>
> - inder
>
> On Tue, Jul 31, 2012 at 11:36 AM, Mingjie Lai wrote:
>
> > Hi Flume devs.
> >
&g
I would create a JIRA for this. FWIW, many people run multiple
channels per host so I don't necessarily agree with this:
"But in our case, the fan out is replicating in most cases. If using
the current "Replicating to Channels" configuration, we will get
several identical channels on the same host
Hi,
I agree, it does not appear to work that way today. It looks like there is
already a JIRA for this https://issues.apache.org/jira/browse/FLUME-1350
If you have any ideas or patches, please update that JIRA!
Brock
On Tue, Jul 31, 2012 at 1:37 PM, Yongcheng Li wrote:
> Does anyone have com
I cannot answer what made us move to Avro. However, I prefer Avro because
you don't have to build the thrift compiler and you aren't required to do
code generation.
On Wed, Aug 1, 2012 at 11:06 PM, Juhani Connolly <
juhani_conno...@cyberagent.co.jp> wrote:
> It looks to me like this was because o
7;s faster? Either way it should lead to
write system call.
- Brock Noland
On Aug. 3, 2012, 9:39 a.m., Denny Ye wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
wrote:
> On paper it certainly seems like a good solution, it's just unfortunate
> that some "supported" languages can't actually interface to it. I
> understand that thrift can be quite a nuisance to deal with at times.
>
>
> On 08/02/2012 11:01 PM, Brock Nol
oved.
In practice this set will be quite small.
- Brock Noland
On Aug. 5, 2012, 12:26 a.m., Hari Shreedharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
thank you
for submitting this!
- Brock Noland
On Aug. 5, 2012, 12:26 a.m., Hari Shreedharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
> On Aug. 5, 2012, 2:32 p.m., Brock Noland wrote:
> > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java,
> > line 726
> > <https://reviews.apache.org/r/6387/diff/3/?file=134246#file134246line726>
> >
> > Can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6387/#review9868
---
Ship it!
Ship It!
- Brock Noland
On Aug. 5, 2012, 9:49 p.m., Hari
unit tests pass. A unit test is added, testRaceFoundInFLUME1432 which found
a problem with the way we previously replayed logs. It passes with these
changes. I also tested on a two node flume installation stopping and restarting
a node several times.
Thanks,
Brock Noland
/fileformat-v2-log-2.gz
PRE-CREATION
flume-ng-channels/flume-file-channel/src/test/resources/fileformat-v2-log-3.gz
PRE-CREATION
Diff: https://reviews.apache.org/r/6419/diff/
Testing
---
Added unit test passes.
Thanks,
Brock Noland
which found
a problem with the way we previously replayed logs. It passes with these
changes. I also tested on a two node flume installation stopping and restarting
a node several times.
Thanks,
Brock Noland
/flume/channel/file/TestLog.java
f286b66
Diff: https://reviews.apache.org/r/6459/diff/
Testing
---
unit tests pass
Thanks,
Brock Noland
eral times.
Thanks,
Brock Noland
ent21330>
probably should be thrown
- Brock Noland
On Aug. 6, 2012, 6:56 a.m., Denny Ye wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
deleted TRANSACTION_ID
field and when I replaced it, I did so in a more sensible place (fields above
methods). If you would it removed, feel free to say so.
- Brock
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6411/#review10118
---
I will provide an updated patch early next week.
- Brock Noland
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6411/#review10094
---
On Aug. 8, 2012, 5:51 p.m., Brock Noland wrote:
>
> ---
> This is an automatically generated e-mail. To re
e capacity small.
- Brock
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6411/#review10086
---
On Aug. 8, 2012, 5:51 p.m., Brock Noland wrote:
>
> ---
logs. It passes with these
changes. I also tested on a two node flume installation stopping and restarting
a node several times.
Thanks,
Brock Noland
-
All unit tests pass. A unit test is added, testRaceFoundInFLUME1432 which found
a problem with the way we previously replayed logs. It passes with these
changes. I also tested on a two node flume installation stopping and restarting
a node several times.
Thanks,
Brock Noland
asses with these
changes. I also tested on a two node flume installation stopping and restarting
a node several times.
Thanks,
Brock Noland
k/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/6578/#comment21663>
The HashMap is missing the generics.
- Brock Noland
On Aug. 13, 2012, 5:47 p.m., Yongcheng Li wrote:
>
> ---
> This is an automatically generated e-
Hi,
I think this makes sense. Can we clearly state and define a contract for
Public and Internal?
Brock
On Tue, Aug 14, 2012 at 10:38 AM, Mike Percy wrote:
> It seems we have reached a point in some of the Flume components where we
> want to add features but that means adding new interfaces to
Agreed it may not work for all existing classes we would like to make
internal. But it would work for things like FileChannel and MemoryChannel,
no?
Brock
On Wed, Aug 15, 2012 at 8:20 AM, Mike Percy wrote:
> Yeah, it sounds reasonable to me to use a subset of the same annotations
> that Hadoop
Ignore this comment. I guess if we are going to use the annotations there
is not need to use "internal" as well.
On Wed, Aug 15, 2012 at 8:28 AM, Brock Noland wrote:
> Agreed it may not work for all existing classes we would like to make
> internal. But it would work for things
Is it possible to get a general idea of the commands you ran push local
commits? I am no git ninja so I want to be sure I don't push any local
commits.
As a side, I have what I hope is a very conservative development model
below. If I am doing something dangerous, please let me know!
to work on
There are many ways to approach this problem and I think I have worked on a
at least one project which has tried them all:
Apache MRUnit => Kept versions in maven modules and eventually separate
source trees
Apache Hive (and Parquet ) => Used an extensive "shim" layer to allow Hive
to work with do
+1 (binding)
Checked sigs and hashes, manual inspection of various other aspects.
On Thu, Oct 13, 2016 at 12:54 PM, Hari Shreedharan
wrote:
> +1 (binding)
>
> Signatures and checksums look good
> Top level files are all good.
> Build runs fine, simple agent with Seq source, memory channel and H
annel/file/TestTransactionEventRecordV3.java
PRE-CREATION
Diff: https://reviews.apache.org/r/6680/diff/
Testing
---
Unit tests pass. I will be running some manual tests as well and will update
when I do so.
Thanks,
Brock Noland
hanks,
Brock Noland
pdate
when I do so.
Thanks,
Brock Noland
will update
when I do so.
Thanks,
Brock Noland
eEventQueue.java
<https://reviews.apache.org/r/6683/#comment22500>
we never close, why are we rechecking to see if it's open? Also does
fileChannel need to be volatile?
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java
<ht
> On Aug. 19, 2012, 10:51 p.m., Brock Noland wrote:
> > Nice patch! This looks to remove many of the probabilistic test failures of
> > testRestartLogReplayV{1,2} which is exactly what I was hoping for! A
> > couple of items to work on below but overall I think
/channel/file/FlumeEventQueue.java
<https://reviews.apache.org/r/6683/#comment22504>
should we lock this file to ensure two threads don't do this write at the
same time?
- Brock Noland
On Aug. 18, 2012, 8:40 a.m., Hari Shreed
> On Aug. 19, 2012, 10:51 p.m., Brock Noland wrote:
> > Nice patch! This looks to remove many of the probabilistic test failures of
> > testRestartLogReplayV{1,2} which is exactly what I was hoping for! A
> > couple of items to work on below but overall I think
> On Aug. 19, 2012, 10:51 p.m., Brock Noland wrote:
> > Nice patch! This looks to remove many of the probabilistic test failures of
> > testRestartLogReplayV{1,2} which is exactly what I was hoping for! A
> > couple of items to work on below but overall I think
> On Aug. 19, 2012, 10:51 p.m., Brock Noland wrote:
> > Nice patch! This looks to remove many of the probabilistic test failures of
> > testRestartLogReplayV{1,2} which is exactly what I was hoping for! A
> > couple of items to work on below but overall I think
> On Aug. 19, 2012, 10:51 p.m., Brock Noland wrote:
> > Nice patch! This looks to remove many of the probabilistic test failures of
> > testRestartLogReplayV{1,2} which is exactly what I was hoping for! A
> > couple of items to work on below but overall I think
.
- Brock Noland
On Aug. 21, 2012, 3:01 a.m., Hari Shreedharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
times without
failure.
Thanks,
Brock Noland
test has run several hundred times
without failure. All FileChannel unit tests have been run a dozen times without
failure.
Thanks,
Brock Noland
With this patch the test has run several hundred times
without failure. All FileChannel unit tests have been run a dozen times without
failure.
Thanks,
Brock Noland
/file/Log.java
9b13423
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java
3dededf
Diff: https://reviews.apache.org/r/6737/diff/
Testing
---
Unit tests pass.
Thanks,
Brock Noland
annel/file/TestIntegration.java
PRE-CREATION
Diff: https://reviews.apache.org/r/6744/diff/
Testing
---
unit tests pass
Thanks,
Brock Noland
a2b17
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java
PRE-CREATION
Diff: https://reviews.apache.org/r/6744/diff/
Testing
---
unit tests pass
Thanks,
Brock Noland
tests pass. I will be running some manual tests as well and will update
when I do so.
Thanks,
Brock Noland
sting
---
Unit tests pass. I will be running some manual tests as well and will update
when I do so.
Thanks,
Brock Noland
ly
- Brock Noland
On Aug. 23, 2012, 8:48 p.m., Brock Noland wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6680/
> --
/filechannel.proto
<https://reviews.apache.org/r/6680/#comment23102>
should be field 1
- Brock Noland
On Aug. 23, 2012, 8:48 p.m., Brock Noland wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6758/#review10736
---
Ship it!
Ship It!
- Brock Noland
On Aug. 24, 2012, 6:33 a.m
urning a checkpoint
taking many milliseconds.
With the advantage that is makes this more understandable.
- Brock Noland
On Aug. 24, 2012, 4:33 a.m., Hari Shreedharan wrote:
>
> ---
> This is an automatically generated e
/channel/file/TestFlumeEventQueue.java
<https://reviews.apache.org/r/6680/#comment23187>
This static hackery should be fixed
- Brock Noland
On Aug. 23, 2012, 8:48 p.m., Brock Noland wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6756/#review10750
---
Ship it!
Ship It!
- Brock Noland
On Aug. 24, 2012, 7:33 p.m
hanks,
Brock Noland
I would not mind trying it.
On Mon, Aug 27, 2012 at 12:29 AM, Jarek Jarcec Cecho wrote:
> I also do not have any prior experience with it, but I don't mind trying
> it out.
>
> Jarcec
>
> On Sun, Aug 26, 2012 at 10:48:10AM -0700, Hari Shreedharan wrote:
> > Hi,
> >
> > Since it has been some time
ected errors in the logs. I also ran the unit
tests ~200 times in a row and they passed.
- Brock Noland
On Aug. 24, 2012, 8:48 p.m., Brock Noland wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
hanks,
Brock Noland
and unit test added
Thanks,
Brock Noland
TestUtils class in
the FIleChannel package. Maybe that is an appropriate place to move the
functions?
- Brock Noland
On Aug. 27, 2012, 8:42 p.m., Hari Shreedharan wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6788/#review10894
---
Ship it!
Ship It!
- Brock Noland
On Aug. 27, 2012, 9:26 p.m
/ReplayHandler.java
14e2ff7
Diff: https://reviews.apache.org/r/6862/diff/
Testing
---
Unit tests pass
Thanks,
Brock Noland
/CheckpointRebuilder.java
<https://reviews.apache.org/r/6870/#comment23498>
we should only call writeCheckpoint if rebuild returns true, correct?
- Brock Noland
On Aug. 31, 2012, 8 a.m., Hari Shreedharan wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6870/#review10945
---
Ship it!
Ship It!
- Brock Noland
On Aug. 31, 2012, 3:50 p.m
Unit tests pass. I will be running some manual tests as well and will update
when I do so.
Thanks,
Brock Noland
.java
e64f856
pom.xml 52a842d
Diff: https://reviews.apache.org/r/6680/diff/
Testing
---
Unit tests pass. I will be running some manual tests as well and will update
when I do so.
Thanks,
Brock Noland
e
PRE-CREATION
Diff: https://reviews.apache.org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
N
Diff: https://reviews.apache.org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
ile-channel/src/test/resources/test.keystore
PRE-CREATION
Diff: https://reviews.apache.org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
. Eclipse can
automatically remove that for you. I created a "cleanup" profile which has on
"Remove trailing white spaces on all lines" selected. You can get to that by
right clicking on the code then going to Source and then Cleanup.
- Brock Noland
On Sept. 6, 2012, 4:05 p.m
as well.
- Brock Noland
On Sept. 6, 2012, 11:10 a.m., Ted Malaska wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
n api (like the method directly above).
flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java
<https://reviews.apache.org/r/6949/#comment23885>
Add the @Test annotation above this method and the extends TestCase is not
required.
> > not matter if the calling code changes it.
sure, fixed
> On Sept. 7, 2012, 12:56 a.m., Hari Shreedharan wrote:
> > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java,
> > line 690
> > <https://reviews
nd up replaying more events, but I think we need to
> > ensure we can match the checkpoint metadata to the checkpoint.
> >
> >
> >
Agreed, will do.
- Brock
---
This is an automatically genera
f they don't match, ask the user to delete the checkpoint
> > dir) and thus we can eliminate this situation. I think it is ok to have log
> > metadata and log file itself mismatched if we die in the middle of a
> > checkpoint, we just end up replaying more events, but I think we need t
/diff/
Testing
---
Unit tests pass. I will be running some manual tests as well and will update
when I do so.
Thanks,
Brock Noland
t.keystore
PRE-CREATION
Diff: https://reviews.apache.org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
sting
---
Unit tests pass. I will be running some manual tests as well and will update
when I do so.
Thanks,
Brock Noland
and will update
when I do so.
Thanks,
Brock Noland
iews.apache.org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
e
PRE-CREATION
Diff: https://reviews.apache.org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
FLUME-1487 was committed which changes the internal format of the
FileChannel to protocol buffers. So compiling requires protoc. This is
a pretty easy build and the source is available here:
http://code.google.com/p/protobuf/
https://issues.apache.org/jira/browse/FLUME-1487
Brock
--
Apache MRUni
PRE-CREATION
Diff: https://reviews.apache.org/r/6946/diff/
Testing
---
Unit tests added and pass.
Thanks,
Brock Noland
/TestFileChannelRestart.java
PRE-CREATION
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRollback.java
PRE-CREATION
Diff: https://reviews.apache.org/r/6968/diff/
Testing
---
unit tests pass
Thanks,
Brock Noland
/diff/
Testing
---
Unit tests pass
Thanks,
Brock Noland
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6949/#review11248
---
Ship it!
Ship It!
- Brock Noland
On Sept. 10, 2012, 2:06 p.m
1 - 100 of 1569 matches
Mail list logo
