Contributor role

Hi! I just started on the Hive team at Cloudera and would like to be assigned to a contributor role. My username is pvary. Thanks, Peter

Re: Assign JIRA to myself

gt; > On Wed, Jun 15, 2016 at 11:22 PM, Peter Vary <pv...@cloudera.com> wrote: > >> Hi, >> >> Thanks for the fast answer. >> Who should I ask to add me as a contributor? 6 days ago I sent here a >> request, but have not got any reply. >> >>

Review Request 48798: HIVE-14001: beeline doesn't give out an error when takes either "-e" or "-f" in command instead of both

Diff: https://reviews.apache.org/r/48798/diff/ Testing --- Unittest with both arguments present. Manual testing Thanks, Peter Vary

RE: Assign JIRA to myself

or. Please see additional information at > https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-BecomingaContributor > > > > *From:* Peter Vary [mailto:pv...@cloudera.com] > *Sent:* Thursday, June 16, 2016 12:15 AM > *To:* dev@hive.apache.org > *Su

Review Request 49948: HIVE-14195: HiveMetaStoreClient getFunction() does not throw NoSuchObjectException

/metastore/HiveMetaStore.java 3cbcc8f Diff: https://reviews.apache.org/r/49948/diff/ Testing --- Manually, and modified the apropriate unit tests Thanks, Peter Vary

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50510/#review143886 ------- On July 27, 2016, 4:26 p.m., Peter Vary wrote: > > -

Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

/src/test/org/apache/hive/beeline/TestBeeLineOpts.java PRE-CREATION Diff: https://reviews.apache.org/r/50510/diff/ Testing --- Manually + unit test Thanks, Peter Vary

Permission to edit wiki

Hi, I would like to be granted permissions to edit the wiki page so that I can document the configuration changes there. Thanks in advance, Peter

Re: Permission to edit wiki

Sorry, I forgot the username. It is pvary. Thanks, Peter 2016. júl. 30. 13:25 ezt írta ("Peter Vary" <pv...@cloudera.com>): > Hi, > > I would like to be granted permissions to edit the wiki page so that I can > document the configuration changes there. > > Thanks in advance, > Peter >

Re: Review Request 49882: HIVE-14146: Column comments with "\n" character "corrupts" table metadata

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/49882/#review144128 ------- On July 11, 2016, 1:43 p.m., Peter Vary wrote: > > --- > This is an automatically generated e

Re: Review Request 50982: HIVE-14345:Beeline result table has erroneous characters

beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java (line 99) <https://reviews.apache.org/r/50982/#comment211753> nit: I think, you should remove this line from the final patch - Peter Vary On Aug. 11, 2016, 2:19 p.

Re: Review Request 50768: HIVE-14415 Upgrade qtest execution framework to junit4 - TestPerfCliDriver

g/r/50768/#comment210852> nit extra line ql/src/test/templates/TestPerfCliDriver.vm (line 84) <https://reviews.apache.org/r/50768/#comment210853> nit extra line ql/src/test/templates/TestPerfCliDriver.vm (line 163) <https://reviews.apache.org/r/50768/#comment210856>

Re: Review Request 50906: HIVE-14444 Upgrade qtest execution framework to junit4 - migrate most of them

> On Aug. 9, 2016, 12:14 a.m., Peter Vary wrote: > > Hi Zoltan, > > > > Thanks for the patch, I can see, that you were working on it even on the > > weekend. > > > > Please help me to understand the components a little more, so I could help > >

Re: Review Request 50982: HIVE-14345:Beeline result table has erroneous characters

/beeline/TestTableOutputFormat.java (lines 50 - 51) <https://reviews.apache.org/r/50982/#comment212017> nit: should be one line - Peter Vary On Aug. 12, 2016, 8:36 p.m., Miklos Csanady wrote: > > --- > This is a

Re: Review Request 49655: HIVE-12646: beeline and HIVE CLI do not parse ; in quote properly

d consider, that the comment fields could contain escaped ' characters, like the one below: ``` create table escape_comments_tbl1 (col1 string comment 'ab\';\'); ``` Thanks, Peter - Peter Vary On July 12, 2016, 4:04 a.m., Sahil Ta

Review Request 49984: HIVE-14215: Displaying inconsistent CPU usage data with MR execution engine

a reliable test case for this, I am open for every suggestions. Thanks, Peter Thanks, Peter Vary

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

/beeline/TestBeeLineWithArgs.java ecfeddb jdbc/src/java/org/apache/hive/jdbc/Utils.java 7ea6309 Diff: https://reviews.apache.org/r/49498/diff/ Testing --- Unit tests for the hooks, and the configuration option Manual test in remote, and embedded mode Thanks, Peter Vary

Re: [ANNOUNCE] New PMC Member : Jesus

Congratulations Jesus! > On Jul 18, 2016, at 6:55 AM, Wei Zheng wrote: > > Congrats Jesus! > > Thanks, > > Wei > > > > > > > > On 7/17/16, 14:29, "Sushanth Sowmyan" wrote: > >> Good to have you onboard, Jesus! :) >> >> On Jul 17, 2016

Re: [ANNOUNCE] New PMC Member : Pengcheng

Congratulations Pengcheng! > On Jul 18, 2016, at 6:55 AM, Wei Zheng wrote: > > Congrats Pengcheng! > > Thanks, > > Wei > > > > > > > On 7/17/16, 16:01, "Xuefu Zhang" wrote: > >> Congrats, PengCheng! >> >> On Sun, Jul 17, 2016 at 2:28 PM,

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

ly, so it is independent of the previous tests - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49498/#review142595 ------

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

s it would be > > still beneficial to save that extra query call. Done as advised - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49498/#review141025 ----

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

re an option to parse the database from the > > 'use' command on success to avoid the wasteful extra query, or was there > > some instances that it did not work as expected? > > Peter Vary wrote: > Actually we could parse the use, and the connect commands. The use > pars

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

in remote, and embedded mode Thanks, Peter Vary

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

/TestBeeLineWithArgs.java ecfeddb jdbc/src/java/org/apache/hive/jdbc/Utils.java 7ea6309 Diff: https://reviews.apache.org/r/49498/diff/ Testing --- Unit tests for the hooks, and the configuration option Manual test in remote, and embedded mode Thanks, Peter Vary

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

----- On July 1, 2016, 3:08 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49498/ > ---

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

gt; > > > What do you think about doing an or, say if the command line opts is > > set, or the hive.cli.pring.current.db is in the properties file. (i guess > > now there is beeline.properties) > > Peter Vary wrote: > To tell the truth, I did not kn

Review Request 49748: HIVE-14100: current_user() returns invalid information

/udf_logged_in_user.q.out PRE-CREATION Diff: https://reviews.apache.org/r/49748/diff/ Testing --- Manually and unit test Thanks, Peter Vary

Re: Review Request 49782: HIVE-14170: Beeline IncrementalRows should buffer rows and incrementally re-calculate width if TableOutputFormat is used

think we should add the new parameter to beeline/src/main/resources/BeeLine.properties, and later in the documentation. Keeping in mind, that I am new to hive, I think you patch is otherwise good. Thanks, Peter - Peter Vary On July 8, 2016, 8 p.m., Sahil Takiar wrote

Review Request 49882: HIVE-14146: Column comments with "\n" character "corrupts" table metadata

/escape_comments.q.out PRE-CREATION Diff: https://reviews.apache.org/r/49882/diff/ Testing --- New unit test and manually Thanks, Peter Vary

Re: Review Request 49882: HIVE-14146: Column comments with "\n" character "corrupts" table metadata

/queries/clientpositive/escape_comments.q PRE-CREATION ql/src/test/results/clientpositive/escape_comments.q.out PRE-CREATION Diff: https://reviews.apache.org/r/49882/diff/ Testing --- New unit test and manually Thanks, Peter Vary

Re: Review Request 50896: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters

(line 106) <https://reviews.apache.org/r/50896/#comment211330> nit Would not be better to change the type of the DEFAULT_DELIMITER_DSV to String? - Peter Vary On Aug. 8, 2016, 3:13 p.m., Marta Kuczora

Re: Review Request 50906: HIVE-14444 Upgrade qtest execution framework to junit4 - migrate most of them

. Thanks, Peter - Peter Vary On Aug. 8, 2016, 8:47 p.m., Zoltan Haindrich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 50906: HIVE-14444 Upgrade qtest execution framework to junit4 - migrate most of them

> On Aug. 9, 2016, 12:14 a.m., Peter Vary wrote: > > Hi Zoltan, > > > > Thanks for the patch, I can see, that you were working on it even on the > > weekend. > > > > Please help me to understand the components a little more, so I could help > >

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

, and the configuration option Manual test in remote, and embedded mode Thanks, Peter Vary

Re: [Announce] New Hive Committer - Mohit Sabharwal

Congratulations Mohit! 2016. júl. 1. 19:10 ezt írta ("Vihang Karajgaonkar" ): > Congratulations Mohit! > > > On Jul 1, 2016, at 10:05 AM, Chao Sun wrote: > > > > Congratulations Mohit! Good job! > > > > Best, > > Chao > > > > On Fri, Jul 1, 2016 at 9:57 AM,

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49498/#review140385 --- On júl. 1, 2016, 3:08 du, Peter Vary wrote: > >

Re: Review Request 50982: HIVE-14345:Beeline result table has erroneous characters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50982/#review145792 --- Thanks Miklos! - Peter Vary On Aug. 13, 2016, 5:34 a.m

Re: Review Request 50982: HIVE-14345:Beeline result table has erroneous characters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50982/#review145793 --- Ship it! Ship It! - Peter Vary On Aug. 13, 2016, 5:34 a.m

Re: Review Request 50896: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50896/#review145993 --- Ship it! Hi Marta, Thanks. LGTM (non binding) Peter - Peter

Re: Missing ASF license headers

Hi, The patch is waiting for review, commit. Could someone take a look at it? https://issues.apache.org/jira/browse/HIVE-15749 <https://issues.apache.org/jira/browse/HIVE-15749> Thanks, Peter > On Jan 27, 2017, at 9:28 PM, Peter Vary <pv...@cloudera.com> wrote: > > T

Re: Review Request 56290: HIVE-15795: Add Accumulo Index Table Support

/TestAccumuloRangeGenerator.java: Recompile with -Xlint:unchecked for details. Thanks, Peter - Peter Vary On Feb. 6, 2017, 4:51 p.m., Mike Fagan wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 56334: HIVE-12767: Implement table property to address Parquet int96 timestamp bug

gt; nit: indentation? ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java (line 226) <https://reviews.apache.org/r/56334/#comment236256> Would not be this flaky? At least dependent on the tester local settings? What happens when running it on Special

Re: Review Request 55846: HIVE-15604: Improve contents of qfile test output

iews.apache.org/r/55846/#comment234169> Why do we change the error aggregation here? - Peter Vary On Jan. 23, 2017, 4:13 p.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generate

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

ine is longer than 100 characters (found 136). I do not think that we are able to keep files shorter than 2000 lines in Hive, so I will remove that check, but AFAIK we try to keep the line length to 100. Or should I change that too? Thanks, Peter - Peter Vary On Jan. 26, 2017, 8:09 p.m.,

Missing ASF license headers

Hi, I am working on enabling YETUS pre-commit test so it can help in the reviews. I was running the ASF license check, and I have found the following files are missing the ASF header: common/src/java/org/apache/hadoop/hive/common/classification/RetrySemantics.java

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

> On jan. 27, 2017, 3:37 du, Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > find

Re: Missing ASF license headers

Thanks Owen, I will do that! Peter 2017. jan. 27. 19:02 ezt írta ("Owen O'Malley" <omal...@apache.org>): > Just file a jira with the patch that adds the headers. > > .. Owen > > On Fri, Jan 27, 2017 at 8:08 AM, Peter Vary <pv...@cloudera.com> wrote: >

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

> On Jan. 27, 2017, 3:37 p.m., Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > f

Re: Review Request 55816: HIVE-15680: Incorrect results when hive.optimize.index.filter=true and same ORC table is referenced twice in query

pr == null ) {:38: warning: ')' is preceded with whitespace. Running Findbugs, ASF header check, etc did not found any new problems. Thanks for the patch! Peter - Peter Vary On Jan. 28, 2017, 9:41 p.m., Anthony

Re: Review Request 56025: HIVE-15723 Hive should report a warning about missing table/column statistics to user.

did not found any new problems. Thanks for the patch! Peter - Peter Vary On Jan. 30, 2017, 10:30 a.m., Remus Rusanu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55932/#review162964 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2017, 3:03 p.m

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

thm for removing passwords it might be a good idea to have a test for it. Thanks, Peter - Peter Vary On Feb. 21, 2017, 9:01 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail.

Re: [ANNOUNCE] New committer: Zoltan Haindrich

Congratulations Zoltan! Well done! :) > On Feb 22, 2017, at 7:00 AM, Zoltan Haindrich wrote: > > Thank you everyone! > > It's really an honor to be associated with this project! > > About me: I've a pretty broad spectrum of interest in general, I always want > to clearly

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

> On Feb. 22, 2017, 10:20 a.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java, lines 398-400 > > <https://reviews.apache.org/r/56763/diff/1-2/?file=1637751#file1637751line398> > > > > As far as I know the Java String is immutable, whi

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

Is it possible to use miniHS2 instead? > > Peter Vary wrote: > This is a very good idea! I think we should do that... > The same applies here as above - tried to keep my changes minimal - Shall > we change this here, or in a followup jira to separate the changes? Checked

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

ter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review166031 --- On Oct. 19, 2016, 1:39 p.m., Peter V

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

Thanks, Peter Vary

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

ng what the filter regex is doing to > > make it easier to understand? > > Peter Vary wrote: > Will do - This is for removing the timestamp from the begining of the log > lines Done > On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

} } But I have tried, and your version is performed better on local fs with 10k files, 4 depth (year/month/day/job). 2800 ms vs. 3000 ms I still think that my version is more readable, but speed is speed :D - Peter Vary On Feb. 23, 2017, 8:15 p.m

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

Not sure why we need this? Can you please add some comment to help us > > understand > > Peter Vary wrote: > To be honest, I was aiming for the minimal change, and did not try to run > without it. Will check - my guess is that the HiveServer configured to use ZK > cl

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

Just a question: Why we are removing the message? Was it missleading in some case? - Peter Vary On Feb. 16, 2017, 6:22 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 51251: HIVE-14588: Add S3 credentials to the hidden configuration variable supported on HIVE-14207

3097) <https://reviews.apache.org/r/51251/#comment212587> nit: delete extra spaces - Peter Vary On Aug. 19, 2016, 8:13 p.m., Gabor Szadovszky wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 51287: The ConsoleReader.readLine method never echoes back the executed line. Instead, Beeline.info is used, which is redirected to stderr with other messages. On interactive mode b

e 992) <https://reviews.apache.org/r/51287/#comment212753> nit space between ){ beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 993) <https://reviews.apache.org/r/51287/#comment212751> nit: spaces after ',' - Peter Vary On Aug. 22, 2016, 3:15 p

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

Diff: https://reviews.apache.org/r/52978/diff/ Testing --- Manually on my computer several runs. Waiting for the QA tests Thanks, Peter Vary

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

! LGTM (non binding) - Peter Vary On Feb. 24, 2017, 7:20 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 51397: HIVE-14536 Unit test code cleanup

ill update the patch if needed Thanks, Peter Vary

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

e current number Run the testcases from intellij, there were some problems (missing TEST_HADOOP_CLASSPATH), but most of the testcases/queries are ok. Waiting for the QA, to validate the test results and I will update the patch if needed Thanks, Peter Vary

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

nt214920> Should not this be static? beeline/src/java/org/apache/hive/beeline/hs2connection/HiveSiteHS2ConnectionFileParser.java (line 57) <https://reviews.apache.org/r/51593/#comment214921> It this is public, do we need the VisibleForTesting annotation? Thanks, Peter - Peter Var

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

k. Waiting for the QA, to validate the test results and I will update the patch if needed Thanks, Peter Vary

Re: Remote debugging of HIVE code from Intellij

Hi Ranjan, I am not sure about what you are about to test, but I think TestPositiveCliDriver is not a valid test name, so not test run in your case. Regards, Peter > On Sep 8, 2016, at 4:08 AM, Ranjan Banerjee wrote: > > Hi, > I am trying to remote debug HIVE code

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

/51593/#comment215364> I might prefer not to expose the file location on the interface, if it is not absolutely required. What do you think of using instead of this a new public method: public boolean isConfigExists()? - Peter Vary On Sept. 6, 2016, 11:53 p.m., V

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

hcat-site.xml" Thanks for the catch. Any other idea? I might have missed something more - hcatalog is new for me. Thanks, Peter - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review147068 ---

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

- checked both Thanks, Peter Vary

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

ight? > > The S3 credentials I think could be defined in the hdfs configuration > > but they are specified in HiveConf hiddenList, they should be stripped and > > have we tested them? > > Peter Vary wrote: > Thanks Chaoyu! > > You are absolutely

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review147400 ------- On Aug. 30, 2016, 6:34 a.m., Peter Vary wrote: > > --

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

ight? > > The S3 credentials I think could be defined in the hdfs configuration > > but they are specified in HiveConf hiddenList, they should be stripped and > > have we tested them? > > Peter Vary wrote: > Thanks Chaoyu! > > You are absolutely

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

r)? > > Is it better to refactor the maskIfPassword from ql to common package? > > Peter Vary wrote: > I did not have to add any new dependency to the pom.xml - the Utilities > was just there :) > > So I checked it now, and it is coming from hive-hcat

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

8e5c0da ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 0786f9b Diff: https://reviews.apache.org/r/51435/diff/ Testing --- Manually - checked both Thanks, Peter Vary

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

ight? > > The S3 credentials I think could be defined in the hdfs configuration > > but they are specified in HiveConf hiddenList, they should be stripped and > > have we tested them? > > Peter Vary wrote: > Thanks Chaoyu! > > You are absolutely

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

8e5c0da ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 0786f9b Diff: https://reviews.apache.org/r/51435/diff/ Testing --- Manually - checked both Thanks, Peter Vary

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review148335 --- Ship it! LGTM (non binding) - Peter Vary On Sept. 7, 2016

Re: Review Request 51468: HIVE-14532 - enable qtests from ide - eclipse

> On Aug. 28, 2016, 3:07 p.m., Peter Vary wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java, > > lines 80-84 > > <https://reviews.apache.org/r/51468/diff/1/?file=1487189#file1487189line80> > > > > It is

Re: Remote debugging of HIVE code from Intellij

Thank you so much for pointing it out. I ran -Dtest=TestCliDriver and it > worked! > On a sidenote I would like to contribute to the project. Is there any > issue you would suggest that I could look into. > > Thanks > Ranjan > > -Original Message- > From

Re: Review Request 52684: HIVE-14754: Track the queries execution lifecycle times

nt but creating a new SessionState runs a quite big chunk of code. Is it possible to use only one SessionState in the test, and close() it at tearDown? - Peter Vary On Oct. 10, 2016, 12:16 p.m., Barna Zsombor Klara wrote: > >

Re: Review Request 49882: HIVE-14146: Column comments with "\n" character "corrupts" table metadata

://reviews.apache.org/r/49882/diff/ Testing --- New unit test and manually Thanks, Peter Vary

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

hat might be an overkill :) metastore/src/java/org/apache/hadoop/hive/metastore/HMSMetricsListener.java (lines 48 - 50) <https://reviews.apache.org/r/52084/#comment217530> If refactoring, this 3 lines might be put into an util method, to avoid code duplication :). Not that important, just an

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149828 --- LGTM, thanks for the patch - Peter Vary On Sept. 21, 2016, 3

Review Request 52122: HIVE-9423 - HiveServer2: Implement some admission control mechanism for graceful degradation when resources are exhausted

, Peter Vary

Re: Review Request 52029: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

ng line (100 char) service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java (line 252) <https://reviews.apache.org/r/52029/#comment217126> nit: name (testAciveSessionTimeMetrics) - Peter Va

Re: Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/#review149648 --- LGTM, Thanks for the patch - Peter Vary On Sept. 20, 2016, 10

Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some admission control mechanism for graceful degradation when resources are exhausted

: https://reviews.apache.org/r/52122/diff/ Testing --- Manual, and added unit test depending on the exception code Thanks, Peter Vary

Re: Review Request 51193: HIVE-14358: Add metrics for number of queries executed for each execution engine (mr, spark, tez)

che.org/r/51193/#comment212469> nit: I think imports should be specific as per coding guideline ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java (lines 43 - 44) <https://reviews.apache.org/r/51193/#comment212468> nit: I think imports should be specific as per co

Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java 201e647 Diff: https://reviews.apache.org/r/51435/diff/ Testing --- Manually - checked both Thanks, Peter Vary

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

_CLASSPATH), but most of the testcases/queries are ok. Waiting for the QA, to validate the test results and I will update the patch if needed Thanks, Peter Vary

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

individual > > tests, or get things working in the IDE. I know Zoltan was driving towards > > getting tests working via the IDE - I don't know how this affects that > > effort. > > Peter Vary wrote: > Hi Siddharth, > > With Zoltan, we have the s

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

s file to enable Eclipse test runs? Otherwise looks good to me. - Peter Vary On Aug. 26, 2016, 10:13 p.m., Zoltan Haindrich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

ter this comment: ${basedir}/${hive.path.to.root}/data/files What do you think? Thanks for your hard work! I really appreciate you working on stuff even on the weekends! - Peter Vary On Aug. 26, 2016, 10:13 p.m., Zoltan

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

t a hadoop jar on the classpath, which means this calculation will fail. If you think after these reasoning you still prefer to throw exceptions, feel free to reopen the issue - I will think this through too tonight :) > On Aug. 25, 2016, 10:46 p.m., Zoltan Haindrich wrote: > > itests/uti

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

e problems (missing TEST_HADOOP_CLASSPATH), but most of the testcases/queries are ok. Waiting for the QA, to validate the test results and I will update the patch if needed Thanks, Peter Vary

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

e the decision is up to the reviewers. Thanks, Peter - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146909 ----

  1   2   3   4   5   6   7   8   9   >