Re: Review Request 65210: HIVE-18480 Create tests for function related methods

> On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 236 (patched) > > > > > > Should we be filing JIRAs for

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

> On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > A few comments, in general the tests look very thorough. Nice work! Thanks for the review Sahil! > On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > >

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 24, 2018, 10:52 a.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196065 --- A few comments, in general the tests look very thorough. Nice

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196031 --- Ship it! Ship It! - Adam Szita On Jan. 23, 2018, 4:47 p.m.,

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

> On Jan. 23, 2018, 2:07 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 103 (patched) > > > > > > Should we extract > >

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 23, 2018, 4:47 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196003 --- Fix it, then Ship it! Looks good Peter, thanks for the patch!

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review195981 --- Ship it! Ship It! - Marta Kuczora On Jan. 22, 2018, 2:33

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

> On Jan. 22, 2018, 1:41 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 409 (patched) > > > > > > After dropping the functions,

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 22, 2018, 2:33 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review195897 --- Thanks a lot Peter for the patch! It looks good to me, I only