Il gio 3 gen 2019, 22:37 Tibor Digana ha scritto:
> Why the build cannot be triggered on GitHub or PR?
> It's only a URL.
>
You are right, github gives special refs which represents the branch of the
forked repo, like pull/123/head.
The problem is that our CI is configured for gitbox and not
I am doing #2.
This means I create a GitBox branch or I run it on my own PC. Not a problem
at all because usually the contributor does not complete it and I have to
add some test or clarify the change in documentation. Sometime I have to
rework the PR even if the idea was good, and I have to
On Thu 3 Jan 2019 at 21:37, Tibor Digana wrote:
> Why the build cannot be triggered on GitHub or PR?
> It's only a URL.
> If you see the frequency of PRs in Surefire, 1 or 2 PRs/month, this should
> not be a problem since the Windows build takes 1.5 hour and Linux 1 hour.
> Taking JDK 7 and 11,
Why the build cannot be triggered on GitHub or PR?
It's only a URL.
If you see the frequency of PRs in Surefire, 1 or 2 PRs/month, this should
not be a problem since the Windows build takes 1.5 hour and Linux 1 hour.
Taking JDK 7 and 11, and one Maven version (3.5) is usually enough on Git
On Thu 3 Jan 2019 at 20:52, Tibor Digana wrote:
> I already lost the point of this thread.
> Still the disk space problem on Windows executors in ASF Jenkins?
> If it's this issue, then why the workspace is not investigated directly on
> the system with remote access?
> Jenkins is very good tool
Il gio 3 gen 2019, 21:52 Tibor Digana ha scritto:
> I already lost the point of this thread.
>
We are trying to figure out how to give better support for new
contributions, the first point is to give feedback as soon as possible (an
automatic build is the top)
Enrico
Still the disk space
I already lost the point of this thread.
Still the disk space problem on Windows executors in ASF Jenkins?
If it's this issue, then why the workspace is not investigated directly on
the system with remote access?
Jenkins is very good tool and I do not want to use Travis but Travis is one
step
On Thu 3 Jan 2019 at 18:03, Enrico Olivelli wrote:
> Il gio 3 gen 2019, 17:38 Mickael Istria ha scritto:
>
> > Hi,
> >
> > I think this discussion is diverging into "trying TravisCI for some
> > plugins" and is loosing focus on the initial question of how to improve
> the
> > build+test flow to
Il gio 3 gen 2019, 17:38 Mickael Istria ha scritto:
> Hi,
>
> I think this discussion is diverging into "trying TravisCI for some
> plugins" and is loosing focus on the initial question of how to improve the
> build+test flow to get faster feedback as a contributor or as a reviewer.
> Can the
Hi,
I think this discussion is diverging into "trying TravisCI for some
plugins" and is loosing focus on the initial question of how to improve the
build+test flow to get faster feedback as a contributor or as a reviewer.
Can the GitHub PR builder plugin be enabled on Maven Core ? Committers
Il gio 3 gen 2019, 08:19 Hervé BOUTEMY ha scritto:
> yes, on our 100 Git repos [1], 90% should be easy to run on any CI with
> minimum configuration and resources
>
> then there is Maven core and complex plugins (like Surefire) which are not
> the
> same story
>
> if someone wants to test other
yes, on our 100 Git repos [1], 90% should be easy to run on any CI with
minimum configuration and resources
then there is Maven core and complex plugins (like Surefire) which are not the
same story
if someone wants to test other toolings to show some useful feature we don't
get in our current
Il giorno mer 2 gen 2019 alle ore 15:34 Vladimir Sitnikov
ha scritto:
>
> Enrico> For instance maven-surefire
> integration tests take 2 hours.
> In general I see Travis (free edition) does not offer many resources.
>
> Each Travis job is limited by 50 minutes, however one can split tests into
>
Enrico> For instance maven-surefire
integration tests take 2 hours.
In general I see Travis (free edition) does not offer many resources.
Each Travis job is limited by 50 minutes, however one can split tests into
multiple jobs, so it will run fine.
Vladimir
Il giorno mer 2 gen 2019 alle ore 15:12 Vladimir Sitnikov
ha scritto:
>
> Enrico> Probably Travis won't be able to run our ITs, at least the free
> version
>
> Why do you think so?
Because Maven CI jobs are huge. For instance maven-surefire
integration tests take 2 hours.
In general I see Travis
Enrico> Probably Travis won't be able to run our ITs, at least the free
version
Why do you think so?
Vladimir
Il dom 30 dic 2018, 00:53 Mickael Istria ha scritto:
> On Saturday, December 29, 2018, Stephen Connolly <
> stephen.alan.conno...@gmail.com> wrote:
> >
> > I think we could easily use TravisCI or one of the cloud CI vendors to
> > perform trial builds of PRs on GitHub.
>
>
> Good. So at this
On Saturday, December 29, 2018, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:
>
> I think we could easily use TravisCI or one of the cloud CI vendors to
> perform trial builds of PRs on GitHub.
Good. So at this point, it's only a matter of writing a .travis.yaml file
in the repo, or
Stephen > Are you sure?
I've just created a dummy account and "approval" does not make merge button
magically appear.
If you have a couple of minutes, please make a PR (I'll approve it shortly)
to https://github.com/vlsi/KE-complex_modifications
Note: you can click "edit" button in GitHub UI for
Karl Heinz Marbaise > The user community is very big but unfortunately the
people who are
Karl Heinz Marbaise > willing to help is not that big...
Can I (ab)use the thread a bit?
One of the issues I run into with Maven is "it takes ages for repeated
build when nothing has changed".
Of course
On Sat, 29 Dec 2018 at 20:41, Mickael Istria wrote:
> I'mglad to see that PR build/merge discussed, it seems to have a good
> potential value for many in simplifying it.
>
> FWIW, at Eclipse Foundation, similar questions were faced and risks
> identified. The result is that at the moment, all
On Sat, 29 Dec 2018 at 18:56, Vladimir Sitnikov
wrote:
> Stephen> Well on other GitHub orgs i’ve seen PR author has Merge
> button once PR is
> Stephen> approved by someone with push rights to the repo... until
> they add a commit
> Stephen> or the merge result changes
>
> It does not work the
> And, again, TravisCI also does the same in a decent way, with the benefit
> of worrying less about underlying infra and security, and only drawback of
> being discoupled from a specific infra (is it really a drawback?)
Just in case: Apache Calcite uses both Travis CI and AppVeryor. It just
I'mglad to see that PR build/merge discussed, it seems to have a good
potential value for many in simplifying it.
FWIW, at Eclipse Foundation, similar questions were faced and risks
identified. The result is that at the moment, all PRs from anyone can be
built on Eclipse infra without much
Stephen> Well on other GitHub orgs i’ve seen PR author has Merge
button once PR is
Stephen> approved by someone with push rights to the repo... until
they add a commit
Stephen> or the merge result changes
It does not work the way you describe.
1) By default GitHub defaults to "Base permissions"
On Sat 29 Dec 2018 at 18:19, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:
>
>
> On Sat 29 Dec 2018 at 18:06, Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com> wrote:
>
>> Stephen> Nah. Once committers have approved the PR then the PR can be
>> merged by the
>> Stephen> creator of
On Sat 29 Dec 2018 at 18:06, Vladimir Sitnikov
wrote:
> Stephen> Nah. Once committers have approved the PR then the PR can be
> merged by the
> Stephen> creator of the PR even if not a committer... at least that’s
> the default
> Stephen> way GitHub PRs work
>
> By default one needs push rights
Stephen> Nah. Once committers have approved the PR then the PR can be
merged by the
Stephen> creator of the PR even if not a committer... at least that’s
the default
Stephen> way GitHub PRs work
By default one needs push rights on the repository to merge PRs.
"Approval" changes nothing. "PR
On Sat 29 Dec 2018 at 17:16, Enrico Olivelli wrote:
> Il sab 29 dic 2018, 17:25 Stephen Connolly <
> stephen.alan.conno...@gmail.com>
> ha scritto:
>
> > On Sat 29 Dec 2018 at 16:20, Stephen Connolly <
> > stephen.alan.conno...@gmail.com> wrote:
> >
> > >
> > >
> > > On Sat 29 Dec 2018 at 15:18,
Hi,
On 29/12/18 18:16, Enrico Olivelli wrote:
Il sab 29 dic 2018, 17:25 Stephen Connolly
ha scritto:
On Sat 29 Dec 2018 at 16:20, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:
On Sat 29 Dec 2018 at 15:18, Enrico Olivelli
wrote:
Il sab 29 dic 2018, 15:17 Stephen Connolly
Il sab 29 dic 2018, 17:25 Stephen Connolly
ha scritto:
> On Sat 29 Dec 2018 at 16:20, Stephen Connolly <
> stephen.alan.conno...@gmail.com> wrote:
>
> >
> >
> > On Sat 29 Dec 2018 at 15:18, Enrico Olivelli
> wrote:
> >
> >> Il sab 29 dic 2018, 15:17 Stephen Connolly <
> >>
On Sat 29 Dec 2018 at 16:20, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:
>
>
> On Sat 29 Dec 2018 at 15:18, Enrico Olivelli wrote:
>
>> Il sab 29 dic 2018, 15:17 Stephen Connolly <
>> stephen.alan.conno...@gmail.com>
>> ha scritto:
>>
>> > There is a security issue with building
On Sat 29 Dec 2018 at 15:18, Enrico Olivelli wrote:
> Il sab 29 dic 2018, 15:17 Stephen Connolly <
> stephen.alan.conno...@gmail.com>
> ha scritto:
>
> > There is a security issue with building PRs automatically.
> >
> > I can see about adding PR discovery to the existing ASF gitbox plugin,
>
Il sab 29 dic 2018, 15:17 Stephen Connolly
ha scritto:
> There is a security issue with building PRs automatically.
>
> I can see about adding PR discovery to the existing ASF gitbox plugin, but
> we’d need committers to ok the build and have reviewed the code as the PR
> could contain attacks
There is a security issue with building PRs automatically.
I can see about adding PR discovery to the existing ASF gitbox plugin, but
we’d need committers to ok the build and have reviewed the code as the PR
could contain attacks to be run from ASF hardware... which is why we don’t
build PRs at
Hervè,
This is the plugin
https://wiki.jenkins.io/display/JENKINS/GitHub+Branch+Source+Plugin?desktop=true=unmigrated-inline-wiki-markup
I see our "maven-box" is using some special "Scan Apache Hosted Git
Folder Triggers" source
(https://builds.apache.org/job/maven-box/configure)
In the Jenkins
Le samedi 29 décembre 2018, 12:40:20 CET Enrico Olivelli a écrit :
> Il sab 29 dic 2018, 12:37 Mickael Istria ha scritto:
> > On Sat, Dec 29, 2018 at 12:01 PM Hervé BOUTEMY
> >
> > wrote:
> > > But in both cases, currently, there is no automatic GitHub PR
> >
> > integration:
> > > Maven
Le samedi 29 décembre 2018, 12:37:36 CET Mickael Istria a écrit :
> On Sat, Dec 29, 2018 at 12:01 PM Hervé BOUTEMY
>
> wrote:
> > But in both cases, currently, there is no automatic GitHub PR integration:
> > Maven committers need to create a branch in the official repository to
> > benefit
> >
Il sab 29 dic 2018, 12:37 Mickael Istria ha scritto:
> On Sat, Dec 29, 2018 at 12:01 PM Hervé BOUTEMY
> wrote:
>
> > But in both cases, currently, there is no automatic GitHub PR
> integration:
> > Maven committers need to create a branch in the official repository to
> > benefit
> > from ASF
On Sat, Dec 29, 2018 at 12:01 PM Hervé BOUTEMY
wrote:
> But in both cases, currently, there is no automatic GitHub PR integration:
> Maven committers need to create a branch in the official repository to
> benefit
> from ASF Jenkins build
>
Ah ok, I wasn't aware the GitHub repo was "unofficial"
Il sab 29 dic 2018, 12:19 Karl Heinz Marbaise ha
scritto:
> Hi Mickael,
>
> On 29/12/18 09:57, Mickael Istria wrote:
> > On Mon, Dec 24, 2018 at 5:21 PM Karl Heinz Marbaise
> > wrote:
> >
> >> Hi Mickael,
> >>
> >
> > Hi,
> >
> > I have to summarize this simply.
> >
> > I was confused about how
Hi Mickael,
On 29/12/18 09:57, Mickael Istria wrote:
On Mon, Dec 24, 2018 at 5:21 PM Karl Heinz Marbaise
wrote:
Hi Mickael,
Hi,
I have to summarize this simply.
I was confused about how automated tests are running or not. If I look at
https://github.com/apache/maven/pull/194 , I do not
Le samedi 29 décembre 2018, 09:57:30 CET Mickael Istria a écrit :
> On Mon, Dec 24, 2018 at 5:21 PM Karl Heinz Marbaise
>
> wrote:
> > Hi Mickael,
>
> Hi,
>
> I have to summarize this simply.
>
> > This is no lack of interest in any kind. It is simply a lack of time of
> > the
On Mon, Dec 24, 2018 at 5:21 PM Karl Heinz Marbaise
wrote:
> Hi Mickael,
>
Hi,
I have to summarize this simply.
> This is no lack of interest in any kind. It is simply a lack of time of
> the committers...cause there is very limited number of committers...
>
I understand that, and I hope I
Am 2018-12-24 um 17:21 schrieb Karl Heinz Marbaise:
Hi Mickael,
I have separated this thread from the previous one cause this will mixup
things...
On 24/12/18 15:40, Mickael Istria wrote:
Hi,
On Sunday, December 23, 2018, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:
If we
45 matches
Mail list logo
