Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

the log4j.properties file Diffs - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1 Diff: https://reviews.apache.org/r/61138/diff/1/ Testing --- Thanks, Arjun Mishra

Review Request 61139: SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

the log4j.properties file Diffs - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1 Diff: https://reviews.apache.org/r/61139/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

default value to WARN to avoid this, unless until specified in the log4j.properties file Diffs - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1 Diff: https://reviews.apache.org/r/61138/diff/1/ Testing --- Thanks, Arjun Mishra

Review Request 61141: SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

the log4j.properties file Diffs - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1 Diff: https://reviews.apache.org/r/61141/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/#review181477 --- On July 26, 2017, 2:44 p.m., Arjun Mishra wrote: > > --- >

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

Alexander Kolbasov's feedback. This fix will be handled by SENTRY-1868 Thanks, Arjun Mishra

Review Request 61823: SENTRY-1896 - Optimize retrieving roles for groups

entry/provider/db/service/persistent/SentryStore.java d7acaea7c Diff: https://reviews.apache.org/r/61823/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 61823: SENTRY-1896 - Optimize retrieving roles for groups

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61823/#review183540 ------- On Aug. 22, 2017, 9:58 p.m., Arjun Mishra wrote: > > --

Re: Review Request 61823: SENTRY-1896 - Optimize retrieving roles for groups

problem is some of the test cases were failing when there were many roles. I think Derby doesn't handle multiple ||'s properly - Arjun --- This is an automatically generated e-mail. To reply, visit: https://re

Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

entry/provider/db/service/persistent/SentryStore.java d7acaea7c Diff: https://reviews.apache.org/r/61863/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

--- On Aug. 23, 2017, 9:24 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61863/ >

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

dition was checked at the beginning of this function. It won't > > happen here. You are right. - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#revie

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

entry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java d7acaea7c Diff: https://reviews.apache.org/r/61863/diff/2/ Changes: https://reviews.apache.org/r/61863/diff/1-2/ Testing --- Thanks, Arjun Mishra

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

> > > > this condition was checked at the beginning of this function. It won't > > happen here. > > Arjun Mishra wrote: > You are right. Actually we do have to do a NULL check since this method is

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

https://reviews.apache.org/r/61863/diff/3/ Changes: https://reviews.apache.org/r/61863/diff/2-3/ Testing --- Thanks, Arjun Mishra

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

jdo.JDOUserException: JDOQL query contains the identifier "group", yet this is a keyword. The query is invalid." - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#review184334 ---

Review Request 62131: Sentry should not store paths outside of the prefix

Description --- Changed the parameter being passed in to true Diffs - sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java 1762ee5fd Diff: https://reviews.apache.org/r/62131/diff/1/ Testing --- Thanks, Arjun Mishra

Review Request 62192: SENTRY-1932: Improve logging for HMSPath

log information more clearly and log at DEBUG level. Diffs - sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java 5a982637d Diff: https://reviews.apache.org/r/62192/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

org/r/62192/diff/2/ Changes: https://reviews.apache.org/r/62192/diff/1-2/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

Diff: https://reviews.apache.org/r/62192/diff/3/ Changes: https://reviews.apache.org/r/62192/diff/2-3/ Testing --- Thanks, Arjun Mishra

Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

/SentryPlugin.java 1318082d3 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b600487dc Diff: https://reviews.apache.org/r/62221/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

hrift/HMSFollower.java b600487dc Diff: https://reviews.apache.org/r/62221/diff/2/ Changes: https://reviews.apache.org/r/62221/diff/1-2/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

--------- On Sept. 11, 2017, 6:56 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62221/ >

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

4line328> > > > > We want a message like this printed when it is the first time > > HMSFollower ran through the entire operation after the clean restart of > > server. > > Arjun Mishra wrote: > I added "LOGGER.debug("HMSFollower is connected to

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

er-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b600487dc Diff: https://reviews.apache.org/r/62221/diff/3/ Changes: https://reviews.apache.org/r/62221/diff/2-3/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

1318082d3 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597d Diff: https://reviews.apache.org/r/62221/diff/4/ Changes: https://reviews.apache.org/r/62221/diff/3-4/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62261/#review185288 --- Ship it! Ship It! - Arjun Mishra On Sept. 13, 2017, 3:49

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

sting --- Thanks, Arjun Mishra

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

nce becomes the leader - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185309 --- On Sept. 13, 2017, 2:26 p.m., A

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

ted e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185309 ------- On Sept. 13, 2017, 2:26 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185309 ------- On Sept. 13, 2017, 2:26 p.m., Arjun Mishra wrote: > > -

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

: https://reviews.apache.org/r/62221/diff/6/ Changes: https://reviews.apache.org/r/62221/diff/5-6/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

: https://reviews.apache.org/r/62221/diff/7/ Changes: https://reviews.apache.org/r/62221/diff/6-7/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

://reviews.apache.org/r/62221/diff/7-8/ Testing --- Thanks, Arjun Mishra

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

lly generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185327 --- On Sept. 13, 2017, 6:42 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

://reviews.apache.org/r/62221/diff/8-9/ Testing --- File Attachments (updated) SENTRY-1938.07.patch https://reviews.apache.org/media/uploaded/files/2017/09/13/2f4d17ae-ce15-4b21-b2e0-2e53b4203ac7__SENTRY-1938.07.patch Thanks, Arjun Mishra

Re: Arjun Mishra - New Apache Sentry Committer

gt;> sergio.p...@cloudera.com.invalid> wrote: > >>> > >>>> Congrats Arjun !! > >>>> > >>>> On Wed, Jul 11, 2018 at 8:29 PM Xinran Yu > >>> wrote: > >>>> > >>>>> Congratulations Arjun! > >>&

Re: Congratulations to Na Li - new Apache Sentry PMC member

Congratulations Lina!! On Fri, Dec 14, 2018 at 7:49 AM Sergio Pena wrote: > Congrats Na Li! > > - Sergio > > On Fri, Dec 14, 2018 at 2:17 AM Alex Kolbasov wrote: > > > We have a new Apache Sentry PMC member - Na Li - Congratulations! > > > > - Alex Kolbasov > > > -- Arjun

Review Request 60752: SENTRY-1831 - The MetastorePlugin SyncTask is leaking connection threads when read timed out issues are thrown

threads by resetting the connection when an error occurs. Diffs - sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java 7a21871b8 Diff: https://reviews.apache.org/r/60752/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 60752: SENTRY-1831 - The MetastorePlugin SyncTask is leaking connection threads when read timed out issues are thrown

: https://reviews.apache.org/r/60752/#review180204 ------- On July 10, 2017, 7:57 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-

Review Request 60843: SENTRY-1827 Minimize TPathsDump thrift message used in HDFS sync - Adding change to sentry-ha-redesign branch

UpdateableAuthzPermissions.java 89a3297d4 sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java 2426b4079 Diff: https://reviews.apache.org/r/60843/diff/1/ Testing --- Thanks, Arjun Mishra

Re: Review Request 60843: SENTRY-1827 Minimize TPathsDump thrift message used in HDFS sync - Adding change to sentry-ha-redesign branch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60843/#review180548 --- Ship it! Ship It! - Arjun Mishra On July 13, 2017, 6:03 p.m

Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

vider-db/pom.xml test -Dtest=TestSentryStore mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestSentryHDFSServiceProcessor mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestImageRetriever.java Thanks, Arjun Mishra

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

rjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review190231 --- On Nov. 6, 2017, 9:52 p.m., Arjun Mishra wrote: > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

line2453> > > > > In the original test code all paths were absolute, i.e starting with > > "/". After your changes, all table paths start with "prefix", which does > > _not_ begin with "/". Why is that? What has changed? If it

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

line2453> > > > > In the original test code all paths were absolute, i.e starting with > > "/". After your changes, all table paths start with "prefix", which does > > _not_ begin with "/". Why is that? What has changed? If it

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

line2453> > > > > In the original test code all paths were absolute, i.e starting with > > "/". After your changes, all table paths start with "prefix", which does > > _not_ begin with "/". Why is that? What has changed? If it

Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

45/diff/1/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore Thanks, Arjun Mishra

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

> > as a contract? It doesn't hurt? - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/#review190428 ---------

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

try-core/sentry-core-common/pom.xml test -Dtest=TestPathUtils Thanks, Arjun Mishra

Re: Review Request 63709: SENTRY-2041: Change Index name in Package.jdo to match index name in SQL

table scripts since it will be redundant? - Arjun Mishra On Nov. 9, 2017, 10:50 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 63881: SENTRY-2040; When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

er-db/pom.xml test Thanks, Arjun Mishra

Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7217dea7a Diff: https://reviews.apache.org/r/63886/diff/1/ Testing --- mvn -f sentry-tests/sentry-tests-hive/pom.xml test -Dtest=TestPrivilegesAtTableScopePart1 Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

vider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java 6ec163b1d Diff: https://reviews.apache.org/r/63881/diff/1/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

isit: https://reviews.apache.org/r/63881/#review191233 ------- On Nov. 16, 2017, 7:30 p.m., Arjun Mishra wrote: > > --- > This is an automatically generate

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

r#splitPath handles NULL String - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/#review191214 --- On Nov. 8, 2017, 3:03 p.

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

d they seem to pass. Did you still want me to add tests? - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/#review191238 ------

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore mvn -f sentry-core/sentry-core-common/pom.xml test -Dtest=TestPathUtils Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

thats a rare case that's why I changed it to INFO - Arjun ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review191242 --

Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

rvice/thrift/HMSFollower.java c4cc91806 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java bbcf09382 Diff: https://reviews.apache.org/r/63993/diff/1/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks,

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

ache.org/r/63993/diff/2/ Changes: https://reviews.apache.org/r/63993/diff/1-2/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

entry-provider-db/pom.xml test Second patch: mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestHMSFollower Thanks, Arjun Mishra

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

-- On Nov. 21, 2017, 5:08 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63975/ > ------- > > (Updated Nov. 21, 20

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

3> > > > > Why do we need an extra boolean Can we just check for currDB == null ? > > Or it isn't null in this case? > > Na Li wrote: > It is not null. The currDB is initialized to be "*" > > Arjun Mishra wrote: > Is it wrong to br

Re: Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/#review191622 --- Ship it! Ship It! - Arjun Mishra On Nov. 21, 2017, 6:34 p.m

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

1/c86539e8-54bd-4b73-8e4d-62512520d4a1__SENTRY-2046.04.patch Thanks, Arjun Mishra

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

11/21/c86539e8-54bd-4b73-8e4d-62512520d4a1__SENTRY-2046.04.patch Thanks, Arjun Mishra

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

it to getCanonicalDb() before entering the for loop - Arjun Mishra On Nov. 21, 2017, 5:08 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

-------- On Nov. 21, 2017, 7:56 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63993/ > --

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191659 --- Ship it! Ship It! - Arjun Mishra On Nov. 21, 2017, 9:27 p.m

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

Diff: https://reviews.apache.org/r/63881/diff/2/ Changes: https://reviews.apache.org/r/63881/diff/1-2/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

r mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestImageRetriever.java Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

or sentry-hms are out of sync. Can you explain in what scenario this will flood the log? - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review191907 --

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review192068 --- On Nov. 27, 2017, 6:03 p.m., Arjun Mishra wrote: > > --

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

-------- On Nov. 27, 2017, 4:39 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63881/ >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

rg/r/63596/diff/2-3/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestSentryHDFSServiceProcessor mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestImageRetriever.java Than

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

entry-provider-db/pom.xml test -Dtest=TestSentryStore mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestSentryHDFSServiceProcessor mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestImageRetriever.java Thanks, Arjun Mishra

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

Dtest=TestSentryHDFSServiceProcessor mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestImageRetriever.java Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

b6 Diff: https://reviews.apache.org/r/63881/diff/3/ Changes: https://reviews.apache.org/r/63881/diff/2-3/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

anges: https://reviews.apache.org/r/63881/diff/3-4/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

object. I will change log level to WARN - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192140 ------

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

eccb40fb6 Diff: https://reviews.apache.org/r/63881/diff/5/ Changes: https://reviews.apache.org/r/63881/diff/4-5/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

anges: https://reviews.apache.org/r/63881/diff/5-6/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

. In which case this would be logged every 0.5 sec - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192387 ---------

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

lient.java eccb40fb6 Diff: https://reviews.apache.org/r/63881/diff/7/ Changes: https://reviews.apache.org/r/63881/diff/6-7/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

https://reviews.apache.org/r/63881/diff/8/ Changes: https://reviews.apache.org/r/63881/diff/7-8/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

b6 Diff: https://reviews.apache.org/r/63881/diff/9/ Changes: https://reviews.apache.org/r/63881/diff/8-9/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

.java eccb40fb6 Diff: https://reviews.apache.org/r/63881/diff/10/ Changes: https://reviews.apache.org/r/63881/diff/9-10/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

vider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java eccb40fb6 Diff: https://reviews.apache.org/r/63881/diff/11/ Changes: https://reviews.apache.org/r/63881/diff/10-11/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

ly, visit: https://reviews.apache.org/r/63881/#review193045 ------- On Dec. 6, 2017, 9:03 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63881/ > ---

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

Dtest=TestSentryHDFSServiceProcessor mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test -Dtest=TestImageRetriever.java Thanks, Arjun Mishra

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

uld create a private class but I don't see a need for that - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review192298 ------

Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

usMonitor.java 360c5a530 Diff: https://reviews.apache.org/r/64545/diff/1/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

/LeaderStatusMonitor.java 360c5a530 Diff: https://reviews.apache.org/r/64545/diff/2/ Changes: https://reviews.apache.org/r/64545/diff/1-2/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

er-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 360c5a530 Diff: https://reviews.apache.org/r/64545/diff/3/ Changes: https://reviews.apache.org/r/64545/diff/2-3/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

tically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review193478 ------- On Dec. 11, 2017, 9:02 p.m., Arjun Mishra wrote: > > --- > This is an autom

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193589 ------- On Dec. 12, 2017, 5:10 p.m., Arjun Mishra wrote: > > --- >

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

ntry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 360c5a530 Diff: https://reviews.apache.org/r/64545/diff/4/ Changes: https://reviews.apache.org/r/64545/diff/3-4/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

/LeaderStatusMonitor.java 360c5a530 Diff: https://reviews.apache.org/r/64545/diff/5/ Changes: https://reviews.apache.org/r/64545/diff/4-5/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

/LeaderStatusMonitor.java 360c5a530 Diff: https://reviews.apache.org/r/64545/diff/6/ Changes: https://reviews.apache.org/r/64545/diff/5-6/ Testing --- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra

  1   2   3   4   5   6   >