/RepoConfigurationConstants.java
12cb93e
Diff: https://reviews.apache.org/r/47674/diff/
Testing
---
Thanks,
Szabolcs Vasas
/java/org/apache/sqoop/repository/RepoConfigurationConstants.java
12cb93e
Diff: https://reviews.apache.org/r/47674/diff/
Testing
---
Thanks,
Szabolcs Vasas
6c75786
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java
0a8139a
core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java
12cb93e
Diff: https://reviews.apache.org/r/47674/diff/
Testing
---
Thanks,
Szabolcs Vasas
/java/org/apache/sqoop/repository/RepoConfigurationConstants.java
12cb93e
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepositoryContextInitialization.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47674/diff/
Testing
---
Thanks,
Szabolcs Vasas
/java/org/apache/sqoop/repository/RepoConfigurationConstants.java
12cb93e
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepositoryContextInitialization.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47674/diff/
Testing
---
Thanks,
Szabolcs Vasas
/java/org/apache/sqoop/repository/RepoConfigurationConstants.java
12cb93e
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepositoryContext.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47674/diff/
Testing
---
Thanks,
Szabolcs Vasas
/AvroTest.java
PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java
1e8c688
Diff: https://reviews.apache.org/r/48097/diff/
Testing
---
Unit test, new integration test is added.
Thanks,
Szabolcs Vasas
on and would probably make the
test cases cleaner.
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java
(line 117)
<https://reviews.apache.org/r/48100/#comment200779>
I guess we could use a before method in this test class as well.
- Szabolcs Vasas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48100/#review136123
---
Ship it!
Ship It!
- Szabolcs Vasas
On June 3, 2016, 9:01
/connector/hdfs/AvroTest.java
PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java
1e8c688
Diff: https://reviews.apache.org/r/48097/diff/
Testing
---
Unit test, new integration test is added.
Thanks,
Szabolcs Vasas
/connector/hdfs/AvroTest.java
PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java
1e8c688
Diff: https://reviews.apache.org/r/48097/diff/
Testing
---
Unit test, new integration test is added.
Thanks,
Szabolcs Vasas
.
Thanks,
Szabolcs Vasas
/DBInputFormat.java 3a8e5d0
Diff: https://reviews.apache.org/r/49192/diff/
Testing
---
We have started an import job on a cluster with a patched Sqoop version and we
have verified that 1 map task now uses only 1 Oracle connection.
Thanks,
Szabolcs Vasas
Sqoop version and we
have verified that 1 map task now uses only 1 Oracle connection.
Thanks,
Szabolcs Vasas
---
We have started an import job on a cluster with a patched Sqoop version and we
have verified that 1 map task now uses only 1 Oracle connection.
Thanks,
Szabolcs Vasas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37251/#review142346
---
Ship it!
Ship It!
- Szabolcs Vasas
On Aug. 8, 2015, 4:09
t; > The tarball (*.tar.gz), signature (*.asc), checksum (*.md5, *.sha):
> > https://dist.apache.org/repos/dist/dev/sqoop/1.99.7_rc0/
> >
> > The tag to be voted upon:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=tag;h=refs/tags/release-1.99.7-r
%7Clin
> >
> > The tarball (*.tar.gz), signature (*.asc), checksum (*.md5, *.sha):
> > https://dist.apache.org/repos/dist/dev/sqoop/1.99.7_rc1/
> >
> > The tag to be voted upon:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=tag;h=refs/tags/release-1.99.7-rc1
> >
> > The KEYS file:
> > http://www.apache.org/dist/sqoop/KEYS
> >
> > Thanks,
> > Abraham Fine
> >
>
--
Szabolcs Vasas
Software Engineer
<http://www.cloudera.com>
Diff: https://reviews.apache.org/r/50566/diff/
Testing
---
New unit test cases are added, also tested manually by executing sqoop import
command.
Thanks,
Szabolcs Vasas
/r/50926/diff/
Testing
---
Unit testing.
Thanks,
Szabolcs Vasas
/TestSqoopJsonUtil.java ce5f4a4
Diff: https://reviews.apache.org/r/50926/diff/
Testing
---
Unit testing.
Thanks,
Szabolcs Vasas
/TestSqoopJsonUtil.java ce5f4a4
Diff: https://reviews.apache.org/r/50926/diff/
Testing
---
Unit testing.
Thanks,
Szabolcs Vasas
tps://reviews.apache.org/r/50987/#comment211916>
It seems the whole file was reformatted and because of this every line
seems to be changed. Can we separate the reformatting to another patch if it is
necessary?
- Szabolcs Vasas
On Aug. 12, 2016, 8:31 a.m., Anna Szonyi
/51180/diff/
Testing
---
Testing Sqoop on a cluster.
Thanks,
Szabolcs Vasas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51159/#review146318
---
Ship it!
Ship It!
- Szabolcs Vasas
On Aug. 17, 2016, 6:30
)
<https://reviews.apache.org/r/50987/#comment212697>
There is a typo in the method name, the t is missing from direct.
- Szabolcs Vasas
On Aug. 19, 2016, 5:15 p.m., Anna Szonyi wrote:
>
> ---
> This is an automatically gener
/diff/
Testing
---
New unit test cases are added.
Thanks,
Szabolcs Vasas
PRE-CREATION
Diff: https://reviews.apache.org/r/52605/diff/
Testing
---
I have added a new MySQL third party test to test the escaping of the double
quote character in the column name and a new Oracle third party test to test
the escaping of the backslash character.
Thanks,
Szabolcs
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52426/#review151030
---
On Sept. 30, 2016, 2:53 p.m., Szabolcs Vasas wrote:
>
> -
/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 37dc004
Diff: https://reviews.apache.org/r/52426/diff/
Testing
---
New unit test cases are added.
Thanks,
Szabolcs Vasas
-Dhbaseprofile=95
Thanks,
Szabolcs Vasas
previous solution was IMHO.
- Szabolcs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52426/#review151787
---
On Oct. 10, 2016, 1:42 p
/ImportToolValidateOptionsTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/50566/diff/
Testing
---
New unit test cases are added, also tested manually by executing sqoop import
command.
Thanks,
Szabolcs Vasas
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52426/#review152486
-------
On Oct. 10, 2016, 1:42 p.m., Szabolcs Vasas wrote:
>
> ---
valid tmpjarsInput we need to be able to
sanitize?
- Szabolcs Vasas
On Oct. 19, 2016, 3:16 p.m., Erzsebet Szilagyi wrote:
>
> ---
> This is an automatically generated e-mail. To r
nceFiles should be
testValidationFailsWithHBaseImportAndAsSequenceFilebecause the test throws an
exception.
- Szabolcs Vasas
On Oct. 24, 2016, 2:03 p.m., Boglarka Egyed wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
, it will be much cleaner than
uncommenting lines in build.xml$
- Szabolcs Vasas
On Oct. 26, 2016, 8:48 a.m., Anna Szonyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
if logging happened! I have just a
hair splitting comment: I can see that org.apache.accumulo.core.util.StringUtil
import is added but it is not actually used in JobBase, we could remove it.
Thanks,
Szabolcs
- Szabolcs Vasas
On Nov. 4, 2016, 8:29 a.m., Erzsebet Szilagyi wrote
the unit test could be also
simpler. What do you think?
- Szabolcs Vasas
On Nov. 4, 2016, 3:52 a.m., Attila Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53374/#review154924
---
Ship it!
Ship It!
- Szabolcs Vasas
On Nov. 3, 2016, 10:17
va/org/apache/sqoop/tool/BaseSqoopTool.java (line 61)
<https://reviews.apache.org/r/53423/#comment225564>
Since the enum is introduced the TRANSCATION_* constants are not needed
anymore I think.
- Szabolcs Vasas
On Nov. 8, 2016, 4:33 p.m., Attila
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53423/#review155594
---
Ship it!
Ship It!
- Szabolcs Vasas
On Nov. 10, 2016, 2:13
gt; >
>> > We appreciate all of Abe's hard work thus far, and look forward to his
>> > continued contributions.
>> >
>> > Best,
>> > Kate
>> >
>> > Links:
>> > 1: https://s.apache.org/MUNt
>>
>>
>
--
Szabolcs Vasas
Software Engineer
<http://www.cloudera.com>
the tip to use yEd for exploring
the dependency graph, it is very useful!
- Szabolcs Vasas
On Nov. 29, 2016, 12:35 p.m., Anna Szonyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://review
)
<https://reviews.apache.org/r/54030/#comment227778>
I think it would be better to use org.apache.commons.lang.StringUtils for
example, jodd.util seems to be a weird package for me.
Hi Anna,
Thank you for fixing the test cases, I have just minor comment to your patch.
- Szabolcs Vasa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54168/#review157279
---
Ship it!
Ship It!
- Szabolcs Vasas
On Nov. 29, 2016, 4:52
t with
testThrowOnErrorWithNotSetSystemProperty and
testThrowOnErrorWithSetSystemProperty test cases.
- Szabolcs Vasas
On Nov. 30, 2016, 2:26 p.m., Boglarka Egyed wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54206/#review157730
---
Ship it!
Ship It!
- Szabolcs Vasas
On Dec. 2, 2016, 10:59
/ExpectedLogMessage.java PRE-CREATION
Diff: https://reviews.apache.org/r/54421/diff/
Testing
---
New integration test and unit test is added.
Thanks,
Szabolcs Vasas
/TestImportTool.java 4136e9f
src/test/org/apache/sqoop/util/ExpectedLogMessage.java PRE-CREATION
Diff: https://reviews.apache.org/r/54421/diff/
Testing
---
New integration test and unit test is added.
Thanks,
Szabolcs Vasas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54429/#review158179
---
Ship it!
Ship It!
- Szabolcs Vasas
On Dec. 6, 2016, 4:44
0>
Same as line 101.
- Szabolcs Vasas
On Dec. 13, 2016, 2:29 p.m., Anna Szonyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
/OracleUpsertOutputFormat.java (line 76)
<https://reviews.apache.org/r/54699/#comment230104>
Can we use a org.apache.hadoop.conf.Configuration instance for accessing
this property instead of the system property?
- Szabolcs Vasas
On Dec. 14, 2016, 10:14 a.m., Anna Szonyi
/TestImportTool.java 4136e9f
src/test/org/apache/sqoop/util/ExpectedLogMessage.java PRE-CREATION
Diff: https://reviews.apache.org/r/54421/diff/
Testing
---
New integration test and unit test is added.
Thanks,
Szabolcs Vasas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54745/#review159309
---
Ship it!
Ship It!
- Szabolcs Vasas
On Dec. 14, 2016, 2 p.m
org/r/54746/#comment230288>
It seems this patch contains the content of SQOOP-3084 too, so if won't
apply if SQOOP-3084 gets committed first. Or do you want to merge to 2 changes?
- Szabolcs Vasas
On Dec. 14, 2016, 3:45 p.m., Anna S
erated e-mail. To reply, visit:
https://reviews.apache.org/r/54421/#review159709
-------
On Dec. 15, 2016, 2:42 p.m., Szabolcs Vasas wrote:
>
> ---
> This is
and unit test is added.
Thanks,
Szabolcs Vasas
ry beginning with various throttling settings,
> > but never made it.
> >
> > Appreciated for any advice.
> > Thanks, Wenxing
> >
>
--
Szabolcs Vasas
Software Engineer
<http://www.cloudera.com>
he column types.
>
> It's quite complex.
>
> Thanks, Wenxing
>
> On Wed, Jan 4, 2017 at 4:24 PM, Szabolcs Vasas wrote:
>
>> Hi Wenxing,
>>
>> I haven't tried this scenario yet but I would be happy to test it on my
>> side. Can you please s
that the patch does not cause a regression.
Thanks,
Szabolcs Vasas
ws.apache.org/r/55466/#comment234702>
This code will not run because the exception is not caught anymore.
- Szabolcs Vasas
On Jan. 12, 2017, 6:32 p.m., Boglarka Egyed wrote:
>
> ---
> This is an automatically generated e-mai
be very good to have a test which ensures that the
patch will not break these old commands.
After that I think we could ship the patch.
Thanks,
Szabolcs
- Szabolcs Vasas
On Jan. 27, 2017, 1:54 p.m., Dmitry Zagorulkin wrote
mapred.map.max.attempts constant was defined
a couple of times, do you think we could easily remove the duplication and use
only one mapreduce.map.max.attempts constant everywhere it is needed? I know it
is not necessarily in scope for your patch, but it is worth considering.
Regards,
Szabolcs
- Szabolcs Vasas
I would be glad if you
could add new test case(s) to prove that your solution works.
Thanks,
Szabolcs
- Szabolcs Vasas
On Feb. 22, 2017, 5:12 a.m., Suraj Nayak wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56949/#review166506
---
Ship it!
Ship It!
- Szabolcs Vasas
On Feb. 23, 2017, 10:52
omment238473>
The test looks good to me, however then I try to run it it fails, because
test.build.data does not seem to be defined on my machine. Can you please fix
it?
- Szabolcs Vasas
On Feb. 9, 2017, 3:39 a.m., Ying Cao wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55466/#review166858
---
Ship it!
Ship It!
- Szabolcs Vasas
On Feb. 25, 2017, 5:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57653/#review169162
---
Ship it!
Ship It!
- Szabolcs Vasas
On March 15, 2017, 5:11
and ran successfully.
Thanks,
Szabolcs Vasas
org/r/57876/diff/1-2/
Testing
---
ant clean test
New unit tests and third party tests are added and ran successfully.
Thanks,
Szabolcs Vasas
ins these profiles, so
> these runs are redundant.
>
> I would also like to propose the creation of a pre-commit hook for Sqoop
> (like the existing one for Sqoop2).
>
> Please let me know if you have any objections.
>
> Thanks,
> Anna
>
--
Szabolcs Vasas
Software Engineer
<http://www.cloudera.com>
org/apache/sqoop/orm/TestCompilationManager.java PRE-CREATION
Diff: https://reviews.apache.org/r/57876/diff/3/
Changes: https://reviews.apache.org/r/57876/diff/2-3/
Testing
---
ant clean test
New unit tests and third party tests are added and ran successfully.
Thanks,
Szabolcs Vasas
tch! I will create the new feature request and
link it to SQOOP-3159.
Szabolcs
- Szabolcs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57876/#review170141
-----
- Szabolcs Vasas
On March 29, 2017, 6:43 a.m., hu xiaodong wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55259/#review170541
---
Ship it!
Ship It!
- Szabolcs Vasas
On March 30, 2017, 6:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58295/#review171575
---
Ship it!
Ship It!
- Szabolcs Vasas
On April 10, 2017, 12:47
if
the user overwrites the null string with the input-null-string Sqoop
parameter. You could use this.options.getInNullStringValue() instead of "null"
like in org.apache.sqoop.orm.ClassWriter#parseNullVal method.
- Szabolcs Vasas
On May 6, 2017,
> want
> > trunk to become unstable or introduce "breaking changes" before the
> > proposed 1.4.7 release.
> >
> > Does anyone have any concerns about this?
> >
> > And in general do we have a policy about feature branches for sqoop
> (like a
> > sqoop_kerberos branch, etc.)?
> >
> > Thanks,
> > Anna
> >
>
--
Szabolcs Vasas
Software Engineer
<http://www.cloudera.com>
gt; Thanks,
> Attila
>
> On May 15, 2017 3:15 PM, "Szabolcs Vasas" wrote:
>
> > Hi all,
> >
> > I also like the idea of creating feature branches. As far as I see we
> > cannot create Sqoop epics on issues.apache.org so we could use subtasks
> to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/#review175098
---
Ship it!
Ship It!
- Szabolcs Vasas
On May 15, 2017, 10:51
are used in a query in
org.apache.sqoop.manager.oracle.OraOopOracleQueries#getOracleDataChunksPartition
method which is used from
org.apache.sqoop.manager.oracle.OraOopDataDrivenDBInputFormat#getSplits which
runs during an import.
Regards,
Szabolcs
- Szabolcs Vasas
On May 15, 2017, 10:51 a.m
> On May 16, 2017, 1:59 p.m., Szabolcs Vasas wrote:
> > Hi Michele,
> >
> > The change seems correct to me since these tables are used in a query in
> > org.apache.sqoop.manager.oracle.OraOopOracleQueries#getOracleDataChunksPartition
>
also very good if you could add test coverage. As far as I see
there are some incremental import related test cases in
com.cloudera.sqoop.TestIncrementalImport that could help.
Regards,
Szabolcs
- Szabolcs Vasas
On May 18, 2017, 5:50 p.m., Sandish Kumar HN wrote
> On May 19, 2017, 10:25 a.m., Szabolcs Vasas wrote:
> > Hi Sandish,
> >
> > Thank you for your patch! I wanted to review it in my IDE but I got the
> > following error when I tried to apply it:
> >
> > /Users/szabolcsvasas/Downloads/MergeIncrement
rt thus inherits the new test
cases you added but they fail for some reason in that class. Can you please
take a look at it too?
Thank you for your efforts!
Regards,
Szabolcs
- Szabolcs Vasas
On May 21, 2017, 11:12 a.m., Eric Lin wrote:
>
> --
fore starting even creating the related JIRA tasks, plans,
> the
> > branching, etc. I'd like to collect the inputs from all of you if this
> fits
> > your plan/requirements/etc.
> >
> > Looking forward hearing all of your thoughts, concerns, pros and cons.
> >
> > Best regards,
> > Attila Szabo
> >
>
--
Szabolcs Vasas
Software Engineer
<http://www.cloudera.com>
adding all the test cases!
Regards,
Szabolcs
- Szabolcs Vasas
On May 30, 2017, 9:36 a.m., Eric Lin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
patch.
Thanks,
Szabolcs Vasas
ort-lite.txt a4b5c75
Diff: https://reviews.apache.org/r/59833/diff/1/
Testing
---
I ran SQL server third party tests with MSSQL 2014 and MSSQL 2017 too.
Thanks,
Szabolcs Vasas
---
Executed unit and third party test cases.
Thanks,
Szabolcs Vasas
src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 5872d25
Diff: https://reviews.apache.org/r/59844/diff/1/
Testing
---
Ran unit and third party test cases.
Thanks,
Szabolcs Vasas
/sqoop/testutil/BaseSqoopTestCase.java 6310a39
Diff: https://reviews.apache.org/r/59843/diff/2/
Changes: https://reviews.apache.org/r/59843/diff/1-2/
Testing
---
Executed unit and third party test cases.
Thanks,
Szabolcs Vasas
/diff/1/
Testing
---
Ran third party test cases.
Thanks,
Szabolcs Vasas
https://reviews.apache.org/r/60090/diff/2/
Changes: https://reviews.apache.org/r/60090/diff/1-2/
Testing
---
Ran third party test cases.
Thanks,
Szabolcs Vasas
sqoop/TestExportUsingProcedure.java
68e79f1252a1c0350f15c4f161b303ad412fb15b
Diff: https://reviews.apache.org/r/60090/diff/3/
Changes: https://reviews.apache.org/r/60090/diff/2-3/
Testing
---
Ran third party test cases.
Thanks,
Szabolcs Vasas
-------
On June 15, 2017, 12:43 p.m., Szabolcs Vasas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60090/
> --
oncern so feel free to proceed
> > with the proposed timeline.
> >
> > Thanks,
> > Bogi
> >
> > On Wed, May 31, 2017 at 4:51 AM, Ying Cao
> > wrote:
> >
> >> Hi Attila,
> >>
> >> This is really great, +1 to the idea !
> >>
vg.com/email-signature?utm_medium=email&;
> utm_source=link&utm_campaign=sig-email&utm_content=webmail>
> Virus-free.
> www.avg.com
> <http://www.avg.com/email-signature?utm_medium=email&;
> utm_source=link&utm_campaign=sig-email&utm_content=webmail>
ran unit and third party tests on
my side and all of them was successful.
Regards,
Szabolcs
- Szabolcs Vasas
On June 29, 2017, 10:17 a.m., Zach Berkowitz wrote:
>
> ---
> This is an automatically generated e-mail. To rep
1 - 100 of 733 matches
Mail list logo
