On 21/01/2014 04:14, Konstantin Kolinko wrote:
Hi!
Reviewing the patches for
https://issues.apache.org/bugzilla/show_bug.cgi?id=56029
(r1559555, r1559708, r1559820)
Thanks for the review. I'm really beginning to dislike this code ;)
I'll take a look at the individual issues asap.
As an
https://issues.apache.org/bugzilla/show_bug.cgi?id=56044
Bug ID: 56044
Summary: Extract EL implementation from embedded Jasper into a
separate JAR
Product: Tomcat 7
Version: unspecified
Hardware: PC
OS:
https://issues.apache.org/bugzilla/show_bug.cgi?id=56045
Bug ID: 56045
Summary: Cannot start embedded container without Jasper
Product: Tomcat 7
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
I've been using Git more and more for Tomcat development and was
wondering what folks thought about moving Tomcat to git. This isn't a
formal proposal or a vote, I'm just trying to gather some views.
On the plus side:
- it is much easier to have multiple issues in progress at the
same time and
2014/1/21 Mark Thomas ma...@apache.org
On the down side:
- there is much more potential to mess things up
Yes, I can help with that if you want :)
- cleaning up is potentially more complex
- the disruption of the move - particularly if we want to move to a
single git repo - could be
On 21/01/2014 10:18, Rémy Maucherat wrote:
2014/1/21 Mark Thomas ma...@apache.org
Thoughts?
Risky, but it can be attempted. I'm not very familiar with the
infrastructure used though. git.apache.org is there already, it mirrors
svn, and it is then mirrored again in github ? The repo to do
2014/1/21 Mark Thomas ma...@apache.org
I've been using Git more and more for Tomcat development and was
wondering what folks thought about moving Tomcat to git. This isn't a
formal proposal or a vote, I'm just trying to gather some views.
On the plus side:
- it is much easier to have
Hi all
+1 for Git
About Maven, it will be a very good move also.
There is tons of projects inside ASF using Maven as their build tool.
There is also so many projects using Tomcat artefacts, hosted on
Central, that it will make their life easier if Maven was used has
main build tool for Tomcat.
Hi Rainer,
On Tue, Jan 21, 2014 at 1:01 PM, Rainer Jung rainer.j...@kippdata.dewrote:
On 21.01.2014 10:58, Mark Thomas wrote:
I've been using Git more and more for Tomcat development and was
wondering what folks thought about moving Tomcat to git. This isn't a
formal proposal or a vote,
On 21 January 2014 21:18, Rémy Maucherat r...@apache.org wrote:
2014/1/21 Mark Thomas ma...@apache.org
On the down side:
- there is much more potential to mess things up
Yes, I can help with that if you want :)
- cleaning up is potentially more complex
- the disruption of the move -
On 21/01/2014 12:27, Olivier Lamy wrote:
I wonder if this could improve a bit the modularity of the various
jars we deploy. Especially for the embeded part. (maybe could prevent
issues as: jsp/jasper is mandatory to run embeded mode even if you
don't use it)
The modularity is not the issue
Hi
just a side note about maven from a tomee dev (and big tomcat user ;):
would be great to make it easier to build for anyone but it would
mandate to be useful to restructure tomcat sources to be modular as
well which would be really great IMO!
Romain Manni-Bucau
Twitter: @rmannibucau
Blog:
2014/1/21 Mark Thomas ma...@apache.org
Since we're considering big changes, what about Maven too ? I'll spare
you
the pros and cons.
I still see more cons than pros for moving to Maven.
It (mostly) works now and allows behaving better with bigger projects. IMO
it is unavoidable now.
2014/1/21 Mark Thomas ma...@apache.org:
I've been using Git more and more for Tomcat development and was
wondering what folks thought about moving Tomcat to git. This isn't a
formal proposal or a vote, I'm just trying to gather some views.
On the plus side:
- it is much easier to have
https://issues.apache.org/bugzilla/show_bug.cgi?id=56046
Bug ID: 56046
Summary: org.apache.tomcat.jdbc.pool.XADataSource InitSQL
property
Product: Tomcat 7
Version: 7.0.35
Hardware: All
OS: All
https://issues.apache.org/bugzilla/show_bug.cgi?id=56046
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Component|Connectors |jdbc-pool
On 21 January 2014 23:42, Konstantin Kolinko knst.koli...@gmail.com wrote:
2014/1/21 Mark Thomas ma...@apache.org:
I've been using Git more and more for Tomcat development and was
wondering what folks thought about moving Tomcat to git. This isn't a
formal proposal or a vote, I'm just trying
- Oliver's project to convert Tomcat build to Maven was not a success
I started but this change need a bit support so perso I don't want to
spend time if lack of interest.
it make sense ;(
-
To unsubscribe, e-mail:
Author: markt
Date: Tue Jan 21 14:08:03 2014
New Revision: 1560017
URL: http://svn.apache.org/r1560017
Log:
Further work for
https://issues.apache.org/bugzilla/show_bug.cgi?id=56029
Review from kkolinko
- Fix bug in parsing functions and whitespace
- More efficient resetting of StringBuidler
-
Author: markt
Date: Tue Jan 21 14:09:04 2014
New Revision: 1560019
URL: http://svn.apache.org/r1560019
Log:
Fix line endings
Modified:
tomcat/trunk/test/webapp/bug5/bug56029.jspx (props changed)
Propchange: tomcat/trunk/test/webapp/bug5/bug56029.jspx
Author: markt
Date: Tue Jan 21 14:14:38 2014
New Revision: 1560023
URL: http://svn.apache.org/r1560023
Log:
Further work for https://issues.apache.org/bugzilla/show_bug.cgi?id=56029
Review from kkolinko
- Fix bug in parsing functions and whitespace
- More efficient resetting of StringBuidler
-
Author: markt
Date: Tue Jan 21 14:16:15 2014
New Revision: 1560025
URL: http://svn.apache.org/r1560025
Log:
Another proposal update
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
This vote has been cancelled due to the regression described in
https://issues.apache.org/bugzilla/show_bug.cgi?id=56029#c3
I will tag 6.0.39 just as soon as the fix for BZ 56029 has the necessary
votes in the status file.
Mark
Others have mostly captured the pros and cons, so mine is brief...
On Tue, Jan 21, 2014 at 4:58 AM, Mark Thomas ma...@apache.org wrote:
I've been using Git more and more for Tomcat development and was
wondering what folks thought about moving Tomcat to git. This isn't a
formal proposal or a
Also +1 to separating the git vs svn discussion from the build system
discussion (Maven, Ant, whatever.) (Side note: been using gradle
recently, fun.)
+1 for split
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
https://issues.apache.org/bugzilla/show_bug.cgi?id=56039
esengst...@gmail.com changed:
What|Removed |Added
CC||esengst...@gmail.com
--
2014/1/21 Yoav Shapira yo...@apache.org
Also +1 to separating the git vs svn discussion from the build system
discussion (Maven, Ant, whatever.) (Side note: been using gradle
recently, fun.)
+1
Never used that Gradle yet though.
Rémy
I conducted a little experiment to facilitate testing of load-balancing,
stickyness etc. I wanted to use a single Tomcat instance with multiple
connectors (ports) each of which using a different jvmRoute when
generating sessions for requests coming in via the respective connector.
That allows to
Author: kkolinko
Date: Tue Jan 21 18:43:32 2014
New Revision: 1560136
URL: http://svn.apache.org/r1560136
Log:
Add Jeremy's patch.
These changes were overwritten by a subsequent commit, but they may be needed
to make a clean svn merge.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified:
https://issues.apache.org/bugzilla/show_bug.cgi?id=56032
--- Comment #3 from Kenneth Gendron kenneth.gend...@gmail.com ---
Thank you very much.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To
Author: markt
Date: Tue Jan 21 19:51:26 2014
New Revision: 1560158
URL: http://svn.apache.org/r1560158
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56032
After an IO error sending a WebSocket message, close the connection.
Modified:
Author: markt
Date: Tue Jan 21 19:54:32 2014
New Revision: 1560159
URL: http://svn.apache.org/r1560159
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56032
After an IO error sending a WebSocket message, close the connection.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=56032
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|NEW |RESOLVED
Author: rjung
Date: Tue Jan 21 20:11:49 2014
New Revision: 1560163
URL: http://svn.apache.org/r1560163
Log:
Vote, promote.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
Author: rjung
Revision: 1560163
Modified property: svn:log
Modified: svn:log at Tue Jan 21 20:13:02 2014
--
--- svn:log (original)
+++ svn:log Tue Jan 21 20:13:02 2014
@@ -1 +1 @@
-Vote, promote.
+Vote, comment.
Author: markt
Date: Tue Jan 21 20:15:06 2014
New Revision: 1560165
URL: http://svn.apache.org/r1560165
Log:
Simplify bind and unbind on start
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Tue Jan 21 20:14:33 2014
New Revision: 1560164
URL: http://svn.apache.org/r1560164
Log:
Simplify bind and unbind on stop
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Tue Jan 21 20:56:21 2014
New Revision: 1560177
URL: http://svn.apache.org/r1560177
Log:
Remove unnecessary code
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java
URL:
Author: markt
Date: Tue Jan 21 20:57:30 2014
New Revision: 1560180
URL: http://svn.apache.org/r1560180
Log:
Address review comment and provide a combined patch.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/1701
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build
Author: markt
Date: Tue Jan 21 22:32:24 2014
New Revision: 1560212
URL: http://svn.apache.org/r1560212
Log:
Fix order of magnitude error in the wait time
Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java
Modified:
Author: markt
Date: Tue Jan 21 22:44:17 2014
New Revision: 1560213
URL: http://svn.apache.org/r1560213
Log:
Writes don't timeout currently with BIO
Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java
Modified:
Author: markt
Date: Tue Jan 21 22:45:35 2014
New Revision: 1560214
URL: http://svn.apache.org/r1560214
Log:
Back port unit test fixes / improvements
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5425
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build
Author: kkolinko
Date: Wed Jan 22 02:46:08 2014
New Revision: 1560237
URL: http://svn.apache.org/r1560237
Log:
Merging ELParser changes from trunk, to better align TC7 code with trunk here
(proposed TC6 patch for BZ 56029 already ports these changes to Tomcat 6)
This commit is a merge of
Author: kkolinko
Date: Wed Jan 22 02:55:20 2014
New Revision: 1560238
URL: http://svn.apache.org/r1560238
Log:
Merging ELParser changes from trunk, to better align TC7 code with trunk here
(proposed TC6 patch for BZ 56029 already ports these changes to Tomcat 6)
Merged r1410742 from
Author: kkolinko
Date: Wed Jan 22 02:57:47 2014
New Revision: 1560240
URL: http://svn.apache.org/r1560240
Log:
Merging ELParser changes from trunk, to better align TC7 code with trunk here
(proposed TC6 patch for BZ 56029 already ports these changes to Tomcat 6)
Merged r1560177 from
Author: kkolinko
Date: Wed Jan 22 03:28:04 2014
New Revision: 1560244
URL: http://svn.apache.org/r1560244
Log:
votes
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
2014/1/22 ma...@apache.org:
Author: markt
Date: Tue Jan 21 22:45:35 2014
New Revision: 1560214
URL: http://svn.apache.org/r1560214
Log:
Back port unit test fixes / improvements
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=56050
Bug ID: 56050
Summary: NPE in WebappClassLoader.clearReferencesJdbc on
shutdown
Product: Tomcat 7
Version: 7.0.50
Hardware: PC
OS: Linux
https://issues.apache.org/bugzilla/show_bug.cgi?id=56050
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|NEW |RESOLVED
https://issues.apache.org/bugzilla/show_bug.cgi?id=56050
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
52 matches
Mail list logo
